cuke_linter 0.1.0 → 0.2.0

data/testing/rspec/spec/unit/linters/outline_with_single_example_row_linter_unit_spec.rb

@@ -0,0 +1,231 @@
+require_relative '../../../../../environments/rspec_env'
+
+
+RSpec.describe CukeLinter::OutlineWithSingleExampleRowLinter do
+
+  let(:good_data) do
+    outline_text = 'Scenario Outline:
+                      * a step
+                    Examples:
+                      | param   |
+                      | value 1 |
+                      | value 2 |'
+
+    CukeLinter::ModelFactory.generate_outline_model(source_text: outline_text)
+  end
+
+  let(:bad_data) do
+    outline_text = 'Scenario Outline:
+                      * a step
+                    Examples:
+                      | param   |
+                      | value 1 |'
+
+    CukeLinter::ModelFactory.generate_outline_model(source_text: outline_text)
+  end
+
+
+  it_should_behave_like 'a linter at the unit level'
+
+
+  it 'has a name' do
+    expect(subject.name).to eq('OutlineWithSingleExampleRowLinter')
+  end
+
+  describe 'linting' do
+
+    context 'an outline with only one example row' do
+
+      context 'with only one example set' do
+
+        let(:test_model) do
+          gherkin = 'Scenario Outline:
+                       * a step
+                     Examples:
+                       | param |
+                       | value |'
+
+          CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin)
+        end
+
+        it 'records a problem' do
+          results = subject.lint(test_model)
+
+          expect(results.first[:problem]).to eq('Outline has only one example row')
+        end
+
+      end
+
+      context 'with multiple example sets' do
+
+        let(:test_model) do
+          gherkin = 'Scenario Outline:
+                       * a step
+                     Examples:
+                       | param |
+                     Examples:
+                       | param |
+                       | value |'
+
+          CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin)
+        end
+
+        it 'records a problem' do
+          results = subject.lint(test_model)
+
+          expect(results.first[:problem]).to eq('Outline has only one example row')
+        end
+
+      end
+
+
+      it 'records the location of the problem' do
+        gherkin = 'Scenario Outline:
+                     * a step
+                   Examples:
+                     | param |
+                     | value |'
+
+        model_1 = CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin, parent_file_path: 'path_to_file')
+        model_2 = CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin, parent_file_path: 'path_to_file')
+
+        model_1.source_line = 1
+        model_2.source_line = 3
+
+        results = subject.lint(model_1)
+        expect(results.first[:location]).to eq('path_to_file:1')
+
+        results = subject.lint(model_2)
+        expect(results.first[:location]).to eq('path_to_file:3')
+      end
+
+    end
+
+    context 'an outline with more than one example row' do
+
+      context 'with only one example set' do
+
+        let(:test_model) do
+          gherkin = 'Scenario Outline:
+                       * a step
+                     Examples:
+                       | param   |
+                       | value 1 |
+                       | value 2 |'
+
+          CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin)
+        end
+
+        it 'does not record a problem' do
+          expect(subject.lint(test_model)).to eq([])
+        end
+
+      end
+
+      context 'with multiple example sets' do
+
+        let(:test_model) do
+          gherkin = 'Scenario Outline:
+                       * a step
+                     Examples:
+                       | param   |
+                       | value 1 |
+                     Examples:
+                       | param   |
+                       | value 1 |'
+
+          CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin)
+        end
+
+        it 'does not record a problem' do
+          expect(subject.lint(test_model)).to eq([])
+        end
+
+      end
+
+    end
+
+    context 'an outline with no example rows' do
+
+      context 'because it has no example sets' do
+
+        context 'because its examples are nil' do
+
+          let(:test_model) do
+            model          = CukeLinter::ModelFactory.generate_outline_model
+            model.examples = nil
+
+            model
+          end
+
+          it 'does not record a problem' do
+            expect(subject.lint(test_model)).to eq([])
+          end
+
+        end
+
+        context 'because its examples are empty' do
+          let(:test_model) do
+            model          = CukeLinter::ModelFactory.generate_outline_model
+            model.examples = []
+
+            model
+          end
+
+          it 'does not record a problem' do
+            expect(subject.lint(test_model)).to eq([])
+          end
+
+        end
+
+      end
+
+      context 'with only one example set' do
+
+        let(:test_model) do
+          gherkin = 'Scenario Outline:
+                       * a step
+                     Examples:
+                       | param |'
+
+          CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin)
+        end
+
+        it 'does not record a problem' do
+          expect(subject.lint(test_model)).to eq([])
+        end
+
+      end
+
+      context 'with multiple example sets' do
+
+        let(:test_model) do
+          gherkin = 'Scenario Outline:
+                       * a step
+                     Examples:
+                       | param |
+                     Examples:
+                       | param |'
+
+          CukeLinter::ModelFactory.generate_outline_model(source_text: gherkin)
+        end
+
+        it 'does not record a problem' do
+          expect(subject.lint(test_model)).to eq([])
+        end
+
+      end
+
+    end
+
+    context 'a non-outline model' do
+
+      it 'returns an empty set of results' do
+        results = subject.lint(CukeModeler::Model.new)
+
+        expect(results).to eq([])
+      end
+
+    end
+  end
+end

data/testing/rspec/spec/unit/linters/test_with_too_many_steps_linter_unit_spec.rb

@@ -0,0 +1,156 @@
+require_relative '../../../../../environments/rspec_env'
+
+
+RSpec.describe CukeLinter::TestWithTooManyStepsLinter do
+
+  let(:good_data) do
+    model       = CukeLinter::ModelFactory.generate_scenario_model
+    model.steps = [:step_1]
+
+    model
+  end
+
+  let(:bad_data) do
+    model       = CukeLinter::ModelFactory.generate_scenario_model
+    model.steps = [:step_1,
+                   :step_2,
+                   :step_3,
+                   :step_4,
+                   :step_5,
+                   :step_6,
+                   :step_7,
+                   :step_8,
+                   :step_9,
+                   :step_10,
+                   :step_11]
+
+    model
+  end
+
+
+  it_should_behave_like 'a linter at the unit level'
+
+
+  it 'has a name' do
+    expect(subject.name).to eq('TestWithTooManyStepsLinter')
+  end
+
+  describe 'linting' do
+
+    ['scenario', 'outline'].each do |model_type|
+
+      context "with a #{model_type} that has too many steps" do
+
+        let(:test_model) do
+          model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: 'path_to_file')
+          model.steps = [:step_1,
+                         :step_2,
+                         :step_3,
+                         :step_4,
+                         :step_5,
+                         :step_6,
+                         :step_7,
+                         :step_8,
+                         :step_9,
+                         :step_10,
+                         :step_11]
+
+          model
+        end
+
+        it 'records a problem' do
+          results = subject.lint(test_model)
+
+          expect(results.first[:problem]).to match(/^Test has too many steps. \d+ steps found \(max 10\)/)
+        end
+
+        it 'records the location of the problem' do
+          test_model.source_line = 1
+          results                = subject.lint(test_model)
+          expect(results.first[:location]).to eq('path_to_file:1')
+
+          test_model.source_line = 3
+          results                = subject.lint(test_model)
+          expect(results.first[:location]).to eq('path_to_file:3')
+        end
+
+        it 'includes the number of steps found in the problem record' do
+          step_count = test_model.steps.count
+          results    = subject.lint(test_model)
+          expect(results.first[:problem]).to eq("Test has too many steps. #{step_count} steps found (max 10)")
+
+          test_model.steps << :another_step
+          results = subject.lint(test_model)
+          expect(results.first[:problem]).to eq("Test has too many steps. #{step_count + 1} steps found (max 10)")
+        end
+
+      end
+
+      context "with a #{model_type} that does not have too many steps" do
+
+        context 'because it has fewer than 10 steps' do
+
+          let(:test_model) do
+            model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: 'path_to_file')
+            model.steps = [:step_1]
+
+            model
+          end
+
+          it 'does not record a problem' do
+            expect(subject.lint(test_model)).to eq([])
+          end
+
+        end
+
+        context 'because it has no steps' do
+
+          context 'because its steps are empty' do
+
+            let(:test_model) do
+              model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: 'path_to_file')
+              model.steps = []
+
+              model
+            end
+
+            it 'does not record a problem' do
+              expect(subject.lint(test_model)).to eq([])
+            end
+
+          end
+
+          context 'because its steps are nil' do
+
+            let(:test_model) do
+              model       = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: 'path_to_file')
+              model.steps = nil
+
+              model
+            end
+
+            it 'does not record a problem' do
+              expect(subject.lint(test_model)).to eq([])
+            end
+
+          end
+
+        end
+
+      end
+
+    end
+
+    context 'a non-test model' do
+
+      let(:test_model) { CukeModeler::Model.new }
+
+      it 'returns an empty set of results' do
+        results = subject.lint(test_model)
+
+        expect(results).to eq([])
+      end
+
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cuke_linter
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Eric Kessler
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-02-11 00:00:00.000000000 Z
+date: 2019-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cuke_modeler
@@ -108,6 +108,48 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: colorize
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 description: 
 email:
 - morrow748@gmail.com
@@ -117,6 +159,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".simplecov"
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
@@ -133,12 +176,18 @@ files:
 - exe/cuke_linter
 - lib/cuke_linter.rb
 - lib/cuke_linter/formatters/pretty_formatter.rb
+- lib/cuke_linter/linters/example_without_name_linter.rb
 - lib/cuke_linter/linters/feature_without_scenarios_linter.rb
+- lib/cuke_linter/linters/outline_with_single_example_row_linter.rb
+- lib/cuke_linter/linters/test_with_too_many_steps_linter.rb
 - lib/cuke_linter/version.rb
 - testing/cucumber/features/command_line.feature
 - testing/cucumber/features/formatters/pretty_formatter.feature
 - testing/cucumber/features/linters/default_linters.feature
+- testing/cucumber/features/linters/example_without_name.feature
 - testing/cucumber/features/linters/feature_without_scenarios.feature
+- testing/cucumber/features/linters/outline_with_single_example_row.feature
+- testing/cucumber/features/linters/test_with_too_many_steps.feature
 - testing/cucumber/step_definitions/action_steps.rb
 - testing/cucumber/step_definitions/setup_steps.rb
 - testing/cucumber/step_definitions/verification_steps.rb
@@ -149,13 +198,19 @@ files:
 - testing/rspec/spec/integration/cuke_linter_integration_spec.rb
 - testing/rspec/spec/integration/formatters/formatter_integration_specs.rb
 - testing/rspec/spec/integration/formatters/pretty_formatter_integration_spec.rb
+- testing/rspec/spec/integration/linters/example_without_name_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/feature_without_scenarios_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/linter_integration_specs.rb
+- testing/rspec/spec/integration/linters/outline_with_single_example_row_linter_integration_spec.rb
+- testing/rspec/spec/integration/linters/test_with_too_many_steps_linter_integration_spec.rb
 - testing/rspec/spec/unit/cuke_linter_unit_spec.rb
 - testing/rspec/spec/unit/formatters/formatter_unit_specs.rb
 - testing/rspec/spec/unit/formatters/pretty_formatter_unit_spec.rb
+- testing/rspec/spec/unit/linters/example_without_name_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/feature_without_scenarios_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/linter_unit_specs.rb
+- testing/rspec/spec/unit/linters/outline_with_single_example_row_linter_unit_spec.rb
+- testing/rspec/spec/unit/linters/test_with_too_many_steps_linter_unit_spec.rb
 homepage: https://github.com/enkessler/cuke_linter
 licenses:
 - MIT