cucumber_factory 2.1.0 → 2.4.0

data/lib/cucumber_factory/update_strategy.rb

@@ -0,0 +1,30 @@
+module CucumberFactory
+
+  class UpdateStrategy
+
+    def initialize(record)
+      @record = record
+    end
+
+    def assign_attributes(attributes)
+      active_record_strategy(attributes) ||
+        ruby_object_strategy(attributes)
+    end
+
+    private
+
+    def active_record_strategy(attributes)
+      return unless @record.respond_to?(:save!)
+
+      CucumberFactory::Switcher.assign_attributes(@record, attributes)
+      @record.save!
+    end
+
+    def ruby_object_strategy(attributes)
+      attributes.each do |name, value|
+        @record.send("#{name}=".to_sym, value)
+      end
+    end
+
+  end
+end

data/lib/cucumber_factory/version.rb

@@ -1,3 +1,3 @@
 module CucumberFactory
-  VERSION = '2.1.0'
+  VERSION = '2.4.0'
 end

data/spec/assets/file.txt

@@ -0,0 +1 @@
+This is a test file.

data/spec/assets/file2.txt

@@ -0,0 +1 @@
+This is the second test file.

data/spec/assets/symlink.txt

@@ -0,0 +1 @@
+spec/assets/file.txt

data/spec/cucumber_factory/steps_spec.rb

@@ -111,7 +111,7 @@ describe 'steps provided by cucumber_factory' do
       payment.id.should == 2
     end
 
-    it "should allow to name records and set a belongs_to association to that record by refering to that name" do
+    it "should allow to name records and set a belongs_to association to that record by referring to that name" do
       invoke_cucumber_step('"Some Prequel" is a movie with the title "Before Sunrise"')
       invoke_cucumber_step('there is a movie with the title "Limitless"')
       invoke_cucumber_step('there is a movie with the title "Before Sunset" and the prequel "Some Prequel"')
@@ -120,7 +120,7 @@ describe 'steps provided by cucumber_factory' do
       movie.prequel.should == prequel
     end
 
-    it "should allow to set a belongs_to association to a previously created record by refering to any string attribute of that record" do
+    it "should allow to set a belongs_to association to a previously created record by referring to any string attribute of that record" do
       invoke_cucumber_step('there is a movie with the title "Before Sunrise"')
       invoke_cucumber_step('there is a movie with the title "Limitless"')
       invoke_cucumber_step('there is a movie with the title "Before Sunset" and the prequel "Before Sunrise"')
@@ -129,7 +129,17 @@ describe 'steps provided by cucumber_factory' do
       movie.prequel.should == prequel
     end
 
-    it "should allow to set a belongs_to association to a previously created record by refering to their explicitely set primary keys" do
+    it "should allow to set a belongs_to association to a previously updated record by referring to any string attribute used when updating" do
+      invoke_cucumber_step('there is a movie')
+      invoke_cucumber_step('the movie above has the title "Before Sunrise"')
+      invoke_cucumber_step('there is a movie with the title "Limitless"')
+      invoke_cucumber_step('there is a movie with the title "Before Sunset" and the prequel "Before Sunrise"')
+      movie = Movie.find_by_title!('Before Sunset')
+      prequel = Movie.find_by_title!('Before Sunrise')
+      movie.prequel.should == prequel
+    end
+
+    it "should allow to set a belongs_to association to a previously created record by referring to their explicitely set primary keys" do
       invoke_cucumber_step('there is a movie with the ID 123')
       invoke_cucumber_step('there is a movie with the title "Before Sunset" and the prequel 123')
       movie = Movie.find_by_title!('Before Sunset')
@@ -165,7 +175,10 @@ describe 'steps provided by cucumber_factory' do
     it "should give created_at precedence over id when saying 'above' if the primary key is not numeric" do
       invoke_cucumber_step('there is a uuid user with the name "Jane" and the id "jane"')
       invoke_cucumber_step('there is a uuid user with the name "John" and the id "john"')
-      UuidUser.find_by_name("John").update_attributes!(:created_at => 1.day.ago)
+
+      uuid_user = UuidUser.find_by_name("John")
+      ActiveRecord::VERSION::MAJOR >= 6 ? uuid_user.update!(:created_at => 1.day.ago) : uuid_user.update_attributes!(:created_at => 1.day.ago)
+
       invoke_cucumber_step('there is a movie with the title "Before Sunset" and the uuid reviewer above')
       before_sunset = Movie.find_by_title!("Before Sunset")
       before_sunset.uuid_reviewer.name.should == "Jane"
@@ -174,7 +187,10 @@ describe 'steps provided by cucumber_factory' do
     it "should ignore created_at if the primary key is numeric" do
       invoke_cucumber_step('there is a user with the name "Jane"')
       invoke_cucumber_step('there is a user with the name "John"')
-      User.find_by_name("John").update_attributes!(:created_at => 1.day.ago)
+
+      user = User.find_by_name("John")
+      ActiveRecord::VERSION::MAJOR >= 6 ? user.update!(:created_at => 1.day.ago) : user.update_attributes!(:created_at => 1.day.ago)
+
       invoke_cucumber_step('there is a movie with the title "Before Sunset" and the reviewer above')
       before_sunset = Movie.find_by_title!("Before Sunset")
       before_sunset.reviewer.name.should == "John"
@@ -188,7 +204,10 @@ describe 'steps provided by cucumber_factory' do
 
     it "should reload an object assigned to a belongs_to before assigning" do
       invoke_cucumber_step('"Jane" is a user who is deleted')
-      User.last.update_attributes(:deleted => false)
+
+      user = User.last
+      ActiveRecord::VERSION::MAJOR >= 6 ? user.update!(:deleted => false) : user.update_attributes!(:deleted => false)
+
       proc { invoke_cucumber_step('there is a movie with the title "Before Sunset" and the reviewer "Jane"') }.should_not raise_error
     end
 
@@ -200,6 +219,15 @@ describe 'steps provided by cucumber_factory' do
       user.deleted.should == true
     end
 
+    it "should allow to name records and set a belongs_to association to that record by referring to that name" do
+      invoke_cucumber_step('"Some Prequel" is a movie with the title "Before Sunrise"')
+      invoke_cucumber_step('there is a movie with the title "Limitless"')
+      invoke_cucumber_step('there is a movie with the title "Before Sunset" and the prequel "Some Prequel"')
+      movie = Movie.find_by_title!('Before Sunset')
+      prequel = Movie.find_by_title!('Before Sunrise')
+      movie.prequel.should == prequel
+    end
+
     it "should allow to set positive boolean attributes with 'which' after the attribute list" do
       user = User.new
       User.stub(:new => user)
@@ -259,7 +287,7 @@ describe 'steps provided by cucumber_factory' do
       user.deleted.should == true
     end
 
-    it "should allow to set a has_many association by refering to multiple named records in square brackets" do
+    it "should allow to set a has_many association by referring to multiple named records in square brackets" do
       invoke_cucumber_step('there is a movie with the title "Sunshine"')
       invoke_cucumber_step('there is a movie with the title "Limitless"')
       invoke_cucumber_step('there is a user with the reviewed movies ["Sunshine" and "Limitless"]')
@@ -356,6 +384,88 @@ title: Before Sunrise
       prequel = Movie.find_by_title!('Before Sunrise')
       movie.prequel.should == prequel
     end
+
+    it 'supports named associations with polymorphic associations' do
+      invoke_cucumber_step('"my opera" is an opera')
+      invoke_cucumber_step('there is a movie with the premiere site "my opera"')
+    end
+
+    it 'does not support last record references with polymorphic associations as the target class cannot be guessed' do
+      invoke_cucumber_step('there is an opera')
+      expect {
+        invoke_cucumber_step('there is a movie with the premiere site above')
+      }.to raise_error(CucumberFactory::Factory::Error, 'Cannot set last Movie#premiere_site for polymorphic associations')
+    end
+
+    it 'supports carrierwave uploaders' do
+      invoke_cucumber_step('there is a payment with the attachment file:"spec/assets/file.txt"')
+      payment = Payment.last
+      expect(payment.attachment.file.read).to eq "This is a test file.\n"
+    end
+
+    it 'supports single quote for carrierwave uploaders' do
+      invoke_cucumber_step("there is a payment with the attachment file:'spec/assets/file.txt'")
+      payment = Payment.last
+      expect(payment.attachment.file.read).to eq "This is a test file.\n"
+    end
+
+    it 'is able to read symlinked files' do
+      invoke_cucumber_step("there is a payment with the attachment file:'spec/assets/symlink.txt'")
+      payment = Payment.last
+      expect(payment.attachment.file.read).to eq "This is a test file.\n"
+    end
+
+    it 'supports table syntax for carrierwave uploaders' do
+      invoke_cucumber_step('there is a payment with these attributes:', nil, <<-DATA_TABLE)
+| attachment | file:"spec/assets/file.txt" |
+      DATA_TABLE
+      payment = Payment.last
+      expect(payment.attachment.file.read).to eq "This is a test file.\n"
+    end
+
+    it 'supports doc string syntax for carrierwave uploaders' do
+      invoke_cucumber_step('there is a payment with these attributes:', <<-DOC_STRING)
+attachment: file:"spec/assets/file.txt"
+      DOC_STRING
+      payment = Payment.last
+      payment.save!
+      expect(payment.attachment.file.read).to eq "This is a test file.\n"
+    end
+
+    it 'allows updating a carrierwave attribute' do
+      invoke_cucumber_step('there is a payment with the attachment file:"spec/assets/file.txt"')
+      payment = Payment.last
+      expect(payment.attachment.file.read).to eq "This is a test file.\n"
+      invoke_cucumber_step('the payment above has the attachment file:"spec/assets/file2.txt"')
+      payment.reload
+      expect(payment.attachment.file.read).to eq "This is the second test file.\n"
+    end
+
+    it 'works with nested factories (BUGFIX)' do
+      invoke_cucumber_step('there is a subgenre movie')
+    end
+
+    describe 'references to named records are tracked correctly' do
+      # CucumberFactory keeps track of all created records by their attributes.
+      # For example, if you create a user with the name "Peter" you can reference him later on as "Peter".
+
+      it 'does not overwrite existing references when associating new records with another reference (BUGFIX)' do
+        invoke_cucumber_step('"reviewer" is a user with the id "1"')
+        movie1 = invoke_cucumber_step('there is a movie with the reviewer "reviewer" and the id "2"') # <- should not overwrite the 'reviewer' reference
+        movie2 = invoke_cucumber_step('there is a movie with the reviewer "reviewer" and the id "3"')
+
+        expect(movie1.reviewer_id).to eq(1)
+        expect(movie2.reviewer_id).to eq(1)
+      end
+
+      it 'does not set new references when setting primary keys of an association (BUGFIX)' do
+        movie1 = invoke_cucumber_step('there is a movie with the id "123" and the user id "456"')  # <- should not set a '456' reference
+        movie2 = invoke_cucumber_step('there is a movie with the user id "456"')
+
+        expect(movie1.reviewer_id).to eq(456)
+        expect(movie2.reviewer_id).to eq(456)
+      end
+    end
   end
 
   context 'without FactoryBot' do
@@ -390,6 +500,13 @@ title: Before Sunrise
       obj.attributes[:total].to_s.should == "45.6"
     end
 
+    it "should allow to set file attributes with the file:'path' syntax" do
+      invoke_cucumber_step('there is a plain Ruby class with the file file:"spec/assets/file.txt"')
+      obj = PlainRubyClass.last
+      obj.attributes[:file].should be_a(File)
+      obj.attributes[:file].read.should == "This is a test file.\n"
+    end
+
     it "should allow set an array of strings with square brackets" do
       invoke_cucumber_step('there is a plain Ruby class with the tags ["foo", "bar"] and the list ["bam", "baz"]')
       obj = PlainRubyClass.last
@@ -498,5 +615,54 @@ tags: ["foo", "bar"]
       lambda { invoke_cucumber_step("there is a machinist model with the attribute 'foo' and the ") }.should raise_error(ArgumentError, 'Unable to parse attributes " and the ".')
       lambda { invoke_cucumber_step("there is a machinist model with the attribute 'foo'. the other_attribute 'bar' and the third attribute 'baz'") }.should raise_error(ArgumentError, 'Unable to parse attributes ".".')
     end
+
+    it "should allow to update the last record of a type" do
+      invoke_cucumber_step('there is a user with the name "Bar" and the email "foo@example.com" who is not subscribed')
+      invoke_cucumber_step('the user above has the name "Baz", the email "foobar@example.com", and is subscribed')
+      user = User.last
+      user.name.should == 'Baz'
+      user.email.should == 'foobar@example.com'
+      user.subscribed.should == true
+    end
+
+    it "should be able to update a record with a given name" do
+      invoke_cucumber_step('"Foo" is a user with the name "Bar"')
+      invoke_cucumber_step('the user "Foo" has the email "foo@example.com"')
+      invoke_cucumber_step("the user 'Foo' is subscribed")
+      user = User.last
+      user.name.should == 'Bar'
+      user.email.should == 'foo@example.com'
+      user.subscribed.should == true
+    end
+
+    it "should be able to update a record with a Cucumber table expression" do
+      invoke_cucumber_step('"Foo" is a user with the name "Bar"')
+      invoke_cucumber_step('the user above has these attributes:', nil, <<-DATA_TABLE)
+| name   | Jane |
+| locked | true |
+      DATA_TABLE
+      user = User.last
+      user.name.should == "Jane"
+      user.locked.should == true
+    end
+
+    it "should allow to update a record via additional data table" do
+      invoke_cucumber_step('"Foo" is a user with the name "Bar"')
+      invoke_cucumber_step('the user above has the email "test@invalid.com", is subscribed, and has these attributes:', nil, <<-DATA_TABLE)
+| name | Jane |
+      DATA_TABLE
+      user = User.last
+      user.name.should == "Jane"
+      user.email.should == "test@invalid.com"
+      user.subscribed.should == true
+    end
+
+    it "should allow to update an association" do
+      invoke_cucumber_step('there is a movie with the title "Before Sunrise"')
+      invoke_cucumber_step('there is a user with the name "John"')
+      invoke_cucumber_step('the movie above has the reviewer above')
+      movie = Movie.last
+      movie.reviewer.name.should == "John"
+    end
   end
 end

data/spec/spec_helper.rb

@@ -3,9 +3,12 @@ $: << File.join(File.dirname(__FILE__), "/../../lib" )
 require 'cucumber_factory'
 require 'gemika'
 require 'factory_bot'
+require 'carrierwave'
+require 'carrierwave/orm/activerecord'
 
 ActiveRecord::Base.default_timezone = :local
 
+Dir["#{File.dirname(__FILE__)}/support/uploaders/*.rb"].sort.each {|f| require f}
 Dir["#{File.dirname(__FILE__)}/support/models/*.rb"].sort.each {|f| require f}
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].sort.each {|f| require f}
 Dir["#{File.dirname(__FILE__)}/shared_examples/**/*.rb"].sort.each {|f| require f}

data/spec/support/database.github.yml

@@ -0,0 +1,6 @@
+postgresql:
+  database: cucumber_factory_test
+  host: localhost
+  username: postgres
+  password: postgres
+  port: 5432

data/spec/support/database.rb

@@ -7,6 +7,8 @@ Gemika::Database.new.rewrite_schema! do
     t.integer :reviewer_id
     t.string :uuid_reviewer_id
     t.integer :box_office_result
+    t.string :premiere_site_type
+    t.bigint :premiere_site_id
   end
 
   create_table :users do |t|
@@ -30,6 +32,7 @@ Gemika::Database.new.rewrite_schema! do
   create_table :payments do |t|
     t.text :comment
     t.integer :amount
+    t.string :attachment
   end
 
   create_table :actors do |t|

data/spec/support/database.sample.yml

@@ -1,5 +1,5 @@
-mysql:
+postgres:
   database: cucumber_factory_test
   host: localhost
-  username: root
-  password: secret
+  username: postgres
+  password: postgres

data/spec/support/factories/factories.rb

@@ -25,7 +25,21 @@ FactoryBot.define do
     end
   end
 
-  factory :movie, :class => Movie
+  factory :movie, :class => Movie do
+    transient do
+      user { nil }
+      user_id { nil }
+    end
+
+    after(:build) do |movie, evaluator|
+      movie.reviewer = evaluator.user if evaluator.user
+      movie.reviewer_id = evaluator.user_id if evaluator.user_id
+    end
+
+    trait :parent_movie_trait
+
+    factory :subgenre_movie, traits: [:parent_movie_trait]
+  end
   factory :opera, :class => Opera
   factory :payment, :class => Payment
   factory :uuid_user, :class => UuidUser

data/spec/support/models/movie.rb

@@ -3,6 +3,7 @@ class Movie < ActiveRecord::Base
   belongs_to :prequel, :class_name => "Movie"
   belongs_to :reviewer, :class_name => "User"
   belongs_to :uuid_reviewer, :class_name => "UuidUser"
+  belongs_to :premiere_site, polymorphic: true, required: false
 
   validate do |record|
     record.errors.add(:reviewer, 'may not be deleted') if record.reviewer and record.reviewer.deleted?

data/spec/support/models/opera.rb

@@ -1,3 +1,3 @@
 class Opera < ActiveRecord::Base
-
+  has_many :movies, as: :premiere_site, inverse_of: :premiere_site
 end

data/spec/support/models/payment.rb

@@ -1,8 +1,13 @@
-class Payment < ActiveRecord::Base
-
-  if ActiveRecord::VERSION::MAJOR <= 3
-    # Only the comment is accessible, amount isn't
-    attr_accessible :comment
-  end
-
-end
+class Payment < ActiveRecord::Base
+  class AttachmentUploader < CarrierWave::Uploader::Base
+    storage :file
+  end
+
+  mount_uploader :attachment, AttachmentUploader
+
+  if ActiveRecord::VERSION::MAJOR <= 3
+    # Only the comment is accessible, amount isn't
+    attr_accessible :comment
+  end
+
+end

data/spec/support/uploaders/attachment_uploader.rb

@@ -0,0 +1,3 @@
+class AttachmentUploader < CarrierWave::Uploader::Base
+  storage :file
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cucumber_factory
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.4.0
 platform: ruby
 authors:
 - Henning Koch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-31 00:00:00.000000000 Z
+date: 2021-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber
@@ -73,10 +73,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".rspec"
 - ".ruby-version"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.cucumber-1.3
@@ -87,6 +87,10 @@ files:
 - Gemfile.cucumber-3.0.lock
 - Gemfile.cucumber-3.1
 - Gemfile.cucumber-3.1.lock
+- Gemfile.cucumber-4.1
+- Gemfile.cucumber-4.1.lock
+- Gemfile.cucumber-5.3
+- Gemfile.cucumber-5.3.lock
 - Gemfile.lock
 - LICENSE
 - README.md
@@ -97,14 +101,18 @@ files:
 - lib/cucumber_factory/build_strategy.rb
 - lib/cucumber_factory/factory.rb
 - lib/cucumber_factory/switcher.rb
+- lib/cucumber_factory/update_strategy.rb
 - lib/cucumber_factory/version.rb
+- spec/assets/file.txt
+- spec/assets/file2.txt
+- spec/assets/symlink.txt
 - spec/cucumber_factory/factory/build_strategy_spec.rb
 - spec/cucumber_factory/steps_spec.rb
 - spec/spec_helper.rb
 - spec/support/cucumber_helper.rb
+- spec/support/database.github.yml
 - spec/support/database.rb
 - spec/support/database.sample.yml
-- spec/support/database.travis.yml
 - spec/support/factories/factories.rb
 - spec/support/models/job_offer.rb
 - spec/support/models/machinist_model.rb
@@ -115,6 +123,7 @@ files:
 - spec/support/models/plain_ruby_class.rb
 - spec/support/models/user.rb
 - spec/support/models/uuid_user.rb
+- spec/support/uploaders/attachment_uploader.rb
 homepage: http://github.com/makandra/cucumber_factory
 licenses:
 - MIT
@@ -134,7 +143,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.1.3
 signing_key: 
 specification_version: 4
 summary: Create records from Cucumber features without writing step definitions.