cucumber_analytics 1.4.1 → 1.4.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ODMwNzMzY2IxOTc5ZGE2ODJkZmJiOWYyMTA2YzJmYTJhZmRmMzIyYg==
+    NDkwYTdjMjFkYjI2OWQ4MmM0ZTZiMDBkNmYxYThlYmM0MjE2MmQzMQ==
   data.tar.gz: !binary |-
-    MzIzZjdhMDQ4NDgzOWNjMTJlMGZlYjIwOGI5NTYwNmYwY2VmNGQ0Ng==
+    MWNjMmQ3NTJkY2QyOTk1MmJlZmE5YTMyNDNkOTQxNzUzODcxYjE4NA==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    OTZiODdmMzE4YzI5ZmU2NzhlYjIyYzJiYzYxYjIzZjdkNmFkY2E0YzdhOTMw
-    Yjg3ZjkwYTQxMmQ5NmFkNDc2YjBlYTMxNzgzYzFlNDM3YjU2MDM0YmNlYTQx
-    ZDNhZjQyMGZkMjI3NWI1ZWIxZTk2NjQwNzU1N2FkZTZhMDYxYWE=
+    YTI4ODRhMjE0OGIzOTgxODM1NTdhM2FiOTQ2MmM5M2ZmNDZkOTFjMTZlYWI2
+    NTJmMmFlYzIzY2U2MWJhNDQ4ZjkxNzJhMGNlNmFlZTgxY2E2MzFlM2QyOWQy
+    MWYxZDdmYzg0ZDI5ZGNhMTcyODM4ZmI4OTc2MzQ0NjU4N2IxOTc=
   data.tar.gz: !binary |-
-    N2QyZDg5YTQ0ZDc0ZmNjNzNiYTFmY2JiOGFjYjUwYjlhOGU1M2EyNTQzZjNk
-    ZWU3YmNlYjFjOWJlOGY3NWFiMDM4Yjc5YWIwZmFkZmM4NzBmOWU0NDc2ZDRm
-    MDA1Nzc2ODhmNGM5MDRlNjZlMjY0YWQwZTliMjhiYTRhOWE3MmI=
+    NzhhNDJmYWVmMjE0ZWNjNDdkZTAwMTkxZmQ0MDUwOThiNzNkMGRkYWQ3OTNk
+    YTcxOGZkMGUzMzMwY2MyMDNiYTkyNmViNDdhZWNlZjA5YjM3YjkxMjcwOTM1
+    NWE5YWVkZjU2NDNlZDZkMDgxMDNlMWQ4NzJkZjBkM2RlZGRlNDU=

data/History.rdoc

@@ -1,3 +1,10 @@
+=== Version 1.4.2 / 2014-01-26
+
+* Bug fix: Example#add_row no longer assumes that the key/value pairs in a
+  Hash are ordered. This was causing values in the added row to be assigned
+  to the incorrect parameter when using versions of Ruby before 1.9.x.
+
+
 === Version 1.4.1 / 2013-12-25
 
 * Bug fix: Trailing empty lines are no longer left out of the contents of doc

data/lib/cucumber_analytics/example.rb

@@ -47,7 +47,7 @@ module CucumberAnalytics
           @row_elements << Row.new("|#{row.join('|')}|")
         when row.is_a?(Hash)
           @rows << row.each_value { |value| value.strip! }
-          @row_elements << Row.new("|#{row.values.join('|')}|")
+          @row_elements << Row.new("|#{ordered_row_values(row).join('|')}|")
         else
           raise(ArgumentError, "Can only add row from a Hash or an Array but received #{row.class}")
       end
@@ -122,5 +122,8 @@ module CucumberAnalytics
       end
     end
 
+    def ordered_row_values(row_hash)
+      @parameters.collect { |parameter| row_hash[parameter] }
+    end
   end
 end

data/lib/cucumber_analytics/version.rb

@@ -1,3 +1,3 @@
 module CucumberAnalytics
-  VERSION = '1.4.1'
+  VERSION = '1.4.2'
 end

data/spec/integration/step_integration_spec.rb

@@ -108,7 +108,7 @@ describe 'Step, Integration' do
       expected_output = ['a test step with -parameter 1- ^and@ *parameter 2!!',
                          '|a block|']
 
-      @step.step_text(with_keywords: false).should == expected_output
+      @step.step_text(:with_keywords => false).should == expected_output
     end
 
   end

data/spec/unit/example_unit_spec.rb

@@ -81,7 +81,7 @@ describe 'Example, Unit' do
 
     rows = example.rows
 
-    rows.collect { |row| row.values }.should == [['value1', 'value2'], ['value3', 'value4']]
+    rows.should == [{'param1' => 'value1', 'param2' => 'value2'}, {'param1' => 'value3', 'param2' => 'value4'}]
   end
 
   it 'has row elements - #row_elements' do
@@ -112,7 +112,7 @@ describe 'Example, Unit' do
       new_row = {'param1' => 'value3', 'param2' => 'value4'}
       example.add_row(new_row)
 
-      example.rows.collect { |row| row.values }.should == [['value1', 'value2'], ['value3', 'value4']]
+      example.rows.should == [{'param1' => 'value1', 'param2' => 'value2'}, {'param1' => 'value3', 'param2' => 'value4'}]
       example.row_elements.collect { |row| row.cells }[1..example.row_elements.count].should == [['value1', 'value2'], ['value3', 'value4']]
     end
 
@@ -123,7 +123,7 @@ describe 'Example, Unit' do
       new_row = ['value3', 'value4']
       example.add_row(new_row)
 
-      example.rows.collect { |row| row.values }.should == [['value1', 'value2'], ['value3', 'value4']]
+      example.rows.should == [{'param1' => 'value1', 'param2' => 'value2'}, {'param1' => 'value3', 'param2' => 'value4'}]
       example.row_elements.collect { |row| row.cells }[1..example.row_elements.count].should == [['value1', 'value2'], ['value3', 'value4']]
     end
 
@@ -142,7 +142,7 @@ describe 'Example, Unit' do
       example.add_row(hash_row)
       example.add_row(array_row)
 
-      example.rows.collect { |row| row.values }.should == [['value1', 'value2'], ['value3', 'value4'], ['value5', 'value6']]
+      example.rows.should == [{'param1' => 'value1', 'param2' => 'value2'}, {'param1' => 'value3', 'param2' => 'value4'}, {'param1' => 'value5', 'param2' => 'value6'}]
       example.row_elements.collect { |row| row.cells }[1..example.row_elements.count].should == [['value1', 'value2'], ['value3', 'value4'], ['value5', 'value6']]
     end
   end
@@ -160,7 +160,7 @@ describe 'Example, Unit' do
       old_row = {'param1' => 'value3', 'param2' => 'value4'}
       example.remove_row(old_row)
 
-      example.rows.collect { |row| row.values }.should == [['value1', 'value2']]
+      example.rows.should == [{'param1' => 'value1', 'param2' => 'value2'}]
       example.row_elements.collect { |row| row.cells }[1..example.row_elements.count].should == [['value1', 'value2']]
     end
 
@@ -171,7 +171,7 @@ describe 'Example, Unit' do
       old_row = ['value3', 'value4']
       example.remove_row(old_row)
 
-      example.rows.collect { |row| row.values }.should == [['value1', 'value2']]
+      example.rows.should == [{'param1' => 'value1', 'param2' => 'value2'}]
       example.row_elements.collect { |row| row.cells }[1..example.row_elements.count].should == [['value1', 'value2']]
     end
 
@@ -190,7 +190,7 @@ describe 'Example, Unit' do
       example.remove_row(hash_row)
       example.remove_row(array_row)
 
-      example.rows.collect { |row| row.values }.should == [['value1', 'value2']]
+      example.rows.should == [{'param1' => 'value1', 'param2' => 'value2'}]
       example.row_elements.collect { |row| row.cells }[1..example.row_elements.count].should == [['value1', 'value2']]
     end
   end

data/spec/unit/feature_unit_spec.rb

@@ -28,6 +28,14 @@ describe 'Feature, Unit' do
     @element.name.should == 'test feature'
   end
 
+  it 'will complain about unknown element types' do
+    parsed_element = {'description' => '',
+                      'elements' => [{'keyword' => 'Scenario', 'description' => ''},
+                                     {'keyword' => 'New Type', 'description' => ''}]}
+
+    expect { clazz.new(parsed_element) }.to raise_error(ArgumentError)
+  end
+
   it 'has a background - #background' do
     @feature.should respond_to(:background)
   end

data/spec/unit/step_unit_spec.rb

@@ -210,25 +210,25 @@ describe 'Step, Unit' do
     it 'can provide the step\'s text without the arguments' do
       expected_output = ['Given a test step with -- ^and@ *parameter 2!!']
 
-      @step.step_text(with_arguments: false).should == expected_output
+      @step.step_text(:with_arguments => false).should == expected_output
     end
 
     it 'can determine its arguments based on delimiters' do
       expected_output = ['Given a test step with -parameter 1- ^@ *parameter 2!!']
 
-      @step.step_text(with_arguments: false, left_delimiter: '^', right_delimiter: '@').should == expected_output
+      @step.step_text(:with_arguments => false, :left_delimiter => '^', :right_delimiter => '@').should == expected_output
     end
 
     it 'can use delimiters of varying lengths' do
       expected_output = ['Given a test step with -parameter 1- ^and@ *!!']
 
-      @step.step_text(with_arguments: false, left_delimiter: '*', right_delimiter: '!!').should == expected_output
+      @step.step_text(:with_arguments => false, :left_delimiter => '*', :right_delimiter => '!!').should == expected_output
     end
 
     it 'can handle delimiters with special regular expression characters' do
       expected_output = ['Given a test step with -parameter 1- ^and@ *!!']
 
-      @step.step_text(with_arguments: false, left_delimiter: '*', right_delimiter: '!!').should == expected_output
+      @step.step_text(:with_arguments => false, :left_delimiter => '*', :right_delimiter => '!!').should == expected_output
     end
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cucumber_analytics
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.2
 platform: ruby
 authors:
 - Eric Kessler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-25 00:00:00.000000000 Z
+date: 2014-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin