cucumber 9.0.0 → 9.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b92466073710d2c5abde6889abd9b33ab63e177d7230b997cd9cee4345f08954
-  data.tar.gz: 35f103db8e96aa79682f0334bb7342c69ccc12aeaceac64ee4415d75ece5408d
+  metadata.gz: 313150f1f463d99e105864744641cd87c56e55f5d4d7856a437214a8db79dbdd
+  data.tar.gz: 90cdd041c890ab05108d3951be679f424ae096bc2df09044b26320096074eee3
 SHA512:
-  metadata.gz: 382b18a67b7166a43e6fe44e1182e5f483cf927946e8cf284e1a4313334865340ec1c94b7655045f533180dbc5a8ebcb98484b12ed8d3a373b29a438b26647ff
-  data.tar.gz: fe8af8ff9e2310f606b7200bfe9f1f92a66ed778133eda23d74f02568b52c13b39b7293c68c7f43b406fe189c94b15ff19f9a82be55d26133aa88676ddf6ef12
+  metadata.gz: 76252cc34ed4bc38ba6e7c0cec30d31b5319d14cdc9745f3e589bad8abf4713c95ec27527095b969dfd983f59ecea57f27ef9d119b68f8c032a19143d332d549
+  data.tar.gz: bef2260cd88f77daa139256c03e68b1744849667d71a3a71931d6c57a4c546e437e996ef6e7aed157520d5ff7dc1b86d2c1a1041b9dd9747f20fe53fd61dec2a

data/README.md

@@ -1,6 +1,4 @@
-<p align="center">
-  <img src="./.github/img/cucumber-open-logo.png" alt="Cucumber Open - Supported by Smartbear" width="428" />
-</p>
+<img src="docs/img/cucumber-open-logo.png" alt="Cucumber Open - Supported by Smartbear" width="428" />
 
 # Cucumber
 
@@ -18,9 +16,7 @@ written in plain language, they can be read by anyone on your team. Because they
 read by anyone, you can use them to help improve communication, collaboration and trust on
 your team.
 
-<p align="center">
-  <img src="./.github/img/gherkin-example.png" alt="Cucumber Gherkin Example" width="728" />
-</p>
+<img src="docs/img/gherkin-example.png" alt="Cucumber Gherkin Example" width="728" />
 
 This is the Ruby implementation of Cucumber. Cucumber is also available for [JavaScript](https://github.com/cucumber/cucumber-js),
 [Java](https://github.com/cucumber/cucumber-jvm), and a lot of other languages. You can find a list of implementations here: https://cucumber.io/docs/installation/.
@@ -56,8 +52,7 @@ Later in this document, bundler is considered being used so all commands are usi
 - Ruby 3.0
 - Ruby 2.7
 - TruffleRuby 22.0.0+
-- JRuby (with [some limitations](https://github.com/cucumber/cucumber-ruby/blob/main/docs/jruby-limitations.md))
-  - 9.4
+- JRuby 9.4+ (with [some limitations](https://github.com/cucumber/cucumber-ruby/blob/main/docs/jruby-limitations.md))
 
 ### Ruby on Rails
 
@@ -109,19 +104,20 @@ And a file named `steps.rb` in `features/step_definitions` with:
 ```ruby
 # features/step_definitions/steps.rb
 
-Given("this will pass") do
+Given('this will pass') do
   @this_will_pass = true
 end
 
-Given("this will fail") do
+Given('this will fail') do
   @this_will_pass = false
 end
 
-When("I do an action") do
+When('I do an action') do
+  :no_op
 end
 
 Then("some results should be there") do
-  expect(@this_will_pass)
+  expect(@this_will_pass).to be true
 end
 ```
 
@@ -135,7 +131,7 @@ To execute a single feature file:
 
 To execute a single example, indicates the line of the name of the example:
 
-    $ bundle exec cucumber features/rule.feature:7
+    $ bundle exec cucumber features/rule.feature:5
 
 To summarize the results on the standard output, and writte a HTML report on disk:
 

data/VERSION

@@ -0,0 +1 @@
+9.0.2

data/lib/cucumber/cli/options.rb

@@ -50,13 +50,13 @@ module Cucumber
       FORMAT_HELP = (BUILTIN_FORMATS.keys.sort.map do |key|
         "  #{key}#{' ' * (max - key.length)} : #{BUILTIN_FORMATS[key][1]}"
       end) + FORMAT_HELP_MSG
-      PROFILE_SHORT_FLAG = '-p'.freeze
-      NO_PROFILE_SHORT_FLAG = '-P'.freeze
-      PROFILE_LONG_FLAG = '--profile'.freeze
-      NO_PROFILE_LONG_FLAG = '--no-profile'.freeze
-      FAIL_FAST_FLAG = '--fail-fast'.freeze
-      RETRY_FLAG = '--retry'.freeze
-      RETRY_TOTAL_FLAG = '--retry-total'.freeze
+      PROFILE_SHORT_FLAG = '-p'
+      NO_PROFILE_SHORT_FLAG = '-P'
+      PROFILE_LONG_FLAG = '--profile'
+      NO_PROFILE_LONG_FLAG = '--no-profile'
+      FAIL_FAST_FLAG = '--fail-fast'
+      RETRY_FLAG = '--retry'
+      RETRY_TOTAL_FLAG = '--retry-total'
       OPTIONS_WITH_ARGS = [
         '-r', '--require', '--i18n-keywords', '-f', '--format', '-o',
         '--out', '-t', '--tags', '-n', '--name', '-e', '--exclude',
@@ -64,7 +64,7 @@ module Cucumber
         '-l', '--lines', '--port', '-I', '--snippet-type'
       ].freeze
       ORDER_TYPES = %w[defined random].freeze
-      TAG_LIMIT_MATCHER = /(?<tag_name>@\w+):(?<limit>\d+)/x
+      TAG_LIMIT_MATCHER = /(?<tag_name>@\w+):(?<limit>\d+)/x.freeze
 
       def self.parse(args, out_stream, error_stream, options = {})
         new(out_stream, error_stream, options).parse!(args)

data/lib/cucumber/deprecate.rb

@@ -42,7 +42,7 @@ module Cucumber
 
     module ForDevelopers
       def self.call(_message, _method, remove_after_version)
-        raise "This method is due for removal after version #{remove_after_version}" if Cucumber::VERSION >= remove_after_version
+        raise "This method is due for removal after version #{remove_after_version}" if remove_after_version <= Cucumber::VERSION
       end
     end
 

data/lib/cucumber/errors.rb

@@ -35,7 +35,8 @@ module Cucumber
   # Raised when a step matches 2 or more StepDefinitions
   class Ambiguous < StandardError
     def initialize(step_name, step_definitions, used_guess)
-      message = String.new # rubocop:disable Style/EmptyLiteral
+      # TODO: [LH] - Just use a heredoc here to fix this up
+      message = String.new
       message << "Ambiguous match of \"#{step_name}\":\n\n"
       message << step_definitions.map(&:backtrace_line).join("\n")
       message << "\n\n"

data/lib/cucumber/events/envelope.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber

data/lib/cucumber/events/gherkin_source_parsed.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber

data/lib/cucumber/events/gherkin_source_read.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber

data/lib/cucumber/events/test_case_finished.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber

data/lib/cucumber/events/test_case_started.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber

data/lib/cucumber/events/test_step_finished.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber

data/lib/cucumber/events/test_step_started.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber

data/lib/cucumber/events/undefined_parameter_type.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber

data/lib/cucumber/file_specs.rb

@@ -5,7 +5,7 @@ require 'cucumber/core/test/location'
 
 module Cucumber
   class FileSpecs
-    FILE_COLON_LINE_PATTERN = /^([\w\W]*?)(?::([\d:]+))?$/ # :nodoc:
+    FILE_COLON_LINE_PATTERN = /^([\w\W]*?)(?::([\d:]+))?$/.freeze # :nodoc:
 
     def initialize(file_specs)
       Cucumber.logger.debug("Features:\n")

data/lib/cucumber/formatter/console.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-# rubocop:disable Metrics/ModuleLength
-
 require 'cucumber/formatter/ansicolor'
 require 'cucumber/formatter/duration'
 require 'cucumber/gherkin/i18n'
@@ -48,7 +46,7 @@ module Cucumber
       def format_string(o, status)
         fmt = format_for(status)
         o.to_s.split("\n").map do |line|
-          if Proc == fmt.class
+          if fmt.instance_of?(Proc)
             fmt.call(line)
           else
             fmt % line
@@ -108,7 +106,7 @@ module Cucumber
 
       # http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-talk/10655
       def linebreaks(msg, max)
-        return msg unless max && max > 0
+        return msg unless max.positive?
 
         msg.gsub(/.{1,#{max}}(?:\s|\Z)/) do
           (Regexp.last_match(0) + 5.chr).gsub(/\n\005/, "\n").gsub(/\005/, "\n")
@@ -262,4 +260,3 @@ module Cucumber
     end
   end
 end
-# rubocop:enable Metrics/ModuleLength

data/lib/cucumber/formatter/console_counts.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/formatter/console'
 
 module Cucumber
@@ -30,7 +32,7 @@ module Cucumber
 
       def status_counts(summary)
         counts = Core::Test::Result::TYPES.map { |status| [status, summary.total(status)] }
-        counts = counts.select { |_status, count| count > 0 }
+        counts = counts.select { |_status, count| count.positive? }
         counts = counts.map { |status, count| format_string("#{count} #{status}", status) }
         "(#{counts.join(', ')})" if counts.any?
       end

data/lib/cucumber/formatter/console_issues.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/formatter/console'
 
 module Cucumber

data/lib/cucumber/formatter/errors.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Cucumber
   module Formatter
     class TestCaseUnknownError < StandardError; end

data/lib/cucumber/formatter/html.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/formatter/io'
 require 'cucumber/html_formatter'
 require 'cucumber/formatter/message_builder'

data/lib/cucumber/formatter/http_io.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'net/http'
 require 'tempfile'
 require 'shellwords'

data/lib/cucumber/formatter/message_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'base64'
 require 'cucumber/formatter/backtrace_filter'
 require 'cucumber/formatter/query/hook_by_test_step'

data/lib/cucumber/formatter/pretty.rb

@@ -19,7 +19,7 @@ module Cucumber
     #
     # If the output is STDOUT (and not a file), there are bright colours to watch too.
     #
-    class Pretty # rubocop:disable Metrics/ClassLength
+    class Pretty
       include FileUtils
       include Console
       include Io

data/lib/cucumber/formatter/publish_banner_printer.rb

@@ -15,7 +15,6 @@ module Cucumber
         end
       end
 
-      # rubocop:disable Metrics/MethodLength
       def display_publish_ad(io)
         display_banner(
           [
@@ -59,7 +58,6 @@ module Cucumber
           io
         )
       end
-      # rubocop:enable Metrics/MethodLength
 
       def highlight(text)
         [text, :cyan]

data/lib/cucumber/formatter/query/hook_by_test_step.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/formatter/errors'
 
 module Cucumber

data/lib/cucumber/formatter/query/pickle_by_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/formatter/errors'
 
 module Cucumber

data/lib/cucumber/formatter/query/pickle_step_by_test_step.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/formatter/errors'
 
 module Cucumber

data/lib/cucumber/formatter/query/step_definitions_by_test_step.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/formatter/errors'
 
 module Cucumber

data/lib/cucumber/formatter/query/test_case_started_by_test_case.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/formatter/errors'
 
 module Cucumber

data/lib/cucumber/formatter/unicode.rb

@@ -10,13 +10,13 @@ if Cucumber::WINDOWS
     Cucumber::CODEPAGE = ENV['CUCUMBER_OUTPUT_ENCODING']
   elsif `cmd /c chcp` =~ /(\d+)/
     if [65_000, 65_001].include? Regexp.last_match(1).to_i
-      Cucumber::CODEPAGE = 'UTF-8'.freeze
+      Cucumber::CODEPAGE = 'UTF-8'
       ENV['ANSICON_API'] = 'ruby'
     else
-      Cucumber::CODEPAGE = "cp#{Regexp.last_match(1).to_i}".freeze
+      Cucumber::CODEPAGE = "cp#{Regexp.last_match(1).to_i}"
     end
   else
-    Cucumber::CODEPAGE = 'cp1252'.freeze
+    Cucumber::CODEPAGE = 'cp1252'
     $stderr.puts("WARNING: Couldn't detect your output codepage. Assuming it is 1252. You may have to chcp 1252 or SET CUCUMBER_OUTPUT_ENCODING=cp1252.")
   end
 

data/lib/cucumber/formatter/url_reporter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Cucumber
   module Formatter
     class URLReporter

data/lib/cucumber/gherkin/formatter/ansi_escapes.rb

@@ -67,11 +67,10 @@ module Cucumber
           'tag'       => 'cyan'
         )
 
-        if ENV['GHERKIN_COLORS'] # Example: export GHERKIN_COLORS="passed=red:failed=yellow"
-          ENV['GHERKIN_COLORS'].split(':').each do |pair|
-            a = pair.split('=')
-            ALIASES[a[0]] = a[1]
-          end
+        # Example: export GHERKIN_COLORS="passed=red:failed=yellow"
+        ENV.fetch('GHERKIN_COLORS', '').split(':').each do |pair|
+          rule, colour = pair.split('=')
+          ALIASES[colour] = rule
         end
 
         ALIASES.each_key do |key|

data/lib/cucumber/glue/invoke_in_world.rb

@@ -28,7 +28,7 @@ module Cucumber
           if check_arity && !cucumber_compatible_arity?(args, block)
             world.instance_exec do
               ari = block.arity
-              ari = ari < 0 ? "#{ari.abs - 1}+" : ari
+              ari = ari.negative? ? "#{ari.abs - 1}+" : ari
               s1 = ari == 1 ? '' : 's'
               s2 = args.length == 1 ? '' : 's'
               raise ArityMismatchError, "Your block takes #{ari} argument#{s1}, but the Regexp matched #{args.length} argument#{s2}."

data/lib/cucumber/glue/proto_world.rb

@@ -26,7 +26,7 @@ module Cucumber
       # @example Passing a multiline string
       #   step "the email should contain:", "Dear sir,\nYou've won a prize!\n"
       # @param [String] name The name of the step
-      # @param [String,Cucumber::Test::DocString,Cucumber::Ast::Table] multiline_argument
+      # @param [String, Cucumber::Test::DocString, Cucumber::Ast::Table] multiline_argument
       def step(name, raw_multiline_arg = nil)
         super
       end
@@ -128,7 +128,7 @@ module Cucumber
 
       # Dynamially generate the API module, closuring the dependencies
       def self.for(runtime, language) # rubocop:disable Metrics/MethodLength,Metrics/AbcSize
-        Module.new do # rubocop:disable Metrics/BlockLength
+        Module.new do
           def self.extended(object)
             # wrap the dynamically generated module so that we can document the methods
             # for yardoc, which doesn't like define_method.

data/lib/cucumber/glue/registry_and_more.rb

@@ -29,7 +29,8 @@ module Cucumber
     # Raised if there are 2 or more World blocks.
     class MultipleWorld < StandardError
       def initialize(first_proc, second_proc)
-        message = String.new # rubocop:disable Style/EmptyLiteral
+        # TODO: [LH] - Just use a heredoc here to fix this up
+        message = String.new
         message << "You can only pass a proc to #World once, but it's happening\n"
         message << "in 2 places:\n\n"
         message << Glue.backtrace_line(first_proc, 'World') << "\n"

data/lib/cucumber/glue/snippet.rb

@@ -61,7 +61,8 @@ module Cucumber
         end
 
         def do_block
-          do_block = String.new # rubocop:disable Style/EmptyLiteral
+          # TODO: [LH] - Just use a heredoc here to fix this up
+          do_block = String.new
           do_block << "do#{parameters}\n"
           multiline_argument.append_comment_to(do_block)
           do_block << "  pending # Write code here that turns the phrase above into concrete actions\n"
@@ -95,7 +96,8 @@ module Cucumber
             "#{prefix}#{code_keyword}('#{expr.source}') do#{parameters(expr)}"
           end.join("\n")
 
-          body = String.new # rubocop:disable Style/EmptyLiteral
+          # TODO: [LH] - Just use a heredoc here to fix this up
+          body = String.new
           multiline_argument.append_comment_to(body)
           body << "  pending # Write code here that turns the phrase above into concrete actions\n"
           body << 'end'

data/lib/cucumber/glue/world_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Cucumber
   module Glue
     class WorldFactory

data/lib/cucumber/multiline_argument/data_table/diff_matrices.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Cucumber
   module MultilineArgument
     class DataTable

data/lib/cucumber/multiline_argument/data_table.rb

@@ -506,7 +506,7 @@ module Cucumber
       end
 
       def ensure_table(table_or_array) # :nodoc:
-        return table_or_array if DataTable == table_or_array.class
+        return table_or_array if table_or_array.instance_of?(DataTable)
 
         DataTable.from(table_or_array)
       end
@@ -591,7 +591,7 @@ module Cucumber
         end
 
         def ==(other)
-          SurplusCell == other.class || value == other.value
+          other.class == SurplusCell || value == other.value
         end
 
         def eql?(other)

data/lib/cucumber/platform.rb

@@ -1,27 +1,22 @@
 # frozen_string_literal: true
 
-# Detect the platform we're running on so we can tweak behaviour
-# in various places.
+# Detect the platform we're running on so we can tweak behaviour in various places.
 require 'rbconfig'
 require 'cucumber/core/platform'
 
 module Cucumber
-  unless defined?(Cucumber::VERSION)
-    VERSION       = File.read(File.expand_path('../../VERSION', __dir__)).strip
-    BINARY        = File.expand_path("#{File.dirname(__FILE__)}/../../bin/cucumber")
-    LIBDIR        = File.expand_path("#{File.dirname(__FILE__)}/../../lib")
-    RAILS         = defined?(Rails)
-    RUBY_BINARY   = File.join(RbConfig::CONFIG['bindir'], RbConfig::CONFIG['ruby_install_name'])
-    RUBY          = defined? RUBY_VERSION
+  VERSION       = File.read(File.expand_path('../../VERSION', __dir__)).strip
+  BINARY        = File.expand_path("#{File.dirname(__FILE__)}/../../bin/cucumber")
+  LIBDIR        = File.expand_path("#{File.dirname(__FILE__)}/../../lib")
+  RUBY_BINARY   = File.join(RbConfig::CONFIG['bindir'], RbConfig::CONFIG['ruby_install_name'])
 
-    class << self
-      attr_accessor :use_full_backtrace
+  class << self
+    attr_accessor :use_full_backtrace
 
-      # @private
-      def file_mode(mode, encoding = 'UTF-8')
-        "#{mode}:#{encoding}"
-      end
+    # @private
+    def file_mode(mode, encoding = 'UTF-8')
+      "#{mode}:#{encoding}"
     end
-    self.use_full_backtrace = false
   end
+  self.use_full_backtrace = false
 end

data/lib/cucumber/runtime/meta_message_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/messages'
 require 'cucumber/ci_environment'
 

data/lib/cucumber/runtime.rb

@@ -112,7 +112,7 @@ module Cucumber
 
     def failure?
       if @configuration.wip?
-        summary_report.test_cases.total_passed > 0
+        summary_report.test_cases.total_passed.positive?
       else
         !summary_report.ok?(@configuration.strict)
       end
@@ -150,8 +150,8 @@ module Cucumber
     end
 
     class NormalisedEncodingFile
-      COMMENT_OR_EMPTY_LINE_PATTERN = /^\s*#|^\s*$/ # :nodoc:
-      ENCODING_PATTERN = /^\s*#\s*encoding\s*:\s*([^\s]+)/ # :nodoc:
+      COMMENT_OR_EMPTY_LINE_PATTERN = /^\s*#|^\s*$/.freeze # :nodoc:
+      ENCODING_PATTERN = /^\s*#\s*encoding\s*:\s*([^\s]+)/.freeze # :nodoc:
 
       def self.read(path)
         new(path).read

data/lib/cucumber/step_match.rb

@@ -78,7 +78,7 @@ module Cucumber
 
         replacement = if block_given?
                         yield(group.value)
-                      elsif Proc == format.class
+                      elsif format.instance_of?(Proc)
                         format.call(group.value)
                       else
                         format % group.value

data/lib/cucumber/term/ansicolor.rb

@@ -63,7 +63,7 @@ module Cucumber
 
       # Regular expression that is used to scan for ANSI-sequences while
       # uncoloring strings.
-      COLORED_REGEXP = /\e\[(?:[34][0-7]|[0-9])?m/
+      COLORED_REGEXP = /\e\[(?:[34][0-7]|[0-9])?m/.freeze
 
       @coloring = true
 

data/lib/cucumber/term/banner.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/term/ansicolor'
 
 module Cucumber