cucumber 8.0.0 → 9.2.0

data/lib/cucumber/platform.rb

@@ -1,27 +1,22 @@
 # frozen_string_literal: true
 
-# Detect the platform we're running on so we can tweak behaviour
-# in various places.
+# Detect the platform we're running on so we can tweak behaviour in various places.
 require 'rbconfig'
 require 'cucumber/core/platform'
 
 module Cucumber
-  unless defined?(Cucumber::VERSION)
-    VERSION       = File.read(File.expand_path('version', __dir__)).strip
-    BINARY        = File.expand_path("#{File.dirname(__FILE__)}/../../bin/cucumber")
-    LIBDIR        = File.expand_path("#{File.dirname(__FILE__)}/../../lib")
-    RAILS         = defined?(Rails)
-    RUBY_BINARY   = File.join(RbConfig::CONFIG['bindir'], RbConfig::CONFIG['ruby_install_name'])
-    RUBY          = defined? RUBY_VERSION
+  VERSION       = File.read(File.expand_path('../../VERSION', __dir__)).strip
+  BINARY        = File.expand_path("#{File.dirname(__FILE__)}/../../bin/cucumber")
+  LIBDIR        = File.expand_path("#{File.dirname(__FILE__)}/../../lib")
+  RUBY_BINARY   = File.join(RbConfig::CONFIG['bindir'], RbConfig::CONFIG['ruby_install_name'])
 
-    class << self
-      attr_accessor :use_full_backtrace
+  class << self
+    attr_accessor :use_full_backtrace
 
-      # @private
-      def file_mode(mode, encoding = 'UTF-8')
-        "#{mode}:#{encoding}"
-      end
+    # @private
+    def file_mode(mode, encoding = 'UTF-8')
+      "#{mode}:#{encoding}"
     end
-    self.use_full_backtrace = false
   end
+  self.use_full_backtrace = false
 end

data/lib/cucumber/rake/task.rb

@@ -2,11 +2,7 @@
 
 require 'cucumber/platform'
 require 'cucumber/gherkin/formatter/ansi_escapes'
-begin
-  # Support Rake > 0.8.7
-  require 'rake/dsl_definition'
-rescue LoadError
-end
+require 'rake/dsl_definition'
 
 module Cucumber
   module Rake
@@ -163,7 +159,7 @@ module Cucumber
       end
 
       def runner(_task_args = nil) # :nodoc:
-        cucumber_opts = [(ENV['CUCUMBER_OPTS'] ? ENV['CUCUMBER_OPTS'].split(/\s+/) : nil) || cucumber_opts_with_profile]
+        cucumber_opts = [ENV['CUCUMBER_OPTS']&.split(/\s+/) || cucumber_opts_with_profile]
         return ForkedCucumberRunner.new(libs, binary, cucumber_opts, bundler, feature_files) if fork
 
         InProcessCucumberRunner.new(libs, cucumber_opts, feature_files)

data/lib/cucumber/running_test_case.rb

@@ -50,7 +50,7 @@ module Cucumber
       end
 
       def source_tag_names
-        tags.map &:name
+        tags.map(&:name)
       end
 
       def with_result(result)

data/lib/cucumber/runtime/for_programming_languages.rb

@@ -7,8 +7,7 @@ module Cucumber
   class Runtime
     # This is what a programming language will consider to be a runtime.
     #
-    # It's a thin class that directs the handul of methods needed by the
-    # programming languages to the right place.
+    # It's a thin class that directs the handful of methods needed by the programming languages to the right place
     class ForProgrammingLanguages
       extend Forwardable
 

data/lib/cucumber/runtime/meta_message_builder.rb

@@ -1,16 +1,18 @@
+# frozen_string_literal: true
+
 require 'cucumber/messages'
 require 'cucumber/ci_environment'
 
 module Cucumber
   class Runtime
-    # Builder to instanciate a Cucumber::Messages::Meta message filled-in with
+    # Builder to instantiate a Cucumber::Messages::Meta message filled-in with
     # the runtime meta-data:
     # - protocol version: the version of the Cucumber::Messages protocol
     # - implementation: the name and version of the implementation (e.g. cucumber-ruby 8.0.0)
     # - runtime: the name and version of the runtime (e.g. ruby 3.0.1)
     # - os: the name and version of the operating system (e.g. linux 3.13.0-45-generic)
     # - cpu: the name of the CPU (e.g. x86_64)
-    # - ci: informtion about the CI environment if any, including:
+    # - ci: information about the CI environment if any, including:
     #   - name: the name of the CI environment (e.g. Jenkins)
     #   - url: the URL of the CI environment (e.g. https://ci.example.com)
     #   - build_number: the build number of the CI environment (e.g. 123)

data/lib/cucumber/runtime/user_interface.rb

@@ -41,8 +41,8 @@ module Cucumber
       # be a path to a file, or if it's an image it may also be a Base64 encoded image.
       # The embedded data may or may not be ignored, depending on what kind of formatter(s) are active.
       #
-      def attach(src, media_type)
-        @visitor.attach(src, media_type)
+      def attach(src, media_type, filename)
+        @visitor.attach(src, media_type, filename)
       end
 
       private

data/lib/cucumber/runtime.rb

@@ -112,9 +112,9 @@ module Cucumber
 
     def failure?
       if @configuration.wip?
-        summary_report.test_cases.total_passed > 0
+        summary_report.test_cases.total_passed.positive?
       else
-        !summary_report.ok?(@configuration.strict)
+        !summary_report.ok?(strict: @configuration.strict)
       end
     end
 
@@ -150,8 +150,8 @@ module Cucumber
     end
 
     class NormalisedEncodingFile
-      COMMENT_OR_EMPTY_LINE_PATTERN = /^\s*#|^\s*$/ # :nodoc:
-      ENCODING_PATTERN = /^\s*#\s*encoding\s*:\s*([^\s]+)/ # :nodoc:
+      COMMENT_OR_EMPTY_LINE_PATTERN = /^\s*#|^\s*$/.freeze # :nodoc:
+      ENCODING_PATTERN = /^\s*#\s*encoding\s*:\s*([^\s]+)/.freeze # :nodoc:
 
       def self.read(path)
         new(path).read
@@ -235,7 +235,7 @@ module Cucumber
     end
 
     require 'cucumber/core/test/filters'
-    def filters # rubocop:disable Metrics/AbcSize
+    def filters
       tag_expressions = @configuration.tag_expressions
       name_regexps = @configuration.name_regexps
       tag_limits = @configuration.tag_limits

data/lib/cucumber/step_match.rb

@@ -78,7 +78,7 @@ module Cucumber
 
         replacement = if block_given?
                         yield(group.value)
-                      elsif Proc == format.class
+                      elsif format.instance_of?(Proc)
                         format.call(group.value)
                       else
                         format % group.value

data/lib/cucumber/term/ansicolor.rb

@@ -63,7 +63,7 @@ module Cucumber
 
       # Regular expression that is used to scan for ANSI-sequences while
       # uncoloring strings.
-      COLORED_REGEXP = /\e\[(?:[34][0-7]|[0-9])?m/
+      COLORED_REGEXP = /\e\[(?:[34][0-7]|[0-9])?m/.freeze
 
       @coloring = true
 

data/lib/cucumber/term/banner.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/term/ansicolor'
 
 module Cucumber