cucumber 7.1.0 → 8.0.0.rc.1

data/lib/cucumber/formatter/ansicolor.rb

@@ -3,21 +3,48 @@
 require 'cucumber/platform'
 require 'cucumber/term/ansicolor'
 
-Cucumber::Term::ANSIColor.coloring = false if !STDOUT.tty? && !ENV.key?('AUTOTEST')
+Cucumber::Term::ANSIColor.coloring = false if !$stdout.tty? && !ENV.key?('AUTOTEST')
 
 module Cucumber
   module Formatter
-    # Defines aliases for coloured output. You don't invoke any methods from this
-    # module directly, but you can change the output colours by defining
-    # a <tt>CUCUMBER_COLORS</tt> variable in your shell, very much like how you can
-    # tweak the familiar POSIX command <tt>ls</tt> with
-    # <a href="http://mipsisrisc.com/rambling/2008/06/27/lscolorsls_colors-now-with-linux-support/">$LSCOLORS/$LS_COLORS</a>
+    # This module allows to format cucumber related outputs using ANSI escape sequences.
+    #
+    # For example, it provides a `passed` method which returns the string with
+    # the ANSI escape sequence to format it green per default.
+    #
+    # To use this, include or extend it in your class.
+    #
+    # Example:
+    #
+    #   require 'cucumber/formatter/ansicolor'
+    #
+    #   class MyFormatter
+    #     extend Cucumber::Term::ANSIColor
+    #
+    #     def on_test_step_finished(event)
+    #       $stdout.puts undefined(event.test_step) if event.result.undefined?
+    #       $stdout.puts passed(event.test_step) if event.result.passed?
+    #     end
+    #   end
+    #
+    # This module also allows the user to customize the format of cucumber outputs
+    # using environment variables.
+    #
+    # For instance, if your shell has a black background and a green font (like the
+    # "Homebrew" settings for OS X' Terminal.app), you may want to override passed
+    # steps to be white instead of green.
+    #
+    # Example:
+    #
+    #   export CUCUMBER_COLORS="passed=white,bold:passed_param=white,bold,underline"
     #
     # The colours that you can change are:
     #
     # * <tt>undefined</tt>     - defaults to <tt>yellow</tt>
     # * <tt>pending</tt>       - defaults to <tt>yellow</tt>
     # * <tt>pending_param</tt> - defaults to <tt>yellow,bold</tt>
+    # * <tt>flaky</tt>         - defaults to <tt>yellow</tt>
+    # * <tt>flaky_param</tt>   - defaults to <tt>yellow,bold</tt>
     # * <tt>failed</tt>        - defaults to <tt>red</tt>
     # * <tt>failed_param</tt>  - defaults to <tt>red,bold</tt>
     # * <tt>passed</tt>        - defaults to <tt>green</tt>
@@ -29,26 +56,18 @@ module Cucumber
     # * <tt>comment</tt>       - defaults to <tt>grey</tt>
     # * <tt>tag</tt>           - defaults to <tt>cyan</tt>
     #
-    # For instance, if your shell has a black background and a green font (like the
-    # "Homebrew" settings for OS X' Terminal.app), you may want to override passed
-    # steps to be white instead of green.
-    #
-    # Although not listed, you can also use <tt>grey</tt>.
-    #
-    # Examples: (On Windows, use SET instead of export.)
-    #
-    #   export CUCUMBER_COLORS="passed=white"
-    #   export CUCUMBER_COLORS="passed=white,bold:passed_param=white,bold,underline"
-    #
     # To see what colours and effects are available, just run this in your shell:
     #
-    #   ruby -e "require 'rubygems'; require 'term/ansicolor'; puts Cucumber::Term::ANSIColor.attributes"
+    #   ruby -e "require 'rubygems'; require 'cucumber/term/ansicolor'; puts Cucumber::Term::ANSIColor.attributes"
     #
     module ANSIColor
       include Cucumber::Term::ANSIColor
 
+      # :stopdoc:
       ALIASES = Hash.new do |h, k|
-        h[Regexp.last_match(1)] + ',bold' if k.to_s =~ /(.*)_param/
+        next unless k.to_s =~ /(.*)_param/
+
+        "#{h[Regexp.last_match(1)]},bold"
       end.merge(
         'undefined' => 'yellow',
         'pending'   => 'yellow',
@@ -60,15 +79,22 @@ module Cucumber
         'comment'   => 'grey',
         'tag'       => 'cyan'
       )
+      # :startdoc:
 
-      if ENV['CUCUMBER_COLORS'] # Example: export CUCUMBER_COLORS="passed=red:failed=yellow"
-        ENV['CUCUMBER_COLORS'].split(':').each do |pair|
+      # Apply the custom color scheme
+      #
+      # example:
+      #
+      #   apply_custom_colors('passed=white')
+      def apply_custom_colors(colors)
+        colors.split(':').each do |pair|
           a = pair.split('=')
           ALIASES[a[0]] = a[1]
         end
       end
+      apply_custom_colors(ENV['CUCUMBER_COLORS']) if ENV['CUCUMBER_COLORS']
 
-      # Eval to define the color-named methods required by Term::ANSIColor.
+      # Define the color-named methods required by Term::ANSIColor.
       #
       # Examples:
       #
@@ -80,53 +106,18 @@ module Cucumber
       #     red(bold(string, &proc)) + red
       #   end
       ALIASES.each_key do |method_name|
-        next if method_name =~ /.*_param/
-        code = <<-COLOR
-          def #{method_name}(string=nil, &proc)
-            #{ALIASES[method_name].split(',').join('(') + '(string, &proc' + ')' * ALIASES[method_name].split(',').length}
-          end
-          # This resets the colour to the non-param colour
-          def #{method_name}_param(string=nil, &proc)
-            #{ALIASES[method_name + '_param'].split(',').join('(') + '(string, &proc' + ')' * ALIASES[method_name + '_param'].split(',').length} + #{ALIASES[method_name].split(',').join(' + ')}
-          end
-        COLOR
-        eval(code) # rubocop:disable Security/Eval
-      end
+        next if method_name.end_with?('_param')
 
-      def self.define_grey #:nodoc:
-        gem 'genki-ruby-terminfo'
-        require 'terminfo'
-        case TermInfo.default_object.tigetnum('colors')
-        when 0
-          raise "Your terminal doesn't support colours."
-        when 1
-          ::Cucumber::Term::ANSIColor.coloring = false
-          alias_method :grey, :white
-        when 2..8
-          alias_method :grey, :white # rubocop:disable Lint/DuplicateMethods
-        else
-          define_real_grey
-        end
-      rescue Exception => e # rubocop:disable Lint/RescueException
-        if e.class.name == 'TermInfo::TermInfoError'
-          STDERR.puts '*** WARNING ***'
-          STDERR.puts "You have the genki-ruby-terminfo gem installed, but you haven't set your TERM variable."
-          STDERR.puts 'Try setting it to TERM=xterm-256color to get grey colour in output.'
-          STDERR.puts "\n"
-          alias_method :grey, :white
-        else
-          define_real_grey
+        define_method(method_name) do |text = nil, &proc|
+          apply_styles(ALIASES[method_name], text, &proc)
         end
-      end
 
-      def self.define_real_grey #:nodoc:
-        define_method :grey do |string|
-          ::Cucumber::Term::ANSIColor.coloring? ? "\e[90m#{string}\e[0m" : string
+        define_method("#{method_name}_param") do |text = nil, &proc|
+          apply_styles(ALIASES["#{method_name}_param"], text, &proc) + apply_styles(ALIASES[method_name])
         end
       end
 
-      define_grey
-
+      # :stopdoc:
       def cukes(n)
         ('(::) ' * n).strip
       end
@@ -142,6 +133,15 @@ module Cucumber
       def yellow_cukes(n)
         blink(yellow(cukes(n)))
       end
+      # :startdoc:
+
+      private
+
+      def apply_styles(styles, text = nil, &proc)
+        styles.split(',').reverse.reduce(text) do |result, method_name|
+          send(method_name, result, &proc)
+        end
+      end
     end
   end
 end

data/lib/cucumber/formatter/ast_lookup.rb

@@ -45,11 +45,11 @@ module Cucumber
             break
           end
           break if node.previous_node.nil?
+
           node = node.previous_node
         end
         keyword = dialect.given_keywords.reject { |kw| kw == '* ' }[0] if keyword.nil?
-        keyword = Cucumber::Gherkin::I18n.code_keyword_for(keyword)
-        keyword
+        Cucumber::Gherkin::I18n.code_keyword_for(keyword)
       end
 
       ScenarioSource = Struct.new(:type, :scenario)

data/lib/cucumber/formatter/backtrace_filter.rb

@@ -33,7 +33,7 @@ module Cucumber
       def exception
         return @exception if ::Cucumber.use_full_backtrace
 
-        pwd_pattern = /#{::Regexp.escape(::Dir.pwd)}\//m # rubocop:disable Style/RegexpLiteral
+        pwd_pattern = /#{::Regexp.escape(::Dir.pwd)}\//m
         backtrace = @exception.backtrace.map { |line| line.gsub(pwd_pattern, './') }
 
         filtered = (backtrace || []).reject do |line|

data/lib/cucumber/formatter/console.rb

@@ -34,7 +34,7 @@ module Cucumber
 
       def format_step(keyword, step_match, status, source_indent)
         comment = if source_indent
-                    c = indent(('# ' + step_match.location.to_s), source_indent)
+                    c = indent("# #{step_match.location}", source_indent)
                     format_string(c, :comment)
                   else
                     ''
@@ -109,7 +109,10 @@ module Cucumber
       # http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-talk/10655
       def linebreaks(msg, max)
         return msg unless max && max > 0
-        msg.gsub(/.{1,#{max}}(?:\s|\Z)/) { ($& + 5.chr).gsub(/\n\005/, "\n").gsub(/\005/, "\n") }.rstrip
+
+        msg.gsub(/.{1,#{max}}(?:\s|\Z)/) do
+          (Regexp.last_match(0) + 5.chr).gsub(/\n\005/, "\n").gsub(/\005/, "\n")
+        end.rstrip
       end
 
       def collect_snippet_data(test_step, ast_lookup)
@@ -150,6 +153,7 @@ module Cucumber
 
       def print_passing_wip(config, passed_test_cases, ast_lookup)
         return unless config.wip?
+
         messages = passed_test_cases.map do |test_case|
           scenario_source = ast_lookup.scenario_source(test_case)
           keyword = scenario_source.type == :Scenario ? scenario_source.scenario.keyword : scenario_source.scenario_outline.keyword
@@ -170,6 +174,7 @@ module Cucumber
       def attach(src, media_type)
         return unless media_type == 'text/x.cucumber.log+plain'
         return unless @io
+
         @io.puts
         @io.puts(format_string(src, :tag))
         @io.flush
@@ -177,6 +182,7 @@ module Cucumber
 
       def print_profile_information
         return if @options[:skip_profile_information] || @options[:profiles].nil? || @options[:profiles].empty?
+
         do_print_profile_information(@options[:profiles])
       end
 
@@ -224,6 +230,7 @@ module Cucumber
         key = keys.join('_').to_sym
         fmt = FORMATS[key]
         raise "No format for #{key.inspect}: #{FORMATS.inspect}" if fmt.nil?
+
         fmt
       end
 
@@ -246,6 +253,7 @@ module Cucumber
 
       class SnippetData
         attr_reader :actual_keyword, :step
+
         def initialize(actual_keyword, step)
           @actual_keyword = actual_keyword
           @step = step

data/lib/cucumber/formatter/console_issues.rb

@@ -23,6 +23,7 @@ module Cucumber
 
       def to_s
         return if @issues.empty?
+
         result = Core::Test::Result::TYPES.map { |type| scenario_listing(type, @issues[type]) }
         result.flatten.join("\n")
       end
@@ -35,6 +36,7 @@ module Cucumber
 
       def scenario_listing(type, test_cases)
         return [] if test_cases.empty?
+
         [format_string("#{type_heading(type)} Scenarios:", type)] + test_cases.map do |test_case|
           scenario_source = @ast_lookup.scenario_source(test_case)
           keyword = scenario_source.type == :Scenario ? scenario_source.scenario.keyword : scenario_source.scenario_outline.keyword
@@ -54,7 +56,10 @@ module Cucumber
 
       def profiles_string
         return if @config.custom_profiles.empty?
-        @config.custom_profiles.map { |profile| "-p #{profile}" }.join(' ') + ' '
+
+        profiles = @config.custom_profiles.map { |profile| "-p #{profile}" }.join(' ')
+
+        "#{profiles} "
       end
     end
   end

data/lib/cucumber/formatter/duration_extractor.rb

@@ -4,6 +4,7 @@ module Cucumber
   module Formatter
     class DurationExtractor
       attr_reader :result_duration
+
       def initialize(result)
         @result_duration = 0
         result.describe_to(self)

data/lib/cucumber/formatter/errors.rb

@@ -1,6 +1,7 @@
 module Cucumber
   module Formatter
     class TestCaseUnknownError < StandardError; end
+
     class TestStepUnknownError < StandardError; end
   end
 end

data/lib/cucumber/formatter/fanout.rb

@@ -21,7 +21,7 @@ module Cucumber
       end
 
       def respond_to_missing?(name, include_private = false)
-        recipients.any? { |recipient| recipient.respond_to?(name, include_private) }
+        recipients.any? { |recipient| recipient.respond_to?(name, include_private) } || super(name, include_private)
       end
     end
   end

data/lib/cucumber/formatter/http_io.rb

@@ -35,6 +35,7 @@ module Cucumber
             headers = headers.merge(parse_header(header_arg))
           else
             raise StandardError, "#{options} was not a valid curl command. Can't set url to #{arg} it is already set to #{url}" if url
+
             url = arg
           end
         end
@@ -49,12 +50,14 @@ module Cucumber
 
       def self.remove_arg_for(args, arg)
         return args.shift unless args.empty?
+
         raise StandardError, "Missing argument for #{arg}"
       end
 
       def self.parse_header(header_arg)
         parts = header_arg.split(':', 2)
         raise StandardError, "#{header_arg} was not a valid header" unless parts.length == 2
+
         { parts[0].strip => parts[1].strip }
       end
     end
@@ -76,6 +79,7 @@ module Cucumber
         @reporter.report(response.body)
         @write_io.close
         return if response.is_a?(Net::HTTPSuccess) || response.is_a?(Net::HTTPRedirection)
+
         raise StandardError, "request to #{uri} failed with status #{response.code}"
       end
 
@@ -98,6 +102,7 @@ module Cucumber
         http = build_client(uri, @https_verify_mode)
 
         raise StandardError, "request to #{uri} failed (too many redirections)" if attempt <= 0
+
         req = build_request(
           uri,
           method,
@@ -126,7 +131,7 @@ module Cucumber
       end
 
       def build_request(uri, method, headers)
-        method_class_name = "#{method[0].upcase}#{method[1..-1].downcase}"
+        method_class_name = "#{method[0].upcase}#{method[1..].downcase}"
         req = Net::HTTP.const_get(method_class_name).new(uri)
         headers.each do |header, value|
           req[header] = value

data/lib/cucumber/formatter/ignore_missing_messages.rb

@@ -12,7 +12,7 @@ module Cucumber
       end
 
       def respond_to_missing?(name, include_private = false)
-        @receiver.respond_to?(name, include_private)
+        @receiver.respond_to?(name, include_private) || super(name, include_private)
       end
     end
   end

data/lib/cucumber/formatter/io.rb

@@ -57,19 +57,21 @@ module Cucumber
       end
 
       def url?(path_or_url_or_io)
-        path_or_url_or_io.match(%r{^https?://})
+        path_or_url_or_io.match(/^https?:\/\//)
       end
 
       def ensure_file(path, name)
         raise "You *must* specify --out FILE for the #{name} formatter" unless String == path.class
         raise "I can't write #{name} to a directory - it has to be a file" if File.directory?(path)
         raise "I can't write #{name} to a file in the non-existing directory #{File.dirname(path)}" unless File.directory?(File.dirname(path))
+
         ensure_io(path, nil)
       end
 
       def ensure_dir(path, name)
         raise "You *must* specify --out DIR for the #{name} formatter" unless String == path.class
         raise "I can't write #{name} reports to a file - it has to be a directory" if File.file?(path)
+
         FileUtils.mkdir_p(path) unless File.directory?(path)
         File.absolute_path path
       end

data/lib/cucumber/formatter/json.rb

@@ -68,6 +68,7 @@ module Cucumber
         test_step, result = *event.attributes
         result = result.with_filtered_backtrace(Cucumber::Formatter::BacktraceFilter)
         return if internal_hook?(test_step)
+
         add_match_and_result(test_step, result)
         @any_step_failed = true if result.failed?
       end
@@ -81,7 +82,7 @@ module Cucumber
       end
 
       def on_test_run_finished(_event)
-        @io.write(JSON.generate(@feature_hashes, pretty: true))
+        @io.write(JSON.pretty_generate(@feature_hashes))
       end
 
       def attach(src, mime_type)
@@ -105,7 +106,7 @@ module Cucumber
       end
 
       def first_step_after_background?(test_step)
-        @in_background && test_step.location.lines.max >= @test_case_hash[:line]
+        @in_background && test_step.location.file == @feature_hash[:uri] && test_step.location.lines.max >= @test_case_hash[:line]
       end
 
       def internal_hook?(test_step)
@@ -133,7 +134,7 @@ module Cucumber
         when 'AfterStep hook'
           after_step_hooks
         else
-          raise 'Unknown hook type ' + hook_step.to_s
+          raise "Unknown hook type #{hook_step}"
         end
       end
 
@@ -175,15 +176,15 @@ module Cucumber
           name: test_step.text,
           line: test_step.location.lines.min
         }
-        step_hash[:doc_string] = create_doc_string_hash(step_source.doc_string) unless step_source.doc_string.nil?
+        step_hash[:doc_string] = create_doc_string_hash(step_source.doc_string, test_step.multiline_arg.content) unless step_source.doc_string.nil?
         step_hash[:rows] = create_data_table_value(step_source.data_table) unless step_source.data_table.nil?
         step_hash
       end
 
-      def create_doc_string_hash(doc_string)
+      def create_doc_string_hash(doc_string, doc_string_content)
         content_type = doc_string.media_type || ''
         {
-          value: doc_string.content,
+          value: doc_string_content,
           content_type: content_type,
           line: doc_string.location.line
         }
@@ -259,6 +260,7 @@ module Cucumber
             line: feature.location.line
           }
           return if feature.tags.empty?
+
           @feature_hash[:tags] = create_tags_array_from_hash_array(feature.tags)
         end
 

data/lib/cucumber/formatter/junit.rb

@@ -84,6 +84,7 @@ module Cucumber
         uri = test_case.location.file
         feature = @ast_lookup.gherkin_document(uri).feature
         raise UnNamedFeatureError, uri if feature.name.empty?
+
         @current_feature_data = @features_data[uri]
         @current_feature_data[:uri] = uri unless @current_feature_data[:uri]
         @current_feature_data[:feature] = feature unless @current_feature_data[:feature]
@@ -111,6 +112,7 @@ module Cucumber
         keyword = scenario_source.type == :Scenario ? scenario_source.scenario.keyword : scenario_source.scenario_outline.keyword
         output = "#{keyword}: #{scenario}\n\n"
         return output if result.ok?(@config.strict)
+
         if scenario_source.type == :Scenario
           if @failing_test_step
             if @failing_test_step.hook?
@@ -125,7 +127,7 @@ module Cucumber
         else
           output += "Example row: #{row_name}\n"
         end
-        output + "\nMessage:\n"
+        "#{output}\nMessage:\n"
       end
 
       def build_testcase(result, scenario_designation, output)
@@ -191,7 +193,7 @@ module Cucumber
       end
 
       def basename(feature_file)
-        File.basename(feature_file.gsub(/[\\\/]/, '-'), '.feature') # rubocop:disable Style/RegexpLiteral
+        File.basename(feature_file.gsub(/[\\\/]/, '-'), '.feature')
       end
 
       def write_file(feature_filename, data)
@@ -228,13 +230,14 @@ module Cucumber
       end
 
       def examples_table_row(row)
-        @row_name = '| ' + row.cells.map(&:value).join(' | ') + ' |'
+        @row_name = "| #{row.cells.map(&:value).join(' | ')} |"
         @name_suffix = " (outline example : #{@row_name})"
       end
     end
 
     class ResultBuilder
       attr_reader :test_case_duration
+
       def initialize(result)
         @test_case_duration = 0
         result.describe_to(self)

data/lib/cucumber/formatter/message_builder.rb

@@ -226,10 +226,11 @@ module Cucumber
         output_envelope(message)
       end
 
-      def on_test_run_finished(*)
+      def on_test_run_finished(event)
         message = Cucumber::Messages::Envelope.new(
           test_run_finished: Cucumber::Messages::TestRunFinished.new(
-            timestamp: time_to_timestamp(Time.now)
+            timestamp: time_to_timestamp(Time.now),
+            success: event.success
           )
         )
 

data/lib/cucumber/formatter/pretty.rb

@@ -24,11 +24,9 @@ module Cucumber
       include Console
       include Io
       include Cucumber::Gherkin::Formatter::Escaping
-      attr_reader :config, :options
+      attr_reader :config, :options, :current_feature_uri, :current_scenario_outline, :current_examples, :current_test_case, :in_scenario_outline, :print_background_steps
       private :config, :options
-      attr_reader :current_feature_uri, :current_scenario_outline, :current_examples, :current_test_case
       private :current_feature_uri, :current_scenario_outline, :current_examples, :current_test_case
-      attr_reader :in_scenario_outline, :print_background_steps
       private :in_scenario_outline, :print_background_steps
 
       def initialize(config)
@@ -105,16 +103,19 @@ module Cucumber
 
       def on_test_step_started(event)
         return if event.test_step.hook?
+
         print_step_header(current_test_case) if first_step_after_printing_background_steps?(event.test_step)
       end
 
       def on_test_step_finished(event)
         collect_snippet_data(event.test_step, @ast_lookup) if event.result.undefined?
         return if in_scenario_outline && !options[:expand]
+
         exception_to_be_printed = find_exception_to_be_printed(event.result)
         print_step_data(event.test_step, event.result) if print_step_data?(event, exception_to_be_printed)
         print_step_output
         return unless exception_to_be_printed
+
         print_exception(exception_to_be_printed, event.result.to_sym, 6)
         @exceptions << exception_to_be_printed
       end
@@ -127,6 +128,7 @@ module Cucumber
         else
           exception_to_be_printed = find_exception_to_be_printed(event.result)
           return unless exception_to_be_printed
+
           print_exception(exception_to_be_printed, event.result.to_sym, 6)
           @exceptions << exception_to_be_printed
         end
@@ -140,6 +142,7 @@ module Cucumber
 
       def attach(src, media_type)
         return unless media_type == 'text/x.cucumber.log+plain'
+
         @test_step_output.push src
       end
 
@@ -147,9 +150,11 @@ module Cucumber
 
       def find_exception_to_be_printed(result)
         return nil if result.ok?(options[:strict])
+
         result = result.with_filtered_backtrace(Cucumber::Formatter::BacktraceFilter)
         exception = result.failed? ? result.exception : result
         return nil if @exceptions.include?(exception)
+
         exception
       end
 
@@ -196,6 +201,7 @@ module Cucumber
       def feature_has_background?
         feature_children = gherkin_document.feature.children
         return false if feature_children.empty?
+
         !feature_children.first.background.nil?
       end
 
@@ -239,6 +245,7 @@ module Cucumber
       def first_step_after_printing_background_steps?(test_step)
         return false unless print_background_steps
         return false unless test_step.location.lines.max >= current_test_case.location.lines.max
+
         @print_background_steps = false
         true
       end
@@ -262,7 +269,8 @@ module Cucumber
       def print_comments(up_to_line, indent_amount)
         comments = gherkin_document.comments
         return if comments.empty? || comments.length <= @next_comment_to_be_printed
-        comments[@next_comment_to_be_printed..-1].each do |comment|
+
+        comments[@next_comment_to_be_printed..].each do |comment|
           if comment.location.line <= up_to_line
             @io.puts(indent(format_string(comment.text.strip, :comment), indent_amount))
             @next_comment_to_be_printed += 1
@@ -294,6 +302,7 @@ module Cucumber
 
       def print_description(description)
         return unless description
+
         description.split("\n").each do |line|
           @io.puts(line)
         end
@@ -398,6 +407,7 @@ module Cucumber
           end
           @io.puts
           next if options[:no_multiline]
+
           print_doc_string(step.doc_string.content, :skipped, 6) unless step.doc_string.nil?
           print_data_table(step.data_table, :skipped, 6) unless step.data_table.nil?
         end
@@ -445,7 +455,7 @@ module Cucumber
         language = ::Gherkin::Dialect.for(language_code)
         scenario_keyword = language.scenario_keywords[0]
         row = scenario_source(test_case).row
-        expanded_name = '| ' + row.cells.map(&:value).join(' | ') + ' |'
+        expanded_name = "| #{row.cells.map(&:value).join(' | ')} |"
         @source_indent = calculate_source_indent_for_expanded_test_case(test_case, scenario_keyword, expanded_name)
         @io.puts
         print_keyword_name(scenario_keyword, expanded_name, 6, test_case.location)

data/lib/cucumber/formatter/progress.rb

@@ -58,6 +58,7 @@ module Cucumber
         progress(result.to_sym) if !test_step.hook? || result.failed?
 
         return if test_step.hook?
+
         collect_snippet_data(test_step, @ast_lookup) if result.undefined?
         @pending_step_matches << @matches[test_step.to_s] if result.pending?
         @failed_results << result if result.failed?

data/lib/cucumber/formatter/query/hook_by_test_step.rb

@@ -13,6 +13,7 @@ module Cucumber
 
         def hook_id(test_step)
           return @hook_id_by_test_step_id[test_step.id] if @hook_id_by_test_step_id.key?(test_step.id)
+
           raise TestStepUnknownError, "No hook found for #{test_step.id} }. Known: #{@hook_id_by_test_step_id.keys}"
         end