cucumber 6.0.0 → 8.0.0.rc.1

data/lib/cucumber/formatter/duration_extractor.rb

@@ -4,6 +4,7 @@ module Cucumber
   module Formatter
     class DurationExtractor
       attr_reader :result_duration
+
       def initialize(result)
         @result_duration = 0
         result.describe_to(self)

data/lib/cucumber/formatter/errors.rb

@@ -1,6 +1,7 @@
 module Cucumber
   module Formatter
     class TestCaseUnknownError < StandardError; end
+
     class TestStepUnknownError < StandardError; end
   end
 end

data/lib/cucumber/formatter/fanout.rb

@@ -21,7 +21,7 @@ module Cucumber
       end
 
       def respond_to_missing?(name, include_private = false)
-        recipients.any? { |recipient| recipient.respond_to?(name, include_private) }
+        recipients.any? { |recipient| recipient.respond_to?(name, include_private) } || super(name, include_private)
       end
     end
   end

data/lib/cucumber/formatter/http_io.rb

@@ -35,6 +35,7 @@ module Cucumber
             headers = headers.merge(parse_header(header_arg))
           else
             raise StandardError, "#{options} was not a valid curl command. Can't set url to #{arg} it is already set to #{url}" if url
+
             url = arg
           end
         end
@@ -49,12 +50,14 @@ module Cucumber
 
       def self.remove_arg_for(args, arg)
         return args.shift unless args.empty?
+
         raise StandardError, "Missing argument for #{arg}"
       end
 
       def self.parse_header(header_arg)
         parts = header_arg.split(':', 2)
         raise StandardError, "#{header_arg} was not a valid header" unless parts.length == 2
+
         { parts[0].strip => parts[1].strip }
       end
     end
@@ -76,6 +79,7 @@ module Cucumber
         @reporter.report(response.body)
         @write_io.close
         return if response.is_a?(Net::HTTPSuccess) || response.is_a?(Net::HTTPRedirection)
+
         raise StandardError, "request to #{uri} failed with status #{response.code}"
       end
 
@@ -98,6 +102,7 @@ module Cucumber
         http = build_client(uri, @https_verify_mode)
 
         raise StandardError, "request to #{uri} failed (too many redirections)" if attempt <= 0
+
         req = build_request(
           uri,
           method,
@@ -126,7 +131,7 @@ module Cucumber
       end
 
       def build_request(uri, method, headers)
-        method_class_name = "#{method[0].upcase}#{method[1..-1].downcase}"
+        method_class_name = "#{method[0].upcase}#{method[1..].downcase}"
         req = Net::HTTP.const_get(method_class_name).new(uri)
         headers.each do |header, value|
           req[header] = value

data/lib/cucumber/formatter/ignore_missing_messages.rb

@@ -12,7 +12,7 @@ module Cucumber
       end
 
       def respond_to_missing?(name, include_private = false)
-        @receiver.respond_to?(name, include_private)
+        @receiver.respond_to?(name, include_private) || super(name, include_private)
       end
     end
   end

data/lib/cucumber/formatter/io.rb

@@ -57,19 +57,21 @@ module Cucumber
       end
 
       def url?(path_or_url_or_io)
-        path_or_url_or_io.match(%r{^https?://})
+        path_or_url_or_io.match(/^https?:\/\//)
       end
 
       def ensure_file(path, name)
         raise "You *must* specify --out FILE for the #{name} formatter" unless String == path.class
         raise "I can't write #{name} to a directory - it has to be a file" if File.directory?(path)
         raise "I can't write #{name} to a file in the non-existing directory #{File.dirname(path)}" unless File.directory?(File.dirname(path))
+
         ensure_io(path, nil)
       end
 
       def ensure_dir(path, name)
         raise "You *must* specify --out DIR for the #{name} formatter" unless String == path.class
         raise "I can't write #{name} reports to a file - it has to be a directory" if File.file?(path)
+
         FileUtils.mkdir_p(path) unless File.directory?(path)
         File.absolute_path path
       end

data/lib/cucumber/formatter/json.rb

@@ -5,7 +5,6 @@ require 'base64'
 require 'cucumber/formatter/backtrace_filter'
 require 'cucumber/formatter/io'
 require 'cucumber/formatter/ast_lookup'
-require 'cucumber/deprecate'
 
 module Cucumber
   module Formatter
@@ -14,14 +13,6 @@ module Cucumber
       include Io
 
       def initialize(config)
-        Cucumber::Deprecate::CliOption.deprecate(
-          config.error_stream,
-          '--format=json',
-          "Please use --format=message and stand-alone json-formatter.\n" \
-          'json-formatter homepage: https://github.com/cucumber/cucumber/tree/master/json-formatter#cucumber-json-formatter',
-          '6.0.0'
-        )
-
         @io = ensure_io(config.out_stream, config.error_stream)
         @ast_lookup = AstLookup.new(config)
         @feature_hashes = []
@@ -41,21 +32,23 @@ module Cucumber
           @feature_hashes << @feature_hash
         end
         @test_case_hash = builder.test_case_hash
-        if builder.background?
-          @in_background = true
-          feature_elements << builder.background_hash
-          @element_hash = builder.background_hash
-        else
-          @in_background = false
-          feature_elements << @test_case_hash
-          @element_hash = @test_case_hash
-        end
+
+        @element_hash = nil
+        @element_background_hash = builder.background_hash
+        @in_background = builder.background?
+
         @any_step_failed = false
       end
 
       def on_test_step_started(event)
         test_step = event.test_step
         return if internal_hook?(test_step)
+
+        if @element_hash.nil?
+          @element_hash = create_element_hash(test_step)
+          feature_elements << @element_hash
+        end
+
         if test_step.hook?
           @step_or_hook_hash = {}
           hooks_of_type(test_step) << @step_or_hook_hash
@@ -75,18 +68,21 @@ module Cucumber
         test_step, result = *event.attributes
         result = result.with_filtered_backtrace(Cucumber::Formatter::BacktraceFilter)
         return if internal_hook?(test_step)
+
         add_match_and_result(test_step, result)
         @any_step_failed = true if result.failed?
       end
 
       def on_test_case_finished(event)
+        feature_elements << @test_case_hash if @in_background
+
         _test_case, result = *event.attributes
         result = result.with_filtered_backtrace(Cucumber::Formatter::BacktraceFilter)
         add_failed_around_hook(result) if result.failed? && !@any_step_failed
       end
 
       def on_test_run_finished(_event)
-        @io.write(JSON.generate(@feature_hashes, pretty: true))
+        @io.write(JSON.pretty_generate(@feature_hashes))
       end
 
       def attach(src, mime_type)
@@ -110,7 +106,7 @@ module Cucumber
       end
 
       def first_step_after_background?(test_step)
-        @in_background && test_step.location.lines.max >= @test_case_hash[:line]
+        @in_background && test_step.location.file == @feature_hash[:uri] && test_step.location.lines.max >= @test_case_hash[:line]
       end
 
       def internal_hook?(test_step)
@@ -138,7 +134,7 @@ module Cucumber
         when 'AfterStep hook'
           after_step_hooks
         else
-          raise 'Unknown hook type ' + hook_step.to_s
+          raise "Unknown hook type #{hook_step}"
         end
       end
 
@@ -166,6 +162,13 @@ module Cucumber
         @step_or_hook_hash[:embeddings] ||= []
       end
 
+      def create_element_hash(test_step)
+        return @element_background_hash if @in_background && !first_step_after_background?(test_step)
+
+        @in_background = false
+        @test_case_hash
+      end
+
       def create_step_hash(test_step)
         step_source = @ast_lookup.step_source(test_step).step
         step_hash = {
@@ -173,15 +176,15 @@ module Cucumber
           name: test_step.text,
           line: test_step.location.lines.min
         }
-        step_hash[:doc_string] = create_doc_string_hash(step_source.doc_string) unless step_source.doc_string.nil?
+        step_hash[:doc_string] = create_doc_string_hash(step_source.doc_string, test_step.multiline_arg.content) unless step_source.doc_string.nil?
         step_hash[:rows] = create_data_table_value(step_source.data_table) unless step_source.data_table.nil?
         step_hash
       end
 
-      def create_doc_string_hash(doc_string)
+      def create_doc_string_hash(doc_string, doc_string_content)
         content_type = doc_string.media_type || ''
         {
-          value: doc_string.content,
+          value: doc_string_content,
           content_type: content_type,
           line: doc_string.location.line
         }
@@ -257,6 +260,7 @@ module Cucumber
             line: feature.location.line
           }
           return if feature.tags.empty?
+
           @feature_hash[:tags] = create_tags_array_from_hash_array(feature.tags)
         end
 
@@ -266,7 +270,8 @@ module Cucumber
             name: background.name,
             description: value_or_empty_string(background.description),
             line: background.location.line,
-            type: 'background'
+            type: 'background',
+            steps: []
           }
         end
 
@@ -278,7 +283,8 @@ module Cucumber
             name: test_case.name,
             description: value_or_empty_string(scenario.description),
             line: test_case.location.lines.max,
-            type: 'scenario'
+            type: 'scenario',
+            steps: []
           }
           @test_case_hash[:tags] = create_tags_array_from_tags_array(test_case.tags) unless test_case.tags.empty?
         end

data/lib/cucumber/formatter/junit.rb

@@ -84,6 +84,7 @@ module Cucumber
         uri = test_case.location.file
         feature = @ast_lookup.gherkin_document(uri).feature
         raise UnNamedFeatureError, uri if feature.name.empty?
+
         @current_feature_data = @features_data[uri]
         @current_feature_data[:uri] = uri unless @current_feature_data[:uri]
         @current_feature_data[:feature] = feature unless @current_feature_data[:feature]
@@ -111,6 +112,7 @@ module Cucumber
         keyword = scenario_source.type == :Scenario ? scenario_source.scenario.keyword : scenario_source.scenario_outline.keyword
         output = "#{keyword}: #{scenario}\n\n"
         return output if result.ok?(@config.strict)
+
         if scenario_source.type == :Scenario
           if @failing_test_step
             if @failing_test_step.hook?
@@ -125,7 +127,7 @@ module Cucumber
         else
           output += "Example row: #{row_name}\n"
         end
-        output + "\nMessage:\n"
+        "#{output}\nMessage:\n"
       end
 
       def build_testcase(result, scenario_designation, output)
@@ -191,7 +193,7 @@ module Cucumber
       end
 
       def basename(feature_file)
-        File.basename(feature_file.gsub(/[\\\/]/, '-'), '.feature') # rubocop:disable Style/RegexpLiteral
+        File.basename(feature_file.gsub(/[\\\/]/, '-'), '.feature')
       end
 
       def write_file(feature_filename, data)
@@ -228,13 +230,14 @@ module Cucumber
       end
 
       def examples_table_row(row)
-        @row_name = '| ' + row.cells.map(&:value).join(' | ') + ' |'
+        @row_name = "| #{row.cells.map(&:value).join(' | ')} |"
         @name_suffix = " (outline example : #{@row_name})"
       end
     end
 
     class ResultBuilder
       attr_reader :test_case_duration
+
       def initialize(result)
         @test_case_duration = 0
         result.describe_to(self)

data/lib/cucumber/formatter/message.rb

@@ -15,7 +15,8 @@ module Cucumber
       end
 
       def output_envelope(envelope)
-        envelope.write_ndjson_to(@io)
+        @io.write(envelope.to_json)
+        @io.write("\n")
       end
     end
   end

data/lib/cucumber/formatter/message_builder.rb

@@ -48,12 +48,12 @@ module Cucumber
         }
 
         if media_type.start_with?('text/')
-          attachment_data[:content_encoding] = Cucumber::Messages::Attachment::ContentEncoding::IDENTITY
+          attachment_data[:content_encoding] = Cucumber::Messages::AttachmentContentEncoding::IDENTITY
           attachment_data[:body] = src
         else
           body = src.respond_to?(:read) ? src.read : src
 
-          attachment_data[:content_encoding] = Cucumber::Messages::Attachment::ContentEncoding::BASE64
+          attachment_data[:content_encoding] = Cucumber::Messages::AttachmentContentEncoding::BASE64
           attachment_data[:body] = Base64.strict_encode64(body)
         end
 
@@ -101,7 +101,7 @@ module Cucumber
       def test_step_to_message(step)
         return hook_step_to_message(step) if step.hook?
 
-        Cucumber::Messages::TestCase::TestStep.new(
+        Cucumber::Messages::TestStep.new(
           id: step.id,
           pickle_step_id: @pickle_step_by_test_step.pickle_step_id(step),
           step_definition_ids: @step_definitions_by_test_step.step_definition_ids(step),
@@ -110,7 +110,7 @@ module Cucumber
       end
 
       def hook_step_to_message(step)
-        Cucumber::Messages::TestCase::TestStep.new(
+        Cucumber::Messages::TestStep.new(
           id: step.id,
           hook_id: @hook_by_test_step.hook_id(step)
         )
@@ -118,7 +118,7 @@ module Cucumber
 
       def step_match_arguments_lists(step)
         match_arguments = step_match_arguments(step)
-        [Cucumber::Messages::TestCase::TestStep::StepMatchArgumentsList.new(
+        [Cucumber::Messages::StepMatchArgumentsList.new(
           step_match_arguments: match_arguments
         )]
       rescue Cucumber::Formatter::TestStepUnknownError
@@ -127,7 +127,7 @@ module Cucumber
 
       def step_match_arguments(step)
         @step_definitions_by_test_step.step_match_arguments(step).map do |argument|
-          Cucumber::Messages::TestCase::TestStep::StepMatchArgumentsList::StepMatchArgument.new(
+          Cucumber::Messages::StepMatchArgument.new(
             group: argument_group_to_message(argument.group),
             parameter_type_name: argument.parameter_type.name
           )
@@ -135,7 +135,7 @@ module Cucumber
       end
 
       def argument_group_to_message(group)
-        Cucumber::Messages::TestCase::TestStep::StepMatchArgumentsList::StepMatchArgument::Group.new(
+        Cucumber::Messages::Group.new(
           start: group.start,
           value: group.value,
           children: group.children.map { |child| argument_group_to_message(child) }
@@ -190,7 +190,7 @@ module Cucumber
 
         result_message = result.to_message
         if result.failed? || result.pending?
-          result_message = Cucumber::Messages::TestStepFinished::TestStepResult.new(
+          result_message = Cucumber::Messages::TestStepResult.new(
             status: result_message.status,
             duration: result_message.duration,
             message: create_error_message(result)
@@ -226,10 +226,11 @@ module Cucumber
         output_envelope(message)
       end
 
-      def on_test_run_finished(*)
+      def on_test_run_finished(event)
         message = Cucumber::Messages::Envelope.new(
           test_run_finished: Cucumber::Messages::TestRunFinished.new(
-            timestamp: time_to_timestamp(Time.now)
+            timestamp: time_to_timestamp(Time.now),
+            success: event.success
           )
         )
 

data/lib/cucumber/formatter/pretty.rb

@@ -24,11 +24,9 @@ module Cucumber
       include Console
       include Io
       include Cucumber::Gherkin::Formatter::Escaping
-      attr_reader :config, :options
+      attr_reader :config, :options, :current_feature_uri, :current_scenario_outline, :current_examples, :current_test_case, :in_scenario_outline, :print_background_steps
       private :config, :options
-      attr_reader :current_feature_uri, :current_scenario_outline, :current_examples, :current_test_case
       private :current_feature_uri, :current_scenario_outline, :current_examples, :current_test_case
-      attr_reader :in_scenario_outline, :print_background_steps
       private :in_scenario_outline, :print_background_steps
 
       def initialize(config)
@@ -105,16 +103,19 @@ module Cucumber
 
       def on_test_step_started(event)
         return if event.test_step.hook?
+
         print_step_header(current_test_case) if first_step_after_printing_background_steps?(event.test_step)
       end
 
       def on_test_step_finished(event)
         collect_snippet_data(event.test_step, @ast_lookup) if event.result.undefined?
         return if in_scenario_outline && !options[:expand]
+
         exception_to_be_printed = find_exception_to_be_printed(event.result)
         print_step_data(event.test_step, event.result) if print_step_data?(event, exception_to_be_printed)
         print_step_output
         return unless exception_to_be_printed
+
         print_exception(exception_to_be_printed, event.result.to_sym, 6)
         @exceptions << exception_to_be_printed
       end
@@ -127,6 +128,7 @@ module Cucumber
         else
           exception_to_be_printed = find_exception_to_be_printed(event.result)
           return unless exception_to_be_printed
+
           print_exception(exception_to_be_printed, event.result.to_sym, 6)
           @exceptions << exception_to_be_printed
         end
@@ -140,6 +142,7 @@ module Cucumber
 
       def attach(src, media_type)
         return unless media_type == 'text/x.cucumber.log+plain'
+
         @test_step_output.push src
       end
 
@@ -147,9 +150,11 @@ module Cucumber
 
       def find_exception_to_be_printed(result)
         return nil if result.ok?(options[:strict])
+
         result = result.with_filtered_backtrace(Cucumber::Formatter::BacktraceFilter)
         exception = result.failed? ? result.exception : result
         return nil if @exceptions.include?(exception)
+
         exception
       end
 
@@ -181,7 +186,7 @@ module Cucumber
       end
 
       def print_step_output
-        @test_step_output.each { |message| @io.puts(format_string(message, :tag).indent(6)) }
+        @test_step_output.each { |message| @io.puts(indent(format_string(message, :tag), 6)) }
         @test_step_output = []
       end
 
@@ -196,6 +201,7 @@ module Cucumber
       def feature_has_background?
         feature_children = gherkin_document.feature.children
         return false if feature_children.empty?
+
         !feature_children.first.background.nil?
       end
 
@@ -239,6 +245,7 @@ module Cucumber
       def first_step_after_printing_background_steps?(test_step)
         return false unless print_background_steps
         return false unless test_step.location.lines.max >= current_test_case.location.lines.max
+
         @print_background_steps = false
         true
       end
@@ -259,33 +266,35 @@ module Cucumber
         end
       end
 
-      def print_comments(up_to_line, indent)
+      def print_comments(up_to_line, indent_amount)
         comments = gherkin_document.comments
         return if comments.empty? || comments.length <= @next_comment_to_be_printed
-        comments[@next_comment_to_be_printed..-1].each do |comment|
+
+        comments[@next_comment_to_be_printed..].each do |comment|
           if comment.location.line <= up_to_line
-            @io.puts(format_string(comment.text.strip, :comment).indent(indent))
+            @io.puts(indent(format_string(comment.text.strip, :comment), indent_amount))
             @next_comment_to_be_printed += 1
           end
           break if @next_comment_to_be_printed >= comments.length
         end
       end
 
-      def print_tags(tags, indent)
+      def print_tags(tags, indent_amount)
         return if !tags || tags.empty?
-        @io.puts(tags.map { |tag| format_string(tag.name, :tag) }.join(' ').indent(indent))
+
+        @io.puts(indent(tags.map { |tag| format_string(tag.name, :tag) }.join(' '), indent_amount))
       end
 
       def print_feature_line(feature)
         print_keyword_name(feature.keyword, feature.name, 0)
       end
 
-      def print_keyword_name(keyword, name, indent, location = nil)
+      def print_keyword_name(keyword, name, indent_amount, location = nil)
         line = "#{keyword}:"
         line += " #{name}"
-        @io.print(line.indent(indent))
+        @io.print(indent(line, indent_amount))
         if location && options[:source]
-          line_comment = format_string("# #{location}", :comment).indent(@source_indent - line.length - indent)
+          line_comment = indent(format_string("# #{location}", :comment), @source_indent - line.length - indent_amount)
           @io.print(line_comment)
         end
         @io.puts
@@ -293,6 +302,7 @@ module Cucumber
 
       def print_description(description)
         return unless description
+
         description.split("\n").each do |line|
           @io.puts(line)
         end
@@ -339,7 +349,7 @@ module Cucumber
         indent = options[:source] ? @source_indent - step_keyword.length - test_step.text.length - base_indent : nil
         print_comments(test_step.location.lines.max, base_indent)
         name_to_report = format_step(step_keyword, @step_matches.fetch(test_step.to_s) { NoStepMatch.new(test_step, test_step.text) }, result.to_sym, indent)
-        @io.puts(name_to_report.indent(base_indent))
+        @io.puts(indent(name_to_report, base_indent))
         print_multiline_argument(test_step, result, base_indent + 2) unless options[:no_multiline]
         @io.flush
       end
@@ -374,10 +384,10 @@ module Cucumber
         end
       end
 
-      def print_data_table(data_table, status, indent)
+      def print_data_table(data_table, status, indent_amount)
         data_table.rows.each do |row|
-          print_comments(row.location.line, indent)
-          @io.puts format_string(gherkin_source.split("\n")[row.location.line - 1].strip, status).indent(indent)
+          print_comments(row.location.line, indent_amount)
+          @io.puts indent(format_string(gherkin_source.split("\n")[row.location.line - 1].strip, status), indent_amount)
         end
       end
 
@@ -393,18 +403,19 @@ module Cucumber
           @io.print(format_string(step_line, :skipped))
           if options[:source]
             comment_line = format_string("# #{current_feature_uri}:#{step.location.line}", :comment)
-            @io.print(comment_line.indent(@source_indent - step_line.length))
+            @io.print(indent(comment_line, @source_indent - step_line.length))
           end
           @io.puts
           next if options[:no_multiline]
+
           print_doc_string(step.doc_string.content, :skipped, 6) unless step.doc_string.nil?
           print_data_table(step.data_table, :skipped, 6) unless step.data_table.nil?
         end
         @io.flush
       end
 
-      def print_doc_string(content, status, indent)
-        s = %("""\n#{content}\n""").indent(indent)
+      def print_doc_string(content, status, indent_amount)
+        s = indent(%("""\n#{content}\n"""), indent_amount)
         s = s.split("\n").map { |l| l =~ /^\s+$/ ? '' : l }.join("\n")
         @io.puts(format_string(s, status))
       end
@@ -416,15 +427,15 @@ module Cucumber
         print_description(examples.description)
         unless options[:expand]
           print_comments(examples.table_header.location.line, 6)
-          @io.puts(gherkin_source.split("\n")[examples.table_header.location.line - 1].strip.indent(6))
+          @io.puts(indent(gherkin_source.split("\n")[examples.table_header.location.line - 1].strip, 6))
         end
         @io.flush
       end
 
       def print_row_data(test_case, result)
         print_comments(test_case.location.lines.max, 6)
-        @io.print(format_string(gherkin_source.split("\n")[test_case.location.lines.max - 1].strip, result.to_sym).indent(6))
-        @io.print(format_string(@test_step_output.join(', '), :tag).indent(2)) unless @test_step_output.empty?
+        @io.print(indent(format_string(gherkin_source.split("\n")[test_case.location.lines.max - 1].strip, result.to_sym), 6))
+        @io.print(indent(format_string(@test_step_output.join(', '), :tag), 2)) unless @test_step_output.empty?
         @test_step_output = []
         @io.puts
         if result.failed? || result.pending?
@@ -444,7 +455,7 @@ module Cucumber
         language = ::Gherkin::Dialect.for(language_code)
         scenario_keyword = language.scenario_keywords[0]
         row = scenario_source(test_case).row
-        expanded_name = '| ' + row.cells.map(&:value).join(' | ') + ' |'
+        expanded_name = "| #{row.cells.map(&:value).join(' | ')} |"
         @source_indent = calculate_source_indent_for_expanded_test_case(test_case, scenario_keyword, expanded_name)
         @io.puts
         print_keyword_name(scenario_keyword, expanded_name, 6, test_case.location)

data/lib/cucumber/formatter/progress.rb

@@ -58,6 +58,7 @@ module Cucumber
         progress(result.to_sym) if !test_step.hook? || result.failed?
 
         return if test_step.hook?
+
         collect_snippet_data(test_step, @ast_lookup) if result.undefined?
         @pending_step_matches << @matches[test_step.to_s] if result.pending?
         @failed_results << result if result.failed?

data/lib/cucumber/formatter/publish_banner_printer.rb

@@ -41,7 +41,7 @@ module Cucumber
             '',
             [
               'More information at ',
-              link('https://reports.cucumber.io/docs/cucumber-ruby')
+              link('https://cucumber.io/docs/cucumber/environment-variables/')
             ],
             '',
             [

data/lib/cucumber/formatter/query/hook_by_test_step.rb

@@ -13,6 +13,7 @@ module Cucumber
 
         def hook_id(test_step)
           return @hook_id_by_test_step_id[test_step.id] if @hook_id_by_test_step_id.key?(test_step.id)
+
           raise TestStepUnknownError, "No hook found for #{test_step.id} }. Known: #{@hook_id_by_test_step_id.keys}"
         end
 

data/lib/cucumber/formatter/query/test_case_started_by_test_case.rb

@@ -15,11 +15,13 @@ module Cucumber
 
         def attempt_by_test_case(test_case)
           raise TestCaseUnknownError, "No test case found for #{test_case.id} }. Known: #{@attempts_by_test_case_id.keys}" unless @attempts_by_test_case_id.key?(test_case.id)
+
           @attempts_by_test_case_id[test_case.id]
         end
 
         def test_case_started_id_by_test_case(test_case)
           raise TestCaseUnknownError, "No test case found for #{test_case.id} }. Known: #{@test_case_started_id_by_test_case_id.keys}" unless @test_case_started_id_by_test_case_id.key?(test_case.id)
+
           @test_case_started_id_by_test_case_id[test_case.id]
         end
 

data/lib/cucumber/formatter/rerun.rb

@@ -15,6 +15,7 @@ module Cucumber
           test_case, result = *event.attributes
           if @config.strict.strict?(:flaky)
             next if result.ok?(@config.strict)
+
             add_to_failures(test_case)
           else
             unless @latest_failed_test_case.nil?
@@ -31,6 +32,7 @@ module Cucumber
         config.on_event :test_run_finished do
           add_to_failures(@latest_failed_test_case) unless @latest_failed_test_case.nil?
           next if @failures.empty?
+
           @io.print file_failures.join("\n")
         end
       end