cucumber 5.0.0 → 5.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b3c9c9e718ba5a344adfb97aaebfb58f5c99bb6f8142bb74c115c9b7fe94d0f3
-  data.tar.gz: 3a70805fa19b0b83393e61853a6803eecc3b5cfd578a3f1e2201c258fa11b107
+  metadata.gz: 36830fb7cfa9895488ea7f11bb33f6267c94328b8b3a08da75749d26f4047479
+  data.tar.gz: 725299585226f1af48d00c12af192844af884ec49d44e6966c22a8a607bd9fa8
 SHA512:
-  metadata.gz: 81ed3402348bf4882f9e8a3b43e3b926396813d844cb93c00e1bfecac15f3fb7672750e0162c01182bada9aed90aff96d1751d66fe3bcd7ff9a0bb0b10052c29
-  data.tar.gz: 8f13726940d23325f2f8278dd6c6ddabbbe4cec7fa3b61d7066c2c068b3c326af011bb6eca6b4a18c0cc9ffa00043bb535d2932185259f60baf51ebefbd19087
+  metadata.gz: 807a72bba0f0a30c266b68afd4866ead55178f2ee2f72bd5a86331445f6de62bf320ebd2a848c05dd6c906c52aa6d082c1b5f241a65cc00e5ff6df14ffe3d6b8
+  data.tar.gz: d11cfaaa57bf35ffbbf54273317825179beb5db3ab106feacb30c7d0860ca6aeacf90404774ee92eafba100db00b5a25428ca7f3447262b0f05687b57d03aeae

data/CHANGELOG.md

@@ -10,7 +10,7 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 
 ----
 
-## [In GIT](https://github.com/cucumber/cucumber-ruby/compare/v5.0.0...master)
+## [In GIT](https://github.com/cucumber/cucumber-ruby/compare/v5.2.0...master)
 
 ### Added
 
@@ -22,6 +22,51 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 
 ### Fixed
 
+### Security fixes
+
+## [5.2.0](https://github.com/cucumber/cucumber-ruby/compare/v5.1.3...v5.2.0)
+
+### Changed
+
+* `--publish` uses the response provided by the server as the banner [#1472](https://github.com/cucumber/cucumber-ruby/issues/1472)
+
+## [5.1.3](https://github.com/cucumber/cucumber-ruby/compare/v5.1.2...v5.1.3)
+
+### Fixed
+
+* The `CUCUMBER_PUBLISH_TOKEN` now sets the correct HTTP header, following a fix in the curl option parser.
+
+## [5.1.2](https://github.com/cucumber/cucumber-ruby/compare/v5.1.1...v5.1.2)
+
+### Fixed
+
+* Do not send headers after following redirection [#1475](https://github.com/cucumber/cucumber-ruby/pull/1475)
+
+## [5.1.1](https://github.com/cucumber/cucumber-ruby/compare/v5.1.0...v5.1.1)
+
+### Security fixes
+
+* Update `cucumber-create-meta` to 2.0.2
+
+## [5.1.0](https://github.com/cucumber/cucumber-ruby/compare/v5.0.0...5.1.0)
+
+### Added
+
+* `-X GET` in an `--out` URL will now issue a `GET` request *without* a body. If the response is `202 Accepted` *and*
+  the `Location` header is present, a new `PUT` request will be sent *with* the body.
+
+  The main reason for this added behaviour is to allow request bodies larger than 6Mb to be sent while using `--publish`.
+  This also improves performance since the request body is only sent once (previously it would be sent twice).
+
+### Changed
+
+* Set banner border color to green when publishing reports
+* Postpone removal of `--format=json`, `embed` and `puts` to version 6.0.0 in deprecation messages
+
+### Fixed
+
+* Display banner on stderr when publishing reports [#1462](https://github.com/cucumber/cucumber-ruby/issues/1462)
+
 ## [5.0.0](https://github.com/cucumber/cucumber-ruby/compare/v4.1.0...5.0.0)
 
 ### Added

data/CONTRIBUTING.md

@@ -65,7 +65,9 @@ help us to correct style violations reported here:
 * Remove empty sections from `CHANGELOG.md`
 * Now release it:
 
-```
-git commit -am "Release X.Y.Z"
-make release
-```
+  ```
+  git commit -am "Release X.Y.Z"
+  make release
+  ```
+
+* Finally, update the cucumber-ruby version in the [documentation project](https://cucumber.io/docs/installation/) in [versions.yaml](https://github.com/cucumber/docs.cucumber.io/blob/master/data/versions.yaml) file.

data/lib/cucumber/cli/options.rb

@@ -9,7 +9,7 @@ require 'cucumber/core/test/result'
 module Cucumber
   module Cli
     class Options
-      CUCUMBER_PUBLISH_URL = ENV['CUCUMBER_PUBLISH_URL'] || 'https://messages.cucumber.io/api/reports'
+      CUCUMBER_PUBLISH_URL = ENV['CUCUMBER_PUBLISH_URL'] || 'https://messages.cucumber.io/api/reports -X GET'
       INDENT = ' ' * 53
       BUILTIN_FORMATS = {
         'pretty'      => ['Cucumber::Formatter::Pretty',      'Prints the feature as is - in colours.'],
@@ -335,7 +335,7 @@ Specify SEED to reproduce the shuffling from a previous run.
           'option is specified; all loading becomes explicit.',
           'Files in directories named "support" are still always',
           'loaded first when their parent directories are',
-          'required or if the "support" directoires themselves are',
+          'required or if the "support" directories themselves are',
           'explicitly required.',
           'This option can be specified multiple times.'
         ]
@@ -367,7 +367,7 @@ Specify SEED to reproduce the shuffling from a previous run.
       end
 
       def require_jars(jars)
-        Dir["#{jars}/**/*.jar"].each { |jar| require jar }
+        Dir["#{jars}/**/*.jar"].sort.each { |jar| require jar }
       end
 
       def publisher

data/lib/cucumber/deprecate.rb

@@ -41,7 +41,7 @@ module Cucumber
 
     module ForDevelopers
       def self.call(_message, _method, remove_after_version)
-        raise "This method is due for removal after version #{remove_after_version}" if Cucumber::VERSION > remove_after_version
+        raise "This method is due for removal after version #{remove_after_version}" if Cucumber::VERSION >= remove_after_version
       end
     end
 

data/lib/cucumber/errors.rb

@@ -11,7 +11,7 @@ module Cucumber
       begin
         raise new(with_prefix(step_name)) # rubocop:disable Style/RaiseArgs
       rescue StandardError => e
-        return e
+        e
       end
     end
 

data/lib/cucumber/formatter/ast_lookup.rb

@@ -136,7 +136,6 @@ module Cucumber
 
         private
 
-        # rubocop:disable Metrics/PerceivedComplexity
         def process_scenario_container(container, original_previous_node)
           container.children.each do |child|
             previous_node = original_previous_node
@@ -158,7 +157,6 @@ module Cucumber
             end
           end
         end
-        # rubocop:enable Metrics/PerceivedComplexity
       end
     end
   end

data/lib/cucumber/formatter/html.rb

@@ -8,7 +8,7 @@ module Cucumber
       include Io
 
       def initialize(config)
-        @io = ensure_io(config.out_stream)
+        @io = ensure_io(config.out_stream, config.error_stream)
         @html_formatter = Cucumber::HTMLFormatter::Formatter.new(@io)
         @html_formatter.write_pre_message
 

data/lib/cucumber/formatter/http_io.rb

@@ -1,5 +1,6 @@
 require 'net/http'
 require 'tempfile'
+require 'shellwords'
 
 module Cucumber
   module Formatter
@@ -18,48 +19,43 @@ module Cucumber
 
     class CurlOptionParser
       def self.parse(options)
-        chunks = options.split(/\s/).compact
-        http_method = 'PUT'
-        url = chunks[0]
-        headers = ''
-
-        last_flag = nil
-        chunks.each do |chunk|
-          if ['-X', '--request'].include?(chunk)
-            last_flag = '-X'
-            next
-          end
+        args = Shellwords.split(options)
 
-          if chunk == '-H'
-            last_flag = '-H'
-            next
-          end
-
-          if last_flag == '-X'
-            http_method = chunk
-            last_flag = nil
+        url = nil
+        http_method = 'PUT'
+        headers = {}
+
+        until args.empty?
+          arg = args.shift
+          case arg
+          when '-X', '--request'
+            http_method = remove_arg_for(args, arg)
+          when '-H'
+            header_arg = remove_arg_for(args, arg)
+            headers = headers.merge(parse_header(header_arg))
+          else
+            raise StandardError, "#{options} was not a valid curl command. Can't set url to #{arg} it is already set to #{url}" if url
+            url = arg
           end
-
-          headers += chunk if last_flag == '-H'
         end
+        raise StandardError, "#{options} was not a valid curl command" unless url
 
         [
           url,
           http_method,
-          make_headers(headers)
+          headers
         ]
       end
 
-      def self.make_headers(headers)
-        hash_headers = {}
-        str_scanner = /("(?<key>[^":]+)\s*:\s*(?<value>[^":]+)")|('(?<key1>[^':]+)\s*:\s*(?<value1>[^':]+)')/
-
-        headers.scan(str_scanner) do |header|
-          header = header.compact!
-          hash_headers[header[0]] = header[1]&.strip
-        end
+      def self.remove_arg_for(args, arg)
+        return args.shift unless args.empty?
+        raise StandardError, "Missing argument for #{arg}"
+      end
 
-        hash_headers
+      def self.parse_header(header_arg)
+        parts = header_arg.split(':', 2)
+        raise StandardError, "#{header_arg} was not a valid header" unless parts.length == 2
+        { parts[0].strip => parts[1].strip }
       end
     end
 
@@ -76,10 +72,11 @@ module Cucumber
       end
 
       def close
-        resource_uri = send_content(@uri, @method, @headers)
-
-        @reporter.report(resource_uri)
+        response = send_content(@uri, @method, @headers)
+        @reporter.report(response.body)
         @write_io.close
+        return if response.is_a?(Net::HTTPSuccess) || response.is_a?(Net::HTTPRedirection)
+        raise StandardError, "request to #{uri} failed with status #{response.code}"
       end
 
       def write(data)
@@ -97,7 +94,7 @@ module Cucumber
       private
 
       def send_content(uri, method, headers, attempt = 10)
-        content = @write_io
+        content = (method == 'GET' ? StringIO.new : @write_io)
         http = build_client(uri, @https_verify_mode)
 
         raise StandardError, "request to #{uri} failed (too many redirections)" if attempt <= 0
@@ -120,13 +117,12 @@ module Cucumber
         end
 
         case response
-        when Net::HTTPSuccess
-          uri
+        when Net::HTTPAccepted
+          send_content(URI(response['Location']), 'PUT', {}, attempt - 1) if response['Location']
         when Net::HTTPRedirection
           send_content(URI(response['Location']), method, headers, attempt - 1)
-        else
-          raise StandardError, "request to #{uri} failed with status #{response.code}"
         end
+        response
       end
 
       def build_request(uri, method, headers)

data/lib/cucumber/formatter/interceptor.rb

@@ -63,10 +63,10 @@ module Cucumber
           case pipe
           when :stderr
             $stderr = new($stderr)
-            return $stderr
+            $stderr
           when :stdout
             $stdout = new($stdout)
-            return $stdout
+            $stdout
           end
         end
       end

data/lib/cucumber/formatter/io.rb

@@ -9,13 +9,13 @@ module Cucumber
     module Io
       module_function
 
-      def ensure_io(path_or_url_or_io)
+      def ensure_io(path_or_url_or_io, error_stream)
         return nil if path_or_url_or_io.nil?
         return path_or_url_or_io if io?(path_or_url_or_io)
 
         io = if url?(path_or_url_or_io)
                url = path_or_url_or_io
-               reporter = url.start_with?(Cucumber::Cli::Options::CUCUMBER_PUBLISH_URL) ? URLReporter.new($stdout) : NoReporter.new
+               reporter = url.start_with?(Cucumber::Cli::Options::CUCUMBER_PUBLISH_URL) ? URLReporter.new(error_stream) : NoReporter.new
                HTTPIO.open(url, nil, reporter)
              else
                File.open(path_or_url_or_io, Cucumber.file_mode('w'))
@@ -64,7 +64,7 @@ module Cucumber
         raise "You *must* specify --out FILE for the #{name} formatter" unless String == path.class
         raise "I can't write #{name} to a directory - it has to be a file" if File.directory?(path)
         raise "I can't write #{name} to a file in the non-existing directory #{File.dirname(path)}" unless File.directory?(File.dirname(path))
-        ensure_io(path)
+        ensure_io(path, nil)
       end
 
       def ensure_dir(path, name)

data/lib/cucumber/formatter/json.rb

@@ -19,10 +19,10 @@ module Cucumber
           '--format=json',
           "Please use --format=message and stand-alone json-formatter.\n" \
           'json-formatter homepage: https://github.com/cucumber/cucumber/tree/master/json-formatter#cucumber-json-formatter',
-          '5.0.0'
+          '6.0.0'
         )
 
-        @io = ensure_io(config.out_stream)
+        @io = ensure_io(config.out_stream, config.error_stream)
         @ast_lookup = AstLookup.new(config)
         @feature_hashes = []
         @step_or_hook_hash = {}

data/lib/cucumber/formatter/junit.rb

@@ -106,7 +106,7 @@ module Cucumber
         write_file(feature_result_filename(feature_data[:uri]), @testsuite.target!)
       end
 
-      def create_output_string(test_case, scenario, result, row_name) # rubocop:disable Metrics/PerceivedComplexity
+      def create_output_string(test_case, scenario, result, row_name)
         scenario_source = @ast_lookup.scenario_source(test_case)
         keyword = scenario_source.type == :Scenario ? scenario_source.scenario.keyword : scenario_source.scenario_outline.keyword
         output = "#{keyword}: #{scenario}\n\n"

data/lib/cucumber/formatter/message.rb

@@ -10,7 +10,7 @@ module Cucumber
       include Io
 
       def initialize(config)
-        @io = ensure_io(config.out_stream)
+        @io = ensure_io(config.out_stream, config.error_stream)
         super(config)
       end
 

data/lib/cucumber/formatter/pretty.rb

@@ -32,7 +32,7 @@ module Cucumber
       private :in_scenario_outline, :print_background_steps
 
       def initialize(config)
-        @io = ensure_io(config.out_stream)
+        @io = ensure_io(config.out_stream, config.error_stream)
         @config = config
         @options = config.to_hash
         @snippets_input = []

data/lib/cucumber/formatter/progress.rb

@@ -19,7 +19,7 @@ module Cucumber
 
       def initialize(config)
         @config = config
-        @io = ensure_io(config.out_stream)
+        @io = ensure_io(config.out_stream, config.error_stream)
         @snippets_input = []
         @undefined_parameter_types = []
         @total_duration = 0

data/lib/cucumber/formatter/publish_banner_printer.rb

@@ -30,7 +30,9 @@ module Cucumber
             ],
             [
               'Environment variable:   ',
-              highlight('CUCUMBER_PUBLISH_ENABLED=true')
+              highlight('CUCUMBER_PUBLISH_ENABLED'),
+              '=',
+              highlight('true')
             ],
             [
               'cucumber.yml:           ',

data/lib/cucumber/formatter/rerun.rb

@@ -7,8 +7,8 @@ module Cucumber
     class Rerun
       include Formatter::Io
 
-      def initialize(config) # rubocop:disable Metrics/PerceivedComplexity
-        @io = ensure_io(config.out_stream)
+      def initialize(config)
+        @io = ensure_io(config.out_stream, config.error_stream)
         @config = config
         @failures = {}
         config.on_event :test_case_finished do |event|

data/lib/cucumber/formatter/steps.rb

@@ -5,7 +5,7 @@ module Cucumber
     # The formatter used for <tt>--format steps</tt>
     class Steps
       def initialize(runtime, path_or_io, options)
-        @io = ensure_io(path_or_io)
+        @io = ensure_io(path_or_io, nil)
         @options = options
         @step_definition_files = collect_steps(runtime)
       end

data/lib/cucumber/formatter/summary.rb

@@ -16,7 +16,7 @@ module Cucumber
 
       def initialize(config)
         @config = config
-        @io = ensure_io(config.out_stream)
+        @io = ensure_io(config.out_stream, config.error_stream)
         @ast_lookup = AstLookup.new(config)
         @counts = ConsoleCounts.new(@config)
         @issues = ConsoleIssues.new(@config, @ast_lookup)

data/lib/cucumber/formatter/url_reporter.rb

@@ -1,30 +1,17 @@
-require 'cucumber/term/banner'
-
 module Cucumber
   module Formatter
     class URLReporter
-      include Term::Banner
-
       def initialize(io)
         @io = io
       end
 
-      def report(url)
-        uri = URI(url)
-        display_banner(
-          [
-            'View your Cucumber Report at:',
-            [["https://reports.cucumber.io#{uri.path}", :cyan, :bold, :underline]],
-            '',
-            [['This report will self-destruct in 24h unless it is claimed or deleted.', :green, :bold]]
-          ],
-          @io
-        )
+      def report(banner)
+        @io.puts(banner)
       end
     end
 
     class NoReporter
-      def report(url); end
+      def report(banner); end
     end
   end
 end

data/lib/cucumber/glue/dsl.rb

@@ -137,4 +137,4 @@ module Cucumber
 end
 
 # TODO: can we avoid adding methods to the global namespace (Kernel)
-extend(Cucumber::Glue::Dsl) # rubocop:disable Style/MixinUsage
+extend(Cucumber::Glue::Dsl)

data/lib/cucumber/glue/proto_world.rb

@@ -87,7 +87,7 @@ module Cucumber
           'If you simply want it in the console, '\
           'keep using "puts" (or Kernel.puts to avoid this message)',
           'puts(message)',
-          '5.0.0'
+          '6.0.0'
         )
         messages.each { |message| log(message.to_s) }
       end
@@ -102,7 +102,7 @@ module Cucumber
         Cucumber.deprecate(
           'Please use attach(file, media_type) instead',
           'embed(file, mime_type, label)',
-          '5.0.0'
+          '6.0.0'
         )
         attach(file, mime_type)
       end
@@ -143,7 +143,7 @@ module Cucumber
       end
 
       # Dynamially generate the API module, closuring the dependencies
-      def self.for(runtime, language) # rubocop:disable Metrics/MethodLength
+      def self.for(runtime, language) # rubocop:disable Metrics/MethodLength,Metrics/AbcSize
         Module.new do # rubocop:disable Metrics/BlockLength
           def self.extended(object)
             # wrap the dynamically generated module so that we can document the methods

data/lib/cucumber/rake/task.rb

@@ -5,9 +5,7 @@ require 'cucumber/gherkin/formatter/ansi_escapes'
 begin
   # Support Rake > 0.8.7
   require 'rake/dsl_definition'
-  # rubocop:disable Lint/HandleExceptions
 rescue LoadError
-  # rubocop:enable Lint/HandleExceptions
 end
 
 module Cucumber

data/lib/cucumber/term/banner.rb

@@ -4,7 +4,7 @@ module Cucumber
   module Term
     module Banner
       def display_banner(lines, io, border_modifiers = nil)
-        BannerMaker.new.display_banner(lines, io, border_modifiers || [:cyan])
+        BannerMaker.new.display_banner(lines, io, border_modifiers || %i[green bold])
       end
 
       class BannerMaker

data/lib/cucumber/version

@@ -1 +1 @@
-5.0.0
+5.2.0

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cucumber
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.2.0
 platform: ruby
 authors:
 - Aslak Hellesøy
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-19 00:00:00.000000000 Z
+date: 2020-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder
@@ -61,7 +61,7 @@ dependencies:
         version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: 2.0.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -71,7 +71,7 @@ dependencies:
         version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: 2.0.2
 - !ruby/object:Gem::Dependency
   name: cucumber-cucumber-expressions
   requirement: !ruby/object:Gem::Requirement
@@ -138,20 +138,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: '13.1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 13.0.1
+        version: 13.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: '13.1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 13.0.1
+        version: 13.1.0
 - !ruby/object:Gem::Dependency
   name: cucumber-wire
   requirement: !ruby/object:Gem::Requirement
@@ -381,7 +381,7 @@ dependencies:
         version: '1.6'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.6.0
+        version: 1.6.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -391,27 +391,27 @@ dependencies:
         version: '1.6'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.6.0
+        version: 1.6.1
 - !ruby/object:Gem::Dependency
   name: octokit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.18'
+        version: '4.19'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.18.0
+        version: 4.19.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.18'
+        version: '4.19'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.18.0
+        version: 4.19.0
 - !ruby/object:Gem::Dependency
   name: rack-test
   requirement: !ruby/object:Gem::Requirement
@@ -438,20 +438,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.8.1
+        version: 2.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.8.1
+        version: 2.1.0
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
@@ -642,5 +642,5 @@ requirements: []
 rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
-summary: cucumber-5.0.0
+summary: cucumber-5.2.0
 test_files: []