cucumber 5.0.0 → 5.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b3c9c9e718ba5a344adfb97aaebfb58f5c99bb6f8142bb74c115c9b7fe94d0f3
-  data.tar.gz: 3a70805fa19b0b83393e61853a6803eecc3b5cfd578a3f1e2201c258fa11b107
+  metadata.gz: ef0451fffdd6dc7d18e7b75d248e3e75dee4f15bb328b8c313e4b6a5606741eb
+  data.tar.gz: 9c14ead4ef9845dc3762d8ffb2d53e9d83c0ad6f66898a104ccd602f207a273b
 SHA512:
-  metadata.gz: 81ed3402348bf4882f9e8a3b43e3b926396813d844cb93c00e1bfecac15f3fb7672750e0162c01182bada9aed90aff96d1751d66fe3bcd7ff9a0bb0b10052c29
-  data.tar.gz: 8f13726940d23325f2f8278dd6c6ddabbbe4cec7fa3b61d7066c2c068b3c326af011bb6eca6b4a18c0cc9ffa00043bb535d2932185259f60baf51ebefbd19087
+  metadata.gz: fd5f761cb29cd344974869cb82a4c25f2f648e11418296c3e7fb8a8d91a9934459519c26bdb89ce37ccccfe789965111e513c92a8106c5eccc81eec6b12a9288
+  data.tar.gz: 4adff7878c3433ba0cf48a7a15b0e5b1f007ab22b8cc001c5c751c87d0328c9c86124ac3e3e7c7ea2b793052f021feb8be90bbd2a3d6491413e12080ddf5ba64

data/CHANGELOG.md

@@ -10,7 +10,7 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 
 ----
 
-## [In GIT](https://github.com/cucumber/cucumber-ruby/compare/v5.0.0...master)
+## [In GIT](https://github.com/cucumber/cucumber-ruby/compare/v5.1.0...master)
 
 ### Added
 
@@ -22,6 +22,25 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 
 ### Fixed
 
+## [5.1.0](https://github.com/cucumber/cucumber-ruby/compare/v5.0.0...5.1.0)
+
+### Added
+
+* `-X GET` in an `--out` URL will now issue a `GET` request *without* a body. If the response is `202 Accepted` *and*
+  the `Location` header is present, a new `PUT` request will be sent *with* the body.
+
+  The main reason for this added behaviour is to allow request bodies larger than 6Mb to be sent while using `--publish`.
+  This also improves performance since the request body is only sent once (previously it would be sent twice).
+
+### Changed
+
+* Set banner border color to green when publishing reports
+* Postpone removal of `--format=json`, `embed` and `puts` to version 6.0.0 in deprecation messages
+
+### Fixed
+
+* Display banner on stderr when publishing reports [#1462](https://github.com/cucumber/cucumber-ruby/issues/1462)
+
 ## [5.0.0](https://github.com/cucumber/cucumber-ruby/compare/v4.1.0...5.0.0)
 
 ### Added

data/lib/cucumber/cli/options.rb

@@ -9,7 +9,7 @@ require 'cucumber/core/test/result'
 module Cucumber
   module Cli
     class Options
-      CUCUMBER_PUBLISH_URL = ENV['CUCUMBER_PUBLISH_URL'] || 'https://messages.cucumber.io/api/reports'
+      CUCUMBER_PUBLISH_URL = ENV['CUCUMBER_PUBLISH_URL'] || 'https://messages.cucumber.io/api/reports -X GET'
       INDENT = ' ' * 53
       BUILTIN_FORMATS = {
         'pretty'      => ['Cucumber::Formatter::Pretty',      'Prints the feature as is - in colours.'],
@@ -367,7 +367,7 @@ Specify SEED to reproduce the shuffling from a previous run.
       end
 
       def require_jars(jars)
-        Dir["#{jars}/**/*.jar"].each { |jar| require jar }
+        Dir["#{jars}/**/*.jar"].sort.each { |jar| require jar }
       end
 
       def publisher

data/lib/cucumber/deprecate.rb

@@ -41,7 +41,7 @@ module Cucumber
 
     module ForDevelopers
       def self.call(_message, _method, remove_after_version)
-        raise "This method is due for removal after version #{remove_after_version}" if Cucumber::VERSION > remove_after_version
+        raise "This method is due for removal after version #{remove_after_version}" if Cucumber::VERSION >= remove_after_version
       end
     end
 

data/lib/cucumber/errors.rb

@@ -11,7 +11,7 @@ module Cucumber
       begin
         raise new(with_prefix(step_name)) # rubocop:disable Style/RaiseArgs
       rescue StandardError => e
-        return e
+        e
       end
     end
 

data/lib/cucumber/formatter/ast_lookup.rb

@@ -136,7 +136,6 @@ module Cucumber
 
         private
 
-        # rubocop:disable Metrics/PerceivedComplexity
         def process_scenario_container(container, original_previous_node)
           container.children.each do |child|
             previous_node = original_previous_node
@@ -158,7 +157,6 @@ module Cucumber
             end
           end
         end
-        # rubocop:enable Metrics/PerceivedComplexity
       end
     end
   end

data/lib/cucumber/formatter/http_io.rb

@@ -97,7 +97,7 @@ module Cucumber
       private
 
       def send_content(uri, method, headers, attempt = 10)
-        content = @write_io
+        content = (method == 'GET' ? StringIO.new : @write_io)
         http = build_client(uri, @https_verify_mode)
 
         raise StandardError, "request to #{uri} failed (too many redirections)" if attempt <= 0
@@ -120,6 +120,10 @@ module Cucumber
         end
 
         case response
+        when Net::HTTPAccepted
+          return uri unless response['Location']
+
+          send_content(URI(response['Location']), 'PUT', headers, attempt - 1)
         when Net::HTTPSuccess
           uri
         when Net::HTTPRedirection

data/lib/cucumber/formatter/interceptor.rb

@@ -63,10 +63,10 @@ module Cucumber
           case pipe
           when :stderr
             $stderr = new($stderr)
-            return $stderr
+            $stderr
           when :stdout
             $stdout = new($stdout)
-            return $stdout
+            $stdout
           end
         end
       end

data/lib/cucumber/formatter/io.rb

@@ -15,7 +15,7 @@ module Cucumber
 
         io = if url?(path_or_url_or_io)
                url = path_or_url_or_io
-               reporter = url.start_with?(Cucumber::Cli::Options::CUCUMBER_PUBLISH_URL) ? URLReporter.new($stdout) : NoReporter.new
+               reporter = url.start_with?(Cucumber::Cli::Options::CUCUMBER_PUBLISH_URL) ? URLReporter.new($stderr) : NoReporter.new
                HTTPIO.open(url, nil, reporter)
              else
                File.open(path_or_url_or_io, Cucumber.file_mode('w'))

data/lib/cucumber/formatter/json.rb

@@ -19,7 +19,7 @@ module Cucumber
           '--format=json',
           "Please use --format=message and stand-alone json-formatter.\n" \
           'json-formatter homepage: https://github.com/cucumber/cucumber/tree/master/json-formatter#cucumber-json-formatter',
-          '5.0.0'
+          '6.0.0'
         )
 
         @io = ensure_io(config.out_stream)

data/lib/cucumber/formatter/junit.rb

@@ -106,7 +106,7 @@ module Cucumber
         write_file(feature_result_filename(feature_data[:uri]), @testsuite.target!)
       end
 
-      def create_output_string(test_case, scenario, result, row_name) # rubocop:disable Metrics/PerceivedComplexity
+      def create_output_string(test_case, scenario, result, row_name)
         scenario_source = @ast_lookup.scenario_source(test_case)
         keyword = scenario_source.type == :Scenario ? scenario_source.scenario.keyword : scenario_source.scenario_outline.keyword
         output = "#{keyword}: #{scenario}\n\n"

data/lib/cucumber/formatter/rerun.rb

@@ -7,7 +7,7 @@ module Cucumber
     class Rerun
       include Formatter::Io
 
-      def initialize(config) # rubocop:disable Metrics/PerceivedComplexity
+      def initialize(config)
         @io = ensure_io(config.out_stream)
         @config = config
         @failures = {}

data/lib/cucumber/glue/proto_world.rb

@@ -87,7 +87,7 @@ module Cucumber
           'If you simply want it in the console, '\
           'keep using "puts" (or Kernel.puts to avoid this message)',
           'puts(message)',
-          '5.0.0'
+          '6.0.0'
         )
         messages.each { |message| log(message.to_s) }
       end
@@ -102,7 +102,7 @@ module Cucumber
         Cucumber.deprecate(
           'Please use attach(file, media_type) instead',
           'embed(file, mime_type, label)',
-          '5.0.0'
+          '6.0.0'
         )
         attach(file, mime_type)
       end
@@ -143,7 +143,7 @@ module Cucumber
       end
 
       # Dynamially generate the API module, closuring the dependencies
-      def self.for(runtime, language) # rubocop:disable Metrics/MethodLength
+      def self.for(runtime, language) # rubocop:disable Metrics/MethodLength,Metrics/AbcSize
         Module.new do # rubocop:disable Metrics/BlockLength
           def self.extended(object)
             # wrap the dynamically generated module so that we can document the methods

data/lib/cucumber/rake/task.rb

@@ -5,9 +5,7 @@ require 'cucumber/gherkin/formatter/ansi_escapes'
 begin
   # Support Rake > 0.8.7
   require 'rake/dsl_definition'
-  # rubocop:disable Lint/HandleExceptions
 rescue LoadError
-  # rubocop:enable Lint/HandleExceptions
 end
 
 module Cucumber

data/lib/cucumber/term/banner.rb

@@ -4,7 +4,7 @@ module Cucumber
   module Term
     module Banner
       def display_banner(lines, io, border_modifiers = nil)
-        BannerMaker.new.display_banner(lines, io, border_modifiers || [:cyan])
+        BannerMaker.new.display_banner(lines, io, border_modifiers || %i[green bold])
       end
 
       class BannerMaker

data/lib/cucumber/version

@@ -1 +1 @@
-5.0.0
+5.1.0

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cucumber
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.1.0
 platform: ruby
 authors:
 - Aslak Hellesøy
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-19 00:00:00.000000000 Z
+date: 2020-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder
@@ -642,5 +642,5 @@ requirements: []
 rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
-summary: cucumber-5.0.0
+summary: cucumber-5.1.0
 test_files: []