cucumber 4.1.0 → 9.2.0

data/lib/cucumber/cli/profile_loader.rb

@@ -11,11 +11,11 @@ module Cucumber
 
       def args_from(profile)
         unless cucumber_yml.key?(profile)
-          raise(ProfileNotFound, <<-END_OF_ERROR)
-Could not find profile: '#{profile}'
+          raise(ProfileNotFound, <<~END_OF_ERROR)
+            Could not find profile: '#{profile}'
 
-Defined profiles in cucumber.yml:
-  * #{cucumber_yml.keys.sort.join("\n  * ")}
+            Defined profiles in cucumber.yml:
+              * #{cucumber_yml.keys.sort.join("\n  * ")}
           END_OF_ERROR
         end
 
@@ -75,11 +75,7 @@ Defined profiles in cucumber.yml:
       def process_configuration_file_with_erb
         require 'erb'
         begin
-          @cucumber_erb = if RUBY_VERSION >= '2.6'
-                            ERB.new(IO.read(cucumber_file), trim_mode: '%').result(binding)
-                          else
-                            ERB.new(IO.read(cucumber_file), nil, '%').result(binding)
-                          end
+          @cucumber_erb = ERB.new(IO.read(cucumber_file), trim_mode: '%').result(binding)
         rescue StandardError
           raise(YmlLoadError, "cucumber.yml was found, but could not be parsed with ERB.  Please refer to cucumber's documentation on correct profile usage.\n#{$ERROR_INFO.inspect}")
         end
@@ -88,7 +84,7 @@ Defined profiles in cucumber.yml:
       def load_configuration
         require 'yaml'
         begin
-          @cucumber_yml = YAML.load(@cucumber_erb) # rubocop:disable Security/YAMLLoad
+          @cucumber_yml = YAML.load(@cucumber_erb)
         rescue StandardError
           raise(YmlLoadError, "cucumber.yml was found, but could not be parsed. Please refer to cucumber's documentation on correct profile usage.\n")
         end

data/lib/cucumber/cli/rerun_file.rb

@@ -10,7 +10,7 @@ module Cucumber
       end
 
       def self.real_path(path)
-        path[1..-1] # remove leading @
+        path[1..]
       end
 
       def initialize(path)

data/lib/cucumber/configuration.rb

@@ -62,6 +62,14 @@ module Cucumber
       @options[:dry_run]
     end
 
+    def publish_enabled?
+      @options[:publish_enabled]
+    end
+
+    def publish_quiet?
+      @options[:publish_quiet]
+    end
+
     def fail_fast?
       @options[:fail_fast]
     end
@@ -70,6 +78,10 @@ module Cucumber
       @options[:retry]
     end
 
+    def retry_total_tests
+      @options[:retry_total]
+    end
+
     def guess?
       @options[:guess]
     end
@@ -168,12 +180,12 @@ module Cucumber
     end
 
     def support_to_load
-      support_files = all_files_to_load.select { |f| f =~ %r{/support/} }
+      support_files = all_files_to_load.select { |f| f =~ /\/support\// }
 
       # env_files are separated from other_files so we can ensure env files
       # load first.
       #
-      env_files = support_files.select { |f| f =~ %r{/support/env\..*} }
+      env_files = support_files.select { |f| f =~ /\/support\/env\..*/ }
       other_files = support_files - env_files
       env_files.reverse + other_files.reverse
     end
@@ -181,7 +193,7 @@ module Cucumber
     def all_files_to_load
       files = require_dirs.map do |path|
         path = path.tr('\\', '/') # In case we're on windows. Globs don't work with backslashes.
-        path = path.gsub(/\/$/, '') # Strip trailing slash. # rubocop:disable Style/RegexpLiteral
+        path = path.gsub(/\/$/, '') # Strip trailing slash.
         File.directory?(path) ? Dir["#{path}/**/*"] : path
       end.flatten.uniq
       remove_excluded_files_from(files)
@@ -192,19 +204,17 @@ module Cucumber
     end
 
     def step_defs_to_load
-      all_files_to_load.reject { |f| f =~ %r{/support/} }
+      all_files_to_load.reject { |f| f =~ /\/support\// }
     end
 
     def formatter_factories
       formats.map do |format, formatter_options, path_or_io|
-        begin
-          factory = formatter_class(format)
-          yield factory,
-                formatter_options,
-                path_or_io
-        rescue Exception => e # rubocop:disable Lint/RescueException
-          raise e, "#{e.message}\nError creating formatter: #{format}", e.backtrace
-        end
+        factory = formatter_class(format)
+        yield factory,
+              formatter_options,
+              path_or_io
+      rescue Exception => e
+        raise e, "#{e.message}\nError creating formatter: #{format}", e.backtrace
       end
     end
 
@@ -256,6 +266,7 @@ module Cucumber
         strict: Cucumber::Core::Test::Result::StrictConfiguration.new,
         require: [],
         dry_run: false,
+        publish_quiet: false,
         fail_fast: false,
         formats: [],
         excludes: [],
@@ -266,7 +277,8 @@ module Cucumber
         snippets: true,
         source: true,
         duration: true,
-        event_bus: Cucumber::Events.make_event_bus
+        event_bus: Cucumber::Events.make_event_bus,
+        retry_total: Float::INFINITY
       }
     end
 
@@ -276,6 +288,7 @@ module Cucumber
 
     def with_default_features_path(paths)
       return default_features_paths if paths.empty?
+
       paths
     end
 

data/lib/cucumber/constantize.rb

@@ -2,7 +2,7 @@
 
 require 'cucumber/platform'
 module Cucumber
-  module Constantize #:nodoc:
+  module Constantize # :nodoc:
     def constantize(camel_cased_word)
       try = 0
       begin

data/lib/cucumber/deprecate.rb

@@ -4,51 +4,11 @@ require 'cucumber/platform'
 require 'cucumber/gherkin/formatter/ansi_escapes'
 
 module Cucumber
-  module Deprecate
-    class AnsiString
-      include Cucumber::Gherkin::Formatter::AnsiEscapes
-
-      def self.failure_message(message)
-        AnsiString.new.failure_message(message)
-      end
-
-      def failure_message(message)
-        failed + message + reset
-      end
-    end
-
-    class CliOption
-      def self.deprecate(stream, option, message, remove_after_version)
-        return if stream.nil?
-        stream.puts(
-          AnsiString.failure_message(
-            "\nWARNING: #{option} is deprecated" \
-            " and will be removed after version #{remove_after_version}.\n#{message}.\n"
-          )
-        )
-      end
-    end
-
-    module ForUsers
-      def self.call(message, method, remove_after_version)
-        STDERR.puts AnsiString.failure_message(
-          "\nWARNING: ##{method} is deprecated" \
-          " and will be removed after version #{remove_after_version}. #{message}.\n" \
-          "(Called from #{caller(3..3).first})"
-        )
-      end
-    end
-
-    module ForDevelopers
-      def self.call(_message, _method, remove_after_version)
-        raise "This method is due for removal after version #{remove_after_version}" if Cucumber::VERSION > remove_after_version
-      end
-    end
-
-    STRATEGY = $PROGRAM_NAME =~ /rspec$/ ? ForDevelopers : ForUsers
-  end
-
-  def self.deprecate(*args)
-    Deprecate::STRATEGY.call(*args)
+  def self.deprecate(message, method, remove_after_version)
+    $stderr.puts(
+      "\nWARNING: ##{method} is deprecated" \
+        " and will be removed after version #{remove_after_version}. #{message}.\n" \
+        "(Called from #{caller(3..3).first})"
+    )
   end
 end

data/lib/cucumber/errors.rb

@@ -9,9 +9,9 @@ module Cucumber
       return result.with_message(with_prefix(result.message)) if result.is_a?(self)
 
       begin
-        raise new(with_prefix(step_name)) # rubocop:disable Style/RaiseArgs
+        raise self, with_prefix(step_name)
       rescue StandardError => e
-        return e
+        e
       end
     end
 
@@ -35,7 +35,8 @@ module Cucumber
   # Raised when a step matches 2 or more StepDefinitions
   class Ambiguous < StandardError
     def initialize(step_name, step_definitions, used_guess)
-      message = String.new # rubocop:disable Style/EmptyLiteral
+      # TODO: [LH] - Just use a heredoc here to fix this up
+      message = String.new
       message << "Ambiguous match of \"#{step_name}\":\n\n"
       message << step_definitions.map(&:backtrace_line).join("\n")
       message << "\n\n"

data/lib/cucumber/events/envelope.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber

data/lib/cucumber/events/gherkin_source_parsed.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber

data/lib/cucumber/events/gherkin_source_read.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber

data/lib/cucumber/events/hook_test_step_created.rb

@@ -6,8 +6,7 @@ module Cucumber
   module Events
     # Event fired when a step is created from a hook
     class HookTestStepCreated < Core::Event.new(:test_step, :hook)
-      attr_reader :test_step
-      attr_reader :hook
+      attr_reader :test_step, :hook
     end
   end
 end

data/lib/cucumber/events/step_activated.rb

@@ -15,12 +15,6 @@ module Cucumber
       #
       # @return [Cucumber::StepMatch]
       attr_reader :step_match
-
-      # @private
-      def initialize(test_step, step_match)
-        @test_step = test_step
-        @step_match = step_match
-      end
     end
   end
 end

data/lib/cucumber/events/step_definition_registered.rb

@@ -10,11 +10,6 @@ module Cucumber
       #
       # @return [RbSupport::RbStepDefinition]
       attr_reader :step_definition
-
-      # _@private
-      def initialize(step_definition)
-        @step_definition = step_definition
-      end
     end
   end
 end

data/lib/cucumber/events/test_case_created.rb

@@ -6,8 +6,7 @@ module Cucumber
   module Events
     # Event fired when a Test::Case is created from a Pickle
     class TestCaseCreated < Core::Event.new(:test_case, :pickle)
-      attr_reader :test_case
-      attr_reader :pickle
+      attr_reader :test_case, :pickle
     end
   end
 end

data/lib/cucumber/events/test_case_finished.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber

data/lib/cucumber/events/test_case_started.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber

data/lib/cucumber/events/test_run_finished.rb

@@ -5,7 +5,8 @@ require 'cucumber/core/events'
 module Cucumber
   module Events
     # Event fired after all test cases have finished executing
-    class TestRunFinished < Core::Event.new
+    class TestRunFinished < Core::Event.new(:success)
+      attr_reader :success
     end
   end
 end

data/lib/cucumber/events/test_step_created.rb

@@ -6,8 +6,7 @@ module Cucumber
   module Events
     # Event fired when a TestStep is created from a PickleStep
     class TestStepCreated < Core::Event.new(:test_step, :pickle_step)
-      attr_reader :test_step
-      attr_reader :pickle_step
+      attr_reader :test_step, :pickle_step
     end
   end
 end

data/lib/cucumber/events/test_step_finished.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber

data/lib/cucumber/events/test_step_started.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber

data/lib/cucumber/events/undefined_parameter_type.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber
   module Events
     class UndefinedParameterType < Core::Event.new(:type_name, :expression)
-      attr_reader :type_name
-      attr_reader :expression
+      attr_reader :type_name, :expression
     end
   end
 end

data/lib/cucumber/events.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-Dir[File.dirname(__FILE__) + '/events/*.rb'].map(&method(:require))
+Dir["#{File.dirname(__FILE__)}/events/*.rb"].map(&method(:require))
 
 module Cucumber
   # Events tell you what's happening while Cucumber runs your features.
@@ -11,7 +11,7 @@ module Cucumber
   # To subscribe to an event, use {Cucumber::Configuration#on_event}
   #
   # @example
-  #   AfterConfiguration do |config|
+  #   InstallPlugin do |config|
   #     config.on_event :test_case_finished do |event|
   #       puts event.result
   #     end

data/lib/cucumber/file_specs.rb

@@ -5,7 +5,7 @@ require 'cucumber/core/test/location'
 
 module Cucumber
   class FileSpecs
-    FILE_COLON_LINE_PATTERN = /^([\w\W]*?)(?::([\d:]+))?$/ #:nodoc:
+    FILE_COLON_LINE_PATTERN = /^([\w\W]*?)(?::([\d:]+))?$/.freeze # :nodoc:
 
     def initialize(file_specs)
       Cucumber.logger.debug("Features:\n")
@@ -32,6 +32,7 @@ module Cucumber
 
       def locations
         return [Core::Test::Location.new(@file)] if @lines.empty?
+
         @lines.map { |line| Core::Test::Location.new(@file, line) }
       end
     end

data/lib/cucumber/filters/activate_steps.rb

@@ -52,6 +52,7 @@ module Cucumber
             end
             configuration.notify :step_activated, test_step, match
             return SkippingStepMatch.new if configuration.dry_run?
+
             match
           end
 

data/lib/cucumber/filters/retry.rb

@@ -7,6 +7,11 @@ require 'cucumber/events'
 module Cucumber
   module Filters
     class Retry < Core::Filter.new(:configuration)
+      def initialize(*_args)
+        super
+        @total_permanently_failed = 0
+      end
+
       def test_case(test_case)
         configuration.on_event(:test_case_finished) do |event|
           next unless retry_required?(test_case, event)
@@ -21,7 +26,21 @@ module Cucumber
       private
 
       def retry_required?(test_case, event)
-        event.test_case == test_case && event.result.failed? && test_case_counts[test_case] < configuration.retry_attempts
+        return false unless event.test_case == test_case
+
+        return false unless event.result.failed?
+
+        return false if @total_permanently_failed >= configuration.retry_total_tests
+
+        retry_required = test_case_counts[test_case] < configuration.retry_attempts
+        if retry_required
+          # retry test
+          true
+        else
+          # test failed after max. attempts
+          @total_permanently_failed += 1
+          false
+        end
       end
 
       def test_case_counts

data/lib/cucumber/filters/tag_limits/verifier.rb

@@ -47,9 +47,7 @@ module Cucumber
             locations.count
           end
 
-          attr_reader :tag_name
-          attr_reader :limit
-          attr_reader :locations
+          attr_reader :tag_name, :limit, :locations
         end
       end
     end

data/lib/cucumber/filters/tag_limits.rb

@@ -38,9 +38,7 @@ module Cucumber
 
       private
 
-      attr_reader :gated_receiver
-      attr_reader :test_case_index
-      attr_reader :verifier
+      attr_reader :gated_receiver, :test_case_index, :verifier
     end
   end
 end