cucumber 3.0.0 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 062b09830dfcb655af8b4c9fe636bdd72463b563
-  data.tar.gz: c39b88bff9779ab5f09f422a3733b0ee858b1693
+  metadata.gz: f84a6bf158202ae59a9b8db4a2659d3fbb54a8a5
+  data.tar.gz: 5f2c8a03f201b4867664044e46b235c65c384e91
 SHA512:
-  metadata.gz: 4e6e4550d06122cd5edd80628344faae94c67cc583188c09156e0dd51c86f7cc228092cce38a6c7224bcb22b3d4b762d689e4dc8b824f6c4cbbd7c42112dfc88
-  data.tar.gz: 31bd67336e921b7e4565a9289f7293e9f5ba6144f57d0e58103d5f3e936bd523097eb7a6776e64d392e7e16a1a3c6ff15d1f4f143c2675806e4c4c5cc48ea8d9
+  metadata.gz: c24410fe9970358b71f76e01897bf3762e9a14b4d7424309d4f43fc113703e1f07e659acec28313b7958b2e97da05c4bc896ff9e0cc1cd94069f4c339831dab4
+  data.tar.gz: 03ef3f7b197165f8fe83613be7a05d4aa3990f94968b067e3d15539242cc04e24c5136b21d7985298b7062449b8ade8ac4c0707b73d27b90cf33ab480bc9573e

data/CHANGELOG.md

@@ -10,13 +10,21 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 
 ----
 
-## [In Git](https://github.com/cucumber/cucumber-ruby/compare/v3.0.0...master) (targeting 3.1.0)
+## [In Git](https://github.com/cucumber/cucumber-ruby/compare/v3.1.0...master) (Not released)
+
+### Added
+
+* N/A
 
 ### Changed
 
 * N/A
 
-### Added
+### Deprecated
+
+* N/A
+
+### Removed
 
 * N/A
 
@@ -24,14 +32,56 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 
 * N/A
 
+## [3.1.0](https://github.com/cucumber/cucumber-ruby/compare/v3.0.2...3.1.0) (2017-11-28)
+
+### Added
+
+* ParameterType transformer runs in World
+  ([#1213](https://github.com/cucumber/cucumber-ruby/pull/1213)
+   [@aslakhellesoy](https://github.com/aslakhellesoy))
+
+### Changed
+
+* Upgraded to `cucumber-expressions` 5.0.4
+* Upgraded to `cucumber-tag_expressions` 1.1.0
+* Upgraded to `gherkin` 5.0.0
+
+### Fixed
+
+*  Fix the handling of failed hooks in the JUnit Formatter ([@brasmusson](https://github.com/brasmusson))
+
+## [3.0.2](https://github.com/cucumber/cucumber-ruby/compare/v3.0.1...v3.0.2) (2017-11-11)
+
+### Removed
+
+* Cucumber is no longer tested on Ruby 2.1 and below.
+
+### Fixed
+
+* Fix html reporter with more than one embedded screenshot ([#1216](https://github.com/cucumber/cucumber-ruby/pull/1216) [@nonkor](https://github.com/nonkor))
+* Change test expectation to handle Ruby's unstable sorting ([#1210](https://github.com/cucumber/cucumber-ruby/pull/1210) [@jaysonesmith](https://github.com/jaysonesmith))
+* Fix the printing of newlines in the rerun formatter - a problem introduced in [#1162](https://github.com/cucumber/cucumber-ruby/issues/1162) ([#1207](https://github.com/cucumber/cucumber-ruby/issues/1207) [@brasmusson](https://github.com/brasmusson))
+* Handle the `--retry` option in profiles ([#1050](https://github.com/cucumber/cucumber-ruby/issues/1050) [@brasmusson](https://github.com/brasmusson))
+
 ### Improved
 
-* N/A
+* Exclude the legacy_api from rubocop, regenerate Rubocop Todo ([@jaysonesmith](https://github.com/jaysonesmith), [@brasmusson](https://github.com/brasmusson))
+* Review and handle excluded/ignored cops ([#1208](https://github.com/cucumber/cucumber-ruby/pull/1208) [@jaysonesmith](https://github.com/jaysonesmith))
+* Fix SymbolProc issues ([#1212](https://github.com/cucumber/cucumber-ruby/pull/1212) [@jaysonesmith](https://github.com/jaysonesmith))
+* Fix TrailingBlankLines ([#1211](https://github.com/cucumber/cucumber-ruby/pull/1211) [@jaysonesmith](https://github.com/jaysonesmith))
+
+## [3.0.1](https://github.com/cucumber/cucumber-ruby/compare/v3.0.0...3.0.1) (2017-09-29)
+
+### Fixed
+
+* `ParameterType` can now override `use_for_snippets` and `prefer_for_regexp_match` without throwing an error. ([@aslakhellesoy](https://github.com/aslakhellesoy))
+* Gemspec has `required_ruby_version = '>= 2.1'` ([@aslakhellesoy](https://github.com/aslakhellesoy))
 
 ## [3.0.0](https://github.com/cucumber/cucumber-ruby/compare/v3.0.0.pre.2...v3.0.0) (2017-09-27)
 
 ### Changed
 
+* Regexp capture groups with `(\d+)` are automatically converted to `Integer`
 * Rename `Step#name` to `#text` ([#1130](https://github.com/cucumber/cucumber-ruby/pull/1130) [@olleolleolle](https://github.com/olleolleolle))
 * `Transform` has been removed and replaced with `ParameterType`. See [upgrading instructions](https://cucumber.io/blog/2017/09/21/upgrading-to-cucumber-3). ([#1190](https://github.com/cucumber/cucumber-ruby/issues/1190) @aslakhellesoy)
 * Nested capture groups are not counted as parameters. See [upgrading instructions](https://cucumber.io/blog/2017/09/21/upgrading-to-cucumber-3). (@aslakhellesoy)

data/CONTRIBUTING.md

@@ -59,10 +59,8 @@ help us to correct style violations reported here:
 
 ## Release Process
 
-* Bump the version number in `lib/cucumber/platform.rb`.
-* Make sure `History.md` is updated with the upcoming version number, and has entries for all fixes.
-* No need to add a `History.md` header at this point - this should be done when a new change is made, later.
-* Make sure you have up-to-date and clean copy of cucumber/cucumber.github.com.git at the same level as cucumber repo.
+* Bump the version number in `lib/cucumber/version`.
+* Make sure `CHANGELOG.md` is updated with the upcoming version number, and has entries for all fixes.
 
 Now release it
 

data/README.md

@@ -1,6 +1,7 @@
-[![Join the chat at https://gitter.im/cucumber/cucumber-ruby](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/cucumber/cucumber-ruby?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
-[![Build Status](https://travis-ci.org/cucumber/cucumber-ruby.svg?branch=master)](https://travis-ci.org/cucumber/cucumber-ruby)
-[![Windows Build Status](https://ci.appveyor.com/api/projects/status/ncqhcevrv93hhu5j?svg=true)](https://ci.appveyor.com/project/cucumberbdd/cucumber-ruby)
+[![OpenCollective](https://opencollective.com/cucumber/backers/badge.svg)](https://opencollective.com/cucumber)
+[![OpenCollective](https://opencollective.com/cucumber/sponsors/badge.svg)](https://opencollective.com/cucumber)
+
+[![CircleCI](https://circleci.com/gh/cucumber/cucumber-ruby.svg?style=svg)](https://circleci.com/gh/cucumber/cucumber-ruby)
 
 [![Code Climate](https://codeclimate.com/github/cucumber/cucumber-ruby.svg)](https://codeclimate.com/github/cucumber/cucumber-ruby)
 [![Coverage Status](https://coveralls.io/repos/cucumber/cucumber-ruby/badge.svg?branch=master)](https://coveralls.io/r/cucumber/cucumber-ruby?branch=master)
@@ -9,7 +10,7 @@
 # Cucumber
 
 Cucumber is a tool for running automated tests written in plain language. Because they're
-written in plain language, they can be read by anyone on your team. Because they can be 
+written in plain language, they can be read by anyone on your team. Because they can be
 read by anyone, you can use them to help improve communication, collaboration and trust on
 your team.
 
@@ -37,4 +38,4 @@ Everyone interacting in this codebase and issue tracker is expected to follow th
 
 ## Copyright
 
-Copyright (c) Aslak Hellesøy and Contributors. See LICENSE for details.
+Copyright (c) Cucumber Ltd. and Contributors. See LICENSE for details.

data/lib/cucumber/cli/options.rb

@@ -27,7 +27,7 @@ module Cucumber
         'json_pretty' => ['Cucumber::Formatter::JsonPretty',  'Prints the feature as prettified JSON'],
         'summary'     => ['Cucumber::Formatter::Summary',     'Summary output of feature and scenarios']
       }
-      max = BUILTIN_FORMATS.keys.map{|s| s.length}.max
+      max = BUILTIN_FORMATS.keys.map(&:length).max
       FORMAT_HELP_MSG = [
                           'Use --format rerun --out rerun.txt to write out failing',
                           'features. You can rerun them with cucumber @rerun.txt.',
@@ -508,6 +508,8 @@ TEXT
           @options[:formats] = stdout_formats[0..0] + non_stdout_formats
         end
 
+        @options[:retry] = other_options[:retry] if @options[:retry] == 0
+
         self
       end
 

data/lib/cucumber/errors.rb

@@ -38,7 +38,7 @@ module Cucumber
     def initialize(step_name, step_definitions, used_guess)
       message = String.new
       message << "Ambiguous match of \"#{step_name}\":\n\n"
-      message << step_definitions.map{|sd| sd.backtrace_line}.join("\n")
+      message << step_definitions.map(&:backtrace_line).join("\n")
       message << "\n\n"
       message << "You can run again with --guess to make Cucumber be more smart about it\n" unless used_guess
       super(message)

data/lib/cucumber/events/test_step_finished.rb

@@ -16,5 +16,3 @@ module Cucumber
 
   end
 end
-
-

data/lib/cucumber/events/test_step_started.rb

@@ -13,5 +13,3 @@ module Cucumber
 
   end
 end
-
-

data/lib/cucumber/events.rb

@@ -37,4 +37,3 @@ module Cucumber
     end
   end
 end
-

data/lib/cucumber/filters/quit.rb

@@ -26,4 +26,3 @@ module Cucumber
 
   end
 end
-

data/lib/cucumber/formatter/html.rb

@@ -399,7 +399,7 @@ module Cucumber
       def next_id(type)
         @indices ||= Hash.new { 0 }
         @indices[type] += 1
-        "#{type}_#{@indices[:type]}"
+        "#{type}_#{@indices[type]}"
       end
 
       def build_exception_detail(exception)

data/lib/cucumber/formatter/html_builder.rb

@@ -117,4 +117,4 @@ module Cucumber
       end
     end
   end
-end
+end

data/lib/cucumber/formatter/ignore_missing_messages.rb

@@ -18,4 +18,3 @@ module Cucumber
 
   end
 end
-

data/lib/cucumber/formatter/json.rb

@@ -82,7 +82,7 @@ module Cucumber
 
       def embed(src, mime_type, _label)
         if File.file?(src)
-          content = File.open(src, 'rb') { |f| f.read }
+          content = File.open(src, 'rb', &:read)
           data = encode64(content)
         else
           if mime_type =~ /;base64$/

data/lib/cucumber/formatter/json_pretty.rb

@@ -8,4 +8,3 @@ module Cucumber
     end
   end
 end
-

data/lib/cucumber/formatter/junit.rb

@@ -104,8 +104,12 @@ module Cucumber
         output = "#{test_case.keyword}: #{scenario}\n\n"
         return output if result.ok?(@config.strict)
         if test_case.keyword == 'Scenario'
-          output += @failing_step_source.keyword.to_s unless hook?(@failing_step_source)
-          output += "#{@failing_step_source}\n"
+          if @failing_step_source
+            output += @failing_step_source.keyword.to_s unless hook?(@failing_step_source)
+            output += "#{@failing_step_source}\n"
+          else # An Around hook has failed
+            output += "Around hook\n"
+          end
         else
           output += "Example row: #{row_name}\n"
         end

data/lib/cucumber/formatter/rerun.rb

@@ -18,7 +18,7 @@ module Cucumber
         end
         config.on_event :test_run_finished do
           next if @failures.empty?
-          @io.print file_failures.join('\n')
+          @io.print file_failures.join("\n")
         end
       end
 

data/lib/cucumber/formatter/summary.rb

@@ -55,4 +55,3 @@ module Cucumber
     end
   end
 end
-

data/lib/cucumber/glue/dsl.rb

@@ -88,8 +88,8 @@ module Cucumber
 
       def ParameterType(options)
         type = options[:type] || Object
-        use_for_snippets = true if options[:use_for_snippets].nil?
-        prefer_for_regexp_match = false if options[:prefer_for_regexp_match].nil?
+        use_for_snippets = if_nil(options[:use_for_snippets], true)
+        prefer_for_regexp_match = if_nil(options[:prefer_for_regexp_match], false)
 
         parameter_type = CucumberExpressions::ParameterType.new(
           options[:name],
@@ -102,6 +102,10 @@ module Cucumber
         Dsl.define_parameter_type(parameter_type)
       end
 
+      def if_nil(value, default)
+        value.nil? ? default : value
+      end
+
       # Registers a proc that will run after Cucumber is configured. You can register as
       # as you want (typically from ruby scripts under <tt>support/hooks.rb</tt>).
       def AfterConfiguration(&proc)

data/lib/cucumber/glue/proto_world.rb

@@ -148,6 +148,7 @@ module Cucumber
             runtime.invoke_dynamic_steps(steps_text, language, location)
           end
 
+          # rubocop:disable UnneededInterpolation
           define_method(:puts) do |*messages|
             # Even though they won't be output until later, converting the messages to
             # strings right away will protect them from modifications to their original
@@ -156,6 +157,7 @@ module Cucumber
 
             runtime.puts(*messages)
           end
+          # rubocop:enable UnneededInterpolation
 
           define_method(:ask) do |question, timeout_seconds=60|
             runtime.ask(question, timeout_seconds)

data/lib/cucumber/glue/step_definition.rb

@@ -63,7 +63,7 @@ module Cucumber
         end
       end
 
-      attr_reader :expression
+      attr_reader :expression, :registry
 
       def initialize(registry, expression, proc)
         raise 'No regexp' if expression.is_a?(Regexp)

data/lib/cucumber/glue/world_factory.rb

@@ -20,4 +20,4 @@ module Cucumber
     end
 
   end
-end
+end

data/lib/cucumber/hooks.rb

@@ -47,6 +47,10 @@ module Cucumber
         'After hook'
       end
 
+      def to_s
+        "#{text} at #{location}"
+      end
+
       def match_locations?(queried_locations)
         queried_locations.any? { |other_location| other_location.match?(location) }
       end
@@ -67,6 +71,10 @@ module Cucumber
         'Before hook'
       end
 
+      def to_s
+        "#{text} at #{location}"
+      end
+
       def match_locations?(queried_locations)
         queried_locations.any? { |other_location| other_location.match?(location) }
       end
@@ -87,6 +95,10 @@ module Cucumber
         'AfterStep hook'
       end
 
+      def to_s
+        "#{text} at #{location}"
+      end
+
       def match_locations?(queried_locations)
         queried_locations.any? { |other_location| other_location.match?(location) }
       end

data/lib/cucumber/multiline_argument/data_table/diff_matrices.rb

@@ -155,4 +155,3 @@ module Cucumber
     end
   end
 end
-

data/lib/cucumber/multiline_argument/data_table.rb

@@ -195,14 +195,12 @@ module Cucumber
       #
       def raw
         cell_matrix.map do |row|
-          row.map do |cell|
-            cell.value
-          end
+          row.map(&:value)
         end
       end
 
       def column_names #:nodoc:
-        @col_names ||= cell_matrix[0].map { |cell| cell.value }
+        @col_names ||= cell_matrix[0].map(&:value)
       end
 
       def rows
@@ -443,9 +441,7 @@ module Cucumber
       def build_hashes
         convert_headers!
         convert_columns!
-        cells_rows[1..-1].map do |row|
-          row.to_hash
-        end
+        cells_rows[1..-1].map(&:to_hash)
       end
 
       def create_cell_matrix(ast_table) #:nodoc:
@@ -475,14 +471,14 @@ module Cucumber
         header_cells = cell_matrix[0]
 
         if @header_conversion_proc
-          header_values = header_cells.map { |cell| cell.value } - @header_mappings.keys
+          header_values = header_cells.map(&:value) - @header_mappings.keys
           @header_mappings = @header_mappings.merge(Hash[*header_values.zip(header_values.map(&@header_conversion_proc)).flatten])
         end
 
         @header_mappings.each_pair do |pre, post|
           mapped_cells = header_cells.select { |cell| pre === cell.value }
           raise "No headers matched #{pre.inspect}" if mapped_cells.empty?
-          raise "#{mapped_cells.length} headers matched #{pre.inspect}: #{mapped_cells.map { |c| c.value }.inspect}" if mapped_cells.length > 1
+          raise "#{mapped_cells.length} headers matched #{pre.inspect}: #{mapped_cells.map(&:value).inspect}" if mapped_cells.length > 1
           mapped_cells[0].value = post
           if @conversion_procs.key?(pre)
             @conversion_procs[post] = @conversion_procs.delete(pre)
@@ -524,7 +520,7 @@ module Cucumber
 
         # For testing only
         def to_sexp #:nodoc:
-          [:row, line, *@cells.map{|cell| cell.to_sexp}]
+          [:row, line, *@cells.map(&:to_sexp)]
         end
 
         def to_hash #:nodoc:

data/lib/cucumber/multiline_argument.rb

@@ -18,7 +18,7 @@ module Cucumber
           builder.doc_string(Core::Ast::DocString.new(argument, content_type, location))
         when Array
           location = location.on_line(argument.first.line..argument.last.line)
-          builder.data_table(argument.map{ |row| row.cells }, location)
+          builder.data_table(argument.map(&:cells), location)
         when DataTable, DocString, None
           argument
         when nil

data/lib/cucumber/step_definitions.rb

@@ -8,7 +8,7 @@ module Cucumber
     end
 
     def to_json
-      @support_code.step_definitions.map{|stepdef| stepdef.to_hash}.to_json
+      @support_code.step_definitions.map(&:to_hash).to_json
     end
   end
 end

data/lib/cucumber/step_match.rb

@@ -13,7 +13,10 @@ module Cucumber
     end
 
     def args
-      @step_arguments.map{|g| g.value }
+      current_world = @step_definition.registry.current_world
+      @step_arguments.map do |arg|
+        arg.value(current_world)
+      end
     end
 
     def activate(test_step)

data/lib/cucumber/step_match_search.rb

@@ -39,7 +39,7 @@ module Cucumber
         top_groups     = step_matches.select {|step_match| step_match.args.length == max_arg_length }
 
         if no_groups.any?
-          longest_regexp_length = no_groups.map {|step_match| step_match.text_length }.max
+          longest_regexp_length = no_groups.map(&:text_length).max
           no_groups.select {|step_match| step_match.text_length == longest_regexp_length }
         elsif top_groups.any?
           shortest_capture_length = top_groups.map {|step_match| step_match.args.inject(0) {|sum, c| sum + c.to_s.length } }.min

data/lib/cucumber/version

@@ -1 +1 @@
-3.0.0
+3.1.0