cucumber 3.0.0.pre.2 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a5726ed71d8a00221ac4b3b7fc15da681ea138a6
-  data.tar.gz: 2479723768c4452ef329c47cb63971e1632adae6
+  metadata.gz: 59a692d9b2bb6abe44ffda39687077d9a9875ac6
+  data.tar.gz: 68b322f2c42b48b161c37af0d5ceb6e80f7604a6
 SHA512:
-  metadata.gz: c963597cfb7056f8240bc532c9712e32fbb61a00a62ddda19bacb86a7ffbaa900b3253b8e7f54317272519df0480e9da3056b6fc9d4f1364b5f487bea564d2fb
-  data.tar.gz: ac436dc31a3e6ba2ef71745a529c70d90160c586fb190a8aedc2e829ea79f3a610621aab0704985951492e032bbacce6a35638d712d12665eea5a678b1a8e76f
+  metadata.gz: bd06621e7445264cb47e0a9a9ef77274d682de78dbf7519d620283aadd82dbee7a0aa3491b37142f9e370355a40de6b048d55742366ae3d0cad1f853433f32b6
+  data.tar.gz: fe939354cfd699bcdf9381bc5f4ed59d041c4cfb8ce33c438671ce49ee6754ee3a4bc728ffb3f1a95f16539d01760d66c89f8ac52ded72b537889bb4ba091098

data/.gitattributes

@@ -0,0 +1,32 @@
+# Set the default behavior, in case people don't have core.autocrlf set.
+* text eol=lf
+
+# Explicitly declare text files to always be normalized and converted
+# to native line endings on checkout.
+*.css text eol=lf
+*.feature text eol=lf
+*.gemspec text eol=lf
+*.js text eol=lf
+*.md text eol=lf
+*.rake text eol=lf
+*.rb text eol=lf
+*.sass text eol=lf
+*.tcl text eol=lf
+*.textile text eol=lf
+*.txt text eol=lf
+*.xml text eol=lf
+*.yml text eol=lf
+Gemfile text eol=lf
+LICENSE text eol=lf
+Rakefile text eol=lf
+.cucumberproignore text eol=lf
+.gitignore text eol=lf
+.rspec text eol=lf
+.ruby-gemset text eol=lf
+.yardopts text eol=lf
+scripts/* text eol=lf
+
+# Denote all files that are truly binary and should not be modified.
+# These patterns are here as an example; we have 0 of these.
+*.png binary
+*.jpg binary

data/.github/ISSUE_TEMPLATE.md

@@ -10,7 +10,7 @@ In general: Please provide as much information as you can to help us solving you
 
 <!--- If you're describing a bug, tell us what should happen -->
 <!--- If you're suggesting a change/improvement, tell us how it should work -->
-<!--- Feel free to use Given / Then / Then if that helps, but please add some plain-language context too -->
+<!--- Feel free to use Given / When / Then if that helps, but please add some plain-language context too -->
 
 ## Current Behavior
 

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -26,6 +26,7 @@
 ## Types of changes
 
 <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
+- [ ] Refactor (code change that does not change external functionality)
 - [ ] Bug fix (non-breaking change which fixes an issue)
 - [ ] New feature (non-breaking change which adds functionality)
 - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

data/.rubocop_todo.yml

@@ -15,17 +15,6 @@ Lint/AmbiguousOperator:
     - 'spec/cucumber/formatter/legacy_api/adapter_spec.rb'
     - 'spec/cucumber/formatter/spec_helper.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Lint/DeprecatedClassMethods:
-  Exclude:
-    - 'lib/cucumber/project_initializer.rb'
-
-# Offense count: 2
-Lint/DuplicateMethods:
-  Exclude:
-    - 'lib/cucumber/multiline_argument.rb'
-
 # Offense count: 2
 Lint/Eval:
   Exclude:
@@ -146,16 +135,6 @@ Style/Alias:
   Exclude:
     - 'lib/cucumber/formatter/ansicolor.rb'
 
-# Offense count: 1197
-# Cop supports --auto-correct.
-Style/AlignArray:
-  Exclude:
-    - 'lib/cucumber/cli/options.rb'
-    - 'lib/cucumber/rake/task.rb'
-    - 'spec/cucumber/formatter/legacy_api/adapter_spec.rb'
-    - 'spec/cucumber/multiline_argument/data_table_spec.rb'
-    - 'spec/cucumber/rake/forked_spec.rb'
-
 # Offense count: 20
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
@@ -167,16 +146,6 @@ Style/AlignParameters:
     - 'lib/cucumber/cli/options.rb'
     - 'lib/cucumber/runtime/for_programming_languages.rb'
 
-# Offense count: 11
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: always, conditionals
-Style/AndOr:
-  Exclude:
-    - 'lib/autotest/cucumber_mixin.rb'
-    - 'lib/cucumber/formatter/html.rb'
-    - 'lib/cucumber/formatter/legacy_api/adapter.rb'
-
 # Offense count: 19
 Style/AsciiComments:
   Exclude:
@@ -288,63 +257,10 @@ Style/ClassAndModuleChildren:
     - 'spec/cucumber/formatter/legacy_api/adapter_spec.rb'
     - 'spec/cucumber/hooks_spec.rb'
 
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: is_a?, kind_of?
-Style/ClassCheck:
-  Exclude:
-    - 'lib/cucumber/formatter/legacy_api/ast.rb'
-    - 'lib/cucumber/hooks.rb'
-    - 'lib/cucumber/multiline_argument/data_table.rb'
-
 # Offense count: 2
 Style/ClassVars:
   Exclude:
-    - 'lib/cucumber/formatter/html.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/ClosingParenthesisIndentation:
-  Exclude:
-    - 'spec/cucumber/cli/options_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/ColonMethodCall:
-  Exclude:
-    - 'lib/cucumber/cli/profile_loader.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: Keywords.
-# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
-Style/CommentAnnotation:
-  Exclude:
-    - 'lib/cucumber/cli/configuration.rb'
-    - 'lib/cucumber/configuration.rb'
-    - 'lib/cucumber/formatter/legacy_api/adapter.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/CommentIndentation:
-  Exclude:
-    - 'lib/cucumber/formatter/html.rb'
-    - 'spec/cucumber/world/pending_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
-# SupportedStyles: assign_to_condition, assign_inside_condition
-Style/ConditionalAssignment:
-  Exclude:
-    - 'lib/cucumber/runtime/for_programming_languages.rb'
-    - 'lib/cucumber/runtime/user_interface.rb'
-
-# Offense count: 1
-Style/ConstantName:
-  Exclude:
-    - 'lib/cucumber/deprecate.rb'
+   - 'lib/cucumber/formatter/html.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.

data/.travis.yml

@@ -1,5 +1,6 @@
 sudo: false
 
+# Keep in sync with cucumber.gemspec's required_ruby_version
 matrix:
   include:
     - rvm: ruby-head
@@ -23,7 +24,7 @@ matrix:
       os: linux
     - rvm: 2.1
       os: osx
-    - rvm: jruby-9.1.12.0
+    - rvm: jruby-9.1.13.0
       os: linux
       env:
         # Travis by default also have "-Dcext.enabled=false" set in
@@ -35,7 +36,7 @@ matrix:
         - LC_ALL=en_US.UTF-8
         - LANG=en_US.UTF-8
         - LANGUAGE=en_US.UTF-8
-    - rvm: jruby-9.1.12.0
+    - rvm: jruby-9.1.13.0
       os: osx
       env:
         # Travis by default also have "-Dcext.enabled=false" set in

data/{History.md → CHANGELOG.md}

@@ -1,11 +1,76 @@
-## [In Git](https://github.com/cucumber/cucumber-ruby/compare/v3.0.0.pre.2...master)
+# CHANGE LOG
 
-### Breaking changes
-### New Features
-### Bugfixes
-### Refactoring / Developer Experience
+All notable changes to this project will be documented in this file.
+
+This project adheres to [Semantic Versioning](http://semver.org).
+
+This document is formatted according to the principles of [Keep A CHANGELOG](http://keepachangelog.com).
+
+Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CONTRIBUTING.md) for more info on how to contribute to Cucumber.
+
+----
+
+## [In Git](https://github.com/cucumber/cucumber-ruby/compare/v3.0.1...master) (Not released)
+
+### Changed
+
+* N/A
+
+### Added
+
+* N/A
+
+### Fixed
+
+* N/A
+
+### Improved
+
+* N/A
+
+## [In Git](https://github.com/cucumber/cucumber-ruby/compare/v3.0.0...3.0.1) (2017-09-29)
+
+### Fixed
+
+* `ParameterType` can now override `use_for_snippets` and `prefer_for_regexp_match` without throwing an error. ([@aslakhellesoy](https://github.com/aslakhellesoy))
+* Gemspec has `required_ruby_version = '>= 2.1'` ([@aslakhellesoy](https://github.com/aslakhellesoy))
+
+## [3.0.0](https://github.com/cucumber/cucumber-ruby/compare/v3.0.0.pre.2...v3.0.0) (2017-09-27)
+
+### Changed
+
+* Regexp capture groups with `(\d+)` are automatically converted to `Integer`
+* Rename `Step#name` to `#text` ([#1130](https://github.com/cucumber/cucumber-ruby/pull/1130) [@olleolleolle](https://github.com/olleolleolle))
+* `Transform` has been removed and replaced with `ParameterType`. See [upgrading instructions](https://cucumber.io/blog/2017/09/21/upgrading-to-cucumber-3). ([#1190](https://github.com/cucumber/cucumber-ruby/issues/1190) @aslakhellesoy)
+* Nested capture groups are not counted as parameters. See [upgrading instructions](https://cucumber.io/blog/2017/09/21/upgrading-to-cucumber-3). (@aslakhellesoy)
+
+### Added
+
+* Handle selective strict options. ([#1169](https://github.com/cucumber/cucumber-ruby/pull/1169), [#1160](https://github.com/cucumber/cucumber-ruby/issues/1160) @brasmusson)
+
+### Fixed
+
+* Use absolute path in IO formatter to prevent `chdir` issues. ([#1111](https://github.com/cucumber/cucumber-ruby/pull/1111/files) @akostadinov)
+
+* Fix bug in DataTable#symbolic_hashes ([#1200](https://github.com/cucumber/cucumber-ruby/pull/1200) @Ben-Behar)
+
+* Fix typo in JSON formatter ([#1196](https://github.com/cucumber/cucumber-ruby/pull/1196) @alb-i986)
+
+* Handle ambiguous steps as failed steps, when not using `--guess` ([#1132](https://github.com/cucumber/cucumber-ruby/pull/1132), [#1113](https://github.com/cucumber/cucumber-ruby/issues/1113) @MadameSheema, @enkessler, @brasmusson)
+
+### Improved
+
+* Refactor: Extract HTMLBuilder#string_to_embed method to DRY up code ([#1187](https://github.com/cucumber/cucumber-ruby/pulls/1187) [@danascheider](https://github.com/danascheider))
+* As per [#251](https://github.com/cucumber/cucumber/issues/251): renamed History.md to CHANGELOG.md, added contributing message at beginning, and misc formatting. ([#1185](https://github.com/cucumber/cucumber-ruby/issues/1185) [jaysonesmith](https://github.com/jaysonesmith))
+* Use past tense in event names (`xStarting` -> `xStarted`) ([#1166](https://github.com/cucumber/cucumber-ruby/issues/1166) @brasmusson).
+* Fix Lint/DeprecatedClassMethods ([#1172](https://github.com/cucumber/cucumber-ruby/issues/1172) [jaysonesmith](https://github.com/jaysonesmith))
+* Fix Lint/DuplicateMethods ([#1173](https://github.com/cucumber/cucumber-ruby/issues/1173) [jaysonesmith](https://github.com/jaysonesmith))
+* Fix Metrics/LineLength ([#1175](https://github.com/cucumber/cucumber-ruby/issues/1175), [#1175](https://github.com/cucumber/cucumber-ruby/issues/1175), [#1176](https://github.com/cucumber/cucumber-ruby/issues/1176) [jaysonesmith](https://github.com/jaysonesmith))
+* Fix Style/AlignArray ([#1177](https://github.com/cucumber/cucumber-ruby/issues/1177) [jaysonesmith](https://github.com/jaysonesmith))
+* Fix Style/AndOr ([#1178](https://github.com/cucumber/cucumber-ruby/issues/1178) [jaysonesmith](https://github.com/jaysonesmith))
+* Fix Multiple Cops ([#1179](https://github.com/cucumber/cucumber-ruby/issues/1179) [jaysonesmith](https://github.com/jaysonesmith))
 
-## [3.0.0.pre.1](https://github.com/cucumber/cucumber-ruby/compare/v2.4.0...v3.0.0.pre.2)
+## [3.0.0.pre.2](https://github.com/cucumber/cucumber-ruby/compare/v2.4.0...v3.0.0.pre.2)
 
 ### Breaking changes
 
@@ -29,8 +94,7 @@
 
 ### Bugfixes
 
-* Fix the profile loader on Windows ([#1133(https://api.github.com/repos/cucumber/cucumber-ruby/pulls/1133) @enkessler)
-* Fix incorrect `DataTable#diff!` results ([#1102](https://github.com/cucumber/cucumber-ruby/pulls/1102) @)
+* Fix the profile loader on Windows ([#1133](https://github.com/cucumber/cucumber-ruby/pulls/1133) @enkessler)
 * Fix incorrect `DataTable#diff!` results ([#1102](https://github.com/cucumber/cucumber-ruby/pulls/1102) @botandrose)
 * Do not apply the hooks to the test case several times when using the retry option ([#1098](https://github.com/cucumber/cucumber-ruby/issues/1098) @brasmusson)
 * Fix bug in comparing empty data tables ([#1097](https://github.com/cucumber/cucumber-ruby/pulls/1097), resolves [#1096](https://github.com/cucumber/cucumber-ruby/issues/1096))
@@ -44,11 +108,11 @@
 
 ### Refactoring / Developer Experience
 
-* Spec: Events.registry exercised ([#1126(https://api.github.com/repos/cucumber/cucumber-ruby/pulls/1126) @olleolleolle)
-* Remove programming language abstraction ([#1131(https://api.github.com/repos/cucumber/cucumber-ruby/pulls/1131) @tooky, @mattwynne)
-* Update cucumber yaml to use new tag syntax ([#1147(https://api.github.com/repos/cucumber/cucumber-ruby/pulls/1147) @danascheider)
-* Turn off Windows failures ([#1142(https://api.github.com/repos/cucumber/cucumber-ruby/pulls/1142) @enkessler)
-* Add script to update history.md ([#1141(https://api.github.com/repos/cucumber/cucumber-ruby/pulls/1141) @mattwynne)
+* Spec: Events.registry exercised ([#1126](https://github.com/cucumber/cucumber-ruby/pulls/1126) @olleolleolle)
+* Remove programming language abstraction ([#1131](https://github.com/cucumber/cucumber-ruby/pulls/1131) @tooky, @mattwynne)
+* Update cucumber yaml to use new tag syntax ([#1147](https://github.com/cucumber/cucumber-ruby/pulls/1147) @danascheider)
+* Turn off Windows failures ([#1142](https://github.com/cucumber/cucumber-ruby/pulls/1142) @enkessler)
+* Add script to update history.md ([#1141](https://github.com/cucumber/cucumber-ruby/pulls/1141) @mattwynne)
 * Update Ruby 2.3 and 2.4 in .travis.yml ([#1100](https://github.com/cucumber/cucumber-ruby/pull/1100) @junaruga)
 * Fixes for rubocop violations ([#1095](https://github.com/cucumber/cucumber-ruby/pull/1095) @bv)
 * Fixes for rubocop violations ([#1042](https://github.com/cucumber/cucumber-ruby/pull/1042) @phoebeclarke)

data/appveyor.yml

@@ -23,4 +23,5 @@ test_script:
 notifications:
   - provider: Slack
     incoming_webhook:
-      secure: https://hooks.slack.com/services/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
+      secure: Zj2V5eXlqH4jMNvdzMBmdLA+lr658qwlJO+o7yfvUc1TMRSLNQaId9rpVWX+FsEH6DsQxYr46BRWU0bymATBe7rf7KSkomCgsAdupvKYciI=
+

data/bin/cucumber

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
-$:.unshift(File.dirname(__FILE__) + '/../lib') unless $:.include?(File.dirname(__FILE__) + '/../lib')
+file_name = File.dirname(__FILE__) + '/../lib'
+$:.unshift(file_name) unless $:.include?(file_name)
 
 require 'simplecov_setup'
 require 'cucumber/rspec/disable_option_parser'

data/cucumber.gemspec

@@ -9,8 +9,8 @@ Gem::Specification.new do |s|
   s.license     = 'MIT'
   s.homepage    = 'https://cucumber.io/'
   s.platform    = Gem::Platform::RUBY
-  s.required_ruby_version = '>= 1.9.3'
-  s.add_dependency 'cucumber-core', '3.0.0.pre.2'
+  s.required_ruby_version = '>= 2.1' # Keep in sync with .travis.yml
+  s.add_dependency 'cucumber-core', '~> 3.0.0'
   s.add_dependency 'builder', '>= 2.1.2'
   s.add_dependency 'diff-lcs', '~> 1.3'
   s.add_dependency 'gherkin', '~> 4.0'

data/examples/i18n/ar/features/step_definitions/calculator_steps.rb

@@ -1,5 +1,10 @@
 # encoding: utf-8
-begin require 'rspec/expectations'; rescue LoadError; require 'spec/expectations'; end
+begin
+  require 'rspec/expectations'
+rescue LoadError
+  require 'spec/expectations'
+end
+
 require 'cucumber/formatter/unicode'
 $:.unshift(File.dirname(__FILE__) + '/../../lib')
 require 'calculator'

data/examples/i18n/bg/features/support/env.rb

@@ -1,5 +1,10 @@
 # encoding: utf-8
-begin require 'rspec/expectations'; rescue LoadError; require 'spec/expectations'; end
+begin
+  require 'rspec/expectations'
+rescue LoadError
+  require 'spec/expectations'
+end
+
 require 'cucumber/formatter/unicode'
 $:.unshift(File.dirname(__FILE__) + '/../../lib')
 require 'calculator'

data/examples/i18n/bg/lib/calculator.rb

@@ -18,7 +18,8 @@ class Calculator
   end
 
   def /
-    divisor, dividend = [@stack.pop, @stack.pop] # Hm, @stack.pop(2) doesn't work
+    divisor, dividend = [@stack.pop, @stack.pop]
+    # Hm, @stack.pop(2) doesn't work
     @stack.push dividend / divisor
   end
 end

data/examples/i18n/ca/features/step_definitions/calculator_steps.rb

@@ -1,5 +1,10 @@
 # encoding: utf-8
-begin require 'rspec/expectations'; rescue LoadError; require 'spec/expectations'; end
+begin
+  require 'rspec/expectations'
+rescue LoadError
+  require 'spec/expectations'
+end
+
 require 'cucumber/formatter/unicode'
 $:.unshift(File.dirname(__FILE__) + '/../../lib')
 require 'calculadora'

data/examples/i18n/cs/features/step_definitions/calculator_steps.rb

@@ -1,5 +1,10 @@
 # encoding: utf-8
-begin require 'rspec/expectations'; rescue LoadError; require 'spec/expectations'; end
+begin
+  require 'rspec/expectations'
+rescue LoadError
+  require 'spec/expectations'
+end
+
 require 'cucumber/formatter/unicode'
 $:.unshift(File.dirname(__FILE__) + '/../../lib')
 require 'calculator'

data/examples/i18n/da/features/step_definitions/lommeregner_steps.rb

@@ -1,5 +1,10 @@
 # encoding: utf-8
-begin require 'rspec/expectations'; rescue LoadError; require 'spec/expectations'; end
+begin
+  require 'rspec/expectations'
+rescue LoadError
+  require 'spec/expectations'
+end
+
 require 'cucumber/formatter/unicode'
 $:.unshift(File.dirname(__FILE__) + '/../../lib')
 require 'lommeregner'

data/examples/i18n/de/features/step_definitions/calculator_steps.rb

@@ -1,5 +1,10 @@
 # encoding: utf-8
-begin require 'rspec/expectations'; rescue LoadError; require 'spec/expectations'; end
+begin
+  require 'rspec/expectations'
+rescue LoadError
+  require 'spec/expectations'
+end
+
 require 'cucumber/formatter/unicode'
 $:.unshift(File.dirname(__FILE__) + '/../../lib')
 require 'calculator'

data/examples/i18n/el/features/step_definitions/calculator_steps.rb

@@ -1,5 +1,10 @@
 # encoding: utf-8
-begin require 'rspec/expectations'; rescue LoadError; require 'spec/expectations'; end
+begin
+  require 'rspec/expectations'
+rescue LoadError
+  require 'spec/expectations'
+end
+
 require 'cucumber/formatter/unicode'
 $:.unshift(File.dirname(__FILE__) + '/../../lib')
 require 'calculator'

data/examples/i18n/en-lol/features/support/env.rb

@@ -1,7 +1,11 @@
 # encoding: utf-8
-require 'cucumber/formatter/unicode'
-begin require 'rspec/expectations'; rescue LoadError; require 'spec/expectations'; end
+begin
+  require 'rspec/expectations'
+rescue LoadError
+  require 'spec/expectations'
+end
 
+require 'cucumber/formatter/unicode'
 $:.unshift(File.dirname(__FILE__) + '/../../lib')
 require 'basket'
 require 'belly'