cucumber 3.0.0.pre.2 → 3.0.0

data/spec/cucumber/formatter/junit_spec.rb

@@ -43,7 +43,7 @@ module Cucumber
             "
           class Junit
             def before_step(step)
-              return unless step.name.match('a passing ctrl scenario')
+              return unless step.text.match('a passing ctrl scenario')
               Interceptor::Pipe.unwrap! :stdout
               @fake_io = $stdout = StringIO.new
               $stdout.sync = true
@@ -51,7 +51,7 @@ module Cucumber
             end
 
             def after_step(step)
-              return unless step.name.match('a passing ctrl scenario')
+              return unless step.text.match('a passing ctrl scenario')
               @interceptedout.write("boo\b\cx\e\a\f boo ")
               $stdout = STDOUT
               @fake_io.close
@@ -116,8 +116,8 @@ module Cucumber
                   Given a passing scenario
             }, File.join('features', 'some', 'path', 'spec.feature')
 
-            it 'writes the filename including the subdirectory' do
-              expect(@formatter.written_files.keys.first).to eq File.join('', 'TEST-features-some-path-spec.xml')
+            it 'writes the filename with absolute path' do
+              expect(@formatter.written_files.keys.first).to eq File.absolute_path('TEST-features-some-path-spec.xml')
             end
           end
 

data/spec/cucumber/formatter/legacy_api/adapter_spec.rb

@@ -111,6 +111,7 @@ module Cucumber
           runner = Core::Test::Runner.new(events)
           compile gherkin_docs, runner, default_filters
           events.test_run_finished
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
             :before_features,
               :before_feature,
@@ -149,66 +150,7 @@ module Cucumber
               :after_feature,
             :after_features
           ]
-        end
-
-        it 'a scenario with no steps' do
-          execute_gherkin do
-            feature do
-              scenario
-            end
-          end
-
-          expect( formatter.legacy_messages ).to eq [
-              :before_features,
-                :before_feature,
-                  :before_tags,
-                  :after_tags,
-                  :feature_name,
-                  :before_feature_element,
-                    :before_tags,
-                      :after_tags,
-                    :scenario_name,
-                  :after_feature_element,
-                :after_feature,
-              :after_features
-          ]
-        end
-
-        it 'a scenario with no steps coming after another scenario' do
-          execute_gherkin do
-            feature do
-              scenario do
-                step 'passing'
-              end
-              scenario
-            end
-          end
-          expect( formatter.legacy_messages ).to eq [
-              :before_features,
-                :before_feature,
-                  :before_tags,
-                  :after_tags,
-                  :feature_name,
-                  :before_feature_element,
-                    :before_tags,
-                      :after_tags,
-                    :scenario_name,
-                    :before_steps,
-                      :before_step,
-                        :before_step_result,
-                        :step_name,
-                        :after_step_result,
-                      :after_step,
-                    :after_steps,
-                  :after_feature_element,
-                  :before_feature_element,
-                    :before_tags,
-                      :after_tags,
-                    :scenario_name,
-                  :after_feature_element,
-                :after_feature,
-              :after_features
-          ]
+          # rubocop:enable AlignArray
         end
 
         it 'a scenario with one step' do
@@ -219,6 +161,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -240,6 +184,7 @@ module Cucumber
                 :after_feature,
               :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a scenario with two steps, one of them failing' do
@@ -291,6 +236,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -324,6 +271,7 @@ module Cucumber
                 :after_feature,
               :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background and an empty scenario' do
@@ -335,6 +283,8 @@ module Cucumber
               scenario
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
             :before_features,
               :before_feature,
@@ -359,6 +309,7 @@ module Cucumber
               :after_feature,
             :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background and two scenarios' do
@@ -375,6 +326,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -418,6 +371,7 @@ module Cucumber
                 :after_feature,
               :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background and one scenario and one scenario outline' do
@@ -438,6 +392,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -500,6 +456,7 @@ module Cucumber
                 :after_feature,
               :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background and one scenario outline and one scenario' do
@@ -520,6 +477,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -582,6 +541,7 @@ module Cucumber
                 :after_feature,
               :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background and two scenario outlines' do
@@ -606,6 +566,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -687,6 +649,7 @@ module Cucumber
                 :after_feature,
               :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background and one scenario outline with two rows' do
@@ -705,6 +668,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -760,6 +725,7 @@ module Cucumber
                 :after_feature,
               :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background and one scenario outline with two examples tables' do
@@ -781,6 +747,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -848,6 +816,7 @@ module Cucumber
                 :after_feature,
               :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background with two steps' do
@@ -862,6 +831,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -898,6 +869,7 @@ module Cucumber
                 :after_feature,
               :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a background' do
@@ -956,6 +928,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -996,6 +970,7 @@ module Cucumber
                 :after_feature,
               :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'scenario outline after scenario' do
@@ -1013,6 +988,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -1065,6 +1042,7 @@ module Cucumber
                 :after_feature,
               :after_features
           ]
+          # rubocop:enable AlignArray
         end
 
         it 'scenario outline before scenario' do
@@ -1082,6 +1060,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -1134,6 +1114,7 @@ module Cucumber
                 :after_feature,
               :after_features
             ]
+          # rubocop:enable AlignArray
         end
 
         it 'scenario outline two rows' do
@@ -1149,6 +1130,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -1194,6 +1177,7 @@ module Cucumber
                 :after_feature,
               :after_features
             ]
+          # rubocop:enable AlignArray
         end
 
         it 'scenario outline two examples tables' do
@@ -1212,6 +1196,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -1269,6 +1255,7 @@ module Cucumber
                 :after_feature,
               :after_features
             ]
+          # rubocop:enable AlignArray
         end
 
         it 'two scenario outline' do
@@ -1290,6 +1277,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -1361,6 +1350,7 @@ module Cucumber
                 :after_feature,
               :after_features
             ]
+          # rubocop:enable AlignArray
         end
 
         it 'failing scenario outline' do
@@ -1375,6 +1365,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -1415,6 +1407,7 @@ module Cucumber
                 :after_feature,
               :after_features
             ]
+          # rubocop:enable AlignArray
         end
 
         it 'a feature with a failing background and two scenarios' do
@@ -1431,6 +1424,8 @@ module Cucumber
               end
             end
           end
+
+          # rubocop:disable AlignArray
           expect( formatter.legacy_messages ).to eq [
               :before_features,
                 :before_feature,
@@ -1475,6 +1470,7 @@ module Cucumber
                 :after_feature,
               :after_features
             ]
+          # rubocop:enable AlignArray
         end
 
         context 'in expand mode' do
@@ -1494,6 +1490,8 @@ module Cucumber
                 end
               end
             end
+
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq [
                 :before_features,
                   :before_feature,
@@ -1536,6 +1534,7 @@ module Cucumber
                   :after_feature,
                 :after_features
               ]
+            # rubocop:enable AlignArray
           end
         end
 
@@ -1561,6 +1560,8 @@ module Cucumber
                 end
               end
             end
+
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
                 :before_features,
                   :before_feature,
@@ -1582,7 +1583,8 @@ module Cucumber
                     :after_feature_element,
                   :after_feature,
                 :after_features
-                ])
+              ])
+            # rubocop:enable AlignArray
           end
         end
 
@@ -1608,6 +1610,7 @@ module Cucumber
               end
             end
 
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
                 :before_features,
                   :before_feature,
@@ -1629,7 +1632,8 @@ module Cucumber
                     :after_feature_element,
                   :after_feature,
                 :after_features
-                ])
+              ])
+            # rubocop:enable AlignArray
           end
 
           it 'prints the exception after the background name' do
@@ -1649,6 +1653,7 @@ module Cucumber
               end
             end
 
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
                 :before_features,
                   :before_feature,
@@ -1680,7 +1685,8 @@ module Cucumber
                     :after_feature_element,
                   :after_feature,
                 :after_features
-                ])
+              ])
+            # rubocop:enable AlignArray
           end
 
 
@@ -1702,6 +1708,7 @@ module Cucumber
               end
             end
 
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
                 :before_features,
                   :before_feature,
@@ -1743,6 +1750,7 @@ module Cucumber
                   :after_feature,
                 :after_features
               ])
+            # rubocop:enable AlignArray
           end
         end
 
@@ -1771,6 +1779,7 @@ module Cucumber
               end
             end
 
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
                 :before_features,
                   :before_feature,
@@ -1792,7 +1801,8 @@ module Cucumber
                     :after_feature_element,
                   :after_feature,
                 :after_features
-                ])
+              ])
+            # rubocop:enable AlignArray
           end
         end
 
@@ -1819,6 +1829,7 @@ module Cucumber
               end
             end
 
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
               :before_features,
                 :before_feature,
@@ -1841,6 +1852,7 @@ module Cucumber
                 :after_feature,
               :after_features
             ])
+            # rubocop:enable AlignArray
           end
 
           it 'prints the exception after the examples table row' do
@@ -1861,6 +1873,7 @@ module Cucumber
               end
             end
 
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
               :before_features,
                 :before_feature,
@@ -1902,6 +1915,7 @@ module Cucumber
                 :after_feature,
               :after_features
             ])
+            # rubocop:enable AlignArray
           end
         end
 
@@ -1928,6 +1942,7 @@ module Cucumber
               end
             end
 
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
               :before_features,
                 :before_feature,
@@ -1950,38 +1965,7 @@ module Cucumber
                 :after_feature,
               :after_features
             ])
-          end
-        end
-
-        context 'with an exception in an after hook but no steps' do
-          it 'prints the exception after the scenario name' do
-            filters = [
-              Filters::ActivateSteps.new(step_match_search, runtime.configuration),
-              Filters::ApplyAfterHooks.new(FailingAfterHook.new),
-              AddBeforeAndAfterHooks.new
-            ]
-            execute_gherkin(filters) do
-              feature do
-                scenario do
-                end
-              end
-            end
-
-            expect( formatter.legacy_messages ).to eq([
-              :before_features,
-                :before_feature,
-                  :before_tags,
-                  :after_tags,
-                  :feature_name,
-                  :before_feature_element,
-                    :before_tags,
-                    :after_tags,
-                    :scenario_name,
-                    :exception,
-                  :after_feature_element,
-                :after_feature,
-              :after_features
-            ])
+            # rubocop:enable AlignArray
           end
         end
 
@@ -2003,10 +1987,12 @@ module Cucumber
             execute_gherkin(filters) do
               feature do
                 scenario do
+                  step 'passing'
                 end
               end
             end
 
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
               :before_features,
                 :before_feature,
@@ -2022,6 +2008,7 @@ module Cucumber
                 :after_feature,
               :after_features
             ])
+            # rubocop:enable AlignArray
           end
         end
 
@@ -2047,7 +2034,7 @@ module Cucumber
                 end
               end
             end
-
+            # rubocop:disable AlignArray
             expect( formatter.legacy_messages ).to eq([
               :before_features,
                 :before_feature,
@@ -2070,6 +2057,7 @@ module Cucumber
                 :after_feature,
               :after_features
             ])
+            # rubocop:enable AlignArray
           end
         end
       end
@@ -2126,7 +2114,7 @@ module Cucumber
       end
 
       context 'in strict mode' do
-        let(:runtime) { Runtime.new strict: true }
+        let(:runtime) { Runtime.new strict: Cucumber::Core::Test::Result::StrictConfiguration.new([:undefined]) }
 
         it 'passes an exception to the formatter for undefined steps' do
           expect( formatter ).to receive(:exception) do |exception|