cucumber 3.0.0.pre.1 → 3.0.0.pre.2

data/spec/cucumber/formatter/junit_spec.rb

@@ -20,7 +20,7 @@ module Cucumber
         end
       end
 
-      context "With no options" do
+      context 'With no options' do
         before(:each) do
           allow(File).to receive(:directory?) { true }
           @formatter = TestDoubleJunitFormatter.new(actual_runtime.configuration.with_options(out_stream: ''))
@@ -30,7 +30,7 @@ module Cucumber
           $stdout = STDOUT
         end
 
-        describe "is able to strip control chars from cdata" do
+        describe 'is able to strip control chars from cdata' do
           before(:each) do
             run_defined_feature
             @doc = Nokogiri.XML(@formatter.written_files.values.first)
@@ -43,47 +43,45 @@ module Cucumber
             "
           class Junit
             def before_step(step)
-              if step.name.match("a passing ctrl scenario")
-                Interceptor::Pipe.unwrap! :stdout
-                @fake_io = $stdout = StringIO.new
-                $stdout.sync = true
-                @interceptedout = Interceptor::Pipe.wrap(:stdout)
-              end
+              return unless step.name.match('a passing ctrl scenario')
+              Interceptor::Pipe.unwrap! :stdout
+              @fake_io = $stdout = StringIO.new
+              $stdout.sync = true
+              @interceptedout = Interceptor::Pipe.wrap(:stdout)
             end
 
             def after_step(step)
-              if step.name.match("a passing ctrl scenario")
-                @interceptedout.write("boo\b\cx\e\a\f boo ")
-                $stdout = STDOUT
-                @fake_io.close
-              end
+              return unless step.name.match('a passing ctrl scenario')
+              @interceptedout.write("boo\b\cx\e\a\f boo ")
+              $stdout = STDOUT
+              @fake_io.close
             end
           end
 
           it { expect(@doc.xpath('//testsuite/testcase/system-out').first.content).to match(/\s+boo boo\s+/) }
         end
 
-        describe "a feature with no name" do
+        describe 'a feature with no name' do
           define_feature <<-FEATURE
             Feature:
               Scenario: Passing
                 Given a passing scenario
           FEATURE
 
-          it "raises an exception" do
+          it 'raises an exception' do
             expect(-> {
               run_defined_feature
             }).to raise_error(Junit::UnNamedFeatureError)
           end
         end
 
-        describe "given a single feature" do
+        describe 'given a single feature' do
           before(:each) do
             run_defined_feature
             @doc = Nokogiri.XML(@formatter.written_files.values.first)
           end
 
-          describe "with a single scenario" do
+          describe 'with a single scenario' do
             define_feature <<-FEATURE
               Feature: One passing scenario, one failing scenario
 
@@ -91,7 +89,7 @@ module Cucumber
                   Given a passing scenario
             FEATURE
 
-            it { expect(@doc.to_s).to match /One passing scenario, one failing scenario/ }
+            it { expect(@doc.to_s).to match(/One passing scenario, one failing scenario/) }
 
             it 'has not a root system-out node' do
               expect(@doc.xpath('//testsuite/system-out').size).to eq 0
@@ -110,7 +108,7 @@ module Cucumber
             end
           end
 
-          describe "with a scenario in a subdirectory" do
+          describe 'with a scenario in a subdirectory' do
             define_feature %{
               Feature: One passing scenario, one failing scenario
 
@@ -123,7 +121,7 @@ module Cucumber
             end
           end
 
-          describe "with a scenario outline table" do
+          describe 'with a scenario outline table' do
             define_steps do
               Given(/.*/) {  }
             end
@@ -146,16 +144,16 @@ module Cucumber
                   | Big Mac  |
             FEATURE
 
-            it { expect(@doc.to_s).to match /Eat things when hungry/ }
-            it { expect(@doc.to_s).to match /Cucumber/ }
-            it { expect(@doc.to_s).to match /Whisky/ }
-            it { expect(@doc.to_s).to match /Big Mac/ }
-            it { expect(@doc.to_s).not_to match /Things/ }
-            it { expect(@doc.to_s).not_to match /Good|Evil/ }
-            it { expect(@doc.to_s).not_to match /type="skipped"/}
+            it { expect(@doc.to_s).to match(/Eat things when hungry/) }
+            it { expect(@doc.to_s).to match(/Cucumber/) }
+            it { expect(@doc.to_s).to match(/Whisky/) }
+            it { expect(@doc.to_s).to match(/Big Mac/) }
+            it { expect(@doc.to_s).not_to match(/Things/) }
+            it { expect(@doc.to_s).not_to match(/Good|Evil/) }
+            it { expect(@doc.to_s).not_to match(/type="skipped"/)}
           end
 
-          describe "scenario with skipped test in junit report" do
+          describe 'scenario with skipped test in junit report' do
             define_feature <<-FEATURE
               Feature: junit report with skipped test
 
@@ -168,10 +166,10 @@ module Cucumber
                   | still undefined  |
             FEATURE
 
-            it { expect(@doc.to_s).to match /skipped="2"/}
+            it { expect(@doc.to_s).to match(/skipped="2"/)}
           end
 
-          describe "with a regular data table scenario" do
+          describe 'with a regular data table scenario' do
             define_steps do
               Given(/the following items on a shortlist/) { |table| }
               When(/I go.*/) {  }
@@ -191,13 +189,13 @@ module Cucumber
 
             FEATURE
             # these type of tables shouldn't crash (or generate test cases)
-            it { expect(@doc.to_s).not_to match /milk/ }
-            it { expect(@doc.to_s).not_to match /cookies/ }
+            it { expect(@doc.to_s).not_to match(/milk/) }
+            it { expect(@doc.to_s).not_to match(/cookies/) }
           end
         end
       end
-      
-      context "In --expand mode" do
+
+      context 'In --expand mode' do
         let(:runtime)   { Runtime.new({:expand => true}) }
         before(:each) do
           allow(File).to receive(:directory?) { true }
@@ -208,13 +206,13 @@ module Cucumber
           $stdout = STDOUT
         end
 
-        describe "given a single feature" do
+        describe 'given a single feature' do
           before(:each) do
             run_defined_feature
             @doc = Nokogiri.XML(@formatter.written_files.values.first)
           end
-          
-          describe "with a scenario outline table" do
+
+          describe 'with a scenario outline table' do
             define_steps do
               Given(/.*/) {  }
             end
@@ -237,16 +235,16 @@ module Cucumber
                   | Big Mac  |
             FEATURE
 
-            it { expect(@doc.to_s).to match /Eat things when hungry/ }
-            it { expect(@doc.to_s).to match /Cucumber/ }
-            it { expect(@doc.to_s).to match /Whisky/ }
-            it { expect(@doc.to_s).to match /Big Mac/ }
-            it { expect(@doc.to_s).not_to match /Things/ }
-            it { expect(@doc.to_s).not_to match /Good|Evil/ }
-            it { expect(@doc.to_s).not_to match /type="skipped"/}
+            it { expect(@doc.to_s).to match(/Eat things when hungry/) }
+            it { expect(@doc.to_s).to match(/Cucumber/) }
+            it { expect(@doc.to_s).to match(/Whisky/) }
+            it { expect(@doc.to_s).to match(/Big Mac/) }
+            it { expect(@doc.to_s).not_to match(/Things/) }
+            it { expect(@doc.to_s).not_to match(/Good|Evil/) }
+            it { expect(@doc.to_s).not_to match(/type="skipped"/)}
           end
         end
-        
+
       end
     end
   end

data/spec/cucumber/formatter/legacy_api/adapter_spec.rb

@@ -59,7 +59,7 @@ module Cucumber
           source_location
         end
 
-        def invoke(pseudo_method, arguments, &block)
+        def invoke(_pseudo_method, _arguments, &_block)
           @proc.call
         end
       end
@@ -106,7 +106,7 @@ module Cucumber
                   step 'passing'
                 end
               end
-            end,
+            end
           ]
           runner = Core::Test::Runner.new(events)
           compile gherkin_docs, runner, default_filters
@@ -147,7 +147,7 @@ module Cucumber
                   :after_steps,
                 :after_feature_element,
               :after_feature,
-            :after_features,
+            :after_features
           ]
         end
 
@@ -170,7 +170,7 @@ module Cucumber
                     :scenario_name,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -207,7 +207,7 @@ module Cucumber
                     :scenario_name,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -238,7 +238,7 @@ module Cucumber
                     :after_steps,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -276,7 +276,7 @@ module Cucumber
               :after_steps,
               :after_feature_element,
               :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -322,7 +322,7 @@ module Cucumber
                     :after_steps,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -357,7 +357,7 @@ module Cucumber
                   :scenario_name,
                 :after_feature_element,
               :after_feature,
-            :after_features,
+            :after_features
           ]
         end
 
@@ -416,7 +416,7 @@ module Cucumber
                     :after_steps,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -498,7 +498,7 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -580,7 +580,7 @@ module Cucumber
                     :after_steps,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -685,7 +685,7 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -758,7 +758,7 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -846,7 +846,7 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -896,7 +896,7 @@ module Cucumber
                     :after_steps,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -940,7 +940,7 @@ module Cucumber
               :after_steps,
               :after_feature_element,
               :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -994,7 +994,7 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -1063,7 +1063,7 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
           ]
         end
 
@@ -1132,7 +1132,7 @@ module Cucumber
                     :after_steps,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ]
         end
 
@@ -1192,7 +1192,7 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ]
         end
 
@@ -1267,7 +1267,7 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ]
         end
 
@@ -1359,7 +1359,7 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ]
         end
 
@@ -1413,7 +1413,7 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ]
         end
 
@@ -1473,7 +1473,7 @@ module Cucumber
                     :after_steps,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ]
         end
 
@@ -1534,7 +1534,7 @@ module Cucumber
                       :after_examples_array,
                     :after_feature_element,
                   :after_feature,
-                :after_features,
+                :after_features
               ]
           end
         end
@@ -1542,7 +1542,7 @@ module Cucumber
         context 'with exception in after step hook' do
 
           class FailingAfterStepHook
-            def find_after_step_hooks(test_case)
+            def find_after_step_hooks(_test_case)
               failing_hook = HookWrapper.new(proc { raise Failure })
               Runtime::StepHooks.new [failing_hook]
             end
@@ -1581,7 +1581,7 @@ module Cucumber
                       :after_steps,
                     :after_feature_element,
                   :after_feature,
-                :after_features,
+                :after_features
                 ])
           end
         end
@@ -1628,7 +1628,7 @@ module Cucumber
                       :after_steps,
                     :after_feature_element,
                   :after_feature,
-                :after_features,
+                :after_features
                 ])
           end
 
@@ -1679,7 +1679,7 @@ module Cucumber
                       :after_steps,
                     :after_feature_element,
                   :after_feature,
-                :after_features,
+                :after_features
                 ])
           end
 
@@ -1741,7 +1741,7 @@ module Cucumber
                       :after_examples_array,
                     :after_feature_element,
                   :after_feature,
-                :after_features,
+                :after_features
               ])
           end
         end
@@ -1791,7 +1791,7 @@ module Cucumber
                       :after_steps,
                     :after_feature_element,
                   :after_feature,
-                :after_features,
+                :after_features
                 ])
           end
         end
@@ -1839,7 +1839,7 @@ module Cucumber
                     :exception,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ])
           end
 
@@ -1900,7 +1900,7 @@ module Cucumber
                     :after_examples_array,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ])
           end
         end
@@ -1948,7 +1948,7 @@ module Cucumber
                     :exception,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ])
           end
         end
@@ -1980,7 +1980,7 @@ module Cucumber
                     :exception,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ])
           end
         end
@@ -2020,7 +2020,7 @@ module Cucumber
                     :exception,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ])
           end
         end
@@ -2068,7 +2068,7 @@ module Cucumber
                     :after_steps,
                   :after_feature_element,
                 :after_feature,
-              :after_features,
+              :after_features
             ])
           end
         end
@@ -2076,7 +2076,7 @@ module Cucumber
 
       describe 'before_step_result message' do
         context 'when the step matches' do
-          it "sends the step match to the formatter" do
+          it 'sends the step match to the formatter' do
             expect(formatter).to receive(:before_step_result) do |_, step_match, *|
               expect(step_match).to be_a SimpleStepMatch
             end
@@ -2091,7 +2091,7 @@ module Cucumber
         end
 
         context "when the step doesn't match" do
-          it "sends a null object to the formatter" do
+          it 'sends a null object to the formatter' do
           end
         end
       end
@@ -2109,7 +2109,7 @@ module Cucumber
         end
       end
 
-      context "after_feature_element callback" do
+      context 'after_feature_element callback' do
         it 'passes an object reflecting the status of the scenario' do
           expect( formatter ).to receive(:after_feature_element).once do |scenario|
             expect( scenario ).to be_failed
@@ -2159,11 +2159,11 @@ module Cucumber
           ]
         end
 
-        def method_missing(message, *args)
+        def method_missing(message, *_args)
           @messages << message
         end
 
-        def respond_to_missing?(name, include_private = false)
+        def respond_to_missing?(_name, _include_private = false)
           true
         end
       end