cucumber 2.3.2 → 2.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3ea4c325d27aa0512732b572a494fccee6e4dff0
-  data.tar.gz: 1defb0bb6842a9995ec302dcc7b2864d9a0e4498
+  metadata.gz: c53e4902ca73f5999ff60be26b1817622c631974
+  data.tar.gz: b4f35193ddd03bacefefd3483184fb9f88c1f624
 SHA512:
-  metadata.gz: 8bc0298eda9a2055a26b030a32149a16ecf96d05ee5623538f0055c3c7515439298aff445cc8fb2341550ddb2f036618e29a742900f5cd056775e1838abf6299
-  data.tar.gz: 47b7a3f1f9cb191af39730bac8506264231df606fa7a63ac13017a01628ef43b74e11f7b5322ea64ee69e28af7251a78435584ce9d1e5a302db3fadab8a9e8ac
+  metadata.gz: 09376bab164a61f983d2bd94c58f3621b7c773378ccfd5df577dbc76349b1d26c4da2a7d95557b65c8636aee403c08291d611124d81562f9824cd8b61acdd420
+  data.tar.gz: 928438ab720c2b6b18ceeb2f7b13b8df82d733fcf399095a4f5b7c68f4ca1601487a8661bff4d6c36c71074464bd36ba0884c87311023ef703c2d2ab5b9ed34b

data/History.md

@@ -1,6 +1,17 @@
-## [In Git](https://github.com/cucumber/cucumber-ruby/compare/v2.3.1...master)
+## [In Git](https://github.com/cucumber/cucumber-ruby/compare/v2.3.3...master)
 
-... your change here?
+### New Features
+
+### Bugfixes
+
+## [v2.3.3](https://github.com/cucumber/cucumber-ruby/compare/v2.3.2...v2.3.3)
+
+Added a message pointing users to [The Great Cucumber and BDD Census of 2016](https://cucumber.typeform.com/to/kjrSc2?audience=cucumber-ruby) to the installer message. Please take a few moments to help us all learn more about how you're using Cucumber and BDD.
+
+### Bugfixes
+
+* Let the JSON formatter include data tables in the JSON file ([#948](https://github.com/cucumber/cucumber-ruby/issues/948) @brasmusson)
+* Stringifying location in the JSON formatter for more consistent json parsing ([949](https://github.com/cucumber/cucumber-ruby/pull/949), [945](https://github.com/cucumber/cucumber-ruby/issues/945) @larryprice)
 
 ## [v2.3.2](https://github.com/cucumber/cucumber-ruby/compare/v2.3.1...v2.3.2)
 

data/cucumber.gemspec

@@ -10,6 +10,16 @@ Gem::Specification.new do |s|
   s.homepage    = "http://cukes.info"
   s.platform    = Gem::Platform::RUBY
   s.required_ruby_version = ">= 1.9.3"
+  s.post_install_message = %{We need your help.
+    
+Please take a few minutes to fill out our survey and help us understand how BDD and Cucumber are used in the wild.
+  
+  http://tinyurl.com/zk9jyrf
+
+Thanks!
+
+♡ The Cucumber Team ♡
+}
 
   s.add_dependency 'cucumber-core', '~> 1.4.0'
   s.add_dependency 'builder', '>= 2.1.2'

data/features/docs/cli/randomize.feature

@@ -5,7 +5,7 @@ Feature: Randomize
   This is especially helpful for detecting situations where you have state
   leaking between scenarios, which can cause flickering or fragile tests.
 
-  If you do find a randmon run that exposes dependencies between your tests,
+  If you do find a random run that exposes dependencies between your tests,
   you can reproduce that run by using the seed that's printed at the end of
   the test run.
 
@@ -37,10 +37,28 @@ Feature: Randomize
 
   @spawn
   Scenario: Run scenarios randomized
-    When I run `cucumber --order random:41515`
+    When I run `cucumber --order random:41515 -q`
     Then it should fail
-    And the stdout should contain:
+    And the stdout should contain exactly:
       """
+      Feature: Bad practice
+      
+        Scenario: Depend on state
+          When I depend on the state
+            I expect the state to be set! (RuntimeError)
+            ./features/step_definitions/steps.rb:6:in `/^I depend on the state$/'
+            features/bad_practice.feature:7:in `When I depend on the state'
+
+        Scenario: Set state
+          Given I set some state
+      
+      Failing Scenarios:
+      cucumber features/bad_practice.feature:6
+    
+      2 scenarios (1 failed, 1 passed)
+      2 steps (1 failed, 1 passed)
+      
       Randomized with seed 41515
+      
       """
 

data/lib/cucumber/formatter/json.rb

@@ -153,6 +153,7 @@ module Cucumber
         }
         step_hash[:comments] = Formatter.create_comments_array(step_source.comments) unless step_source.comments.empty?
         step_hash[:doc_string] = create_doc_string_hash(step_source.multiline_arg) if step_source.multiline_arg.doc_string?
+        step_hash[:rows] = create_data_table_value(step_source.multiline_arg) if step_source.multiline_arg.data_table?
         step_hash
       end
 
@@ -165,6 +166,12 @@ module Cucumber
         }
       end
 
+      def create_data_table_value(data_table)
+        data_table.raw.map do |row|
+          { cells: row }
+        end
+      end
+
       def add_match_and_result(test_step, result)
         @step_or_hook_hash[:match] = create_match_hash(test_step, result)
         @step_or_hook_hash[:result] = create_result_hash(result)
@@ -179,7 +186,7 @@ module Cucumber
       end
 
       def create_match_hash(test_step, result)
-        { location: test_step.action_location }
+        { location: test_step.action_location.to_s }
       end
 
       def create_result_hash(result)

data/lib/cucumber/gherkin/steps_parser.rb

@@ -12,11 +12,9 @@ module Cucumber
       end
       def parse(text)
         ast_builder = ::Gherkin::AstBuilder.new
-        token_matcher = ::Gherkin::TokenMatcher.new
-        token_matcher.send(:change_dialect, @language, nil) unless @language == 'en'
         context = ::Gherkin::ParserContext.new(
           ::Gherkin::TokenScanner.new(text),
-          token_matcher,
+          ::Gherkin::TokenMatcher.new(@language),
           [],
           []
           )

data/lib/cucumber/version

@@ -1 +1 @@
-2.3.2
+2.3.3

data/spec/cucumber/formatter/json_spec.rb

@@ -757,6 +757,48 @@ module Cucumber
                                  "duration": 1}}]}]}]})
           end
         end
+
+        describe "with a scenario with a step with a data table" do
+          define_feature <<-FEATURE
+          Feature: Banana party
+
+            Scenario: Monkey eats bananas
+              Given there are bananas
+                | aa | bb |
+                | cc | dd |
+            FEATURE
+
+          define_steps do
+            Given(/^there are bananas$/) { |s| s }
+          end
+
+          it "includes the doc string in the json data" do
+            expect(load_normalised_json(@out)).to eq MultiJson.load(%{
+              [{"id": "banana-party",
+                "uri": "spec.feature",
+                "keyword": "Feature",
+                "name": "Banana party",
+                "line": 1,
+                "description": "",
+                "elements":
+                 [{"id": "banana-party;monkey-eats-bananas",
+                   "keyword": "Scenario",
+                   "name": "Monkey eats bananas",
+                   "line": 3,
+                   "description": "",
+                   "type": "scenario",
+                   "steps":
+                     [{"keyword": "Given ",
+                       "name": "there are bananas",
+                       "line": 4,
+                       "rows": 
+                         [{"cells": ["aa", "bb"]}, 
+                          {"cells": ["cc", "dd"]}],
+                       "match": {"location": "spec/cucumber/formatter/json_spec.rb:772"},
+                       "result": {"status": "passed",
+                                  "duration": 1}}]}]}]})
+          end
+        end
       end
 
       def load_normalised_json(out)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cucumber
 version: !ruby/object:Gem::Version
-  version: 2.3.2
+  version: 2.3.3
 platform: ruby
 authors:
 - Aslak Hellesøy
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-22 00:00:00.000000000 Z
+date: 2016-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -832,7 +832,9 @@ homepage: http://cukes.info
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message: "We need your help.\n    \nPlease take a few minutes to fill
+  out our survey and help us understand how BDD and Cucumber are used in the wild.\n
+  \ \n  http://tinyurl.com/zk9jyrf\n\nThanks!\n\n♡ The Cucumber Team ♡\n"
 rdoc_options:
 - "--charset=UTF-8"
 require_paths:
@@ -852,7 +854,7 @@ rubyforge_project:
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: cucumber-2.3.2
+summary: cucumber-2.3.3
 test_files:
 - features/docs/api/list_step_defs_as_json.feature
 - features/docs/api/listen_for_events.feature