cucumber 2.0.2 → 2.1.0

data/spec/cucumber/formatter/event_bus_report_spec.rb

@@ -0,0 +1,79 @@
+require 'cucumber/configuration'
+require 'cucumber/runtime'
+require 'cucumber/formatter/spec_helper'
+require 'cucumber/formatter/event_bus_report'
+
+module Cucumber
+  module Formatter
+    describe EventBusReport do
+      extend SpecHelperDsl
+      include SpecHelper
+
+      context "With no options" do
+        let(:config) { Cucumber::Configuration.new }
+
+        before(:each) do
+          @formatter = EventBusReport.new(config)
+        end
+
+        describe "given a single feature" do
+
+          describe "a scenario with a single passing step" do
+            define_feature <<-FEATURE
+          Feature:
+            Scenario: Test Scenario
+              Given passing
+            FEATURE
+
+            define_steps do
+              Given(/pass/) {}
+            end
+
+            it "emits a BeforeTestCase event" do
+              received_event = nil
+              config.on_event Cucumber::Events::BeforeTestCase do |event|
+                received_event = event
+              end
+              run_defined_feature
+              expect(received_event.test_case.name).to eq "Test Scenario"
+            end
+
+            it "emits a BeforeTestStep event" do
+              received_event = nil
+              config.on_event Cucumber::Events::BeforeTestStep do |event|
+                received_event = event
+              end
+              run_defined_feature
+              expect(received_event.test_case.name).to eq "Test Scenario"
+              expect(received_event.test_step.name).to eq "passing"
+            end
+
+            it "emits an AfterTestStep event with a passed result" do
+              received_event = nil
+              config.on_event Cucumber::Events::AfterTestStep do |event|
+                received_event = event
+              end
+              run_defined_feature
+              expect(received_event.test_case.name).to eq "Test Scenario"
+              expect(received_event.test_step.name).to eq "passing"
+              expect(received_event.result).to be_passed
+            end
+
+            it "emits an AfterTestCase event with a passed result" do
+              received_event = nil
+              config.on_event Cucumber::Events::AfterTestCase do |event|
+                received_event = event
+              end
+              run_defined_feature
+              expect(received_event.test_case.name).to eq "Test Scenario"
+              expect(received_event.result).to be_passed
+            end
+          end
+        end
+      end
+    end
+  end
+end
+
+
+

data/spec/cucumber/formatter/fail_fast_spec.rb

@@ -0,0 +1,88 @@
+require 'cucumber/formatter/fail_fast'
+require 'cucumber/core'
+require 'cucumber/core/gherkin/writer'
+require 'cucumber/core/test/result'
+require 'cucumber/core/filter'
+require 'cucumber/core/ast'
+require 'cucumber'
+require 'support/standard_step_actions'
+
+module Cucumber::Formatter
+  describe FailFast do 
+    include Cucumber::Core
+    include Cucumber::Core::Gherkin::Writer
+
+    let(:configuration) { Cucumber::Configuration.new }
+    before { FailFast.new(configuration) }
+    let(:report) { EventBusReport.new(configuration) }
+
+    context 'failing scenario' do 
+      before(:each) do 
+        @gherkin = gherkin('foo.feature') do 
+          feature do 
+            scenario do 
+              step 'failing'
+            end
+
+            scenario do 
+              step 'failing'
+            end
+          end
+        end
+      end
+
+      after(:each) do 
+        Cucumber.wants_to_quit = false
+      end
+
+      it 'sets Cucumber.wants_to_quit' do 
+        execute([@gherkin], report, [StandardStepActions.new])
+        expect(Cucumber.wants_to_quit).to be true
+      end
+    end
+
+    context 'passing scenario' do 
+      before(:each) do 
+        @gherkin = gherkin('foo.feature') do 
+          feature do 
+            scenario do 
+              step 'passing'
+            end
+          end
+        end
+      end
+
+      it 'doesn\'t set Cucumber.wants_to_quit' do 
+        execute([@gherkin], report, [StandardStepActions.new])
+        expect(Cucumber.wants_to_quit).to be_falsey
+      end
+    end
+
+    context 'undefined scenario' do
+      before(:each) do 
+        @gherkin = gherkin('foo.feature') do 
+          feature do 
+            scenario do 
+              step 'undefined'
+            end
+          end
+        end
+      end
+
+      it 'doesn\'t set Cucumber.wants_to_quit' do 
+        execute([@gherkin], report, [StandardStepActions.new])
+        expect(Cucumber.wants_to_quit).to be_falsey
+      end
+
+      context 'in strict mode' do
+        let(:configuration) { Cucumber::Configuration.new strict: true }
+
+        it 'sets Cucumber.wants_to_quit' do 
+          execute([@gherkin], report, [StandardStepActions.new])
+          expect(Cucumber.wants_to_quit).to be_truthy
+        end
+      end
+    end
+
+  end
+end

data/spec/cucumber/formatter/json_spec.rb

@@ -715,6 +715,48 @@ module Cucumber
           end
         end
 
+        describe "with a scenario when only an around hook is failing" do
+          define_feature <<-FEATURE
+          Feature: Banana party
+
+            Scenario: Monkey eats bananas
+              Given there are bananas
+            FEATURE
+
+          define_steps do
+            Around() { |scenario, block| block.call; raise RuntimeError, "error" }
+            Given(/^there are bananas$/) {}
+          end
+
+          it "includes the around hook result in the json data" do
+            expect(load_normalised_json(@out)).to eq MultiJson.load(%{
+              [{"id": "banana-party",
+                "uri": "spec.feature",
+                "keyword": "Feature",
+                "name": "Banana party",
+                "line": 1,
+                "description": "",
+                "elements":
+                 [{"id": "banana-party;monkey-eats-bananas",
+                   "keyword": "Scenario",
+                   "name": "Monkey eats bananas",
+                   "line": 3,
+                   "description": "",
+                   "type": "scenario",
+                   "steps":
+                    [{"keyword": "Given ",
+                      "name": "there are bananas",
+                      "line": 4,
+                      "match": {"location": "spec/cucumber/formatter/json_spec.rb:728"},
+                      "result": {"status": "passed",
+                                 "duration": 1}}],
+                   "around":
+                    [{"match": {"location": "unknown_hook_location:1"},
+                      "result": {"status": "failed",
+                                 "error_message": "error (RuntimeError)\\n./spec/cucumber/formatter/json_spec.rb:727:in `Around'",
+                                 "duration": 1}}]}]}]})
+          end
+        end
       end
 
       def load_normalised_json(out)
@@ -727,7 +769,7 @@ module Cucumber
         json.each do |feature|
           elements = feature.fetch('elements') { [] }
           elements.each do |scenario|
-            ['steps', 'before', 'after'].each do |type|
+            ['steps', 'before', 'after', 'around'].each do |type|
               if scenario[type]
                 scenario[type].each do |step_or_hook|
                   normalise_json_step_or_hook(step_or_hook)

data/spec/cucumber/formatter/rerun_spec.rb

@@ -2,6 +2,7 @@ require 'cucumber/formatter/rerun'
 require 'cucumber/core'
 require 'cucumber/core/gherkin/writer'
 require 'cucumber/core/filter'
+require 'support/standard_step_actions'
 
 module Cucumber::Formatter
   describe Rerun do
@@ -10,23 +11,6 @@ module Cucumber::Formatter
 
     # after_test_case
     context 'when 2 scenarios fail in the same file' do
-      class WithSteps < Cucumber::Core::Filter.new
-        def test_case(test_case)
-          test_steps = test_case.test_steps.map do |step|
-            case step.name
-            when /fail/
-              step.with_action { raise Failure }
-            when /pass/
-              step.with_action {}
-            else
-              step
-            end
-          end
-
-          test_case.with_steps(test_steps).describe_to(receiver)
-        end
-      end
-
       it 'Prints the locations of the failed scenarios' do
         gherkin = gherkin('foo.feature') do
           feature do
@@ -46,7 +30,7 @@ module Cucumber::Formatter
         io = StringIO.new
         report = Rerun.new(double, io, {})
 
-        execute [gherkin], report, [WithSteps.new]
+        execute [gherkin], report, [StandardStepActions.new]
 
         expect( io.string ).to eq 'foo.feature:3:6'
       end
@@ -81,7 +65,7 @@ module Cucumber::Formatter
         io = StringIO.new
         report = Rerun.new(double, io, {})
 
-        execute [foo, bar], report, [WithSteps.new]
+        execute [foo, bar], report, [StandardStepActions.new]
 
         expect(io.string).to eq 'foo.feature:3:6 bar.feature:3'
       end
@@ -100,7 +84,7 @@ module Cucumber::Formatter
         io = StringIO.new
         report = Rerun.new(double, io, {})
 
-        execute [gherkin], report, [WithSteps.new]
+        execute [gherkin], report, [StandardStepActions.new]
       end
     end
   end

data/spec/cucumber/rb_support/rb_step_definition_spec.rb

@@ -114,6 +114,35 @@ module Cucumber
         }).to raise_error(Cucumber::UndefinedDynamicStep)
       end
 
+      it "raises UndefinedDynamicStep when an undefined step with doc string is parsed dynamically" do
+        dsl.Given(/Outside/) do
+          steps %{
+            Given Inside
+            """
+            abc
+            """
+          }
+        end
+
+        expect(-> {
+          run_step "Outside"
+        }).to raise_error(Cucumber::UndefinedDynamicStep)
+      end
+
+      it "raises UndefinedDynamicStep when an undefined step with data table is parsed dynamically" do
+        dsl.Given(/Outside/) do
+          steps %{
+            Given Inside
+             | a |
+             | 1 |
+          }
+        end
+
+        expect(-> {
+          run_step "Outside"
+        }).to raise_error(Cucumber::UndefinedDynamicStep)
+      end
+
       it "allows forced pending" do
         dsl.Given(/Outside/) do
           pending("Do me!")

data/spec/cucumber/runtime_spec.rb

@@ -13,34 +13,8 @@ module Cucumber
       end
     end
 
-    describe "#configure" do
-      let(:support_code)      { double(Runtime::SupportCode).as_null_object }
-      let(:new_configuration) { double('New configuration')}
-
-      before(:each) do
-        allow(Runtime::SupportCode).to receive(:new) { support_code }
-      end
-
-      it "tells the support_code about the new configuration" do
-        expect(support_code).to receive(:configure).with(new_configuration)
-        subject.configure(new_configuration)
-      end
-
-      it "replaces the existing configuration" do
-        # not really sure how to test this. Maybe we should just expose
-        # Runtime#configuration with an attr_reader?
-        some_new_paths = ['foo/bar', 'baz']
-
-        allow(new_configuration).to receive(:paths) { some_new_paths }
-
-        subject.configure(new_configuration)
-
-        expect(subject.features_paths).to eq some_new_paths
-      end
-
-      it '#doc_string' do
-        expect(subject.doc_string('Text')).to eq 'Text'
-      end
+    it '#doc_string' do
+      expect(subject.doc_string('Text')).to eq 'Text'
     end
   end
 end

data/spec/spec_helper.rb

@@ -4,7 +4,7 @@ $:.unshift(File.dirname(__FILE__))
 # For Travis....
 require 'cucumber/encoding'
 
-load File.expand_path(File.dirname(__FILE__) + '/../spec/simplecov_setup.rb')
+require 'simplecov_setup'
 
 require 'pry'
 

data/spec/support/standard_step_actions.rb

@@ -0,0 +1,18 @@
+# Filter that activates steps with obvious pass / fail behaviour
+class StandardStepActions < Cucumber::Core::Filter.new
+  def test_case(test_case)
+    test_steps = test_case.test_steps.map do |step|
+      case step.name
+      when /fail/
+        step.with_action { raise Failure }
+      when /pass/
+        step.with_action {}
+      else
+        step
+      end
+    end
+
+    test_case.with_steps(test_steps).describe_to(receiver)
+  end
+end
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cucumber
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.1.0
 platform: ruby
 authors:
 - Aslak Hellesøy
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-15 00:00:00.000000000 Z
+date: 2015-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -18,14 +18,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: 1.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: 1.3.0
 - !ruby/object:Gem::Dependency
   name: builder
   requirement: !ruby/object:Gem::Requirement
@@ -55,19 +55,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 1.1.3
 - !ruby/object:Gem::Dependency
-  name: gherkin
+  name: gherkin3
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.12'
+        version: 3.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.12'
+        version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
@@ -562,11 +562,13 @@ files:
 - examples/watir/features/support/env.rb
 - examples/watir/features/support/screenshots.rb
 - features/docs/api/list_step_defs_as_json.feature
+- features/docs/api/listen_for_events.feature
 - features/docs/api/run_cli_main_with_existing_runtime.feature
 - features/docs/cli/backtraces.feature
 - features/docs/cli/dry_run.feature
 - features/docs/cli/exclude_files.feature
 - features/docs/cli/execute_with_tag_filter.feature
+- features/docs/cli/fail_fast.feature
 - features/docs/cli/finding_steps.feature
 - features/docs/cli/randomize.feature
 - features/docs/cli/require.feature
@@ -674,10 +676,16 @@ files:
 - lib/cucumber/configuration.rb
 - lib/cucumber/constantize.rb
 - lib/cucumber/core_ext/instance_exec.rb
-- lib/cucumber/core_ext/proc.rb
 - lib/cucumber/core_ext/string.rb
 - lib/cucumber/encoding.rb
 - lib/cucumber/errors.rb
+- lib/cucumber/events.rb
+- lib/cucumber/events/after_test_case.rb
+- lib/cucumber/events/after_test_step.rb
+- lib/cucumber/events/before_test_case.rb
+- lib/cucumber/events/before_test_step.rb
+- lib/cucumber/events/bus.rb
+- lib/cucumber/events/step_match.rb
 - lib/cucumber/file_specs.rb
 - lib/cucumber/filters.rb
 - lib/cucumber/filters/activate_steps.rb
@@ -700,6 +708,8 @@ files:
 - lib/cucumber/formatter/debug.rb
 - lib/cucumber/formatter/duration.rb
 - lib/cucumber/formatter/duration_extractor.rb
+- lib/cucumber/formatter/event_bus_report.rb
+- lib/cucumber/formatter/fail_fast.rb
 - lib/cucumber/formatter/fanout.rb
 - lib/cucumber/formatter/hook_query_visitor.rb
 - lib/cucumber/formatter/html.rb
@@ -722,6 +732,13 @@ files:
 - lib/cucumber/formatter/summary.rb
 - lib/cucumber/formatter/unicode.rb
 - lib/cucumber/formatter/usage.rb
+- lib/cucumber/gherkin/data_table_parser.rb
+- lib/cucumber/gherkin/formatter/ansi_escapes.rb
+- lib/cucumber/gherkin/formatter/argument.rb
+- lib/cucumber/gherkin/formatter/escaping.rb
+- lib/cucumber/gherkin/formatter/hashable.rb
+- lib/cucumber/gherkin/i18n.rb
+- lib/cucumber/gherkin/steps_parser.rb
 - lib/cucumber/hooks.rb
 - lib/cucumber/language_support.rb
 - lib/cucumber/language_support/language_methods.rb
@@ -764,6 +781,7 @@ files:
 - lib/cucumber/wire_support/wire_protocol.rb
 - lib/cucumber/wire_support/wire_protocol/requests.rb
 - lib/cucumber/wire_support/wire_step_definition.rb
+- lib/simplecov_setup.rb
 - spec/cucumber/cli/configuration_spec.rb
 - spec/cucumber/cli/main_spec.rb
 - spec/cucumber/cli/options_spec.rb
@@ -772,7 +790,7 @@ files:
 - spec/cucumber/configuration_spec.rb
 - spec/cucumber/constantize_spec.rb
 - spec/cucumber/core_ext/instance_exec_spec.rb
-- spec/cucumber/core_ext/proc_spec.rb
+- spec/cucumber/events/bus_spec.rb
 - spec/cucumber/file_specs_spec.rb
 - spec/cucumber/filters/activate_steps_spec.rb
 - spec/cucumber/filters/gated_receiver_spec.rb
@@ -782,6 +800,8 @@ files:
 - spec/cucumber/formatter/ansicolor_spec.rb
 - spec/cucumber/formatter/debug_spec.rb
 - spec/cucumber/formatter/duration_spec.rb
+- spec/cucumber/formatter/event_bus_report_spec.rb
+- spec/cucumber/formatter/fail_fast_spec.rb
 - spec/cucumber/formatter/html_spec.rb
 - spec/cucumber/formatter/interceptor_spec.rb
 - spec/cucumber/formatter/json_spec.rb
@@ -812,8 +832,8 @@ files:
 - spec/cucumber/wire_support/wire_language_spec.rb
 - spec/cucumber/wire_support/wire_packet_spec.rb
 - spec/cucumber/world/pending_spec.rb
-- spec/simplecov_setup.rb
 - spec/spec_helper.rb
+- spec/support/standard_step_actions.rb
 homepage: http://cukes.info
 licenses:
 - MIT
@@ -838,14 +858,16 @@ rubyforge_project:
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: cucumber-2.0.2
+summary: cucumber-2.1.0
 test_files:
 - features/docs/api/list_step_defs_as_json.feature
+- features/docs/api/listen_for_events.feature
 - features/docs/api/run_cli_main_with_existing_runtime.feature
 - features/docs/cli/backtraces.feature
 - features/docs/cli/dry_run.feature
 - features/docs/cli/exclude_files.feature
 - features/docs/cli/execute_with_tag_filter.feature
+- features/docs/cli/fail_fast.feature
 - features/docs/cli/finding_steps.feature
 - features/docs/cli/randomize.feature
 - features/docs/cli/require.feature
@@ -931,7 +953,7 @@ test_files:
 - spec/cucumber/configuration_spec.rb
 - spec/cucumber/constantize_spec.rb
 - spec/cucumber/core_ext/instance_exec_spec.rb
-- spec/cucumber/core_ext/proc_spec.rb
+- spec/cucumber/events/bus_spec.rb
 - spec/cucumber/file_specs_spec.rb
 - spec/cucumber/filters/activate_steps_spec.rb
 - spec/cucumber/filters/gated_receiver_spec.rb
@@ -941,6 +963,8 @@ test_files:
 - spec/cucumber/formatter/ansicolor_spec.rb
 - spec/cucumber/formatter/debug_spec.rb
 - spec/cucumber/formatter/duration_spec.rb
+- spec/cucumber/formatter/event_bus_report_spec.rb
+- spec/cucumber/formatter/fail_fast_spec.rb
 - spec/cucumber/formatter/html_spec.rb
 - spec/cucumber/formatter/interceptor_spec.rb
 - spec/cucumber/formatter/json_spec.rb
@@ -971,6 +995,6 @@ test_files:
 - spec/cucumber/wire_support/wire_language_spec.rb
 - spec/cucumber/wire_support/wire_packet_spec.rb
 - spec/cucumber/world/pending_spec.rb
-- spec/simplecov_setup.rb
 - spec/spec_helper.rb
+- spec/support/standard_step_actions.rb
 has_rdoc: