cucumber 2.0.0.rc.4 → 2.0.0.rc.5

data/spec/cucumber/formatter/legacy_api/adapter_spec.rb

@@ -1884,7 +1884,7 @@ module Cucumber
         end
 
         context 'with an exception in an after hook but no steps' do
-          it 'prints the exception after the steps' do
+          it 'prints the exception after the scenario name' do
             filters = [
               Filters::ActivateSteps.new(SimpleStepDefinitions.new),
               Filters::ApplyAfterHooks.new(FailingAfterHook.new),
@@ -1914,6 +1914,94 @@ module Cucumber
             ])
           end
         end
+
+        context 'with an exception in an around hook before the test case is run' do
+          class FailingAroundHookBeforeRunningTestCase
+            def find_around_hooks(test_case)
+              [
+                Hooks.around_hook(test_case.source) { raise Failure }
+              ]
+            end
+          end
+
+          it 'prints the exception after the scenario name' do
+            filters = [
+              Filters::ActivateSteps.new(SimpleStepDefinitions.new),
+              Filters::ApplyAroundHooks.new(FailingAroundHookBeforeRunningTestCase.new),
+              AddBeforeAndAfterHooks.new
+            ]
+            execute_gherkin(filters) do
+              feature do
+                scenario do
+                end
+              end
+            end
+
+            expect( formatter.legacy_messages ).to eq([
+              :before_features,
+                :before_feature,
+                  :before_tags,
+                  :after_tags,
+                  :feature_name,
+                  :before_feature_element,
+                    :before_tags,
+                    :after_tags,
+                    :scenario_name,
+                    :exception,
+                  :after_feature_element,
+                :after_feature,
+              :after_features,
+            ])
+          end
+        end
+
+        context 'with an exception in an around hook after the test case is run' do
+          class FailingAroundHookAfterRunningTestCase
+            def find_around_hooks(test_case)
+              [
+                Hooks.around_hook(test_case.source) { |run_test_case| run_test_case.call; raise Failure }
+              ]
+            end
+          end
+
+          it 'prints the exception after the scenario name' do
+            filters = [
+              Filters::ActivateSteps.new(SimpleStepDefinitions.new),
+              Filters::ApplyAroundHooks.new(FailingAroundHookAfterRunningTestCase.new),
+              AddBeforeAndAfterHooks.new
+            ]
+            execute_gherkin(filters) do
+              feature do
+                scenario do
+                  step
+                end
+              end
+            end
+
+            expect( formatter.legacy_messages ).to eq([
+              :before_features,
+                :before_feature,
+                  :before_tags,
+                  :after_tags,
+                  :feature_name,
+                  :before_feature_element,
+                    :before_tags,
+                    :after_tags,
+                    :scenario_name,
+                    :before_steps,
+                    :before_step,
+                    :before_step_result,
+                    :step_name,
+                    :after_step_result,
+                    :after_step,
+                    :exception,
+                    :after_steps,
+                  :after_feature_element,
+                :after_feature,
+              :after_features,
+            ])
+          end
+        end
       end
 
       it 'passes nil as the multiline arg when there is none' do

data/spec/cucumber/formatter/pretty_spec.rb

@@ -21,6 +21,19 @@ module Cucumber
             run_defined_feature
           end
 
+          describe "with a scenario with no steps" do
+            define_feature <<-FEATURE
+          Feature: Banana party
+
+            Scenario: Monkey eats banana
+            FEATURE
+
+            it "outputs the scenario name" do
+              expect(@out.string).to include "Scenario: Monkey eats banana"
+            end
+          end
+
+
           describe "with a scenario" do
             define_feature <<-FEATURE
           Feature: Banana party

data/spec/cucumber/project_initializer_spec.rb

@@ -0,0 +1,87 @@
+require 'spec_helper'
+require 'tmpdir'
+
+module Cucumber
+  describe ProjectInitializer, :isolated_home => true do
+    let(:command_line_config) { ProjectInitializer.new }
+
+    before do
+      allow(command_line_config).to receive(:puts)
+    end
+
+    context "no files created" do
+      around(:example) do |example|
+
+        dir = Dir.mktmpdir
+        original_dir = Dir.pwd
+        begin
+          FileUtils.cd dir
+          example.call
+        ensure
+          FileUtils.cd original_dir
+          FileUtils.rm_rf dir
+        end
+      end
+
+      it "should create features directory" do
+        expect(command_line_config).to receive(:puts).with %r(^\s+create\s+features$)
+        command_line_config.run
+      end
+
+      it "should create step_definitions directory" do
+        expect(command_line_config).to receive(:puts).with %r(^\s+create\s+features/step_definitions$)
+        command_line_config.run
+      end
+
+      it "should create support directory" do
+        expect(command_line_config).to receive(:puts).with %r(^\s+create\s+features/support$)
+        command_line_config.run
+      end
+
+      it "should create env.rb directory" do
+        expect(command_line_config).to receive(:puts).with %r(^\s+create\s+features/support/env.rb$)
+        command_line_config.run
+      end
+
+    end
+
+    context "files created" do
+      around(:example) do |example|
+        dir = Dir.mktmpdir
+        FileUtils.mkdir_p "#{dir}/features"
+        FileUtils.mkdir_p "#{dir}/features/step_definitions"
+        FileUtils.mkdir_p "#{dir}/features/support"
+        FileUtils.touch "#{dir}/features/support/env.rb"
+        original_dir = Dir.pwd
+        begin
+          FileUtils.cd dir
+          example.call
+        ensure
+          FileUtils.cd original_dir
+          FileUtils.rm_rf dir
+        end
+      end
+
+      it "should not create features directory" do
+        expect(command_line_config).to receive(:puts).with %r(^\s+exist\s+features$)
+        command_line_config.run
+      end
+
+      it "should not create step_definitions directory" do
+        expect(command_line_config).to receive(:puts).with %r(^\s+exist\s+features/step_definitions$)
+        command_line_config.run
+      end
+
+      it "should not create support directory" do
+        expect(command_line_config).to receive(:puts).with %r(^\s+exist\s+features/support$)
+        command_line_config.run
+      end
+
+      it "should not create env.rb directory" do
+        expect(command_line_config).to receive(:puts).with %r(^\s+exist\s+features/support/env.rb$)
+        command_line_config.run
+      end
+
+    end
+  end
+end

data/spec/cucumber/rb_support/rb_step_definition_spec.rb

@@ -7,13 +7,14 @@ module Cucumber
       let(:user_interface) { double('user interface') }
       let(:support_code)   { Cucumber::Runtime::SupportCode.new(user_interface) }
       let(:rb)             { support_code.load_programming_language('rb') }
+      let(:scenario)       { double('scenario', iso_code: 'en').as_null_object }
       let(:dsl) do
         rb
         Object.new.extend(Cucumber::RbSupport::RbDsl)
       end
 
       before do
-        rb.begin_scenario(double('scenario').as_null_object)
+        rb.begin_scenario(scenario)
         $inside = nil
       end
 
@@ -84,16 +85,33 @@ module Cucumber
 
           run_step "With symbol on symbol"
         end
+
+        it "has the correct location" do
+          dsl.Given /With symbol/, :with_symbol
+          expect(step_match("With symbol").file_colon_line).to eq "spec/cucumber/rb_support/rb_step_definition_spec.rb:#{__LINE__-1}"
+        end
       end
 
-      it "raises Undefined when inside step is not defined" do
+      it "raises UndefinedDynamicStep when inside step is not defined" do
         dsl.Given(/Outside/) do
           step 'Inside'
         end
 
         expect(-> {
           run_step "Outside"
-        }).to raise_error(Cucumber::Undefined)
+        }).to raise_error(Cucumber::UndefinedDynamicStep)
+      end
+
+      it "raises UndefinedDynamicStep when an undefined step is parsed dynamically" do
+        dsl.Given(/Outside/) do
+          steps %{
+            Given Inside
+          }
+        end
+
+        expect(-> {
+          run_step "Outside"
+        }).to raise_error(Cucumber::UndefinedDynamicStep)
       end
 
       it "allows forced pending" do

data/spec/cucumber/rb_support/snippet_spec.rb

@@ -27,7 +27,7 @@ module Cucumber
           @pattern = 'A "string" with 4 spaces'
 
           expect(snippet_text).to eq unindented(%{
-          Given(/^A "(.*?)" with (\\d+) spaces$/) do |arg1, arg2|
+          Given(/^A "([^"]*)" with (\\d+) spaces$/) do |arg1, arg2|
             pending # Write code here that turns the phrase above into concrete actions
           end
           })
@@ -48,7 +48,7 @@ module Cucumber
           @multiline_argument = Core::Ast::DataTable.new([[]], Core::Ast::Location.new(''))
 
           expect(snippet_text).to eq unindented(%{
-          Given(/^I have (\\d+) "(.*?)" cukes in (\\d+) "(.*?)"$/) do |arg1, arg2, arg3, arg4, table|
+          Given(/^I have (\\d+) "([^"]*)" cukes in (\\d+) "([^"]*)"$/) do |arg1, arg2, arg3, arg4, table|
             # table is a Cucumber::Core::Ast::DataTable
             pending # Write code here that turns the phrase above into concrete actions
           end
@@ -59,7 +59,7 @@ module Cucumber
           @pattern = 'A "first" arg'
 
           expect(snippet_text).to eq unindented(%{
-          Given(/^A "(.*?)" arg$/) do |arg1|
+          Given(/^A "([^"]*)" arg$/) do |arg1|
             pending # Write code here that turns the phrase above into concrete actions
           end
           })
@@ -69,7 +69,7 @@ module Cucumber
           @pattern = 'A "first" and "second" arg'
 
           expect(snippet_text).to eq unindented(%{
-          Given(/^A "(.*?)" and "(.*?)" arg$/) do |arg1, arg2|
+          Given(/^A "([^"]*)" and "([^"]*)" arg$/) do |arg1, arg2|
             pending # Write code here that turns the phrase above into concrete actions
           end
           })
@@ -90,7 +90,7 @@ module Cucumber
           @multiline_argument = Core::Ast::DataTable.new([[]], Core::Ast::Location.new(""))
 
           expect(snippet_text).to eq unindented(%{
-          Given(/^A "(.*?)" arg$/) do |arg1, table|
+          Given(/^A "([^"]*)" arg$/) do |arg1, table|
             # table is a Cucumber::Core::Ast::DataTable
             pending # Write code here that turns the phrase above into concrete actions
           end
@@ -102,7 +102,7 @@ module Cucumber
           @multiline_argument = MultilineArgument.from("", Core::Ast::Location.new(""))
 
           expect(snippet_text).to eq unindented(%{
-          Given(/^A "(.*?)" arg$/) do |arg1, string|
+          Given(/^A "([^"]*)" arg$/) do |arg1, string|
             pending # Write code here that turns the phrase above into concrete actions
           end
           })

data/spec/cucumber/running_test_case_spec.rb

@@ -0,0 +1,83 @@
+require 'cucumber/running_test_case'
+require 'cucumber/core'
+require 'cucumber/core/gherkin/writer'
+
+module Cucumber
+  describe RunningTestCase do
+    include Core
+    include Core::Gherkin::Writer
+
+    attr_accessor :wrapped_test_case, :core_test_case
+
+    before do
+      receiver = double.as_null_object
+      allow(receiver).to receive(:test_case) { |core_test_case|
+        self.core_test_case = core_test_case
+        self.wrapped_test_case = RunningTestCase.new(core_test_case)
+      }
+      compile [gherkin_doc], receiver
+    end
+
+    context "for a regular scenario" do
+      let(:gherkin_doc) do
+        gherkin do
+          feature "feature name" do
+            scenario "scenario name" do
+              step "passing"
+            end
+          end
+        end
+      end
+
+      it "sets the scenario name correctly" do
+        expect(wrapped_test_case.name).to eq "scenario name"
+      end
+
+      it "sets the feature name correctly" do
+        expect(wrapped_test_case.feature.name).to eq "feature name"
+      end
+
+      it "exposes properties of the test_case" do
+        expect(wrapped_test_case.location).to eq core_test_case.location
+        expect(wrapped_test_case.source).to eq core_test_case.source
+        expect(wrapped_test_case.keyword).to eq core_test_case.keyword
+      end
+    end
+
+    context "for a scenario outline" do
+      let(:gherkin_doc) do
+        gherkin do
+          feature "feature name" do
+            scenario_outline "scenario outline name" do
+              step "passing with <arg1> <arg2>"
+
+              examples "examples name" do
+                row "arg1", "arg2"
+                row "a", "b"
+              end
+            end
+          end
+        end
+      end
+
+      it "sets the test case's name correctly" do
+        expect(wrapped_test_case.name).to eq "scenario outline name, examples name (#1)"
+      end
+
+      it "sets the feature name correctly" do
+        expect(wrapped_test_case.feature.name).to eq "feature name"
+      end
+
+      it "exposes properties of the test_case" do
+        expect(wrapped_test_case.location).to eq core_test_case.location
+        expect(wrapped_test_case.source).to eq core_test_case.source
+        expect(wrapped_test_case.keyword).to eq core_test_case.keyword
+      end
+
+      it "exposes the examples table row cell values" do
+        expect(wrapped_test_case.cell_values).to eq ["a", "b"]
+      end
+
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -2,10 +2,7 @@ ENV['CUCUMBER_COLORS'] = nil
 $:.unshift(File.dirname(__FILE__))
 
 # For Travis....
-if defined? Encoding
-  Encoding.default_external = 'utf-8'
-  Encoding.default_internal = 'utf-8'
-end
+require 'cucumber/encoding'
 
 load File.expand_path(File.dirname(__FILE__) + '/../spec/simplecov_setup.rb')
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cucumber
 version: !ruby/object:Gem::Version
-  version: 2.0.0.rc.4
+  version: 2.0.0.rc.5
 platform: ruby
 authors:
 - Aslak Hellesøy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-13 00:00:00.000000000 Z
+date: 2015-03-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -314,7 +314,6 @@ description: Behaviour Driven Development with elegance and joy
 email: cukes@googlegroups.com
 executables:
 - cucumber
-- cuke
 extensions: []
 extra_rdoc_files: []
 files:
@@ -330,7 +329,6 @@ files:
 - README.md
 - Rakefile
 - bin/cucumber
-- bin/cuke
 - cucumber.gemspec
 - cucumber.yml
 - examples/i18n/README.textile
@@ -416,6 +414,11 @@ files:
 - examples/i18n/hi/features/division.feature
 - examples/i18n/hi/features/step_definitions/calculator_steps.rb
 - examples/i18n/hi/lib/calculator.rb
+- examples/i18n/ht/Rakefile
+- examples/i18n/ht/features/adisyon.feature
+- examples/i18n/ht/features/divizyon.feature
+- examples/i18n/ht/features/step_definitions/kalkilatris_steps.rb
+- examples/i18n/ht/lib/kalkilatris.rb
 - examples/i18n/hu/Rakefile
 - examples/i18n/hu/features/osszeadas.feature
 - examples/i18n/hu/features/osztas.feature
@@ -580,6 +583,7 @@ files:
 - features/docs/defining_steps/transforms.feature
 - features/docs/exception_in_after_hook.feature
 - features/docs/exception_in_after_step_hook.feature
+- features/docs/exception_in_around_hook.feature
 - features/docs/exception_in_before_hook.feature
 - features/docs/extending_cucumber/custom_filter.feature
 - features/docs/extending_cucumber/custom_formatter.feature
@@ -607,12 +611,15 @@ files:
 - features/docs/profiles.feature
 - features/docs/rake_task.feature
 - features/docs/raketask.feature
-- features/docs/report_called_undefined_steps.feature
-- features/docs/wire_protocol.feature
-- features/docs/wire_protocol_erb.feature
-- features/docs/wire_protocol_table_diffing.feature
-- features/docs/wire_protocol_tags.feature
-- features/docs/wire_protocol_timeouts.feature
+- features/docs/wire_protocol/erb_configuration.feature
+- features/docs/wire_protocol/handle_unexpected_response.feature
+- features/docs/wire_protocol/invoke_message.feature
+- features/docs/wire_protocol/readme.md
+- features/docs/wire_protocol/snippets_message.feature
+- features/docs/wire_protocol/step_matches_message.feature
+- features/docs/wire_protocol/table_diffing.feature
+- features/docs/wire_protocol/tags.feature
+- features/docs/wire_protocol/timeouts.feature
 - features/docs/work_in_progress.feature
 - features/docs/writing_support_code/after_hooks.feature
 - features/docs/writing_support_code/around_hooks.feature
@@ -656,7 +663,6 @@ files:
 - lib/autotest/discover.rb
 - lib/cucumber.rb
 - lib/cucumber/ast.rb
-- lib/cucumber/ast/facade.rb
 - lib/cucumber/cli/configuration.rb
 - lib/cucumber/cli/main.rb
 - lib/cucumber/cli/options.rb
@@ -666,6 +672,7 @@ files:
 - lib/cucumber/core_ext/instance_exec.rb
 - lib/cucumber/core_ext/proc.rb
 - lib/cucumber/core_ext/string.rb
+- lib/cucumber/encoding.rb
 - lib/cucumber/errors.rb
 - lib/cucumber/file_specs.rb
 - lib/cucumber/filters.rb
@@ -718,6 +725,7 @@ files:
 - lib/cucumber/multiline_argument/data_table.rb
 - lib/cucumber/multiline_argument/doc_string.rb
 - lib/cucumber/platform.rb
+- lib/cucumber/project_initializer.rb
 - lib/cucumber/rake/task.rb
 - lib/cucumber/rb_support/rb_dsl.rb
 - lib/cucumber/rb_support/rb_hook.rb
@@ -729,6 +737,7 @@ files:
 - lib/cucumber/rb_support/snippet.rb
 - lib/cucumber/rspec/disable_option_parser.rb
 - lib/cucumber/rspec/doubles.rb
+- lib/cucumber/running_test_case.rb
 - lib/cucumber/runtime.rb
 - lib/cucumber/runtime/after_hooks.rb
 - lib/cucumber/runtime/before_hooks.rb
@@ -776,12 +785,14 @@ files:
 - spec/cucumber/formatter/spec_helper.rb
 - spec/cucumber/hooks_spec.rb
 - spec/cucumber/multiline_argument/data_table_spec.rb
+- spec/cucumber/project_initializer_spec.rb
 - spec/cucumber/rake/forked_spec.rb
 - spec/cucumber/rb_support/rb_language_spec.rb
 - spec/cucumber/rb_support/rb_step_definition_spec.rb
 - spec/cucumber/rb_support/rb_transform_spec.rb
 - spec/cucumber/rb_support/regexp_argument_matcher_spec.rb
 - spec/cucumber/rb_support/snippet_spec.rb
+- spec/cucumber/running_test_case_spec.rb
 - spec/cucumber/runtime/for_programming_languages_spec.rb
 - spec/cucumber/runtime/support_code_spec.rb
 - spec/cucumber/runtime_spec.rb
@@ -819,7 +830,7 @@ rubyforge_project:
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: cucumber-2.0.0.rc.4
+summary: cucumber-2.0.0.rc.5
 test_files:
 - features/docs/api/list_step_defs_as_json.feature
 - features/docs/api/run_cli_main_with_existing_runtime.feature
@@ -845,6 +856,7 @@ test_files:
 - features/docs/defining_steps/transforms.feature
 - features/docs/exception_in_after_hook.feature
 - features/docs/exception_in_after_step_hook.feature
+- features/docs/exception_in_around_hook.feature
 - features/docs/exception_in_before_hook.feature
 - features/docs/extending_cucumber/custom_filter.feature
 - features/docs/extending_cucumber/custom_formatter.feature
@@ -872,12 +884,15 @@ test_files:
 - features/docs/profiles.feature
 - features/docs/rake_task.feature
 - features/docs/raketask.feature
-- features/docs/report_called_undefined_steps.feature
-- features/docs/wire_protocol.feature
-- features/docs/wire_protocol_erb.feature
-- features/docs/wire_protocol_table_diffing.feature
-- features/docs/wire_protocol_tags.feature
-- features/docs/wire_protocol_timeouts.feature
+- features/docs/wire_protocol/erb_configuration.feature
+- features/docs/wire_protocol/handle_unexpected_response.feature
+- features/docs/wire_protocol/invoke_message.feature
+- features/docs/wire_protocol/readme.md
+- features/docs/wire_protocol/snippets_message.feature
+- features/docs/wire_protocol/step_matches_message.feature
+- features/docs/wire_protocol/table_diffing.feature
+- features/docs/wire_protocol/tags.feature
+- features/docs/wire_protocol/timeouts.feature
 - features/docs/work_in_progress.feature
 - features/docs/writing_support_code/after_hooks.feature
 - features/docs/writing_support_code/around_hooks.feature
@@ -925,12 +940,14 @@ test_files:
 - spec/cucumber/formatter/spec_helper.rb
 - spec/cucumber/hooks_spec.rb
 - spec/cucumber/multiline_argument/data_table_spec.rb
+- spec/cucumber/project_initializer_spec.rb
 - spec/cucumber/rake/forked_spec.rb
 - spec/cucumber/rb_support/rb_language_spec.rb
 - spec/cucumber/rb_support/rb_step_definition_spec.rb
 - spec/cucumber/rb_support/rb_transform_spec.rb
 - spec/cucumber/rb_support/regexp_argument_matcher_spec.rb
 - spec/cucumber/rb_support/snippet_spec.rb
+- spec/cucumber/running_test_case_spec.rb
 - spec/cucumber/runtime/for_programming_languages_spec.rb
 - spec/cucumber/runtime/support_code_spec.rb
 - spec/cucumber/runtime_spec.rb