cucumber 2.0.0.beta.3 → 2.0.0

data/features/docs/cli/strict_mode.feature

@@ -10,8 +10,14 @@ Feature: Strict mode
       Scenario: Missing
         Given this step passes
     """
+    And a file named "features/pending.feature" with:
+    """
+    Feature: Pending
+      Scenario: Pending
+        Given this step is pending
+    """
 
-  Scenario: Fail with --strict
+  Scenario: Fail with --strict due to undefined step
     When I run `cucumber -q features/missing.feature --strict`
     Then it should fail with:
       """
@@ -26,6 +32,23 @@ Feature: Strict mode
       1 step (1 undefined)
       """
 
+  Scenario: Fail with --strict due to pending step
+    Given the standard step definitions
+    When I run `cucumber -q features/pending.feature --strict`
+    Then it should fail with:
+      """
+      Feature: Pending
+
+        Scenario: Pending
+          Given this step is pending
+            TODO (Cucumber::Pending)
+            ./features/step_definitions/steps.rb:3:in `/^this step is pending$/'
+            features/pending.feature:3:in `Given this step is pending'
+
+      1 scenario (1 pending)
+      1 step (1 pending)
+      """
+
   Scenario: Succeed with --strict
     Given the standard step definitions
     When I run `cucumber -q features/missing.feature --strict`

data/features/docs/defining_steps/nested_steps.feature

@@ -127,3 +127,52 @@ Feature: Nested Steps
       1 scenario (1 failed)
       1 step (1 failed)
       """
+
+  Scenario: Undefined nested step
+    Given a file named "features/call_undefined_step_from_step_def.feature" with:
+      """
+      Feature: Calling undefined step
+
+        Scenario: Call directly
+          Given a step that calls an undefined step
+
+        Scenario: Call via another
+          Given a step that calls a step that calls an undefined step
+      """
+    And a file named "features/step_definitions/steps.rb" with:
+      """
+      Given /^a step that calls an undefined step$/ do
+        step 'this does not exist'
+      end
+
+      Given /^a step that calls a step that calls an undefined step$/ do
+        step 'a step that calls an undefined step'
+      end
+      """
+    When I run `cucumber -q features/call_undefined_step_from_step_def.feature`
+    Then it should fail with exactly:
+      """
+      Feature: Calling undefined step
+
+        Scenario: Call directly
+          Given a step that calls an undefined step
+            Undefined dynamic step: "this does not exist" (Cucumber::UndefinedDynamicStep)
+            ./features/step_definitions/steps.rb:2:in `/^a step that calls an undefined step$/'
+            features/call_undefined_step_from_step_def.feature:4:in `Given a step that calls an undefined step'
+
+        Scenario: Call via another
+          Given a step that calls a step that calls an undefined step
+            Undefined dynamic step: "this does not exist" (Cucumber::UndefinedDynamicStep)
+            ./features/step_definitions/steps.rb:2:in `/^a step that calls an undefined step$/'
+            ./features/step_definitions/steps.rb:6:in `/^a step that calls a step that calls an undefined step$/'
+            features/call_undefined_step_from_step_def.feature:7:in `Given a step that calls a step that calls an undefined step'
+
+      Failing Scenarios:
+      cucumber features/call_undefined_step_from_step_def.feature:3
+      cucumber features/call_undefined_step_from_step_def.feature:6
+
+      2 scenarios (2 failed)
+      2 steps (2 failed)
+      0m0.012s
+
+      """

data/features/docs/defining_steps/skip_scenario.feature

@@ -1,7 +1,6 @@
 Feature: Skip Scenario
-  - 
 
-  Scenario: With a failing step
+  Scenario: With a passing step
     Given a file named "features/test.feature" with:
       """
       Feature: test
@@ -31,3 +30,33 @@ Feature: Skip Scenario
 
       """
 
+  Scenario: Use legacy API from a hook
+    Given a file named "features/test.feature" with:
+      """
+      Feature: test
+        Scenario: test
+          Given this step passes
+          And this step passes
+      """
+    And the standard step definitions
+    And a file named "features/support/hook.rb" with:
+      """
+      Before do |scenario|
+        scenario.skip_invoke!
+      end
+      """
+    When I run `cucumber -q`
+    Then it should pass with:
+      """
+      Feature: test
+
+        Scenario: test
+          Given this step passes
+          And this step passes
+
+      1 scenario (1 skipped)
+      2 steps (2 skipped)
+      0m0.012s
+
+      """
+

data/features/docs/defining_steps/snippets.feature

@@ -13,6 +13,9 @@ Feature: Snippets
         \"\"\"
           example with <html> entities
         \"\"\"
+        When a simple when step
+        And another when step
+        Then a simple then step
       """
     When I run `cucumber features/undefined_steps.feature -s`
     Then the output should contain:
@@ -20,6 +23,18 @@ Feature: Snippets
       Given(/^a pystring$/) do |string|
         pending # Write code here that turns the phrase above into concrete actions
       end
+
+      When(/^a simple when step$/) do
+        pending # Write code here that turns the phrase above into concrete actions
+      end
+
+      When(/^another when step$/) do
+        pending # Write code here that turns the phrase above into concrete actions
+      end
+
+      Then(/^a simple then step$/) do
+        pending # Write code here that turns the phrase above into concrete actions
+      end
       """
 
   Scenario: Snippet for undefined step with a step table

data/features/docs/exception_in_after_step_hook.feature

@@ -94,7 +94,7 @@ Feature: Exception in AfterStep Block
           Given this step passes # features/step_definitions/steps.rb:1
 
       Failing Scenarios:
-      cucumber features/naughty_step_in_scenario_outline.feature:9 # Scenario Outline: Naughty Step, Examples (row 2)
+      cucumber features/naughty_step_in_scenario_outline.feature:9 # Scenario Outline: Naughty Step, Examples (#2)
 
       4 scenarios (1 failed, 3 passed)
       4 steps (4 passed)

data/features/docs/exception_in_around_hook.feature

@@ -0,0 +1,80 @@
+Feature: Exceptions in Around Hooks
+
+  Around hooks are awkward beasts to handle internally.
+
+  Right now, if there's an error in your Around hook before you call `block.call`,
+  we won't even print the steps for the scenario.
+
+  This is because that `block.call` invokes all the logic that would tell Cucumber's
+  UI about the steps in your scenario. If we never reach that code, we'll never be
+  told about them.
+
+  There's another scenario to consider, where the exception occurs after the steps
+  have been run. How would we want to report in that case?
+
+  Scenario: Exception before the test case is run
+    Given the standard step definitions
+    And a file named "features/support/env.rb" with:
+      """
+      Around do |scenario, block|
+        fail "this should be reported"
+        block.call
+      end
+      """
+    And a file named "features/test.feature" with:
+      """
+      Feature:
+        Scenario:
+          Given this step passes
+      """
+    When I run `cucumber -q`
+    Then it should fail with exactly:
+      """
+      Feature: 
+
+        Scenario: 
+        this should be reported (RuntimeError)
+        ./features/support/env.rb:2:in `Around'
+      
+      Failing Scenarios:
+      cucumber features/test.feature:2
+      
+      1 scenario (1 failed)
+      0 steps
+      0m0.012s
+
+      """
+
+  Scenario: Exception after the test case is run
+    Given the standard step definitions
+    And a file named "features/support/env.rb" with:
+      """
+      Around do |scenario, block|
+        block.call
+        fail "this should be reported"
+      end
+      """
+    And a file named "features/test.feature" with:
+      """
+      Feature:
+        Scenario:
+          Given this step passes
+      """
+    When I run `cucumber -q`
+    Then it should fail with exactly:
+      """
+      Feature: 
+
+        Scenario: 
+          Given this step passes
+            this should be reported (RuntimeError)
+            ./features/support/env.rb:3:in `Around'
+      
+      Failing Scenarios:
+      cucumber features/test.feature:2
+      
+      1 scenario (1 failed)
+      1 step (1 passed)
+      0m0.012s
+
+      """

data/features/docs/extending_cucumber/custom_filter.feature

@@ -0,0 +1,29 @@
+Feature: Custom filter
+
+  Scenario: Add a custom filter via AfterConfiguration hook
+    Given a file named "features/test.feature" with:
+      """
+      Feature:
+        Scenario:
+          Given my special step
+      """
+    And a file named "features/support/my_filter.rb" with:
+      """
+      require 'cucumber/core/filter'
+
+      MakeAnythingPass = Cucumber::Core::Filter.new do
+        def test_case(test_case)
+          activated_steps = test_case.test_steps.map do |test_step|
+            test_step.with_action { }
+          end
+          test_case.with_steps(activated_steps).describe_to receiver
+        end
+      end
+
+      AfterConfiguration do |config|
+        config.filters << MakeAnythingPass.new
+      end
+      """
+    When I run `cucumber --strict`
+    Then it should pass
+

data/features/docs/extending_cucumber/custom_formatter.feature

@@ -1,18 +1,45 @@
 Feature: Custom Formatter
 
-  Scenario: my own formatter
+  Background:
     Given a file named "features/f.feature" with:
       """
       Feature: I'll use my own
-        because I'm worth it
-        Scenario: just print me
+        Scenario: Just print me
           Given this step passes
       """
     And the standard step definitions
-    And a file named "features/support/ze/formator.rb" with:
+
+  Scenario: Use the new API
+    Given a file named "features/support/custom_formatter.rb" with:
       """
-      module Ze
-        class Formator
+      module MyCustom
+        class Formatter
+          def initialize(runtime, io, options)
+            @io = io
+          end
+
+          def before_test_case(test_case)
+            feature = test_case.source.first
+            scenario = test_case.source.last
+            @io.puts feature.short_name.upcase
+            @io.puts "  #{scenario.name.upcase}"
+          end
+        end
+      end
+      """
+    When I run `cucumber features/f.feature --format MyCustom::Formatter`
+    Then it should pass with exactly:
+      """
+      I'LL USE MY OWN
+        JUST PRINT ME
+
+      """
+
+  Scenario: Use the legacy API
+    Given a file named "features/support/custom_legacy_formatter.rb" with:
+      """
+      module MyCustom
+        class LegacyFormatter
           def initialize(runtime, io, options)
             @io = io
           end
@@ -27,7 +54,38 @@ Feature: Custom Formatter
         end
       end
       """
-    When I run `cucumber features/f.feature --format Ze::Formator`
+    When I run `cucumber features/f.feature --format MyCustom::LegacyFormatter`
+    Then it should pass with exactly:
+      """
+      I'LL USE MY OWN
+        JUST PRINT ME
+
+      """
+
+  Scenario: Use both
+    You can use a specific shim to opt-in to both APIs at once.
+
+    Given a file named "features/support/custom_mixed_formatter.rb" with:
+      """
+      module MyCustom
+        class MixedFormatter
+
+          def initialize(runtime, io, options)
+            @io = io
+          end
+
+          def before_test_case(test_case)
+            feature = test_case.source.first
+            @io.puts feature.short_name.upcase
+          end
+
+          def scenario_name(keyword, name, file_colon_line, source_indent)
+            @io.puts "  #{name.upcase}"
+          end
+        end
+      end
+      """
+    When I run `cucumber features/f.feature --format MyCustom::MixedFormatter`
     Then it should pass with exactly:
       """
       I'LL USE MY OWN

data/features/docs/formatters/debug_formatter.feature

@@ -18,23 +18,30 @@ Feature: Debug formatter
     Then the stderr should not contain anything
     Then it should pass with:
       """
+      before_test_case
       before_features
-        before_feature
-          before_tags
-          after_tags
-          feature_name
-          before_feature_element
-            before_tags
-            after_tags
-            scenario_name
-            before_steps
-              before_step
-                before_step_result
-                  step_name
-                after_step_result
-              after_step
-            after_steps
-          after_feature_element
-        after_feature
+      before_feature
+      before_tags
+      after_tags
+      feature_name
+      before_test_step
+      after_test_step
+      before_test_step
+      before_feature_element
+      before_tags
+      after_tags
+      scenario_name
+      before_steps
+      before_step
+      before_step_result
+      step_name
+      after_step_result
+      after_step
+      after_test_step
+      after_steps
+      after_feature_element
+      after_test_case
+      after_feature
       after_features
+      done
       """

data/features/docs/formatters/json_formatter.feature

@@ -82,6 +82,14 @@ Feature: JSON output formatter
         Scenario:
           Given I embed data directly
 
+        Scenario Outline:
+          Given I embed data directly
+
+	  Examples:
+	  | dummy |
+	  |  1    |
+	  |  2    |
+
       """
     And a file named "features/out_scenario_out_scenario_outline.feature" with:
       """
@@ -613,7 +621,7 @@ Feature: JSON output formatter
 
   @spawn
   Scenario: embedding data directly
-    When I run `cucumber -b --format json features/embed_data_directly.feature`
+    When I run `cucumber -b --format json -x features/embed_data_directly.feature`
     Then it should pass with JSON:
     """
     [
@@ -652,6 +660,62 @@ Feature: JSON output formatter
                 }
               }
             ]
+          },
+          {
+            "keyword": "Scenario Outline",
+            "name": "",
+            "line": 11,
+            "description": "",
+            "id": "an-embed-data-directly-feature;;;2",
+            "type": "scenario",
+            "steps": [
+              {
+                "keyword": "Given ",
+                "name": "I embed data directly",
+                "line": 11,
+                "embeddings": [
+                  {
+                    "mime_type": "mime-type",
+                    "data": "YWJj"
+                  }
+                ],
+                "match": {
+                  "location": "features/step_definitions/json_steps.rb:10"
+                },
+                "result": {
+                  "status": "passed",
+                  "duration": 1
+                }
+              }
+            ]
+          },
+          {
+            "keyword": "Scenario Outline",
+            "name": "",
+            "line": 12,
+            "description": "",
+            "id": "an-embed-data-directly-feature;;;3",
+            "type": "scenario",
+            "steps": [
+              {
+                "keyword": "Given ",
+                "name": "I embed data directly",
+                "line": 12,
+                "embeddings": [
+                  {
+                    "mime_type": "mime-type",
+                    "data": "YWJj"
+                  }
+                ],
+                "match": {
+                  "location": "features/step_definitions/json_steps.rb:10"
+                },
+                "result": {
+                  "status": "passed",
+                  "duration": 1
+                }
+              }
+            ]
           }
         ]
       }

data/features/docs/formatters/junit_formatter.feature

@@ -274,3 +274,43 @@ You *must* specify --out DIR for the junit formatter
       </testsuite>
 
       """ 
+
+  Scenario: one feature, one scenario outline, two examples: one passing, one failing with --expand option
+    When I run `cucumber --expand --format junit --out tmp/ features/scenario_outline.feature`
+    Then it should fail with exactly:
+      """
+
+      """
+    And the junit output file "tmp/TEST-features-scenario_outline.xml" should contain:
+      """
+      <?xml version="1.0" encoding="UTF-8"?>
+      <testsuite failures="1" errors="0" skipped="0" tests="2" time="0.05" name="Scenario outlines">
+      <testcase classname="Scenario outlines" name="Using scenario outlines (outline example : | passes |)" time="0.05">
+        <system-out/>
+        <system-err/>
+      </testcase>
+      <testcase classname="Scenario outlines" name="Using scenario outlines (outline example : | fails |)" time="0.05">
+        <failure message="failed Using scenario outlines (outline example : | fails |)" type="failed">
+          <![CDATA[Scenario Outline: Using scenario outlines
+      
+      Example row: | fails |
+      
+      Message:
+      ]]>
+          <![CDATA[ (RuntimeError)
+      ./features/step_definitions/steps.rb:4:in `/^this step fails$/'
+      features/scenario_outline.feature:9:in `Given this step fails'
+      features/scenario_outline.feature:4:in `Given this step <type>']]>
+        </failure>
+        <system-out/>
+        <system-err/>
+      </testcase>
+        <system-out>
+          <![CDATA[]]>
+        </system-out>
+        <system-err>
+          <![CDATA[]]>
+        </system-err>
+      </testsuite>
+
+      """ 

data/features/docs/formatters/pretty_formatter.feature

@@ -28,4 +28,46 @@ Feature: Pretty output formatter
     """
     Using the default profile...
     """
+  Scenario: Hook output should be printed before hook exception
+    Given the standard step definitions
+    And a file named "features/test.feature" with:
+      """
+      Feature:
+        Scenario:
+          Given this step passes
+      """
+    And a file named "features/step_definitions/output_steps.rb" with:
+      """
+      Before do
+        puts "Before hook"
+       end
 
+      AfterStep do
+        puts "AfterStep hook"
+      end
+
+      After do
+        puts "After hook"
+	raise "error"
+      end
+      """
+    When I run `cucumber -q -f pretty features/test.feature`
+    Then the stderr should not contain anything
+    Then it should fail with:
+      """
+      Feature: 
+ 
+        Scenario: 
+            Before hook
+          Given this step passes
+            AfterStep hook
+            After hook
+            error (RuntimeError)
+            ./features/step_definitions/output_steps.rb:11:in `After'
+      
+      Failing Scenarios:
+      cucumber features/test.feature:2
+      
+      1 scenario (1 failed)
+      1 step (1 passed)
+      """

data/features/docs/formatters/rerun_formatter.feature

@@ -113,8 +113,9 @@ Feature: Rerun formatter
     features/failing_background_outline.feature:11:12
     """
 
-Scenario: Scenario outlines with expand
-  For details see https://github.com/cucumber/cucumber/issues/503
+  Scenario: Scenario outlines with expand
+    For details see https://github.com/cucumber/cucumber/issues/503
+
     Given a file named "features/one_passing_one_failing.feature" with:
     """
       Feature: One passing example, one failing example

data/features/docs/getting_started.feature

@@ -9,7 +9,7 @@ Feature: Getting started
     When I run `cucumber`
     Then it should fail with:
       """
-      No such file or directory - features. Please create a features directory to get started.
+      No such file or directory - features. You can use `cucumber --init` to get started.
       """
 
   Scenario: Accidentally run Cucumber in a folder with Ruby files in it.

data/features/docs/{wire_protocol_erb.feature → wire_protocol/erb_configuration.feature}

@@ -1,6 +1,6 @@
 @wire
-Feature: Wire Protocol with ERB
-  In order to be allow Cucumber to touch my app in intimate places
+Feature: ERB configuration
+
   As a developer on server with multiple users
   I want to be able to configure which port my wire server runs on
   So that I can avoid port conflicts

data/features/docs/wire_protocol/handle_unexpected_response.feature

@@ -0,0 +1,30 @@
+@wire
+Feature: Handle unexpected response
+
+  When the server sends us back a message we don't understand, this is how Cucumber will behave.
+
+  Background:
+    Given a file named "features/wired.feature" with:
+      """
+      Feature: High strung
+        Scenario: Wired
+          Given we're all wired
+
+      """
+    And a file named "features/step_definitions/some_remote_place.wire" with:
+      """
+      host: localhost
+      port: 54321
+
+      """
+
+  Scenario: Unexpected response
+    Given there is a wire server running on port 54321 which understands the following protocol:
+      | request                                              | response                            |
+      | ["begin_scenario"]                                   | ["yikes"]                           |
+      | ["step_matches",{"name_to_match":"we're all wired"}] | ["success",[{"id":"1", "args":[]}]] |
+    When I run `cucumber -f pretty`
+    Then the output should contain:
+      """
+      undefined method `handle_yikes'
+      """