cucumber 11.1.0 → 12.0.0

data/lib/cucumber/formatter/json.rb

@@ -22,6 +22,7 @@ module Cucumber
         config.on_event :test_step_started, &method(:on_test_step_started)
         config.on_event :test_step_finished, &method(:on_test_step_finished)
         config.on_event :test_run_finished, &method(:on_test_run_finished)
+        config.on_event :attach_called, &method(:on_attach_called)
       end
 
       def on_test_case_started(event)
@@ -87,18 +88,19 @@ module Cucumber
         @io.write(JSON.pretty_generate(@feature_hashes))
       end
 
-      def attach(src, mime_type, _filename, _streamed_file)
-        if mime_type == 'text/x.cucumber.log+plain'
-          test_step_output << src
+      def on_attach_called(event)
+        if event.media_type == 'text/x.cucumber.log+plain'
+          test_step_output << event.src
           return
         end
-        if mime_type =~ /;base64$/
-          mime_type = mime_type[0..-8]
-          data = src
+        if event.media_type =~ /;base64$/
+          media_type = event.media_type[0..-8]
+          data = event.src
         else
-          data = encode64(src)
+          data = encode64(event.src)
+          media_type = event.media_type
         end
-        test_step_embeddings << { mime_type: mime_type, data: data }
+        test_step_embeddings << { mime_type: media_type, data: data }
       end
 
       private

data/lib/cucumber/formatter/junit.rb

@@ -53,7 +53,7 @@ module Cucumber
       def on_test_step_finished(event)
         return if @failing_test_step
 
-        @failing_test_step = event.test_step unless event.result.ok?(strict: @config.strict)
+        @failing_test_step = event.test_step unless event.result.ok?
       end
 
       def on_test_case_finished(event)
@@ -109,7 +109,7 @@ module Cucumber
         scenario_source = @ast_lookup.scenario_source(test_case)
         keyword = scenario_source.type == :Scenario ? scenario_source.scenario.keyword : scenario_source.scenario_outline.keyword
         output = "#{keyword}: #{scenario}\n\n"
-        return output if result.ok?(strict: @config.strict)
+        return output if result.ok?
 
         if scenario_source.type == :Scenario
           if @failing_test_step
@@ -138,7 +138,7 @@ module Cucumber
         testcase_attributes = get_testcase_attributes(classname, name, duration, filename)
 
         @current_feature_data[:builder].testcase(testcase_attributes) do
-          if !result.passed? && result.ok?(strict: @config.strict)
+          if !result.passed? && result.ok?
             @current_feature_data[:builder].skipped
             @current_feature_data[:skipped] += 1
           elsif !result.passed?

data/lib/cucumber/formatter/message.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
-require 'cucumber/formatter/io'
-require 'cucumber/query'
+require_relative 'io'
 
 module Cucumber
   module Formatter
@@ -11,14 +10,11 @@ module Cucumber
 
       def initialize(config)
         @io = ensure_io(config.out_stream, config.error_stream)
-        @repository = Cucumber::Repository.new
-        @query = Cucumber::Query.new(@repository)
         config.on_event :envelope, &method(:output_envelope)
       end
 
       def output_envelope(event)
         envelope = event.envelope
-        @repository.update(envelope)
         @io.write(envelope.to_json)
         @io.write("\n")
       end

data/lib/cucumber/formatter/message_builder.rb

@@ -3,14 +3,17 @@
 require 'base64'
 require 'json'
 
-require 'cucumber/formatter/backtrace_filter'
 require 'cucumber/query'
 
+require_relative 'backtrace_filter'
+require_relative 'message_handlers'
+
 module Cucumber
   module Formatter
     class MessageBuilder
       include Cucumber::Messages::Helpers::TimeConversion
       include Io
+      include MessageHandlers
       include Console
 
       def initialize(config)
@@ -20,8 +23,7 @@ module Cucumber
 
         @test_run_started_id = config.test_run_started_id
 
-        # Fake Query objects
-        @test_case_by_step_id = {}
+        # Fake Query objects - used to build specific parts of the messages defined inside handlers
         @pickle_id_by_test_case_id = {}
         @pickle_id_step_by_test_step_id = {}
         @hook_id_by_test_step_id = {}
@@ -30,56 +32,60 @@ module Cucumber
 
         # Ensure all handlers for events occur after all ivars are instantiated
 
-        config.on_event :gherkin_source_parsed, &method(:on_gherkin_source_parsed)
-
         config.on_event :hook_test_step_created, &method(:on_hook_test_step_created)
 
         config.on_event :step_activated, &method(:on_step_activated)
 
         config.on_event :test_case_created, &method(:on_test_case_created)
         config.on_event :test_case_ready, &method(:on_test_case_ready)
-        config.on_event :test_case_started, &method(:on_test_case_started)
-        config.on_event :test_case_finished, &method(:on_test_case_finished)
 
         config.on_event :test_run_started, &method(:on_test_run_started)
         config.on_event :test_run_finished, &method(:on_test_run_finished)
 
         config.on_event :test_step_created, &method(:on_test_step_created)
-        config.on_event :test_step_started, &method(:on_test_step_started)
         config.on_event :test_step_finished, &method(:on_test_step_finished)
 
+        config.on_event :attach_called, &method(:on_attach_called)
         config.on_event :envelope, &method(:on_envelope)
       end
 
       def on_envelope(event)
-        @current_test_run_hook_started_id = event.envelope.test_run_hook_started.id if event.envelope.test_run_hook_started
+        @repository.update(event.envelope)
+        store_current_test_run_hook_started_id(event)
+        @current_test_step_id = event.envelope.test_step_started.test_step_id if event.envelope.test_step_started
+        return unless event.envelope.test_case_started
+
+        @current_test_case_started_id = event.envelope.test_case_started.id
+        @current_test_run_hook_started_id = nil
       end
 
-      def attach(src, media_type, filename, streamed_file)
+      def on_attach_called(event)
         attachment_data =
           if @current_test_run_hook_started_id.nil?
             {
               test_step_id: @current_test_step_id,
               test_case_started_id: @current_test_case_started_id,
-              media_type: media_type,
-              file_name: filename,
+              media_type: event.media_type,
+              file_name: event.filename,
               timestamp: time_to_timestamp(Time.now)
             }
           else
             {
               test_run_hook_started_id: @current_test_run_hook_started_id,
-              media_type: media_type,
-              file_name: filename,
+              media_type: event.media_type,
+              file_name: event.filename,
               timestamp: time_to_timestamp(Time.now)
             }
           end
 
+        streamed_file = event.src.encoding == Encoding::BINARY
+
         if streamed_file
           attachment_data[:content_encoding] = Cucumber::Messages::AttachmentContentEncoding::BASE64
-          attachment_data[:body] = Base64.strict_encode64(src)
+          attachment_data[:body] = Base64.strict_encode64(event.src)
         else
           attachment_data[:content_encoding] = Cucumber::Messages::AttachmentContentEncoding::IDENTITY
-          attachment_data[:body] = src.is_a?(Hash) ? src.to_json : src
+          attachment_data[:body] = event.src.is_a?(Hash) ? event.src.to_json : event.src
         end
 
         message = Cucumber::Messages::Envelope.new(attachment: Cucumber::Messages::Attachment.new(**attachment_data))
@@ -88,28 +94,31 @@ module Cucumber
 
       private
 
-      def on_gherkin_source_parsed(_event)
-        # TODO: Handle GherkinSourceParsed
-      end
-
       def on_hook_test_step_created(event)
+        # Set iVar value for `hook_id`
         @hook_id_by_test_step_id[event.test_step.id] = event.hook.id
       end
 
       def on_step_activated(event)
+        # Add/Update iVar value for `step_definition_ids...`
         @step_definition_ids_by_test_step_id[event.test_step.id] << event.step_match.step_definition.id
+        # Add/Update iVar value for `step_match_arguments...`
         @step_match_arguments_by_test_step_id[event.test_step.id] = event.step_match.step_arguments
       end
 
       def on_test_case_created(event)
+        # Set iVar value for `pickle_id`
         @pickle_id_by_test_case_id[event.test_case.id] = event.pickle.id
       end
 
       def on_test_case_ready(event)
+        # Use iVar value for `pickle_id`
+        pickle_id = @pickle_id_by_test_case_id.fetch(event.test_case.id)
+
         message = Cucumber::Messages::Envelope.new(
           test_case: Cucumber::Messages::TestCase.new(
             id: event.test_case.id,
-            pickle_id: fake_query_pickle_id(event.test_case),
+            pickle_id: pickle_id,
             test_steps: event.test_case.test_steps.map { |step| test_step_to_message(step) },
             test_run_started_id: @test_run_started_id
           )
@@ -121,55 +130,6 @@ module Cucumber
         @config.event_bus.envelope(message)
       end
 
-      def on_test_case_started(event)
-        # For any new test_case_started events, we must ALWAYS generate a new id for a new run
-        @current_test_case_started_id = @config.id_generator.new_id
-        @current_test_run_hook_started_id = nil
-
-        find_all_test_case_started_by_test_case_id =
-          @repository.test_case_started_by_id
-                     .values
-                     .select { |test_case_started| test_case_started.test_case_id == event.test_case.id }
-
-        # If no TestCaseStarted messages exist. We must be on attempt 1 (Hence the .to_i casting for a `nil` value)
-        attempts_previously_made = find_all_test_case_started_by_test_case_id.map(&:attempt).max.to_i
-
-        message = Cucumber::Messages::Envelope.new(
-          test_case_started: Cucumber::Messages::TestCaseStarted.new(
-            id: @current_test_case_started_id,
-            test_case_id: event.test_case.id,
-            timestamp: time_to_timestamp(Time.now),
-            attempt: attempts_previously_made + 1
-          )
-        )
-
-        @config.event_bus.envelope(message)
-        @repository.update(message)
-      end
-
-      def on_test_case_finished(event)
-        test_case_started_id =
-          @repository.test_case_started_by_id
-                     .values
-                     .detect { |test_case_started_message| test_case_started_message.test_case_id == event.test_case.id }
-                     .id
-
-        test_case_started_message = @repository.test_case_started_by_id[test_case_started_id]
-        max_attempts = @config.retry_attempts
-        retries_attempted = test_case_started_message.attempt - 1
-        will_be_retried = event.result.failed? && (retries_attempted < max_attempts)
-
-        message = Cucumber::Messages::Envelope.new(
-          test_case_finished: Cucumber::Messages::TestCaseFinished.new(
-            test_case_started_id: test_case_started_id,
-            timestamp: time_to_timestamp(Time.now),
-            will_be_retried: will_be_retried
-          )
-        )
-
-        @config.event_bus.envelope(message)
-      end
-
       def on_test_run_started(*)
         message = Cucumber::Messages::Envelope.new(
           test_run_started: Cucumber::Messages::TestRunStarted.new(
@@ -194,71 +154,14 @@ module Cucumber
       end
 
       def on_test_step_created(event)
+        # Set iVar value for `pickle_id_step_...`
         @pickle_id_step_by_test_step_id[event.test_step.id] = event.pickle_step.id
+        # Set iVar value for `step_definition_ids...`
         @step_definition_ids_by_test_step_id[event.test_step.id] = []
       end
 
-      def on_test_step_started(event)
-        @current_test_step_id = event.test_step.id
-        find_test_case_by_step_id =
-          @repository.test_case_by_id
-                     .values
-                     .detect { |test_case_message| test_case_message.test_steps.any? { |step_message| step_message.id == event.test_step.id } }
-
-        find_test_case_started_by_test_case =
-          @repository.test_case_started_by_id
-                     .values
-                     .select { |test_case_started_message| test_case_started_message.test_case_id == find_test_case_by_step_id.id }
-                     .max_by(&:attempt)
-
-        message = Cucumber::Messages::Envelope.new(
-          test_step_started: Cucumber::Messages::TestStepStarted.new(
-            test_step_id: event.test_step.id,
-            test_case_started_id: find_test_case_started_by_test_case.id,
-            timestamp: time_to_timestamp(Time.now)
-          )
-        )
-
-        @config.event_bus.envelope(message)
-      end
-
       def on_test_step_finished(event)
-        find_test_case_by_step_id =
-          @repository.test_case_by_id
-                     .values
-                     .detect { |test_case_message| test_case_message.test_steps.any? { |step_message| step_message.id == event.test_step.id } }
-
-        find_test_case_started_by_test_case =
-          @repository.test_case_started_by_id
-                     .values
-                     .select { |test_case_started_message| test_case_started_message.test_case_id == find_test_case_by_step_id.id }
-                     .max_by(&:attempt)
-
-        result = event.result.with_filtered_backtrace(Cucumber::Formatter::BacktraceFilter)
-        result_message = result.to_message
-        if result.failed? || result.pending?
-          message_element = result.failed? ? result.exception : result
-
-          result_message = Cucumber::Messages::TestStepResult.new(
-            status: result_message.status,
-            duration: result_message.duration,
-            message: create_error_message(message_element),
-            exception: create_exception_object(result, message_element)
-          )
-        end
-
         output_snippet_envelope(event)
-
-        message = Cucumber::Messages::Envelope.new(
-          test_step_finished: Cucumber::Messages::TestStepFinished.new(
-            test_step_id: event.test_step.id,
-            test_case_started_id: find_test_case_started_by_test_case.id,
-            test_step_result: result_message,
-            timestamp: time_to_timestamp(Time.now)
-          )
-        )
-
-        @config.event_bus.envelope(message)
       end
 
       def output_snippet_envelope(event)
@@ -305,8 +208,10 @@ module Cucumber
 
         Cucumber::Messages::TestStep.new(
           id: step.id,
+          # Use iVar value for `pickle_id_step_...`
           pickle_step_id: @pickle_id_step_by_test_step_id[step.id],
-          step_definition_ids: fake_query_step_definition_ids(step),
+          # Use iVar value for `step_definition_ids...`
+          step_definition_ids: @step_definition_ids_by_test_step_id.fetch(step.id),
           step_match_arguments_lists: step_match_arguments_lists(step)
         )
       end
@@ -314,6 +219,7 @@ module Cucumber
       def hook_step_to_message(step)
         Cucumber::Messages::TestStep.new(
           id: step.id,
+          # Use iVar value for `hook_id`
           hook_id: @hook_id_by_test_step_id[step.id]
         )
       end
@@ -328,7 +234,9 @@ module Cucumber
       end
 
       def step_match_arguments(step)
-        fake_query_step_match_arguments(step)&.map do |argument|
+        # Use iVar value for `step_match_arguments...`
+        step_matches = @step_match_arguments_by_test_step_id[step.id]
+        step_matches&.map do |argument|
           Cucumber::Messages::StepMatchArgument.new(
             group: argument_group_to_message(argument.group),
             parameter_type_name: parameter_type_name(argument)
@@ -364,22 +272,6 @@ module Cucumber
           stack_trace: message_element.backtrace.join("\n")
         )
       end
-
-      def fake_query_hook_id(test_step)
-        @hook_id_by_test_step_id.fetch(test_step.id)
-      end
-
-      def fake_query_pickle_id(test_case)
-        @pickle_id_by_test_case_id.fetch(test_case.id)
-      end
-
-      def fake_query_step_definition_ids(test_step)
-        @step_definition_ids_by_test_step_id.fetch(test_step.id)
-      end
-
-      def fake_query_step_match_arguments(test_step)
-        @step_match_arguments_by_test_step_id.fetch(test_step.id, nil)
-      end
     end
   end
 end

data/lib/cucumber/formatter/message_handlers.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module Cucumber
+  module Formatter
+    # Common Message Handlers to be used across all message-based formatters
+    # Designed to work solely with events of type `Envelope`
+    module MessageHandlers
+      def store_current_test_run_hook_started_id(event)
+        @current_test_run_hook_started_id = event.envelope.test_run_hook_started.id if event.envelope.test_run_hook_started
+      end
+    end
+  end
+end

data/lib/cucumber/formatter/pretty.rb

@@ -64,6 +64,7 @@ module Cucumber
         config.on_event :test_case_finished, &method(:on_test_case_finished)
         config.on_event :test_run_finished, &method(:on_test_run_finished)
         config.on_event :undefined_parameter_type, &method(:collect_undefined_parameter_type_names)
+        config.on_event :attach_called, &method(:on_attach_called)
       end
 
       def on_gherkin_source_read(event)
@@ -137,20 +138,20 @@ module Cucumber
         print_summary
       end
 
-      def attach(src, media_type, filename, _streamed_file)
-        return unless media_type == 'text/x.cucumber.log+plain'
+      def on_attach_called(event)
+        return unless event.media_type == 'text/x.cucumber.log+plain'
 
-        if filename
-          @test_step_output.push("#{filename}: #{src}")
+        if event.filename
+          @test_step_output.push("#{event.filename}: #{event.src}")
         else
-          @test_step_output.push(src)
+          @test_step_output.push(event.src)
         end
       end
 
       private
 
       def find_exception_to_be_printed(result)
-        return nil if result.ok?(strict: options[:strict])
+        return nil if result.ok?
 
         result = result.with_filtered_backtrace(Cucumber::Formatter::BacktraceFilter)
         exception = result.failed? ? result.exception : result

data/lib/cucumber/formatter/progress.rb

@@ -36,6 +36,7 @@ module Cucumber
         config.on_event :test_case_finished, &method(:on_test_case_finished)
         config.on_event :test_run_finished, &method(:on_test_run_finished)
         config.on_event :undefined_parameter_type, &method(:collect_undefined_parameter_type_names)
+        config.on_event :attach_called, &method(:on_attach_called)
       end
 
       def on_step_activated(event)

data/lib/cucumber/formatter/rerun.rb

@@ -1,8 +1,9 @@
 # frozen_string_literal: true
 
-require 'cucumber/formatter/io'
 require 'cucumber/query'
 
+require_relative 'io'
+
 module Cucumber
   module Formatter
     class Rerun
@@ -27,42 +28,20 @@ module Cucumber
       def finish_report
         @query.find_all_test_case_started.each do |test_case|
           status = @query.find_most_severe_test_step_result_by(test_case).status
-          # RULE: Don't log test cases without a pickle (Unsure what these could be?)
+
+          # RULE: Don't log test cases without a pickle (We cannot query their location data to log them)
           pickle = @query.find_pickle_by(test_case)
           next if pickle.nil?
 
-          # RULE: (Configuration specific)
-          #   -> If the test case has already been logged (And so we're retrying), we remove prior references of failures
-          if passing?(test_case) && !rerun_flaky_tests?
+          # RULE: Test cases with the worst result as Passing is not considered a failure (Don't log these)
+          if status == Cucumber::Messages::TestStepResultStatus::PASSED
+            # If the test case in question had already been logged as a failure (And we're retrying), remove the prior reference of failure
             uri_and_location_hash[pickle.uri].delete(pickle.location.line)
             next
           end
 
-          # RULE: (Configuration specific - to be amended once CCK conformance is finalised)
-          #   -> If the strict configuration permits the result - handle it accordingly
-          if status == 'UNDEFINED' && !@config.strict.strict?(:undefined)
-            Cucumber.deprecate(
-              'The strict configuration in cucumber is going away and moving towards a standardised set of behaviours',
-              '--strict=undefined',
-              '12.0.0'
-            )
-            next
-          end
-
-          if status == 'PENDING' && !@config.strict.strict?(:pending)
-            Cucumber.deprecate(
-              'The strict configuration in cucumber is going away and moving towards a standardised set of behaviours',
-              '--strict=pending',
-              '12.0.0'
-            )
-            next
-          end
-
-          # RULE: Passing test cases are not considered failures (Don't log these)
-          next if passing?(test_case)
-
-          # RULE: Skipped test cases are not considered failures (on their own, don't log these)
-          next if skipped?(test_case)
+          # RULE: Test cases with the worst result as Skipped/Pending/Undefined are not considered failures (don't log these)
+          next if non_rerunnable_status?(status)
 
           # RULE: Before logging a failure, ensure we are not on a retried test case (Don't log a retry multiple times)
           next if test_case.attempt > 1
@@ -85,18 +64,12 @@ module Cucumber
         @uri_and_location_hash ||= Hash.new { |hash, key| hash[key] = Set.new }
       end
 
-      def rerun_flaky_tests?
-        @config.strict.strict?(:flaky)
-      end
-
-      def passing?(test_case_started)
-        most_severe_test_step_result = @query.find_most_severe_test_step_result_by(test_case_started)
-        most_severe_test_step_result.status == Cucumber::Messages::TestStepResultStatus::PASSED
-      end
-
-      def skipped?(test_case_started)
-        most_severe_test_step_result = @query.find_most_severe_test_step_result_by(test_case_started)
-        most_severe_test_step_result.status == Cucumber::Messages::TestStepResultStatus::SKIPPED
+      def non_rerunnable_status?(status)
+        [
+          Cucumber::Messages::TestStepResultStatus::SKIPPED,
+          Cucumber::Messages::TestStepResultStatus::PENDING,
+          Cucumber::Messages::TestStepResultStatus::UNDEFINED
+        ].include?(status)
       end
     end
   end

data/lib/cucumber/formatter/summary.rb

@@ -4,12 +4,13 @@ require 'cucumber/formatter/io'
 require 'cucumber/formatter/console'
 require 'cucumber/formatter/console_counts'
 require 'cucumber/formatter/console_issues'
+require 'cucumber/formatter/backtrace_filter'
 require 'cucumber/core/test/result'
 require 'cucumber/formatter/ast_lookup'
 
 module Cucumber
   module Formatter
-    # Summary formatter, outputting only feature / scenario titles
+    # Summary formatter, outputting feature / scenario titles plus failure details
     class Summary
       include Io
       include Console
@@ -20,6 +21,7 @@ module Cucumber
         @ast_lookup = AstLookup.new(config)
         @counts = ConsoleCounts.new(@config)
         @issues = ConsoleIssues.new(@config, @ast_lookup)
+        @failed_results = []
         @start_time = Time.now
 
         @config.on_event :test_case_started do |event|
@@ -31,9 +33,14 @@ module Cucumber
           print_result event.result
         end
 
+        @config.on_event :test_step_finished do |event|
+          collect_failed_result(event.test_step, event.result)
+        end
+
         @config.on_event :test_run_finished do |_event|
           duration = Time.now - @start_time
           @io.puts
+          print_elements(@failed_results, :failed, 'steps')
           print_statistics(duration, @config, @counts, @issues)
         end
       end
@@ -61,6 +68,13 @@ module Cucumber
       def print_result(result)
         @io.puts format_string(result, result.to_sym)
       end
+
+      def collect_failed_result(test_step, result)
+        return if test_step.hook?
+
+        result = result.with_filtered_backtrace(Cucumber::Formatter::BacktraceFilter)
+        @failed_results << result if result.failed?
+      end
     end
   end
 end

data/lib/cucumber/glue/hook.rb

@@ -4,7 +4,6 @@ require 'cucumber/glue/invoke_in_world'
 
 module Cucumber
   module Glue
-    # TODO: Kill pointless wrapper for Before, After and AfterStep hooks with fire
     class Hook
       attr_reader :id, :tag_expressions, :location, :name
 

data/lib/cucumber/glue/multiple_world.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+module Cucumber
+  module Glue
+    # Raised if there are 2 or more World blocks.
+    class MultipleWorld < StandardError
+      def initialize(first_proc, second_proc)
+        super(error_message(first_proc, second_proc))
+      end
+
+      def error_message(first_proc, second_proc)
+        <<~MESSAGE
+      You can only pass a proc to #World once, but it's happening
+      in 2 places:
+      #{Glue.backtrace_line(first_proc, 'World')}
+      #{Glue.backtrace_line(second_proc, 'World')}
+      Use Ruby modules instead to extend your worlds. See the Cucumber::Glue::Dsl#World RDoc
+      or http://wiki.github.com/cucumber/cucumber/a-whole-new-world.
+
+
+        MESSAGE
+      end
+    end
+
+  end
+end

data/lib/cucumber/glue/nil_world.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module Cucumber
+  module Glue
+    # Raised if a World block returns Nil.
+    class NilWorld < StandardError
+      def initialize
+        super('World procs should never return nil')
+      end
+    end
+  end
+end

data/lib/cucumber/glue/proto_world.rb

@@ -93,12 +93,11 @@ module Cucumber
         if File.file?(file)
           media_type = MiniMime.lookup_by_filename(file)&.content_type if media_type.nil?
           file = File.read(file, mode: 'rb')
-          streamed_file = true
         end
         # We pass in the concept of whether the file is streamed to ensure that the envelope encoding is correct
-        super(file, media_type, filename, streamed_file)
+        super(file, media_type, filename)
       rescue StandardError
-        super(file, media_type, filename, streamed_file)
+        super(file, media_type, filename)
       end
 
       # Mark the matched step as pending.
@@ -155,8 +154,8 @@ module Cucumber
             runtime.ask(question, timeout_seconds)
           end
 
-          define_method(:attach) do |file, media_type, filename, streamed_file|
-            runtime.attach(file, media_type, filename, streamed_file)
+          define_method(:attach) do |file, media_type, filename|
+            runtime.attach(file, media_type, filename)
           end
 
           # Prints the list of modules that are included in the World