cucumber 11.0.0 → 11.1.0

data/lib/cucumber/formatter/console.rb

@@ -116,11 +116,11 @@ module Cucumber
       def collect_snippet_data(test_step, ast_lookup)
         # collect snippet data for undefined steps
         keyword = ast_lookup.snippet_step_keyword(test_step)
-        @snippets_input << Console::SnippetData.new(keyword, test_step)
+        snippets_input << Console::SnippetData.new(keyword, test_step)
       end
 
       def collect_undefined_parameter_type_names(undefined_parameter_type)
-        @undefined_parameter_types << undefined_parameter_type.type_name
+        undefined_parameter_types << undefined_parameter_type.type_name
       end
 
       def print_snippets(options)
@@ -129,9 +129,9 @@ module Cucumber
         snippet_text_proc = lambda do |step_keyword, step_name, multiline_arg|
           snippet_text(step_keyword, step_name, multiline_arg)
         end
-        do_print_snippets(snippet_text_proc) unless @snippets_input.empty?
+        do_print_snippets(snippet_text_proc) unless snippets_input.empty?
 
-        @undefined_parameter_types.map do |type_name|
+        undefined_parameter_types.map do |type_name|
           do_print_undefined_parameter_type_snippet(type_name)
         end
       end
@@ -169,7 +169,7 @@ module Cucumber
         end
       end
 
-      def attach(src, media_type, filename)
+      def attach(src, media_type, filename, _streamed_file)
         return unless media_type == 'text/x.cucumber.log+plain'
         return unless @io
 
@@ -249,11 +249,19 @@ module Cucumber
 
       def snippet_text(step_keyword, step_name, multiline_arg)
         keyword = Cucumber::Gherkin::I18n.code_keyword_for(step_keyword).strip
-        config.snippet_generators.map do |generator|
-          generator.call(keyword, step_name, multiline_arg, config.snippet_type)
+        @config.snippet_generators.map do |generator|
+          generator.call(keyword, step_name, multiline_arg, @config.snippet_type)
         end.join("\n")
       end
 
+      def snippets_input
+        @snippets_input ||= []
+      end
+
+      def undefined_parameter_types
+        @undefined_parameter_types ||= []
+      end
+
       class SnippetData
         attr_reader :actual_keyword, :step
 

data/lib/cucumber/formatter/console_issues.rb

@@ -10,6 +10,7 @@ module Cucumber
       def initialize(config, ast_lookup = AstLookup.new(config))
         @previous_test_case = nil
         @issues = Hash.new { |h, k| h[k] = [] }
+        @global_hooks_summary = GlobalHooksSummary.new(config)
         @config = config
         @config.on_event(:test_case_finished) do |event|
           if event.test_case != @previous_test_case
@@ -24,14 +25,13 @@ module Cucumber
       end
 
       def to_s
-        return if @issues.empty?
-
-        result = Core::Test::Result::TYPES.map { |type| scenario_listing(type, @issues[type]) }
-        result.flatten.join("\n")
+        test_case_result = @issues.empty? ? [] : Core::Test::Result::TYPES.map { |type| scenario_listing(type, @issues[type]) }
+        global_hooks_result = @global_hooks_summary.ok? ? [] : @global_hooks_summary.exception_listing
+        [test_case_result + global_hooks_result].flatten.join("\n")
       end
 
       def any?
-        @issues.any?
+        @issues.any? || !@global_hooks_summary.ok?
       end
 
       private

data/lib/cucumber/formatter/fail_fast.rb

@@ -9,11 +9,10 @@ module Cucumber
       def initialize(configuration)
         @previous_test_case = nil
         configuration.on_event :test_case_finished do |event|
-          test_case, result = *event.attributes
-          if test_case != @previous_test_case
+          if event.test_case != @previous_test_case
             @previous_test_case = event.test_case
-            Cucumber.wants_to_quit = true unless result.ok?(strict: configuration.strict)
-          elsif result.passed?
+            Cucumber.wants_to_quit = true unless event.result.ok?(strict: configuration.strict)
+          elsif event.result.passed?
             Cucumber.wants_to_quit = false
           end
         end

data/lib/cucumber/formatter/global_hooks_summary.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+require 'cucumber/formatter/io'
+require 'cucumber/formatter/console'
+require 'cucumber/formatter/console_counts'
+require 'cucumber/formatter/console_issues'
+require 'cucumber/core/test/result'
+require 'cucumber/formatter/ast_lookup'
+
+module Cucumber
+  module Formatter
+    # AllHookSummary formatter, keep track of failures in Before/AfterAll hooks
+    class GlobalHooksSummary
+      include Console
+
+      def initialize(config)
+        @config = config
+        @all_hook_failures = []
+
+        @config.on_event :test_run_hook_finished do |event|
+          @all_hook_failures << event unless event.test_result.ok?
+        end
+      end
+
+      def ok?
+        @all_hook_failures.empty?
+      end
+
+      def exception_listing
+        [format_string('Global hook failures:', :failed)] + @all_hook_failures.map do |event|
+          format_string("#{event.hook.location} # #{event.test_result.exception} (#{event.test_result.exception.class})", :failed)
+        end
+      end
+    end
+  end
+end

data/lib/cucumber/formatter/json.rb

@@ -65,7 +65,8 @@ module Cucumber
       end
 
       def on_test_step_finished(event)
-        test_step, result = *event.attributes
+        test_step = event.test_step
+        result = event.result
         result = result.with_filtered_backtrace(Cucumber::Formatter::BacktraceFilter)
         return if internal_hook?(test_step)
 
@@ -76,7 +77,8 @@ module Cucumber
       def on_test_case_finished(event)
         feature_elements << @test_case_hash if @in_background
 
-        _test_case, result = *event.attributes
+        _test_case = event.test_case
+        result = event.result
         result = result.with_filtered_backtrace(Cucumber::Formatter::BacktraceFilter)
         add_failed_around_hook(result) if result.failed? && !@any_step_failed
       end
@@ -85,7 +87,7 @@ module Cucumber
         @io.write(JSON.pretty_generate(@feature_hashes))
       end
 
-      def attach(src, mime_type, _filename)
+      def attach(src, mime_type, _filename, _streamed_file)
         if mime_type == 'text/x.cucumber.log+plain'
           test_step_output << src
           return

data/lib/cucumber/formatter/junit.rb

@@ -51,19 +51,17 @@ module Cucumber
       end
 
       def on_test_step_finished(event)
-        test_step, result = *event.attributes
         return if @failing_test_step
 
-        @failing_test_step = test_step unless result.ok?(strict: @config.strict)
+        @failing_test_step = event.test_step unless event.result.ok?(strict: @config.strict)
       end
 
       def on_test_case_finished(event)
-        test_case, result = *event.attributes
-        result = result.with_filtered_backtrace(Cucumber::Formatter::BacktraceFilter)
-        test_case_name = NameBuilder.new(test_case, @ast_lookup)
+        result = event.result.with_filtered_backtrace(Cucumber::Formatter::BacktraceFilter)
+        test_case_name = NameBuilder.new(event.test_case, @ast_lookup)
         scenario = test_case_name.scenario_name
         scenario_designation = "#{scenario}#{test_case_name.name_suffix}"
-        output = create_output_string(test_case, scenario, result, test_case_name.row_name)
+        output = create_output_string(event.test_case, scenario, result, test_case_name.row_name)
         build_testcase(result, scenario_designation, output)
 
         Interceptor::Pipe.unwrap! :stdout

data/lib/cucumber/formatter/message.rb

@@ -1,20 +1,23 @@
 # frozen_string_literal: true
 
 require 'cucumber/formatter/io'
-require 'cucumber/formatter/message_builder'
+require 'cucumber/query'
 
 module Cucumber
   module Formatter
     # The formatter used for <tt>--format message</tt>
-    class Message < MessageBuilder
+    class Message
       include Io
 
       def initialize(config)
         @io = ensure_io(config.out_stream, config.error_stream)
-        super(config)
+        @repository = Cucumber::Repository.new
+        @query = Cucumber::Query.new(@repository)
+        config.on_event :envelope, &method(:output_envelope)
       end
 
-      def output_envelope(envelope)
+      def output_envelope(event)
+        envelope = event.envelope
         @repository.update(envelope)
         @io.write(envelope.to_json)
         @io.write("\n")