cucumber 1.3.10 → 2.0.0

data/{legacy_features/exception_in_after_block.feature → features/docs/exception_in_after_hook.feature}

@@ -4,14 +4,12 @@ Feature: Exception in After Block
   I want exceptions raised in After blocks to be handled gracefully and reported by the formatters
 
   Background:
-    Given a standard Cucumber project directory structure
-    And a file named "features/step_definitions/steps.rb" with:
+    Given the standard step definitions
+    And a file named "features/step_definitions/naughty_steps.rb" with:
       """
       Given /^this step does something naughty$/ do x=1
         @naughty = true
       end
-
-      Given(/^this step works$/) do; end
       """
     And a file named "features/support/env.rb" with:
       """
@@ -23,6 +21,7 @@ Feature: Exception in After Block
       end
       """
 
+  @spawn
   Scenario: Handle Exception in standard scenario step and carry on
     Given a file named "features/naughty_step_in_scenario.feature" with:
       """
@@ -32,20 +31,20 @@ Feature: Exception in After Block
           Given this step does something naughty
 
         Scenario: Success
-          Given this step works
+          Given this step passes
       """
-    When I run cucumber features
-    Then it should fail with
+    When I run `cucumber features`
+    Then it should fail with:
       """
       Feature: Sample
 
         Scenario: Naughty Step                   # features/naughty_step_in_scenario.feature:3
-          Given this step does something naughty # features/step_definitions/steps.rb:1
+          Given this step does something naughty # features/step_definitions/naughty_steps.rb:1
             This scenario has been very very naughty (NaughtyScenarioException)
             ./features/support/env.rb:4:in `After'
 
-        Scenario: Success       # features/naughty_step_in_scenario.feature:6
-          Given this step works # features/step_definitions/steps.rb:5
+        Scenario: Success        # features/naughty_step_in_scenario.feature:6
+          Given this step passes # features/step_definitions/steps.rb:1
 
       Failing Scenarios:
       cucumber features/naughty_step_in_scenario.feature:3 # Scenario: Naughty Step
@@ -55,6 +54,7 @@ Feature: Exception in After Block
 
       """
 
+  @spawn
   Scenario: Handle Exception in scenario outline table row and carry on
     Given a file named "features/naughty_step_in_scenario_outline.feature" with:
       """
@@ -65,35 +65,35 @@ Feature: Exception in After Block
 
           Examples:
           | Might Work             |
-          | works                  |
+          | passes                 |
           | does something naughty |
-          | works                  |
+          | passes                 |
 
         Scenario: Success
-          Given this step works
+          Given this step passes
 
       """
-    When I run cucumber features
-    Then it should fail with
+    When I run `cucumber features -q`
+    Then it should fail with:
       """
       Feature: Sample
 
-        Scenario Outline: Naughty Step # features/naughty_step_in_scenario_outline.feature:3
-          Given this step <Might Work> # features/step_definitions/steps.rb:5
+        Scenario Outline: Naughty Step
+          Given this step <Might Work>
 
           Examples: 
             | Might Work             |
-            | works                  |
+            | passes                 |
             | does something naughty |
             This scenario has been very very naughty (NaughtyScenarioException)
             ./features/support/env.rb:4:in `After'
-            | works                  |
+            | passes                 |
 
-        Scenario: Success       # features/naughty_step_in_scenario_outline.feature:12
-          Given this step works # features/step_definitions/steps.rb:5
+        Scenario: Success
+          Given this step passes
 
       Failing Scenarios:
-      cucumber features/naughty_step_in_scenario_outline.feature:3 # Scenario: Naughty Step
+      cucumber features/naughty_step_in_scenario_outline.feature:9
 
       4 scenarios (1 failed, 3 passed)
       4 steps (4 passed)
@@ -109,10 +109,10 @@ Feature: Exception in After Block
           Given this step does something naughty
 
         Scenario: Success
-          Given this step works
+          Given this step passes
       """
-    When I run cucumber features --format progress
-    Then it should fail with
+    When I run `cucumber features --format progress`
+    Then it should fail with:
       """
       .F.
 
@@ -124,4 +124,3 @@ Feature: Exception in After Block
 
       """
 
-

data/{legacy_features/exception_in_after_step_block.feature → features/docs/exception_in_after_step_hook.feature}

@@ -4,14 +4,12 @@ Feature: Exception in AfterStep Block
   I want exceptions raised in AfterStep blocks to be handled gracefully and reported by the formatters
 
   Background:
-    Given a standard Cucumber project directory structure
-    And a file named "features/step_definitions/steps.rb" with:
+    Given the standard step definitions
+    And a file named "features/step_definitions/naughty_steps.rb" with:
       """
       Given /^this step does something naughty$/ do x=1
         @naughty = true
       end
-
-      Given(/^this step works$/) do; end
       """
     And a file named "features/support/env.rb" with:
       """
@@ -32,27 +30,27 @@ Feature: Exception in AfterStep Block
           Given this step does something naughty
 
         Scenario: Success
-          Given this step works
+          Given this step passes
       """
-    When I run cucumber features
-    Then it should fail with
+    When I run `cucumber features`
+    Then it should fail with:
       """
       Feature: Sample
 
         Scenario: Naughty Step                   # features/naughty_step_in_scenario.feature:3
-          Given this step does something naughty # features/step_definitions/steps.rb:1
+          Given this step does something naughty # features/step_definitions/naughty_steps.rb:1
             This step has been very very naughty (NaughtyStepException)
             ./features/support/env.rb:4:in `AfterStep'
             features/naughty_step_in_scenario.feature:4:in `Given this step does something naughty'
 
-        Scenario: Success       # features/naughty_step_in_scenario.feature:6
-          Given this step works # features/step_definitions/steps.rb:5
+        Scenario: Success        # features/naughty_step_in_scenario.feature:6
+          Given this step passes # features/step_definitions/steps.rb:1
 
       Failing Scenarios:
       cucumber features/naughty_step_in_scenario.feature:3 # Scenario: Naughty Step
 
       2 scenarios (1 failed, 1 passed)
-      2 steps (1 failed, 1 passed)
+      2 steps (2 passed)
 
       """
 
@@ -66,39 +64,39 @@ Feature: Exception in AfterStep Block
 
           Examples:
           | Might Work             |
-          | works                  |
+          | passes                 |
           | does something naughty |
-          | works                  |
+          | passes                 |
 
         Scenario: Success
-          Given this step works
+          Given this step passes
 
       """
-    When I run cucumber features
-    Then it should fail with
+    When I run `cucumber features`
+    Then it should fail with:
       """
       Feature: Sample
 
         Scenario Outline: Naughty Step # features/naughty_step_in_scenario_outline.feature:3
-          Given this step <Might Work> # features/step_definitions/steps.rb:5
+          Given this step <Might Work> # features/naughty_step_in_scenario_outline.feature:4
 
           Examples: 
             | Might Work             |
-            | works                  |
+            | passes                 |
             | does something naughty |
             This step has been very very naughty (NaughtyStepException)
             ./features/support/env.rb:4:in `AfterStep'
+            features/naughty_step_in_scenario_outline.feature:9:in `Given this step does something naughty'
             features/naughty_step_in_scenario_outline.feature:4:in `Given this step <Might Work>'
-            | works                  |
+            | passes                 |
 
-        Scenario: Success       # features/naughty_step_in_scenario_outline.feature:12
-          Given this step works # features/step_definitions/steps.rb:5
+        Scenario: Success        # features/naughty_step_in_scenario_outline.feature:12
+          Given this step passes # features/step_definitions/steps.rb:1
 
       Failing Scenarios:
-      cucumber features/naughty_step_in_scenario_outline.feature:3 # Scenario: Naughty Step
+      cucumber features/naughty_step_in_scenario_outline.feature:9 # Scenario Outline: Naughty Step, Examples (#2)
 
       4 scenarios (1 failed, 3 passed)
-      4 steps (1 failed, 3 passed)
+      4 steps (4 passed)
 
       """
-

data/features/docs/exception_in_around_hook.feature

@@ -0,0 +1,80 @@
+Feature: Exceptions in Around Hooks
+
+  Around hooks are awkward beasts to handle internally.
+
+  Right now, if there's an error in your Around hook before you call `block.call`,
+  we won't even print the steps for the scenario.
+
+  This is because that `block.call` invokes all the logic that would tell Cucumber's
+  UI about the steps in your scenario. If we never reach that code, we'll never be
+  told about them.
+
+  There's another scenario to consider, where the exception occurs after the steps
+  have been run. How would we want to report in that case?
+
+  Scenario: Exception before the test case is run
+    Given the standard step definitions
+    And a file named "features/support/env.rb" with:
+      """
+      Around do |scenario, block|
+        fail "this should be reported"
+        block.call
+      end
+      """
+    And a file named "features/test.feature" with:
+      """
+      Feature:
+        Scenario:
+          Given this step passes
+      """
+    When I run `cucumber -q`
+    Then it should fail with exactly:
+      """
+      Feature: 
+
+        Scenario: 
+        this should be reported (RuntimeError)
+        ./features/support/env.rb:2:in `Around'
+      
+      Failing Scenarios:
+      cucumber features/test.feature:2
+      
+      1 scenario (1 failed)
+      0 steps
+      0m0.012s
+
+      """
+
+  Scenario: Exception after the test case is run
+    Given the standard step definitions
+    And a file named "features/support/env.rb" with:
+      """
+      Around do |scenario, block|
+        block.call
+        fail "this should be reported"
+      end
+      """
+    And a file named "features/test.feature" with:
+      """
+      Feature:
+        Scenario:
+          Given this step passes
+      """
+    When I run `cucumber -q`
+    Then it should fail with exactly:
+      """
+      Feature: 
+
+        Scenario: 
+          Given this step passes
+            this should be reported (RuntimeError)
+            ./features/support/env.rb:3:in `Around'
+      
+      Failing Scenarios:
+      cucumber features/test.feature:2
+      
+      1 scenario (1 failed)
+      1 step (1 passed)
+      0m0.012s
+
+      """

data/{legacy_features/exception_in_before_block.feature → features/docs/exception_in_before_hook.feature}

@@ -4,11 +4,7 @@ Feature: Exception in Before Block
   I want exceptions raised in Before blocks to be handled gracefully and reported by the formatters
 
   Background:
-    Given a standard Cucumber project directory structure
-    And a file named "features/step_definitions/steps.rb" with:
-      """
-      Given(/^this step works$/) do; end
-      """
+    Given the standard step definitions
     And a file named "features/support/env.rb" with:
       """
       class SomeSetupException < Exception; end
@@ -18,23 +14,24 @@ Feature: Exception in Before Block
       end
       """
 
+  @spawn
   Scenario: Handle Exception in standard scenario step and carry on
     Given a file named "features/naughty_step_in_scenario.feature" with:
       """
       Feature: Sample
 
         Scenario: Run a good step
-          Given this step works
+          Given this step passes
       """
-    When I run cucumber features
-    Then it should fail with
+    When I run `cucumber features`
+    Then it should fail with:
       """
       Feature: Sample
 
         Scenario: Run a good step # features/naughty_step_in_scenario.feature:3
         I cannot even start this scenario (SomeSetupException)
         ./features/support/env.rb:4:in `Before'
-          Given this step works   # features/step_definitions/steps.rb:1
+          Given this step passes  # features/step_definitions/steps.rb:1
 
       Failing Scenarios:
       cucumber features/naughty_step_in_scenario.feature:3 # Scenario: Run a good step
@@ -50,29 +47,30 @@ Feature: Exception in Before Block
       Feature: Sample
 
         Background:
-          Given this step works
+          Given this step passes
 
         Scenario: Run a good step
-          Given this step works
+          Given this step passes
       """
-    When I run cucumber features
-    Then it should fail with
+    When I run `cucumber features`
+    Then it should fail with exactly:
       """
       Feature: Sample
       
-        Background:             # features/naughty_step_in_before.feature:3
+        Background:              # features/naughty_step_in_before.feature:3
         I cannot even start this scenario (SomeSetupException)
         ./features/support/env.rb:4:in `Before'
-          Given this step works # features/step_definitions/steps.rb:1
+          Given this step passes # features/step_definitions/steps.rb:1
       
         Scenario: Run a good step # features/naughty_step_in_before.feature:6
-          Given this step works   # features/step_definitions/steps.rb:1
+          Given this step passes  # features/step_definitions/steps.rb:1
 
       Failing Scenarios:
       cucumber features/naughty_step_in_before.feature:6 # Scenario: Run a good step
 
       1 scenario (1 failed)
-      2 steps (1 skipped, 1 passed)
+      2 steps (2 skipped)
+      0m0.012s
 
       """
 
@@ -82,10 +80,10 @@ Feature: Exception in Before Block
       Feature: Sample
 
         Scenario: Run a good step
-          Given this step works
+          Given this step passes
       """
-    When I run cucumber features --format progress
-    Then it should fail with
+    When I run `cucumber features --format progress`
+    Then it should fail with:
       """
       F-
 

data/features/docs/extending_cucumber/custom_filter.feature

@@ -0,0 +1,29 @@
+Feature: Custom filter
+
+  Scenario: Add a custom filter via AfterConfiguration hook
+    Given a file named "features/test.feature" with:
+      """
+      Feature:
+        Scenario:
+          Given my special step
+      """
+    And a file named "features/support/my_filter.rb" with:
+      """
+      require 'cucumber/core/filter'
+
+      MakeAnythingPass = Cucumber::Core::Filter.new do
+        def test_case(test_case)
+          activated_steps = test_case.test_steps.map do |test_step|
+            test_step.with_action { }
+          end
+          test_case.with_steps(activated_steps).describe_to receiver
+        end
+      end
+
+      AfterConfiguration do |config|
+        config.filters << MakeAnythingPass.new
+      end
+      """
+    When I run `cucumber --strict`
+    Then it should pass
+

data/features/docs/extending_cucumber/custom_formatter.feature

@@ -0,0 +1,94 @@
+Feature: Custom Formatter
+
+  Background:
+    Given a file named "features/f.feature" with:
+      """
+      Feature: I'll use my own
+        Scenario: Just print me
+          Given this step passes
+      """
+    And the standard step definitions
+
+  Scenario: Use the new API
+    Given a file named "features/support/custom_formatter.rb" with:
+      """
+      module MyCustom
+        class Formatter
+          def initialize(runtime, io, options)
+            @io = io
+          end
+
+          def before_test_case(test_case)
+            feature = test_case.source.first
+            scenario = test_case.source.last
+            @io.puts feature.short_name.upcase
+            @io.puts "  #{scenario.name.upcase}"
+          end
+        end
+      end
+      """
+    When I run `cucumber features/f.feature --format MyCustom::Formatter`
+    Then it should pass with exactly:
+      """
+      I'LL USE MY OWN
+        JUST PRINT ME
+
+      """
+
+  Scenario: Use the legacy API
+    Given a file named "features/support/custom_legacy_formatter.rb" with:
+      """
+      module MyCustom
+        class LegacyFormatter
+          def initialize(runtime, io, options)
+            @io = io
+          end
+
+          def before_feature(feature)
+            @io.puts feature.short_name.upcase
+          end
+
+          def scenario_name(keyword, name, file_colon_line, source_indent)
+            @io.puts "  #{name.upcase}"
+          end
+        end
+      end
+      """
+    When I run `cucumber features/f.feature --format MyCustom::LegacyFormatter`
+    Then it should pass with exactly:
+      """
+      I'LL USE MY OWN
+        JUST PRINT ME
+
+      """
+
+  Scenario: Use both
+    You can use a specific shim to opt-in to both APIs at once.
+
+    Given a file named "features/support/custom_mixed_formatter.rb" with:
+      """
+      module MyCustom
+        class MixedFormatter
+
+          def initialize(runtime, io, options)
+            @io = io
+          end
+
+          def before_test_case(test_case)
+            feature = test_case.source.first
+            @io.puts feature.short_name.upcase
+          end
+
+          def scenario_name(keyword, name, file_colon_line, source_indent)
+            @io.puts "  #{name.upcase}"
+          end
+        end
+      end
+      """
+    When I run `cucumber features/f.feature --format MyCustom::MixedFormatter`
+    Then it should pass with exactly:
+      """
+      I'LL USE MY OWN
+        JUST PRINT ME
+
+      """

data/features/docs/formatters/debug_formatter.feature

@@ -0,0 +1,47 @@
+Feature: Debug formatter
+
+  In order to help you easily visualise the listener API, you can use
+  the `debug` formatter that prints the calls to the listener as a
+  feature is run.
+
+  Background:
+    Given the standard step definitions
+
+  Scenario: title
+    Given a file named "features/test.feature" with:
+      """
+      Feature:
+        Scenario:
+          Given this step passes
+      """
+    When I run `cucumber -f debug`
+    Then the stderr should not contain anything
+    Then it should pass with:
+      """
+      before_test_case
+      before_features
+      before_feature
+      before_tags
+      after_tags
+      feature_name
+      before_test_step
+      after_test_step
+      before_test_step
+      before_feature_element
+      before_tags
+      after_tags
+      scenario_name
+      before_steps
+      before_step
+      before_step_result
+      step_name
+      after_step_result
+      after_step
+      after_test_step
+      after_steps
+      after_feature_element
+      after_test_case
+      after_feature
+      after_features
+      done
+      """

data/features/{formatter_step_file_colon_line.feature → docs/formatters/formatter_step_file_colon_line.feature}

@@ -13,15 +13,13 @@ Feature: Formatter API: Step file path and line number (Issue #179)
       """
     And a file named "features/step_definitions/steps.rb" with:
       """
-      Given /^step at line (.*)$/ do |line|
-      end
+      Given(/^step at line (.*)$/) {|line| }
       """
     And a file named "features/support/jb/formatter.rb" with:
       """
       module Jb
         class Formatter
-          def initialize(step_mother, io, options)
-            @step_mother = step_mother
+          def initialize(runtime, io, options)
             @io = io
           end
 

data/features/{html_formatter.feature → docs/formatters/html_formatter.feature}

@@ -1,13 +1,14 @@
 Feature: HTML output formatter
 
   Background:
-    Given a file named "features/scenario_outline_with_undefined_steps.feature" with:
+    Given the standard step definitions
+    And a file named "features/scenario_outline_with_undefined_steps.feature" with:
       """
       Feature:
 
         Scenario Outline:
-          Given an undefined step
-        
+          Given this step is undefined
+
         Examples:
           |foo|
           |bar|
@@ -17,7 +18,7 @@ Feature: HTML output formatter
       Feature: Outline
 
         Scenario Outline: Will it blend?
-          Given this hasn't been implemented yet
+          Given this step is pending
           And other step
           When I do something with <example>
           Then I should see something
@@ -32,21 +33,12 @@ Feature: HTML output formatter
       Feature: Feature with failing background step
 
         Background:
-          Given this fails
+          Given this step fails
 
         Scenario:
           When I do something
           Then I should see something
       """
-    And a file named "features/step_definitions/steps.rb" with:
-      """
-      Given /^this fails$/ do
-        fail 'This step should fail'
-      end
-      Given /^this hasn't been implemented yet$/ do
-        pending
-      end
-      """
 
   Scenario: an scenario outline, one undefined step, one random example, expand flag on
     When I run `cucumber features/scenario_outline_with_undefined_steps.feature --format html --expand `
@@ -63,10 +55,14 @@ Feature: HTML output formatter
     """
     makeRed('scenario_1')
     """
+
     Examples:
       | file                                                   | flag     |
       | features/scenario_outline_with_pending_step.feature    | --expand |
       | features/scenario_outline_with_pending_step.feature    |          |
+
+    Examples:
+      | file                                                   | flag     |
       | features/scenario_outline_with_undefined_steps.feature | --expand |
       | features/scenario_outline_with_undefined_steps.feature |          |