cucumber 0.3.0 → 0.3.1

data/examples/tickets/features/301/filter_background_tagged_hooks.feature

@@ -0,0 +1,6 @@
+Feature https://rspec.lighthouseapp.com/projects/16211/tickets/301
+  Background: A background
+    Given whatever
+    
+  Scenario: VB is not cool
+    Then VB should not be cool

data/examples/tickets/features/301/filter_background_tagged_hooks_steps.rb

@@ -0,0 +1,12 @@
+require 'spec/expectations'
+
+Before('@nothing_has_this_tag') do
+  @vb = :cool
+end
+
+Given /^whatever$/ do
+end
+
+Then /^VB should not be cool$/ do
+  @vb.should_not == :cool
+end

data/examples/tickets/features/306/only_background.feature

@@ -0,0 +1,4 @@
+Feature: woo yeah
+
+  Background:
+    Given passing step without a table

data/features/background.feature

@@ -72,6 +72,7 @@ Feature: backgrounds
     When I run cucumber -q features/background/failing_background.feature --require features
     Then it should fail with
     """
+    @after_file
     Feature: Failing background sample
 
       Background: 
@@ -79,7 +80,7 @@ Feature: backgrounds
           FAIL (RuntimeError)
           ./features/step_definitions/sample_steps.rb:2:in `flunker'
           ./features/step_definitions/sample_steps.rb:16:in `/^failing without a table$/'
-          features/background/failing_background.feature:4:in `Given failing without a table'
+          features/background/failing_background.feature:5:in `Given failing without a table'
         And '10' cukes
 
       Scenario: failing background

data/features/cucumber_cli.feature

@@ -191,6 +191,36 @@ Feature: Cucumber command line
           When I stop procrastinating
           And there is world peace
 
+      Feature: multiline
+
+        Background: I'm a multiline name
+          which goes on and on and on for three lines
+          yawn
+          Given passing without a table
+
+        Scenario: I'm a multiline name
+          which goes on and on and on for three lines
+          yawn
+          Given passing without a table
+
+        Scenario Outline: I'm a multiline name
+          which goes on and on and on for three lines
+          yawn
+          Given <state> without a table
+
+        Examples: 
+          | state   |
+          | passing |
+    
+        Scenario Outline: name
+          Given <state> without a table
+
+        Examples: I'm a multiline name
+          which goes on and on and on for three lines
+          yawn
+          | state   |
+          | passing |
+
       Feature: Outline Sample
 
         Scenario: I have no steps
@@ -229,6 +259,31 @@ Feature: Cucumber command line
             hello
             \"\"\"
 
+      Feature: search examples
+
+        Background: Hantu Pisang background match
+          Given passing without a table
+
+        Scenario: should match Hantu Pisang
+          Given passing without a table
+
+        Scenario: Ignore me
+          Given failing without a table
+
+        Scenario Outline: Ignore me
+          Given <state> without a table
+
+        Examples: 
+          | state   |
+          | failing |
+
+        Scenario Outline: Hantu Pisang match
+          Given <state> without a table
+
+        Examples: 
+          | state   |
+          | passing |
+
       Feature: undefined multiline args
       
         Scenario: pystring
@@ -242,8 +297,8 @@ Feature: Cucumber command line
             | table   |
             | example |
 
-      14 scenarios
-      12 skipped steps
+      21 scenarios
+      26 skipped steps
       9 undefined steps
 
       """
@@ -274,24 +329,45 @@ Feature: Cucumber command line
 
       """
 
-  Scenario: Run scenario specified by name using --scenario
-    When I run cucumber --scenario Passing -q features
+  Scenario: Run feature elements which matches a name using --name
+    When I run cucumber --name Pisang -q features/
     Then it should pass with
       """
-      @one
-      Feature: Sample
+      Feature: search examples
 
-        @three
-        Scenario: Passing
-          Given passing
-            | a | b |
-            | c | d |
+        Background: Hantu Pisang background match
+          Given passing without a table
 
-      1 scenario
+        Scenario: should match Hantu Pisang
+          Given passing without a table
+
+        Scenario Outline: Hantu Pisang match
+          Given <state> without a table
+
+        Examples: 
+          | state   |
+          | passing |
+
+      2 scenarios
+      4 passed steps
+
+      """
+
+  Scenario: Run a single background which matches a name using --name
+    When I run cucumber --name 'Hantu Pisang background' -q features/
+    Then it should pass with
+      """
+      Feature: search examples
+
+        Background: Hantu Pisang background match
+          Given passing without a table
+
+      0 scenarios
       1 passed step
 
       """
 
+
   Scenario: Run with a tag that exists on 2 scenarios
     When I run cucumber -q features --tags three
     Then it should pass with

data/features/cucumber_cli_outlines.feature

@@ -2,6 +2,38 @@ Feature: Cucumber command line
   In order to write better software
   Developers should be able to execute requirements as tests
 
+  Scenario: Run scenario outline with filtering on outline name
+    When I run cucumber -q features --name "Test state"
+    Then it should fail with
+      """
+      Feature: Outline Sample
+
+        Scenario Outline: Test state
+          Given <state> without a table
+          Given <other_state> without a table
+
+        Examples: Rainbow colours
+          | state   | other_state |
+          | missing | passing     |
+          | passing | passing     |
+          | failing | passing     |
+          FAIL (RuntimeError)
+          ./features/step_definitions/sample_steps.rb:2:in `flunker'
+          ./features/step_definitions/sample_steps.rb:16:in `/^failing without a table$/'
+          features/outline_sample.feature:6:in `Given <state> without a table'
+
+        Examples: Only passing
+          | state   | other_state |
+          | passing | passing     |
+
+      4 scenarios
+      1 failed step
+      2 skipped steps
+      1 undefined step
+      4 passed steps
+
+      """
+
   Scenario: Run scenario outline steps only
     When I run cucumber -q features/outline_sample.feature:7
     Then it should fail with

data/features/custom_formatter.feature

@@ -4,8 +4,8 @@ Feature: Custom Formatter
     When I run cucumber --format Tag::Count features
     Then it should fail with
       """
-      | four | lots | one | three | two |
-      | 1    | 1    | 1   | 2     | 1   |
+      | after_file | four | lots | one | three | two |
+      | 1          | 1    | 1    | 1   | 2     | 1   |
 
       """
     

data/features/multiline_names.feature

@@ -0,0 +1,43 @@
+Feature: Multiline description names
+  In order to accurately document feature elements
+  As a cucumberist
+  I want to have multiline names
+
+  Scenario: multiline scenario
+    When I run cucumber features/multiline_name.feature --no-snippets
+    Then it should pass with
+    """
+    Feature: multiline
+
+      Background: I'm a multiline name              # features/multiline_name.feature:3
+        which goes on and on and on for three lines
+        yawn
+        Given passing without a table               # features/step_definitions/sample_steps.rb:12
+
+      Scenario: I'm a multiline name                # features/multiline_name.feature:8
+        which goes on and on and on for three lines
+        yawn
+        Given passing without a table               # features/step_definitions/sample_steps.rb:12
+
+      Scenario Outline: I'm a multiline name        # features/multiline_name.feature:13
+        which goes on and on and on for three lines
+        yawn
+        Given <state> without a table               # features/step_definitions/sample_steps.rb:12
+
+      Examples: 
+        | state   |
+        | passing |
+
+      Scenario Outline: name          # features/multiline_name.feature:21
+        Given <state> without a table # features/step_definitions/sample_steps.rb:12
+
+      Examples: I'm a multiline name
+        which goes on and on and on for three lines
+        yawn
+        | state   |
+        | passing |
+
+    3 scenarios
+    6 passed steps
+
+    """

data/features/report_called_undefined_steps.feature

@@ -23,7 +23,7 @@ Feature: Cucumber command line
       2 scenarios
       2 undefined steps
 
-      You can implement step definitions for missing steps with these snippets:
+      You can implement step definitions for undefined steps with these snippets:
 
       Given /^this does not exist$/ do
         pending

data/features/usage.feature

@@ -9,18 +9,27 @@ Feature: Cucumber command line
       """
       /^passing without a table$/          # features/step_definitions/sample_steps.rb:12
        Given passing without a table       # features/background/failing_background_after_success.feature:4
+       Given passing without a table       # features/multiline_name.feature:6
+       Given passing without a table       # features/multiline_name.feature:11
+       Given <state> without a table       # features/multiline_name.feature:16
+       Given <state> without a table       # features/multiline_name.feature:22
        Given <state> without a table       # features/outline_sample.feature:6
        Given <other_state> without a table # features/outline_sample.feature:7
+       Given passing without a table       # features/search_sample.feature:4
+       Given passing without a table       # features/search_sample.feature:7
+       Given <state> without a table       # features/search_sample.feature:19
       /^failing without a table$/    # features/step_definitions/sample_steps.rb:15
-       Given failing without a table # features/background/failing_background.feature:4
+       Given failing without a table # features/background/failing_background.feature:5
        Given failing without a table # features/background/scenario_outline_failing_background.feature:4
+       Given failing without a table # features/search_sample.feature:10
+       Given <state> without a table # features/search_sample.feature:13
       /^a step definition that calls an undefined step$/    # features/step_definitions/sample_steps.rb:19
        Given a step definition that calls an undefined step # features/call_undefined_step_from_step_def.feature:4
       /^call step "(.*)"$/                                              # features/step_definitions/sample_steps.rb:23
        Given call step "a step definition that calls an undefined step" # features/call_undefined_step_from_step_def.feature:7
       /^'(.+)' cukes$/   # features/step_definitions/sample_steps.rb:27
        Given '10' cukes  # features/background/background_with_name.feature:4
-       And '10' cukes    # features/background/failing_background.feature:5
+       And '10' cukes    # features/background/failing_background.feature:6
        Given '10' cukes  # features/background/passing_background.feature:4
        Given '10' cukes  # features/background/scenario_outline_passing_background.feature:4
        Given '2' cukes   # features/tons_of_cukes.feature:4
@@ -74,8 +83,8 @@ Feature: Cucumber command line
        Given '2' cukes   # features/tons_of_cukes.feature:52
       /^I should have '(.+)' cukes$/      # features/step_definitions/sample_steps.rb:31
        Then I should have '10' cukes      # features/background/background_with_name.feature:7
-       Then I should have '10' cukes      # features/background/failing_background.feature:8
-       Then I should have '10' cukes      # features/background/failing_background.feature:11
+       Then I should have '10' cukes      # features/background/failing_background.feature:9
+       Then I should have '10' cukes      # features/background/failing_background.feature:12
        Then I should have '10' cukes      # features/background/passing_background.feature:7
        Then I should have '10' cukes      # features/background/passing_background.feature:10
        Then I should have '10' cukes      # features/background/pending_background.feature:7

data/lib/cucumber/ast/background.rb

@@ -4,12 +4,13 @@ module Cucumber
   module Ast
     class Background
       include FeatureElement
-      attr_writer :feature
+      attr_reader :feature_elements
 
       def initialize(comment, line, keyword, name, steps)
         @comment, @line, @keyword, @name, @steps = comment, line, keyword, name, StepCollection.new(steps)
         attach_steps(steps)
         @step_invocations = @steps.step_invocations(true)
+        @feature_elements = []
       end
 
       def step_collection(step_invocations)
@@ -23,32 +24,28 @@ module Cucumber
 
       def accept(visitor)
         visitor.visit_comment(@comment)
-        visitor.visit_background_name(@keyword, @name, file_colon_line(@line), source_indent(text_length))
-        visitor.step_mother.before(self)
+        visitor.visit_background_name(@keyword, @name, file_colon_line(@line), source_indent(first_line_length))
+        visitor.step_mother.before(hook_context)
         visitor.visit_steps(@step_invocations)
         @failed = @step_invocations.detect{|step_invocation| step_invocation.exception}
-        visitor.step_mother.after(self) if @failed
+        visitor.step_mother.after(hook_context) if @failed
       end
 
       def accept_hook?(hook)
-        # TODO: When background is involved - no tag based hook filtering is occurring with
-        # the current implementation. All hooks will be executed. This is because of the line
-        #   visitor.step_mother.before(self)
-        # in the #accept method above. Instead, we should really be passing the first scenario
-        # here. We currently don't have access to that, so a refactoring is in order to make that happen.
-        true
+        false
       end
 
       def failed?
         @failed
       end
 
-      def text_length
-        @keyword.jlength
+      def hook_context
+        @feature_elements.first || self
       end
 
       def to_sexp
         sexp = [:background, @line, @keyword]
+        sexp += [@name] unless @name.empty?
         comment = @comment.to_sexp
         sexp += [comment] if comment
         steps = @steps.to_sexp
@@ -57,4 +54,4 @@ module Cucumber
       end
     end
   end
-end
+end

data/lib/cucumber/ast/feature.rb

@@ -8,6 +8,7 @@ module Cucumber
       def initialize(background, comment, tags, name, feature_elements)
         @background, @comment, @tags, @name, @feature_elements = background, comment, tags, name, feature_elements
 
+        background.feature = self if background
         @feature_elements.each do |feature_element|
           feature_element.feature = self
         end
@@ -23,6 +24,10 @@ module Cucumber
         end
       end
 
+      def accept_hook?(hook)
+        @tags.accept_hook?(hook)
+      end
+
       def next_feature_element(feature_element, &proc)
         index = @feature_elements.index(feature_element)
         next_one = @feature_elements[index+1]

data/lib/cucumber/ast/feature_element.rb

@@ -1,5 +1,9 @@
+require 'enumerator'
+
 module Cucumber
   module FeatureElement
+    attr_writer :feature
+
     def attach_steps(steps)
       steps.each {|step| step.feature_element = self}
     end
@@ -9,13 +13,27 @@ module Cucumber
     end
 
     def text_length
-      @keyword.jlength + @name.jlength
+      name_line_lengths.max
+    end
+
+    def first_line_length
+      name_line_lengths[0]
     end
 
-    def matches_scenario_names?(scenario_names)
-      scenario_names.detect{|name| name == @name}
+    def name_line_lengths
+      if @name.empty?
+        [@keyword.jlength]
+      else
+        @name.split("\n").enum_for(:each_with_index).map do |line, line_number| 
+          line_number == 0 ? @keyword.jlength + line.jlength : line.jlength + Ast::Step::INDENT - 1 # We -1 as names which are not keyword lines are missing a space between keyword and name
+        end
+      end
     end
 
+    def matches_scenario_names?(scenario_name_regexps)
+      scenario_name_regexps.detect{|name| name =~ @name}
+    end 
+
     def backtrace_line(name = "#{@keyword} #{@name}", line = @line)
       @feature.backtrace_line(name, line) if @feature
     end
@@ -29,14 +47,7 @@ module Cucumber
     end
 
     def accept_hook?(hook)
-      @tags.accept_hook?(hook)
-    end
-
-    # TODO: Remove when we use StepCollection everywhere
-    def previous_step(step)
-      i = @steps.index(step) || -1
-      @steps[i-1]
+      @tags.accept_hook?(hook) || @feature.accept_hook?(hook)
     end
-    
   end
-end
+end