cucumber-wire 1.1.0 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 462ca912391ac19f173a610a18056c7c2dd3ddc42d6ab7b11aeaef6986d60201
-  data.tar.gz: ba3040346ba690ce5471b5af2e97b9a5e383001933684c79c553e9603f9fdd98
+  metadata.gz: 1e6165b86a29bd73dd89d8f0597e4b3c835162aa97aa1f67ab719e05baa55564
+  data.tar.gz: 607270d0f042c6460668ab59259ca1d8c845913be01594cea736bac6dc9b05d9
 SHA512:
-  metadata.gz: 620e604bec618f31fbb554079297f4c55f956e8bccad13deaa760c2ddbc902e8fb0371336584a3d8c122c4ccdf1298860a763865f1a1c319035bdc27d8805a0c
-  data.tar.gz: 6e3ff7030d0770fe50d3010db7a21e55811dc78c369de8725175680666738d642b93fba2354f9dd076233fa6f26ed1d1eb44d6ea46156124be696074ff7f9cd5
+  metadata.gz: a35c2406a29c41ff059dbe0922389c579ee714b6a29583a59c0d4c5b8a37d08ec5b43f841bc63fda0268dee9f585b20d432ad0817e517fc4503dd80bba0c4542
+  data.tar.gz: a723d908ffb86c75aff3f1b02d5376789099028e87ea70df158c53d7003f16d30930772f35b1a3ba6fb3a9a930a295d82ef845cba44efebc4ec7874e1ce15875

data/CHANGELOG.md

@@ -10,6 +10,47 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 
 ----
 
+## [3.1.0](https://github.com/cucumber/cucumber-ruby-wire/compare/v3.0.0...v3.1.0)
+
+### Changed
+
+* Updated gems:
+  * `cucumber-core` ~> 7.1.0
+  * `cucumber-messages` ~> 12.2.0
+
+## [3.0.0](https://github.com/cucumber/cucumber-ruby-wire/compare/v2.0.1...v3.0.0)
+
+### Changed
+
+* Use `cucumber-ruby-core` 7.0.0
+
+* Updated monorepo libraries:
+  * cucumber-cucumber-expressions ~> 10
+  * cucumber-messages ~> 12
+
+## [2.0.1](https://github.com/cucumber/cucumber-ruby-wire/compare/v2.0.0...v2.0.1)
+
+### Removed
+
+* Replace use of `MultiJSON` to use native JSON gem
+
+## [2.0.0](https://github.com/cucumber/cucumber-ruby-wire/compare/v1.2.0...v2.0.0)
+
+### Changed
+
+* Use `cucumber-ruby-core` 6.0.0
+
+## [1.2.0](https://github.com/cucumber/cucumber-ruby-wire/compare/v1.1.0...v1.2.0)
+
+### Removed
+
+* Multiline arguments do not need `Location` anymore
+
+### Added
+
+* Use `Cucumber:Messages::IdGenerator::UUID` to provide ids for `Hooks`
+
+
 ## [1.1.0](https://github.com/cucumber/cucumber-ruby-wire/compare/v1.0.0...v1.1.0)
 
 ### Changed

data/README.md

@@ -1,3 +1,41 @@
 [![Build Status](https://travis-ci.org/cucumber/cucumber-ruby-wire.svg?branch=master)](https://travis-ci.org/cucumber/cucumber-ruby-wire)
 
 # cucumber-wire
+
+This gem was extracted from the [cucumber gem](https://github.com/cucumber/cucumber-ruby), and remains a runtime dependency to that gem.
+
+Its tests are a bit hairy and prone to the occasional flicker.
+
+In the future, it may become an opt-in plugin rather than a direct dependency on every Cucumber.
+
+## Configuration
+
+You can configure the connection using a YAML file called a `.wire` file:
+
+```yaml
+host: localhost
+port: 54321
+timeout:
+  connect: 11
+  invoke: 120
+  begin_scenario: 120
+  end_scenario: 120
+```
+
+### Timeouts
+
+The default timeout is 120 seconds. `connect` has a default timeout of 11 seconds.
+
+### YAML with ERB templating
+
+The file format is YAML, with ERB templating, so you could make the configuration configurable:
+
+```yaml,erb
+host: localhost
+port: 54321
+timeout:
+  connect: <%= (ENV['MY_CONNECT_TIMEOUT'] || 11).to_i %>
+  invoke: 120
+  begin_scenario: 120
+  end_scenario: 120
+```

data/lib/cucumber/wire/add_hooks_filter.rb

@@ -1,4 +1,6 @@
 # coding: utf-8
+require 'cucumber/messages'
+
 module Cucumber
   module Wire
     class AddHooksFilter < Core::Filter.new(:connections)
@@ -11,16 +13,20 @@ module Cucumber
       def before_hook(test_case)
         # TODO: is this dependency on Cucumber::Hooks OK? Feels a bit internal..
         # TODO: how do we express the location of the hook? Should we create one hook per connection so we can use the host:port of the connection?
-        Cucumber::Hooks.before_hook(Core::Test::Location.new('TODO:wire')) do
+        Cucumber::Hooks.before_hook(id_generator.new_id, Core::Test::Location.new('TODO:wire')) do
           connections.begin_scenario(test_case)
         end
       end
 
       def after_hook(test_case)
-        Cucumber::Hooks.after_hook(Core::Test::Location.new('TODO:wire')) do
+        Cucumber::Hooks.after_hook(id_generator.new_id, Core::Test::Location.new('TODO:wire')) do
           connections.end_scenario(test_case)
         end
       end
+
+      def id_generator
+        @id_generator ||= Cucumber::Messages::IdGenerator::UUID.new
+      end
     end
   end
 end

data/lib/cucumber/wire/connections.rb

@@ -1,4 +1,4 @@
-require 'multi_json'
+require 'json'
 require 'socket'
 require 'cucumber/wire/connection'
 require 'cucumber/wire/configuration'

data/lib/cucumber/wire/data_packet.rb

@@ -1,4 +1,4 @@
-require 'multi_json'
+require 'json'
 
 module Cucumber
   module Wire
@@ -7,7 +7,7 @@ module Cucumber
     class DataPacket
       class << self
         def parse(raw)
-          attributes = MultiJson.load(raw.strip)
+          attributes = JSON.parse(raw.strip)
           message = attributes[0]
           params  = attributes[1]
           new(message, params)
@@ -23,7 +23,7 @@ module Cucumber
       def to_json
         packet = [@message]
         packet << @params if @params
-        MultiJson.dump(packet)
+        JSON.generate(packet)
       end
 
       def handle_with(handler)

data/lib/cucumber/wire/protocol/requests.rb

@@ -69,10 +69,8 @@ module Cucumber
           end
 
           def handle_diff!(tables)
-            # TODO: figure out if / how we could get a location for a table from the wire (or make a null location)
-            location = Core::Test::Location.new(__FILE__, __LINE__)
-            table1 = table(tables[0], location)
-            table2 = table(tables[1], location)
+            table1 = table(tables[0])
+            table2 = table(tables[1])
             table1.diff!(table2)
           end
 
@@ -89,8 +87,8 @@ module Cucumber
 
           private
 
-          def table(data, location)
-            Cucumber::MultilineArgument.from_core(Core::Test::DataTable.new(data, location))
+          def table(data)
+            Cucumber::MultilineArgument.from_core(Core::Test::DataTable.new(data))
           end
         end
 

data/lib/cucumber/wire/version

@@ -1 +1 @@
-1.1.0
+3.1.0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-wire
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 3.1.0
 platform: ruby
 authors:
 - Matt Wynne
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-10-31 00:00:00.000000000 Z
+date: 2020-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -16,60 +16,80 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 7.1.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '7.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 7.1.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '7.1'
 - !ruby/object:Gem::Dependency
-  name: cucumber-expressions
+  name: cucumber-cucumber-expressions
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '8.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 8.0.2
+        version: 10.1.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 10.1.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '8.0'
+        version: '10.1'
+- !ruby/object:Gem::Dependency
+  name: cucumber-messages
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 8.0.2
+        version: 12.2.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 12.2.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.2'
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.1.2
+        version: 4.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.1.2
+        version: 4.0.1
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -164,7 +184,7 @@ homepage: http://cucumber.io
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--charset=UTF-8"
 require_paths:
@@ -180,10 +200,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.0.6
+signing_key:
 specification_version: 4
-summary: cucumber-wire-1.1.0
+summary: cucumber-wire-3.1.0
 test_files:
 - spec/cucumber/wire/data_packet_spec.rb
 - spec/cucumber/wire/configuration_spec.rb