cucumber-wire 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 462ca912391ac19f173a610a18056c7c2dd3ddc42d6ab7b11aeaef6986d60201
-  data.tar.gz: ba3040346ba690ce5471b5af2e97b9a5e383001933684c79c553e9603f9fdd98
+  metadata.gz: 180f3b85cce4bc115f12c42c35cfc1ae9ddf2d046e9359a168dda59c81f38ac8
+  data.tar.gz: b8740378f12e070524613710ca82b2832aca2ad911c377d1a85b0510021fa8ac
 SHA512:
-  metadata.gz: 620e604bec618f31fbb554079297f4c55f956e8bccad13deaa760c2ddbc902e8fb0371336584a3d8c122c4ccdf1298860a763865f1a1c319035bdc27d8805a0c
-  data.tar.gz: 6e3ff7030d0770fe50d3010db7a21e55811dc78c369de8725175680666738d642b93fba2354f9dd076233fa6f26ed1d1eb44d6ea46156124be696074ff7f9cd5
+  metadata.gz: 8e00f2465851ea1247d40b33893074df9949d303cedc4e6581622db8803382ed16aa447bd1dbc0fba03b9af8ce6b436a1b44f88a1ebf9178ff57849dfb792d5f
+  data.tar.gz: f33ee829c0297fa4dff553387370d8b4b431a70e7782a0d55e82890521ae2cea1bae53f21d36c145eed08ad247ab82e88d2cfa4def7df6f352951c314d1edb68

data/CHANGELOG.md

@@ -10,6 +10,17 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 
 ----
 
+## [1.2.0](https://github.com/cucumber/cucumber-ruby-wire/compare/v1.1.0...v1.2.0)
+
+### Removed
+
+* Multiline arguments do not need `Location` anymore
+
+### Added
+
+* Use `Cucumber:Messages::IdGenerator::UUID` to provide ids for `Hooks
+
+
 ## [1.1.0](https://github.com/cucumber/cucumber-ruby-wire/compare/v1.0.0...v1.1.0)
 
 ### Changed

data/README.md

@@ -1,3 +1,41 @@
 [![Build Status](https://travis-ci.org/cucumber/cucumber-ruby-wire.svg?branch=master)](https://travis-ci.org/cucumber/cucumber-ruby-wire)
 
 # cucumber-wire
+
+This gem was extracted from the [cucumber gem](https://github.com/cucumber/cucumber-ruby), and remains a runtime dependency to that gem.
+
+Its tests are a bit hairy and prone to the occasional flicker.
+
+In the future, it may become an opt-in plugin rather than a direct dependency on every Cucumber.
+
+## Configuration
+
+You can configure the connection using a YAML file called a `.wire` file:
+
+```yaml
+host: localhost
+port: 54321
+timeout:
+  connect: 11
+  invoke: 120
+  begin_scenario: 120
+  end_scenario: 120
+```
+
+### Timeouts
+
+The default timeout is 120 seconds. `connect` has a default timeout of 11 seconds.
+
+### YAML with ERB templating
+
+The file format is YAML, with ERB templating, so you could make the configuration configurable:
+
+```yaml,erb
+host: localhost
+port: 54321
+timeout:
+  connect: <%= (ENV['MY_CONNECT_TIMEOUT'] || 11).to_i %>
+  invoke: 120
+  begin_scenario: 120
+  end_scenario: 120
+```

data/lib/cucumber/wire/add_hooks_filter.rb

@@ -1,4 +1,6 @@
 # coding: utf-8
+require 'cucumber/messages'
+
 module Cucumber
   module Wire
     class AddHooksFilter < Core::Filter.new(:connections)
@@ -11,16 +13,20 @@ module Cucumber
       def before_hook(test_case)
         # TODO: is this dependency on Cucumber::Hooks OK? Feels a bit internal..
         # TODO: how do we express the location of the hook? Should we create one hook per connection so we can use the host:port of the connection?
-        Cucumber::Hooks.before_hook(Core::Test::Location.new('TODO:wire')) do
+        Cucumber::Hooks.before_hook(id_generator.new_id, Core::Test::Location.new('TODO:wire')) do
           connections.begin_scenario(test_case)
         end
       end
 
       def after_hook(test_case)
-        Cucumber::Hooks.after_hook(Core::Test::Location.new('TODO:wire')) do
+        Cucumber::Hooks.after_hook(id_generator.new_id, Core::Test::Location.new('TODO:wire')) do
           connections.end_scenario(test_case)
         end
       end
+
+      def id_generator
+        @id_generator ||= Cucumber::Messages::IdGenerator::UUID.new
+      end
     end
   end
 end

data/lib/cucumber/wire/protocol/requests.rb

@@ -69,10 +69,8 @@ module Cucumber
           end
 
           def handle_diff!(tables)
-            # TODO: figure out if / how we could get a location for a table from the wire (or make a null location)
-            location = Core::Test::Location.new(__FILE__, __LINE__)
-            table1 = table(tables[0], location)
-            table2 = table(tables[1], location)
+            table1 = table(tables[0])
+            table2 = table(tables[1])
             table1.diff!(table2)
           end
 
@@ -89,8 +87,8 @@ module Cucumber
 
           private
 
-          def table(data, location)
-            Cucumber::MultilineArgument.from_core(Core::Test::DataTable.new(data, location))
+          def table(data)
+            Cucumber::MultilineArgument.from_core(Core::Test::DataTable.new(data))
           end
         end
 

data/lib/cucumber/wire/version

@@ -1 +1 @@
-1.1.0
+1.2.0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-wire
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Matt Wynne
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-31 00:00:00.000000000 Z
+date: 2020-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -180,10 +180,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
-summary: cucumber-wire-1.1.0
+summary: cucumber-wire-1.2.0
 test_files:
 - spec/cucumber/wire/data_packet_spec.rb
 - spec/cucumber/wire/configuration_spec.rb