cucumber-rails 1.7.0 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: b276ab8f9a0ebd797f290786e0afced74033c0f4
-  data.tar.gz: 80af0b6ba3e16d29cfcd93e9f8f82c0e1e01217b
+SHA256:
+  metadata.gz: 4583ae621b7346d537d3ab6e4e66da4f39b99c04e5403aab0d94a60fa9e20142
+  data.tar.gz: 832a66009f3801b9a1efb43d7a83a853076465afbbcaf2b44fbc2b25514fae75
 SHA512:
-  metadata.gz: 493e90cf574a3785e83982e0dffcc6cc998c3e9f1ceac1ace13446bb033222a26b439376780238d3897eb34d4cfebf77fd06b5232b691d3538eeb8e7577a4338
-  data.tar.gz: 3caca7b73bbdfeb694ac0812ff0d2a7503cfe98b09589dd056ad101addeaa0f2971cb6c4086fb4f31ea6685c92ffd2d157a1825489e487b547d569225c497148
+  metadata.gz: ab69574710466da0405aa96555ade3c78a5013f29181534908bdfd6fc92157fe9410fc65228920a90cdfc1862079573754aa63beaeff53229fa2574b6f3a09a8
+  data.tar.gz: 31f270978a478b0ca111271417f19325b60e7d1f6823abddc62598ae0fabcfc9c93dfc494775d7c8451e08b2dc9c3b4e9f296148552b766272dc99793487df6b

data/.gitignore

@@ -11,3 +11,4 @@ gemfiles/*.lock
 Gemfile.lock
 spec/examples.txt
 .idea
+.ruby-version

data/.rubocop.yml

@@ -1 +1,36 @@
 inherit_from: .rubocop_todo.yml
+
+require:
+  - rubocop-rspec
+  - rubocop-performance
+
+AllCops:
+  TargetRubyVersion: 2.3
+  Exclude:
+    # This file is something which we aren't advising people to use
+    # Probably need to consider deleting this fully at some point
+    - 'features/support/legacy_web_steps_support.rb'
+    # These are auto-generated from a load of features that we
+    # don't have direct control over
+    - 'tmp/**/*'
+    # Generated by appraisal
+    - 'gemfiles/*.gemfile'
+
+Style/Documentation:
+  Enabled: false
+
+Metrics/LineLength:
+  Max: 200
+  IgnoredPatterns:
+    - '^Given'
+    - '^When'
+    - '^Then'
+
+Style/RegexpLiteral:
+  EnforcedStyle: slashes
+  AllowInnerSlashes: true
+
+BlockLength:
+  Exclude:
+    - './spec/**/*_spec.rb'
+    - 'cucumber-rails.gemspec'

data/.rubocop_todo.yml

@@ -1,443 +1,59 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-04-17 11:50:08 +0200 using RuboCop version 0.65.0.
+# on 2019-07-31 11:34:26 +0200 using RuboCop version 0.72.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 9
-# Cop supports --auto-correct.
-# Configuration parameters: TreatCommentsAsGroupSeparators, Include.
-# Include: **/*.gemfile, **/Gemfile, **/gems.rb
-Bundler/OrderedGems:
-  Exclude:
-    - 'gemfiles/rails_4_2.gemfile'
-    - 'gemfiles/rails_5_0.gemfile'
-    - 'gemfiles/rails_5_1.gemfile'
-    - 'gemfiles/rails_5_2.gemfile'
-    - 'gemfiles/rails_6_0.gemfile'
-
 # Offense count: 1
-# Configuration parameters: Include.
-# Include: **/*.gemspec
-Gemspec/DuplicatedAssignment:
-  Exclude:
-    - 'cucumber-rails.gemspec'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: TreatCommentsAsGroupSeparators, Include.
-# Include: **/*.gemspec
-Gemspec/OrderedDependencies:
-  Exclude:
-    - 'cucumber-rails.gemspec'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: outdent, indent
-Layout/AccessModifierIndentation:
-  Exclude:
-    - 'lib/cucumber/rails/database.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleAlignWith.
-# SupportedStylesAlignWith: either, start_of_block, start_of_line
-Layout/BlockAlignment:
-  Exclude:
-    - 'features/support/env.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/ClosingHeredocIndentation:
-  Exclude:
-    - 'features/support/legacy_web_steps_support.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-Layout/EmptyLineAfterGuardClause:
-  Exclude:
-    - 'Rakefile'
-    - 'dev_tasks/yard.rake'
-    - 'lib/cucumber/rails/database.rb'
-    - 'lib/generators/cucumber/install/install_generator.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-Layout/EmptyLineAfterMagicComment:
-  Exclude:
-    - 'Rakefile'
-    - 'cucumber-rails.gemspec'
-    - 'spec/cucumber/rails/database_spec.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, no_empty_lines
-Layout/EmptyLinesAroundBlockBody:
-  Exclude:
-    - 'spec/cucumber/rails/database_spec.rb'
-    - 'spec/generators/cucumber/install/install_generator_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/EmptyLinesAroundExceptionHandlingKeywords:
-  Exclude:
-    - 'lib/cucumber/rails/hooks/database_cleaner.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
-Layout/ExtraSpacing:
-  Exclude:
-    - 'lib/cucumber/rails/database.rb'
-    - 'spec/generators/cucumber/install/install_generator_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
-Layout/IndentHeredoc:
-  Exclude:
-    - 'features/support/legacy_web_steps_support.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: Width, IgnoredPatterns.
-Layout/IndentationWidth:
-  Exclude:
-    - 'features/support/env.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: aligned, indented
-Layout/MultilineOperationIndentation:
-  Exclude:
-    - 'features/support/env.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Layout/SpaceAroundKeyword:
-  Exclude:
-    - 'features/step_definitions/cucumber_rails_steps.rb'
-    - 'features/support/env.rb'
-
-# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment.
 Layout/SpaceAroundOperators:
   Exclude:
     - 'dev_tasks/yard.rake'
-    - 'lib/cucumber/rails/database.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
-# SupportedStyles: space, no_space
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceBeforeBlockBraces:
-  Exclude:
-    - 'lib/cucumber/rails.rb'
-    - 'lib/cucumber/rails/database.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/SpaceBeforeComma:
-  Exclude:
-    - 'features/step_definitions/cucumber_rails_steps.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Layout/SpaceInsidePercentLiteralDelimiters:
-  Exclude:
-    - 'lib/cucumber/rails/database.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: space, no_space
-Layout/SpaceInsideStringInterpolation:
-  Exclude:
-    - 'lib/cucumber/rails/database.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: AllowInHeredoc.
-Layout/TrailingWhitespace:
-  Exclude:
-    - 'features/step_definitions/cucumber_rails_steps.rb'
-    - 'features/support/env.rb'
-
-# Offense count: 10
-Lint/AmbiguousRegexpLiteral:
-  Exclude:
-    - 'features/step_definitions/cucumber_rails_steps.rb'
 
 # Offense count: 2
+# Configuration parameters: AllowComments.
 Lint/HandleExceptions:
   Exclude:
     - 'lib/cucumber/rails/hooks/database_cleaner.rb'
     - 'lib/cucumber/rails/world.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Lint/ScriptPermission:
-  Exclude:
-    - 'lib/generators/cucumber/install/templates/script/cucumber'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
-Lint/UnusedBlockArgument:
-  Exclude:
-    - 'Rakefile'
-
 # Offense count: 3
-Lint/UselessAssignment:
-  Exclude:
-    - 'lib/cucumber/rails/hooks/database_cleaner.rb'
-    - 'lib/cucumber/rails/rspec.rb'
-    - 'lib/cucumber/rails/world.rb'
-
-# Offense count: 4
 Metrics/AbcSize:
-  Max: 23
-
-# Offense count: 4
-# Configuration parameters: CountComments, ExcludedMethods.
-# ExcludedMethods: refine
-Metrics/BlockLength:
-  Max: 36
+  Max: 19
 
-# Offense count: 4
+# Offense count: 3
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
-  Max: 188
-
-# Offense count: 1
-# Configuration parameters: CountComments.
-Metrics/ModuleLength:
-  Max: 209
-
-# Offense count: 1
-Metrics/PerceivedComplexity:
-  Max: 8
-
-# Offense count: 2
-# Configuration parameters: Blacklist.
-# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
-Naming/HeredocDelimiterNaming:
-  Exclude:
-    - 'features/support/legacy_web_steps_support.rb'
-
-# Offense count: 1
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: snake_case, normalcase, non_integer
-Naming/VariableNumber:
-  Exclude:
-    - 'lib/cucumber/rails/rspec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Performance/Casecmp:
-  Exclude:
-    - 'lib/cucumber/rails/capybara/javascript_emulation.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect.
-Performance/StartWith:
-  Exclude:
-    - 'features/step_definitions/cucumber_rails_steps.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, conditionals
-Style/AndOr:
-  Exclude:
-    - 'lib/cucumber/rails/capybara/javascript_emulation.rb'
+  Max: 18
 
 # Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle.
-# SupportedStyles: nested, compact
-Style/ClassAndModuleChildren:
-  Exclude:
-    - 'lib/cucumber/rails/action_controller.rb'
-    - 'lib/cucumber/rails/application.rb'
-    - 'lib/cucumber/rails/capybara/javascript_emulation.rb'
-    - 'lib/cucumber/rails/hooks/active_record.rb'
-
-# Offense count: 1
-Style/CommentedKeyword:
-  Exclude:
-    - 'lib/cucumber/rails/world.rb'
+# Configuration parameters: .
+# SupportedStyles: have_received, receive
+RSpec/MessageSpies:
+  EnforcedStyle: receive
 
-# Offense count: 14
-Style/Documentation:
-  Exclude:
-    - 'spec/**/*'
-    - 'test/**/*'
-    - 'features/step_definitions/cucumber_rails_steps.rb'
-    - 'features/support/bundler_pre_support.rb'
-    - 'features/support/env.rb'
-    - 'features/support/legacy_web_steps_support.rb'
-    - 'lib/cucumber/rails/action_controller.rb'
-    - 'lib/cucumber/rails/capybara/javascript_emulation.rb'
-    - 'lib/cucumber/rails/database.rb'
-    - 'lib/cucumber/rails/hooks/active_record.rb'
-    - 'lib/generators/cucumber/install/install_generator.rb'
+# Offense count: 2
+# Configuration parameters: AggregateFailuresByDefault.
+RSpec/MultipleExpectations:
+  Max: 2
 
 # Offense count: 1
 Style/DoubleNegation:
   Exclude:
     - 'lib/cucumber/rails/action_controller.rb'
 
-# Offense count: 3
-# Cop supports --auto-correct.
-Style/Encoding:
-  Exclude:
-    - 'Rakefile'
-    - 'cucumber-rails.gemspec'
-    - 'spec/cucumber/rails/database_spec.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-Style/ExpandPathArguments:
-  Exclude:
-    - 'cucumber-rails.gemspec'
-    - 'lib/generators/cucumber/install/install_generator.rb'
-    - 'spec/generators/cucumber/install/install_generator_spec.rb'
-
-# Offense count: 1
-# Configuration parameters: .
-# SupportedStyles: annotated, template, unannotated
-Style/FormatStringToken:
-  EnforcedStyle: template
-
-# Offense count: 3
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
-  Exclude:
-    - 'features/step_definitions/cucumber_rails_steps.rb'
-    - 'lib/cucumber/rails/database.rb'
-    - 'lib/generators/cucumber/install/install_generator.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-Style/IfUnlessModifier:
-  Exclude:
-    - 'Rakefile'
-    - 'dev_tasks/yard.rake'
-    - 'features/step_definitions/cucumber_rails_steps.rb'
-    - 'lib/cucumber/rails/database.rb'
-
 # Offense count: 1
 Style/MixinUsage:
   Exclude:
     - 'lib/cucumber/rails/rspec.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: literals, strict
-Style/MutableConstant:
-  Exclude:
-    - 'lib/cucumber/rails/database.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: Whitelist.
-# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
-Style/NestedParenthesizedCalls:
-  Exclude:
-    - 'lib/cucumber/rails/capybara/select_dates_and_times.rb'
-
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedOctalStyle.
 # SupportedOctalStyles: zero_with_o, zero_only
 Style/NumericLiteralPrefix:
   Exclude:
-    - 'lib/generators/cucumber/install/install_generator.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredDelimiters.
-Style/PercentLiteralDelimiters:
-  Exclude:
-    - 'lib/cucumber/rails/database.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-Style/RedundantSelf:
-  Exclude:
-    - 'lib/cucumber/rails/capybara/javascript_emulation.rb'
-    - 'lib/cucumber/rails/hooks/active_record.rb'
-    - 'spec/spec_helper.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
-  Exclude:
-    - 'lib/cucumber/rails.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowIfMethodIsEmpty.
-Style/SingleLineMethods:
-  Exclude:
-    - 'lib/cucumber/rails/world.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: use_perl_names, use_english_names
-Style/SpecialGlobalVars:
-  Exclude:
-    - 'Rakefile'
-    - 'features/support/env.rb'
-
-# Offense count: 90
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiterals:
-  Exclude:
-    - 'Appraisals'
-    - 'Gemfile'
-    - 'Rakefile'
-    - 'cucumber-rails.gemspec'
-    - 'dev_tasks/yard.rake'
-    - 'features/step_definitions/cucumber_rails_steps.rb'
-    - 'gemfiles/rails_4_2.gemfile'
-    - 'gemfiles/rails_5_0.gemfile'
-    - 'gemfiles/rails_5_1.gemfile'
-    - 'gemfiles/rails_5_2.gemfile'
-    - 'gemfiles/rails_6_0.gemfile'
-    - 'spec/spec_helper.rb'
-
-# Offense count: 11
-# Cop supports --auto-correct.
-# Configuration parameters: MinSize.
-# SupportedStyles: percent, brackets
-Style/SymbolArray:
-  EnforcedStyle: brackets
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/UnneededInterpolation:
-  Exclude:
-    - 'features/step_definitions/cucumber_rails_steps.rb'
-
-# Offense count: 51
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 254
+    - 'lib/generators/cucumber/install_generator.rb'