cucumber-rails 1.7.0 → 1.8.0

data/.travis.yml

@@ -1,5 +1,8 @@
+language: ruby
+
+dist: xenial
+
 rvm:
-  - 2.2
   - 2.3
   - 2.4
   - 2.5
@@ -9,11 +12,13 @@ rvm:
 addons:
   firefox: latest
 
-# whitelist
 branches:
   only:
     - master
 
+services:
+  - xvfb
+
 gemfile:
   - gemfiles/rails_6_0.gemfile
   - gemfiles/rails_5_2.gemfile
@@ -26,20 +31,30 @@ matrix:
   allow_failures:
     - rvm: ruby-head
   exclude:
-    - rvm: 2.2
-      gemfile: gemfiles/rails_6_0.gemfile
+  # Only test Rails6 on supported rubies
+  # Don't test lowest rails support on maintained rubies
     - rvm: 2.3
       gemfile: gemfiles/rails_6_0.gemfile
-    - rvm: 2.4
-      gemfile: gemfiles/rails_6_0.gemfile
     - rvm: 2.4
       gemfile: gemfiles/rails_4_2.gemfile
+    - rvm: 2.4
+      gemfile: gemfiles/rails_6_0.gemfile
     - rvm: 2.5
       gemfile: gemfiles/rails_4_2.gemfile
+    - rvm: 2.6
+      gemfile: gemfiles/rails_4_2.gemfile
+    - rvm: 2.6
+      gemfile: gemfiles/rails_5_0.gemfile
+    - rvm: 2.6
+      gemfile: gemfiles/rails_5_1.gemfile
+    - rvm: ruby-head
+      gemfile: gemfiles/rails_4_2.gemfile
+    - rvm: ruby-head
+      gemfile: gemfiles/rails_5_0.gemfile
+    - rvm: ruby-head
+      gemfile: gemfiles/rails_5_1.gemfile
 
 before_install:
   - gem install --remote bundler -v '~> 1.17'
   - bin/install_geckodriver.sh
   - bin/install_webpacker.sh
-
-before_script: geckodriver -V

data/Appraisals

@@ -1,32 +1,35 @@
-appraise "rails_4_2" do
-  gem "railties", "~> 4.2.1"
-  gem "i18n", "< 1.5.1", platform: :mri_22
-  gem "capybara", "< 3.16.0", platform: [:mri_23, :mri_22]
-  gem "nokogiri", "< 1.9.1", platform: [:mri_23, :mri_22]
+# frozen_string_literal: true
+
+appraise 'rails_4_2' do
+  gem 'capybara', '< 3.16.0', platform: :mri_23
+  gem 'nokogiri', '< 1.9.1', platform: :mri_23
+  gem 'railties', '~> 4.2.11'
+  gem 'sqlite3', '~> 1.3.13'
 end
 
-appraise "rails_5_0" do
-  gem "railties", "~> 5.0.0"
-  gem "i18n", "< 1.5.1", platform: :mri_22
-  gem "capybara", "< 3.16.0", platform: [:mri_23, :mri_22]
-	gem "nokogiri", "< 1.9.1", platform: [:mri_23, :mri_22]
+appraise 'rails_5_0' do
+  gem 'capybara', '< 3.16.0', platform: :mri_23
+  gem 'nokogiri', '< 1.9.1', platform: :mri_23
+  gem 'railties', '~> 5.0.7'
+  gem 'sqlite3', '~> 1.3.13'
 end
 
-appraise "rails_5_1" do
-  gem "railties", "~> 5.1.0"
-  gem "i18n", "< 1.5.1", platform: :mri_22
-  gem "capybara", "< 3.16.0", platform: [:mri_23, :mri_22]
-  gem "nokogiri", "< 1.9.1", platform: [:mri_23, :mri_22]
+appraise 'rails_5_1' do
+  gem 'capybara', '< 3.16.0', platform: :mri_23
+  gem 'nokogiri', '< 1.9.1', platform: :mri_23
+  gem 'railties', '~> 5.1.0'
+  gem 'sqlite3', '~> 1.3.13'
 end
 
-appraise "rails_5_2" do
-  gem "railties", "~> 5.2"
-  gem "i18n", "< 1.5.1", platform: :mri_22
-  gem "capybara", "< 3.16.0", platform: [:mri_23, :mri_22]
-  gem "nokogiri", "< 1.9.1", platform: [:mri_23, :mri_22]
+appraise 'rails_5_2' do
+  gem 'capybara', '< 3.16.0', platform: :mri_23
+  gem 'nokogiri', '< 1.9.1', platform: :mri_23
+  gem 'railties', '~> 5.2.3'
+  gem 'sqlite3', '~> 1.3.13'
 end
 
-appraise "rails_6_0" do
-  gem "railties", "~> 6.0.0.beta1"
-  gem "rails",    "~> 6.0.0.beta1"
+appraise 'rails_6_0' do
+  gem 'railties', '~> 6.0.0.rc2'
+  gem 'rails',    '~> 6.0.0.rc2'
+  gem 'sqlite3', '~> 1.4'
 end

data/CHANGELOG.md

@@ -1,34 +1,80 @@
 Please see [CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CONTRIBUTING.md) on how to contribute to Cucumber.
 
-## [master](https://github.com/cucumber/cucumber-rails/compare/v1.6.0...master) (Not yet released)
-There are currently no unreleased changes.
+## [master](https://github.com/cucumber/cucumber-rails/compare/v1.8.0...master) (Not yet released)
 
+### Changed
+
+ * 
+   
+### Fixed
+
+ * 
+
+## [v1.8.0](https://github.com/cucumber/cucumber-rails/compare/v1.7.0..v1.8.0) (2019-08-06)
+
+### Changed
+
+ * Drop Ruby 2.2 support (target 2.3 and up) ([#424](https://github.com/cucumber/cucumber-rails/pull/424) [mvz])
+ 
+ * Begin to update the core runtime / development dependencies to something a little more recent
+   ([#413](https://github.com/cucumber/cucumber-rails/pull/413) /
+   [#431](https://github.com/cucumber/cucumber-rails/pull/431) /
+   [#432](https://github.com/cucumber/cucumber-rails/pull/432)
+   [mvz] / 
+   [luke-hill])
+   
+### Fixed
+
+ * Various rubocop / styling issues that had built up over time
+  ([#414](https://github.com/cucumber/cucumber-rails/pull/414) /
+  [#416](https://github.com/cucumber/cucumber-rails/pull/416) /
+  [#419](https://github.com/cucumber/cucumber-rails/pull/419) /
+  [#420](https://github.com/cucumber/cucumber-rails/pull/420) /
+  [#421](https://github.com/cucumber/cucumber-rails/pull/421) /
+  [#421](https://github.com/cucumber/cucumber-rails/pull/434)
+  [luke-hill] /
+  [mvz])
+  
+ * Generic Travis Healthcheck (Fixed up polluted logs and use newer Ubuntu OS)
+  ([#415](https://github.com/cucumber/cucumber-rails/pull/415) /
+  [#417](https://github.com/cucumber/cucumber-rails/pull/417)
+  [luke-hill])
+  
+ * Rails6 not building correctly
+  ([#418](https://github.com/cucumber/cucumber-rails/pull/418)
+  [luke-hill])
+  
+ * Provisional Ruby 2.7 builds not working
+  ([#427](https://github.com/cucumber/cucumber-rails/pull/427)
+  [amatsuda] /
+  [luke-hill])
+ 
 ## [v1.7.0](https://github.com/cucumber/cucumber-rails/compare/v1.6.0...v1.7.0) (2019-04-17)
 
 ### Changed
 
- * Drop rails `4.0` / `4.1` support ([#392](https://github.com/cucumber/cucumber-rails/pull/392) [deivid-rodriguez](https://github.com/deivid-rodriguez))
- * Allow Ruby `2.6` users to `ERB.new` ([#399](https://github.com/cucumber/cucumber-rails/pull/399) [koic](https://github.com/koic))
- * Allow Rails to be used in the `6.x` series (Currently as of release only beta1 is supported) ([#405](https://github.com/cucumber/cucumber-rails/pull/405) [kotovalexarian](https://github.com/kotovalexarian))
- * Update CI to test most relevant Rubies ([#411](https://github.com/cucumber/cucumber-rails/pull/411) [olleolleolle](https://github.com/olleolleolle))
+ * Drop rails `4.0` / `4.1` support ([#392](https://github.com/cucumber/cucumber-rails/pull/392) [deivid-rodriguez])
+ * Allow Ruby `2.6` users to `ERB.new` ([#399](https://github.com/cucumber/cucumber-rails/pull/399) [koic])
+ * Allow Rails to be used in the `6.x` series (Currently as of release only beta1 is supported) ([#405](https://github.com/cucumber/cucumber-rails/pull/405) [kotovalexarian])
+ * Update CI to test most relevant Rubies ([#411](https://github.com/cucumber/cucumber-rails/pull/411) [olleolleolle])
 
 ### Fixed
 
  * Appraisals fixes (Up-to-date `geckodriver`, standardised the various `.gemfile`s)
- [#389](https://github.com/cucumber/cucumber-rails/pull/389) /
+ ([#389](https://github.com/cucumber/cucumber-rails/pull/389) /
  [#394](https://github.com/cucumber/cucumber-rails/pull/394) /
  [#395](https://github.com/cucumber/cucumber-rails/pull/395) /
  [#408](https://github.com/cucumber/cucumber-rails/pull/408)
- [xtrasimplicity](https://github.com/xtrasimplicity) /
- [deivid-rodriguez](https://github.com/deivid-rodriguez) /
- [mvz](https://github.com/mvz)
+ [xtrasimplicity] /
+ [deivid-rodriguez] /
+ [mvz])
  
  * Various build issues that had built up over the previous year
-  [#403](https://github.com/cucumber/cucumber-rails/pull/403) /
+  ([#403](https://github.com/cucumber/cucumber-rails/pull/403) /
   [#404](https://github.com/cucumber/cucumber-rails/pull/404) /
   [#410](https://github.com/cucumber/cucumber-rails/pull/410)
-  [koic](https://github.com/koic) /
-  [mvz](https://github.com/mvz)
+  [koic] /
+  [mvz])
 
 ## [v1.6.0](https://github.com/cucumber/cucumber-rails/compare/v1.5.0...v1.6.0) (2018-04-23)
 
@@ -40,7 +86,7 @@ There are currently no unreleased changes.
  * Updated syntax to support both new and deprecated forms of tag negation. ([#348](https://github.com/cucumber/cucumber-rails/pull/348) [mirelon](https://github.com/mirelon), [#359](https://github.com/cucumber/cucumber-rails/pull/359) [xtrasimplicity](https://github.com/xtrasimplicity))
  * Dependencies: Allowed `Ammeter` versions greater than 1.1.3. ([#368](https://github.com/cucumber/cucumber-rails/pull/368) [mvz](https://github.com/mvz))
  * Switched to Ruby 1.9 hash syntax. ([#371](https://github.com/cucumber/cucumber-rails/pull/371) [mvz](https://github.com/mvz))
- * Added support to handle rerun files with multiple lines. ([#c6d3d7e](https://github.com/cucumber/cucumber-rails/commit/c6d3d7e77febb758ae17bd154b9d4da7a8847c3d) [mvz](https://github.com/mvz))
+ * Added support to handle rerun files with multiple lines. ([#373]((https://github.com/cucumber/cucumber-rails/pull/345)) [mvz](https://github.com/mvz))
  * Added support for Rails 5.2 and Capybara 3. ([#378](https://github.com/cucumber/cucumber-rails/pull/378/) [gobijan](https://github.com/gobijan), [radar](https://github.com/radar), [xtrasimplicity](https://github.com/xtrasimplicity))
  
 ### Fixed
@@ -52,7 +98,7 @@ There are currently no unreleased changes.
 ## [v1.5.0](https://github.com/cucumber/cucumber-rails/compare/1.4.5...1.5.0) (2017-05-12)
 
  * Drop rails 3 support ([#334](https://github.com/cucumber/cucumber-rails/pull/334) Matijs van Zuijlen)
- * Add rals 5.1 support ([#337](https://github.com/cucumber/cucumber-rails/pull/337) Matijs van Zuijlen - Rafael Reggiani Manzo)
+ * Add rails 5.1 support ([#337](https://github.com/cucumber/cucumber-rails/pull/337) Matijs van Zuijlen - Rafael Reggiani Manzo)
 
 ## [v1.4.5](https://github.com/cucumber/cucumber-rails/compare/1.4.4...1.4.5) (2016-09-27)
 
@@ -492,3 +538,12 @@ and to celebrate that cucumber-rails now supports Capybara as an alternative to
 * Webrat step "Then I should be on" should use request_uri instead of path for missing query string parameters (ZhangJinzhu)
 * Added MIME type parameter to attach file step definition (Felix Flores)
 * Added check when including ActiveSupport::Testing::SetupAndTeardown for older Rails versions (Jeremy Durham)
+
+[deivid-rodriguez]: https://github.com/deivid-rodriguez
+[koic]: https://github.com/koic
+[kotovalexarian]: https://github.com/kotovalexarian
+[mvz]: https://github.com/mvz
+[olleolleolle]: https://github.com/olleolleolle
+[luke-hill]: https://github.com/luke-hill
+[amatsuda]: https://github.com/amatsuda
+[xtrasimplicity]: https://github.com/xtrasimplicity

data/CONTRIBUTING.md

@@ -29,7 +29,10 @@ This document is a guide for those maintaining Cucumber-Rails, and others who wo
     bundle install
     bin/install_geckodriver.sh
     bin/install_webpacker.sh
-    bundle exec rake
+    # Then to run tests on one specific gemfile (i.e. Rails 4.2), run
+    bundle exec appraisal rails_4_2 rake test
+    # Or run tests across the full supported stack. Note that because we support many versions. This takes 5-10 minutes
+    bundle exec rake appraisal
 
 ## Release Process
 
@@ -44,19 +47,6 @@ Now release it
     git commit -m "Release X.Y.Z"
     rake release
 
-### NOTE:
-
-If after running the rake release task you get an error similar to this:
-
-    rake aborted!
-    Couldn't git push. `git push  2>&1' failed with the following output:
-
-    To git@github.com:cucumber/cucumber-rails.git
-    ! [rejected]        rails-2.3.x -> rails-2.3.x (non-fast-forward)
-    error: failed to push some refs to 'git@github.com:cucumber/cucumber-rails.git'
-
-make sure that you have pulled all the recent changes from the master branch
-
 ## Gaining Release Karma
 
 To become a release manager, create a pull request adding your name to the list below, including

data/Gemfile

@@ -1,7 +1,5 @@
-source "https://rubygems.org"
+# frozen_string_literal: true
 
-# Test dependencies for Rails in the default test task, as test-generated
-# apps do not run bundler for speed reasons. Kept here so they can be
-# excluded from Appraisal-generated gemfiles.
+source 'https://rubygems.org'
 
 gemspec

data/README.md

@@ -5,8 +5,7 @@
 [![Code Climate](https://codeclimate.com/github/cucumber/cucumber-rails.svg)](https://codeclimate.com/github/cucumber/cucumber-rails)
 [![Open Source Helpers](https://www.codetriage.com/cucumber/cucumber-rails/badges/users.svg)](https://www.codetriage.com/cucumber/cucumber-rails)
 
-Cucumber-Rails brings Cucumber to Rails 4.2 and Rails 5.x. This gem is also compatible with Rails 6.0+
-but this is currently in a beta phase, so there may be issues.
+Cucumber-Rails brings Cucumber to Rails 4.2, Rails 5.x and Rails 6.0.
 
 ## Installation
 
@@ -63,7 +62,7 @@ When upgrading from a previous version it is recommended that you rerun:
 The *only* way to have a bug fixed or a new feature accepted is to describe it with a Cucumber feature. Let's say you think you have found a bug in the cucumber:install generator. Fork this project, clone it to your workstation and check out a branch with a descriptive name:
 
     git clone git@github.com:you/cucumber-rails.git
-    git checkout -b bug-install-generator
+    git checkout -b bugfix/generator-fails-on-ruby-25
 
 Start by making sure you can run the existing features. Now, create a feature that demonstrates what's wrong. See the existing features for examples. When you have a failing feature that reproduces the bug, commit, push and send a pull request. Someone from the Cucumber-Rails team will review it and hopefully create a fix.
 
@@ -97,14 +96,12 @@ To run the suite against a named gemfile, use the following:
 
 To remove and rebuild the different gemfiles (for example, to update a rails version or its dependencies), use the following:
 
-    [bundle exec] appraisal install
+    [bundle exec] appraisal update
 
 If you've changed versions of the dependencies, you may find it helpful to forcefully clean each appraisal's gem lock file in `gemfiles/`. You can do this using:
 
     [bundle exec] rake clean
 
-
-
 ### Adding dependencies
 
 To support the multiple-gemfile testing, when adding a new dependency the following rules apply:
@@ -123,7 +120,7 @@ If you get an error while trying to run the tests locally, similar to the one be
 
     Could not find a JavaScript runtime. See https://github.com/sstephenson/execjs for a list of available runtimes. (ExecJS::RuntimeUnavailable)
     
-you would need to install a javascript runtime.
+You need to install a javascript runtime.
 
 You can do that in ubuntu by using:
 

data/Rakefile

@@ -1,5 +1,7 @@
-# encoding: utf-8
-CUCUMBER_RAILS_VERSION = Gem::Specification.load(File.dirname(__FILE__) + '/cucumber-rails.gemspec').version.version
+# frozen_string_literal: true
+
+CUCUMBER_RAILS_VERSION =
+  Gem::Specification.load(File.dirname(__FILE__) + '/cucumber-rails.gemspec').version.version
 require 'rubygems'
 require 'bundler'
 require 'bundler/setup'
@@ -9,41 +11,43 @@ require 'rake/clean'
 require 'pathname'
 Bundler::GemHelper.install_tasks
 
-$:.unshift(File.dirname(__FILE__) + '/lib')
+$LOAD_PATH.unshift(File.dirname(__FILE__) + '/lib')
 Dir["#{File.dirname(__FILE__)}/dev_tasks/*.rake"].sort.each { |ext| load ext }
 
 CLEAN.include('doc', 'tmp')
 
 task default: :test
 
-task test: [:spec, :cucumber]
+task test: %i[spec cucumber]
 
 namespace :test do
-  desc "Run tests against all gemfiles"
+  desc 'Run tests against all gemfiles'
   task :all do
     Rake::Task['appraisal'].invoke('test')
   end
 
-  desc "Run tests against specified gemfile, e.g. rake test:gemfile[rails_3_0]"
-  task :gemfile, :name do |task, args|
+  desc 'Run tests against specified gemfile, e.g. rake test:gemfile[rails_3_0]'
+  task :gemfile, :name do |_task, args|
     unless args.name && Pathname.new("gemfiles/#{args.name}.gemfile").exist?
-      raise ArgumentError "You must provide the name of an existing Appraisal gemfile, e.g. 'rake test:gemfile[rails_3_2]'"
+      raise ArgumentError "You must provide the name of an existing Appraisal gemfile,
+        e.g. 'rake test:gemfile[rails_4_2]'"
     end
+
     Rake::Task["appraisal:#{args.name}"].invoke('test')
   end
 end
 
 namespace :gemfiles do
-  desc "Install dependencies for all gemfiles"
+  desc 'Install dependencies for all gemfiles'
   task :install do
-    ENV['BUNDLE_GEMFILE'] = "Gemfile.appraisal"
+    ENV['BUNDLE_GEMFILE'] = 'Gemfile.appraisal'
     Rake::Task['appraisal:install'].invoke
   end
 
   task :clean do
-    FileUtils.rm_rf("gemfiles/*")
+    FileUtils.rm_rf('gemfiles/*')
   end
 
-  desc "Rebuild generated gemfiles and install dependencies"
-  task rebuild: [:clean, :install]
+  desc 'Rebuild generated gemfiles and install dependencies'
+  task rebuild: %i[clean install]
 end

data/bin/install_geckodriver.sh

@@ -8,7 +8,7 @@ curl --silent \
      --fail \
      --retry 3 \
      --output /tmp/geckodriver_linux64.tar.gz \
-     https://github.com/mozilla/geckodriver/releases/download/v0.23.0/geckodriver-v0.23.0-linux64.tar.gz
+     https://github.com/mozilla/geckodriver/releases/download/v0.24.0/geckodriver-v0.24.0-linux64.tar.gz
 
 sudo tar -C /usr/local/bin -xvzf /tmp/geckodriver_linux64.tar.gz geckodriver
 

data/cucumber-rails.gemspec

@@ -1,44 +1,44 @@
-# -*- encoding: utf-8 -*-
-$LOAD_PATH.unshift File.expand_path("../lib", __FILE__)
+# frozen_string_literal: true
+
+$LOAD_PATH.unshift File.expand_path('lib', __dir__)
 
 Gem::Specification.new do |s|
   s.name        = 'cucumber-rails'
-  s.version     = '1.7.0'
-  s.authors     = ["Aslak Hellesøy", "Dennis Blöte", "Rob Holland"]
-  s.description = "Cucumber Generator and Runtime for Rails"
+  s.version     = '1.8.0'
+  s.authors     = ['Aslak Hellesøy', 'Dennis Blöte', 'Rob Holland']
+  s.description = 'Cucumber Generator and Runtime for Rails'
   s.summary     = "#{s.name}-#{s.version}"
   s.email       = 'cukes@googlegroups.com'
-  s.homepage    = "http://cukes.info"
+  s.homepage    = 'http://cukes.info'
 
   s.license = 'MIT'
 
-  s.required_ruby_version = '>= 2.2'
-
-  s.add_runtime_dependency('capybara', ['>= 2.3.0', '< 4'])
+  s.add_runtime_dependency('capybara', ['>= 2.12', '< 4'])
   s.add_runtime_dependency('cucumber', ['>= 3.0.2', '< 4'])
+  s.add_runtime_dependency('mime-types', ['>= 2.0', '< 4'])
   s.add_runtime_dependency('nokogiri', '~> 1.8')
   s.add_runtime_dependency('railties', ['>= 4.2', '< 7'])
-  s.add_runtime_dependency('mime-types', ['>= 1.17', '< 4'])
 
   # Main development dependencies
-  s.add_development_dependency('ammeter', ['>= 1.0.0', '!= 1.1.3'])
-  s.add_development_dependency('appraisal', '>= 0.5.1')
-  s.add_development_dependency('aruba', '~> 0.14.2')
-  s.add_development_dependency('bundler', '>= 1.3.5')
-  s.add_development_dependency('rubocop', '~> 0.66.0')
-  s.add_development_dependency('rake', '>= 10.3')
-  s.add_development_dependency('rspec', '~> 3.5')
+  s.add_development_dependency('ammeter', '>= 1.1.4')
+  s.add_development_dependency('appraisal', '~> 2.2')
+  s.add_development_dependency('aruba', '~> 0.14.4')
+  s.add_development_dependency('bundler', '>= 1.17')
   s.add_development_dependency('rails', ['>= 4.2', '< 7'])
-  s.add_development_dependency('sqlite3', '~> 1.3.13')
+  s.add_development_dependency('rake', '>= 12.0')
+  s.add_development_dependency('rspec', '~> 3.6')
+  s.add_development_dependency('rubocop', '~> 0.72.0')
+  s.add_development_dependency('rubocop-performance', '~> 1.4.0')
+  s.add_development_dependency('rubocop-rspec', '~> 1.33.0')
+  s.add_development_dependency('sqlite3', '~> 1.3')
 
   # For Documentation:
-  s.add_development_dependency('rdiscount', '>= 2.0.7')
-  s.add_development_dependency('rdoc', '>= 3.4')
-  s.add_development_dependency('yard', '>= 0.8.7')
+  s.add_development_dependency('rdoc', '>= 6.0')
+  s.add_development_dependency('yard', '~> 0.9.10')
 
-  s.required_ruby_version = '>= 2.2.0'
-  s.rubygems_version = ">= 1.6.1"
+  s.required_ruby_version = '>= 2.3.0'
+  s.rubygems_version = '>= 1.6.1'
   s.files            = `git ls-files`.split("\n")
   s.test_files       = `git ls-files -- {spec,features}/*`.split("\n")
-  s.require_path     = "lib"
+  s.require_path     = 'lib'
 end