cucumber-rails 1.4.0 → 2.1.0

data/features/capybara_javascript_drivers.feature

@@ -3,69 +3,79 @@ Feature: Capybara Javascript Drivers
 
   Background: A simple calendar app
     Given I have created a new Rails app and installed cucumber-rails
-    And I successfully run `bundle exec rails g scaffold appointment name:string when:datetime`
-    And I write to "features/step_definitions/date_time_steps.rb" with:
-      """
-      When /^(?:|I )select "([^"]+)" as the "([^"]+)" time$/ do |time, selector|
-        select_time(time, :from => selector)
-      end
-
-      When /^(?:|I )select "([^"]+)" as the "([^"]+)" date$/ do |date, selector|
-        select_date(date, :from => selector)
-      end
-
-      When /^(?:|I )select "([^"]+)" as the "([^"]+)" date and time$/ do |datetime, selector|
-        select_datetime(datetime, :from => selector)
-      end
-      """
+    And I force selenium to run Firefox in headless mode
+    When I run `bundle exec rails g scaffold appointment name:string when:datetime`
 
   Scenario: Use a particular driver
-    Given I write to "features/create_appointment.feature" with:
+    When I write to "features/create_appointment.feature" with:
       """
       @javascript
       Feature: Create appointments
-        Scenario: Constitution on May 17
+        Scenario: Visit the Constitution on May 17
           Given I am on the new appointment page
           And I fill in "Norway's constitution" for "Name"
-          And I select "2009-02-20 15:10:00 UTC" as the "When" date and time
+          And I select "2015-02-20 15:10:00 UTC" as the "When" date and time
           And I press "Create Appointment"
           Then I should see "Norway's constitution"
-          And I should see "2009-02-20 15:10:00 UTC"
+          And I should see "2015-02-20 15:10:00 UTC"
+      """
+    And I write to "features/create_appointment_steps.rb" with:
+      """
+      Given('I am on the new appointment page') do
+        visit new_appointment_path
+      end
 
+      When('I fill in {string} for {string}') do |value, field|
+        fill_in(field, with: value)
+      end
+
+      When('I press {string}') do |button|
+        click_button(button)
+      end
+
+      Then('I should see {string}') do |text|
+        expect(page).to have_content(text)
+      end
+
+      When('I select {string} as the {string} date and time') do |datetime, selector|
+        select_datetime(datetime, from: selector)
+      end
       """
-    When I run `bundle exec rake db:migrate`
+    And I run `bundle exec rake db:migrate`
     And I run `bundle exec rake cucumber`
-    Then it should pass with:
+    Then the feature run should pass with:
       """
       1 scenario (1 passed)
       6 steps (6 passed)
       """
 
   Scenario: Mixed DB access
-    Given I write to "features/create_appointment.feature" with:
+    When I write to "features/create_appointment.feature" with:
       """
       @javascript
       Feature: Create appointments
-        Scenario: Constitution on May 17
+        Scenario: Visit the Constitution on May 17
           Given a random appointment
-          And I am viewing random appointment
+          And I am viewing the appointment
           Then I should see "Random appointment"
-
       """
-    And I write to "features/step_definitions/custom_steps.rb" with:
+    And I write to "features/step_definitions/create_appointment_steps.rb" with:
       """
-      Given /^a random appointment$/ do
-        @appointment = Appointment.create!(:name => 'Random appointment', :when => DateTime.now)
+      Given('a random appointment') do
+        @appointment = Appointment.create!(name: 'Random appointment', when: DateTime.now)
       end
 
-      Given /^I am viewing random appointment$/ do
+      Given('I am viewing the appointment') do
         visit appointment_path(@appointment)
       end
-      """
 
-    When I run `bundle exec rake db:migrate`
+      Then('I should see {string}') do |text|
+        expect(page).to have_content(text)
+      end
+      """
+    And I run `bundle exec rake db:migrate`
     And I run `bundle exec rake cucumber`
-    Then it should pass with:
+    Then the feature run should pass with:
       """
       1 scenario (1 passed)
       3 steps (3 passed)

data/features/choose_javascript_database_strategy.feature

@@ -1,9 +1,9 @@
 Feature: Choose javascript database strategy
 
-  When running a scenario with the @javascript tag, Capybara will fire up a web server
+  Whilst running a scenario with the @javascript tag, Capybara will fire up a web server
   in the same process in a separate thread to your cukes. By default, this means ActiveRecord will give it a
   separate database connection, which in turn means data you put into your database from
-  Cucumber step definitions (e.g. using FactoryGirl) won't be visible to the web server
+  Cucumber step definitions (e.g. using FactoryBot) won't be visible to the web server
   until the database transaction is committed.
 
   So if you use a transaction strategy for cleaning up your database at the end of a scenario,
@@ -26,9 +26,23 @@ Feature: Choose javascript database strategy
   Background:
     Given I have created a new Rails app and installed cucumber-rails
     And I have a "Widget" ActiveRecord model object
+    When I write to "features/step_definitions/widget_steps.rb" with:
+      """
+      When('I create {int} widgets') do |number|
+        number.times { Widget.create! }
+      end
+
+      Then('I should have {int} widgets') do |number|
+        expect(Widget.count).to eq(number)
+      end
+
+      Then('the DatabaseCleaner strategy should be {word}') do |strategy_name|
+        expect(DatabaseCleaner.cleaners.values.first.strategy.to_s).to match(/#{strategy_name}/i)
+      end
+      """
 
   Scenario: Set the strategy to truncation and run a javascript scenario.
-    Given I append to "features/env.rb" with:
+    When I append to "features/env.rb" with:
       """
       DatabaseCleaner.strategy = :transaction
       Cucumber::Rails::Database.javascript_strategy = :truncation
@@ -37,13 +51,13 @@ Feature: Choose javascript database strategy
       """
       Feature:
         Background:
-          Given I have created 2 widgets
+          When I create 2 widgets
 
         @javascript
         Scenario:
-          Then the DatabaseCleaner strategy should be truncation
           When I create 3 widgets
-          Then I should have 5 widgets
+          Then the DatabaseCleaner strategy should be truncation
+          And I should have 5 widgets
 
         @javascript
         Scenario:
@@ -54,29 +68,15 @@ Feature: Choose javascript database strategy
           Then the DatabaseCleaner strategy should be transaction
           And I should have 2 widgets
       """
-    And I write to "features/step_definitions/widget_steps.rb" with:
+    And I run the cukes
+    Then the feature run should pass with:
       """
-      Given /created? (\d) widgets/ do |num|
-        num.to_i.times { Widget.create! }
-      end
-
-      Then /should have (\d) widgets/ do |num|
-        Widget.count.should == num.to_i
-      end
-
-     Then /^the DatabaseCleaner strategy should be (\w+)$/ do |strategy_name|
-        DatabaseCleaner.connections.first.strategy.to_s.should =~ /#{strategy_name}/i
-      end
+      3 scenarios (3 passed)
+      10 steps (10 passed)
       """
-    When I run the cukes
-    Then it should pass with:
-       """
-       3 scenarios (3 passed)
-       10 steps (10 passed)
-       """
 
- Scenario: Set the strategy to deletion and run a javascript scenario.
-    Given I append to "features/env.rb" with:
+  Scenario: Set the strategy to deletion and run a javascript scenario.
+    When I append to "features/env.rb" with:
       """
       Cucumber::Rails::Database.javascript_strategy = :deletion
       """
@@ -85,7 +85,7 @@ Feature: Choose javascript database strategy
       @javascript
       Feature:
         Background:
-          Given I have created 2 widgets
+          When I create 2 widgets
 
         Scenario:
           When I create 3 widgets
@@ -94,26 +94,17 @@ Feature: Choose javascript database strategy
         Scenario:
           Then I should have 2 widgets
       """
-    And I write to "features/step_definitions/widget_steps.rb" with:
+    And I run the cukes
+    Then the feature run should pass with:
       """
-      Given /created? (\d) widgets/ do |num|
-        num.to_i.times { Widget.create! }
-      end
-
-      Then /should have (\d) widgets/ do |num|
-        Widget.count.should == num.to_i
-      end
+      2 scenarios (2 passed)
+      5 steps (5 passed)
       """
-    When I run the cukes
-    Then it should pass with:
-       """
-       2 scenarios (2 passed)
-       5 steps (5 passed)
-     """
+
   Scenario: Set the strategy to truncation with an except option and run a javascript scenario.
-    Given I append to "features/env.rb" with:
+    When I append to "features/env.rb" with:
       """
-     Cucumber::Rails::Database.javascript_strategy = :truncation, {:except=>%w[widgets]}
+      Cucumber::Rails::Database.javascript_strategy = :truncation, { except: %w[widgets] }
       """
     And I write to "features/widgets.feature" with:
       """
@@ -126,19 +117,9 @@ Feature: Choose javascript database strategy
         Scenario:
           Then I should have 3 widgets
       """
-    And I write to "features/step_definitions/widget_steps.rb" with:
+    And I run the cukes
+    Then the feature run should pass with:
       """
-      Given /created? (\d) widgets/ do |num|
-        num.to_i.times { Widget.create! }
-      end
-
-      Then /should have (\d) widgets/ do |num|
-        Widget.count.should == num.to_i
-      end
+      2 scenarios (2 passed)
+      3 steps (3 passed)
       """
-    When I run the cukes
-    Then it should pass with:
-       """
-       2 scenarios (2 passed)
-       3 steps (3 passed)
-       """

data/features/configuration.feature

@@ -0,0 +1,48 @@
+Feature: Cucumber Rails Configuration
+
+  In order to configure how Cucumber-Rails runs
+  As a developer
+  I should be able to alter the settings of my project
+
+  Scenario: Default configuration
+    Given I have created a new Rails app with no database and installed cucumber-rails
+    When I write to "features/config.feature" with:
+      """
+      Feature: Rack Test Methods
+        Scenario: Default Methods are added to the World
+          Then Rack Test should be mixed into the Cucumber World
+      """
+    When I write to "features/step_definitions/config_steps.rb" with:
+      """
+      Then('Rack Test should be mixed into the Cucumber World') do
+        expect(self.class.ancestors).to include(Rack::Test::Methods)
+      end
+      """
+    And I run `bundle exec rake cucumber`
+    Then the feature run should pass with:
+      """
+      1 scenario (1 passed)
+      1 step (1 passed)
+      """
+
+  Scenario: Altered configuration
+    Given I have created a new Rails app with no database and installed cucumber-rails
+    And I set the environment variable "CR_REMOVE_RACK_TEST_HELPERS" to "true"
+    When I write to "features/config.feature" with:
+      """
+      Feature: Rack Test Methods
+        Scenario: Rack Test Methods can be removed from the world
+          Then Rack Test should not be mixed into the Cucumber World
+      """
+    When I write to "features/step_definitions/config_steps.rb" with:
+      """
+      Then('Rack Test should not be mixed into the Cucumber World') do
+        expect(self.class.ancestors).not_to include(Rack::Test::Methods)
+      end
+      """
+    And I run `bundle exec rake cucumber`
+    Then the feature run should pass with:
+      """
+      1 scenario (1 passed)
+      1 step (1 passed)
+      """

data/features/database_cleaner.feature

@@ -1,44 +1,44 @@
-Feature: DatabaseCleaner
+Feature: Database Cleaner
 
   Scenario: Create records in background
     Given I have created a new Rails app and installed cucumber-rails
-    And I write to "features/widgets.feature" with:
+    When I write to "features/widgets.feature" with:
       """
       Feature: Create widgets
-        Background: some widdgets
+        Background: 2 initial widgets
           Given I have 2 widgets
-      
-        Scenario: Add 3
+
+        Scenario: Add 3 widgets
           When I create 3 more widgets
           Then I should have 5 widgets
 
-        Scenario: Add 7
+        Scenario: Add 7 widgets
           When I create 7 more widgets
           Then I should have 9 widgets
       """
-    And I successfully run `rails generate model widget name:string`
+    And I run `rails generate model widget name:string`
     And I write to "features/step_definitions/widget_steps.rb" with:
       """
-      Given /^I have (\d+) widgets$/ do |n|
-        n.to_i.times do |i|
-          Widget.create! :name => "Widget #{Widget.count + i}"
+      Given('I have {int} widgets') do |number|
+        number.times do |i|
+          Widget.create! name: "Widget #{Widget.count + i}"
         end
       end
 
-      When /^I create (\d+) more widgets$/ do |n|
-        n.to_i.times do |i|
-          Widget.create! :name => "Widget #{Widget.count + i}"
+      When('I create {int} more widgets') do |number|
+        number.times do |i|
+          Widget.create! name: "Widget #{Widget.count + i}"
         end
       end
 
-      Then /^I should have (\d+) widgets$/ do |n|
-        Widget.count.should == n.to_i
+      Then('I should have {int} widgets') do |number|
+        expect(Widget.count).to eq(number)
       end
       """
     And I run `bundle exec rake db:migrate`
     And I run `bundle exec rake cucumber`
-    Then it should pass with:
-       """
-       2 scenarios (2 passed)
-       6 steps (6 passed)
-       """
+    Then the feature run should pass with:
+      """
+      2 scenarios (2 passed)
+      6 steps (6 passed)
+      """

data/features/disable_automatic_database_cleaning.feature

@@ -12,7 +12,7 @@ Feature: Disable automatic database cleaning
 
   Scenario: Disabling automatic cleaning
     Given I have created a new Rails app and installed cucumber-rails
-    And I append to "features/env.rb" with:
+    When I append to "features/env.rb" with:
       """
       Cucumber::Rails::Database.autorun_database_cleaner = false
       """
@@ -27,29 +27,23 @@ Feature: Disable automatic database cleaning
           When I create 5 widgets
           Then I should have 8 widgets
       """
-    And I successfully run `rails generate model widget name:string`
+    And I run `rails generate model widget name:string`
     And I write to "features/step_definitions/widget_steps.rb" with:
       """
-      Given /^I have (\d+) widgets$/ do |n|
-        n.to_i.times do |i|
-          Widget.create! :name => "Widget #{Widget.count + i}"
+      When('I create {int} widgets') do |number|
+        number.times do |i|
+          Widget.create! name: "Widget #{Widget.count + i}"
         end
       end
 
-      When /^I create (\d+) widgets$/ do |n|
-        n.to_i.times do |i|
-          Widget.create! :name => "Widget #{Widget.count + i}"
-        end
-      end
-
-      Then /^I should have (\d+) widgets$/ do |n|
-        Widget.count.should == n.to_i
+      Then('I should have {int} widgets') do |number|
+        expect(Widget.count).to eq(number)
       end
-     """
+      """
     And I run `bundle exec rake db:migrate`
     And I run `bundle exec rake cucumber`
-    Then it should pass with:
-       """
-       2 scenarios (2 passed)
-       4 steps (4 passed)
-       """
+    Then the feature run should pass with:
+      """
+      2 scenarios (2 passed)
+      4 steps (4 passed)
+      """

data/features/emulate_javascript.feature

@@ -1,44 +1,53 @@
 Feature: Emulate Javascript
 
-  Scenario: See a widget
+  Background:
     Given I have created a new Rails app and installed cucumber-rails
-    And I successfully run `rails generate scaffold widget name:string`
-    And I write to "features/f.feature" with:
+    And I force selenium to run Firefox in headless mode
+    When I run `rails generate scaffold widget name:string`
+    And I write to "features/step_definitions/widget_steps.rb" with:
+    """
+      Given('there is a widget named {string}') do |name|
+        FactoryBot.create(:widget, name: name)
+      end
+
+      When('I am on the widgets page') do
+        visit widgets_path
+      end
+
+      Then('I should see {string}') do |text|
+        expect(page).to have_content(text)
+      end
+      """
+    And I write to "features/support/factories/widget.rb" with:
+      """
+      FactoryBot.define do
+        factory :widget do
+          name { 'testwidget' }
+        end
+      end
+      """
+
+  Scenario: See a widget
+    When I write to "features/widgets.feature" with:
       """
       @javascript
       Feature: Widget inventory
         Scenario: Delete a widget
           Given there is a widget named "wrench"
-          When I go to the widgets page
+          And I am on the widgets page
           Then I should see "wrench"
       """
-    And I write to "features/step_definitions/s.rb" with:
-      """
-      Given /^there is a widget named "([^"]*)"$/ do |name|
-        FactoryGirl.create(:widget, :name => name)
-      end
-      """
-    And I write to "features/support/factories.rb" with:
+    And I run `bundle exec rake db:migrate`
+    And I run `bundle exec rake cucumber`
+    Then the feature run should pass with:
       """
-      FactoryGirl.define do
-        factory :widget do
-          name 'testwidget'
-        end
-      end
+      1 scenario (1 passed)
+      3 steps (3 passed)
       """
-    When I run `bundle exec rake db:migrate`
-    And I run `bundle exec rake cucumber`
-    Then it should pass with:
-       """
-       1 scenario (1 passed)
-       3 steps (3 passed)
-       """
 
   Scenario: Pass on the CSRF token
-    Given I have created a new Rails app and installed cucumber-rails
-    And I successfully run `rails generate scaffold widget name:string`
-    And I successfully run `sed -i -e 's/forgery_protection *= false/forgery_protection = true/' config/environments/test.rb`
-    And I successfully run `rails generate controller session establish`
+    When I run `sed -i -e 's/forgery_protection *= false/forgery_protection = true/' config/environments/test.rb`
+    And I run `rails generate controller session establish`
     And I write to "app/controllers/session_controller.rb" with:
       """
       class SessionController < ApplicationController
@@ -51,42 +60,50 @@ Feature: Emulate Javascript
       """
       class ApplicationController < ActionController::Base
         protect_from_forgery
-        before_filter :except => :establish do
-          render :text => "denied", :status => :forbidden and return false unless session[:verified]
+
+        before_action except: :establish do
+          render text: 'denied', status: :forbidden and return false unless session[:verified]
         end
       end
       """
-    And I write to "features/f.feature" with:
+    And I write to "features/widgets.feature" with:
       """
       Feature: Widget inventory
         Scenario: Delete a widget
           Given there is a widget named "wrench"
-          When I go to the session establish page
-          And I go to the widgets page
+          And I am on the session establish page
+          And I am on the widgets page
           Then I should see "wrench"
           When I follow "Destroy"
           Then I should not see "denied"
           And I should be on the widgets page
           And I should not see "wrench"
       """
-    And I write to "features/step_definitions/s.rb" with:
+    And I append to "features/step_definitions/widget_steps.rb" with:
+      # TODO: Remove the newline below (Required) once bug is fixed: https://github.com/cucumber/aruba/issues/662
       """
-      Given /^there is a widget named "([^"]*)"$/ do |name|
-        FactoryGirl.create(:widget, :name => name)
+
+      Given('I am on the session establish page') do
+        visit session_establish_path
       end
-      """
-    And I write to "features/support/factories.rb" with:
-      """
-      FactoryGirl.define do
-        factory :widget do
-          name 'testwidget'
-        end
+
+      When('I follow {string}') do |link|
+        click_link(link)
+      end
+
+      Then('I should not see {string}') do |text|
+        expect(page).not_to have_content(text)
+      end
+
+      Then('I should be on the widgets page') do
+        current_path = URI.parse(current_url).path
+        expect(current_path).to eq(widgets_path)
       end
       """
-    When I run `bundle exec rake db:migrate`
+    And I run `bundle exec rake db:migrate`
     And I run `bundle exec rake cucumber`
-    Then it should pass with:
-       """
-       1 scenario (1 passed)
-       8 steps (8 passed)
-       """
+    Then the feature run should pass with:
+      """
+      1 scenario (1 passed)
+      8 steps (8 passed)
+      """

data/features/install_cucumber_rails.feature

@@ -1,7 +1,7 @@
-Feature: Rails
-  In order to take over the world
-  Cucumber-Rails should work on major versions
-  of Rails 3 or 4 and Ruby, with Capybara, Spork and DatabaseCleaner
+Feature: Install Cucumber Rails
+
+  Cucumber-Rails should work on supported versions
+  of Ruby on Rails, with Capybara and DatabaseCleaner
 
   Scenario: Install Cucumber-Rails
     Given I have created a new Rails app and installed cucumber-rails
@@ -9,5 +9,6 @@ Feature: Rails
       | config/cucumber.yml                    |
       | script/cucumber                        |
       | features/support/env.rb                |
+      | features/step_definitions/.gitkeep     |
       | lib/tasks/cucumber.rake                |
-    And the file "features/support/env.rb" should contain "require 'cucumber/rails'"
+    And the file "features/support/env.rb" should contain "require 'cucumber/rails'"

data/features/no_database.feature

@@ -1,11 +1,11 @@
 Feature: No Database
+
   Allow Cucumber to work with a Rails app without a database
 
-  @fails-on-travis
   Scenario: No ActiveRecord and DatabaseCleaner
     Given I have created a new Rails app with no database and installed cucumber-rails
     # Turn off ActiveRecord
-    And I write to "config/application.rb" with:
+    When I write to "config/application.rb" with:
       """
       require File.expand_path('../boot', __FILE__)
 
@@ -17,7 +17,7 @@ Feature: No Database
 
       module TestApp
         class Application < Rails::Application
-          config.encoding = "utf-8"
+          config.encoding = 'utf-8'
           config.filter_parameters += [:password]
         end
       end
@@ -26,20 +26,13 @@ Feature: No Database
       """
       require 'cucumber/rails'
       """
-    # Remove DatabaseCleaner and SQLite
-    And I write to "Gemfile" with:
-      """
-      source 'http://rubygems.org'
-      gem 'rails'
-      gem "cucumber-rails", :group => :test, :path => "../../.."
-      gem "capybara", :group => :test
-      gem "rspec-rails", :group => :test
-      """
+    And I remove the 'database_cleaner' gem from the Gemfile
+    And I remove the 'sqlite' gem from the Gemfile
     And I write to "app/controllers/posts_controller.rb" with:
       """
       class PostsController < ApplicationController
         def index
-          raise "There is an error in index"
+          raise 'There is an error in index'
         end
       end
       """
@@ -53,11 +46,11 @@ Feature: No Database
       """
       Feature: posts
         Scenario: See them
-          When I do it
+          When I view the posts
       """
     And I write to "features/step_definitions/posts_steps.rb" with:
       """
-      When /^I do it$/ do
+      When('I view the posts') do
         visit '/posts'
       end
       """