cucumber-rails 0.4.1 → 0.5.0.beta1

data/History.txt

@@ -1,3 +1,12 @@
+== 0.5.0.beta1
+
+* Dropped support for Rails 2 (Aslak Hellesøy)
+* Dropped support for Webrat (Aslak Hellesøy)
+* Removed database cleaner strategy overrides (#134 Daniel Morrison, Daniel Duvall)
+* Upgrade to Capybara 1.0.0.beta1 or newer (#130 Simon Menke, Klaus Hartl, Aslak Hellesøy)
+* Generated paths.rb cleanup (#133 Tim Pope)
+* Allow css pseudo-classes in scopers (#122 twalpole)
+
 == 0.4.1 2011-04-05
 
 === Bugfixes

data/README.md

@@ -0,0 +1,74 @@
+# Cucumber-Rails
+
+Cucumber-Rails brings Cucumber to Rails3. It contains 2 generators - one
+for bootstrapping your Rails app for Cucumber, and a second one for generating features.
+
+Cucumber-Rails also contains Cucumber Step Definitions that wrap Capybara,
+giving you a head start for writing Cucumber features against your Rails app.
+
+## Installation
+
+Before you can use the generator, add the gem to your project's Gemfile as follows:
+
+    group :test do
+      gem 'cucumber-rails'
+      # database_cleaner is not required, but highly recommended
+      gem 'database_cleaner'
+    end
+
+Then install it by running:
+
+    bundle install
+
+Learn about the various options:
+
+    ruby rails generate cucumber:install --help
+
+Finally, bootstrap your Rails app, for example:
+
+    rails generate cucumber:install
+
+## Generating a Cucumber feature
+
+IMPORTANT: Only do this if you are new to Cucumber. We recommend you write your
+Cucumber features by hand once you get the hang of it.
+
+Example:
+
+    ruby rails generate cucumber:feature post title:string body:text published:boolean
+    ruby rails generate scaffold post title:string body:text published:boolean
+    rake db:migrate
+    rake cucumber
+
+## Running Cucumber
+
+With Rake:
+
+    rake cucumber
+
+Without Rake:
+
+    [bundle exec] cucumber
+
+## Hacking on Cucumber-Rails
+
+If you have a bugfix or a new feature you want to contribute, please fork on Github and make your own feature branch:
+
+  git clone git@github.com:you/cucumber-rails.git
+  git checkout -b 87-my-awesome-bugfix
+
+The feature branch should contain a ticket number (if applicable) and a descriptive name that aligns with the ticket name.
+When you think you're done send a pull request.
+
+### Setting up your environment
+
+I strongly recommend rvm and ruby 1.9.2. When you have that, cd into your cucumber-rails repository and:
+
+  gem install bundler
+  bundle install
+
+### Running all features
+
+  rake cucumber
+
+One of the features uses MongoDB, which needs to be running in order to make features/mongoid.feature to pass.

data/config/cucumber.yml

@@ -0,0 +1 @@
+default: --tags ~@broken

data/cucumber-rails.gemspec

@@ -1,36 +1,36 @@
 # -*- encoding: utf-8 -*-
 $LOAD_PATH.unshift File.expand_path("../lib", __FILE__)
-require 'cucumber/rails/version'
 
 Gem::Specification.new do |s|
   s.name        = 'cucumber-rails'
-  s.version     = Cucumber::Rails::VERSION
+  s.version     = '0.5.0.beta1'
   s.authors     = ["Aslak Hellesøy", "Dennis Blöte", "Rob Holland"]
   s.description = "Cucumber Generators and Runtime for Rails"
-  s.summary     = "cucumber-rails-#{s.version}"
+  s.summary     = "#{s.name}-#{s.version}"
   s.email       = 'cukes@googlegroups.com'
   s.homepage    = "http://cukes.info"
 
-  s.add_dependency('cucumber', Cucumber::Rails::DEPS['cucumber'])
-  s.add_dependency('rack-test', Cucumber::Rails::DEPS['rack-test'])
-  s.add_dependency('nokogiri', Cucumber::Rails::DEPS['nokogiri'])
-  s.add_development_dependency('bundler', Cucumber::Rails::DEPS['bundler'])
-  s.add_development_dependency('aruba', Cucumber::Rails::DEPS['aruba'])
-  s.add_development_dependency('rails', Cucumber::Rails::DEPS['rails'])
-  s.add_development_dependency('sqlite3-ruby', Cucumber::Rails::DEPS['sqlite3-ruby'])
-  s.add_development_dependency('rspec-rails', Cucumber::Rails::DEPS['rspec-rails'])
-  s.add_development_dependency('capybara', Cucumber::Rails::DEPS['capybara'])
-  s.add_development_dependency('webrat', Cucumber::Rails::DEPS['webrat'])
-  s.add_development_dependency('database_cleaner', Cucumber::Rails::DEPS['database_cleaner'])
-  s.add_development_dependency('mongoid', Cucumber::Rails::DEPS['mongoid'])
-  s.add_development_dependency('bson_ext', Cucumber::Rails::DEPS['bson_ext'])
-  s.add_development_dependency('akephalos', Cucumber::Rails::DEPS['akephalos'])
+  s.add_dependency('cucumber', '>= 0.10.2')
+  s.add_dependency('rack-test', '>= 0.5.7')
+  s.add_dependency('nokogiri', '>= 1.4.4')
+  s.add_dependency('capybara', '>= 1.0.0.beta1')
+  s.add_development_dependency('bundler', '>= 1.0.12')
+  s.add_development_dependency('aruba', '>= 0.3.6')
+  s.add_development_dependency('rails', '>= 3.0.7')
+  s.add_development_dependency('sqlite3-ruby', '>= 1.3.3')
+  s.add_development_dependency('rspec', '>= 2.6.0.rc6')
+  s.add_development_dependency('rspec-rails', '>= 2.2.0')
+  s.add_development_dependency('factory_girl', '>= 2.0.0.beta2')
+  s.add_development_dependency('database_cleaner', '>= 0.6.7')
+  s.add_development_dependency('mongoid', '>= 2.0.1')
+  s.add_development_dependency('bson_ext', '>= 1.3.0')
+  # s.add_development_dependency('akephalos', '>= 0.2.5')
 
   s.rubygems_version = ">= 1.6.1"
   s.files            = `git ls-files`.split("\n")
   s.test_files       = `git ls-files -- {spec,features}/*`.split("\n")
   s.executables      = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
-  s.extra_rdoc_files = ["LICENSE", "README.rdoc", "History.txt"]
+  s.extra_rdoc_files = ["LICENSE", "README.md", "History.txt"]
   s.rdoc_options     = ["--charset=UTF-8"]
   s.require_path     = "lib"
 end

data/features/capybara_javascript_drivers.feature

@@ -1,3 +1,4 @@
+@broken
 Feature: Capybara Javascript Drivers
 
   Background: A simple calendar app

data/features/emulate_javascript.feature

@@ -0,0 +1,33 @@
+Feature: Emulate Javascript
+
+  Scenario: Delete a widget
+    Given I have created a new Rails 3 app "widgets" with cucumber-rails support
+    And I successfully run `rails generate scaffold widget name:string`
+    And I write to "features/f.feature" with:
+      """
+      Feature: Widget inventory
+        Scenario: Delete a widget
+          Given there is a widget named "wrench"
+          When I go to the widgets page
+          And I follow "Destroy"
+          Then I should not see "wrench"
+      """
+    And I write to "features/step_definitions/s.rb" with:
+      """
+      Given /^there is a widget named "([^"]*)"$/ do |name|
+        Factory(:widget, :name => name)
+      end
+      """
+    And I write to "features/support/factories.rb" with:
+      """
+      Factory.define :widget do |f| 
+        f.name 'testwidget'
+      end
+      """
+    When I run `rake db:migrate cucumber`
+    Then it should pass with:
+       """
+       1 scenario (1 passed)
+       4 steps (4 passed)
+       """
+

data/features/multiple_databases.feature

@@ -0,0 +1,74 @@
+Feature: Multiple Databases
+  In order to use Database Cleaner with multiple database repositories
+  As an engineer
+  I want to specify explicit strategies for each
+
+  Background: A Rails 3 app utilizing multiple database repositories exists
+    Given I have created a new Rails 3 app "rails-3-app" with cucumber-rails support
+    And I remove the file "features/step_definitions/web_steps.rb"
+    And I append to "config/database.yml" with:
+      """
+
+      ursidae:
+        adapter: sqlite3
+        database: db/ursidae.sqlite3
+      """
+    And I write to "app/models/bear.rb" with:
+      """
+      class Bear < ActiveRecord::Base
+        establish_connection "ursidae"
+      end
+      """
+    And a directory named "db/migrate"
+    And I write to "db/migrate/001_create_bears.rb" with:
+      """
+      class CreateBears < ActiveRecord::Migration
+        def self.up
+          if Rails.env == 'ursidae'
+            create_table :bears do |t|
+              t.string :name, :null => false
+            end
+            add_index :bears, :name,  :unique => true
+          end
+        end
+      end
+      """
+    And I successfully run `bundle exec rake db:migrate`
+    And I successfully run `bundle exec rake db:migrate RAILS_ENV=ursidae`
+    And I write to "features/support/env.rb" with:
+      """
+      require 'cucumber/rails'
+      DatabaseCleaner.strategy = :transaction
+      DatabaseCleaner[:active_record, {:connection => "ursidae"}].strategy = :truncation
+      """
+    And I write to "features/create_bear.feature" with:
+      """
+      Feature: Screws up in transactional test and must use truncation
+        Scenario: I create a bear
+          When I create a bear
+          And something transactional happens
+      """
+    And I write to "features/step_definitions/create_bear_steps.rb" with:
+      """
+      When /^I create a bear$/ do
+        Bear.create!(:name => "yogi")
+      end
+      When /^something transactional happens$/ do
+        Bear.transaction { Bear.find_by_name("yogi").lock! }
+      end
+      """
+
+  Scenario: Default transactional strategy is not attempted on second database
+    When I run `bundle exec rake cucumber FEATURE=features/create_bear.feature`
+    Then it should pass with:
+      """
+      1 scenario (1 passed)
+      2 steps (2 passed)
+      """
+    And the output should not contain "cannot rollback - no transaction is active"
+
+  Scenario: Truncation strategy is used on the second database
+    Given I successfully run `bundle exec rails runner 'Bear.create(:name => "boo boo")'`
+    And I successfully run `bundle exec rake cucumber FEATURE=features/create_bear.feature`
+    When I run `bundle exec rails runner 'raise "ahh! bears!" if Bear.count > 0'`
+    Then the exit status should be 0

data/features/no_database.feature

@@ -1,3 +1,4 @@
+@announce
 Feature: No Database
   Allow Cucumber to work with a Rails app without a database
 

data/features/pseduo_class_selectors.feature

@@ -0,0 +1,24 @@
+Feature: Pseudo-class Selectors
+
+  Scenario: Look within css pseudo-class selectors
+    Given a project without ActiveRecord
+    And a cukes resource
+    And I write to "app/views/cukes/index.html.erb" with:
+      """
+      <div>foo</div>
+      <div>bar</div>
+      """
+    And I write to "features/tests.feature" with:
+      """
+      Feature: Tests
+        Scenario: Tests
+          When I go to the cukes page
+          Then I should see "bar" within "div:nth-child(2)"
+          And I should not see "foo" within "div:nth-child(2)"
+      """
+    And I run `rake cucumber`
+    Then it should pass with:
+      """
+      1 scenario (1 passed)
+      3 steps (3 passed)
+      """

data/features/select_dates.feature

@@ -53,6 +53,42 @@ Feature: Select dates
       <% end %>
       """
     When I run `bundle exec rake db:migrate cucumber`
+    Then it should pass with:
+      """
+      1 scenario (1 passed)
+      6 steps (6 passed)
+      """
+      
+  Scenario: Select date when the order of fields is changed and label is set to the first select
+    Given I successfully run `bundle exec rails g scaffold appointment name:string when:date`
+    And I write to "features/create_appointment.feature" with:
+      """
+      Feature: Create appointments
+        Scenario: Constitution on May 17
+          Given I am on the new appointment page
+          And I fill in "Norway's constitution" for "Name"
+          And I select "2009-02-20" as the "When" date
+          And I press "Create Appointment"
+          Then I should see "Norway's constitution"
+          And I should see "2009-02-20"
+      """
+    And I write to "app/views/appointments/_form.html.erb" with:
+      """
+      <%= form_for(@appointment) do |f| %>
+        <div class="field">
+          <%= f.label :name %><br />
+          <%= f.text_field :name %>
+        </div>
+        <div class="field">
+          <%= f.label :when, :for => "appointment_when_2i" %><br />
+          <%= f.date_select :when, :order=>[:month, :day, :year] %>
+        </div>
+        <div class="actions">
+          <%= f.submit %>
+        </div>
+      <% end %>
+      """
+    When I run `bundle exec rake db:migrate cucumber`
     Then it should pass with:
       """
       1 scenario (1 passed)

data/features/step_definitions/cucumber_rails_steps.rb

@@ -12,6 +12,7 @@ Given /^I have created a new Rails 3 app "([^"]*)" with cucumber\-rails support$
       gem "capybara", :group => :test
       gem "rspec-rails", :group => :test
       gem "database_cleaner", :group => :test
+      gem 'factory_girl', :group => :test
 
       """
     And I successfully run `bundle exec rails generate cucumber:install`

data/lib/cucumber/rails.rb

@@ -1,9 +1,5 @@
 require 'rails'
-if Rails.version.to_f < 3.0
-  require 'cucumber/rails2'
-else
-  require 'cucumber/rails3'
-end
+require 'cucumber/rails3'
 
 require 'cucumber/rails/world'
 require 'cucumber/rails/hooks'

data/lib/cucumber/rails/capybara/javascript_emulation.rb

@@ -11,7 +11,7 @@ module Cucumber
   
         def click_with_javascript_emulation
           if link_with_non_get_http_method?
-            ::Capybara::Driver::RackTest::Form.new(driver, js_form(element_node.document, self[:href], emulated_method)).submit(self)
+            ::Capybara::RackTest::Form.new(driver, js_form(element_node.document, self[:href], emulated_method)).submit(self)
           else
             click_without_javascript_emulation
           end
@@ -64,20 +64,20 @@ module Cucumber
   end
 end
 
-class Capybara::Driver::RackTest::Node
+class Capybara::RackTest::Node
   include ::Cucumber::Rails::Capybara::JavascriptEmulation
 end
 
 Before('~@no-js-emulation') do
   # Enable javascript emulation
-  ::Capybara::Driver::RackTest::Node.class_eval do
+  ::Capybara::RackTest::Node.class_eval do
     alias_method :click, :click_with_javascript_emulation
   end
 end
 
 Before('@no-js-emulation') do
   # Disable javascript emulation
-  ::Capybara::Driver::RackTest::Node.class_eval do
+  ::Capybara::RackTest::Node.class_eval do
     alias_method :click, :click_without_javascript_emulation
   end
 end

data/lib/cucumber/rails/capybara/select_dates_and_times.rb

@@ -28,7 +28,7 @@ module Cucumber
 
         # @example "event_starts_at_"
         def get_base_dom_id_from_label_tag(field)
-          find(:xpath, "//label[contains(., '#{field}')]")['for'].gsub(/(_1i)$/, '')
+          find(:xpath, "//label[contains(., '#{field}')]")['for'].gsub(/(_[1-5]i)$/, '')
         end
       end
     end

data/lib/cucumber/rails/hooks/database_cleaner.rb

@@ -1,32 +1,7 @@
-# Default setup for DatabaseCleaner that will work for most projects.
-# If you need your own setup, roll your own.
 begin
   require 'database_cleaner'
 
   Before do
-    begin
-      $__cucumber_global_database_cleaner_strategy ||= DatabaseCleaner.connections[0].strategy # There is no accessor on the DatabaseCleaner
-    rescue DatabaseCleaner::NoStrategySetError => e
-      e.message << "\nYou can set the strategy in your features/support/env.rb"
-    end
-  end
-
-  Before('~@no-txn', '~@selenium', '~@culerity', '~@celerity', '~@javascript') do
-    DatabaseCleaner.strategy = $__cucumber_global_database_cleaner_strategy
-  end
-
-  Before('@no-txn,@selenium,@culerity,@celerity,@javascript') do
-    DatabaseCleaner.strategy = :truncation
-  end
-
-  Before do
-    # TODO: May have to patch DatabaseCleaner's Transaction class to do what we used to do:
-    #   run_callbacks :setup if respond_to?(:run_callbacks)
-    # IIRC There was a cucumber-rails ticket that added that to support multiple connections...
-    # Similar in After (use run_callbacks :teardown if respond_to?(:run_callbacks))
-    #
-    # May also have to add this to Transaction:
-    #  include ActiveSupport::Testing::SetupAndTeardown if ActiveSupport::Testing.const_defined?("SetupAndTeardown")
     DatabaseCleaner.start
   end
 

data/lib/generators/cucumber/feature/feature_generator.rb

@@ -1,11 +1,9 @@
 require File.join(File.dirname(__FILE__), 'named_arg')
-require File.join(File.dirname(__FILE__), 'feature_base')
 
 module Cucumber
   class FeatureGenerator < ::Rails::Generators::NamedBase
+    source_root File.expand_path("../templates", __FILE__)
 
-    include Cucumber::Generators::FeatureBase
-  
     argument :fields, :optional => true, :type => :array, :banner => "[field:type, field:type]"
 
     attr_reader :named_args
@@ -15,23 +13,16 @@ module Cucumber
     end    
 
     def generate
-      create_directory
-      create_feature_file
-      create_steps_file
-      create_support_file
+      empty_directory 'features/step_definitions'
+      template 'feature.erb', "features/manage_#{plural_name}.feature"
+      template 'steps.erb', "features/step_definitions/#{singular_name}_steps.rb"
+      gsub_file 'features/support/paths.rb', /'\/'/mi do |match|
+        "#{match}\n    when /the new #{singular_name} page/\n      new_#{singular_name}_path\n"
+      end
     end
   
     def self.banner
       "#{$0} cucumber:feature ModelName [field:type, field:type]"
     end
-  
-    def self.gem_root
-      File.expand_path("../../../../../", __FILE__)
-    end
-  
-    def self.source_root
-      File.join(gem_root, 'templates', 'feature')
-    end
-  
   end
 end