cucumber-rails 0.4.0.beta.1 → 0.4.0

data/features/routing.feature

@@ -0,0 +1,21 @@
+Feature: Routing
+
+  Scenario: Visit undefined route
+    Given a project without ActiveRecord
+    And I remove the file "public/index.html"
+    And I write to "features/tests.feature" with:
+      """
+      Feature: Tests
+        Scenario: Tests
+          When I go to the home page
+      """
+    And I run `rake cucumber`
+    Then it should fail with:
+      """
+      1 scenario (1 failed)
+      1 step (1 failed)
+      """
+    And the stdout should contain:
+       """
+       No route matches "/" (ActionController::RoutingError)
+       """

data/features/select_dates.feature

@@ -0,0 +1,25 @@
+Feature: Select dates
+
+  Background: A simple calendar app
+    Given I have created a new Rails 3 app "rails-3-app" with cucumber-rails support
+    And I successfully run `bundle exec rails g scaffold appointment name:string when:datetime`
+  
+  Scenario: Select dates
+    Given I write to "features/create_appointment.feature" with:
+      """
+      Feature: Create appointments
+        Scenario: Constitution on May 17
+          Given I am on the new appointment page
+          And I fill in "Norway's constitution" for "Name"
+          And I select "2009-02-20 15:10:00 UTC" as the "When" date and time
+          And I press "Create Appointment"
+          Then I should see "Norway's constitution"
+          And I should see "2009-02-20 15:10:00 UTC"
+      """
+    When I run `bundle exec rake db:migrate cucumber`
+    Then it should pass with:
+      """
+      1 scenario (1 passed)
+      6 steps (6 passed)
+      """
+    

data/features/step_definitions/cucumber_rails_steps.rb

@@ -1,13 +1,74 @@
 Given /^I have created a new Rails 3 app "([^"]*)" with cucumber\-rails support$/ do |app_name|
   steps %Q{
-    When I successfully run "rails new rails-3-app"
+    When I successfully run `rails new #{app_name}`
     Then it should pass with:
       """
       README
       """
     And I cd to "#{app_name}"
-    And I successfully run "rails generate cucumber:install"
-    And I successfully run "bundle install"
-    And I successfully run "rake db:migrate"
+    And I append to "Gemfile" with:
+      """
+      gem "cucumber-rails", :group => :test, :path => "../../.."
+      gem "capybara", :group => :test
+      gem "rspec-rails", :group => :test
+      gem "database_cleaner", :group => :test
+      """
+    And I successfully run `bundle exec rails generate cucumber:install`
   }
 end
+
+Given /^a project without ActiveRecord$/ do
+  steps %Q{
+    Given I successfully run `rails new cuke-app`
+    And I cd to "cuke-app"
+    And I append to "Gemfile" with:
+      """
+      gem "cucumber-rails", :group => :test, :path => "../../.."
+      gem "capybara", :group => :test
+      gem "rspec-rails", :group => :test
+      """
+    And I successfully run `bundle exec rails generate cucumber:install`
+    And I overwrite "features/support/env.rb" with:
+      """
+      require 'cucumber/rails'
+      """
+
+    And I write to "config/application.rb" with:
+      """
+      require File.expand_path('../boot', __FILE__)
+
+      require 'action_controller/railtie'
+      require 'action_mailer/railtie'
+      require 'active_resource/railtie'
+      require 'rails/test_unit/railtie'
+
+      Bundler.require(:default, Rails.env) if defined?(Bundler)
+
+      module CukeApp
+        class Application < Rails::Application
+          config.encoding = "utf-8"
+          config.filter_parameters += [:password]
+        end
+      end
+      """
+    And I remove the file "config/database.yml"
+  }
+end
+
+And /^a cukes resource$/ do
+  steps %Q{
+    Given I write to "config/routes.rb" with:
+      """
+      CukeApp::Application.routes.draw do
+        resources :cukes
+      end
+      """
+    And I write to "app/controllers/cukes_controller.rb" with:
+      """
+      class CukesController < ApplicationController
+        def index
+        end
+      end
+      """
+  }
+end

data/features/support/env.rb

@@ -1,6 +1,10 @@
-ENV['CUCUMBER_RAILS_TEST'] = 'yeah baby'
 $:.unshift(File.dirname(__FILE__) + '/../../lib')
 require 'rubygems'
 require 'bundler/setup'
 require 'rspec/expectations'
 require 'aruba/cucumber'
+
+Before do
+  @aruba_timeout_seconds = 60 # A long time needed some times to install gems (bundle install)
+  unset_bundler_env_vars
+end

data/generators/cucumber/cucumber_generator.rb

@@ -4,8 +4,6 @@ require File.expand_path(File.join(File.dirname(__FILE__), '../../lib/generators
 class CucumberGenerator < Rails::Generator::Base
   include Cucumber::Generators::InstallBase
 
-  attr_accessor :driver
-  attr_accessor :framework
   attr_reader :language, :template_dir
 
   def initialize(runtime_args, runtime_options = {})
@@ -19,14 +17,6 @@ class CucumberGenerator < Rails::Generator::Base
     end
   end
 
-  def framework
-    options[:framework] ||= detect_current_framework || detect_default_framework
-  end
-
-  def driver
-    options[:driver] ||= detect_current_driver || detect_default_driver
-  end
-
   def self.gem_root
     File.expand_path('../../../', __FILE__)
   end
@@ -48,23 +38,7 @@ class CucumberGenerator < Rails::Generator::Base
   def add_options!(opt)
     opt.separator ''
     opt.separator 'Options:'
-    opt.on('--webrat', 'Setup cucumber for use with webrat') do
-      options[:driver] = :webrat
-    end
-
-    opt.on('--capybara', 'Setup cucumber for use with capybara') do
-      options[:driver] = :capybara
-    end
-
-    opt.on('--rspec', "Setup cucumber for use with RSpec") do
-      options[:framework] = :rspec
-    end
-
-    opt.on('--testunit', "Setup cucumber for use with test/unit") do
-      options[:framework] = :testunit
-    end
-
-    opt.on('--spork', 'Setup cucumber for use with Spork') do
+    opt.on('--spork', 'Use Spork to run features') do
       options[:spork] = true
     end
   end

data/lib/cucumber/rails.rb

@@ -4,26 +4,9 @@ if Rails.version.to_f < 3.0
 else
   require 'cucumber/rails3'
 end
-  
-require 'cucumber/rails/world'
-require 'cucumber/rails/hooks/database_cleaner'
-require 'cucumber/rails/hooks/allow_rescue'
-
-if defined?(Capybara)
-  require 'capybara/rails'
-  require 'capybara/cucumber'
-  require 'capybara/session'
-  require 'cucumber/rails/capybara/javascript_emulation'
-  require 'cucumber/rails/capybara/select_dates_and_times'
-end
 
-if defined?(Webrat)
-end
+require 'cucumber/rails/world'
+require 'cucumber/rails/hooks'
+require 'cucumber/rails/capybara'
 
 require 'cucumber/web/tableish'
-
-if !defined?(ActiveRecord::Base)
-  module Cucumber::Rails
-    def World.fixture_table_names; []; end # Workaround for projects that don't use ActiveRecord
-  end
-end

data/lib/cucumber/rails/capybara.rb

@@ -0,0 +1,7 @@
+if defined?(Capybara)
+  require 'capybara/rails'
+  require 'capybara/cucumber'
+  require 'capybara/session'
+  require 'cucumber/rails/capybara/javascript_emulation'
+  require 'cucumber/rails/capybara/select_dates_and_times'
+end

data/lib/cucumber/rails/capybara/select_dates_and_times.rb

@@ -3,26 +3,33 @@ module Cucumber
     module Capybara
       module SelectDatesAndTimes
         def select_date(field, options = {})
-          date = Date.parse(options[:with])
-          within(:xpath, ::Capybara::XPath.fieldset(field).append(%Q{//p[label[contains(., "#{field}")]]})) do
-            find(:xpath, '//select[contains(@id, "_1i")]').select(date.year)
-            find(:xpath, '//select[contains(@id, "_2i")]').select(date.strftime('%B'))
-            find(:xpath, '//select[contains(@id, "_3i")]').select(date.day)
-          end
+          date        = Date.parse(options[:with])
+          base_dom_id = get_base_dom_id_from_label_tag(field)
+
+          find(:xpath, "//select[@id='#{base_dom_id}_1i']").select(date.year.to_s)
+          find(:xpath, "//select[@id='#{base_dom_id}_2i']").select(date.strftime('%B'))
+          find(:xpath, "//select[@id='#{base_dom_id}_3i']").select(date.day.to_s)
         end
       
         def select_time(field, options = {})
-          time = Time.parse(options[:with])
-          within(:xpath, ::Capybara::XPath.fieldset(field).append(%Q{//p[label[contains(., "#{field}")]]})) do
-            find(:xpath, '//select[contains(@id, "_4i")]').select(time.hour.to_s.rjust(2,'0'))
-            find(:xpath, '//select[contains(@id, "_5i")]').select(time.min.to_s.rjust(2,'0'))
-          end
+          time        = Time.zone.parse(options[:with])
+          base_dom_id = get_base_dom_id_from_label_tag(field)
+
+          find(:xpath, "//select[@id='#{base_dom_id}_4i']").select(time.hour.to_s.rjust(2, '0'))
+          find(:xpath, "//select[@id='#{base_dom_id}_5i']").select(time.min.to_s.rjust(2,  '0'))
         end
       
         def select_datetime(field, options = {})
           select_date(field, options)
           select_time(field, options)
         end
+
+        private
+
+        # @example "event_starts_at_"
+        def get_base_dom_id_from_label_tag(field)
+          find(:xpath, "//label[contains(., '#{field}')]")['for'].gsub(/(1i)$/, '')
+        end
       end
     end
   end
@@ -30,14 +37,14 @@ end
 
 World(::Cucumber::Rails::Capybara::SelectDatesAndTimes)
 
-When /^(?:|I )select "([^"]*)" as the "([^"]*)" time$/ do |time, selector|
+When /^(?:|I )select "([^"]+)" as the "([^"]+)" time$/ do |time, selector|
   select_time(selector, :with => time)
 end
 
-When /^(?:|I )select "([^"]*)" as the "([^"]*)" date$/ do |date, selector|
+When /^(?:|I )select "([^"]+)" as the "([^"]+)" date$/ do |date, selector|
   select_date(selector, :with => date)
 end
 
-When /^(?:|I )select "([^"]*)" as the "([^"]*)" date and time$/ do |datetime, selector|
+When /^(?:|I )select "([^"]+)" as the "([^"]+)" date and time$/ do |datetime, selector|
   select_datetime(selector, :with => datetime)
 end

data/lib/cucumber/rails/hooks.rb

@@ -0,0 +1,3 @@
+require 'cucumber/rails/hooks/database_cleaner'
+require 'cucumber/rails/hooks/allow_rescue'
+require 'cucumber/rails/hooks/mail'

data/lib/cucumber/rails/hooks/database_cleaner.rb

@@ -1,19 +1,32 @@
+# Default setup for DatabaseCleaner that will work for most projects.
+# If you need your own setup, roll your own.
 begin
   require 'database_cleaner'
 
   Before do
-    $__cucumber_global_use_txn = !!Cucumber::Rails::World.use_transactional_fixtures if $__cucumber_global_use_txn.nil?
+    begin
+      $__cucumber_global_database_cleaner_strategy ||= DatabaseCleaner.connections[0].strategy # There is no accessor on the DatabaseCleaner
+    rescue DatabaseCleaner::NoStrategySetError => e
+      e.message << "\nYou can set the strategy in your features/support/env.rb"
+    end
   end
 
   Before('~@no-txn', '~@selenium', '~@culerity', '~@celerity', '~@javascript') do
-    Cucumber::Rails::World.use_transactional_fixtures = $__cucumber_global_use_txn
+    DatabaseCleaner.strategy = :truncation
   end
 
   Before('@no-txn,@selenium,@culerity,@celerity,@javascript') do
-    Cucumber::Rails::World.use_transactional_fixtures = false
+    DatabaseCleaner.strategy = $__cucumber_global_database_cleaner_strategy
   end
 
   Before do
+    # TODO: May have to patch DatabaseCleaner's Transaction class to do what we used to do:
+    #   run_callbacks :setup if respond_to?(:run_callbacks)
+    # IIRC There was a cucumber-rails ticket that added that to support multiple connections...
+    # Similar in After (use run_callbacks :teardown if respond_to?(:run_callbacks))
+    #
+    # May also have to add this to Transaction:
+    #  include ActiveSupport::Testing::SetupAndTeardown if ActiveSupport::Testing.const_defined?("SetupAndTeardown")
     DatabaseCleaner.start
   end
 

data/lib/cucumber/rails/rspec.rb

@@ -1,3 +1,5 @@
+require 'cucumber/rails/world'
+
 begin
   require 'rspec/rails/matchers'
 

data/lib/cucumber/rails/version.rb

@@ -1,15 +1,20 @@
 module Cucumber
   module Rails
-    VERSION = '0.4.0.beta.1'
+    VERSION = '0.4.0'
     DEPS = {
-      'cucumber'          => '~> 0.10.0',
-      'rails'             => '~> 3.0.3',
-      'capybara'          => '~> 0.4.0',
-      'webrat'            => '~> 0.7.2',
-      'rspec-rails'       => '~> 2.2.0',
-      'database_cleaner'  => '~> 0.6.0',
-      'sqlite3-ruby'      => '~> 1.3.2',
-      'aruba'             => '~> 0.2.7'
+      'aruba'             => '>= 0.3.4',
+      'cucumber'          => '>= 0.10.1',
+
+      'bundler'           => '>= 1.0.10',
+      'rack-test'         => '>= 0.5.7',
+      'nokogiri'          => '>= 1.4.4',
+      'rails'             => '>= 3.0.3',
+      'capybara'          => '>= 0.4.1',
+      'webrat'            => '>= 0.7.3',
+      'rspec-rails'       => '>= 2.2.0',
+      'database_cleaner'  => '>= 0.6.0',
+      'sqlite3-ruby'      => '>= 1.3.3',
+      'mongoid'           => '>= 2.0.0.rc.7'
     }
   end
 end

data/lib/cucumber/rails/world.rb

@@ -1,10 +1,16 @@
 module Cucumber #:nodoc:
   module Rails #:nodoc:
     class World < ActionController::IntegrationTest #:nodoc:
+      include Rack::Test::Methods
       include ActiveSupport::Testing::SetupAndTeardown if ActiveSupport::Testing.const_defined?("SetupAndTeardown")
+
       def initialize #:nodoc:
         @_result = Test::Unit::TestResult.new if defined?(Test::Unit::TestResult)
       end
+
+      if !defined?(ActiveRecord::Base)
+        def self.fixture_table_names; []; end # Workaround for projects that don't use ActiveRecord
+      end
     end
   end
 end

data/lib/cucumber/rails2.rb

@@ -12,5 +12,5 @@ else
 end
 
 if !Rails.configuration.cache_classes
-  warn "WARNING: You have set Rails' config.cache_classes to false (most likely in config/environments/cucumber.rb).  This setting is known to break Cucumber's use_transactional_fixtures method. Set config.cache_classes to true if you want to use transactional fixtures.  For more information see https://rspec.lighthouseapp.com/projects/16211/tickets/165."
+  warn "WARNING: You have set Rails' config.cache_classes to false (most likely in config/environments/cucumber.rb).  This setting is known to cause problems with database transactions. Set config.cache_classes to true if you want to use transactions.  For more information see https://rspec.lighthouseapp.com/projects/16211/tickets/165."
 end

data/lib/cucumber/rails3.rb

@@ -1,16 +1,16 @@
 require 'cucumber/rails3/application'
 ENV["RAILS_ENV"] ||= "test"
-env = caller.detect{|f| f =~ /\/env\.rb:/}
-require File.expand_path(File.dirname(env) + '/../../config/environment')
+ENV["RAILS_ROOT"] ||= File.expand_path(File.dirname(caller.detect{|f| f =~ /\/env\.rb:/}) + '/../..')
+require File.expand_path(ENV["RAILS_ROOT"] + '/config/environment')
 require 'cucumber/rails3/action_controller'
 
 if defined?(ActiveRecord::Base)
-  require 'rails/test_help' 
+  require 'rails/test_help'
 else
-  require 'action_controller/test_process'
-  require 'action_controller/integration'
+  require 'action_dispatch/testing/test_process'
+  require 'action_dispatch/testing/integration'
 end
 
 if !Rails.application.config.cache_classes
-  warn "WARNING: You have set Rails' config.cache_classes to false (most likely in config/environments/test.rb).  This setting is known to break Cucumber's use_transactional_fixtures method. Set config.cache_classes to true if you want to use transactional fixtures.  For more information see https://rspec.lighthouseapp.com/projects/16211/tickets/165."
-end
+  warn "WARNING: You have set Rails' config.cache_classes to false (most likely in config/environments/cucumber.rb).  This setting is known to cause problems with database transactions. Set config.cache_classes to true if you want to use transactions.  For more information see https://rspec.lighthouseapp.com/projects/16211/tickets/165."
+end

data/lib/generators/cucumber/install/install_base.rb

@@ -1,5 +1,5 @@
 require 'rbconfig'
-#require 'cucumber/rails/version'
+require 'cucumber/rails/version'
 
 module Cucumber
   module Generators
@@ -14,13 +14,6 @@ module Cucumber
         create_feature_support(m)
         create_tasks(m)
         create_database(m) unless options[:skip_database]
-        
-        cucumber_rails_options = {:group => :test}
-        cucumber_rails_options[:path] = '../../..' if ENV['CUCUMBER_RAILS_TEST']
-        add_gem('cucumber-rails', Cucumber::Rails::VERSION, cucumber_rails_options)
-        add_gem(driver_from_options.to_s, Cucumber::Rails::DEPS[driver_from_options.to_s], :group => :test)
-        add_gem(framework_from_options.to_s, Cucumber::Rails::DEPS[framework_from_options.to_s], :group => :test)
-        add_gem('database_cleaner', Cucumber::Rails::DEPS['database_cleaner'], :group => :test)
       end
 
       # Checks and prints the limitations
@@ -73,22 +66,18 @@ module Cucumber
       def create_feature_support(m)
         if rails2?
           m.directory 'features/support'
-          m.file      'support/paths.rb', 'features/support/paths.rb'
-
-          if spork?
-            m.template 'support/rails_spork.rb.erb', 'features/support/env.rb'
-          else
-            m.template 'support/rails.rb.erb',       'features/support/env.rb'
-          end
+          m.file      'support/paths.rb',     'features/support/paths.rb'
+          m.file      'support/selectors.rb', 'features/support/selectors.rb'
         else
           m.empty_directory 'features/support'
-          m.copy_file 'support/paths.rb', 'features/support/paths.rb'
+          m.copy_file       'support/paths.rb',     'features/support/paths.rb'
+          m.copy_file       'support/selectors.rb', 'features/support/selectors.rb'
+        end
 
-          if spork?
-            m.template 'support/rails_spork.rb.erb', 'features/support/env.rb'
-          else
-            m.template 'support/rails.rb.erb',       'features/support/env.rb'
-          end
+        if spork?
+          m.template 'support/rails_spork.rb.erb', 'features/support/env.rb'
+        else
+          m.template 'support/rails.rb.erb',       'features/support/env.rb'
         end
       end
 
@@ -103,6 +92,7 @@ module Cucumber
       end
 
       def create_database(m)
+        return unless File.exist?('config/database.yml')
         unless File.read('config/database.yml').include? 'cucumber:'
           m.gsub_file 'config/database.yml', /^test:.*\n/, "test: &test\n"
           m.gsub_file 'config/database.yml', /\z/, "\ncucumber:\n  <<: *test"
@@ -121,26 +111,6 @@ module Cucumber
         end
       end
 
-      def detect_current_driver
-        detect_in_env([['capybara', :capybara], ['webrat', :webrat]])
-      end
-
-      def detect_default_driver
-        @default_driver = first_loadable([['capybara', :capybara], ['webrat', :webrat]])
-        raise "I don't know which driver you want. Use --capybara or --webrat, or gem install capybara or webrat." unless @default_driver
-        @default_driver
-      end
-
-      def detect_current_framework
-        detect_in_env([['spec', :rspec]])  || :testunit
-      end
-
-      def detect_default_framework
-        # TODO need to check this - defaulting to :testunit has been moved from first_loadable
-        # It's unlikely that we don't have test/unit since it comes with Ruby
-        @default_framework ||= first_loadable([['rspec', :rspec]])
-      end
-
       def spork?
         options[:spork]
       end
@@ -162,16 +132,6 @@ module Cucumber
         IO.read(File.join(self.class.gem_root, 'VERSION')).chomp
       end
 
-      def first_loadable(libraries)
-        require 'rubygems'
-
-        libraries.each do |lib_name, lib_key|
-          return lib_key if Gem.available?(lib_name)
-        end
-
-        nil
-      end
-
       def detect_in_env(choices)
         return nil unless File.file?("features/support/env.rb")