cucumber-rails 0.3.2 → 0.4.0.beta.1

data/features/support/env.rb

@@ -1,4 +1,6 @@
+ENV['CUCUMBER_RAILS_TEST'] = 'yeah baby'
 $:.unshift(File.dirname(__FILE__) + '/../../lib')
 require 'rubygems'
+require 'bundler/setup'
 require 'rspec/expectations'
-require 'aruba'
+require 'aruba/cucumber'

data/generators/cucumber/cucumber_generator.rb

@@ -1,9 +1,7 @@
-require 'rbconfig'
 require File.expand_path(File.join(File.dirname(__FILE__), '../../lib/generators/cucumber/install/install_base'))
 
 # This generator bootstraps a Rails project for use with Cucumber
 class CucumberGenerator < Rails::Generator::Base
-
   include Cucumber::Generators::InstallBase
 
   attr_accessor :driver
@@ -17,13 +15,7 @@ class CucumberGenerator < Rails::Generator::Base
 
   def manifest
     record do |m|
-      check_upgrade_limitations
-      create_templates(m, true)
-      create_scripts(m, true)
-      create_step_definitions(m, true)
-      create_feature_support(m, true)
-      create_tasks(m, true)
-      create_database(m, true)
+      install_cucumber_rails(m)
     end
   end
 
@@ -35,10 +27,6 @@ class CucumberGenerator < Rails::Generator::Base
     options[:driver] ||= detect_current_driver || detect_default_driver
   end
 
-  def cucumber_rails_env
-    'cucumber'
-  end
-
   def self.gem_root
     File.expand_path('../../../', __FILE__)
   end
@@ -57,10 +45,6 @@ class CucumberGenerator < Rails::Generator::Base
     "Usage: #{$0} cucumber (language)"
   end
 
-  def after_generate
-    print_instructions
-  end
-
   def add_options!(opt)
     opt.separator ''
     opt.separator 'Options:'

data/lib/cucumber/rails.rb

@@ -0,0 +1,29 @@
+require 'rails'
+if Rails.version.to_f < 3.0
+  require 'cucumber/rails2'
+else
+  require 'cucumber/rails3'
+end
+  
+require 'cucumber/rails/world'
+require 'cucumber/rails/hooks/database_cleaner'
+require 'cucumber/rails/hooks/allow_rescue'
+
+if defined?(Capybara)
+  require 'capybara/rails'
+  require 'capybara/cucumber'
+  require 'capybara/session'
+  require 'cucumber/rails/capybara/javascript_emulation'
+  require 'cucumber/rails/capybara/select_dates_and_times'
+end
+
+if defined?(Webrat)
+end
+
+require 'cucumber/web/tableish'
+
+if !defined?(ActiveRecord::Base)
+  module Cucumber::Rails
+    def World.fixture_table_names; []; end # Workaround for projects that don't use ActiveRecord
+  end
+end

data/lib/cucumber/rails/capybara/javascript_emulation.rb

@@ -0,0 +1,83 @@
+module Cucumber
+  module Rails
+    module Capybara
+      module JavascriptEmulation
+        def self.included(base)
+          base.class_eval do
+            alias_method :click_without_javascript_emulation, :click
+            alias_method :click, :click_with_javascript_emulation
+          end
+        end
+  
+        def click_with_javascript_emulation
+          if link_with_non_get_http_method?
+            ::Capybara::Driver::RackTest::Form.new(driver, js_form(element_node.document, self[:href], emulated_method)).submit(self)
+          else
+            click_without_javascript_emulation
+          end
+        end
+
+        private
+
+        def js_form(document, action, emulated_method, method = 'POST')
+          js_form = document.create_element('form')
+          js_form['action'] = action
+          js_form['method'] = method
+
+          if emulated_method and emulated_method.downcase != method.downcase
+            input = document.create_element('input')
+            input['type'] = 'hidden'
+            input['name'] = '_method'
+            input['value'] = emulated_method
+            js_form.add_child(input)
+          end
+        
+          js_form
+        end
+
+        def link_with_non_get_http_method?
+          if ::Rails.version.to_f >= 3.0
+            tag_name == 'a' && element_node['data-method'] && element_node['data-method'] =~ /(?:delete|put|post)/
+          else
+            tag_name == 'a' && element_node['onclick'] && element_node['onclick'] =~ /var f = document\.createElement\('form'\); f\.style\.display = 'none';/
+          end
+        end
+
+        def emulated_method
+          if ::Rails.version.to_f >= 3.0
+            element_node['data-method']
+          else
+            element_node['onclick'][/m\.setAttribute\('value', '([^']*)'\)/, 1]
+          end
+        end
+
+        def element_node
+          if self.respond_to? :native
+            self.native
+          else
+            warn "DEPRECATED: cucumber-rails loves you, just not your version of Capybara. Please update Capybara to >= 0.4.0"
+            self.node
+          end
+        end
+      end
+    end
+  end
+end
+
+class Capybara::Driver::RackTest::Node
+  include ::Cucumber::Rails::Capybara::JavascriptEmulation
+end
+
+Before('~@no-js-emulation') do
+  # Enable javascript emulation
+  ::Capybara::Driver::RackTest::Node.class_eval do
+    alias_method :click, :click_with_javascript_emulation
+  end
+end
+
+Before('@no-js-emulation') do
+  # Disable javascript emulation
+  ::Capybara::Driver::RackTest::Node.class_eval do
+    alias_method :click, :click_without_javascript_emulation
+  end
+end

data/lib/cucumber/rails/capybara/select_dates_and_times.rb

@@ -0,0 +1,43 @@
+module Cucumber
+  module Rails
+    module Capybara
+      module SelectDatesAndTimes
+        def select_date(field, options = {})
+          date = Date.parse(options[:with])
+          within(:xpath, ::Capybara::XPath.fieldset(field).append(%Q{//p[label[contains(., "#{field}")]]})) do
+            find(:xpath, '//select[contains(@id, "_1i")]').select(date.year)
+            find(:xpath, '//select[contains(@id, "_2i")]').select(date.strftime('%B'))
+            find(:xpath, '//select[contains(@id, "_3i")]').select(date.day)
+          end
+        end
+      
+        def select_time(field, options = {})
+          time = Time.parse(options[:with])
+          within(:xpath, ::Capybara::XPath.fieldset(field).append(%Q{//p[label[contains(., "#{field}")]]})) do
+            find(:xpath, '//select[contains(@id, "_4i")]').select(time.hour.to_s.rjust(2,'0'))
+            find(:xpath, '//select[contains(@id, "_5i")]').select(time.min.to_s.rjust(2,'0'))
+          end
+        end
+      
+        def select_datetime(field, options = {})
+          select_date(field, options)
+          select_time(field, options)
+        end
+      end
+    end
+  end
+end
+
+World(::Cucumber::Rails::Capybara::SelectDatesAndTimes)
+
+When /^(?:|I )select "([^"]*)" as the "([^"]*)" time$/ do |time, selector|
+  select_time(selector, :with => time)
+end
+
+When /^(?:|I )select "([^"]*)" as the "([^"]*)" date$/ do |date, selector|
+  select_date(selector, :with => date)
+end
+
+When /^(?:|I )select "([^"]*)" as the "([^"]*)" date and time$/ do |datetime, selector|
+  select_datetime(selector, :with => datetime)
+end

data/lib/cucumber/rails/hooks/allow_rescue.rb

@@ -0,0 +1,8 @@
+Before('@allow-rescue') do
+  @__orig_allow_rescue = ActionController::Base.allow_rescue
+  ActionController::Base.allow_rescue = true
+end
+
+After('@allow-rescue') do
+  ActionController::Base.allow_rescue = @__orig_allow_rescue
+end

data/lib/cucumber/rails/hooks/database_cleaner.rb

@@ -0,0 +1,25 @@
+begin
+  require 'database_cleaner'
+
+  Before do
+    $__cucumber_global_use_txn = !!Cucumber::Rails::World.use_transactional_fixtures if $__cucumber_global_use_txn.nil?
+  end
+
+  Before('~@no-txn', '~@selenium', '~@culerity', '~@celerity', '~@javascript') do
+    Cucumber::Rails::World.use_transactional_fixtures = $__cucumber_global_use_txn
+  end
+
+  Before('@no-txn,@selenium,@culerity,@celerity,@javascript') do
+    Cucumber::Rails::World.use_transactional_fixtures = false
+  end
+
+  Before do
+    DatabaseCleaner.start
+  end
+
+  After do
+    DatabaseCleaner.clean
+  end
+
+rescue LoadError => ignore_if_database_cleaner_not_present
+end

data/lib/cucumber/rails/hooks/mail.rb

@@ -0,0 +1,5 @@
+if defined?(ActionMailer::Base)
+  Before do
+    ActionMailer::Base.deliveries = []
+  end
+end

data/lib/cucumber/rails/rspec.rb

@@ -1,6 +1,3 @@
-# TODO: Not even sure is this is necessary anymore, since we're doing this in Cucumber's rb_world.rb...
-require 'cucumber/rails/world'
-
 begin
   require 'rspec/rails/matchers'
 

data/lib/cucumber/rails/version.rb

@@ -0,0 +1,15 @@
+module Cucumber
+  module Rails
+    VERSION = '0.4.0.beta.1'
+    DEPS = {
+      'cucumber'          => '~> 0.10.0',
+      'rails'             => '~> 3.0.3',
+      'capybara'          => '~> 0.4.0',
+      'webrat'            => '~> 0.7.2',
+      'rspec-rails'       => '~> 2.2.0',
+      'database_cleaner'  => '~> 0.6.0',
+      'sqlite3-ruby'      => '~> 1.3.2',
+      'aruba'             => '~> 0.2.7'
+    }
+  end
+end

data/lib/cucumber/rails/world.rb

@@ -1,40 +1,6 @@
-unless defined?(Test)
-  begin
-    require 'spec/test/unit'
-  rescue LoadError => ignore_if_rspec_not_installed
-  end
-end
-
-if defined?(ActiveRecord::Base)
-  if Rails.version.to_f >= 3.0
-    require 'rails/test_help' 
-  else
-    require 'test_help' 
-  end
-else
-  # I can't do rescue LoadError because in this files could be loaded
-  # from rails gem (ie. load actionpack 2.3.5 if rubygems are not disabled)
-  if Rails.version.to_f < 3.0
-    require 'action_controller/test_process'
-    require 'action_controller/integration'
-  else
-    require 'action_dispatch/testing/test_process'
-    require 'action_dispatch/testing/integration'
-  end
-end
-
-require 'cucumber/rails/test_unit'
-require 'cucumber/rails/action_controller'
-
-
-if (::Rails.respond_to?(:application) && !(::Rails.application.config.cache_classes)) || 
-  (!(::Rails.respond_to?(:application)) && ::Rails.respond_to?(:configuration) && !(::Rails.configuration.cache_classes))
-  warn "WARNING: You have set Rails' config.cache_classes to false (most likely in config/environments/cucumber.rb).  This setting is known to break Cucumber's use_transactional_fixtures method. Set config.cache_classes to true if you want to use transactional fixtures.  For more information see https://rspec.lighthouseapp.com/projects/16211/tickets/165."
-end
-
 module Cucumber #:nodoc:
-  module Rails
-    class World < ActionController::IntegrationTest
+  module Rails #:nodoc:
+    class World < ActionController::IntegrationTest #:nodoc:
       include ActiveSupport::Testing::SetupAndTeardown if ActiveSupport::Testing.const_defined?("SetupAndTeardown")
       def initialize #:nodoc:
         @_result = Test::Unit::TestResult.new if defined?(Test::Unit::TestResult)

data/lib/cucumber/rails2.rb

@@ -0,0 +1,16 @@
+require 'cucumber/rails2/action_controller'
+ENV["RAILS_ENV"] ||= "cucumber"
+env = caller.detect{|f| f =~ /\/env\.rb:/}
+require File.expand_path(File.dirname(env) + '/../../config/environment')
+
+
+if defined?(ActiveRecord::Base)
+  require 'test_help' 
+else
+  require 'action_dispatch/testing/test_process'
+  require 'action_dispatch/testing/integration'
+end
+
+if !Rails.configuration.cache_classes
+  warn "WARNING: You have set Rails' config.cache_classes to false (most likely in config/environments/cucumber.rb).  This setting is known to break Cucumber's use_transactional_fixtures method. Set config.cache_classes to true if you want to use transactional fixtures.  For more information see https://rspec.lighthouseapp.com/projects/16211/tickets/165."
+end

data/lib/cucumber/rails2/action_controller.rb

@@ -0,0 +1,29 @@
+ActionController::Base.class_eval do
+  cattr_accessor :allow_rescue
+  
+  alias_method :rescue_action_without_bypass, :rescue_action
+
+  def rescue_action(exception)
+    if ActionController::Base.allow_rescue
+      rescue_action_without_bypass(exception)
+    else
+      raise exception
+    end
+  end
+end
+
+begin
+  ActionController::Failsafe.class_eval do
+    alias_method :failsafe_response_without_bypass, :failsafe_response
+
+    def failsafe_response(exception)
+      raise exception
+    end
+  end
+rescue NameError # Failsafe was introduced in Rails 2.3.2
+  ActionController::Dispatcher.class_eval do
+    def self.failsafe_response(output, status, exception = nil)
+      raise exception
+    end
+  end
+end

data/lib/cucumber/rails3.rb

@@ -0,0 +1,16 @@
+require 'cucumber/rails3/application'
+ENV["RAILS_ENV"] ||= "test"
+env = caller.detect{|f| f =~ /\/env\.rb:/}
+require File.expand_path(File.dirname(env) + '/../../config/environment')
+require 'cucumber/rails3/action_controller'
+
+if defined?(ActiveRecord::Base)
+  require 'rails/test_help' 
+else
+  require 'action_controller/test_process'
+  require 'action_controller/integration'
+end
+
+if !Rails.application.config.cache_classes
+  warn "WARNING: You have set Rails' config.cache_classes to false (most likely in config/environments/test.rb).  This setting is known to break Cucumber's use_transactional_fixtures method. Set config.cache_classes to true if you want to use transactional fixtures.  For more information see https://rspec.lighthouseapp.com/projects/16211/tickets/165."
+end

data/lib/cucumber/rails3/action_controller.rb

@@ -0,0 +1,12 @@
+ActionController::Base.class_eval do
+  cattr_accessor :allow_rescue
+end
+
+class ActionDispatch::ShowExceptions
+  alias __cucumber_orig_call__ call
+  
+  def call(env)
+    env['action_dispatch.show_exceptions'] = !!ActionController::Base.allow_rescue
+    __cucumber_orig_call__(env)
+  end
+end

data/lib/cucumber/rails3/application.rb

@@ -0,0 +1,17 @@
+require 'rails/application'
+
+# Make sure the ActionDispatch::ShowExceptions middleware is always enabled,
+# regardless of what is in config/environments/test.rb
+# Instead we are overriding ActionDispatch::ShowExceptions to be able to
+# toggle whether or not exceptions are raised.
+class Rails::Application
+  alias __cucumber_orig_initialize__ initialize!
+  
+  def initialize!
+    ad = config.action_dispatch
+    def ad.show_exceptions
+      true
+    end
+    __cucumber_orig_initialize__
+  end
+end

data/lib/generators/cucumber/feature/feature_generator.rb

@@ -2,7 +2,7 @@ require File.join(File.dirname(__FILE__), 'named_arg')
 require File.join(File.dirname(__FILE__), 'feature_base')
 
 module Cucumber
-  class FeatureGenerator < Rails::Generators::NamedBase
+  class FeatureGenerator < ::Rails::Generators::NamedBase
 
     include Cucumber::Generators::FeatureBase
   

data/lib/generators/cucumber/install/install_base.rb

@@ -1,9 +1,28 @@
+require 'rbconfig'
+#require 'cucumber/rails/version'
+
 module Cucumber
   module Generators
     module InstallBase
-
       DEFAULT_SHEBANG = File.join(Config::CONFIG['bindir'], Config::CONFIG['ruby_install_name'])
 
+      def install_cucumber_rails(m)
+        check_upgrade_limitations
+        create_templates(m)
+        create_scripts(m)
+        create_step_definitions(m)
+        create_feature_support(m)
+        create_tasks(m)
+        create_database(m) unless options[:skip_database]
+        
+        cucumber_rails_options = {:group => :test}
+        cucumber_rails_options[:path] = '../../..' if ENV['CUCUMBER_RAILS_TEST']
+        add_gem('cucumber-rails', Cucumber::Rails::VERSION, cucumber_rails_options)
+        add_gem(driver_from_options.to_s, Cucumber::Rails::DEPS[driver_from_options.to_s], :group => :test)
+        add_gem(framework_from_options.to_s, Cucumber::Rails::DEPS[framework_from_options.to_s], :group => :test)
+        add_gem('database_cleaner', Cucumber::Rails::DEPS['database_cleaner'], :group => :test)
+      end
+
       # Checks and prints the limitations
       def check_upgrade_limitations
         if File.exist?('features/step_definitions/webrat_steps.rb')
@@ -20,37 +39,15 @@ module Cucumber
       end
 
       # Creates templates
-      def create_templates(m = self, rails2 = false)
+      def create_templates(m)
         m.template 'config/cucumber.yml.erb', 'config/cucumber.yml'
-        if rails2
+        if rails2?
           m.template 'environments/cucumber.rb.erb', 'config/environments/cucumber.rb'
         end
       end
 
-      def configure_gemfile(m = self, rails2 = false)
-        require 'thor-ext'
-        unless rails2
-          puts "Update Rails 3 Gemfile for cucumber"
-          gsub_file 'Gemfile', /('|")gem/, "\1\ngem"
-          add_gem('database_cleaner', '>=0.5.2') unless has_plugin? 'database_cleaner'
-          if driver == :capybara
-            add_gem('capybara', '>=0.3.7')
-          else
-            add_gem('webrat', '>=0.7.0') unless has_plugin? 'webrat'
-          end
-          if framework == :rspec
-            add_gem('rspec', '>=1.3.0') unless has_plugin? 'rspec'
-            add_gem('rspec-rails', '>=1.3.2') unless has_plugin? 'rspec-rails'
-          end
-          if spork?
-            add_gem('spork''>=0.7.5') unless has_plugin? 'spork'
-          end
-          add_gems(%w{cucumber cucumber-rails})
-        end
-      end
-
-      def create_scripts(m = self, rails2 = false)
-        if rails2
+      def create_scripts(m)
+        if rails2?
           m.file 'script/cucumber', 'script/cucumber', {
             :chmod => 0755, :shebang => options[:shebang] == DEFAULT_SHEBANG ? nil : options[:shebang]
           }
@@ -60,8 +57,8 @@ module Cucumber
         end
       end
 
-      def create_step_definitions(m = self, rails2 = false)
-        if rails2
+      def create_step_definitions(m)
+        if rails2?
           m.directory 'features/step_definitions'
         else
           m.empty_directory 'features/step_definitions'
@@ -73,8 +70,8 @@ module Cucumber
         end
       end
 
-      def create_feature_support(m = self, rails2 = false)
-        if rails2
+      def create_feature_support(m)
+        if rails2?
           m.directory 'features/support'
           m.file      'support/paths.rb', 'features/support/paths.rb'
 
@@ -95,8 +92,8 @@ module Cucumber
         end
       end
 
-      def create_tasks(m = self, rails2 = false)
-        if rails2
+      def create_tasks(m)
+        if rails2?
           m.directory 'lib/tasks'
         else
           m.empty_directory 'lib/tasks'
@@ -105,7 +102,7 @@ module Cucumber
         m.template 'tasks/cucumber.rake.erb', 'lib/tasks/cucumber.rake'
       end
 
-      def create_database(m = self, rails2 = false)
+      def create_database(m)
         unless File.read('config/database.yml').include? 'cucumber:'
           m.gsub_file 'config/database.yml', /^test:.*\n/, "test: &test\n"
           m.gsub_file 'config/database.yml', /\z/, "\ncucumber:\n  <<: *test"
@@ -115,29 +112,15 @@ module Cucumber
         end
       end
 
-      def print_instructions
-        require 'cucumber/formatter/ansicolor'
-        extend Cucumber::Formatter::ANSIColor
-
-        if @default_driver
-          puts <<-WARNING
-
-    #{yellow_cukes(15)}
-
-                  #{yellow_cukes(1)}   D R I V E R   A L E R T    #{yellow_cukes(1)}
-
-    You didn't explicitly generate with --capybara or --webrat, so I looked at
-    your gems and saw that you had #{green(@default_driver.to_s)} installed, so I went with that.
-    If you want something else, be specific about it. Otherwise, relax.
-
-    #{yellow_cukes(15)}
+      protected
 
-    WARNING
+      def add_gem(*args)
+        if rails2?
+        else
+          self.gem(*args)
         end
       end
 
-      protected
-
       def detect_current_driver
         detect_in_env([['capybara', :capybara], ['webrat', :webrat]])
       end
@@ -162,6 +145,10 @@ module Cucumber
         options[:spork]
       end
 
+      def rails2?
+        defined?(Rails::Generator::Base) # In Rails3 it's Rails::Generators::Base (plural s)
+      end
+
       def embed_file(source, indent='')
         IO.read(File.join(self.class.source_root, source)).gsub(/^/, indent)
       end