cucumber-rails 0.3.0 → 1.0.0

data/features/select_dates.feature

@@ -0,0 +1,99 @@
+Feature: Select dates
+
+  Background: A simple calendar app
+    Given I have created a new Rails 3 app "rails-3-app" with cucumber-rails support
+  
+  Scenario: Select date and time
+    Given I successfully run `bundle exec rails g scaffold appointment name:string when:datetime`
+    And I write to "features/create_appointment.feature" with:
+      """
+      Feature: Create appointments
+        Scenario: Constitution on May 17
+          Given I am on the new appointment page
+          And I fill in "Norway's constitution" for "Name"
+          And I select "2009-02-20 15:10:00 UTC" as the "When" date and time
+          And I press "Create Appointment"
+          Then I should see "Norway's constitution"
+          And I should see "2009-02-20 15:10:00 UTC"
+      """
+    When I run `bundle exec rake db:migrate`
+    And I run `bundle exec rake cucumber`
+    Then it should pass with:
+      """
+      1 scenario (1 passed)
+      6 steps (6 passed)
+      """
+  
+  Scenario: Select date with label pointing to first select
+    Given I successfully run `bundle exec rails g scaffold appointment name:string when:date`
+    And I write to "features/create_appointment.feature" with:
+      """
+      Feature: Create appointments
+        Scenario: Constitution on May 17
+          Given I am on the new appointment page
+          And I fill in "Norway's constitution" for "Name"
+          And I select "2009-02-20" as the "When" date
+          And I press "Create Appointment"
+          Then I should see "Norway's constitution"
+          And I should see "2009-02-20"
+      """
+    And I write to "app/views/appointments/_form.html.erb" with:
+      """
+      <%= form_for(@appointment) do |f| %>
+        <div class="field">
+          <%= f.label :name %><br />
+          <%= f.text_field :name %>
+        </div>
+        <div class="field">
+          <%= f.label :when, :for => "appointment_when_1i" %><br />
+          <%= f.date_select :when %>
+        </div>
+        <div class="actions">
+          <%= f.submit %>
+        </div>
+      <% end %>
+      """
+    When I run `bundle exec rake db:migrate`
+    And I run `bundle exec rake cucumber`
+    Then it should pass with:
+      """
+      1 scenario (1 passed)
+      6 steps (6 passed)
+      """
+      
+  Scenario: Select date when the order of fields is changed and label is set to the first select
+    Given I successfully run `bundle exec rails g scaffold appointment name:string when:date`
+    And I write to "features/create_appointment.feature" with:
+      """
+      Feature: Create appointments
+        Scenario: Constitution on May 17
+          Given I am on the new appointment page
+          And I fill in "Norway's constitution" for "Name"
+          And I select "2009-02-20" as the "When" date
+          And I press "Create Appointment"
+          Then I should see "Norway's constitution"
+          And I should see "2009-02-20"
+      """
+    And I write to "app/views/appointments/_form.html.erb" with:
+      """
+      <%= form_for(@appointment) do |f| %>
+        <div class="field">
+          <%= f.label :name %><br />
+          <%= f.text_field :name %>
+        </div>
+        <div class="field">
+          <%= f.label :when, :for => "appointment_when_2i" %><br />
+          <%= f.date_select :when, :order=>[:month, :day, :year] %>
+        </div>
+        <div class="actions">
+          <%= f.submit %>
+        </div>
+      <% end %>
+      """
+    When I run `bundle exec rake db:migrate`
+    And I run `bundle exec rake cucumber`
+    Then it should pass with:
+      """
+      1 scenario (1 passed)
+      6 steps (6 passed)
+      """

data/features/step_definitions/cucumber_rails_steps.rb

@@ -1,7 +1,81 @@
-Given /^I symlink this repo to "([^\"]*)"$/ do |target|
-  source = File.expand_path('../../..', __FILE__)
-  in_current_dir do
-    target = File.expand_path(target)
-    FileUtils.ln_s(source, target)
-  end
+Given /^I have created a new Rails 3 app "([^"]*)" with cucumber\-rails support$/ do |app_name|
+  steps %Q{
+    When I successfully run `rails new #{app_name}`
+    Then it should pass with:
+      """
+      README
+      """
+    And I cd to "#{app_name}"
+    And I append to "Gemfile" with:
+      """
+      gem "cucumber-rails", :group => :test, :path => "../../.."
+      gem "capybara", :group => :test
+      gem "rspec-rails", :group => :test
+      gem "database_cleaner", :group => :test
+      gem 'factory_girl', :group => :test
+
+      """
+    And I successfully run `bundle exec rails generate cucumber:install`
+  }
 end
+
+Given /^a project without ActiveRecord$/ do
+  steps %Q{
+    Given I successfully run `rails new cuke-app`
+    And I cd to "cuke-app"
+    And I append to "Gemfile" with:
+      """
+      gem "cucumber-rails", :group => :test, :path => "../../.."
+      gem "capybara", :group => :test
+      gem "rspec-rails", :group => :test
+
+      """
+    And I successfully run `bundle exec rails generate cucumber:install`
+    And I overwrite "features/support/env.rb" with:
+      """
+      require 'cucumber/rails'
+
+      """
+
+    And I write to "config/application.rb" with:
+      """
+      require File.expand_path('../boot', __FILE__)
+
+      require 'action_controller/railtie'
+      require 'action_mailer/railtie'
+      require 'active_resource/railtie'
+      require 'rails/test_unit/railtie'
+
+      Bundler.require(:default, Rails.env) if defined?(Bundler)
+
+      module CukeApp
+        class Application < Rails::Application
+          config.encoding = "utf-8"
+          config.filter_parameters += [:password]
+        end
+      end
+
+      """
+    And I remove the file "config/database.yml"
+  }
+end
+
+And /^a cukes resource$/ do
+  steps %Q{
+    Given I write to "config/routes.rb" with:
+      """
+      CukeApp::Application.routes.draw do
+        resources :cukes
+      end
+
+      """
+    And I write to "app/controllers/cukes_controller.rb" with:
+      """
+      class CukesController < ApplicationController
+        def index
+        end
+      end
+
+      """
+  }
+end

data/features/support/env.rb

@@ -1,4 +1,10 @@
 $:.unshift(File.dirname(__FILE__) + '/../../lib')
 require 'rubygems'
-require 'spec'
-require 'aruba'
+require 'bundler/setup'
+require 'rspec/expectations'
+require 'aruba/cucumber'
+
+Before do
+  @aruba_timeout_seconds = 120 # A long time needed some times
+  unset_bundler_env_vars
+end

data/features/test_unit.feature

@@ -0,0 +1,43 @@
+Feature: Run with Test::Unit
+
+  Scenario: Delete a widget
+    Given I have created a new Rails 3 app "widgets" with cucumber-rails support
+    And I overwrite "Gemfile" with:
+       """
+       gem 'rails'
+       gem 'sqlite3'
+       gem "cucumber-rails", :group => :test, :path => "../../.."
+       gem "capybara", :group => :test
+       gem "database_cleaner", :group => :test
+       gem 'factory_girl', :group => :test
+
+       """
+    And I successfully run `rails generate scaffold widget name:string`
+    And I write to "features/f.feature" with:
+      """
+      Feature: Widget inventory
+        Scenario: Delete a widget
+          Given there is a widget named "wrench"
+          When I go to the widgets page
+          Then I should see "wrench"
+      """
+    And I write to "features/step_definitions/s.rb" with:
+      """
+      Given /^there is a widget named "([^"]*)"$/ do |name|
+        Factory(:widget, :name => name)
+      end
+      """
+    And I write to "features/support/factories.rb" with:
+      """
+      Factory.define :widget do |f| 
+        f.name 'testwidget'
+      end
+      """
+    When I run `bundle exec rake db:migrate`
+    And I run `bundle exec rake cucumber`
+    Then it should pass with:
+       """
+       1 scenario (1 passed)
+       3 steps (3 passed)
+       """
+

data/lib/cucumber/rails/capybara/javascript_emulation.rb

@@ -0,0 +1,83 @@
+module Cucumber
+  module Rails
+    module Capybara
+      module JavascriptEmulation
+        def self.included(base)
+          base.class_eval do
+            alias_method :click_without_javascript_emulation, :click
+            alias_method :click, :click_with_javascript_emulation
+          end
+        end
+  
+        def click_with_javascript_emulation
+          if link_with_non_get_http_method?
+            ::Capybara::RackTest::Form.new(driver, js_form(element_node.document, self[:href], emulated_method)).submit(self)
+          else
+            click_without_javascript_emulation
+          end
+        end
+
+        private
+
+        def js_form(document, action, emulated_method, method = 'POST')
+          js_form = document.create_element('form')
+          js_form['action'] = action
+          js_form['method'] = method
+
+          if emulated_method and emulated_method.downcase != method.downcase
+            input = document.create_element('input')
+            input['type'] = 'hidden'
+            input['name'] = '_method'
+            input['value'] = emulated_method
+            js_form.add_child(input)
+          end
+        
+          js_form
+        end
+
+        def link_with_non_get_http_method?
+          if ::Rails.version.to_f >= 3.0
+            tag_name == 'a' && element_node['data-method'] && element_node['data-method'] =~ /(?:delete|put|post)/
+          else
+            tag_name == 'a' && element_node['onclick'] && element_node['onclick'] =~ /var f = document\.createElement\('form'\); f\.style\.display = 'none';/
+          end
+        end
+
+        def emulated_method
+          if ::Rails.version.to_f >= 3.0
+            element_node['data-method']
+          else
+            element_node['onclick'][/m\.setAttribute\('value', '([^']*)'\)/, 1]
+          end
+        end
+
+        def element_node
+          if self.respond_to? :native
+            self.native
+          else
+            warn "DEPRECATED: cucumber-rails loves you, just not your version of Capybara. Please update Capybara to >= 0.4.0"
+            self.node
+          end
+        end
+      end
+    end
+  end
+end
+
+class Capybara::RackTest::Node
+  include ::Cucumber::Rails::Capybara::JavascriptEmulation
+end
+
+Before('~@no-js-emulation') do
+  # Enable javascript emulation
+  ::Capybara::RackTest::Node.class_eval do
+    alias_method :click, :click_with_javascript_emulation
+  end
+end
+
+Before('@no-js-emulation') do
+  # Disable javascript emulation
+  ::Capybara::RackTest::Node.class_eval do
+    alias_method :click, :click_without_javascript_emulation
+  end
+end

data/lib/cucumber/rails/capybara/select_dates_and_times.rb

@@ -0,0 +1,50 @@
+module Cucumber
+  module Rails
+    module Capybara
+      module SelectDatesAndTimes
+        def select_date(field, options = {})
+          date        = Date.parse(options[:with])
+          base_dom_id = get_base_dom_id_from_label_tag(field)
+
+          find(:xpath, "//select[@id='#{base_dom_id}_1i']").select(date.year.to_s)
+          find(:xpath, "//select[@id='#{base_dom_id}_2i']").select(I18n.l date, :format => '%B')
+          find(:xpath, "//select[@id='#{base_dom_id}_3i']").select(date.day.to_s)
+        end
+      
+        def select_time(field, options = {})
+          time        = Time.zone.parse(options[:with])
+          base_dom_id = get_base_dom_id_from_label_tag(field)
+
+          find(:xpath, "//select[@id='#{base_dom_id}_4i']").select(time.hour.to_s.rjust(2, '0'))
+          find(:xpath, "//select[@id='#{base_dom_id}_5i']").select(time.min.to_s.rjust(2,  '0'))
+        end
+      
+        def select_datetime(field, options = {})
+          select_date(field, options)
+          select_time(field, options)
+        end
+
+        private
+
+        # @example "event_starts_at_"
+        def get_base_dom_id_from_label_tag(field)
+          find(:xpath, "//label[contains(., '#{field}')]")['for'].gsub(/(_[1-5]i)$/, '')
+        end
+      end
+    end
+  end
+end
+
+World(::Cucumber::Rails::Capybara::SelectDatesAndTimes)
+
+When /^(?:|I )select "([^"]+)" as the "([^"]+)" time$/ do |time, selector|
+  select_time(selector, :with => time)
+end
+
+When /^(?:|I )select "([^"]+)" as the "([^"]+)" date$/ do |date, selector|
+  select_date(selector, :with => date)
+end
+
+When /^(?:|I )select "([^"]+)" as the "([^"]+)" date and time$/ do |datetime, selector|
+  select_datetime(selector, :with => datetime)
+end

data/lib/cucumber/rails/capybara.rb

@@ -0,0 +1,6 @@
+require 'capybara'
+require 'capybara/rails'
+require 'capybara/cucumber'
+require 'capybara/session'
+require 'cucumber/rails/capybara/javascript_emulation'
+require 'cucumber/rails/capybara/select_dates_and_times'

data/lib/cucumber/rails/hooks/active_record.rb

@@ -0,0 +1,14 @@
+if defined?(ActiveRecord::Base)
+  require 'cucumber/rails3/active_record'
+
+  Before('@javascript') do
+    # Forces all threads to share the same connection. This works on
+    # Capybara because it starts the web server in a thread.
+    ActiveRecord::Base.shared_connection = ActiveRecord::Base.connection
+  end
+
+  Before('~@javascript') do
+    # Do not use a shared connection unless we're in a @javascript scenario
+    ActiveRecord::Base.shared_connection = nil
+  end
+end

data/lib/cucumber/rails/hooks/allow_rescue.rb

@@ -0,0 +1,8 @@
+Before('@allow-rescue') do
+  @__orig_allow_rescue = ActionController::Base.allow_rescue
+  ActionController::Base.allow_rescue = true
+end
+
+After('@allow-rescue') do
+  ActionController::Base.allow_rescue = @__orig_allow_rescue
+end

data/lib/cucumber/rails/hooks/database_cleaner.rb

@@ -0,0 +1,13 @@
+begin
+  require 'database_cleaner'
+
+  Before do
+    DatabaseCleaner.start
+  end
+
+  After do
+    DatabaseCleaner.clean
+  end
+
+rescue LoadError => ignore_if_database_cleaner_not_present
+end

data/lib/cucumber/rails/hooks/mail.rb

@@ -0,0 +1,5 @@
+if defined?(ActionMailer::Base)
+  Before do
+    ActionMailer::Base.deliveries = []
+  end
+end

data/lib/cucumber/rails/hooks.rb

@@ -0,0 +1,4 @@
+require 'cucumber/rails/hooks/active_record'
+require 'cucumber/rails/hooks/database_cleaner'
+require 'cucumber/rails/hooks/allow_rescue'
+require 'cucumber/rails/hooks/mail'

data/lib/cucumber/rails/rspec.rb

@@ -1,13 +1,11 @@
 require 'cucumber/rails/world'
 
 begin
-  require 'rspec/expectations'
-  require 'rspec/rails'
+  require 'rspec/rails/matchers'
 
   [Cucumber::Rails::World, ActionController::Integration::Session].each do |klass|
     klass.class_eval do
-      include Rspec::Matchers
-      include Rspec::Rails::Matchers
+      include RSpec::Matchers
     end
   end
 rescue LoadError => try_rspec_1
@@ -17,7 +15,7 @@ rescue LoadError => try_rspec_1
   [Cucumber::Rails::World, ActionController::Integration::Session].each do |klass|
     klass.class_eval do
       include Spec::Matchers
-      include Spec::Rails::Matchers
+      include Spec::Rails::Matchers if defined?(Spec::Rails::Matchers)
     end
   end
-end
+end

data/lib/cucumber/rails/world.rb

@@ -1,43 +1,21 @@
-unless defined?(Test)
-  begin
-    require 'spec/test/unit'
-  rescue LoadError => ignore_if_rspec_not_installed
-  end
-end
-
-if defined?(ActiveRecord::Base)
-  if Rails.version.to_f >= 3.0
-    require 'rails/test_help' 
-  else
-    require 'test_help' 
-  end
-else
-  # I can't do rescue LoadError because in this files could be loaded
-  # from rails gem (ie. load actionpack 2.3.5 if rubygems are not disabled)
-  if Rails.version.to_f < 3.0
-    require 'action_controller/test_process'
-    require 'action_controller/integration'
-  else
-    require 'action_dispatch/testing/test_process'
-    require 'action_dispatch/testing/integration'
-  end
-end
-
-require 'cucumber/rails/test_unit'
-require 'cucumber/rails/action_controller'
-
-
-if (::Rails.respond_to?(:application) && !(::Rails.application.config.cache_classes)) || 
-  (!(::Rails.respond_to?(:application)) && ::Rails.respond_to?(:configuration) && !(::Rails.configuration.cache_classes))
-  warn "WARNING: You have set Rails' config.cache_classes to false (most likely in config/environments/cucumber.rb).  This setting is known to break Cucumber's use_transactional_fixtures method. Set config.cache_classes to true if you want to use transactional fixtures.  For more information see https://rspec.lighthouseapp.com/projects/16211/tickets/165."
+begin
+  # Try to load it so we can assign @_result below if needed.
+  require 'test/unit/testresult'
+rescue LoadError => ignore
 end
 
 module Cucumber #:nodoc:
-  module Rails
-    class World < ActionController::IntegrationTest
+  module Rails #:nodoc:
+    class World < ActionController::IntegrationTest #:nodoc:
+      include Rack::Test::Methods
       include ActiveSupport::Testing::SetupAndTeardown if ActiveSupport::Testing.const_defined?("SetupAndTeardown")
+
       def initialize #:nodoc:
-        @_result = Test::Unit::TestResult.new
+        @_result = Test::Unit::TestResult.new if defined?(Test::Unit::TestResult)
+      end
+
+      if !defined?(ActiveRecord::Base)
+        def self.fixture_table_names; []; end # Workaround for projects that don't use ActiveRecord
       end
     end
   end

data/lib/cucumber/rails.rb

@@ -0,0 +1,8 @@
+require 'rails'
+require 'cucumber/rails3'
+
+require 'cucumber/rails/world'
+require 'cucumber/rails/hooks'
+require 'cucumber/rails/capybara'
+
+require 'cucumber/web/tableish'

data/lib/cucumber/rails3/action_controller.rb

@@ -0,0 +1,12 @@
+ActionController::Base.class_eval do
+  cattr_accessor :allow_rescue
+end
+
+class ActionDispatch::ShowExceptions
+  alias __cucumber_orig_call__ call
+  
+  def call(env)
+    env['action_dispatch.show_exceptions'] = !!ActionController::Base.allow_rescue
+    __cucumber_orig_call__(env)
+  end
+end

data/lib/cucumber/rails3/active_record.rb

@@ -0,0 +1,8 @@
+class ActiveRecord::Base
+  mattr_accessor :shared_connection
+  @@shared_connection = nil
+
+  def self.connection
+    @@shared_connection || retrieve_connection
+  end
+end

data/lib/cucumber/rails3/application.rb

@@ -0,0 +1,17 @@
+require 'rails/application'
+
+# Make sure the ActionDispatch::ShowExceptions middleware is always enabled,
+# regardless of what is in config/environments/test.rb
+# Instead we are overriding ActionDispatch::ShowExceptions to be able to
+# toggle whether or not exceptions are raised.
+class Rails::Application
+  alias __cucumber_orig_initialize__ initialize!
+  
+  def initialize!
+    ad = config.action_dispatch
+    def ad.show_exceptions
+      true
+    end
+    __cucumber_orig_initialize__
+  end
+end

data/lib/cucumber/rails3.rb

@@ -0,0 +1,16 @@
+require 'cucumber/rails3/application'
+ENV["RAILS_ENV"] ||= "test"
+ENV["RAILS_ROOT"] ||= File.expand_path(File.dirname(caller.detect{|f| f =~ /\/env\.rb:/}) + '/../..')
+require File.expand_path(ENV["RAILS_ROOT"] + '/config/environment')
+require 'cucumber/rails3/action_controller'
+
+if defined?(ActiveRecord::Base)
+  require 'rails/test_help'
+else
+  require 'action_dispatch/testing/test_process'
+  require 'action_dispatch/testing/integration'
+end
+
+if !Rails.application.config.cache_classes
+  warn "WARNING: You have set Rails' config.cache_classes to false (most likely in config/environments/cucumber.rb).  This setting is known to cause problems with database transactions. Set config.cache_classes to true if you want to use transactions.  For more information see https://rspec.lighthouseapp.com/projects/16211/tickets/165."
+end

data/lib/cucumber/web/tableish.rb

@@ -3,7 +3,7 @@ require 'nokogiri'
 module Cucumber
   module Web
     module Tableish
-      # This method returns an Array of Array of String, using CSS3 selectors. 
+      # This method returns an Array of Array of String, using CSS3 selectors.
       # This is particularly handy when using Cucumber's Table#diff! method.
       #
       # The +row_selector+ argument must be a String, and picks out all the rows
@@ -51,27 +51,68 @@ module Cucumber
 
       def _tableish(html, row_selector, column_selectors) #:nodoc
         doc = Nokogiri::HTML(html)
-        column_count = nil
-        doc.search(row_selector).map do |row|
+        spans = nil
+        max_cols = 0
+
+        # Parse the table.
+        rows = doc.search(row_selector).map do |row|
           cells = case(column_selectors)
           when String
             row.search(column_selectors)
           when Proc
             column_selectors.call(row)
           end
-          column_count ||= cells.length
-          (0...column_count).map do |n|
-            cell = cells[n]
-            case(cell)
+
+          # TODO: max_cols should be sum of colspans
+          max_cols = [max_cols, cells.length].max
+
+          spans ||= Array.new(max_cols, 1)
+
+          cell_index = 0
+
+          cells = (0...spans.length).inject([]) do |array, n|
+            span = spans[n]
+
+            cell = if span > 1
+              row_span, col_span = 1, 1
+              nil
+            else
+              cell = cells[cell_index]
+
+              row_span, col_span = _parse_spans(cell)
+
+              if col_span > 1
+                ((n + 1)...(n + col_span)).each do |m|
+                  spans[m] = row_span + 1
+                end
+              end
+
+              cell_index +=1
+              cell
+            end
+
+            spans[n] = row_span > 1 ? row_span : ([span - 1, 1].max)
+
+            array << case cell
               when String then cell.strip
               when nil then ''
               else cell.text.strip
             end
+
+            array
           end
+
+          cells
         end
       end
-    end    
+
+      def _parse_spans(cell)
+        cell.is_a?(Nokogiri::XML::Node) ?
+          [cell.attributes['rowspan'].to_s.to_i || 1, cell.attributes['colspan'].to_s.to_i || 1] :
+          [1, 1]
+      end
+    end
   end
 end
 
-World(Cucumber::Web::Tableish)
+World(Cucumber::Web::Tableish)