cucumber-nc 0.0.1 → 0.0.2

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 56e1d5715e8e716553cda195cbe20cd572843ce1
+  data.tar.gz: 45588b64495e10b017451c202a03487e77babeda
+SHA512:
+  metadata.gz: 5b043be336b7bd257a351acedf9593a274bb4cd2493b95f78d0e96f2fadb1488a805ec329a3865e138f87859815b2557501b302d208e68ece00a4bb4c9c41006
+  data.tar.gz: 2a38bcaca654921809be05be739ab9f627e6ad4e881bca49f7f82735dd617d3b9aff5370e952eaea924b2a2bbf81830e96a50f3c4a8f365843a621b8cc1c2744

data/.gitignore

@@ -1,2 +1,4 @@
-Gemfile.lock
-pkg
+/Gemfile.lock
+/pkg
+/.ruby-gemset
+/.ruby-version

data/CHANGELOG.md

@@ -0,0 +1,11 @@
+# Changes
+
+## v0.0.2, 2014-04-02
+
+* Add `pry` as a development dependency in Gemfile.
+* Update `.gitignore` to be friendly to `RVM` et al.
+* Merge pull request #1: "Update notification body and fix count of failed scenarios"
+
+## v0.0.1, 2012-08-26
+
+Initial release.

data/Gemfile

@@ -1,8 +1,10 @@
-source :rubygems
+source "https://rubygems.org"
 
 gemspec
 
 group :development, :test do
   gem 'rake'
   gem 'rspec'
+
+  gem 'pry'
 end

data/cucumber-nc.gemspec

@@ -1,7 +1,7 @@
 # -*- encoding: utf-8 -*-
 Gem::Specification.new do |gem|
   gem.name          = 'cucumber-nc'
-  gem.version       = '0.0.1'
+  gem.version       = '0.0.2'
   gem.authors       = ['Jon Frisby', 'Odin Dutton']
   gem.email         = ['jfrisby@mrjoy.com', 'odindutton@gmail.com']
   gem.description   = 'https://github.com/MrJoy/cucumber-nc'

data/lib/cucumber_nc.rb

@@ -48,13 +48,13 @@ class CucumberNc
     (num == 1) ? str : "#{str}s"
   end
 
-  def summary_line(features, failures)
+  def summary_line(features)
     scenarios = step_mother.scenarios.count
-    scenarios_failed = failures.count
+    scenarios_failed = step_mother.scenarios(:failed).count
     scenarios_undefined = step_mother.scenarios(:undefined).count
     scenarios_pending = step_mother.scenarios(:pending).count
-    scenarios_passing = step_mother.steps(:passed).count -
-      (scenarios_failed + scenarios_undefined + scenarios_pending)
+    scenarios_passing = step_mother.scenarios(:passed).count
+
     steps = step_mother.steps.count
     steps_failed = step_mother.steps(:failed).count
     steps_skipped = step_mother.steps(:skipped).count
@@ -62,49 +62,53 @@ class CucumberNc
     steps_pending = step_mother.steps(:pending).count
     steps_passing = step_mother.steps(:passed).count
 
-    # 5 scenarios (1 undefined, 3 pending, 1 passed)
-    # 35 steps (23 skipped, 1 undefined, 3 pending, 8 passed)
-    # 0m0.024s
-
-    # 5 scenarios (1 undefined, 3 pending, 1 passed)
-    # 35 steps (26 skipped, 1 undefined, 3 pending, 5 passed)
-
     counts = []
-    counts << "#{scenarios_failed} fail" if(scenarios_failed > 0)
-    counts << "#{scenarios_undefined} undef" if(scenarios_undefined > 0)
-    counts << "#{scenarios_pending} pend" if(scenarios_pending > 0)
-    counts << "#{scenarios_passing} pass"
+    counts << "#{scenarios_undefined} undefined" if scenarios_undefined > 0
+    counts << "#{scenarios_pending} pending" if scenarios_pending > 0
+    counts << "#{scenarios_failed} failed" if scenarios_failed > 0
+    counts << "#{scenarios_passing} passed" if scenarios_passing > 0
 
-    summary = "#{scenarios} #{pluralize(scenarios, "scenario")} (#{counts.join(', ')})\n\n"
+    # 5 scenarios (1 undefined, 3 pending, 1 passed)
+    case counts.count
+    when 4
+      summary = "#{scenarios} #{pluralize(scenarios, "scenario")} (#{counts[0]}, #{counts[1]}, #{counts[2]},\n#{counts[3]})\n"
+    else
+      summary = "#{scenarios} #{pluralize(scenarios, "scenario")} (#{counts.join(', ')})\n"
+    end
 
     counts = []
-    counts << "#{steps_failed} fail" if(steps_failed > 0)
-    counts << "#{steps_skipped} skip" if(steps_skipped > 0)
-    counts << "#{steps_undefined} undef" if(steps_undefined > 0)
-    counts << "#{steps_pending} pend" if(steps_pending > 0)
-    counts << "#{steps_passing} pass"
+    counts << "#{steps_undefined} undefined" if steps_undefined > 0
+    counts << "#{steps_skipped} skipped" if steps_skipped > 0
+    counts << "#{steps_pending} pending" if steps_pending > 0
+    counts << "#{steps_failed} failed" if steps_failed > 0
+    counts << "#{steps_passing} passed" if steps_passing > 0
 
-    summary << "#{steps} #{pluralize(steps, "step")} (#{counts.join(', ')})"
+    # 35 steps (23 skipped, 1 undefined, 3 pending, 8 passed)
+    case counts.count
+    when 4
+      summary << "#{steps} #{pluralize(steps, "step")} (#{counts[0]}, #{counts[1]}, #{counts[2]},\n#{counts[3]})"
+    when 5
+      summary << "#{steps} #{pluralize(steps, "step")} (#{counts[0]}, #{counts[1]}, #{counts[2]},\n#{counts[3]}, #{counts[4]})"
+    else
+      summary << "#{steps} #{pluralize(steps, "step")} (#{ counts.join(', ') })"
+    end
 
     summary
   end
 
   def print_summary(features)
-    failures = step_mother.
-      scenarios(:failed).
-      select { |s| s.is_a?(Cucumber::Ast::Scenario) || s.is_a?(Cucumber::Ast::OutlineTable::ExampleRow) }.
-      collect { |s| (s.is_a?(Cucumber::Ast::OutlineTable::ExampleRow)) ? s.scenario_outline : s }
-
     body = []
-    body << "Finished in #{format_duration(features.duration)}"
-    body << summary_line(features, failures)
+    body << summary_line(features)
+
+    # 0m0.024s
+    body << "#{ format_duration(features.duration) }"
 
     name = File.basename(File.expand_path('.'))
 
-    title = if(!failures.empty?)
-      "\u26D4 #{name}: #{failures.count} failed #{pluralize(failures.count, 'scenario')}"
+    title = unless step_mother.scenarios(:failed).empty?
+      "\u26D4 #{ name }: #{ step_mother.scenarios(:failed).count } failed #{ pluralize(step_mother.scenarios(:failed).count, 'scenario') }"
     else
-      "\u2705 #{name}: Success"
+      "\u2705 #{ name }: Success"
     end
 
     say title, body.join("\n")

data/spec/cucumbernc_spec.rb

@@ -1,9 +1,73 @@
 require 'cucumber_nc'
+require 'set'
+require 'bigdecimal'
+
+class Duration
+  attr_accessor :duration
+  def initialize(d)
+    @duration = BigDecimal.new(d, 4)
+  end
+end
+
+class StepMocker
+  ALLOWED_SCENARIO_STATUSES=Set.new([:passed, :pending, :undefined, :failed])
+  class << ALLOWED_SCENARIO_STATUSES; def to_s; self.to_a.join(", "); end; end
+  ALLOWED_STEP_STATUSES=Set.new([:passed, :pending, :undefined, :skipped, :failed])
+  class << ALLOWED_STEP_STATUSES; def to_s; self.to_a.join(", "); end; end
+
+  def initialize
+    clear_mocks
+  end
+
+  def scenarios(status=nil)
+    return self.data.
+      select { |scenario| status.nil? || scenario[:status] == status }
+  end
+
+  def steps(status=nil)
+    return self.data.
+      map { |scenario| scenario[:steps] }.
+      flatten.
+      select { |step| status.nil? || step == status }
+  end
+
+  def clear_mocks
+    self.data = []
+    return self
+  end
+
+  def add_scenario(status)
+    raise ArgumentError.new("Scenario status must be one of: #{ALLOWED_SCENARIO_STATUSES}, got '#{status}'!") unless(ALLOWED_SCENARIO_STATUSES.include?(status))
+    scenario_mock = {
+      :status => status,
+      :steps  => [],
+    }
+
+    class << scenario_mock[:steps]
+      def add_step(status)
+        raise ArgumentError.new("Step status must be one of: #{ALLOWED_STEP_STATUSES}, got '#{status}'!") unless(ALLOWED_STEP_STATUSES.include?(status))
+        self << status
+        return self
+      end
+    end
+
+    yield scenario_mock[:steps] if(block_given?)
+
+    self.data << scenario_mock
+    return self
+  end
+
+protected
+
+  attr_accessor :data
+end
 
 describe CucumberNc do
+  let(:step_mocker) do
+    StepMocker.new
+  end
+
   let(:formatter)   do
-    # TODO: Implement me....
-    #step_mocker =
     CucumberNc.new(step_mocker, nil, nil)
   end
 
@@ -13,30 +77,50 @@ describe CucumberNc do
   let(:success) { "\u2705" }
   let(:failure) { "\u26D4" }
 
-  it 'returns the summary' do
+  it 'gives TerminalNotifier an accurate summary' do
+    step_mocker.
+      clear_mocks.
+      add_scenario(:failed) do |mock|
+        mock.add_step(:passed)
+        mock.add_step(:failed)
+        mock.add_step(:pending)
+      end
+
     TerminalNotifier.should_receive(:notify).with(
-      "Finished in 0.0001 seconds\n3 examples, 1 failure, 1 pending",
-      :title => "#{failure} #{current_dir}: 1 failed example"
+      "1 scenario (1 failed)\n3 steps (1 pending, 1 failed, 1 passed)\n0.0m0.001s",
+      :title => "#{failure} #{current_dir}: 1 failed scenario"
     )
 
-    formatter.dump_summary(0.0001, 3, 1, 1)
+    formatter.send(:print_summary, Duration.new(0.001))
   end
 
-  it 'returns a failing notification' do
+  it 'properly indicates failure to TerminalNotifier' do
+    step_mocker.
+      clear_mocks.
+      add_scenario(:failed) do |mock|
+        mock.add_step(:failed)
+      end
+
     TerminalNotifier.should_receive(:notify).with(
-      "Finished in 0.0001 seconds\n1 example, 1 failure",
-      :title => "#{failure} #{current_dir}: 1 failed example"
+      "1 scenario (1 failed)\n1 step (1 failed)\n0.0m0.001s",
+      :title => "#{failure} #{current_dir}: 1 failed scenario"
     )
 
-    formatter.dump_summary(0.0001, 1, 1, 0)
+    formatter.send(:print_summary, Duration.new(0.001))
   end
 
-  it 'returns a success notification' do
+  it 'properly indicates success to TerminalNotifier' do
+    step_mocker.
+      clear_mocks.
+      add_scenario(:passed) do |mock|
+        mock.add_step(:passed)
+      end
+
     TerminalNotifier.should_receive(:notify).with(
-      "Finished in 0.0001 seconds\n1 example, 0 failures",
+      "1 scenario (1 passed)\n1 step (1 passed)\n0.0m0.001s",
       :title => "#{success} #{current_dir}: Success"
     )
 
-    formatter.dump_summary(0.0001, 1, 0, 0)
+    formatter.send(:print_summary, Duration.new(0.001))
   end
 end

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-nc
 version: !ruby/object:Gem::Version
-  version: 0.0.1
-  prerelease: 
+  version: 0.0.2
 platform: ruby
 authors:
 - Jon Frisby
@@ -10,38 +9,34 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-26 00:00:00.000000000 Z
+date: 2014-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: terminal-notifier
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.4.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.4.2
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.2'
 description: https://github.com/MrJoy/cucumber-nc
@@ -52,7 +47,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
@@ -62,28 +58,26 @@ files:
 - spec/cucumbernc_spec.rb
 homepage: https://github.com/MrJoy/cucumber-nc
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Cucumber formatter for Mountain Lion's Notification Center
 test_files:
 - spec/cucumbernc_spec.rb
-has_rdoc: