cucumber-messages 13.0.1 → 14.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1d5ddca46fd45d4ac2df0ffb741967ce6bd7ea54b8206fa7e73ca5223c15698d
-  data.tar.gz: c445cb77ec2b8ae74ce8983edbdfd87981fd9fc3a4c47a08d84c55814285d24f
+  metadata.gz: 5d72085d7cb48f631fd458b59ff369badf20132bf9064b7d2304a48c367724ea
+  data.tar.gz: ddd1d08b8fa9927b240f255a153e3110d3256988882746adbccaf34c3536d0d1
 SHA512:
-  metadata.gz: 343d47e6ed010e2e4b3ce7a15419d3a65c8edaa1c0bdc19af6a42442018f82b0e07925ddda5f288b8b4db7565079f3a4c27c40da72ad7061355e1ab1243ba1b2
-  data.tar.gz: 8d6b41fdced719587634791c6186bb5ee5f7e9582a31caadec6ba6e207756d45d02947021103aeb35be1ec419152a2496179fbfae90fd2c8e7d9b6e19709bfdc
+  metadata.gz: e47d90a13d38574b82c6df4b7e22ac29063aa8b7dae4e48eafdaba907ccaef1ef18381f4d779b84430fc5b0046e49c999901baf394382c796fb395a9702567e2
+  data.tar.gz: b8eecf47cc0e6b4f76fba0344c697017cfc2e0ff0e67903f8b12806429509b3d9e820b82f66b8a24acfa36bc5a0564bc08472baa6a746b99aaa241eeceeb7894

data/VERSION

@@ -1 +1 @@
-13.0.1
+14.0.1

data/lib/cucumber/messages.pb.rb

@@ -365,6 +365,7 @@ module Cucumber
       optional :string, :media_type, 5
       optional ::Cucumber::Messages::Attachment::ContentEncoding, :content_encoding, 6
       optional :string, :file_name, 7
+      optional :string, :url, 8
     end
 
     class Pickle

data/lib/cucumber/messages/ndjson_to_message_enumerator.rb

@@ -5,8 +5,13 @@ module Cucumber
     class NdjsonToMessageEnumerator < Enumerator
       def initialize(io)
         super() do |yielder|
-          io.each_line do |json|
-            m = Cucumber::Messages::Envelope.from_json(json)
+          io.each_line do |line|
+            next if line.strip.empty?
+            begin
+              m = Cucumber::Messages::Envelope.from_json(line)
+            rescue => e
+              raise "Not JSON: #{line.strip}"
+            end
             yielder.yield(m)
           end
         end

data/spec/cucumber/messages/ndjson_serialization_spec.rb

@@ -69,6 +69,22 @@ module Cucumber
         expect(incoming_messages.to_a).to(eq(outgoing_messages))
       end
 
+      it "ignores empty lines" do
+        outgoing_messages = [
+          Envelope.new(source: Source.new(data: 'Feature: Hello')),
+          Envelope.new(attachment: Attachment.new(binary: [1,2,3,4].pack('C*')))
+        ]
+
+        io = StringIO.new
+        write_outgoing_messages(outgoing_messages, io)
+        io.write("\n\n")
+
+        io.rewind
+        incoming_messages = NdjsonToMessageEnumerator.new(io)
+
+        expect(incoming_messages.to_a).to(eq(outgoing_messages))
+      end
+
       it "ignores missing fields" do
         io = StringIO.new
         io.puts('{"unused": 99}')
@@ -79,6 +95,16 @@ module Cucumber
         expect(incoming_messages.to_a).to(eq([Envelope.new]))
       end
 
+      it "includes offending line in error message" do
+        io = StringIO.new
+        io.puts('BLA BLA')
+
+        io.rewind
+        incoming_messages = NdjsonToMessageEnumerator.new(io)
+
+        expect { incoming_messages.to_a }.to(raise_error('Not JSON: BLA BLA'))
+      end
+
       def write_outgoing_messages(messages, out)
         messages.each do |message|
           message.write_ndjson_to(out)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-messages
 version: !ruby/object:Gem::Version
-  version: 13.0.1
+  version: 14.0.1
 platform: ruby
 authors:
 - Aslak Hellesøy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-07 00:00:00.000000000 Z
+date: 2021-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: protobuf-cucumber
@@ -39,7 +39,7 @@ dependencies:
         version: '13.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 13.0.1
+        version: 13.0.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -49,27 +49,27 @@ dependencies:
         version: '13.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 13.0.1
+        version: 13.0.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.9'
+        version: '3.10'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.9.0
+        version: 3.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.9'
+        version: '3.10'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.9.0
+        version: 3.10.0
 description: Protocol Buffer messages for Cucumber's inter-process communication
 email: cukes@googlegroups.com
 executables: []
@@ -122,11 +122,11 @@ requirements: []
 rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
-summary: cucumber-messages-13.0.1
+summary: cucumber-messages-14.0.1
 test_files:
-- spec/cucumber/messages/time_conversion_spec.rb
+- spec/capture_warnings.rb
+- spec/cucumber/messages/id_generator_spec.rb
 - spec/cucumber/messages/ndjson_serialization_spec.rb
-- spec/cucumber/messages/version_spec.rb
 - spec/cucumber/messages/protobuf_serialization_spec.rb
-- spec/cucumber/messages/id_generator_spec.rb
-- spec/capture_warnings.rb
+- spec/cucumber/messages/time_conversion_spec.rb
+- spec/cucumber/messages/version_spec.rb