cucumber-messages 13.0.0 → 14.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 713a658f8965cf01a13cf0a47b18305449c7ce32416b3919657375b524641031
-  data.tar.gz: 55768b934bdbd23530761c89b9d050df9ee9d94b591436984ce9db1d1888f152
+  metadata.gz: 209607333877ccdedc0b706c2b9e8ed04ae481bb0d69e0f97d9f2e8393a13f0a
+  data.tar.gz: ec4bfb28fca377b77d04112dcd2bcb8b25c0fcf3af46f77719240c046dd535e8
 SHA512:
-  metadata.gz: 0bee6fef69261e393e949d1e4604a2a5cf75425256b2807c14577c8f35dfcedf7d05c74a114a83c15402af8591cc38bdbbeb0d75f1fd2ae8c4b7800f38af1c45
-  data.tar.gz: 5ccb7800a8cffbfb9d540cdb4f4f318140c76fc6fb2ebfadda6ada4bb2854100c3cfdd5158a17efd4859cee13e229d7607f973608b8de5309326ee20595daa96
+  metadata.gz: e9b872a2ae10e5b6e6f0f7e21973bac443592652913f583fe0a173ff6a25c545dfa069baa508a1f868d22aecad4c718318947ac47ff0b24e45da4dd7118fb812
+  data.tar.gz: cf36c88ddf8c0291c4f633ec6b6ae19d1363473eb204962a6efa64b4c10c1fb027dfe1fda5446903405ac427a7a881085a0cdbe02b6d851b82f14ad31d89767f

data/VERSION

@@ -1 +1 @@
-13.0.0
+14.0.0

data/lib/cucumber/messages.pb.rb

@@ -365,6 +365,7 @@ module Cucumber
       optional :string, :media_type, 5
       optional ::Cucumber::Messages::Attachment::ContentEncoding, :content_encoding, 6
       optional :string, :file_name, 7
+      optional :string, :url, 8
     end
 
     class Pickle

data/lib/cucumber/messages/ndjson_to_message_enumerator.rb

@@ -5,8 +5,13 @@ module Cucumber
     class NdjsonToMessageEnumerator < Enumerator
       def initialize(io)
         super() do |yielder|
-          io.each_line do |json|
-            m = Cucumber::Messages::Envelope.from_json(json)
+          io.each_line do |line|
+            next if line.strip.empty?
+            begin
+              m = Cucumber::Messages::Envelope.from_json(line)
+            rescue => e
+              raise "Not JSON: #{line.strip}"
+            end
             yielder.yield(m)
           end
         end

data/spec/cucumber/messages/ndjson_serialization_spec.rb

@@ -69,6 +69,22 @@ module Cucumber
         expect(incoming_messages.to_a).to(eq(outgoing_messages))
       end
 
+      it "ignores empty lines" do
+        outgoing_messages = [
+          Envelope.new(source: Source.new(data: 'Feature: Hello')),
+          Envelope.new(attachment: Attachment.new(binary: [1,2,3,4].pack('C*')))
+        ]
+
+        io = StringIO.new
+        write_outgoing_messages(outgoing_messages, io)
+        io.write("\n\n")
+
+        io.rewind
+        incoming_messages = NdjsonToMessageEnumerator.new(io)
+
+        expect(incoming_messages.to_a).to(eq(outgoing_messages))
+      end
+
       it "ignores missing fields" do
         io = StringIO.new
         io.puts('{"unused": 99}')
@@ -79,6 +95,16 @@ module Cucumber
         expect(incoming_messages.to_a).to(eq([Envelope.new]))
       end
 
+      it "includes offending line in error message" do
+        io = StringIO.new
+        io.puts('BLA BLA')
+
+        io.rewind
+        incoming_messages = NdjsonToMessageEnumerator.new(io)
+
+        expect { incoming_messages.to_a }.to(raise_error('Not JSON: BLA BLA'))
+      end
+
       def write_outgoing_messages(messages, out)
         messages.each do |message|
           message.write_ndjson_to(out)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-messages
 version: !ruby/object:Gem::Version
-  version: 13.0.0
+  version: 14.0.0
 platform: ruby
 authors:
 - Aslak Hellesøy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-07 00:00:00.000000000 Z
+date: 2021-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: protobuf-cucumber
@@ -39,7 +39,7 @@ dependencies:
         version: '13.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 13.0.1
+        version: 13.0.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -49,27 +49,27 @@ dependencies:
         version: '13.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 13.0.1
+        version: 13.0.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.9'
+        version: '3.10'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.9.0
+        version: 3.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.9'
+        version: '3.10'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.9.0
+        version: 3.10.0
 description: Protocol Buffer messages for Cucumber's inter-process communication
 email: cukes@googlegroups.com
 executables: []
@@ -122,11 +122,11 @@ requirements: []
 rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
-summary: cucumber-messages-13.0.0
+summary: cucumber-messages-14.0.0
 test_files:
-- spec/cucumber/messages/time_conversion_spec.rb
+- spec/capture_warnings.rb
+- spec/cucumber/messages/id_generator_spec.rb
 - spec/cucumber/messages/ndjson_serialization_spec.rb
-- spec/cucumber/messages/version_spec.rb
 - spec/cucumber/messages/protobuf_serialization_spec.rb
-- spec/cucumber/messages/id_generator_spec.rb
-- spec/capture_warnings.rb
+- spec/cucumber/messages/time_conversion_spec.rb
+- spec/cucumber/messages/version_spec.rb