cucumber-cucumber-expressions 8.3.1 → 10.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d75b7265f9a2c2142d7733b064bb4e6ec6d317d1f32ba9e4148e42512b90a4df
-  data.tar.gz: c7f8fa3ce1e9eccaf40fcbfd9288ed8302ea1b13b2cb8aa385a64abaf94a2d15
+  metadata.gz: 5bba8569a4b4b7ae2a05e97b5d2e5f7b8c455b6843175475a6d55d4fb58fe8e5
+  data.tar.gz: 443f0d744039bdd83e4aff50ef3e71738222e3436d8c094195b1e916f33078cd
 SHA512:
-  metadata.gz: a05e6facfd23519c59b261e253a623097c892108a9b66d3fd330128b9651be4923f01b16666cf61c82abc112c6b5fcee987703b0c4198462148b6a174b51ba24
-  data.tar.gz: '09a81cd8ef765626765d0f269063c284266cf2153d3b80c4cdeacb464aeea41b4df9967ba256a3f8a27bd06f89c2f650cffffc903e4d5206504e05ff1daa2e50'
+  metadata.gz: 3548b8ae4d3ac5f91f8a5ad31bda608cf3bdf1d24150bb0c95206966e6e5ace38506830cdda614a1b0957e257a6be78607037ddba77e73521da05011eabdb84c
+  data.tar.gz: 89b1992ef048d7bdcf5c62aaa0038508bf80fbb5d5383a1cd96746c9f6dcf50223f44b7ddf5ac943d0e51515da2f631d6e03cce662c52660f59617c0eb822081

data/README.md

@@ -1,5 +1,3 @@
 # Cucumber Expressions for Ruby
 
-[![Build Status](https://travis-ci.org/cucumber/cucumber-expressions-ruby.svg?branch=master)](https://travis-ci.org/cucumber/cucumber-expressions-ruby)
-
 [The docs are here](https://cucumber.io/docs/cucumber/cucumber-expressions/).

data/Rakefile

@@ -10,9 +10,7 @@ Dir['./rake/*.rb'].each do |f|
 end
 
 require "rspec/core/rake_task"
-RSpec::Core::RakeTask.new(:spec) do |t|
-  t.ruby_opts  = %w[-r./spec/coverage -w]
-end
+RSpec::Core::RakeTask.new(:spec)
 
 require_relative 'spec/capture_warnings'
 include CaptureWarnings

data/VERSION

@@ -0,0 +1 @@
+10.2.1

data/cucumber-cucumber-expressions.gemspec

@@ -1,7 +1,10 @@
 # -*- encoding: utf-8 -*-
+
+version = File.read(File.expand_path("VERSION", __dir__)).strip
+
 Gem::Specification.new do |s|
   s.name        = 'cucumber-cucumber-expressions'
-  s.version     = '8.3.1'
+  s.version     = version
   s.authors     = ["Aslak Hellesøy"]
   s.description = 'Cucumber Expressions - a simpler alternative to Regular Expressions'
   s.summary     = "cucumber-expressions-#{s.version}"
@@ -22,9 +25,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rake', '~> 13.0', '>= 13.0.1'
   s.add_development_dependency 'rspec', '~> 3.9', '>= 3.9.0'
 
-  # For coverage reports
-  s.add_development_dependency 'coveralls', '~> 0.8', '>= 0.8.23'
-
   s.rubygems_version = ">= 1.6.1"
   s.files            = `git ls-files`.split("\n").reject {|path| path =~ /\.gitignore$/ }
   s.test_files       = `git ls-files -- spec/*`.split("\n")

data/default.mk

@@ -32,21 +32,21 @@ endif
 endif
 .PHONY: gem
 
-$(GEM): clean .tested
+$(GEM): .tested
 	gem build $(GEMSPEC)
 	test -s "$(GEM)" || { echo "Gem not built: $(GEM)"; exit 1; }
 
-pre-release: update-version update-dependencies gem
+remove-local-dependencies:
+	cat Gemfile | sed 's/^gem /#gem /' > Gemfile.tmp
+	mv Gemfile.tmp Gemfile
+.PHONY: remove-local-dependencies
+
+pre-release: remove-local-dependencies update-version update-dependencies gem
 .PHONY: pre-release
 
 update-version:
 ifdef NEW_VERSION
-ifneq (,$(GEMSPEC))
-	sed -i "s/\(s\.version *= *'\)[0-9]*\.[0-9]*\.[0-9]*\('\)/\1$(NEW_VERSION)\2/" $(GEMSPEC)
-endif
-else
-	@echo -e "\033[0;31mNEW_VERSION is not defined. Can't update version :-(\033[0m"
-	exit 1
+	@echo "$(NEW_VERSION)" > VERSION
 endif
 .PHONY: update-version
 
@@ -59,12 +59,13 @@ endif
 .PHONY: publish
 
 post-release:
-	@echo "No post-release needed for ruby"
+	cat Gemfile | sed 's/^#gem /gem /' > Gemfile.tmp
+	mv Gemfile.tmp Gemfile
 .PHONY: post-release
 
 clean: clean-ruby
 .PHONY: clean
 
 clean-ruby:
-	rm -f .deps .linked .tested* Gemfile.lock *.gem
+	rm -rf .deps .linked .tested* Gemfile.lock *.gem acceptance
 .PHONY: clean-ruby

data/examples.txt

@@ -29,3 +29,7 @@ I have 22 cukes in my belly now
 I have {} cuke(s) in my {} now
 I have 22 cukes in my belly now
 ["22","belly"]
+---
+/^a (pre-commercial transaction |pre buyer fee model )?purchase(?: for \$(\d+))?$/
+a purchase for $33
+[null,33]

data/lib/cucumber/cucumber_expressions/expression_factory.rb

@@ -0,0 +1,22 @@
+require 'cucumber/cucumber_expressions/errors'
+require 'cucumber/cucumber_expressions/cucumber_expression'
+require 'cucumber/cucumber_expressions/regular_expression'
+
+module Cucumber
+  module CucumberExpressions
+    class ExpressionFactory
+      def initialize(parameter_type_registry)
+        @parameter_type_registry = parameter_type_registry
+      end
+
+      def create_expression(string_or_regexp)
+        case string_or_regexp
+        when String then CucumberExpression.new(string_or_regexp, @parameter_type_registry)
+        when Regexp then RegularExpression.new(string_or_regexp, @parameter_type_registry)
+        else
+          raise CucumberExpressionError.new("Can't create an expression from #{string_or_regexp.inspect}")
+        end
+      end
+    end
+  end
+end

data/lib/cucumber/cucumber_expressions/group.rb

@@ -11,7 +11,7 @@ module Cucumber
       end
 
       def values
-        (children.empty? ? [self] : children).map(&:value).compact
+        (children.empty? ? [self] : children).map(&:value)
       end
     end
   end

data/lib/cucumber/cucumber_expressions/parameter_type_registry.rb

@@ -18,7 +18,7 @@ module Cucumber
         define_parameter_type(ParameterType.new('int', INTEGER_REGEXPS, Integer, lambda {|s = nil| s && s.to_i}, true, true))
         define_parameter_type(ParameterType.new('float', FLOAT_REGEXP, Float, lambda {|s = nil| s && s.to_f}, true, false))
         define_parameter_type(ParameterType.new('word', WORD_REGEXP, String, lambda {|s = nil| s}, false, false))
-        define_parameter_type(ParameterType.new('string', STRING_REGEXP, String, lambda {|s = nil| s && s.gsub(/\\"/, '"').gsub(/\\'/, "'")}, true, false))
+        define_parameter_type(ParameterType.new('string', STRING_REGEXP, String, lambda { |s1, s2| arg = s1 != nil ? s1 : s2; arg.gsub(/\\"/, '"').gsub(/\\'/, "'")}, true, false))
         define_parameter_type(ParameterType.new('', ANONYMOUS_REGEXP, String, lambda {|s = nil| s}, false, true))
       end
 

data/lib/cucumber/cucumber_expressions/tree_regexp.rb

@@ -8,68 +8,75 @@ module Cucumber
 
       def initialize(regexp)
         @regexp = regexp.is_a?(Regexp) ? regexp : Regexp.new(regexp)
-        @stack = [GroupBuilder.new]
+        @group_builder = create_group_builder(@regexp)
+      end
+
+      def match(s)
+        match = @regexp.match(s)
+        return nil if match.nil?
+        group_indices = (0..match.length).to_a.to_enum
+        @group_builder.build(match, group_indices)
+      end
+
+      private def is_non_capturing(source, i)
+        # Regex is valid. Bounds check not required.
+        if source[i+1] != '?'
+          # (X)
+          return false
+        end
+
+        if source[i+2] != '<'
+          # (?:X)
+          # (?idmsuxU-idmsuxU)
+          # (?idmsux-idmsux:X)
+          # (?=X)
+          # (?!X)
+          # (?>X)
+          return true
+        end
+
+        if source[i+3] == '=' || source[i+3] == '!'
+          # (?<=X)
+          # (?<!X)
+          return true
+        end
+
+        # (?<name>X)
+        raise CucumberExpressionError.new("Named capture groups are not supported. See https://github.com/cucumber/cucumber/issues/329")
+      end
+
+      private def create_group_builder(regexp)
+        source = regexp.source
+        stack = [GroupBuilder.new]
         group_start_stack = []
-        last = nil
         escaping = false
-        @non_capturing_maybe = false
-        @name_capturing_maybe = false
         char_class = false
-
-        @regexp.source.each_char.with_index do |c, n|
+        source.each_char.with_index do |c, i|
           if c == '[' && !escaping
             char_class = true
           elsif c == ']' && !escaping
             char_class = false
           elsif c == '(' && !escaping && !char_class
-            @stack.push(GroupBuilder.new)
-            group_start_stack.push(n + 1)
-            @non_capturing_maybe = false
+            group_start_stack.push(i)
+            group_builder = GroupBuilder.new
+            non_capturing = is_non_capturing(source, i)
+            if non_capturing
+              group_builder.set_non_capturing!
+            end
+            stack.push(group_builder)
           elsif c == ')' && !escaping && !char_class
-            gb = @stack.pop
+            gb = stack.pop
             group_start = group_start_stack.pop
             if gb.capturing?
-              gb.source = @regexp.source[group_start...n]
-              @stack.last.add(gb)
+              gb.source = source[group_start + 1...i]
+              stack.last.add(gb)
             else
-              gb.move_children_to(@stack.last)
+              gb.move_children_to(stack.last)
             end
-            end_group
-          elsif c == '?' && last == '('
-            @non_capturing_maybe = true
-          elsif (c == '<') && @non_capturing_maybe
-            @name_capturing_maybe = true
-          elsif (c == ':' || c == '!' || c == '=') && last == '?' && @non_capturing_maybe
-            end_non_capturing_group
-          elsif (c == '=' || c == '!') && last == '<' && @name_capturing_maybe
-            end_non_capturing_group
-          elsif @name_capturing_maybe
-            raise CucumberExpressionError.new("Named capture groups are not supported. See https://github.com/cucumber/cucumber/issues/329")
           end
-
           escaping = c == '\\' && !escaping
-          last = c
         end
-        @group_builder = @stack.pop
-      end
-
-      def match(s)
-        match = @regexp.match(s)
-        return nil if match.nil?
-        group_indices = (0..match.length).to_a.to_enum
-        @group_builder.build(match, group_indices)
-      end
-
-      private
-
-      def end_non_capturing_group
-        @stack.last.set_non_capturing!
-        end_group
-      end
-
-      def end_group
-        @non_capturing_maybe = false
-        @name_capturing_maybe = false
+        stack.pop
       end
     end
   end

data/spec/cucumber/cucumber_expressions/cucumber_expression_spec.rb

@@ -201,6 +201,33 @@ module Cucumber
         end
       end
 
+
+      it "unmatched optional groups have undefined values" do
+        parameter_type_registry = ParameterTypeRegistry.new
+        parameter_type_registry.define_parameter_type(
+            ParameterType.new(
+                'textAndOrNumber',
+                /([A-Z]+)?(?: )?([0-9]+)?/,
+                Object,
+                -> (s1, s2) {
+                  [s1, s2]
+                },
+                false,
+                true
+            )
+        )
+        expression = CucumberExpression.new(
+            '{textAndOrNumber}',
+            parameter_type_registry
+        )
+
+        class World
+        end
+
+        expect(expression.match("TLA")[0].value(World.new)).to eq(["TLA", nil])
+        expect(expression.match("123")[0].value(World.new)).to eq([nil, "123"])
+      end
+
       def match(expression, text)
         cucumber_expression = CucumberExpression.new(expression, ParameterTypeRegistry.new)
         args = cucumber_expression.match(text)

data/spec/cucumber/cucumber_expressions/expression_factory_spec.rb

@@ -0,0 +1,23 @@
+require 'cucumber/cucumber_expressions/expression_factory'
+
+module Cucumber
+  module CucumberExpressions
+    describe ExpressionFactory do
+      before do
+        @expression_factory = ExpressionFactory.new(ParameterTypeRegistry.new)
+      end
+
+      it 'creates a RegularExpression' do
+        expect(@expression_factory.create_expression(/x/).class).to eq(RegularExpression)
+      end
+
+      it 'creates a CucumberExpression' do
+        expect(@expression_factory.create_expression('{int}').class).to eq(CucumberExpression)
+      end
+
+      it 'creates a XXXRegularExpression' do
+        expect {@expression_factory.create_expression('hello {x}')}.to raise_error("Undefined parameter type {x}")
+      end
+    end
+  end
+end

data/spec/cucumber/cucumber_expressions/tree_regexp_spec.rb

@@ -22,6 +22,7 @@ module Cucumber
         group = tr.match('abc')
         expect(group.value).to eq('abc')
         expect(group.children.length).to eq 1
+        expect(group.children[0].value).to eq('c')
       end
 
       it 'ignores `?!` as a non-capturing group' do
@@ -55,6 +56,28 @@ module Cucumber
         expect(group.children.length).to eq 1
       end
 
+      it 'ignores `?<!` as a non-capturing group' do
+        tr = TreeRegexp.new(/a(.+)(?<!b)$/)
+        group = tr.match('abc')
+        expect(group.value).to eq('abc')
+        expect(group.children[0].value).to eq('bc')
+        expect(group.children.length).to eq 1
+      end
+
+      it 'ignores `?>` as a non-capturing group' do
+        tr = TreeRegexp.new(/a(?>b)c/)
+        group = tr.match('abc')
+        expect(group.value).to eq('abc')
+        expect(group.children.length).to eq 0
+      end
+
+      it 'throws an error when there are named capture groups because they are buggy in Ruby' do
+        # https://github.com/cucumber/cucumber/issues/329
+        expect {
+          TreeRegexp.new(/^I am a person( named "(?<first_name>.+) (?<last_name>.+)")?$/)
+        }.to raise_error(/Named capture groups are not supported/)
+      end
+
       it 'matches optional group' do
         tr = TreeRegexp.new(/^Something( with an optional argument)?/)
         group = tr.match('Something')
@@ -122,12 +145,42 @@ module Cucumber
         expect(group.children.length).to eq(1)
       end
 
-      it 'throws an error when there are named capture groups because they are buggy in Ruby' do
-        # https://github.com/cucumber/cucumber/issues/329
-        expect {
-          TreeRegexp.new(/^I am a person( named "(?<first_name>.+) (?<last_name>.+)")?$/)
-        }.to raise_error(/Named capture groups are not supported/)
+      it 'works with inline flags' do
+        tr = TreeRegexp.new(/(?i)HELLO/)
+        group = tr.match('hello')
+        expect(group.value).to eq('hello')
+        expect(group.children.length).to eq 0
+      end
+
+      it 'works with non capturing inline flags' do
+        tr = TreeRegexp.new(/(?i:HELLO)/)
+        group = tr.match('hello')
+        expect(group.value).to eq('hello')
+        expect(group.children.length).to eq 0
       end
+
+      it 'works with empty capturing group' do
+        tr = TreeRegexp.new(/()/)
+        group = tr.match('')
+        expect(group.value).to eq('')
+        expect(group.children[0].value).to eq('')
+        expect(group.children.length).to eq 1
+      end
+
+      it 'works with empty non-capturing group' do
+        tr = TreeRegexp.new(/(?:)/)
+        group = tr.match('')
+        expect(group.value).to eq('')
+        expect(group.children.length).to eq 0
+      end
+
+      it 'works with empty non-look ahead' do
+        tr = TreeRegexp.new(/(?<=)/)
+        group = tr.match('')
+        expect(group.value).to eq('')
+        expect(group.children.length).to eq 0
+      end
+
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-cucumber-expressions
 version: !ruby/object:Gem::Version
-  version: 8.3.1
+  version: 10.2.1
 platform: ruby
 authors:
 - Aslak Hellesøy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-10 00:00:00.000000000 Z
+date: 2020-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -50,26 +50,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.9.0
-- !ruby/object:Gem::Dependency
-  name: coveralls
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.8'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.8.23
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.8'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.8.23
 description: Cucumber Expressions - a simpler alternative to Regular Expressions
 email: cukes@googlegroups.com
 executables: []
@@ -86,6 +66,7 @@ files:
 - Makefile
 - README.md
 - Rakefile
+- VERSION
 - cucumber-cucumber-expressions.gemspec
 - default.mk
 - examples.txt
@@ -94,6 +75,7 @@ files:
 - lib/cucumber/cucumber_expressions/cucumber_expression.rb
 - lib/cucumber/cucumber_expressions/cucumber_expression_generator.rb
 - lib/cucumber/cucumber_expressions/errors.rb
+- lib/cucumber/cucumber_expressions/expression_factory.rb
 - lib/cucumber/cucumber_expressions/generated_expression.rb
 - lib/cucumber/cucumber_expressions/group.rb
 - lib/cucumber/cucumber_expressions/group_builder.rb
@@ -104,7 +86,6 @@ files:
 - lib/cucumber/cucumber_expressions/tree_regexp.rb
 - scripts/update-gemspec
 - spec/capture_warnings.rb
-- spec/coverage.rb
 - spec/cucumber/cucumber_expressions/argument_spec.rb
 - spec/cucumber/cucumber_expressions/combinatorial_generated_expression_factory_test.rb
 - spec/cucumber/cucumber_expressions/cucumber_expression_generator_spec.rb
@@ -112,6 +93,7 @@ files:
 - spec/cucumber/cucumber_expressions/cucumber_expression_spec.rb
 - spec/cucumber/cucumber_expressions/custom_parameter_type_spec.rb
 - spec/cucumber/cucumber_expressions/expression_examples_spec.rb
+- spec/cucumber/cucumber_expressions/expression_factory_spec.rb
 - spec/cucumber/cucumber_expressions/parameter_type_registry_spec.rb
 - spec/cucumber/cucumber_expressions/parameter_type_spec.rb
 - spec/cucumber/cucumber_expressions/regular_expression_spec.rb
@@ -141,14 +123,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6.2
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
-summary: cucumber-expressions-8.3.1
+summary: cucumber-expressions-10.2.1
 test_files:
 - spec/capture_warnings.rb
-- spec/coverage.rb
 - spec/cucumber/cucumber_expressions/argument_spec.rb
 - spec/cucumber/cucumber_expressions/combinatorial_generated_expression_factory_test.rb
 - spec/cucumber/cucumber_expressions/cucumber_expression_generator_spec.rb
@@ -156,6 +136,7 @@ test_files:
 - spec/cucumber/cucumber_expressions/cucumber_expression_spec.rb
 - spec/cucumber/cucumber_expressions/custom_parameter_type_spec.rb
 - spec/cucumber/cucumber_expressions/expression_examples_spec.rb
+- spec/cucumber/cucumber_expressions/expression_factory_spec.rb
 - spec/cucumber/cucumber_expressions/parameter_type_registry_spec.rb
 - spec/cucumber/cucumber_expressions/parameter_type_spec.rb
 - spec/cucumber/cucumber_expressions/regular_expression_spec.rb

data/spec/coverage.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-require 'simplecov'
-formatters = [ SimpleCov::Formatter::HTMLFormatter ]
-
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(*formatters)
-SimpleCov.add_filter 'spec/'
-SimpleCov.start