cucumber-cucumber-expressions 10.1.0 → 11.0.0

data/spec/cucumber/cucumber_expressions/cucumber_expression_tokenizer_spec.rb

@@ -0,0 +1,24 @@
+require 'yaml'
+require 'json'
+require 'cucumber/cucumber_expressions/cucumber_expression_tokenizer'
+require 'cucumber/cucumber_expressions/errors'
+
+module Cucumber
+  module CucumberExpressions
+    describe 'Cucumber expression tokenizer' do
+      Dir['testdata/tokens/*.yaml'].each do |testcase|
+        expectation = YAML.load_file(testcase) # encoding?
+        it "#{testcase}" do
+          tokenizer = CucumberExpressionTokenizer.new
+          if expectation['exception'].nil?
+            tokens = tokenizer.tokenize(expectation['expression'])
+            token_hashes = tokens.map{|token| token.to_hash}
+            expect(token_hashes).to eq(JSON.parse(expectation['expected']))
+          else
+            expect { tokenizer.tokenize(expectation['expression']) }.to raise_error(expectation['exception'])
+          end
+        end
+      end
+    end
+  end
+end

data/spec/cucumber/cucumber_expressions/custom_parameter_type_spec.rb

@@ -69,7 +69,7 @@ module Cucumber
               true,
               false
           )
-        end.to raise_error("Illegal character '[' in parameter name {[string]}")
+        end.to raise_error("Illegal character in parameter name {[string]}. Parameter names may not contain '[]()$.|?*+'")
       end
 
       describe CucumberExpression do

data/spec/cucumber/cucumber_expressions/expression_examples_spec.rb

@@ -7,7 +7,7 @@ module Cucumber
   module CucumberExpressions
     describe 'examples.txt' do
       def match(expression_text, text)
-        expression = expression_text =~ /\/(.*)\// ?
+        expression = expression_text =~ /^\/(.*)\/$/ ?
           RegularExpression.new(Regexp.new($1), ParameterTypeRegistry.new) :
           CucumberExpression.new(expression_text, ParameterTypeRegistry.new)
 

data/spec/cucumber/cucumber_expressions/expression_factory_spec.rb

@@ -14,10 +14,6 @@ module Cucumber
       it 'creates a CucumberExpression' do
         expect(@expression_factory.create_expression('{int}').class).to eq(CucumberExpression)
       end
-
-      it 'creates a XXXRegularExpression' do
-        expect {@expression_factory.create_expression('hello {x}')}.to raise_error("Undefined parameter type {x}")
-      end
     end
   end
 end

data/spec/cucumber/cucumber_expressions/tree_regexp_spec.rb

@@ -22,6 +22,7 @@ module Cucumber
         group = tr.match('abc')
         expect(group.value).to eq('abc')
         expect(group.children.length).to eq 1
+        expect(group.children[0].value).to eq('c')
       end
 
       it 'ignores `?!` as a non-capturing group' do
@@ -55,6 +56,28 @@ module Cucumber
         expect(group.children.length).to eq 1
       end
 
+      it 'ignores `?<!` as a non-capturing group' do
+        tr = TreeRegexp.new(/a(.+)(?<!b)$/)
+        group = tr.match('abc')
+        expect(group.value).to eq('abc')
+        expect(group.children[0].value).to eq('bc')
+        expect(group.children.length).to eq 1
+      end
+
+      it 'ignores `?>` as a non-capturing group' do
+        tr = TreeRegexp.new(/a(?>b)c/)
+        group = tr.match('abc')
+        expect(group.value).to eq('abc')
+        expect(group.children.length).to eq 0
+      end
+
+      it 'throws an error when there are named capture groups because they are buggy in Ruby' do
+        # https://github.com/cucumber/cucumber/issues/329
+        expect {
+          TreeRegexp.new(/^I am a person( named "(?<first_name>.+) (?<last_name>.+)")?$/)
+        }.to raise_error(/Named capture groups are not supported/)
+      end
+
       it 'matches optional group' do
         tr = TreeRegexp.new(/^Something( with an optional argument)?/)
         group = tr.match('Something')
@@ -122,12 +145,42 @@ module Cucumber
         expect(group.children.length).to eq(1)
       end
 
-      it 'throws an error when there are named capture groups because they are buggy in Ruby' do
-        # https://github.com/cucumber/cucumber/issues/329
-        expect {
-          TreeRegexp.new(/^I am a person( named "(?<first_name>.+) (?<last_name>.+)")?$/)
-        }.to raise_error(/Named capture groups are not supported/)
+      it 'works with inline flags' do
+        tr = TreeRegexp.new(/(?i)HELLO/)
+        group = tr.match('hello')
+        expect(group.value).to eq('hello')
+        expect(group.children.length).to eq 0
+      end
+
+      it 'works with non capturing inline flags' do
+        tr = TreeRegexp.new(/(?i:HELLO)/)
+        group = tr.match('hello')
+        expect(group.value).to eq('hello')
+        expect(group.children.length).to eq 0
       end
+
+      it 'works with empty capturing group' do
+        tr = TreeRegexp.new(/()/)
+        group = tr.match('')
+        expect(group.value).to eq('')
+        expect(group.children[0].value).to eq('')
+        expect(group.children.length).to eq 1
+      end
+
+      it 'works with empty non-capturing group' do
+        tr = TreeRegexp.new(/(?:)/)
+        group = tr.match('')
+        expect(group.value).to eq('')
+        expect(group.children.length).to eq 0
+      end
+
+      it 'works with empty non-look ahead' do
+        tr = TreeRegexp.new(/(?<=)/)
+        group = tr.match('')
+        expect(group.value).to eq('')
+        expect(group.children.length).to eq 0
+      end
+
     end
   end
 end

data/testdata/ast/alternation-followed-by-optional.yaml

@@ -0,0 +1,17 @@
+expression: three blind\ rat/cat(s)
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 23, "nodes": [
+    {"type": "TEXT_NODE", "start": 0, "end": 5, "token": "three"},
+    {"type": "TEXT_NODE", "start": 5, "end": 6, "token": " "},
+    {"type": "ALTERNATION_NODE", "start": 6, "end": 23, "nodes": [
+      {"type": "ALTERNATIVE_NODE", "start": 6, "end": 16, "nodes": [
+        {"type": "TEXT_NODE", "start": 6, "end": 16, "token": "blind rat"}
+      ]},
+      {"type": "ALTERNATIVE_NODE", "start": 17, "end": 23, "nodes": [
+        {"type": "TEXT_NODE", "start": 17, "end": 20, "token": "cat"},
+        {"type": "OPTIONAL_NODE", "start": 20, "end": 23, "nodes": [
+          {"type": "TEXT_NODE", "start": 21, "end": 22, "token": "s"}
+        ]}
+      ]}
+    ]}
+  ]}

data/testdata/ast/alternation-phrase.yaml

@@ -0,0 +1,16 @@
+expression: three hungry/blind mice
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 23, "nodes": [
+    {"type": "TEXT_NODE", "start": 0, "end": 5, "token": "three"},
+    {"type": "TEXT_NODE", "start": 5, "end": 6, "token": " "},
+    {"type": "ALTERNATION_NODE", "start": 6, "end": 18, "nodes": [
+      {"type": "ALTERNATIVE_NODE", "start": 6, "end": 12, "nodes": [
+        {"type": "TEXT_NODE", "start": 6, "end": 12, "token": "hungry"}
+      ]},
+      {"type": "ALTERNATIVE_NODE", "start": 13, "end": 18, "nodes": [
+        {"type": "TEXT_NODE", "start": 13, "end": 18, "token": "blind"}
+      ]}
+    ]},
+    {"type": "TEXT_NODE", "start": 18, "end": 19, "token": " "},
+    {"type": "TEXT_NODE", "start": 19, "end": 23, "token": "mice"}
+  ]}

data/testdata/ast/alternation-with-parameter.yaml

@@ -0,0 +1,27 @@
+expression: I select the {int}st/nd/rd/th
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 29, "nodes": [
+    {"type": "TEXT_NODE", "start": 0, "end": 1, "token": "I"},
+    {"type": "TEXT_NODE", "start": 1, "end": 2, "token": " "},
+    {"type": "TEXT_NODE", "start": 2, "end": 8, "token": "select"},
+    {"type": "TEXT_NODE", "start": 8, "end": 9, "token": " "},
+    {"type": "TEXT_NODE", "start": 9, "end": 12, "token": "the"},
+    {"type": "TEXT_NODE", "start": 12, "end": 13, "token": " "},
+    {"type": "PARAMETER_NODE", "start": 13, "end": 18, "nodes": [
+      {"type": "TEXT_NODE", "start": 14, "end": 17, "token": "int"}
+    ]},
+    {"type": "ALTERNATION_NODE", "start": 18, "end": 29, "nodes": [
+      {"type": "ALTERNATIVE_NODE", "start": 18, "end": 20, "nodes": [
+        {"type": "TEXT_NODE", "start": 18, "end": 20, "token": "st"}
+      ]},
+      {"type": "ALTERNATIVE_NODE", "start": 21, "end": 23, "nodes": [
+        {"type": "TEXT_NODE", "start": 21, "end": 23, "token": "nd"}
+      ]},
+      {"type": "ALTERNATIVE_NODE", "start": 24, "end": 26, "nodes": [
+        {"type": "TEXT_NODE", "start": 24, "end": 26, "token": "rd"}
+      ]},
+      {"type": "ALTERNATIVE_NODE", "start": 27, "end": 29, "nodes": [
+        {"type": "TEXT_NODE", "start": 27, "end": 29, "token": "th"}
+      ]}
+    ]}
+  ]}

data/testdata/ast/alternation-with-unused-end-optional.yaml

@@ -0,0 +1,15 @@
+expression: three )blind\ mice/rats
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 23, "nodes": [
+    {"type": "TEXT_NODE", "start": 0, "end": 5, "token": "three"},
+    {"type": "TEXT_NODE", "start": 5, "end": 6, "token": " "},
+    {"type": "ALTERNATION_NODE", "start": 6, "end": 23, "nodes": [
+      {"type": "ALTERNATIVE_NODE", "start": 6, "end": 18, "nodes": [
+        {"type": "TEXT_NODE", "start": 6, "end": 7, "token": ")"},
+        {"type": "TEXT_NODE", "start": 7, "end": 18, "token": "blind mice"}
+      ]},
+      {"type": "ALTERNATIVE_NODE", "start": 19, "end": 23, "nodes": [
+        {"type": "TEXT_NODE", "start": 19, "end": 23, "token": "rats"}
+      ]}
+    ]}
+  ]}

data/testdata/ast/alternation-with-unused-start-optional.yaml

@@ -0,0 +1,8 @@
+expression: three blind\ mice/rats(
+exception: |-
+  This Cucumber Expression has a problem at column 23:
+
+  three blind\ mice/rats(
+                        ^
+  The '(' does not have a matching ')'.
+  If you did not intend to use optional text you can use '\(' to escape the optional text

data/testdata/ast/alternation-with-white-space.yaml

@@ -0,0 +1,12 @@
+expression: '\ three\ hungry/blind\ mice\ '
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 29, "nodes": [
+    {"type": "ALTERNATION_NODE", "start": 0, "end": 29, "nodes": [
+      {"type": "ALTERNATIVE_NODE", "start": 0, "end": 15, "nodes": [
+        {"type": "TEXT_NODE", "start": 0, "end": 15, "token": " three hungry"}
+      ]},
+      {"type": "ALTERNATIVE_NODE", "start": 16, "end": 29, "nodes": [
+        {"type": "TEXT_NODE", "start": 16, "end": 29, "token": "blind mice "}
+      ]}
+    ]}
+  ]}

data/testdata/ast/alternation.yaml

@@ -0,0 +1,12 @@
+expression: mice/rats
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 9, "nodes": [
+    {"type": "ALTERNATION_NODE", "start": 0, "end": 9, "nodes": [
+      {"type": "ALTERNATIVE_NODE", "start": 0, "end": 4, "nodes": [
+        {"type": "TEXT_NODE", "start": 0, "end": 4, "token": "mice"}
+      ]},
+      {"type": "ALTERNATIVE_NODE", "start": 5, "end": 9, "nodes": [
+        {"type": "TEXT_NODE", "start": 5, "end": 9, "token": "rats"}
+      ]}
+    ]}
+  ]}

data/testdata/ast/anonymous-parameter.yaml

@@ -0,0 +1,5 @@
+expression: "{}"
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 2, "nodes": [
+    {"type": "PARAMETER_NODE", "start": 0, "end": 2, "nodes": []}
+  ]}

data/testdata/ast/closing-brace.yaml

@@ -0,0 +1,5 @@
+expression: "}"
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 1, "nodes": [
+    {"type": "TEXT_NODE", "start": 0, "end": 1, "token": "}"}
+  ]}

data/testdata/ast/closing-parenthesis.yaml

@@ -0,0 +1,5 @@
+expression: )
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 1, "nodes": [
+    {"type": "TEXT_NODE", "start": 0, "end": 1, "token": ")"}
+  ]}

data/testdata/ast/empty-alternation.yaml

@@ -0,0 +1,8 @@
+expression: /
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 1, "nodes": [
+    {"type": "ALTERNATION_NODE", "start": 0, "end": 1, "nodes": [
+      {"type": "ALTERNATIVE_NODE", "start": 0, "end": 0, "nodes": []},
+      {"type": "ALTERNATIVE_NODE", "start": 1, "end": 1, "nodes": []}
+    ]}
+  ]}

data/testdata/ast/empty-alternations.yaml

@@ -0,0 +1,9 @@
+expression: '//'
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 2, "nodes": [
+    {"type": "ALTERNATION_NODE", "start": 0, "end": 2, "nodes": [
+      {"type": "ALTERNATIVE_NODE", "start": 0, "end": 0, "nodes": []},
+      {"type": "ALTERNATIVE_NODE", "start": 1, "end": 1, "nodes": []},
+      {"type": "ALTERNATIVE_NODE", "start": 2, "end": 2, "nodes": []}
+    ]}
+  ]}

data/testdata/ast/empty-string.yaml

@@ -0,0 +1,3 @@
+expression: ""
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 0, "nodes": []}

data/testdata/ast/escaped-alternation.yaml

@@ -0,0 +1,5 @@
+expression: 'mice\/rats'
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 10, "nodes": [
+    {"type": "TEXT_NODE", "start": 0, "end": 10, "token": "mice/rats"}
+  ]}

data/testdata/ast/escaped-backslash.yaml

@@ -0,0 +1,5 @@
+expression: '\\'
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 2, "nodes": [
+    {"type": "TEXT_NODE", "start": 0, "end": 2, "token": "\\"}
+  ]}

data/testdata/ast/escaped-opening-parenthesis.yaml

@@ -0,0 +1,5 @@
+expression: '\('
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 2, "nodes": [
+    {"type": "TEXT_NODE", "start": 0, "end": 2, "token": "("}
+  ]}

data/testdata/ast/escaped-optional-followed-by-optional.yaml

@@ -0,0 +1,15 @@
+expression: three \((very) blind) mice
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 26, "nodes": [
+    {"type": "TEXT_NODE", "start": 0, "end": 5, "token": "three"},
+    {"type": "TEXT_NODE", "start": 5, "end": 6, "token": " "},
+    {"type": "TEXT_NODE", "start": 6, "end": 8, "token": "("},
+    {"type": "OPTIONAL_NODE", "start": 8, "end": 14, "nodes": [
+      {"type": "TEXT_NODE", "start": 9, "end": 13, "token": "very"}
+    ]},
+    {"type": "TEXT_NODE", "start": 14, "end": 15, "token": " "},
+    {"type": "TEXT_NODE", "start": 15, "end": 20, "token": "blind"},
+    {"type": "TEXT_NODE", "start": 20, "end": 21, "token": ")"},
+    {"type": "TEXT_NODE", "start": 21, "end": 22, "token": " "},
+    {"type": "TEXT_NODE", "start": 22, "end": 26, "token": "mice"}
+  ]}

data/testdata/ast/escaped-optional-phrase.yaml

@@ -0,0 +1,10 @@
+expression: three \(blind) mice
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 19, "nodes": [
+    {"type": "TEXT_NODE", "start": 0, "end": 5, "token": "three"},
+    {"type": "TEXT_NODE", "start": 5, "end": 6, "token": " "},
+    {"type": "TEXT_NODE", "start": 6, "end": 13, "token": "(blind"},
+    {"type": "TEXT_NODE", "start": 13, "end": 14, "token": ")"},
+    {"type": "TEXT_NODE", "start": 14, "end": 15, "token": " "},
+    {"type": "TEXT_NODE", "start": 15, "end": 19, "token": "mice"}
+  ]}

data/testdata/ast/escaped-optional.yaml

@@ -0,0 +1,7 @@
+expression: '\(blind)'
+
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 8, "nodes": [
+    {"type": "TEXT_NODE", "start": 0, "end": 7, "token": "(blind"},
+    {"type": "TEXT_NODE", "start": 7, "end": 8, "token": ")"}
+  ]}

data/testdata/ast/opening-brace.yaml

@@ -0,0 +1,8 @@
+expression: '{'
+exception: |-
+  This Cucumber Expression has a problem at column 1:
+
+  {
+  ^
+  The '{' does not have a matching '}'.
+  If you did not intend to use a parameter you can use '\{' to escape the a parameter

data/testdata/ast/opening-parenthesis.yaml

@@ -0,0 +1,8 @@
+expression: (
+exception: |-
+  This Cucumber Expression has a problem at column 1:
+
+  (
+  ^
+  The '(' does not have a matching ')'.
+  If you did not intend to use optional text you can use '\(' to escape the optional text

data/testdata/ast/optional-containing-nested-optional.yaml

@@ -0,0 +1,15 @@
+expression: three ((very) blind) mice
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 25, "nodes": [
+    {"type": "TEXT_NODE", "start": 0, "end": 5, "token": "three"},
+    {"type": "TEXT_NODE", "start": 5, "end": 6, "token": " "},
+    {"type": "OPTIONAL_NODE", "start": 6, "end": 20, "nodes": [
+      {"type": "OPTIONAL_NODE", "start": 7, "end": 13, "nodes": [
+        {"type": "TEXT_NODE", "start": 8, "end": 12, "token": "very"}
+      ]},
+      {"type": "TEXT_NODE", "start": 13, "end": 14, "token": " "},
+      {"type": "TEXT_NODE", "start": 14, "end": 19, "token": "blind"}
+    ]},
+    {"type": "TEXT_NODE", "start": 20, "end": 21, "token": " "},
+    {"type": "TEXT_NODE", "start": 21, "end": 25, "token": "mice"}
+  ]}

data/testdata/ast/optional-phrase.yaml

@@ -0,0 +1,12 @@
+expression: three (blind) mice
+
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 18, "nodes": [
+    {"type": "TEXT_NODE", "start": 0, "end": 5, "token": "three"},
+    {"type": "TEXT_NODE", "start": 5, "end": 6, "token": " "},
+    {"type": "OPTIONAL_NODE", "start": 6, "end": 13, "nodes": [
+      {"type": "TEXT_NODE", "start": 7, "end": 12, "token": "blind"}
+    ]},
+    {"type": "TEXT_NODE", "start": 13, "end": 14, "token": " "},
+    {"type": "TEXT_NODE", "start": 14, "end": 18, "token": "mice"}
+  ]}

data/testdata/ast/optional.yaml

@@ -0,0 +1,7 @@
+expression: (blind)
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 7, "nodes": [
+    {"type": "OPTIONAL_NODE", "start": 0, "end": 7, "nodes": [
+      {"type": "TEXT_NODE", "start": 1, "end": 6, "token": "blind"}
+    ]}
+  ]}

data/testdata/ast/parameter.yaml

@@ -0,0 +1,7 @@
+expression: "{string}"
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 8, "nodes": [
+    {"type": "PARAMETER_NODE", "start": 0, "end": 8, "nodes": [
+      {"type": "TEXT_NODE", "start": 1, "end": 7, "token": "string"}
+    ]}
+  ]}

data/testdata/ast/phrase.yaml

@@ -0,0 +1,9 @@
+expression: three blind mice
+expected: |-
+  {"type": "EXPRESSION_NODE", "start": 0, "end": 16, "nodes": [
+    {"type": "TEXT_NODE", "start": 0, "end": 5, "token": "three"},
+    {"type": "TEXT_NODE", "start": 5, "end": 6, "token": " "},
+    {"type": "TEXT_NODE", "start": 6, "end": 11, "token": "blind"},
+    {"type": "TEXT_NODE", "start": 11, "end": 12, "token": " "},
+    {"type": "TEXT_NODE", "start": 12, "end": 16, "token": "mice"}
+  ]}

data/testdata/ast/unfinished-parameter.yaml

@@ -0,0 +1,8 @@
+expression: "{string"
+exception: |-
+  This Cucumber Expression has a problem at column 1:
+
+  {string
+  ^
+  The '{' does not have a matching '}'.
+  If you did not intend to use a parameter you can use '\{' to escape the a parameter