cucumber-core 7.0.0 → 10.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5da6b6a86e45d13134912cb888a833bcb6a61fbc78fc3e0f2c838bc63bbbfcde
-  data.tar.gz: 3eb01eac47d77e801dbd1302c65149104a86194e115ad680e73c3d87a935c8da
+  metadata.gz: e93409e35ad98842e630d094f02c5f89fd231c91aa8e0cc79084e67f4ef467c8
+  data.tar.gz: c9a191b3e2a2beb0504d961a6c015fb44de6bbef2d5e5979e83682fe4c294771
 SHA512:
-  metadata.gz: c8cd767b9449a3560d42c8f8cc3f56fbeca66ac7c49c9ee7821b688ca2cc8fed33885974edc8abc47056cfd7c7b9a7b9b1909c78cbc7090d1e2270afad3f6960
-  data.tar.gz: 827f0d7d8023d81e7957bd8e0d5d7258f0e402abd41974822a51aad3e4488326d13144c7f8ab58892016b20cc4c1dd986d127b2dedfee16dd6108064a6d39c65
+  metadata.gz: 1942ec15af9e74b8fd4487cefdd485e6bf8d476a14d4177bdda4d084e515f297696ebe59b2fa5a0535619dc708c355ca147dfd6a764e4a2af8ccc20dda8955ec
+  data.tar.gz: c469d7d0eb04ac6cdacca93153fd17c0d369938b975304063adb1f1552662032b37098d3aa815006afd65c6180d0e964240d6b5e4a45d2752c950fe3c9e2ff60

data/CHANGELOG.md

@@ -1,5 +1,66 @@
 Please see [CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CONTRIBUTING.md) on how to contribute to Cucumber.
 
+## [In GIT](https://github.com/cucumber/cucumber-ruby-core/compare/v10.0.0...main)
+
+### Added
+
+### Changed
+
+### Deprecate
+
+### Removed
+
+### Fixed
+
+### Dependencies
+
+## [10.0.0](https://github.com/cucumber/cucumber-ruby-core/compare/v9.0.1...v10.0.0)
+
+### Dependencies
+
+* Upgraded to gherkin v20 and messages v17.
+
+  This removes protocol buffers from the runtime dependencies.
+
+  This deeply impacts the API as the internal representation of messages has changed from
+  Protocol Buffer objects to new auto-generated DTOs.
+
+## [9.0.1](https://github.com/cucumber/cucumber-ruby-core/compare/v9.0.0...v9.0.1)
+
+### Fixed
+
+* Skipped scenarios do not affect anymore status of flaky scenarios on retry
+  ([#218](https://github.com/cucumber/cucumber-ruby-core/pull/218) @eduardrudko)
+
+## [9.0.0](https://github.com/cucumber/cucumber-ruby-core/compare/v8.0.1...v9.0.0)
+
+### Dependencies
+
+* Upgraded to gherkin v18 and messages v15
+* Updated other dependencies (look at the diff for details)
+
+## [8.0.1](https://github.com/cucumber/cucumber-ruby-core/compare/v8.0.0...v8.0.1)
+
+### Fixed
+
+* Make releases from docker using secrets from keybase
+
+## [8.0.0](https://github.com/cucumber/cucumber-ruby-core/compare/v7.1.0...v8.0.0)
+
+This release failed
+
+### Dependencies
+
+* Updated dependencies (look at the diff for details)
+
+## [7.1.0](https://github.com/cucumber/cucumber-ruby-core/compare/v7.0.0...v7.1.0)
+
+### Changed
+
+* Updated gems:
+  * `cucumber-gherkin` ~> 14.0.1
+  * `cucumber-messages` ~> 12.2.0
+
 ## [7.0.0](https://github.com/cucumber/cucumber-ruby-core/compare/v6.0.0...v7.0.0)
 
 ### Changed

data/CONTRIBUTING.md

@@ -1,13 +1,13 @@
 Release Process
 ===============
 
+* Upgrade gems with `scripts/update-gemspec`
 * Bump the version number in `lib/cucumber/core/version.rb`
 * Update `CHANGELOG.md` with the upcoming version number and create a new `In Git` section
+* Remove empty sections from `CHANGELOG.md`
 * Now release it:
 
 ```
-bundle update
-bundle exec rake
 git commit -m "Release X.Y.Z"
-rake release
+make release
 ```

data/README.md

@@ -1,10 +1,10 @@
 # cucumber-core
 
-[![Chat with us](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/cucumber/cucumber-ruby?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![CircleCI](https://circleci.com/gh/cucumber/cucumber-ruby-core.svg?style=svg)](https://circleci.com/gh/cucumber/cucumber-ruby-core)
-[![Build Status](https://travis-ci.org/cucumber/cucumber-ruby-core.svg?branch=master)](https://travis-ci.org/cucumber/cucumber-ruby-core)
 [![Code Climate](https://codeclimate.com/github/cucumber/cucumber-ruby-core.svg)](https://codeclimate.com/github/cucumber/cucumber-ruby-core)
 [![Coverage Status](https://coveralls.io/repos/cucumber/cucumber-ruby-core/badge.svg?branch=master)](https://coveralls.io/r/cucumber/cucumber-ruby-core?branch=master)
+[![pull requests](https://oselvar.com/api/badge?label=pull%20requests&csvUrl=https%3A%2F%2Fraw.githubusercontent.com%2Fcucumber%2Foselvar-github-metrics%2Fmain%2Fdata%2Fcucumber%2Fcucumber-ruby-core%2FpullRequests.csv)](https://oselvar.com/github/cucumber/oselvar-github-metrics/main/cucumber/cucumber-ruby-core)
+[![issues](https://oselvar.com/api/badge?label=issues&csvUrl=https%3A%2F%2Fraw.githubusercontent.com%2Fcucumber%2Foselvar-github-metrics%2Fmain%2Fdata%2Fcucumber%2Fcucumber-ruby-core%2Fissues.csv)](https://oselvar.com/github/cucumber/oselvar-github-metrics/main/cucumber/cucumber-ruby-core)
 
 Cucumber Core is the [inner hexagon](http://alistair.cockburn.us/Hexagonal+architecture) for the [Ruby flavour of Cucumber](https://github.com/cucumber/cucumber-ruby).
 

data/lib/cucumber/core/compiler.rb

@@ -40,7 +40,7 @@ module Cucumber
         lines = source_lines_for_pickle(pickle).sort.reverse
         tags = pickle.tags.map { |tag| Test::Tag.new(Test::Location.new(uri, source_line_for_pickle_tag(tag)), tag.name) }
         test_case = Test::Case.new(id_generator.new_id, pickle.name, test_steps, Test::Location.new(uri, lines), tags, pickle.language)
-        @event_bus.test_case_created(test_case, pickle) unless @event_bus.nil?
+        @event_bus&.test_case_created(test_case, pickle)
         test_case
       end
 
@@ -48,11 +48,11 @@ module Cucumber
         lines = source_lines_for_pickle_step(pickle_step).sort.reverse
         multiline_arg = create_multiline_arg(pickle_step, uri)
         step = Test::Step.new(id_generator.new_id, pickle_step.text, Test::Location.new(uri, lines), multiline_arg)
-        @event_bus.test_step_created(step, pickle_step) unless @event_bus.nil?
+        @event_bus&.test_step_created(step, pickle_step)
         step
       end
 
-      def create_multiline_arg(pickle_step, uri)
+      def create_multiline_arg(pickle_step, _uri)
         if pickle_step.argument
           if pickle_step.argument.doc_string
             doc_string = pickle_step.argument.doc_string

data/lib/cucumber/core/event.rb

@@ -22,7 +22,7 @@ module Cucumber
           end
 
           define_method(:to_h) do
-            attributes.reduce({}) { |result, attribute| 
+            attributes.reduce({}) { |result, attribute|
               value = self.send(attribute)
               result[attribute] = value
               result
@@ -48,8 +48,8 @@ module Cucumber
 
         def underscore(string)
           string.to_s.gsub(/::/, '/').
-          gsub(/([A-Z]+)([A-Z][a-z])/,'\1_\2').
-          gsub(/([a-z\d])([A-Z])/,'\1_\2').
+          gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2').
+          gsub(/([a-z\d])([A-Z])/, '\1_\2').
           tr("-", "_").
           downcase
         end

data/lib/cucumber/core/event_bus.rb

@@ -44,7 +44,7 @@ module Cucumber
 
       def broadcast_queued_events_to(handler, event_type)
         @event_queue.select { |event|
-          event.class == event_type
+          event.instance_of?(event_type)
         }.each { |event|
           handler.call(event)
         }

data/lib/cucumber/core/events.rb

@@ -61,7 +61,6 @@ module Cucumber
 
       end
 
-
       # Signals that a {Test::Case} has finished executing
       class TestCaseFinished < Event.new(:test_case, :result)
 

data/lib/cucumber/core/gherkin/writer.rb

@@ -60,12 +60,14 @@ module Cucumber
           end
 
           def statements
-            prepare_statements language_statement,
+            prepare_statements(
+              language_statement,
               comments_statement,
               tag_statement,
               name_statement,
               description_statement,
               NEW_LINE
+            )
           end
 
           def language_statement
@@ -85,10 +87,12 @@ module Cucumber
 
           private
           def statements
-            prepare_statements comments_statement,
+            prepare_statements(
+              comments_statement,
               tag_statement,
               name_statement,
               description_statement
+            )
           end
         end
 
@@ -104,10 +108,12 @@ module Cucumber
 
           private
           def statements
-            prepare_statements comments_statement,
+            prepare_statements(
+              comments_statement,
               name_statement,
               description_statement,
               NEW_LINE
+            )
           end
         end
 
@@ -123,10 +129,12 @@ module Cucumber
 
           private
           def statements
-            prepare_statements comments_statement,
+            prepare_statements(
+              comments_statement,
               tag_statement,
               name_statement,
               description_statement
+            )
           end
         end
 
@@ -235,12 +243,14 @@ module Cucumber
 
           private
           def statements
-            prepare_statements NEW_LINE,
+            prepare_statements(
+              NEW_LINE,
               comments_statement,
               tag_statement,
               name_statement,
               description_statement,
               row_statements(2)
+            )
           end
         end
       end

data/lib/cucumber/core/gherkin/writer/helpers.rb

@@ -126,11 +126,11 @@ module Cucumber
         module HasDescription
           private
           def description
-            options.fetch(:description) { '' }.split("\n").map(&:strip)
+            options.fetch(:description, '').split("\n").map(&:strip)
           end
 
           def description_statement
-            description.map { |s| indent(s,2) } unless description.empty?
+            description.map { |s| indent(s, 2) } unless description.empty?
           end
         end
 

data/lib/cucumber/core/report/summary.rb

@@ -23,7 +23,7 @@ module Cucumber
             if event.test_case != @previous_test_case
               @previous_test_case = event.test_case
               event.result.describe_to test_cases
-            elsif event.result.passed?
+            elsif event.result.passed? || event.result.skipped?
               test_cases.flaky
               test_cases.decrement_failed
             end

data/lib/cucumber/core/test/action.rb

@@ -1,8 +1,7 @@
 # frozen_string_literal: true
+require 'cucumber/core/test/location'
 require 'cucumber/core/test/result'
 require 'cucumber/core/test/timer'
-require 'cucumber/core/test/result'
-require 'cucumber/core/test/location'
 
 module Cucumber
   module Core

data/lib/cucumber/core/test/data_table.rb

@@ -104,7 +104,7 @@ module Cucumber
 
         def hashes_to_array(hashes)
           header = hashes[0].keys.sort
-          [header] + hashes.map{|hash| header.map{|key| hash[key]}}
+          [header] + hashes.map {|hash| header.map {|key| hash[key]}}
         end
 
       end

data/lib/cucumber/core/test/filters/activate_steps_for_self_test.rb

@@ -33,4 +33,3 @@ module Cucumber
     end
   end
 end
-

data/lib/cucumber/core/test/result.rb

@@ -1,5 +1,7 @@
 # encoding: utf-8
 # frozen_string_literal: true
+require "cucumber/messages"
+require "cucumber/messages/time_conversion"
 
 module Cucumber
   module Core
@@ -44,8 +46,8 @@ module Cucumber
           end
 
           def to_message
-            Cucumber::Messages::TestStepFinished::TestStepResult.new(
-              status: Cucumber::Messages::TestStepFinished::TestStepResult::Status::UNKNOWN,
+            Cucumber::Messages::TestStepResult.new(
+              status: Cucumber::Messages::TestStepResultStatus::UNKNOWN,
               duration: UnknownDuration.new.to_message_duration
             )
           end
@@ -75,8 +77,8 @@ module Cucumber
           end
 
           def to_message
-            Cucumber::Messages::TestStepFinished::TestStepResult.new(
-              status: Cucumber::Messages::TestStepFinished::TestStepResult::Status::PASSED,
+            Cucumber::Messages::TestStepResult.new(
+              status: Cucumber::Messages::TestStepResultStatus::PASSED,
               duration: duration.to_message_duration
             )
           end
@@ -128,8 +130,8 @@ module Cucumber
               message = ""
             end
 
-            Cucumber::Messages::TestStepFinished::TestStepResult.new(
-              status: Cucumber::Messages::TestStepFinished::TestStepResult::Status::FAILED,
+            Cucumber::Messages::TestStepResult.new(
+              status: Cucumber::Messages::TestStepResultStatus::FAILED,
               duration: duration.to_message_duration,
               message: message
             )
@@ -216,8 +218,8 @@ module Cucumber
           end
 
           def to_message
-            Cucumber::Messages::TestStepFinished::TestStepResult.new(
-              status: Cucumber::Messages::TestStepFinished::TestStepResult::Status::UNDEFINED,
+            Cucumber::Messages::TestStepResult.new(
+              status: Cucumber::Messages::TestStepResultStatus::UNDEFINED,
               duration: duration.to_message_duration
             )
           end
@@ -241,8 +243,8 @@ module Cucumber
           end
 
           def to_message
-            Cucumber::Messages::TestStepFinished::TestStepResult.new(
-              status: Cucumber::Messages::TestStepFinished::TestStepResult::Status::SKIPPED,
+            Cucumber::Messages::TestStepResult.new(
+              status: Cucumber::Messages::TestStepResultStatus::SKIPPED,
               duration: duration.to_message_duration
             )
           end
@@ -266,8 +268,8 @@ module Cucumber
           end
 
           def to_message
-            Cucumber::Messages::TestStepFinished::TestStepResult.new(
-              status: Cucumber::Messages::TestStepFinished::TestStepResult::Status::PENDING,
+            Cucumber::Messages::TestStepResult.new(
+              status: Cucumber::Messages::TestStepResultStatus::PENDING,
               duration: duration.to_message_duration
             )
           end
@@ -280,7 +282,7 @@ module Cucumber
           private :settings
 
           def initialize(strict_types = [])
-            @settings = Hash[STRICT_AFFECTED_TYPES.map { |t| [t, :default] }]
+            @settings = STRICT_AFFECTED_TYPES.map { |t| [t, :default] }.to_h
             strict_types.each do |type|
               set_strict(true, type)
             end
@@ -310,7 +312,7 @@ module Cucumber
           end
 
           def merge!(other)
-            settings.keys.each do |type|
+            settings.each_key do |type|
               set_strict(other.strict?(type), type) if other.set?(type)
             end
             self
@@ -369,7 +371,7 @@ module Cucumber
 
           def total(for_status = nil)
             if for_status
-              @totals.fetch(for_status) { 0 }
+              @totals.fetch(for_status, 0)
             else
               @totals.reduce(0) { |total, status| total += status[1] }
             end
@@ -383,7 +385,7 @@ module Cucumber
 
           def get_total(method_name)
             status = method_name.to_s.gsub('total_', '').to_sym
-            return @totals.fetch(status) { 0 }
+            return @totals.fetch(status, 0)
           end
 
           def increment_total(status)
@@ -402,7 +404,14 @@ module Cucumber
           end
 
           def to_message_duration
-            seconds_to_duration(nanoseconds.to_f / NANOSECONDS_PER_SECOND)
+            duration_hash = seconds_to_duration(nanoseconds.to_f / NANOSECONDS_PER_SECOND)
+            duration_hash.transform_keys! do |key|
+              key.to_sym
+            rescue Error
+              return key
+            end
+
+            Cucumber::Messages::Duration.from_h(duration_hash)
           end
         end
 
@@ -418,7 +427,7 @@ module Cucumber
           end
 
           def to_message_duration
-            seconds_to_duration(0)
+            Cucumber::Messages::Duration.new(seconds: 0, nanos: 0)
           end
         end
       end

data/lib/cucumber/core/test/timer.rb

@@ -19,7 +19,7 @@ module Cucumber
         end
 
         def sec
-          nsec / 10 ** 9.0
+          nsec / 10**9.0
         end
 
         private
@@ -42,7 +42,7 @@ module Cucumber
           else
             def time_in_nanoseconds
               t = Time.now
-              t.to_i * 10 ** 9 + t.nsec
+              t.to_i * 10**9 + t.nsec
             end
           end
         end

data/lib/cucumber/core/version.rb

@@ -3,7 +3,7 @@ module Cucumber
   module Core
     class Version
       def self.to_s
-        "7.0.0"
+        "10.0.0"
       end
     end
   end

data/spec/coverage.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+require 'rubygems'
 require 'simplecov'
 formatters = [ SimpleCov::Formatter::HTMLFormatter ]
 

data/spec/cucumber/core/compiler_spec.rb

@@ -52,7 +52,7 @@ module Cucumber::Core
           end
         ]
 
-        compile(gherkin_documents, event_bus) do | visitor |
+        compile(gherkin_documents, event_bus) do |visitor|
           allow( visitor ).to receive(:test_case)
           allow( visitor ).to receive(:test_step)
           allow( visitor ).to receive(:done)

data/spec/cucumber/core/event_bus_spec.rb

@@ -74,7 +74,7 @@ module Cucumber
 
         context "#broadcast method" do
           it "must be passed an instance of a registered event type" do
-            expect { 
+            expect {
               event_bus.broadcast Events::UnregisteredEvent
             }.to raise_error(ArgumentError)
           end
@@ -95,7 +95,7 @@ module Cucumber
         end
 
         it "raises an error if you use an unknown Event ID" do
-          expect { 
+          expect {
             event_bus.on(:some_unknown_event) { :whatever }
           }.to raise_error(ArgumentError)
         end

data/spec/cucumber/core/event_spec.rb

@@ -13,7 +13,7 @@ module Cucumber
 
         it "generates events with attributes" do
           my_event_type = Event.new(:foo, :bar)
-          my_event = my_event_type.new(1,2)
+          my_event = my_event_type.new(1, 2)
           expect(my_event.attributes).to eq [1, 2]
           expect(my_event.foo).to eq 1
           expect(my_event.bar).to eq 2
@@ -25,13 +25,13 @@ module Cucumber
         end
 
         it "can be converted to a hash" do
-          my_event = MyEventType.new(1,2)
+          my_event = MyEventType.new(1, 2)
           expect(my_event.to_h).to eq foo: 1, bar: 2
         end
 
         it "has an event_id" do
           expect(MyEventType.event_id).to eq :my_event_type
-          expect(MyEventType.new(1,2).event_id).to eq :my_event_type
+          expect(MyEventType.new(1, 2).event_id).to eq :my_event_type
         end
       end
     end

data/spec/cucumber/core/filter_spec.rb

@@ -11,7 +11,7 @@ module Cucumber::Core
     describe ".new" do
       let(:receiver) { double.as_null_object }
 
-      let(:doc) { 
+      let(:doc) {
         gherkin do
           feature do
             scenario 'x' do
@@ -46,7 +46,7 @@ module Cucumber::Core
           end
         end
 
-        # You can pass the names of attributes when building a 
+        # You can pass the names of attributes when building a
         # filter, allowing you to have custom attributes.
         class NamedBlankingFilter < Filter.new(:name_pattern)
           def test_case(test_case)

data/spec/cucumber/core/gherkin/parser_spec.rb

@@ -143,7 +143,7 @@ module Cucumber
                   step 'text'
                 end
               end
-              rule description: "Second rule"do
+              rule description: "Second rule" do
                 example name: "Do not talk about the fight club" do
                   step 'text'
                 end

data/spec/cucumber/core/gherkin/writer_spec.rb

@@ -330,4 +330,3 @@ module Cucumber::Core::Gherkin
     end
   end
 end
-

data/spec/cucumber/core/report/summary_spec.rb

@@ -65,6 +65,17 @@ module Cucumber::Core::Report
         expect( @summary.test_cases.total(:flaky) ).to eq(1)
         expect( @summary.test_cases.total ).to eq(1)
       end
+
+      it "handless flaky with following skip test cases" do
+        allow(test_case).to receive(:==).and_return(false, true)
+        event_bus.send(:test_case_finished, test_case, failed_result)
+        event_bus.send(:test_case_finished, test_case, skipped_result)
+
+        expect( @summary.test_cases.total(:failed) ).to eq(0)
+        expect( @summary.test_cases.total(:skipped) ).to eq(0)
+        expect( @summary.test_cases.total(:flaky) ).to eq(1)
+        expect( @summary.test_cases.total ).to eq(1)
+      end
     end
 
     context "test step summary" do

data/spec/cucumber/core/test/action_spec.rb

@@ -17,7 +17,7 @@ module Cucumber
         context "location" do
 
           context "with location passed to the constructor" do
-          let(:location) { double }
+            let(:location) { double }
 
             it "returns the location passed to the constructor" do
               action = Action.new(location) {}
@@ -151,4 +151,3 @@ module Cucumber
     end
   end
 end
-

data/spec/cucumber/core/test/data_table_spec.rb

@@ -15,20 +15,20 @@ module Cucumber
 
         describe "equality" do
           it "is equal to another table with the same data" do
-            expect( DataTable.new([[1,2],[3,4]]) ).to eq DataTable.new([[1,2],[3,4]])
+            expect( DataTable.new([[1, 2], [3, 4]]) ).to eq DataTable.new([[1, 2], [3, 4]])
           end
 
           it "is not equal to another table with different data" do
-            expect( DataTable.new([[1,2],[3,4]]) ).not_to eq DataTable.new([[1,2]])
+            expect( DataTable.new([[1, 2], [3, 4]]) ).not_to eq DataTable.new([[1, 2]])
           end
 
           it "is not equal to a non table" do
-            expect( DataTable.new([[1,2],[3,4]]) ).not_to eq Object.new
+            expect( DataTable.new([[1, 2], [3, 4]]) ).not_to eq Object.new
           end
         end
 
         describe "#data_table?" do
-          let(:table) { DataTable.new([[1,2],[3,4]]) }
+          let(:table) { DataTable.new([[1, 2], [3, 4]]) }
 
           it "returns true" do
             expect(table).to be_data_table
@@ -36,7 +36,7 @@ module Cucumber
         end
 
         describe "#doc_string" do
-          let(:table) { DataTable.new([[1,2],[3,4]]) }
+          let(:table) { DataTable.new([[1, 2], [3, 4]]) }
 
           it "returns false" do
             expect(table).not_to be_doc_string
@@ -52,7 +52,7 @@ module Cucumber
           end
 
           it 'returns a new table with the cells modified by the block' do
-            expect( table.map { |cell| "*#{cell}*" } ).to eq  DataTable.new([%w{*foo* *bar*}, %w{*1* *2*}])
+            expect( table.map { |cell| "*#{cell}*" } ).to eq DataTable.new([%w{*foo* *bar*}, %w{*1* *2*}])
           end
         end
 

data/spec/cucumber/core/test/location_spec.rb

@@ -19,9 +19,9 @@ module Cucumber::Core::Test
         expect( one_location ).to eq another_location
       end
 
-       it "is not equal to a wild card of the same file" do
-         expect( Location.new(file, line) ).not_to eq Location.new(file)
-       end
+      it "is not equal to a wild card of the same file" do
+        expect( Location.new(file, line) ).not_to eq Location.new(file)
+      end
 
       context "collections of locations" do
         it "behave as expected with uniq" do
@@ -45,7 +45,7 @@ module Cucumber::Core::Test
       end
 
       it "is file:line:line:line for an arbitrary set of lines" do
-        expect( Location.new("foo.feature", [1,3,5]).to_s ).to eq "foo.feature:1:3:5"
+        expect( Location.new("foo.feature", [1, 3, 5]).to_s ).to eq "foo.feature:1:3:5"
       end
     end
 
@@ -88,7 +88,7 @@ module Cucumber::Core::Test
     describe "created from source location" do
       context "when the location is in the tree below pwd" do
         it "create a relative path from pwd" do
-          expect( Location.from_source_location(Dir.pwd + "/path/file.rb", 1).file ).to eq "path/file.rb"
+          expect( Location.from_source_location("#{Dir.pwd}/path/file.rb", 1).file ).to eq "path/file.rb"
         end
       end
 
@@ -109,7 +109,7 @@ module Cucumber::Core::Test
 
     describe "created from file-colon-line" do
       it "handles also Windows paths" do
-        # Note: running this test on Windows will produce "c:/path/file.rb", but "c:\path\file.rb" on Linux.
+        # NOTE: running this test on Windows will produce "c:/path/file.rb", but "c:\path\file.rb" on Linux.
         expect( Location.from_file_colon_line("c:\\path\\file.rb:123").file ).to match(/c:(\\|\/)path(\\|\/)file.rb/)
       end
     end
@@ -119,7 +119,7 @@ module Cucumber::Core::Test
         expect( Location.of_caller.to_s ).to be_included_in caller[0]
       end
 
-      context "when specifying additional caller depth"do
+      context "when specifying additional caller depth" do
         it "use the location of the n:th caller" do
           expect( Location.of_caller(1).to_s ).to be_included_in caller[1]
         end

data/spec/cucumber/core/test/result_spec.rb

@@ -25,7 +25,7 @@ module Cucumber::Core::Test
 
       it "converts to a Cucumber::Message::TestResult" do
         message = result.to_message
-        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::PASSED)
+        expect(message.status).to eq(Cucumber::Messages::TestStepResultStatus::PASSED)
       end
 
       it "has a duration" do
@@ -75,7 +75,7 @@ module Cucumber::Core::Test
 
       it "converts to a Cucumber::Message::TestResult" do
         message = result.to_message
-        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::FAILED)
+        expect(message.status).to eq(Cucumber::Messages::TestStepResultStatus::FAILED)
       end
 
       it "requires both constructor arguments" do
@@ -144,7 +144,7 @@ module Cucumber::Core::Test
 
       it "converts to a Cucumber::Message::TestResult" do
         message = result.to_message
-        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::UNKNOWN)
+        expect(message.status).to eq(Cucumber::Messages::TestStepResultStatus::UNKNOWN)
       end
     end
 
@@ -207,7 +207,7 @@ module Cucumber::Core::Test
 
       it "converts to a Cucumber::Message::TestResult" do
         message = result.to_message
-        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::UNDEFINED)
+        expect(message.status).to eq(Cucumber::Messages::TestStepResultStatus::UNDEFINED)
       end
 
       specify { expect( result.to_sym ).to eq :undefined }
@@ -236,7 +236,7 @@ module Cucumber::Core::Test
 
       it "converts to a Cucumber::Message::TestResult" do
         message = result.to_message
-        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::SKIPPED)
+        expect(message.status).to eq(Cucumber::Messages::TestStepResultStatus::SKIPPED)
       end
 
       specify { expect( result.to_sym ).to eq :skipped }
@@ -263,7 +263,7 @@ module Cucumber::Core::Test
 
       it "converts to a Cucumber::Message::TestResult" do
         message = result.to_message
-        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::PENDING)
+        expect(message.status).to eq(Cucumber::Messages::TestStepResultStatus::PENDING)
       end
 
       specify { expect( result.to_sym ).to eq :pending }
@@ -344,16 +344,16 @@ module Cucumber::Core::Test
       describe '#merge!' do
         let(:merged_configuration) { Result::StrictConfiguration.new }
         it 'sets the not default values from the argument accordingly' do
-            strict_configuration.set_strict(false, :undefined)
-            strict_configuration.set_strict(false, :pending)
-            strict_configuration.set_strict(true, :flaky)
-            merged_configuration.set_strict(true, :pending)
-            merged_configuration.set_strict(false, :flaky)
-            strict_configuration.merge!(merged_configuration)
-
-            expect( strict_configuration.strict?(:undefined) ).to be_falsey
-            expect( strict_configuration.strict?(:pending) ).to be_truthy
-            expect( strict_configuration.strict?(:flaky) ).to be_falsey
+          strict_configuration.set_strict(false, :undefined)
+          strict_configuration.set_strict(false, :pending)
+          strict_configuration.set_strict(true, :flaky)
+          merged_configuration.set_strict(true, :pending)
+          merged_configuration.set_strict(false, :flaky)
+          strict_configuration.merge!(merged_configuration)
+
+          expect( strict_configuration.strict?(:undefined) ).to be_falsey
+          expect( strict_configuration.strict?(:pending) ).to be_truthy
+          expect( strict_configuration.strict?(:flaky) ).to be_falsey
         end
       end
     end

data/spec/cucumber/core_spec.rb

@@ -62,7 +62,7 @@ module Cucumber
             scenario_outline 'foo' do
               step '<arg>'
 
-              examples tags: '@a'do
+              examples tags: '@a' do
                 row 'arg'
                 row 'x'
               end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-core
 version: !ruby/object:Gem::Version
-  version: 7.0.0
+  version: 10.0.0
 platform: ruby
 authors:
 - Aslak Hellesøy
@@ -12,68 +12,68 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-24 00:00:00.000000000 Z
+date: 2021-07-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-gherkin
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 13.0.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: '20.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 20.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 13.0.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: '20.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 20.0.0
 - !ruby/object:Gem::Dependency
   name: cucumber-messages
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.1'
+        version: '17.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 12.1.1
+        version: 17.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.1'
+        version: '17.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 12.1.1
+        version: 17.0.0
 - !ruby/object:Gem::Dependency
   name: cucumber-tag-expressions
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.4
+        version: 3.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.4
+        version: 3.0.1
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -98,80 +98,100 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 13.0.0
     - - "~>"
       - !ruby/object:Gem::Version
         version: '13.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 13.0.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 13.0.0
     - - "~>"
       - !ruby/object:Gem::Version
         version: '13.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 13.0.6
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.78.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.78'
+        version: '3.10'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.78.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.78'
+        version: '3.10'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.10.0
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.9.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.9'
+        version: '1.18'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.18.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.18'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.9.0
+        version: 1.18.3
+- !ruby/object:Gem::Dependency
+  name: rubocop-packaging
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.9'
+        version: '0.5'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.5.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.5.1
 - !ruby/object:Gem::Dependency
   name: unindent
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
 description: Core library for the Cucumber BDD app
@@ -214,7 +234,6 @@ files:
 - lib/cucumber/core/test/tag.rb
 - lib/cucumber/core/test/timer.rb
 - lib/cucumber/core/version.rb
-- spec/capture_warnings.rb
 - spec/coverage.rb
 - spec/cucumber/core/compiler_spec.rb
 - spec/cucumber/core/event_bus_spec.rb
@@ -262,31 +281,30 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
-summary: cucumber-core-7.0.0
+summary: cucumber-core-10.0.0
 test_files:
-- spec/cucumber/core/test/runner_spec.rb
-- spec/cucumber/core/test/doc_string_spec.rb
-- spec/cucumber/core/test/filters/locations_filter_spec.rb
-- spec/cucumber/core/test/step_spec.rb
-- spec/cucumber/core/test/duration_matcher.rb
+- spec/cucumber/core_spec.rb
+- spec/cucumber/core/report/summary_spec.rb
+- spec/cucumber/core/compiler_spec.rb
+- spec/cucumber/core/gherkin/parser_spec.rb
+- spec/cucumber/core/gherkin/writer_spec.rb
+- spec/cucumber/core/event_bus_spec.rb
+- spec/cucumber/core/filter_spec.rb
+- spec/cucumber/core/test/timer_spec.rb
 - spec/cucumber/core/test/case_spec.rb
 - spec/cucumber/core/test/result_spec.rb
-- spec/cucumber/core/test/location_spec.rb
 - spec/cucumber/core/test/action_spec.rb
-- spec/cucumber/core/test/timer_spec.rb
+- spec/cucumber/core/test/filters/locations_filter_spec.rb
+- spec/cucumber/core/test/runner_spec.rb
+- spec/cucumber/core/test/doc_string_spec.rb
+- spec/cucumber/core/test/location_spec.rb
+- spec/cucumber/core/test/duration_matcher.rb
 - spec/cucumber/core/test/data_table_spec.rb
+- spec/cucumber/core/test/step_spec.rb
 - spec/cucumber/core/test/empty_multiline_argument_spec.rb
-- spec/cucumber/core/gherkin/parser_spec.rb
-- spec/cucumber/core/gherkin/writer_spec.rb
 - spec/cucumber/core/event_spec.rb
-- spec/cucumber/core/report/summary_spec.rb
-- spec/cucumber/core/compiler_spec.rb
-- spec/cucumber/core/event_bus_spec.rb
-- spec/cucumber/core/filter_spec.rb
-- spec/cucumber/core_spec.rb
-- spec/capture_warnings.rb
-- spec/coverage.rb
 - spec/report_api_spy.rb
+- spec/coverage.rb

data/spec/capture_warnings.rb

@@ -1,74 +0,0 @@
-# frozen_string_literal: true
-# With thanks to @myronmarston
-# https://github.com/vcr/vcr/blob/master/spec/capture_warnings.rb
-
-module CaptureWarnings
-  def report_warnings(&block)
-    current_dir = Dir.pwd
-    warnings, errors = capture_error(&block).partition { |line| line.include?('warning') }
-    project_warnings, other_warnings = warnings.uniq.partition { |line| line.include?(current_dir) && !line.include?('/vendor/') }
-
-    if errors.any?
-      puts errors.join("\n")
-    end
-
-    if other_warnings.any?
-      puts "#{ other_warnings.count } non-cucumber-core warnings detected, set VIEW_OTHER_WARNINGS=true to see them."
-      print_warnings('other', other_warnings) if ENV['VIEW_OTHER_WARNINGS']
-    end
-
-    # Until they fix https://bugs.ruby-lang.org/issues/10661
-    if RUBY_VERSION == "2.2.0"
-      project_warnings = project_warnings.reject { |w| w =~ /warning: possible reference to past scope/ }
-    end
-
-    if project_warnings.any?
-      puts "#{ project_warnings.count } cucumber-core warnings detected"
-      print_warnings('cucumber-core', project_warnings)
-      fail "Please remove all cucumber-core warnings."
-    end
-
-    ensure_system_exit_if_required
-  end
-
-  def capture_error(&block)
-    old_stderr = STDERR.clone
-    pipe_r, pipe_w = IO.pipe
-    pipe_r.sync    = true
-    error         = String.new
-    reader = Thread.new do
-      begin
-        loop do
-          error << pipe_r.readpartial(1024)
-        end
-      rescue EOFError
-      end
-    end
-    STDERR.reopen(pipe_w)
-    block.call
-  ensure
-    capture_system_exit
-    STDERR.reopen(old_stderr)
-    pipe_w.close
-    reader.join
-    return error.split("\n")
-  end
-
-  def print_warnings(type, warnings)
-    puts
-    puts "-" * 30 + " #{type} warnings: " + "-" * 30
-    puts
-    puts warnings.join("\n")
-    puts
-    puts "-" * 75
-    puts
-  end
-
-  def ensure_system_exit_if_required
-    raise @system_exit if @system_exit
-  end
-
-  def capture_system_exit
-    @system_exit = $!
-  end
-end