cucumber-core 5.0.2 → 9.0.0

data/spec/cucumber/core/event_bus_spec.rb

@@ -74,7 +74,7 @@ module Cucumber
 
         context "#broadcast method" do
           it "must be passed an instance of a registered event type" do
-            expect { 
+            expect {
               event_bus.broadcast Events::UnregisteredEvent
             }.to raise_error(ArgumentError)
           end
@@ -95,7 +95,7 @@ module Cucumber
         end
 
         it "raises an error if you use an unknown Event ID" do
-          expect { 
+          expect {
             event_bus.on(:some_unknown_event) { :whatever }
           }.to raise_error(ArgumentError)
         end

data/spec/cucumber/core/event_spec.rb

@@ -13,7 +13,7 @@ module Cucumber
 
         it "generates events with attributes" do
           my_event_type = Event.new(:foo, :bar)
-          my_event = my_event_type.new(1,2)
+          my_event = my_event_type.new(1, 2)
           expect(my_event.attributes).to eq [1, 2]
           expect(my_event.foo).to eq 1
           expect(my_event.bar).to eq 2
@@ -25,13 +25,13 @@ module Cucumber
         end
 
         it "can be converted to a hash" do
-          my_event = MyEventType.new(1,2)
+          my_event = MyEventType.new(1, 2)
           expect(my_event.to_h).to eq foo: 1, bar: 2
         end
 
         it "has an event_id" do
           expect(MyEventType.event_id).to eq :my_event_type
-          expect(MyEventType.new(1,2).event_id).to eq :my_event_type
+          expect(MyEventType.new(1, 2).event_id).to eq :my_event_type
         end
       end
     end

data/spec/cucumber/core/filter_spec.rb

@@ -11,7 +11,7 @@ module Cucumber::Core
     describe ".new" do
       let(:receiver) { double.as_null_object }
 
-      let(:doc) { 
+      let(:doc) {
         gherkin do
           feature do
             scenario 'x' do
@@ -46,7 +46,7 @@ module Cucumber::Core
           end
         end
 
-        # You can pass the names of attributes when building a 
+        # You can pass the names of attributes when building a
         # filter, allowing you to have custom attributes.
         class NamedBlankingFilter < Filter.new(:name_pattern)
           def test_case(test_case)

data/spec/cucumber/core/gherkin/parser_spec.rb

@@ -9,11 +9,14 @@ module Cucumber
       describe Parser do
         let(:receiver)  { double }
         let(:event_bus) { double }
-        let(:parser)    { Parser.new(receiver, event_bus) }
+        let(:gherkin_query) { double }
+        let(:parser)    { Parser.new(receiver, event_bus, gherkin_query) }
         let(:visitor)   { double }
 
         before do
           allow( event_bus ).to receive(:gherkin_source_parsed)
+          allow( event_bus).to receive(:envelope)
+          allow( gherkin_query ).to receive(:update)
         end
 
         def parse
@@ -40,6 +43,12 @@ module Cucumber
             expect( event_bus ).to receive(:gherkin_source_parsed)
             parse
           end
+
+          it "emits an 'envelope' event for every message produced by Gherkin" do
+            # Only one message emited, there's no pickles generated
+            expect( event_bus ).to receive(:envelope).once
+            parse
+          end
         end
 
         context "for empty files" do
@@ -87,6 +96,13 @@ module Cucumber
             expect( receiver ).to receive(:pickle)
             parse
           end
+
+          it "emits an 'envelope' event containing the pickle" do
+            allow( receiver ).to receive(:pickle)
+            # Once for the gherkin document, once with the pickle
+            expect( event_bus ).to receive(:envelope).twice
+            parse
+          end
         end
 
         context "when scenario is inside a rule" do
@@ -127,7 +143,7 @@ module Cucumber
                   step 'text'
                 end
               end
-              rule description: "Second rule"do
+              rule description: "Second rule" do
                 example name: "Do not talk about the fight club" do
                   step 'text'
                 end

data/spec/cucumber/core/gherkin/writer_spec.rb

@@ -330,4 +330,3 @@ module Cucumber::Core::Gherkin
     end
   end
 end
-

data/spec/cucumber/core/test/action_spec.rb

@@ -17,7 +17,7 @@ module Cucumber
         context "location" do
 
           context "with location passed to the constructor" do
-          let(:location) { double }
+            let(:location) { double }
 
             it "returns the location passed to the constructor" do
               action = Action.new(location) {}
@@ -151,4 +151,3 @@ module Cucumber
     end
   end
 end
-

data/spec/cucumber/core/test/case_spec.rb

@@ -13,11 +13,12 @@ module Cucumber
         include Core
         include Core::Gherkin::Writer
 
+        let(:id) { double }
         let(:name) { double }
         let(:location) { double }
         let(:tags) { double }
         let(:language) { double }
-        let(:test_case) { Test::Case.new(name, test_steps, location, tags, language) }
+        let(:test_case) { Test::Case.new(id, name, test_steps, location, tags, language) }
         let(:test_steps) { [double, double] }
 
         context 'describing itself' do
@@ -45,7 +46,7 @@ module Cucumber
             expect( first_hook ).to receive(:describe_to).ordered.and_yield
             expect( second_hook ).to receive(:describe_to).ordered.and_yield
             around_hooks = [first_hook, second_hook]
-            Test::Case.new(name, [], location, tags, language, around_hooks).describe_to(visitor, double)
+            Test::Case.new(id, name, [], location, tags, language, around_hooks).describe_to(visitor, double)
           end
 
         end

data/spec/cucumber/core/test/data_table_spec.rb

@@ -6,31 +6,29 @@ module Cucumber
   module Core
     module Test
       describe DataTable do
-        let(:location) { Test::Location.new('foo.feature', 9..12) }
-
         before do
           @table = DataTable.new([
             %w{one four seven},
             %w{4444 55555 666666}
-          ], location)
+          ])
         end
 
         describe "equality" do
           it "is equal to another table with the same data" do
-            expect( DataTable.new([[1,2],[3,4]], location) ).to eq DataTable.new([[1,2],[3,4]], location)
+            expect( DataTable.new([[1, 2], [3, 4]]) ).to eq DataTable.new([[1, 2], [3, 4]])
           end
 
           it "is not equal to another table with different data" do
-            expect( DataTable.new([[1,2],[3,4]], location) ).not_to eq DataTable.new([[1,2]], location)
+            expect( DataTable.new([[1, 2], [3, 4]]) ).not_to eq DataTable.new([[1, 2]])
           end
 
           it "is not equal to a non table" do
-            expect( DataTable.new([[1,2],[3,4]], location) ).not_to eq Object.new
+            expect( DataTable.new([[1, 2], [3, 4]]) ).not_to eq Object.new
           end
         end
 
         describe "#data_table?" do
-          let(:table) { DataTable.new([[1,2],[3,4]], location) }
+          let(:table) { DataTable.new([[1, 2], [3, 4]]) }
 
           it "returns true" do
             expect(table).to be_data_table
@@ -38,7 +36,7 @@ module Cucumber
         end
 
         describe "#doc_string" do
-          let(:table) { DataTable.new([[1,2],[3,4]], location) }
+          let(:table) { DataTable.new([[1, 2], [3, 4]]) }
 
           it "returns false" do
             expect(table).not_to be_doc_string
@@ -46,7 +44,7 @@ module Cucumber
         end
 
         describe "#map" do
-          let(:table) { DataTable.new([ %w{foo bar}, %w{1 2} ], location) }
+          let(:table) { DataTable.new([ %w{foo bar}, %w{1 2} ]) }
 
           it 'yields the contents of each cell to the block' do
 
@@ -54,7 +52,7 @@ module Cucumber
           end
 
           it 'returns a new table with the cells modified by the block' do
-            expect( table.map { |cell| "*#{cell}*" } ).to eq  DataTable.new([%w{*foo* *bar*}, %w{*1* *2*}], location)
+            expect( table.map { |cell| "*#{cell}*" } ).to eq DataTable.new([%w{*foo* *bar*}, %w{*1* *2*}])
           end
         end
 
@@ -63,14 +61,14 @@ module Cucumber
             @table = DataTable.new([
               %w{one 1111},
               %w{two 22222}
-            ], location)
+            ])
           end
 
           it "should transpose the table" do
             transposed = DataTable.new([
               %w{one two},
               %w{1111 22222}
-            ], location)
+            ])
             expect( @table.transpose ).to eq( transposed )
           end
         end

data/spec/cucumber/core/test/doc_string_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-require 'cucumber/core/test/location'
 require 'cucumber/core/test/doc_string'
 require 'unindent'
 
@@ -7,11 +6,10 @@ module Cucumber
   module Core
     module Test
       describe DocString do
-        let(:location) { double }
-        let(:doc_string) { DocString.new(content, content_type, location) }
+        let(:doc_string) { DocString.new(content, content_type) }
 
         describe "#data_table?" do
-          let(:doc_string) { DocString.new("test", "text/plain" , location) }
+          let(:doc_string) { DocString.new("test", "text/plain" ) }
 
           it "returns false" do
             expect(doc_string).not_to be_data_table
@@ -19,7 +17,7 @@ module Cucumber
         end
 
         describe "#doc_string" do
-          let(:doc_string) { DocString.new("test", "text/plain" , location) }
+          let(:doc_string) { DocString.new("test", "text/plain" ) }
 
           it "returns true" do
             expect(doc_string).to be_doc_string
@@ -48,15 +46,15 @@ module Cucumber
           let(:content_type) { 'text/plain' }
 
           it 'is equal to another DocString with the same content and content_type' do
-            expect( doc_string ).to eq DocString.new(content, content_type, location)
+            expect( doc_string ).to eq DocString.new(content, content_type)
           end
 
           it 'is not equal to another DocString with different content' do
-            expect( doc_string ).not_to eq DocString.new('bar', content_type, location)
+            expect( doc_string ).not_to eq DocString.new('bar', content_type)
           end
 
           it 'is not equal to another DocString with different content_type' do
-            expect( doc_string ).not_to eq DocString.new(content, 'text/html', location)
+            expect( doc_string ).not_to eq DocString.new(content, 'text/html')
           end
 
           it 'is equal to a string with the same content' do
@@ -96,13 +94,12 @@ module Cucumber
       end
 
       context "inspect" do
-        let(:location) { Test::Location.new("features/feature.feature", 8) }
         let(:content_type) { 'text/plain' }
 
         it "provides a useful inspect method" do
-          doc_string = DocString.new("some text", content_type, location)
+          doc_string = DocString.new("some text", content_type)
           expect(doc_string.inspect).to eq <<-END.chomp.unindent
-          #<Cucumber::Core::Test::DocString (features/feature.feature:8)
+          #<Cucumber::Core::Test::DocString
             """text/plain
             some text
             """>

data/spec/cucumber/core/test/location_spec.rb

@@ -19,9 +19,9 @@ module Cucumber::Core::Test
         expect( one_location ).to eq another_location
       end
 
-       it "is not equal to a wild card of the same file" do
-         expect( Location.new(file, line) ).not_to eq Location.new(file)
-       end
+      it "is not equal to a wild card of the same file" do
+        expect( Location.new(file, line) ).not_to eq Location.new(file)
+      end
 
       context "collections of locations" do
         it "behave as expected with uniq" do
@@ -45,7 +45,7 @@ module Cucumber::Core::Test
       end
 
       it "is file:line:line:line for an arbitrary set of lines" do
-        expect( Location.new("foo.feature", [1,3,5]).to_s ).to eq "foo.feature:1:3:5"
+        expect( Location.new("foo.feature", [1, 3, 5]).to_s ).to eq "foo.feature:1:3:5"
       end
     end
 
@@ -88,7 +88,7 @@ module Cucumber::Core::Test
     describe "created from source location" do
       context "when the location is in the tree below pwd" do
         it "create a relative path from pwd" do
-          expect( Location.from_source_location(Dir.pwd + "/path/file.rb", 1).file ).to eq "path/file.rb"
+          expect( Location.from_source_location("#{Dir.pwd}/path/file.rb", 1).file ).to eq "path/file.rb"
         end
       end
 
@@ -109,7 +109,7 @@ module Cucumber::Core::Test
 
     describe "created from file-colon-line" do
       it "handles also Windows paths" do
-        # Note: running this test on Windows will produce "c:/path/file.rb", but "c:\path\file.rb" on Linux.
+        # NOTE: running this test on Windows will produce "c:/path/file.rb", but "c:\path\file.rb" on Linux.
         expect( Location.from_file_colon_line("c:\\path\\file.rb:123").file ).to match(/c:(\\|\/)path(\\|\/)file.rb/)
       end
     end
@@ -119,7 +119,7 @@ module Cucumber::Core::Test
         expect( Location.of_caller.to_s ).to be_included_in caller[0]
       end
 
-      context "when specifying additional caller depth"do
+      context "when specifying additional caller depth" do
         it "use the location of the n:th caller" do
           expect( Location.of_caller(1).to_s ).to be_included_in caller[1]
         end

data/spec/cucumber/core/test/result_spec.rb

@@ -23,6 +23,11 @@ module Cucumber::Core::Test
         expect( result.to_s ).to eq "✓"
       end
 
+      it "converts to a Cucumber::Message::TestResult" do
+        message = result.to_message
+        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::PASSED)
+      end
+
       it "has a duration" do
         expect( result.duration ).to eq duration
       end
@@ -68,6 +73,11 @@ module Cucumber::Core::Test
         expect( result.duration ).to eq duration
       end
 
+      it "converts to a Cucumber::Message::TestResult" do
+        message = result.to_message
+        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::FAILED)
+      end
+
       it "requires both constructor arguments" do
         expect { Result::Failed.new }.to raise_error(ArgumentError)
         expect { Result::Failed.new(duration) }.to raise_error(ArgumentError)
@@ -131,6 +141,11 @@ module Cucumber::Core::Test
       specify { expect( result ).to     be_unknown   }
       specify { expect( result ).not_to be_skipped   }
       specify { expect( result ).not_to be_flaky     }
+
+      it "converts to a Cucumber::Message::TestResult" do
+        message = result.to_message
+        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::UNKNOWN)
+      end
     end
 
     describe Result::Raisable do
@@ -190,6 +205,11 @@ module Cucumber::Core::Test
         result.describe_to(visitor, args)
       end
 
+      it "converts to a Cucumber::Message::TestResult" do
+        message = result.to_message
+        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::UNDEFINED)
+      end
+
       specify { expect( result.to_sym ).to eq :undefined }
 
       specify { expect( result ).not_to be_passed    }
@@ -214,6 +234,11 @@ module Cucumber::Core::Test
         result.describe_to(visitor, args)
       end
 
+      it "converts to a Cucumber::Message::TestResult" do
+        message = result.to_message
+        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::SKIPPED)
+      end
+
       specify { expect( result.to_sym ).to eq :skipped }
 
       specify { expect( result ).not_to be_passed    }
@@ -236,6 +261,11 @@ module Cucumber::Core::Test
         result.describe_to(visitor, args)
       end
 
+      it "converts to a Cucumber::Message::TestResult" do
+        message = result.to_message
+        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::PENDING)
+      end
+
       specify { expect( result.to_sym ).to eq :pending }
 
       specify { expect( result ).not_to be_passed    }
@@ -259,7 +289,7 @@ module Cucumber::Core::Test
 
     describe Result::StrictConfiguration do
       subject(:strict_configuration) { Result::StrictConfiguration.new}
-      
+
       describe '#set_strict' do
         context 'no type argument' do
           it 'sets all result types to the setting argument' do
@@ -314,16 +344,16 @@ module Cucumber::Core::Test
       describe '#merge!' do
         let(:merged_configuration) { Result::StrictConfiguration.new }
         it 'sets the not default values from the argument accordingly' do
-            strict_configuration.set_strict(false, :undefined)
-            strict_configuration.set_strict(false, :pending)
-            strict_configuration.set_strict(true, :flaky)
-            merged_configuration.set_strict(true, :pending)
-            merged_configuration.set_strict(false, :flaky)
-            strict_configuration.merge!(merged_configuration)
-
-            expect( strict_configuration.strict?(:undefined) ).to be_falsey
-            expect( strict_configuration.strict?(:pending) ).to be_truthy
-            expect( strict_configuration.strict?(:flaky) ).to be_falsey
+          strict_configuration.set_strict(false, :undefined)
+          strict_configuration.set_strict(false, :pending)
+          strict_configuration.set_strict(true, :flaky)
+          merged_configuration.set_strict(true, :pending)
+          merged_configuration.set_strict(false, :flaky)
+          strict_configuration.merge!(merged_configuration)
+
+          expect( strict_configuration.strict?(:undefined) ).to be_falsey
+          expect( strict_configuration.strict?(:pending) ).to be_truthy
+          expect( strict_configuration.strict?(:flaky) ).to be_falsey
         end
       end
     end