cucumber-core 5.0.0 → 7.1.0

data/spec/cucumber/core/test/doc_string_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-require 'cucumber/core/test/location'
 require 'cucumber/core/test/doc_string'
 require 'unindent'
 
@@ -7,11 +6,10 @@ module Cucumber
   module Core
     module Test
       describe DocString do
-        let(:location) { double }
-        let(:doc_string) { DocString.new(content, content_type, location) }
+        let(:doc_string) { DocString.new(content, content_type) }
 
         describe "#data_table?" do
-          let(:doc_string) { DocString.new("test", "text/plain" , location) }
+          let(:doc_string) { DocString.new("test", "text/plain" ) }
 
           it "returns false" do
             expect(doc_string).not_to be_data_table
@@ -19,7 +17,7 @@ module Cucumber
         end
 
         describe "#doc_string" do
-          let(:doc_string) { DocString.new("test", "text/plain" , location) }
+          let(:doc_string) { DocString.new("test", "text/plain" ) }
 
           it "returns true" do
             expect(doc_string).to be_doc_string
@@ -48,15 +46,15 @@ module Cucumber
           let(:content_type) { 'text/plain' }
 
           it 'is equal to another DocString with the same content and content_type' do
-            expect( doc_string ).to eq DocString.new(content, content_type, location)
+            expect( doc_string ).to eq DocString.new(content, content_type)
           end
 
           it 'is not equal to another DocString with different content' do
-            expect( doc_string ).not_to eq DocString.new('bar', content_type, location)
+            expect( doc_string ).not_to eq DocString.new('bar', content_type)
           end
 
           it 'is not equal to another DocString with different content_type' do
-            expect( doc_string ).not_to eq DocString.new(content, 'text/html', location)
+            expect( doc_string ).not_to eq DocString.new(content, 'text/html')
           end
 
           it 'is equal to a string with the same content' do
@@ -96,13 +94,12 @@ module Cucumber
       end
 
       context "inspect" do
-        let(:location) { Test::Location.new("features/feature.feature", 8) }
         let(:content_type) { 'text/plain' }
 
         it "provides a useful inspect method" do
-          doc_string = DocString.new("some text", content_type, location)
+          doc_string = DocString.new("some text", content_type)
           expect(doc_string.inspect).to eq <<-END.chomp.unindent
-          #<Cucumber::Core::Test::DocString (features/feature.feature:8)
+          #<Cucumber::Core::Test::DocString
             """text/plain
             some text
             """>

data/spec/cucumber/core/test/location_spec.rb

@@ -100,14 +100,17 @@ module Cucumber::Core::Test
 
       context "when the location is neither below pwd nor in an installed gem" do
         it "use the absolute path to the file" do
-          expect( Location.from_source_location("/path/file.rb", 1).file ).to eq "/path/file.rb"
+          # Use File.expand on expectation to ensure tests work on multiple platform.
+          # On Windows, it will return "C:/path/file.rb" as an absolute path while it will return "/path/file.rb" on Linux.
+          expect( Location.from_source_location("/path/file.rb", 1).file ).to eq File.expand_path("/path/file.rb")
         end
       end
     end
 
     describe "created from file-colon-line" do
       it "handles also Windows paths" do
-        expect( Location.from_file_colon_line("c:\path\file.rb:123").file ).to eq "c:\path\file.rb"
+        # Note: running this test on Windows will produce "c:/path/file.rb", but "c:\path\file.rb" on Linux.
+        expect( Location.from_file_colon_line("c:\\path\\file.rb:123").file ).to match(/c:(\\|\/)path(\\|\/)file.rb/)
       end
     end
 

data/spec/cucumber/core/test/result_spec.rb

@@ -23,6 +23,11 @@ module Cucumber::Core::Test
         expect( result.to_s ).to eq "✓"
       end
 
+      it "converts to a Cucumber::Message::TestResult" do
+        message = result.to_message
+        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::PASSED)
+      end
+
       it "has a duration" do
         expect( result.duration ).to eq duration
       end
@@ -68,6 +73,11 @@ module Cucumber::Core::Test
         expect( result.duration ).to eq duration
       end
 
+      it "converts to a Cucumber::Message::TestResult" do
+        message = result.to_message
+        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::FAILED)
+      end
+
       it "requires both constructor arguments" do
         expect { Result::Failed.new }.to raise_error(ArgumentError)
         expect { Result::Failed.new(duration) }.to raise_error(ArgumentError)
@@ -131,6 +141,11 @@ module Cucumber::Core::Test
       specify { expect( result ).to     be_unknown   }
       specify { expect( result ).not_to be_skipped   }
       specify { expect( result ).not_to be_flaky     }
+
+      it "converts to a Cucumber::Message::TestResult" do
+        message = result.to_message
+        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::UNKNOWN)
+      end
     end
 
     describe Result::Raisable do
@@ -190,6 +205,11 @@ module Cucumber::Core::Test
         result.describe_to(visitor, args)
       end
 
+      it "converts to a Cucumber::Message::TestResult" do
+        message = result.to_message
+        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::UNDEFINED)
+      end
+
       specify { expect( result.to_sym ).to eq :undefined }
 
       specify { expect( result ).not_to be_passed    }
@@ -214,6 +234,11 @@ module Cucumber::Core::Test
         result.describe_to(visitor, args)
       end
 
+      it "converts to a Cucumber::Message::TestResult" do
+        message = result.to_message
+        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::SKIPPED)
+      end
+
       specify { expect( result.to_sym ).to eq :skipped }
 
       specify { expect( result ).not_to be_passed    }
@@ -236,6 +261,11 @@ module Cucumber::Core::Test
         result.describe_to(visitor, args)
       end
 
+      it "converts to a Cucumber::Message::TestResult" do
+        message = result.to_message
+        expect(message.status).to eq(Cucumber::Messages::TestStepFinished::TestStepResult::Status::PENDING)
+      end
+
       specify { expect( result.to_sym ).to eq :pending }
 
       specify { expect( result ).not_to be_passed    }
@@ -259,7 +289,7 @@ module Cucumber::Core::Test
 
     describe Result::StrictConfiguration do
       subject(:strict_configuration) { Result::StrictConfiguration.new}
-      
+
       describe '#set_strict' do
         context 'no type argument' do
           it 'sets all result types to the setting argument' do

data/spec/cucumber/core/test/runner_spec.rb

@@ -7,19 +7,21 @@ require 'cucumber/core/test/duration_matcher'
 module Cucumber::Core::Test
   describe Runner do
 
+    let(:step_id)   { double }
+    let(:test_id)   { double }
     let(:name)      { double }
     let(:location)  { double }
     let(:tags)      { double }
     let(:language)  { double }
-    let(:test_case) { Case.new(name, test_steps, location, tags, language) }
+    let(:test_case) { Case.new(test_id, name, test_steps, location, tags, language) }
     let(:text)      { double }
     let(:runner)    { Runner.new(event_bus) }
     let(:event_bus) { double.as_null_object }
-    let(:passing)   { Step.new(text, location, location).with_action {} }
-    let(:failing)   { Step.new(text, location, location).with_action { raise exception } }
-    let(:pending)   { Step.new(text, location, location).with_action { raise Result::Pending.new("TODO") } }
-    let(:skipping)  { Step.new(text, location, location).with_action { raise Result::Skipped.new } }
-    let(:undefined) { Step.new(text, location, location) }
+    let(:passing)   { Step.new(step_id, text, location, location).with_action {} }
+    let(:failing)   { Step.new(step_id, text, location, location).with_action { raise exception } }
+    let(:pending)   { Step.new(step_id, text, location, location).with_action { raise Result::Pending.new("TODO") } }
+    let(:skipping)  { Step.new(step_id, text, location, location).with_action { raise Result::Skipped.new } }
+    let(:undefined) { Step.new(step_id, text, location, location) }
     let(:exception) { StandardError.new('test error') }
 
     before do
@@ -223,8 +225,8 @@ module Cucumber::Core::Test
 
     context 'with multiple test cases' do
       context 'when the first test case fails' do
-        let(:first_test_case) { Case.new(name, [failing], location, tags, language) }
-        let(:last_test_case)  { Case.new(name, [passing], location, tags, language) }
+        let(:first_test_case) { Case.new(test_id, name, [failing], location, tags, language) }
+        let(:last_test_case)  { Case.new(test_id, name, [passing], location, tags, language) }
         let(:test_cases)      { [first_test_case, last_test_case] }
 
         it 'reports the results correctly for the following test case' do
@@ -244,9 +246,9 @@ module Cucumber::Core::Test
         hook_mapping = UnskippableAction.new do |last_result|
           result_spy = last_result
         end
-        after_hook = HookStep.new(text, location, hook_mapping)
-        failing_step = Step.new(text, location).with_action { fail }
-        test_case = Case.new(name, [failing_step, after_hook], location, tags, language)
+        after_hook = HookStep.new(step_id, text, location, hook_mapping)
+        failing_step = Step.new(step_id, text, location).with_action { fail }
+        test_case = Case.new(test_id, name, [failing_step, after_hook], location, tags, language)
         test_case.describe_to runner
         expect(result_spy).to be_failed
       end
@@ -256,8 +258,8 @@ module Cucumber::Core::Test
     context "with around hooks" do
       it "passes normally when around hooks don't fail" do
         around_hook = AroundHook.new { |block| block.call }
-        passing_step = Step.new(text, location, location).with_action {}
-        test_case = Case.new(name, [passing_step], location, tags, language, [around_hook])
+        passing_step = Step.new(step_id, text, location, location).with_action {}
+        test_case = Case.new(test_id, name, [passing_step], location, tags, language, [around_hook])
         expect(event_bus).to receive(:test_case_finished).with(test_case, anything) do |reported_test_case, result|
           expect(result).to be_passed
         end
@@ -266,8 +268,8 @@ module Cucumber::Core::Test
 
       it "gets a failed result if the Around hook fails before the test case is run" do
         around_hook = AroundHook.new { |block| raise exception }
-        passing_step = Step.new(text, location, location).with_action {}
-        test_case = Case.new(name, [passing_step], location, tags, language, [around_hook])
+        passing_step = Step.new(step_id, text, location, location).with_action {}
+        test_case = Case.new(test_id, name, [passing_step], location, tags, language, [around_hook])
         expect(event_bus).to receive(:test_case_finished).with(test_case, anything) do |reported_test_case, result|
           expect(result).to be_failed
           expect(result.exception).to eq exception
@@ -277,8 +279,8 @@ module Cucumber::Core::Test
 
       it "gets a failed result if the Around hook fails after the test case is run" do
         around_hook = AroundHook.new { |block| block.call; raise exception }
-        passing_step = Step.new(text, location, location).with_action {}
-        test_case = Case.new(name, [passing_step], location, tags, language, [around_hook])
+        passing_step = Step.new(step_id, text, location, location).with_action {}
+        test_case = Case.new(test_id, name, [passing_step], location, tags, language, [around_hook])
         expect(event_bus).to receive(:test_case_finished).with(test_case, anything) do |reported_test_case, result|
           expect(result).to be_failed
           expect(result.exception).to eq exception
@@ -288,8 +290,8 @@ module Cucumber::Core::Test
 
       it "fails when a step fails if the around hook works" do
         around_hook = AroundHook.new { |block| block.call }
-        failing_step = Step.new(text, location, location).with_action { raise exception }
-        test_case = Case.new(name, [failing_step], location, tags, language, [around_hook])
+        failing_step = Step.new(step_id, text, location, location).with_action { raise exception }
+        test_case = Case.new(test_id, name, [failing_step], location, tags, language, [around_hook])
         expect(event_bus).to receive(:test_case_finished).with(test_case, anything) do |reported_test_case, result|
           expect(result).to be_failed
           expect(result.exception).to eq exception
@@ -299,8 +301,8 @@ module Cucumber::Core::Test
 
       it "sends after_test_step for a step interrupted by (a timeout in) the around hook" do
         around_hook = AroundHook.new { |block| block.call; raise exception }
-        passing_step = Step.new(text, location, location).with_action {}
-        test_case = Case.new(name, [], location, tags, language, [around_hook])
+        passing_step = Step.new(step_id, text, location, location).with_action {}
+        test_case = Case.new(test_id, name, [], location, tags, language, [around_hook])
         allow(runner).to receive(:running_test_step).and_return(passing_step)
         expect(event_bus).to receive(:test_step_finished).with(passing_step, anything) do |reported_test_case, result|
           expect(result).to be_failed

data/spec/cucumber/core/test/step_spec.rb

@@ -3,6 +3,7 @@ require 'cucumber/core/test/step'
 
 module Cucumber::Core::Test
   describe Step do
+    let(:id) { 'some-random-uid' }
     let(:text) { 'step text' }
     let(:location) { double }
 
@@ -10,7 +11,7 @@ module Cucumber::Core::Test
       it "describes itself to a visitor" do
         visitor = double
         args = double
-        test_step = Step.new(text, location)
+        test_step = Step.new(id, text, location)
         expect( visitor ).to receive(:test_step).with(test_step, args)
         test_step.describe_to(visitor, args)
       end
@@ -19,7 +20,7 @@ module Cucumber::Core::Test
     describe "backtrace line" do
       let(:text) { 'this step passes' }
       let(:location)  { Location.new('path/file.feature', 10) }
-      let(:test_step) { Step.new(text, location) }
+      let(:test_step) { Step.new(id, text, location) }
 
       it "knows how to form the backtrace line" do
         expect( test_step.backtrace_line ).to eq("path/file.feature:10:in `this step passes'")
@@ -30,7 +31,7 @@ module Cucumber::Core::Test
       it "passes arbitrary arguments to the action's block" do
         args_spy = nil
         expected_args = [double, double]
-        test_step = Step.new(text, location).with_action do |*actual_args|
+        test_step = Step.new(id, text, location).with_action do |*actual_args|
           args_spy = actual_args
         end
         test_step.execute(*expected_args)
@@ -39,7 +40,7 @@ module Cucumber::Core::Test
 
       context "when a passing action exists" do
         it "returns a passing result" do
-          test_step = Step.new(text, location).with_action {}
+          test_step = Step.new(id, text, location).with_action {}
           expect( test_step.execute ).to be_passed
         end
       end
@@ -48,7 +49,7 @@ module Cucumber::Core::Test
         let(:exception) { StandardError.new('oops') }
 
         it "returns a failing result" do
-          test_step = Step.new(text, location).with_action { raise exception }
+          test_step = Step.new(id, text, location).with_action { raise exception }
           result = test_step.execute
           expect( result           ).to be_failed
           expect( result.exception ).to eq exception
@@ -57,7 +58,7 @@ module Cucumber::Core::Test
 
       context "with no action" do
         it "returns an Undefined result" do
-          test_step = Step.new(text, location)
+          test_step = Step.new(id, text, location)
           result = test_step.execute
           expect( result           ).to be_undefined
         end
@@ -65,7 +66,7 @@ module Cucumber::Core::Test
     end
 
     it "exposes the text and location of as attributes" do
-      test_step = Step.new(text, location)
+      test_step = Step.new(id, text, location)
       expect( test_step.text              ).to eq text
       expect( test_step.location          ).to eq location
     end
@@ -73,13 +74,13 @@ module Cucumber::Core::Test
     it "exposes the location of the action as attribute" do
       location = double
       action = double(location: location)
-      test_step = Step.new(text, location, action)
+      test_step = Step.new(id, text, location, action)
       expect( test_step.action_location ).to eq location
     end
 
     it "returns the text when converted to a string" do
       text = 'a passing step'
-      test_step = Step.new(text, location)
+      test_step = Step.new(id, text, location)
       expect( test_step.to_s     ).to eq 'a passing step'
     end
 

data/spec/cucumber/core_spec.rb

@@ -170,7 +170,7 @@ module Cucumber
       context "with around hooks" do
         class WithAroundHooks < Core::Filter.new(:logger)
           def test_case(test_case)
-            base_step = Core::Test::Step.new('text', nil, nil, nil)
+            base_step = Core::Test::Step.new('some-random-uid', 'text', nil, nil, nil)
             test_steps = [
               base_step.with_action { logger << :step },
             ]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-core
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 7.1.0
 platform: ruby
 authors:
 - Aslak Hellesøy
@@ -9,169 +9,171 @@ authors:
 - Steve Tooke
 - Oleg Sukhodolsky
 - Tom Brand
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-08-15 00:00:00.000000000 Z
+date: 2020-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: gherkin
+  name: cucumber-gherkin
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '14.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 7.0.3
+        version: 14.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '14.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 7.0.3
+        version: 14.0.1
 - !ruby/object:Gem::Dependency
-  name: cucumber-tag_expressions
+  name: cucumber-messages
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.2
+        version: 12.2.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.2
+        version: 12.2.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.2'
 - !ruby/object:Gem::Dependency
-  name: backports
+  name: cucumber-tag-expressions
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.15'
+        version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.15.0
+        version: 2.0.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.15'
+        version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.15.0
+        version: 2.0.4
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.16.0
+        version: 0.8.23
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.16.0
+        version: 0.8.23
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.9.2
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
+        version: 13.0.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.6'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 13.0.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.6'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
-  name: unindent
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: kramdown
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
+        version: 0.78.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.4.2
+        version: '0.78'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.78.0
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.4.2
+        version: '0.78'
 - !ruby/object:Gem::Dependency
-  name: yard
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.9.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.9.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.9'
 - !ruby/object:Gem::Dependency
-  name: coveralls
+  name: unindent
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.0'
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.0'
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '1.0'
 description: Core library for the Cucumber BDD app
 email: cukes@googlegroups.com
 executables: []
@@ -244,7 +246,7 @@ metadata:
   documentation_uri: https://www.rubydoc.info/github/cucumber/cucumber-ruby-core
   mailing_list_uri: https://groups.google.com/forum/#!forum/cukes
   source_code_uri: https://github.com/cucumber/cucumber-ruby-core
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--charset=UTF-8"
 require_paths:
@@ -253,18 +255,17 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.2'
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14.4
-signing_key: 
+rubygems_version: 3.0.6
+signing_key:
 specification_version: 4
-summary: cucumber-core-5.0.0
+summary: cucumber-core-7.1.0
 test_files:
 - spec/cucumber/core/test/runner_spec.rb
 - spec/cucumber/core/test/doc_string_spec.rb