cucumber-core 3.0.0.pre.2 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 14ae96e7b157ead29d3bb55f9590dd59abdf2878
-  data.tar.gz: 72d1ed6b3b96b8d19c92ffa81d6b1be7ae690a7a
+  metadata.gz: 15cf4b980313f359f353c814b64882a6e4813284
+  data.tar.gz: e43878f811006e883fed0da63d468a8aad348963
 SHA512:
-  metadata.gz: da7bd878d405691af0f96191da9e1d32caf7802e7d14ef039c206c524ced53c46305c12e74a8ff8362eef619e54cefa606949424609a1f576a1435cb3754879d
-  data.tar.gz: b1c03286e6851861e1532547825bc2bd096881acb5140a0cc1717373edbb288620960bf0bb34890459294b020e70bedb0cebd0798a4a3b394a17b0f9e019753d
+  metadata.gz: 32015aeac82148a7b00f2f32ae2df457cd63660f1cd8dcbcad8da9bda36dfb3cb8b20bd43312488c19ab3e18074940d90c9ad01826101843e8a1e810930768a1
+  data.tar.gz: 8d57d02175e18afc9623bb981a997789561f4ce5a00492e31a9e2a2ad0436a3260210d1342924f7e0c51c2e8056b97f7d0e2d48df456eb8bf11b7dba87d919b7

data/.travis.yml

@@ -9,9 +9,12 @@ matrix:
     - rvm: 2.2
     - rvm: 2.1
     - rvm: 2.0.0
-    - rvm: jruby-9.1.12.0
+    - rvm: jruby-9.1.13.0
       env:
         - JRUBY_OPTS="--debug"
+        - LC_ALL=en_US.UTF-8
+        - LANG=en_US.UTF-8
+        - LANGUAGE=en_US.UTF-8        
   allow_failures:
     - rvm: ruby-head
   fast_finish: true

data/{HISTORY.md → CHANGELOG.md}

@@ -1,9 +1,42 @@
-## [In Git](https://github.com/cucumber/cucumber-ruby-core/compare/3.0.0.pre.2...master)
+Please see [CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CONTRIBUTING.md) on how to contribute to Cucumber.
 
-### New Features
-### Bugfixes
-### Removed Features
-### Refactoring
+## [In Git](https://github.com/cucumber/cucumber-ruby-core/compare/v3.0.0...master) (targetting 3.1.0)
+
+### Changed
+
+* N/A
+
+### Added
+
+* N/A
+
+### Fixed
+
+* N/A
+
+### Improved
+
+* N/A
+
+## [3.0.0](https://github.com/cucumber/cucumber-ruby-core/compare/v3.0.0.pre.2...v3.0.0) (2017-09-27)
+
+### Changed
+
+* Step#name renamed to #text ([#137](https://github.com/cucumber/cucumber-ruby-core/pull/137) [@olleolleolle](https://github.com/olleolleolle))
+* Use past tense in event names (`xStarting` -> `xStarted`) (see [cucumber/cucumber-ruby#1166](https://github.com/cucumber/cucumber-ruby/issues/1166) @brasmusson).
+
+### Added
+
+* Do not create test cases for scenarios with no steps ([#144](https://github.com/cucumber/cucumber-ruby-core/pull/144) @brasmusson)
+* Handle selective strict settings ([#143](https://github.com/cucumber/cucumber-ruby-core/pull/143) @brasmusson)
+
+### Fixed
+
+* Fix DataTable's Location to be aware of all of its lines ([#142](https://github.com/cucumber/cucumber-ruby-core/pull/142) @botandrose)
+
+### Improved
+
+* As per [#251](https://github.com/cucumber/cucumber/issues/251): renamed History.md to CHANGELOG.md, added contributing message at beginning, and misc formatting. ([#145](https://github.com/cucumber/cucumber-ruby-core/pull/145) [jaysonesmith](https://github.com/jaysonesmith))
 
 ## [3.0.0.pre.2](https://github.com/cucumber/cucumber-ruby-core/compare/v2.0.0...3.0.0.pre.2) (2017-07-26)
 

data/CONTRIBUTING.md

@@ -2,9 +2,8 @@ Release Process
 ===============
 
 * Bump the version number in `lib/cucumber/core/version.rb`
-* Update `HISTORY.md` is updated with the upcoming version number and entries
-  for all changes recorded.
-* Now release it
+* Update `CHANGELOG.md` with the upcoming version number and create a new `In Git` section
+* Now release it:
 
 ```
 bundle update

data/README.md

@@ -75,7 +75,7 @@ class ActivateSteps < Cucumber::Core::Filter.new
   private
 
   def activate(step)
-    case step.name
+    case step.text
     when /fail/
       step.with_action { raise Failure }
     when /pass/
@@ -105,7 +105,7 @@ end
 MyRunner.new.execute([feature], [ActivateSteps.new]) do |events|
   events.on(:test_step_finished) do |event|
     test_step, result = event.test_step, event.result
-    puts "#{test_step.name} #{result}"
+    puts "#{test_step.text} #{result}"
   end
 end
 ```

data/lib/cucumber/core/ast/empty_multiline_argument.rb

@@ -23,10 +23,6 @@ module Cucumber
           []
         end
 
-        def to_sexp
-          []
-        end
-
         def inspect
           "#<#{self.class}>"
         end

data/lib/cucumber/core/ast/feature.rb

@@ -42,16 +42,6 @@ module Cucumber
           end
         end
 
-        def to_sexp
-          sexp = [:feature, file, name]
-          comment = @comment.to_sexp
-          sexp += [comment] if comment
-          tags = @tags.to_sexp
-          sexp += tags if tags.any?
-          sexp += @feature_elements.map{|fe| fe.to_sexp}
-          sexp
-        end
-
         private
 
         def description_for_visitors

data/lib/cucumber/core/ast/outline_step.rb

@@ -11,19 +11,23 @@ module Cucumber
         include HasLocation
         include DescribesItself
 
-        attr_reader :language, :location, :comments, :keyword, :name, :multiline_arg
+        attr_reader :language, :location, :comments, :keyword, :text, :multiline_arg
 
         def initialize(language, location, comments, keyword, text, multiline_arg)
-          @language, @location, @comments, @keyword, @name, @multiline_arg = language, location, comments, keyword, text, multiline_arg
+          @language, @location, @comments, @keyword, @text, @multiline_arg = language, location, comments, keyword, text, multiline_arg
         end
 
         def to_step(row)
-          Ast::ExpandedOutlineStep.new(self, language, row.location, comments, keyword, row.expand(name), replace_multiline_arg(row))
+          Ast::ExpandedOutlineStep.new(self, language, row.location, comments, keyword, row.expand(text), replace_multiline_arg(row))
+        end
+
+        def to_s
+          text
         end
 
         def inspect
-          keyword_and_name = [keyword, name].join(": ")
-          %{#<#{self.class} "#{keyword_and_name}" (#{location})>}
+          keyword_and_text = [keyword, text].join(": ")
+          %{#<#{self.class} "#{keyword_and_text}" (#{location})>}
         end
 
         private
@@ -47,4 +51,3 @@ module Cucumber
     end
   end
 end
-

data/lib/cucumber/core/ast/scenario.rb

@@ -31,16 +31,6 @@ module Cucumber
           raw_steps
         end
 
-        def to_sexp
-          sexp = [:scenario, line, keyword, name]
-          comment = comment.to_sexp
-          sexp += [comment] if comment
-          tags = tags.to_sexp
-          sexp += tags if tags.any?
-          sexp += step_invocations.to_sexp if step_invocations.any?
-          sexp
-        end
-
         private
 
         def description_for_visitors

data/lib/cucumber/core/ast/step.rb

@@ -9,18 +9,18 @@ module Cucumber
         include HasLocation
         include DescribesItself
 
-        attr_reader :keyword, :name, :language, :comments, :exception, :multiline_arg
+        attr_reader :keyword, :text, :language, :comments, :exception, :multiline_arg
 
-        def initialize(language, location, comments, keyword, name, multiline_arg)
-          @language, @location, @comments, @keyword, @name, @multiline_arg = language, location, comments, keyword, name, multiline_arg
+        def initialize(language, location, comments, keyword, text, multiline_arg)
+          @language, @location, @comments, @keyword, @text, @multiline_arg = language, location, comments, keyword, text, multiline_arg
         end
 
-        def to_sexp
-          [:step, line, keyword, name, @multiline_arg.to_sexp]
+        def to_s
+          text
         end
 
         def backtrace_line
-          "#{location}:in `#{keyword}#{name}'"
+          "#{location}:in `#{keyword}#{text}'"
         end
 
         def actual_keyword(previous_step_keyword = nil)
@@ -36,8 +36,8 @@ module Cucumber
         end
 
         def inspect
-          keyword_and_name = [keyword, name].join(": ")
-          %{#<#{self.class} "#{keyword_and_name}" (#{location})>}
+          keyword_and_text = [keyword, text].join(": ")
+          %{#<#{self.class} "#{keyword_and_text}" (#{location})>}
         end
 
         private
@@ -53,8 +53,8 @@ module Cucumber
 
       class ExpandedOutlineStep < Step
 
-        def initialize(outline_step, language, location, comments, keyword, name, multiline_arg)
-          @outline_step, @language, @location, @comments, @keyword, @name, @multiline_arg = outline_step, language, location, comments, keyword, name, multiline_arg
+        def initialize(outline_step, language, location, comments, keyword, text, multiline_arg)
+          @outline_step, @language, @location, @comments, @keyword, @text, @multiline_arg = outline_step, language, location, comments, keyword, text, multiline_arg
         end
 
         def all_locations
@@ -65,7 +65,7 @@ module Cucumber
 
         def backtrace_line
           "#{step_backtrace_line}\n" +
-          "#{@outline_step.location}:in `#{@outline_step.keyword}#{@outline_step.name}'"
+          "#{@outline_step.location}:in `#{@outline_step.keyword}#{@outline_step.text}'"
         end
 
       end

data/lib/cucumber/core/compiler.rb

@@ -45,7 +45,7 @@ module Cucumber
         end
 
         def on_test_case(source)
-          Test::Case.new(test_steps, source).describe_to(receiver)
+          Test::Case.new(test_steps, source).describe_to(receiver) if test_steps.count > 0
           @test_steps = nil
           self
         end

data/lib/cucumber/core/events.rb

@@ -5,7 +5,7 @@ module Cucumber
     module Events
 
       # Signals that a {Test::Case} is about to be executed
-      class TestCaseStarting < Event.new(:test_case)
+      class TestCaseStarted < Event.new(:test_case)
 
         # @return [Test::Case] the test case to be executed
         attr_reader :test_case
@@ -13,7 +13,7 @@ module Cucumber
       end
 
       # Signals that a {Test::Step} is about to be executed
-      class TestStepStarting < Event.new(:test_step)
+      class TestStepStarted < Event.new(:test_step)
 
         # @return [Test::Step] the test step to be executed
         attr_reader :test_step
@@ -47,8 +47,8 @@ module Cucumber
       # that will be used by the {EventBus} by default.
       def self.registry
         build_registry(
-          TestCaseStarting,
-          TestStepStarting,
+          TestCaseStarted,
+          TestStepStarted,
           TestStepFinished,
           TestCaseFinished,
         )

data/lib/cucumber/core/gherkin/ast_builder.rb

@@ -373,6 +373,12 @@ module Cucumber
           def rows
             attributes[:rows] = attributes[:rows].map { |r| r[:cells].map { |c| c[:value] } }
           end
+
+          def location
+            first_line = attributes[:location][:line]
+            last_line = first_line + attributes[:rows].length - 1
+            Ast::Location.new(file, first_line..last_line)
+          end
         end
 
         class DocStringBuilder < Builder

data/lib/cucumber/core/report/summary.rb

@@ -12,7 +12,7 @@ module Cucumber
           subscribe_to(event_bus)
         end
 
-        def ok?(be_strict = false)
+        def ok?(be_strict = Test::Result::StrictConfiguration.new)
           test_cases.ok?(be_strict)
         end
 

data/lib/cucumber/core/test/filters/activate_steps_for_self_test.rb

@@ -13,7 +13,7 @@ module Cucumber
 
           def test_case(test_case)
             test_steps = test_case.test_steps.map do |step|
-              case step.name
+              case step.text
               when /fail/
                 step.with_action { raise Failure }
               when /pending/

data/lib/cucumber/core/test/result.rb

@@ -6,11 +6,12 @@ module Cucumber
     module Test
       module Result
         TYPES = [:failed, :flaky, :skipped, :undefined, :pending, :passed, :unknown].freeze
+        STRICT_AFFECTED_TYPES = [:flaky, :undefined, :pending].freeze
 
-        def self.ok?(type, be_strict = false)
+        def self.ok?(type, be_strict = StrictConfiguration.new)
           private
           class_name = type.to_s.slice(0, 1).capitalize + type.to_s.slice(1..-1)
-          const_get(class_name).ok?(be_strict)
+          const_get(class_name).ok?(be_strict.strict?(type))
         end
 
         # Defines to_sym on a result class for the given result type
@@ -67,8 +68,8 @@ module Cucumber
             "✓"
           end
 
-          def ok?(be_strict = false)
-            self.class.ok?(be_strict)
+          def ok?(be_strict = nil)
+            self.class.ok?
           end
 
           def with_appended_backtrace(step)
@@ -106,8 +107,8 @@ module Cucumber
             "✗"
           end
 
-          def ok?(be_strict = false)
-            self.class.ok?(be_strict)
+          def ok?(be_strict = nil)
+            self.class.ok?
           end
 
           def with_duration(new_duration)
@@ -164,8 +165,8 @@ module Cucumber
             filter.new(dup).exception
           end
 
-          def ok?(be_strict = false)
-            self.class.ok?(be_strict)
+          def ok?(be_strict = StrictConfiguration.new)
+            self.class.ok?(be_strict.strict?(to_sym))
           end
         end
 
@@ -223,6 +224,54 @@ module Cucumber
           end
         end
 
+        # Handles the strict settings for the result types that are
+        # affected by the strict options (that is the STRICT_AFFECTED_TYPES).
+        class StrictConfiguration
+          attr_accessor :settings
+          private :settings
+          
+          def initialize(strict_types = [])
+            @settings = Hash[STRICT_AFFECTED_TYPES.map { |t| [t, :default] }]
+            strict_types.each do |type|
+              set_strict(true, type)
+            end
+          end
+
+          def strict?(type = nil)
+            if type.nil?
+              settings.each do |_key, value|
+                return true if value == true
+              end
+              false
+            else
+              return false unless settings.key?(type)
+              return false unless set?(type)
+              settings[type]
+            end
+          end
+
+          def set_strict(setting, type = nil)
+            if type.nil?
+              STRICT_AFFECTED_TYPES.each do |t|
+                set_strict(setting, t)
+              end
+            else
+              settings[type] = setting
+            end
+          end
+
+          def merge!(other)
+            settings.keys.each do |type|
+              set_strict(other.strict?(type), type) if other.set?(type)
+            end
+            self
+          end
+
+          def set?(type)
+            settings[type] != :default
+          end
+        end
+
         #
         # An object that responds to the description protocol from the results
         # and collects summary information.
@@ -250,7 +299,7 @@ module Cucumber
             end
           end
 
-          def ok?(be_strict = false)
+          def ok?(be_strict = StrictConfiguration.new)
             TYPES.each do |type|
               if get_total(type) > 0
                 return false unless Result.ok?(type, be_strict)

data/lib/cucumber/core/test/runner.rb

@@ -15,7 +15,7 @@ module Cucumber
         def test_case(test_case, &descend)
           @running_test_case = RunningTestCase.new
           @running_test_step = nil
-          event_bus.test_case_starting(test_case)
+          event_bus.test_case_started(test_case)
           descend.call(self)
           event_bus.test_case_finished(test_case, running_test_case.result)
           self
@@ -23,7 +23,7 @@ module Cucumber
 
         def test_step(test_step)
           @running_test_step = test_step
-          event_bus.test_step_starting test_step
+          event_bus.test_step_started test_step
           step_result = running_test_case.execute(test_step)
           event_bus.test_step_finished test_step, step_result
           @running_test_step = nil
@@ -102,7 +102,7 @@ module Cucumber
 
               def execute(test_step, monitor, &continue)
                 result = test_step.execute(monitor.result, &continue)
-                result = result.with_message(%(Undefined step: "#{test_step.name}")) if result.undefined?
+                result = result.with_message(%(Undefined step: "#{test_step.text}")) if result.undefined?
                 result = result.with_appended_backtrace(test_step.source.last) if IsStepVisitor.new(test_step).step?
                 result.describe_to(monitor, result)
               end

data/lib/cucumber/core/test/step.rb

@@ -36,8 +36,12 @@ module Cucumber
           self.class.new(source, Test::Action.new(location, &block))
         end
 
-        def name
-          source.last.name
+        def text
+          source.last.text
+        end
+
+        def to_s
+          text
         end
 
         def location

data/lib/cucumber/core/version.rb

@@ -3,7 +3,7 @@ module Cucumber
   module Core
     class Version
       def self.to_s
-        "3.0.0.pre.2"
+        "3.0.0"
       end
     end
   end

data/spec/cucumber/core/ast/outline_step_spec.rb

@@ -9,12 +9,12 @@ module Cucumber
   module Core
     module Ast
       describe OutlineStep do
-        let(:outline_step) { OutlineStep.new(language, location, comments, keyword, name, multiline_arg) }
+        let(:outline_step) { OutlineStep.new(language, location, comments, keyword, text, multiline_arg) }
         let(:language) { double }
         let(:location) { double }
         let(:comments)  { double }
         let(:keyword)  { double }
-        let(:name)     { 'anything' }
+        let(:text)     { 'anything' }
         let(:multiline_arg) { EmptyMultilineArgument.new }
 
         describe 'location' do
@@ -28,6 +28,12 @@ module Cucumber
           end
         end
 
+        describe "to_s" do
+          it "returns the text of the step" do
+            expect(outline_step.to_s).to eq 'anything'
+          end
+        end
+
         describe 'comments' do
           it "has comments" do
             expect( outline_step ).to respond_to(:comments)
@@ -36,18 +42,18 @@ module Cucumber
 
         describe "converting to a Step" do
           context "a single argument in the name" do
-            let(:name) { 'a <color> cucumber' }
+            let(:text) { 'a <color> cucumber' }
 
             it "replaces the argument" do
               row = ExamplesTable::Row.new({'color' => 'green'}, 1, location, language, comments)
-              expect( outline_step.to_step(row).name ).to eq 'a green cucumber'
+              expect( outline_step.to_step(row).text ).to eq 'a green cucumber'
             end
 
           end
 
           context "when the step has a DataTable" do
-            let(:outline_step) { OutlineStep.new(language, location, comments, keyword, name, table) }
-            let(:name)  { "anything" }
+            let(:outline_step) { OutlineStep.new(language, location, comments, keyword, text, table) }
+            let(:text)  { "anything" }
             let(:table) { DataTable.new([['x', 'y'],['a', 'a <arg>']], Location.new('foo.feature', 23)) }
 
             it "replaces the arguments in the DataTable" do
@@ -64,9 +70,9 @@ module Cucumber
 
           context "when the step has a DocString" do
             let(:location) { double }
-            let(:outline_step) { OutlineStep.new(language, location, comments, keyword, name, doc_string) }
+            let(:outline_step) { OutlineStep.new(language, location, comments, keyword, text, doc_string) }
             let(:doc_string) { DocString.new('a <arg> that needs replacing', '', location) }
-            let(:name) { 'anything' }
+            let(:text) { 'anything' }
 
             it "replaces the arguments in the DocString" do
               visitor = double

data/spec/cucumber/core/ast/step_spec.rb

@@ -9,9 +9,17 @@ module Cucumber
     module Ast
       describe Step do
         let(:step) do
-          language, location, comments, keyword, name = *double
+          text = "a passing step"
+          keyword = "Given"
+          language, location, comments = *double
           multiline_arg = EmptyMultilineArgument.new
-          Step.new(language, location, comments, keyword, name, multiline_arg)
+          Step.new(language, location, comments, keyword, text, multiline_arg)
+        end
+
+        describe "to_s" do
+          it("returns the text of the step") do
+            expect(step.to_s).to eq("a passing step")
+          end
         end
 
         describe "describing itself" do
@@ -109,10 +117,10 @@ module Cucumber
       describe ExpandedOutlineStep do
         let(:outline_step) { double }
         let(:step) do
-          language, location, keyword, name = *double
+          language, location, keyword, text = *double
           multiline_arg = EmptyMultilineArgument.new
           comments = []
-          ExpandedOutlineStep.new(outline_step, language, location, comments, keyword, name, multiline_arg)
+          ExpandedOutlineStep.new(outline_step, language, location, comments, keyword, text, multiline_arg)
         end
 
         describe "describing itself" do

data/spec/cucumber/core/compiler_spec.rb

@@ -139,7 +139,7 @@ module Cucumber::Core
           expect( visitor ).to receive(:test_step) do |test_step|
             visit_source(test_step) do |source_visitor|
               expect( source_visitor ).to receive(:step) do |step|
-                expect(step.name).to eq 'passing 1 with 2'
+                expect(step.text).to eq 'passing 1 with 2'
               end
             end
           end.once.ordered
@@ -147,7 +147,7 @@ module Cucumber::Core
           expect( visitor ).to receive(:test_step) do |test_step|
             visit_source(test_step) do |source_visitor|
               expect( source_visitor ).to receive(:step) do |step|
-                expect(step.name).to eq 'as well as 3'
+                expect(step.text).to eq 'as well as 3'
               end
             end
           end.once.ordered
@@ -157,6 +157,23 @@ module Cucumber::Core
       end
     end
 
+    context 'empty scenarios' do
+      it 'does not create test cases for them' do
+        gherkin_documents = [
+          gherkin do
+            feature do
+              scenario do
+              end
+            end
+          end
+        ]
+        compile(gherkin_documents) do |visitor|
+          expect( visitor ).to receive(:test_case).never
+          expect( visitor ).to receive(:done).once.ordered
+        end
+      end
+    end
+
     describe Compiler::FeatureCompiler do
       let(:receiver) { double('receiver') }
       let(:compiler) { Compiler::FeatureCompiler.new(receiver) }

data/spec/cucumber/core/filter_spec.rb

@@ -30,7 +30,7 @@ module Cucumber::Core
         my_filter = my_filter_class.new
         expect(receiver).to receive(:test_case) { |test_case|
           expect(test_case.test_steps.length).to eq 1
-          expect(test_case.test_steps.first.name).to eq 'a step'
+          expect(test_case.test_steps.first.text).to eq 'a step'
         }.exactly(2).times
         compile [doc], receiver, [my_filter]
       end

data/spec/cucumber/core/gherkin/parser_spec.rb

@@ -197,7 +197,7 @@ module Cucumber
             allow( visitor ).to receive(:scenario_outline).and_yield(visitor)
             allow( visitor ).to receive(:examples_table)
             expect( visitor ).to receive(:outline_step) do |step|
-              expect( step.name ).to eq 'passing <arg>'
+              expect( step.text ).to eq 'passing <arg>'
             end
             feature.describe_to(visitor)
           end

data/spec/cucumber/core/report/summary_spec.rb

@@ -159,14 +159,16 @@ module Cucumber::Core::Report
         event_bus.send(:test_case_finished, test_case, pending_result)
 
         expect( @summary.ok? ).to eq true
-        expect( @summary.ok?(true) ).to eq false
+        be_strict = ::Cucumber::Core::Test::Result::StrictConfiguration.new([:pending])
+        expect( @summary.ok?(be_strict) ).to eq false
       end
 
       it "undefined test case is ok if not strict" do
         event_bus.send(:test_case_finished, test_case, undefined_result)
 
         expect( @summary.ok? ).to eq true
-        expect( @summary.ok?(true) ).to eq false
+        be_strict = ::Cucumber::Core::Test::Result::StrictConfiguration.new([:undefined])
+        expect( @summary.ok?(be_strict) ).to eq false
       end
     end
   end

data/spec/cucumber/core/test/case_spec.rb

@@ -277,7 +277,7 @@ module Cucumber
             gherkin = Gherkin::Document.new('features/treasure.feature', %{# language: en-pirate
               Ahoy matey!: Treasure map
                 Heave to: Find the treasure
-                  Gangway!: a map
+                  Gangway! a map
             })
             receiver = double.as_null_object
             expect( receiver ).to receive(:test_case) do |test_case|

data/spec/cucumber/core/test/filters/locations_filter_spec.rb

@@ -96,8 +96,8 @@ module Cucumber::Core
                 Given a table
                   | a | b |
                   | 1 | 2 |
+                  | 3 | 4 |
 
-              Scenario: empty
           END
         end
 
@@ -112,13 +112,6 @@ module Cucumber::Core
           expect(receiver.test_case_locations).to eq [test_case_named('two').location]
         end
 
-        it 'matches the precise location of an empty scenario' do
-          location = test_case_named('empty').location
-          filter = Test::LocationsFilter.new([location])
-          compile [doc], receiver, [filter]
-          expect(receiver.test_case_locations).to eq [test_case_named('empty').location]
-        end
-
         it 'matches multiple locations' do
           good_location = Ast::Location.new(file, 8)
           bad_location = Ast::Location.new(file, 5)
@@ -201,10 +194,25 @@ module Cucumber::Core
             test_cases.find { |c| c.name == 'with a table' }
           end
 
-          it "matches a location on the first table row" do
+          it "matches a location at the start of the table" do
             location = Ast::Location.new(file, 23)
             expect( test_case.match_locations?([location]) ).to be_truthy
           end
+
+          it "matches a location in the middle of the table" do
+            location = Ast::Location.new(file, 24)
+            expect( test_case.match_locations?([location]) ).to be_truthy
+          end
+
+          it "matches a location at the end of the table" do
+            location = Ast::Location.new(file, 25)
+            expect( test_case.match_locations?([location]) ).to be_truthy
+          end
+
+          it "does not match a location after the table" do
+            location = Ast::Location.new(file, 26)
+            expect( test_case.match_locations?([location]) ).to be_falsey
+          end
         end
 
         context "with duplicate locations in the filter" do

data/spec/cucumber/core/test/result_spec.rb

@@ -49,8 +49,7 @@ module Cucumber::Core::Test
       specify { expect( result ).not_to be_flaky     }
 
       specify { expect( result ).to be_ok }
-      specify { expect( result.ok?(false) ).to be_truthy }
-      specify { expect( result.ok?(true) ).to be_truthy }
+      specify { expect( result.ok? ).to be_truthy }
     end
 
     describe Result::Failed do
@@ -109,8 +108,7 @@ module Cucumber::Core::Test
       specify { expect( result ).not_to be_flaky     }
 
       specify { expect( result ).to_not be_ok }
-      specify { expect( result.ok?(false) ).to be_falsey }
-      specify { expect( result.ok?(true) ).to be_falsey }
+      specify { expect( result.ok? ).to be_falsey }
     end
 
     describe Result::Unknown do
@@ -202,8 +200,9 @@ module Cucumber::Core::Test
       specify { expect( result ).not_to be_flaky     }
 
       specify { expect( result ).to be_ok }
-      specify { expect( result.ok?(false) ).to be_truthy }
-      specify { expect( result.ok?(true) ).to be_falsey }
+      specify { expect( result.ok? ).to be_truthy }
+      be_strict = Result::StrictConfiguration.new([:undefined])
+      specify { expect( result.ok?(be_strict) ).to be_falsey }
     end
 
     describe Result::Skipped do
@@ -225,8 +224,7 @@ module Cucumber::Core::Test
       specify { expect( result ).not_to be_flaky     }
 
       specify { expect( result ).to be_ok }
-      specify { expect( result.ok?(false) ).to be_truthy }
-      specify { expect( result.ok?(true) ).to be_truthy }
+      specify { expect( result.ok? ).to be_truthy }
     end
 
     describe Result::Pending do
@@ -249,8 +247,9 @@ module Cucumber::Core::Test
       specify { expect( result ).to     be_pending   }
 
       specify { expect( result ).to be_ok }
-      specify { expect( result.ok?(false) ).to be_truthy }
-      specify { expect( result.ok?(true) ).to be_falsey }
+      specify { expect( result.ok? ).to be_truthy }
+      be_strict = Result::StrictConfiguration.new([:pending])
+      specify { expect( result.ok?(be_strict) ).to be_falsey }
     end
 
     describe Result::Flaky do
@@ -258,6 +257,77 @@ module Cucumber::Core::Test
       specify { expect( Result::Flaky.ok?(true) ).to be_falsey }
     end
 
+    describe Result::StrictConfiguration do
+      subject(:strict_configuration) { Result::StrictConfiguration.new}
+      
+      describe '#set_strict' do
+        context 'no type argument' do
+          it 'sets all result types to the setting argument' do
+            strict_configuration.set_strict(true)
+            expect( strict_configuration.strict?(:undefined) ).to be_truthy
+            expect( strict_configuration.strict?(:pending) ).to be_truthy
+            expect( strict_configuration.strict?(:flaky) ).to be_truthy
+
+            strict_configuration.set_strict(false)
+            expect( strict_configuration.strict?(:undefined) ).to be_falsey
+            expect( strict_configuration.strict?(:pending) ).to be_falsey
+            expect( strict_configuration.strict?(:flaky) ).to be_falsey
+          end
+        end
+        context 'with type argument' do
+          it 'sets the specified result type to the setting argument' do
+            strict_configuration.set_strict(true, :undefined)
+            expect( strict_configuration.strict?(:undefined) ).to be_truthy
+            expect( strict_configuration.set?(:pending) ).to be_falsey
+            expect( strict_configuration.set?(:flaky) ).to be_falsey
+
+            strict_configuration.set_strict(false, :undefined)
+            expect( strict_configuration.strict?(:undefined) ).to be_falsey
+            expect( strict_configuration.set?(:pending) ).to be_falsey
+            expect( strict_configuration.set?(:flaky) ).to be_falsey
+          end
+        end
+      end
+
+      describe '#strict?' do
+        context 'no type argument' do
+          it 'returns true if any result type is set to strict' do
+            strict_configuration.set_strict(false, :pending)
+            expect( strict_configuration.strict? ).to be_falsey
+
+            strict_configuration.set_strict(true, :flaky)
+            expect( strict_configuration.strict? ).to be_truthy
+          end
+        end
+        context 'with type argument' do
+          it 'returns true if the specified result type is set to strict' do
+            strict_configuration.set_strict(false, :pending)
+            strict_configuration.set_strict(true, :flaky)
+
+            expect( strict_configuration.strict?(:undefined) ).to be_falsey
+            expect( strict_configuration.strict?(:pending) ).to be_falsey
+            expect( strict_configuration.strict?(:flaky) ).to be_truthy
+          end
+        end
+      end
+
+      describe '#merge!' do
+        let(:merged_configuration) { Result::StrictConfiguration.new }
+        it 'sets the not default values from the argument accordingly' do
+            strict_configuration.set_strict(false, :undefined)
+            strict_configuration.set_strict(false, :pending)
+            strict_configuration.set_strict(true, :flaky)
+            merged_configuration.set_strict(true, :pending)
+            merged_configuration.set_strict(false, :flaky)
+            strict_configuration.merge!(merged_configuration)
+
+            expect( strict_configuration.strict?(:undefined) ).to be_falsey
+            expect( strict_configuration.strict?(:pending) ).to be_truthy
+            expect( strict_configuration.strict?(:flaky) ).to be_falsey
+        end
+      end
+    end
+
     describe Result::Summary do
       let(:summary)   { Result::Summary.new }
       let(:failed)    { Result::Failed.new(Result::Duration.new(10), exception) }
@@ -360,19 +430,22 @@ module Cucumber::Core::Test
         it "pending result is ok if not strict" do
           pending.describe_to summary
           expect( summary.ok? ).to be true
-          expect( summary.ok?(true) ).to be false
+          be_strict = Result::StrictConfiguration.new([:pending])
+          expect( summary.ok?(be_strict) ).to be false
         end
 
         it "undefined result is ok if not strict" do
           undefined.describe_to summary
           expect( summary.ok? ).to be true
-          expect( summary.ok?(true) ).to be false
+          be_strict = Result::StrictConfiguration.new([:undefined])
+          expect( summary.ok?(be_strict) ).to be false
         end
 
         it "flaky result is ok if not strict" do
           summary.flaky
           expect( summary.ok? ).to be true
-          expect( summary.ok?(true) ).to be false
+          be_strict = Result::StrictConfiguration.new([:flaky])
+          expect( summary.ok?(be_strict) ).to be false
         end
       end
     end

data/spec/cucumber/core/test/runner_spec.rb

@@ -19,7 +19,7 @@ module Cucumber::Core::Test
     let(:exception) { StandardError.new('test error') }
 
     before do
-      allow(event_bus).to receive(:test_case_starting)
+      allow(event_bus).to receive(:test_case_started)
       allow(source).to receive(:location)
     end
 
@@ -66,8 +66,8 @@ module Cucumber::Core::Test
       context "without steps" do
         let(:test_steps) { [] }
 
-        it "emits a test_case_starting event before running the test case" do
-          expect(event_bus).to receive(:test_case_starting).with(test_case)
+        it "emits a test_case_started event before running the test case" do
+          expect(event_bus).to receive(:test_case_started).with(test_case)
           test_case.describe_to runner
         end
 
@@ -99,7 +99,7 @@ module Cucumber::Core::Test
             expect(event_bus).to receive(:test_case_finished) do |test_case, result|
               expect( result ).to be_undefined
             end
-            allow( undefined.source.last ).to receive(:name)
+            allow( undefined.source.last ).to receive(:text)
             test_case.describe_to runner
           end
 
@@ -107,7 +107,7 @@ module Cucumber::Core::Test
             expect(event_bus).to receive(:test_case_finished) do |test_case, result|
               expect( result.message ).to eq("Undefined step: \"step name\"")
             end
-            expect( undefined.source.last ).to receive(:name).and_return("step name")
+            expect( undefined.source.last ).to receive(:text).and_return("step name")
             test_case.describe_to runner
           end
 
@@ -116,7 +116,7 @@ module Cucumber::Core::Test
               expect( result.backtrace ).to eq(["step line"])
             end
             expect( undefined.source.last ).to receive(:backtrace_line).and_return("step line")
-            allow( undefined.source.last ).to receive(:name)
+            allow( undefined.source.last ).to receive(:text)
             test_case.describe_to runner
           end
         end

data/spec/cucumber/core/test/step_spec.rb

@@ -73,11 +73,11 @@ module Cucumber::Core::Test
       end
     end
 
-    it "exposes the name and location of the AST step or hook as attributes" do
-      name, location = double, double
-      step_or_hook = double(name: name, location: location)
+    it "exposes the text and location of the AST step or hook as attributes" do
+      text, location = double, double
+      step_or_hook = double(text: text, location: location)
       test_step = Step.new([step_or_hook])
-      expect( test_step.name     ).to eq name
+      expect( test_step.text     ).to eq text
       expect( test_step.location ).to eq location
     end
 
@@ -88,5 +88,11 @@ module Cucumber::Core::Test
       expect( test_step.action_location ).to eq location
     end
 
+    it "returns the text of the AST step when converted to a string" do
+      ast_step = double(text: 'a passing step', location: double)
+      test_step = Step.new([ast_step])
+      expect( test_step.to_s     ).to eq 'a passing step'
+    end
+
   end
 end

data/spec/cucumber/core_spec.rb

@@ -99,37 +99,37 @@ module Cucumber
 
         observed_events = []
         execute [gherkin], [Core::Test::Filters::ActivateStepsForSelfTest.new] do |event_bus|
-          event_bus.on(:test_case_starting) do |event|
+          event_bus.on(:test_case_started) do |event|
             test_case = event.test_case
-            observed_events << [:test_case_starting, test_case.name]
+            observed_events << [:test_case_started, test_case.name]
           end
           event_bus.on(:test_case_finished) do |event|
             test_case, result = *event.attributes
             observed_events << [:test_case_finished, test_case.name, result.to_sym]
           end
-          event_bus.on(:test_step_starting) do |event|
+          event_bus.on(:test_step_started) do |event|
             test_step = event.test_step
-            observed_events << [:test_step_starting, test_step.name]
+            observed_events << [:test_step_started, test_step.text]
           end
           event_bus.on(:test_step_finished) do |event|
             test_step, result = *event.attributes
-            observed_events << [:test_step_finished, test_step.name, result.to_sym]
+            observed_events << [:test_step_finished, test_step.text, result.to_sym]
           end
         end
 
         expect(observed_events).to eq [
-          [:test_case_starting, 'The one that passes'],
-          [:test_step_starting, 'passing'],
+          [:test_case_started, 'The one that passes'],
+          [:test_step_started, 'passing'],
           [:test_step_finished, 'passing', :passed],
           [:test_case_finished, 'The one that passes', :passed],
-          [:test_case_starting, 'The one that fails'],
-          [:test_step_starting, 'passing'],
+          [:test_case_started, 'The one that fails'],
+          [:test_step_started, 'passing'],
           [:test_step_finished, 'passing', :passed],
-          [:test_step_starting, 'failing'],
+          [:test_step_started, 'failing'],
           [:test_step_finished, 'failing', :failed],
-          [:test_step_starting, 'passing'],
+          [:test_step_started, 'passing'],
           [:test_step_finished, 'passing', :skipped],
-          [:test_step_starting, 'undefined'],
+          [:test_step_started, 'undefined'],
           [:test_step_finished, 'undefined', :undefined],
           [:test_case_finished, 'The one that fails', :failed],
         ]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-core
 version: !ruby/object:Gem::Version
-  version: 3.0.0.pre.2
+  version: 3.0.0
 platform: ruby
 authors:
 - Aslak Hellesøy
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-26 00:00:00.000000000 Z
+date: 2017-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin
@@ -167,9 +167,9 @@ files:
 - ".ruby-gemset"
 - ".travis.yml"
 - ".yardopts"
+- CHANGELOG.md
 - CONTRIBUTING.md
 - Gemfile
-- HISTORY.md
 - LICENSE
 - README.md
 - Rakefile
@@ -262,15 +262,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
-summary: cucumber-core-3.0.0.pre.2
+summary: cucumber-core-3.0.0
 test_files:
 - spec/capture_warnings.rb
 - spec/coverage.rb