cucumber-core 2.0.0 → 3.0.0.pre.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bb172018d9e05188dafca358b06cfe31d5d10575
-  data.tar.gz: d41a9aa632138309140db42346519eeb349ee322
+  metadata.gz: 14ae96e7b157ead29d3bb55f9590dd59abdf2878
+  data.tar.gz: 72d1ed6b3b96b8d19c92ffa81d6b1be7ae690a7a
 SHA512:
-  metadata.gz: 117f9542f1c84472c5cac771e2eff5284ea9be7f965d40d0e8163b13f8d455e3f1c7654467936fa4da55fd0b4de242eb6677557896239f140da1bd41156f4328
-  data.tar.gz: 7e911a2e55a093cfd2dd73945d31df73d2504aa5cd88bb1a06f5778d234e5803a039856597595468c408b8ee6b864f6752d575f5753e499a19793dcf3a57166f
+  metadata.gz: da7bd878d405691af0f96191da9e1d32caf7802e7d14ef039c206c524ced53c46305c12e74a8ff8362eef619e54cefa606949424609a1f576a1435cb3754879d
+  data.tar.gz: b1c03286e6851861e1532547825bc2bd096881acb5140a0cc1717373edbb288620960bf0bb34890459294b020e70bedb0cebd0798a4a3b394a17b0f9e019753d

data/.travis.yml

@@ -1,11 +1,20 @@
+language: ruby
 sudo: false
 
-rvm:
-  - 2.3.0
-  - 2.2
-  - 2.1
-  - 2.0.0
-  - jruby-9.0.5.0
+matrix:
+  include:
+    - rvm: ruby-head
+    - rvm: 2.4.1
+    - rvm: 2.3.4
+    - rvm: 2.2
+    - rvm: 2.1
+    - rvm: 2.0.0
+    - rvm: jruby-9.1.12.0
+      env:
+        - JRUBY_OPTS="--debug"
+  allow_failures:
+    - rvm: ruby-head
+  fast_finish: true
 
 # whitelist
 branches:
@@ -13,8 +22,6 @@ branches:
     - master
 
 notifications:
-  email:
-    - cukes-devs@googlegroups.com
   webhooks:
     urls: # gitter
       - https://webhooks.gitter.im/e/dc010332f9d40fcc21c4

data/HISTORY.md

@@ -1,10 +1,41 @@
-## [In Git](https://github.com/cucumber/cucumber-ruby-core/compare/v1.5.0...master)
+## [In Git](https://github.com/cucumber/cucumber-ruby-core/compare/3.0.0.pre.2...master)
 
 ### New Features
+### Bugfixes
+### Removed Features
+### Refactoring
+
+## [3.0.0.pre.2](https://github.com/cucumber/cucumber-ruby-core/compare/v2.0.0...3.0.0.pre.2) (2017-07-26)
+
+### New Features
+
+* Add a flaky result type to be used for flaky scenarios ([#141](https://github.com/cucumber/cucumber-ruby-core/pull/141), [cucumber/cucumber-ruby#1044](https://github.com/cucumber/cucumber-ruby/issues/1044) @brasmusson)
+* Make the Summary report able to say if the total result is ok ([#140](https://github.com/cucumber/cucumber-ruby-core/pull/140) @brasmusson)
+* Replay previous events to new subscribers ([#136](https://github.com/cucumber/cucumber-ruby-core/pull/136) @mattwynne)
+* Ruby 2.4.0 compatibility ([#120](https://github.com/cucumber/cucumber-ruby-core/pull/120) @junaruga)
+* Use tag expressions ([#116](https://github.com/cucumber/cucumber-ruby-core/pull/116) @brasmusson)
+* Access example table row data by param name ([#118](https://github.com/cucumber/cucumber-ruby-core/pull/118) @enkessler)
+
+### Bugfixes
+
+N/A
+
+### Removed Features
+
+N/A
+
+### Refactoring
+
+* Travis: jruby-9.1.10.0 ([#130](https://github.com/cucumber/cucumber-ruby-core/pull/130) @olleolleolle)
+* Travis: jruby-9.1.12.0 ([#133](https://github.com/cucumber/cucumber-ruby-core/pull/132) @olleolleolle)
+
+## [2.0.0](https://github.com/cucumber/cucumber-ruby-core/compare/v1.5.0...2.0.0)
 
- * Implement equality for test cases ([#111](https://github.com/cucumber/cucumber-ruby-core/pull/111) @mattwynne)
- * Implement an event bus (moved from Cucumber-Ruby) ([#106](https://github.com/cucumber/cucumber-ruby-core/pull/106) @mattwynne)
- * Use frozen string literals ([#105](https://github.com/cucumber/cucumber-ruby-core/pull/105) @twalpole)
+### New Features
+
+* Implement equality for test cases ([#111](https://github.com/cucumber/cucumber-ruby-core/pull/111) @mattwynne)
+* Implement an event bus (moved from Cucumber-Ruby) ([#106](https://github.com/cucumber/cucumber-ruby-core/pull/106) @mattwynne)
+* Use frozen string literals ([#105](https://github.com/cucumber/cucumber-ruby-core/pull/105) @twalpole)
 
 ### Bugfixes
 
@@ -15,7 +46,11 @@
 
 * Remove support for Ruby v1.9.3. ([112](https://github.com/cucumber/cucumber-ruby-core/pull/112) @brasmusson)
 
-## [v1.5.0](https://github.com/cucumber/cucumber-ruby-core/compare/v1.4.0...v1.5.0)
+### Refactoring
+
+N/A
+
+## [1.5.0](https://github.com/cucumber/cucumber-ruby-core/compare/v1.4.0...v1.5.0)
 
 ### New Features
 
@@ -25,7 +60,7 @@
 
  * Use monotonic time ([#103](https://github.com/cucumber/cucumber-ruby-core/pull/103) @mikz)
 
-## [v1.4.0](https://github.com/cucumber/cucumber-ruby-core/compare/v1.3.1...v1.4.0)
+## [1.4.0](https://github.com/cucumber/cucumber-ruby-core/compare/v1.3.1...v1.4.0)
 
 ### New Features
 
@@ -33,7 +68,7 @@
 
 ### Bugfixes
 
-## [v1.3.1](https://github.com/cucumber/cucumber-ruby-core/compare/v1.3.0...v1.3.1)
+## [1.3.1](https://github.com/cucumber/cucumber-ruby-core/compare/v1.3.0...v1.3.1)
 
 ### New Features
 
@@ -41,7 +76,7 @@
 
  * Speed up location filtering ([#99](https://github.com/cucumber/cucumber-ruby-core/issues/99) @mattwynne @akostadinov @brasmusson)
 
-## [v1.3.0](https://github.com/cucumber/cucumber-ruby-core/compare/v1.2.0...v1.3.0)
+## [1.3.0](https://github.com/cucumber/cucumber-ruby-core/compare/v1.2.0...v1.3.0)
 
 ### New Features
 
@@ -53,7 +88,7 @@
  * Make sure that `after_test_step` is sent also when a test step is interrupted by (a timeout in) an around hook ([cucumber/cucumber-ruby#909](https://github.com/cucumber/cucumber-ruby/issues/909) @brasmusson)
  * Improve the check that a test_step quacks like a Cucumber::Core::Test::Step ([95](https://github.com/cucumber/cucumber-ruby-core/issues/95) @brasmusson)
 
-## [v1.2.0](https://github.com/cucumber/cucumber-ruby-core/compare/v1.1.3...v1.2.0)
+## [1.2.0](https://github.com/cucumber/cucumber-ruby-core/compare/v1.1.3...v1.2.0)
 
 ### New Features
 
@@ -65,13 +100,13 @@
 
 ### Bugfixes
 
-## [v1.1.3](https://github.com/cucumber/cucumber-ruby-core/compare/v1.1.2...v1.1.3)
+## [1.1.3](https://github.com/cucumber/cucumber-ruby-core/compare/v1.1.2...v1.1.3)
 
 ### New Features
 
   * Added custom `inspect` methods for AST Nodes (@tooky)
 
-## [v1.1.2](https://github.com/cucumber/cucumber-ruby-core/compare/v1.1.1...v1.1.2)
+## [1.1.2](https://github.com/cucumber/cucumber-ruby-core/compare/v1.1.1...v1.1.2)
 
 ### New Features
 
@@ -81,24 +116,24 @@
   * Fail test case if around hook fails (@mattwynne, @tooky)
   * Expose `Test::Case#around_hooks` (@tooky)
 
-## [v1.1.1](https://github.com/cucumber/cucumber-ruby-core/compare/v1.1.0...v1.1.1)
+## [1.1.1](https://github.com/cucumber/cucumber-ruby-core/compare/v1.1.0...v1.1.1)
 
 
 ### New Features
 
   * Calculate actual keyword for snippets (@brasmusson)
 
-### Bugfixes
+### Bugfixes
 
   * Remove keyword from `Test::Case#name` [82](https://github.com/cucumber/cucumber-ruby-core/pull/82) (@richarda)
 
-## [v1.1.0](https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0...v1.1.0)
+## [1.1.0](https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0...v1.1.0)
 
 ### New features
 
   * LocationsFilter now sorts test cases as well as filtering them (@mattwynne)
 
-## [v1.0.0](https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0.beta.4...v1.0.0)
+## [1.0.0](https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0.beta.4...v1.0.0)
 
 ### Features Removed
 
@@ -109,7 +144,7 @@
 
   * Added dynamic filter class constructor (@mattwynne)
 
-## [v1.0.0.beta.4](https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0.beta.3...v1.0.0.beta.4)
+## [1.0.0.beta.4](https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0.beta.3...v1.0.0.beta.4)
 
 ### New Features
 
@@ -122,10 +157,10 @@
  * Handle empty feature files (#[77](https://github.com/cucumber/cucumber-ruby-core/pull/77), [cucumber/cucumber-ruby#771](https://github.com/cucumber/cucumber-ruby/issues/771) [@brasmusson](https://github.com/brasmusson))
  * Run after hooks in reverse order (#[69](https://github.com/cucumber/cucumber-ruby-core/pull/69) [@erran](https://github.com/erran))
 
-## [v1.0.0.beta.3](https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0.beta.2...v1.0.0.beta.3)
+## [1.0.0.beta.3](https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0.beta.2...v1.0.0.beta.3)
 
 Changes were not logged.
 
-## [v1.0.0.beta.2](https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0.beta.1...v1.0.0.beta.2)
+## [1.0.0.beta.2](https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0.beta.1...v1.0.0.beta.2)
 
 Changes were not logged.

data/README.md

@@ -1,4 +1,4 @@
-#cucumber-core
+# cucumber-core
 
 [![Chat with us](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/cucumber/cucumber-ruby?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![Build Status](https://secure.travis-ci.org/cucumber/cucumber-ruby-core.svg)](http://travis-ci.org/cucumber/cucumber-ruby-core)
@@ -10,7 +10,7 @@ Cucumber Core is the [inner hexagon](http://alistair.cockburn.us/Hexagonal+archi
 
 It contains the core domain logic to execute Cucumber features. It has no user interface, just a Ruby API. If you're interested in how Cucumber works, or in building other tools that work with Gherkin documents, you've come to the right place.
 
-##An overview
+## An overview
 
 The entry-point is a single method on the module [`Cucumber::Core`](Cucumber/Core.html) called [`#execute`](Cucumber/Core.html#execute-instance_method). Here's what it does:
 
@@ -21,13 +21,13 @@ The entry-point is a single method on the module [`Cucumber::Core`](Cucumber/Cor
 
 We've introduced a number of concepts here, so let's go through them in detail.
 
-###The AST
+### The AST
 
 The Abstract Syntax Tree or [AST](Cucumber/Core/Ast.html) is an object graph that represents the Gherkin documents you've passed into the core. Things like [Feature](Cucumber/Core/Ast/Feature.html), [Scenario](Cucumber/Core/Ast/Scenario.html) and [ExamplesTable](Cucumber/Core/Ast/ExamplesTable.html).
 
 These are immutable value objects.
 
-###Test cases
+### Test cases
 
 Your gherkin might contain scenarios, as well as examples from tables beneath a scenario outline.
 
@@ -35,11 +35,11 @@ Test cases represent the general case of both of these. We compile the AST down
 
 Test cases and their test steps are also immutable value objects.
 
-###Filters
+### Filters
 
 Once we have the test cases, and they've been activated by the mappings, you may want to pass them through a filter or two. Filters can be used to do things like activate, sort, replace or remove some of the test cases or their steps before they're executed.
 
-###Events
+### Events
 
 Events are how you find out what is happening during your test run. As the test cases and steps are executed, the runner emits events to signal what's going on.
 
@@ -52,7 +52,7 @@ The following events are emitted during a run:
 
 That's probably best illustrated with an example.
 
-##Example
+## Example
 
 Here's an example of how you might use [`Cucumber::Core#execute`](Cucumber/Core#execute-instance_method)
 

data/cucumber-core.gemspec

@@ -14,8 +14,9 @@ Gem::Specification.new do |s|
   s.license     = "MIT"
   s.required_ruby_version = ">= 1.9.3"
 
-  s.add_dependency 'gherkin', '~> 4.0'
-  s.add_dependency 'backports', '~> 3.6'
+  s.add_dependency 'gherkin', '>= 4.1.3'
+  s.add_dependency 'cucumber-tag_expressions', '>= 1.0.1'
+  s.add_dependency 'backports', '>= 3.8.0'
 
   s.add_development_dependency 'bundler',   '>= 1.3.5'
   s.add_development_dependency 'rake',      '>= 0.9.2'

data/lib/cucumber/core/ast/examples_table.rb

@@ -82,6 +82,10 @@ module Cucumber
               other.data == data
           end
 
+          def [](parameter_name)
+            @data[parameter_name]
+          end
+
           def values
             @data.values
           end

data/lib/cucumber/core/event_bus.rb

@@ -15,6 +15,7 @@ module Cucumber
       def initialize(registry = Events.registry)
         @event_types = registry.freeze
         @handlers = {}
+        @event_queue = []
       end
 
       # Register for an event. The handler proc will be called back with each of the attributes
@@ -24,23 +25,31 @@ module Cucumber
         validate_handler_and_event_id!(handler, event_id)
         event_class = event_types[event_id]
         handlers_for(event_class) << handler
+        broadcast_queued_events_to handler, event_class
       end
 
       # Broadcast an event
       def broadcast(event)
         raise ArgumentError, "Event type #{event.class} is not registered. Try one of these:\n#{event_types.values.join("\n")}" unless is_registered_type?(event.class)
         handlers_for(event.class).each { |handler| handler.call(event) }
+        @event_queue << event
       end
 
       def method_missing(event_id, *args)
         event_class = event_types.fetch(event_id) { super }
         broadcast event_class.new(*args)
-      rescue NameError => error
-        raise error, error.message + "\nDid you get the ID of the event wrong? Try one of these:\n#{event_types.keys.join("\n")}", error.backtrace
       end
 
       private
 
+      def broadcast_queued_events_to(handler, event_type)
+        @event_queue.select { |event|
+          event.class == event_type
+        }.each { |event|
+          handler.call(event)
+        }
+      end
+
       def handlers_for(event_class)
         @handlers[event_class.to_s] ||= []
       end

data/lib/cucumber/core/report/summary.rb

@@ -6,16 +6,27 @@ module Cucumber
         attr_reader :test_cases, :test_steps
 
         def initialize(event_bus)
+          @previous_test_case = nil
           @test_cases = Test::Result::Summary.new
           @test_steps = Test::Result::Summary.new
           subscribe_to(event_bus)
         end
 
+        def ok?(be_strict = false)
+          test_cases.ok?(be_strict)
+        end
+
         private
 
         def subscribe_to(event_bus)
           event_bus.on(:test_case_finished) do |event|
-            event.result.describe_to test_cases
+            if event.test_case != @previous_test_case
+              @previous_test_case = event.test_case
+              event.result.describe_to test_cases
+            elsif event.result.passed?
+              test_cases.flaky
+              test_cases.decrement_failed
+            end
           end
           event_bus.on(:test_step_finished) do |event|
             event.result.describe_to test_steps if is_step?(event.test_step)

data/lib/cucumber/core/test/case.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 require 'cucumber/core/test/result'
+require 'cucumber/tag_expressions'
 require 'cucumber/core/gherkin/tag_expression'
 require 'cucumber/core/ast/location'
 
@@ -59,7 +60,7 @@ module Cucumber
         end
 
         def match_tags?(*expressions)
-          Cucumber::Core::Gherkin::TagExpression.new(expressions.flatten).evaluate(tags)
+          expressions.flatten.all? { |expression| match_single_tag_expression?(expression) }
         end
 
         def match_name?(name_regexp)
@@ -120,6 +121,18 @@ module Cucumber
           end.call
         end
 
+        def match_single_tag_expression?(expression)
+          if old_style_tag_expression?(expression)
+            Cucumber::Core::Gherkin::TagExpression.new([expression]).evaluate(tags)
+          else
+            Cucumber::TagExpressions::Parser.new.parse(expression).evaluate(tags.map(&:name))
+          end
+        end
+
+        def old_style_tag_expression?(expression)
+          expression.include?(',') || expression.include?('~')
+        end
+
         class NameBuilder
           attr_reader :result
           attr_reader :keyword

data/lib/cucumber/core/test/filters/tag_filter.rb

@@ -15,7 +15,6 @@ module Cucumber
         end
 
         def done
-          tag_limits.enforce(test_cases)
           receiver.done
           self
         end
@@ -26,10 +25,6 @@ module Cucumber
           @test_cases ||= TestCases.new
         end
 
-        def tag_limits
-          @tag_limits ||= TagLimits.new(filter_expressions)
-        end
-
         class TestCases
           attr_reader :test_cases_by_tag_name
           private :test_cases_by_tag_name
@@ -48,65 +43,6 @@ module Cucumber
             test_cases_by_tag_name[tag_name]
           end
         end
-
-        class TagLimits
-          TAG_MATCHER = /^
-            (?:~)?                 #The tag negation symbol "~". This is optional and not captured.
-            (?<tag_name>\@\w+)     #Captures the tag name including the "@" symbol.
-            \:                     #The seperator, ":", between the tag name and the limit.
-            (?<limit>\d+)          #Caputres the limit number.
-          $/x
-
-          attr_reader :limit_list
-          private :limit_list
-          def initialize(filter_expressions)
-            @limit_list = Array(filter_expressions).flat_map do |raw_expression|
-              raw_expression.split(/\s*,\s*/)
-            end.map do |filter_expression|
-              TAG_MATCHER.match(filter_expression)
-            end.compact.each_with_object({}) do |matchdata, limit_list|
-              limit_list[matchdata[:tag_name]] = Integer(matchdata[:limit])
-            end
-          end
-
-          def enforce(test_cases)
-            limit_breaches = limit_list.reduce([]) do |breaches, (tag_name, limit)|
-              tag_count = test_cases.with_tag_name(tag_name).count
-              if tag_count > limit
-                tag_locations = test_cases.with_tag_name(tag_name).map(&:location)
-                breaches << TagLimitBreach.new(
-                  tag_count,
-                  limit,
-                  tag_name,
-                  tag_locations
-                )
-              end
-              breaches
-            end
-            raise TagExcess.new(limit_breaches) if limit_breaches.any?
-            self
-          end
-        end
-
-        TagLimitBreach = Struct.new(
-          :tag_count,
-          :tag_limit,
-          :tag_name,
-          :tag_locations
-        ) do
-
-          def message
-            "#{tag_name} occurred #{tag_count} times, but the limit was set to #{tag_limit}\n  " +
-              tag_locations.map(&:to_s).join("\n  ")
-          end
-          alias :to_s :message
-        end
-
-        class TagExcess < StandardError
-          def initialize(limit_breaches)
-            super(limit_breaches.map(&:to_s).join("\n"))
-          end
-        end
       end
     end
   end

data/lib/cucumber/core/test/result.rb

@@ -1,10 +1,17 @@
-# encoding: UTF-8
+# encoding: utf-8
 # frozen_string_literal: true
 
 module Cucumber
   module Core
     module Test
       module Result
+        TYPES = [:failed, :flaky, :skipped, :undefined, :pending, :passed, :unknown].freeze
+
+        def self.ok?(type, be_strict = false)
+          private
+          class_name = type.to_s.slice(0, 1).capitalize + type.to_s.slice(1..-1)
+          const_get(class_name).ok?(be_strict)
+        end
 
         # Defines to_sym on a result class for the given result type
         #
@@ -16,7 +23,7 @@ module Cucumber
               result_type
             end
 
-            [:passed, :failed, :undefined, :unknown, :skipped, :pending].each do |possible_result_type|
+            TYPES.each do |possible_result_type|
               define_method("#{possible_result_type}?") do
                 possible_result_type == to_sym
               end
@@ -41,6 +48,10 @@ module Cucumber
           include Result.query_methods :passed
           attr_accessor :duration
 
+          def self.ok?(be_strict = false)
+            true
+          end
+
           def initialize(duration)
             raise ArgumentError unless duration
             @duration = duration
@@ -57,7 +68,7 @@ module Cucumber
           end
 
           def ok?(be_strict = false)
-            true
+            self.class.ok?(be_strict)
           end
 
           def with_appended_backtrace(step)
@@ -73,6 +84,10 @@ module Cucumber
           include Result.query_methods :failed
           attr_reader :duration, :exception
 
+          def self.ok?(be_strict = false)
+            false
+          end
+
           def initialize(duration, exception)
             raise ArgumentError unless duration
             raise ArgumentError unless exception
@@ -92,7 +107,7 @@ module Cucumber
           end
 
           def ok?(be_strict = false)
-            false
+            self.class.ok?(be_strict)
           end
 
           def with_duration(new_duration)
@@ -109,7 +124,16 @@ module Cucumber
           end
         end
 
-        # Base class for exceptions that can be raised in a step defintion causing
+        # Flaky is not used directly as an execution result, but is used as a
+        # reporting result type for test cases that fails and the passes on
+        # retry, therefore only the class method self.ok? is needed.
+        class Flaky
+          def self.ok?(be_strict = false)
+            !be_strict
+          end
+        end
+
+        # Base class for exceptions that can be raised in a step definition causing
         # the step to have that result.
         class Raisable < StandardError
           attr_reader :message, :duration
@@ -139,11 +163,19 @@ module Cucumber
             return self unless backtrace
             filter.new(dup).exception
           end
+
+          def ok?(be_strict = false)
+            self.class.ok?(be_strict)
+          end
         end
 
         class Undefined < Raisable
           include Result.query_methods :undefined
 
+          def self.ok?(be_strict = false)
+            !be_strict
+          end
+
           def describe_to(visitor, *args)
             visitor.undefined(*args)
             visitor.duration(duration, *args)
@@ -153,15 +185,15 @@ module Cucumber
           def to_s
             "?"
           end
-
-          def ok?(be_strict = false)
-            !be_strict
-          end
         end
 
         class Skipped < Raisable
           include Result.query_methods :skipped
 
+          def self.ok?(be_strict = false)
+            true
+          end
+
           def describe_to(visitor, *args)
             visitor.skipped(*args)
             visitor.duration(duration, *args)
@@ -171,15 +203,15 @@ module Cucumber
           def to_s
             "-"
           end
-
-          def ok?(be_strict = false)
-            true
-          end
         end
 
         class Pending < Raisable
           include Result.query_methods :pending
 
+          def self.ok?(be_strict = false)
+            !be_strict
+          end
+
           def describe_to(visitor, *args)
             visitor.pending(self, *args)
             visitor.duration(duration, *args)
@@ -189,10 +221,6 @@ module Cucumber
           def to_s
             "P"
           end
-
-          def ok?(be_strict = false)
-            !be_strict
-          end
         end
 
         #
@@ -222,6 +250,15 @@ module Cucumber
             end
           end
 
+          def ok?(be_strict = false)
+            TYPES.each do |type|
+              if get_total(type) > 0
+                return false unless Result.ok?(type, be_strict)
+              end
+            end
+            true
+          end
+
           def exception(exception)
             @exceptions << exception
             self
@@ -240,6 +277,10 @@ module Cucumber
             end
           end
 
+          def decrement_failed
+            @totals[:failed] -= 1
+          end
+          
           private
 
           def get_total(method_name)

data/lib/cucumber/core/version.rb

@@ -3,7 +3,7 @@ module Cucumber
   module Core
     class Version
       def self.to_s
-        "2.0.0"
+        "3.0.0.pre.2"
       end
     end
   end

data/spec/coverage.rb

@@ -7,5 +7,5 @@ if ENV['TRAVIS']
   formatters << Coveralls::SimpleCov::Formatter
 end
 
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[*formatters]
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(formatters)
 SimpleCov.start

data/spec/cucumber/core/ast/doc_string_spec.rb

@@ -77,11 +77,11 @@ module Cucumber
             expect( doc_string.encoding ).to eq Encoding.find('US-ASCII')
           end
 
-          it 'allows implicit convertion to a String' do
+          it 'allows implicit conversion to a String' do
             expect( 'expected content' ).to include(doc_string)
           end
 
-          it 'allows explicit convertion to a String' do
+          it 'allows explicit conversion to a String' do
             expect( doc_string.to_s ).to eq 'content'
           end
 

data/spec/cucumber/core/ast/examples_table_spec.rb

@@ -75,11 +75,16 @@ module Cucumber::Core::Ast
         end
       end
 
-      describe 'accesing the values' do
+      describe 'accessing the values' do
         it 'returns the actual row values' do
           row = ExamplesTable::Row.new({'x' => '1', 'y' => '2'}, 1, location, language, comments)
           expect( row.values ).to eq ['1', '2']
         end
+
+        it "can access a row value by it's parameter name" do
+          row = ExamplesTable::Row.new({'x' => '1', 'y' => '2'}, 1, location, language, comments)
+          expect( row['x']).to eq '1'
+        end
       end
 
       describe 'equality' do

data/spec/cucumber/core/ast/location_spec.rb

@@ -62,7 +62,7 @@ module Cucumber::Core::Ast
           expect( matching ).to be_match(precise)
         end
 
-        it "does not match a precise location on a differnt line in the same file" do
+        it "does not match a precise location on a different line in the same file" do
           expect( matching ).not_to be_match(same_file_other_line)
         end
 

data/spec/cucumber/core/event_bus_spec.rb

@@ -136,6 +136,18 @@ module Cucumber
           expect(handler.received_payload.some_attribute).to eq :some_attribute
         end
 
+        it "sends events that were broadcast before you subscribed" do
+          event_bus.test_event :some_attribute
+          event_bus.another_test_event
+
+          received_payload = nil
+          event_bus.on(:test_event) do |event|
+            received_payload = event
+          end
+
+          expect(received_payload.some_attribute).to eq(:some_attribute)
+        end
+
       end
 
       it "will let you inspect the registry" do

data/spec/cucumber/core/report/summary_spec.rb

@@ -55,6 +55,16 @@ module Cucumber::Core::Report
         expect( @summary.test_cases.total(:undefined) ).to eq(1)
         expect( @summary.test_cases.total ).to eq(1)
       end
+
+      it "handles flaky test cases" do
+        allow(test_case).to receive(:==).and_return(false, true)
+        event_bus.send(:test_case_finished, test_case, failed_result)
+        event_bus.send(:test_case_finished, test_case, passed_result)
+
+        expect( @summary.test_cases.total(:failed) ).to eq(0)
+        expect( @summary.test_cases.total(:flaky) ).to eq(1)
+        expect( @summary.test_cases.total ).to eq(1)
+      end
     end
 
     context "test step summary" do
@@ -123,5 +133,41 @@ module Cucumber::Core::Report
         end
       end
     end
+
+    context "ok? result" do
+      let(:test_case) { double }
+
+      it "passed test case is ok" do
+        event_bus.send(:test_case_finished, test_case, passed_result)
+
+        expect( @summary.ok? ).to eq true
+      end
+
+      it "skipped test case is ok" do
+        event_bus.send(:test_case_finished, test_case, skipped_result)
+
+        expect( @summary.ok? ).to eq true
+      end
+
+      it "failed test case is not ok" do
+        event_bus.send(:test_case_finished, test_case, failed_result)
+
+        expect( @summary.ok? ).to eq false
+      end
+
+      it "pending test case is ok if not strict" do
+        event_bus.send(:test_case_finished, test_case, pending_result)
+
+        expect( @summary.ok? ).to eq true
+        expect( @summary.ok?(true) ).to eq false
+      end
+
+      it "undefined test case is ok if not strict" do
+        event_bus.send(:test_case_finished, test_case, undefined_result)
+
+        expect( @summary.ok? ).to eq true
+        expect( @summary.ok?(true) ).to eq false
+      end
+    end
   end
 end

data/spec/cucumber/core/test/case_spec.rb

@@ -185,6 +185,42 @@ module Cucumber
         end
 
         describe "matching tags" do
+          it "matches tags using tag expressions" do
+            gherkin = gherkin do
+              feature tags: ['@a', '@b'] do
+                scenario tags: ['@c'] do
+                  step
+                end
+              end
+            end
+            receiver = double.as_null_object
+            expect( receiver ).to receive(:test_case) do |test_case|
+              expect( test_case.match_tags?(['@a and @b']) ).to be_truthy
+              expect( test_case.match_tags?(['@a or @d']) ).to be_truthy
+              expect( test_case.match_tags?(['not @d']) ).to be_truthy
+              expect( test_case.match_tags?(['@a and @d']) ).to be_falsy
+            end
+            compile [gherkin], receiver
+          end
+
+          it "matches handles multiple expressions" do
+            gherkin = gherkin do
+              feature tags: ['@a', '@b'] do
+                scenario tags: ['@c'] do
+                  step
+                end
+              end
+            end
+            receiver = double.as_null_object
+            expect( receiver ).to receive(:test_case) do |test_case|
+              expect( test_case.match_tags?(['@a and @b', 'not @d']) ).to be_truthy
+              expect( test_case.match_tags?(['@a and @b', 'not @c']) ).to be_falsy
+            end
+            compile [gherkin], receiver
+          end
+        end
+
+        describe "matching tags (old style)" do
           it "matches boolean expressions of tags" do
             gherkin = gherkin do
               feature tags: ['@a', '@b'] do
@@ -195,7 +231,25 @@ module Cucumber
             end
             receiver = double.as_null_object
             expect( receiver ).to receive(:test_case) do |test_case|
-              expect( test_case.match_tags?('@a') ).to be_truthy
+              expect( test_case.match_tags?(['@a', '@b']) ).to be_truthy
+              expect( test_case.match_tags?(['@a, @d']) ).to be_truthy
+              expect( test_case.match_tags?(['~@d']) ).to be_truthy
+              expect( test_case.match_tags?(['@a', '@d']) ).to be_falsy
+            end
+            compile [gherkin], receiver
+          end
+
+          it "handles mixing old and new style expressions" do
+            gherkin = gherkin do
+              feature tags: ['@a', '@b'] do
+                scenario tags: ['@c'] do
+                  step
+                end
+              end
+            end
+            receiver = double.as_null_object
+            expect( receiver ).to receive(:test_case) do |test_case|
+              expect( test_case.match_tags?(['@a and @b', '~@d']) ).to be_truthy
             end
             compile [gherkin], receiver
           end

data/spec/cucumber/core/test/result_spec.rb

@@ -46,6 +46,7 @@ module Cucumber::Core::Test
       specify { expect( result ).not_to be_undefined }
       specify { expect( result ).not_to be_unknown   }
       specify { expect( result ).not_to be_skipped   }
+      specify { expect( result ).not_to be_flaky     }
 
       specify { expect( result ).to be_ok }
       specify { expect( result.ok?(false) ).to be_truthy }
@@ -105,6 +106,7 @@ module Cucumber::Core::Test
       specify { expect( result ).not_to be_undefined }
       specify { expect( result ).not_to be_unknown   }
       specify { expect( result ).not_to be_skipped   }
+      specify { expect( result ).not_to be_flaky     }
 
       specify { expect( result ).to_not be_ok }
       specify { expect( result.ok?(false) ).to be_falsey }
@@ -130,6 +132,7 @@ module Cucumber::Core::Test
       specify { expect( result ).not_to be_undefined }
       specify { expect( result ).to     be_unknown   }
       specify { expect( result ).not_to be_skipped   }
+      specify { expect( result ).not_to be_flaky     }
     end
 
     describe Result::Raisable do
@@ -196,6 +199,7 @@ module Cucumber::Core::Test
       specify { expect( result ).to     be_undefined }
       specify { expect( result ).not_to be_unknown   }
       specify { expect( result ).not_to be_skipped   }
+      specify { expect( result ).not_to be_flaky     }
 
       specify { expect( result ).to be_ok }
       specify { expect( result.ok?(false) ).to be_truthy }
@@ -218,6 +222,7 @@ module Cucumber::Core::Test
       specify { expect( result ).not_to be_undefined }
       specify { expect( result ).not_to be_unknown   }
       specify { expect( result ).to     be_skipped   }
+      specify { expect( result ).not_to be_flaky     }
 
       specify { expect( result ).to be_ok }
       specify { expect( result.ok?(false) ).to be_truthy }
@@ -240,6 +245,7 @@ module Cucumber::Core::Test
       specify { expect( result ).not_to be_undefined }
       specify { expect( result ).not_to be_unknown   }
       specify { expect( result ).not_to be_skipped   }
+      specify { expect( result ).not_to be_flaky     }
       specify { expect( result ).to     be_pending   }
 
       specify { expect( result ).to be_ok }
@@ -247,12 +253,18 @@ module Cucumber::Core::Test
       specify { expect( result.ok?(true) ).to be_falsey }
     end
 
+    describe Result::Flaky do
+      specify { expect( Result::Flaky.ok?(false) ).to be_truthy }
+      specify { expect( Result::Flaky.ok?(true) ).to be_falsey }
+    end
+
     describe Result::Summary do
       let(:summary)   { Result::Summary.new }
       let(:failed)    { Result::Failed.new(Result::Duration.new(10), exception) }
       let(:passed)    { Result::Passed.new(Result::Duration.new(11)) }
       let(:skipped)   { Result::Skipped.new }
       let(:unknown)   { Result::Unknown.new }
+      let(:pending)   { Result::Pending.new }
       let(:undefined) { Result::Undefined.new }
       let(:exception) { StandardError.new }
 
@@ -328,6 +340,41 @@ module Cucumber::Core::Test
         [passed, failed].each { |r| r.describe_to summary }
         expect( summary.exceptions ).to eq [exception]
       end
+
+      context "ok? result" do
+        it "passed result is ok" do
+          passed.describe_to summary
+          expect( summary.ok? ).to be true
+        end
+
+        it "skipped result is ok" do
+          skipped.describe_to summary
+          expect( summary.ok? ).to be true
+        end
+
+        it "failed result is not ok" do
+          failed.describe_to summary
+          expect( summary.ok? ).to be false
+        end
+
+        it "pending result is ok if not strict" do
+          pending.describe_to summary
+          expect( summary.ok? ).to be true
+          expect( summary.ok?(true) ).to be false
+        end
+
+        it "undefined result is ok if not strict" do
+          undefined.describe_to summary
+          expect( summary.ok? ).to be true
+          expect( summary.ok?(true) ).to be false
+        end
+
+        it "flaky result is ok if not strict" do
+          summary.flaky
+          expect( summary.ok? ).to be true
+          expect( summary.ok?(true) ).to be false
+        end
+      end
     end
 
     describe Result::Duration do

data/spec/cucumber/core_spec.rb

@@ -77,127 +77,6 @@ module Cucumber
 
         compile [gherkin], visitor, [Cucumber::Core::Test::TagFilter.new(['@a', '@b'])]
       end
-
-      describe 'with tag filters that have limits' do
-        let(:visitor) { double.as_null_object }
-        let(:gherkin_doc) do
-          gherkin do
-            feature tags: '@feature' do
-              scenario tags: '@one @three' do
-                step
-              end
-
-              scenario tags: '@one' do
-                step
-              end
-
-              scenario_outline  do
-                step '<arg>'
-
-                examples tags: '@three'do
-                  row 'arg'
-                  row 'x'
-                end
-              end
-
-              scenario tags: '@ignore' do
-                step
-              end
-            end
-          end
-        end
-
-        require 'unindent'
-        def expect_tag_excess(error_message)
-          expect {
-            compile [gherkin_doc], visitor, tag_filters
-          }.to raise_error(
-            Cucumber::Core::Test::TagFilter::TagExcess, error_message.unindent.chomp
-          )
-        end
-
-        context 'on scenarios' do
-          let(:tag_filters) {
-            [ Cucumber::Core::Test::TagFilter.new(['@one:1']) ]
-          }
-
-          it 'raises a tag excess error with the location of the test cases' do
-            expect_tag_excess <<-STR
-              @one occurred 2 times, but the limit was set to 1
-                features/test.feature:5
-                features/test.feature:9
-            STR
-          end
-        end
-
-        context 'on scenario outlines' do
-          let(:tag_filters) {
-            [ Cucumber::Core::Test::TagFilter.new(['@three:1']) ]
-          }
-
-          it 'raises a tag excess error with the location of the test cases' do
-            expect_tag_excess <<-STR
-              @three occurred 2 times, but the limit was set to 1
-                features/test.feature:5
-                features/test.feature:18
-            STR
-          end
-        end
-
-        context 'on a feature with scenarios' do
-          let(:tag_filters) {
-            [ Cucumber::Core::Test::TagFilter.new(['@feature:2']) ]
-          }
-
-          it 'raises a tag excess error with the location of the test cases' do
-            expect_tag_excess <<-STR
-              @feature occurred 4 times, but the limit was set to 2
-                features/test.feature:5
-                features/test.feature:9
-                features/test.feature:18
-                features/test.feature:21
-            STR
-          end
-        end
-
-        context 'with negated tags' do
-          let(:tag_filters) {
-            [ Cucumber::Core::Test::TagFilter.new(['~@one:1']) ]
-          }
-
-          it 'raises a tag excess error with the location of the test cases' do
-            expect_tag_excess <<-STR
-              @one occurred 2 times, but the limit was set to 1
-                features/test.feature:5
-                features/test.feature:9
-            STR
-          end
-        end
-
-        context 'whith multiple tag limits' do
-          let(:tag_filters) {
-            [ Cucumber::Core::Test::TagFilter.new(['@one:1, @three:1', '~@feature:3']) ]
-          }
-
-          it 'raises a tag excess error with the location of the test cases' do
-            expect_tag_excess <<-STR
-              @one occurred 2 times, but the limit was set to 1
-                features/test.feature:5
-                features/test.feature:9
-              @three occurred 2 times, but the limit was set to 1
-                features/test.feature:5
-                features/test.feature:18
-              @feature occurred 4 times, but the limit was set to 3
-                features/test.feature:5
-                features/test.feature:9
-                features/test.feature:18
-                features/test.feature:21
-            STR
-          end
-        end
-
-      end
-
     end
 
     describe "executing a test suite" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-core
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 3.0.0.pre.2
 platform: ruby
 authors:
 - Aslak Hellesøy
@@ -12,36 +12,50 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-02 00:00:00.000000000 Z
+date: 2017-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: 4.1.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.1.3
+- !ruby/object:Gem::Dependency
+  name: cucumber-tag_expressions
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: 1.0.1
 - !ruby/object:Gem::Dependency
   name: backports
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.6'
+        version: 3.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.6'
+        version: 3.8.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -248,15 +262,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
-summary: cucumber-core-2.0.0
+summary: cucumber-core-3.0.0.pre.2
 test_files:
 - spec/capture_warnings.rb
 - spec/coverage.rb
@@ -286,4 +300,3 @@ test_files:
 - spec/cucumber/core_spec.rb
 - spec/readme_spec.rb
 - spec/report_api_spy.rb
-has_rdoc: