cucumber-core 13.0.3 → 14.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b2b88e7441c1f14355f2126f50c6373dfd45cd21298d37533297efc44e62cfff
-  data.tar.gz: bf8cb6fbb013a074b6e65c846cfc76d42f259654639f999b7bd1a91f9bca02ef
+  metadata.gz: 570471feb1c7ceb0d00c12ffda878f8520993ec3a8cf31059f38f4eb4e045923
+  data.tar.gz: 5e303f42a9aecf8290351f657f9aa763d0a046623e6479083c466cd040cfa8c6
 SHA512:
-  metadata.gz: 315e5ac87eb4c89f510ab9626aa3b6e2413ee459ba428ebd0d4be867e171d9600ef25aa9c941e9b34aca98f2375b292365d2d30f72e4a7225ff388180aa7a01a
-  data.tar.gz: d35ddfa0b15ffae9b824d3826b775f90eb9603f62c88b014ed2edc950226b4afd5fd4a05558922e5e43613dc7d3f686b5607e8d33ef11d20e083b75ba4185974
+  metadata.gz: def6d99174f68b29d3daa43256175014306168b77f484341d5fb78b3e2446cf539dff514a9fb85eabb65ec9c342507855121bfa87135b848ea16d29ddcc19a4f
+  data.tar.gz: 8873beb624b2cbc3144e8b46cb3d03709855491cfbeba79b796e5f15bdc6540eaa1ec3c59cc67dd43be4b20815ac4ecfc55885ea1cb8034212f924f06197110c

data/CHANGELOG.md

@@ -10,6 +10,16 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 
 ## [Unreleased]
 
+## [14.0.0] - 2024-08-08
+### Changed
+- Permit usage of gherkin up to v29 and messages up to v26
+- **Internal Breaking Change**: Structure of `Action` classes have changed.
+See upgrading notes for [14.0.0.md](upgrading_notes/14.0.0.md#upgrading-to-cucumber-core-1400)
+([#282](https://github.com/cucumber/cucumber-ruby-core/pull/282))
+
+### Removed
+- Remove support for ruby 2.6 and below. 2.7 or higher is required now (Autofixed to Ruby 2.7 styles)
+
 ## [13.0.3] - 2024-07-24
 ### Changed
 - Fixed up all remaining Layout auto-correct cops in the codebase
@@ -31,8 +41,8 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 - Now using a 2-tiered changelog to avoid any bugs when using polyglot-release
 - More refactoring of the repo by fixing up a bunch of manual rubocop offenses (See PR's for details)
 ([#259](https://github.com/cucumber/cucumber-ruby-core/pull/259) [#262](https://github.com/cucumber/cucumber-ruby-core/pull/262) [#268](https://github.com/cucumber/cucumber-ruby-core/pull/268) [#274](https://github.com/cucumber/cucumber-ruby-core/pull/274))
-- In all `Summary` and `Result` classes, changed the `strict` argument into a keyword argument
-See upgrading notes for [13.0.0.md](upgrading_notes/13.0.0.md#upgrading-to-1300)
+- In all `Summary` and `Result` classes, changed the `strict` argument into a keyword argument.
+See upgrading notes for [13.0.0.md](upgrading_notes/13.0.0.md#upgrading-to-cucumber-core-1300)
 ([#261](https://github.com/cucumber/cucumber-ruby-core/pull/261))
 - Permit usage of gherkin v27
 
@@ -64,7 +74,8 @@ See upgrading notes for [13.0.0.md](upgrading_notes/13.0.0.md#upgrading-to-1300)
 ### Changed
 - Updated `cucumber-gherkin` and `cucumber-messages`
 
-[Unreleased]: https://github.com/cucumber/cucumber-ruby-core/compare/v13.0.3...HEAD
+[Unreleased]: https://github.com/cucumber/cucumber-ruby-core/compare/v14.0.0...HEAD
+[14.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v13.0.3...v14.0.0
 [13.0.3]: https://github.com/cucumber/cucumber-ruby-core/compare/v13.0.2...v13.0.3
 [13.0.2]: https://github.com/cucumber/cucumber-ruby-core/compare/v13.0.1...v13.0.2
 [13.0.1]: https://github.com/cucumber/cucumber-ruby-core/compare/v13.0.0...v13.0.1

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (C) The Cucumber Organisation
+Copyright (c) Cucumber Ltd. and Contributors
 
 MIT License (Expat)
 

data/lib/cucumber/core/events.rb

@@ -1,4 +1,3 @@
-# coding: utf-8
 # frozen_string_literal: true
 
 require 'cucumber/core/event'
@@ -87,7 +86,7 @@ module Cucumber
       #
       # @return [Hash{Symbol => Class}]
       def self.build_registry(*types)
-        types.map { |type| [type.event_id, type] }.to_h
+        types.to_h { |type| [type.event_id, type] }
       end
     end
   end

data/lib/cucumber/core/gherkin/parser.rb

@@ -50,7 +50,7 @@ module Cucumber
           case type?(message)
           when :gherkin_document; then event_bus.gherkin_source_parsed(message.gherkin_document)
           when :pickle;           then receiver.pickle(message.pickle)
-          when :parse_error;      then raise ParseError.new("#{document.uri}: #{message.parse_error.message}")
+          when :parse_error;      then raise ParseError, "#{document.uri}: #{message.parse_error.message}"
           else                    raise "Unknown message: #{message.to_hash}"
           end
         end

data/lib/cucumber/core/gherkin/writer.rb

@@ -16,7 +16,8 @@ module Cucumber
 
         class Gherkin
           def initialize(uri, &source)
-            @uri, @source = uri, source
+            @uri = uri
+            @source = source
           end
 
           def comment(line)
@@ -193,8 +194,7 @@ module Cucumber
           include Indentation.level(6)
           include HasRows
 
-          def initialize(*)
-          end
+          def initialize(*); end
 
           def build(source)
             source + statements

data/lib/cucumber/core/test/action/defined.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+require 'cucumber/core/test/location'
+require 'cucumber/core/test/result'
+require 'cucumber/core/test/timer'
+
+module Cucumber
+  module Core
+    module Test
+      module Action
+        class Defined
+          attr_reader :location
+
+          def initialize(location = nil, &block)
+            raise ArgumentError, 'Passing a block to execute the action is mandatory.' unless block
+
+            @location = location || Test::Location.new(*block.source_location)
+            @block = block
+            @timer = Timer.new
+          end
+
+          def skip(*)
+            skipped
+          end
+
+          def execute(*args)
+            @timer.start
+            @block.call(*args)
+            passed
+          rescue Result::Raisable => e
+            e.with_duration(@timer.duration)
+          rescue Exception => e
+            failed(e)
+          end
+
+          def inspect
+            "#<#{self.class}: #{location}>"
+          end
+
+          private
+
+          def passed
+            Result::Passed.new(@timer.duration)
+          end
+
+          def failed(exception)
+            Result::Failed.new(@timer.duration, exception)
+          end
+
+          def skipped
+            Result::Skipped.new
+          end
+        end
+      end
+    end
+  end
+end

data/lib/cucumber/core/test/action/undefined.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require 'cucumber/core/test/result'
+
+module Cucumber
+  module Core
+    module Test
+      module Action
+        class Undefined
+          attr_reader :location
+
+          def initialize(source_location)
+            @location = source_location
+          end
+
+          def execute(*)
+            undefined
+          end
+
+          def skip(*)
+            undefined
+          end
+
+          private
+
+          def undefined
+            Result::Undefined.new
+          end
+        end
+      end
+    end
+  end
+end

data/lib/cucumber/core/test/action/unskippable.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require 'cucumber/core/test/result'
+require 'cucumber/core/test/action/defined'
+
+module Cucumber
+  module Core
+    module Test
+      module Action
+        class Unskippable < Defined
+          def skip(*args)
+            execute(*args)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/cucumber/core/test/action.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+require 'cucumber/core/test/location'
+require 'cucumber/core/test/result'
+require 'cucumber/core/test/timer'
+
+require 'cucumber/core/test/action/defined'
+require 'cucumber/core/test/action/undefined'
+require 'cucumber/core/test/action/unskippable'

data/lib/cucumber/core/test/around_hook.rb

@@ -21,10 +21,10 @@ module Cucumber
           @timer.start
           @block.call(continue)
           Result::Unknown.new # Around hook does not know the result of the inner test steps
-        rescue Result::Raisable => exception
-          exception.with_duration(@timer.duration)
-        rescue Exception => exception
-          failed(exception)
+        rescue Result::Raisable => e
+          e.with_duration(@timer.duration)
+        rescue Exception => e
+          failed(e)
         end
 
         private

data/lib/cucumber/core/test/case.rb

@@ -10,7 +10,7 @@ module Cucumber
         attr_reader :id, :name, :test_steps, :location, :parent_locations, :tags, :language, :around_hooks
 
         def initialize(id, name, test_steps, location, parent_locations, tags, language, around_hooks = [])
-          raise ArgumentError.new("test_steps should be an Array but is a #{test_steps.class}") unless test_steps.is_a?(Array)
+          raise ArgumentError, "test_steps should be an Array but is a #{test_steps.class}" unless test_steps.is_a?(Array)
 
           @id = id
           @name = name

data/lib/cucumber/core/test/data_table.rb

@@ -101,7 +101,7 @@ module Cucumber
         end
 
         def ensure_array_of_array(array)
-          Hash === array[0] ? hashes_to_array(array) : array
+          array[0].is_a?(Hash) ? hashes_to_array(array) : array
         end
 
         def hashes_to_array(hashes)

data/lib/cucumber/core/test/doc_string.rb

@@ -60,9 +60,7 @@ module Cucumber
           if other.respond_to?(:content_type)
             return false unless content_type == other.content_type
           end
-          if other.respond_to?(:to_str)
-            return content == other.to_str
-          end
+          return content == other.to_str if other.respond_to?(:to_str)
 
           false
         end

data/lib/cucumber/core/test/filters/locations_filter.rb

@@ -23,11 +23,11 @@ module Cucumber
         private
 
         def sorted_test_cases
-          filter_locations.map { |filter_location|
-            test_cases[filter_location.file].select { |test_case|
+          filter_locations.map do |filter_location|
+            test_cases[filter_location.file].select do |test_case|
               test_case.match_locations?([filter_location])
-            }
-          }.flatten.uniq
+            end
+          end.flatten.uniq
         end
 
         def test_cases

data/lib/cucumber/core/test/filters/name_filter.rb

@@ -7,9 +7,7 @@ module Cucumber
     module Test
       class NameFilter < Filter.new(:name_regexps)
         def test_case(test_case)
-          if accept?(test_case)
-            test_case.describe_to(receiver)
-          end
+          test_case.describe_to(receiver) if accept?(test_case)
           self
         end
 

data/lib/cucumber/core/test/filters/tag_filter.rb

@@ -8,9 +8,7 @@ module Cucumber
       class TagFilter < Filter.new(:filter_expressions)
         def test_case(test_case)
           test_cases << test_case
-          if test_case.match_tags?(filter_expressions)
-            test_case.describe_to(receiver)
-          end
+          test_case.describe_to(receiver) if test_case.match_tags?(filter_expressions)
           self
         end
 

data/lib/cucumber/core/test/location.rb

@@ -22,7 +22,7 @@ module Cucumber
           pwd = File.expand_path(Dir.pwd)
           pwd.force_encoding(file.encoding)
           if file.index(pwd)
-            file = file[pwd.length + 1..-1]
+            file = file[pwd.length + 1..]
           elsif file =~ /.*\/gems\/(.*\.rb)$/
             file = $1
           end
@@ -38,7 +38,7 @@ module Cucumber
           end
         end
 
-        class Wildcard < Struct.new(:file)
+        Wildcard = Struct.new(:file) do
           def to_s
             file
           end
@@ -52,7 +52,7 @@ module Cucumber
           end
         end
 
-        class Precise < Struct.new(:file, :lines)
+        Precise = Struct.new(:file, :lines) do
           def include?(other_lines)
             lines.include?(other_lines)
           end
@@ -96,7 +96,7 @@ module Cucumber
         end
 
         require 'set'
-        class Lines < Struct.new(:data)
+        Lines = Struct.new(:data) do
           protected :data
 
           def initialize(raw_data)
@@ -167,17 +167,17 @@ module Cucumber
         end
 
         def tags
-          # will be overriden by nodes that actually have tags
+          # will be overridden by nodes that actually have tags
           []
         end
 
         def comments
-          # will be overriden by nodes that actually have comments
+          # will be overridden by nodes that actually have comments
           []
         end
 
         def multiline_arg
-          # will be overriden by nodes that actually have a multiline_argument
+          # will be overridden by nodes that actually have a multiline_argument
           Test::EmptyMultilineArgument.new
         end
       end

data/lib/cucumber/core/test/result.rb

@@ -1,4 +1,3 @@
-# encoding: utf-8
 # frozen_string_literal: true
 
 require 'cucumber/messages'
@@ -173,7 +172,8 @@ module Cucumber
           attr_reader :message, :duration
 
           def initialize(message = '', duration = UnknownDuration.new, backtrace = nil)
-            @message, @duration = message, duration
+            @message = message
+            @duration = duration
             super(message)
             set_backtrace(backtrace) if backtrace
           end
@@ -287,7 +287,7 @@ module Cucumber
           private :settings
 
           def initialize(strict_types = [])
-            @settings = STRICT_AFFECTED_TYPES.map { |t| [t, :default] }.to_h
+            @settings = STRICT_AFFECTED_TYPES.to_h { |t| [t, :default] }
             strict_types.each do |type|
               set_strict(true, type)
             end

data/lib/cucumber/core/test/step.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'cucumber/core/test/result'
-require 'cucumber/core/test/actions'
+require 'cucumber/core/test/action'
 require 'cucumber/core/test/empty_multiline_argument'
 
 module Cucumber
@@ -10,7 +10,7 @@ module Cucumber
       class Step
         attr_reader :id, :text, :location, :multiline_arg
 
-        def initialize(id, text, location, multiline_arg = Test::EmptyMultilineArgument.new, action = Test::UndefinedAction.new(location))
+        def initialize(id, text, location, multiline_arg = Test::EmptyMultilineArgument.new, action = Test::Action::Undefined.new(location))
           raise ArgumentError if text.nil? || text.empty?
 
           @id = id
@@ -37,7 +37,7 @@ module Cucumber
         end
 
         def with_action(action_location = nil, &block)
-          self.class.new(id, text, location, multiline_arg, Test::Action.new(action_location, &block))
+          self.class.new(id, text, location, multiline_arg, Test::Action::Defined.new(action_location, &block))
         end
 
         def backtrace_line

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-core
 version: !ruby/object:Gem::Version
-  version: 13.0.3
+  version: 14.0.0
 platform: ruby
 authors:
 - Aslak Hellesøy
@@ -12,48 +12,48 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-07-24 00:00:00.000000000 Z
+date: 2024-08-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-gherkin
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ">"
       - !ruby/object:Gem::Version
         version: '27'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '28'
+        version: '30'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ">"
       - !ruby/object:Gem::Version
         version: '27'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '28'
+        version: '30'
 - !ruby/object:Gem::Dependency
   name: cucumber-messages
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ">"
       - !ruby/object:Gem::Version
-        version: '20'
+        version: '22'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '23'
+        version: '27'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ">"
       - !ruby/object:Gem::Version
-        version: '20'
+        version: '22'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '23'
+        version: '27'
 - !ruby/object:Gem::Dependency
   name: cucumber-tag-expressions
   requirement: !ruby/object:Gem::Requirement
@@ -80,14 +80,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13.1'
+        version: '13.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13.1'
+        version: '13.2'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -108,28 +108,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.28.2
+        version: 1.61.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.28.2
+        version: 1.61.0
 - !ruby/object:Gem::Dependency
   name: rubocop-packaging
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.1
+        version: 0.5.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.1
+        version: 0.5.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -150,14 +150,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.10.0
+        version: 3.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.10.0
+        version: 3.0.1
 description: Core library for the Cucumber BDD app
 email: cukes@googlegroups.com
 executables: []
@@ -179,17 +179,16 @@ files:
 - lib/cucumber/core/gherkin/writer/helpers.rb
 - lib/cucumber/core/platform.rb
 - lib/cucumber/core/report/summary.rb
-- lib/cucumber/core/test/actions.rb
-- lib/cucumber/core/test/actions/action.rb
-- lib/cucumber/core/test/actions/undefined_action.rb
-- lib/cucumber/core/test/actions/unskippable_action.rb
+- lib/cucumber/core/test/action.rb
+- lib/cucumber/core/test/action/defined.rb
+- lib/cucumber/core/test/action/undefined.rb
+- lib/cucumber/core/test/action/unskippable.rb
 - lib/cucumber/core/test/around_hook.rb
 - lib/cucumber/core/test/case.rb
 - lib/cucumber/core/test/data_table.rb
 - lib/cucumber/core/test/doc_string.rb
 - lib/cucumber/core/test/empty_multiline_argument.rb
 - lib/cucumber/core/test/filters.rb
-- lib/cucumber/core/test/filters/activate_steps_for_self_test.rb
 - lib/cucumber/core/test/filters/locations_filter.rb
 - lib/cucumber/core/test/filters/name_filter.rb
 - lib/cucumber/core/test/filters/tag_filter.rb
@@ -218,15 +217,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.0.1
+      version: 3.2.8
 requirements: []
 rubygems_version: 3.3.5
 signing_key: 
 specification_version: 4
-summary: cucumber-core-13.0.3
+summary: cucumber-core-14.0.0
 test_files: []

data/lib/cucumber/core/test/actions/action.rb

@@ -1,57 +0,0 @@
-# frozen_string_literal: true
-
-require 'cucumber/core/test/location'
-require 'cucumber/core/test/result'
-require 'cucumber/core/test/timer'
-
-module Cucumber
-  module Core
-    module Test
-      class Action
-        def initialize(location = nil, &block)
-          raise ArgumentError, 'Passing a block to execute the action is mandatory.' unless block
-
-          @location = location || Test::Location.new(*block.source_location)
-          @block = block
-          @timer = Timer.new
-        end
-
-        def skip(*)
-          skipped
-        end
-
-        def execute(*args)
-          @timer.start
-          @block.call(*args)
-          passed
-        rescue Result::Raisable => exception
-          exception.with_duration(@timer.duration)
-        rescue Exception => exception
-          failed(exception)
-        end
-
-        def location
-          @location
-        end
-
-        def inspect
-          "#<#{self.class}: #{location}>"
-        end
-
-        private
-
-        def passed
-          Result::Passed.new(@timer.duration)
-        end
-
-        def failed(exception)
-          Result::Failed.new(@timer.duration, exception)
-        end
-
-        def skipped
-          Result::Skipped.new
-        end
-      end
-    end
-  end
-end

data/lib/cucumber/core/test/actions/undefined_action.rb

@@ -1,31 +0,0 @@
-# frozen_string_literal: true
-
-require 'cucumber/core/test/result'
-
-module Cucumber
-  module Core
-    module Test
-      class UndefinedAction
-        attr_reader :location
-
-        def initialize(source_location)
-          @location = source_location
-        end
-
-        def execute(*)
-          undefined
-        end
-
-        def skip(*)
-          undefined
-        end
-
-        private
-
-        def undefined
-          Result::Undefined.new
-        end
-      end
-    end
-  end
-end

data/lib/cucumber/core/test/actions/unskippable_action.rb

@@ -1,16 +0,0 @@
-# frozen_string_literal: true
-
-require 'cucumber/core/test/result'
-require 'cucumber/core/test/actions/action'
-
-module Cucumber
-  module Core
-    module Test
-      class UnskippableAction < Action
-        def skip(*args)
-          execute(*args)
-        end
-      end
-    end
-  end
-end

data/lib/cucumber/core/test/actions.rb

@@ -1,9 +0,0 @@
-# frozen_string_literal: true
-
-require 'cucumber/core/test/location'
-require 'cucumber/core/test/result'
-require 'cucumber/core/test/timer'
-
-require 'cucumber/core/test/actions/action'
-require 'cucumber/core/test/actions/undefined_action'
-require 'cucumber/core/test/actions/unskippable_action'

data/lib/cucumber/core/test/filters/activate_steps_for_self_test.rb

@@ -1,35 +0,0 @@
-# frozen_string_literal: true
-
-module Cucumber
-  module Core
-    module Test
-      module Filters
-        # This filter is used for testing Cucumber itself. It adds step definitions
-        # that will activate steps to have passed / failed / pending results
-        # if they use conventional names.
-        #
-        # It was extracted from our test code, and does not have any tests of its own.
-        class ActivateStepsForSelfTest < Core::Filter.new
-          Failure = Class.new(StandardError)
-
-          def test_case(test_case)
-            test_case.with_steps(test_steps(test_case)).describe_to(receiver)
-          end
-
-          private
-
-          def test_steps(test_case)
-            test_case.test_steps.map do |step|
-              case step.text
-              when /fail/ then step.with_action { raise Failure }
-              when /pending/ then step.with_action { raise Test::Result::Pending }
-              when /pass/ then step.with_action { :no_op }
-              else; step
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end