cucumber-core 1.1.3 → 1.2.0

data/spec/cucumber/core/test/runner_spec.rb

@@ -10,15 +10,16 @@ module Cucumber::Core::Test
     let(:source)    { [double('ast node', location: double)] }
     let(:runner)    { Runner.new(report) }
     let(:report)    { double.as_null_object }
-    let(:passing)   { Step.new([double]).with_action {} }
-    let(:failing)   { Step.new([double]).with_action { raise exception } }
-    let(:pending)   { Step.new([double]).with_action { raise Result::Pending.new("TODO") } }
-    let(:skipping)  { Step.new([double]).with_action { raise Result::Skipped.new } }
-    let(:undefined) { Step.new([double]) }
+    let(:passing)   { Step.new([source]).with_action {} }
+    let(:failing)   { Step.new([source]).with_action { raise exception } }
+    let(:pending)   { Step.new([source]).with_action { raise Result::Pending.new("TODO") } }
+    let(:skipping)  { Step.new([source]).with_action { raise Result::Skipped.new } }
+    let(:undefined) { Step.new([source]) }
     let(:exception) { StandardError.new('test error') }
 
     before do
       allow(report).to receive(:before_test_case)
+      allow(source).to receive(:location)
     end
 
     context "reporting the duration of a test case" do
@@ -100,6 +101,24 @@ module Cucumber::Core::Test
             expect( report ).to receive(:after_test_case) do |test_case, result|
               expect( result ).to be_undefined
             end
+            allow( undefined.source.last ).to receive(:name)
+            test_case.describe_to runner
+          end
+
+          it 'sets the message on the result' do
+            expect( report ).to receive(:after_test_case) do |test_case, result|
+              expect( result.message ).to eq("Undefined step: \"step name\"")
+            end
+            expect( undefined.source.last ).to receive(:name).and_return("step name")
+            test_case.describe_to runner
+          end
+
+          it 'appends the backtrace of the result' do
+            expect( report ).to receive(:after_test_case) do |test_case, result|
+              expect( result.backtrace ).to eq(["step line"])
+            end
+            expect( undefined.source.last ).to receive(:backtrace_line).and_return("step line")
+            allow( undefined.source.last ).to receive(:name)
             test_case.describe_to runner
           end
         end
@@ -113,6 +132,14 @@ module Cucumber::Core::Test
             end
             test_case.describe_to runner
           end
+
+          it 'appends the backtrace of the result' do
+            expect( report ).to receive(:after_test_case) do |test_case, result|
+              expect( result.backtrace.last ).to eq("step line")
+            end
+            expect( pending.source.last ).to receive(:backtrace_line).and_return("step line")
+            test_case.describe_to runner
+          end
         end
 
         context "a skipping step" do
@@ -124,6 +151,14 @@ module Cucumber::Core::Test
             end
             test_case.describe_to runner
           end
+
+          it 'appends the backtrace of the result' do
+            expect( report ).to receive(:after_test_case) do |test_case, result|
+              expect( result.backtrace.last ).to eq("step line")
+            end
+            expect( skipping.source.last ).to receive(:backtrace_line).and_return("step line")
+            test_case.describe_to runner
+          end
         end
 
         context 'that fail' do
@@ -135,6 +170,14 @@ module Cucumber::Core::Test
             end
             test_case.describe_to runner
           end
+
+          it 'appends the backtrace of the exception of the result' do
+            expect( report ).to receive(:after_test_case) do |test_case, result|
+              expect( result.exception.backtrace.last ).to eq("step line")
+            end
+            expect( failing.source.last ).to receive(:backtrace_line).and_return("step line")
+            test_case.describe_to runner
+          end
         end
 
         context 'where the first step fails' do
@@ -202,8 +245,8 @@ module Cucumber::Core::Test
         hook_mapping = UnskippableAction.new do |last_result|
           result_spy = last_result
         end
-        after_hook = Step.new([double], hook_mapping)
-        failing_step = Step.new([double]).with_action { fail }
+        after_hook = Step.new([source], hook_mapping)
+        failing_step = Step.new([source]).with_action { fail }
         test_case = Case.new([failing_step, after_hook], source)
         test_case.describe_to runner
         expect(result_spy).to be_failed
@@ -214,7 +257,7 @@ module Cucumber::Core::Test
     context "with around hooks" do
       it "passes normally when around hooks don't fail" do
         around_hook = AroundHook.new { |block| block.call }
-        passing_step = Step.new([double]).with_action {}
+        passing_step = Step.new([source]).with_action {}
         test_case = Case.new([passing_step], source, [around_hook])
         expect(report).to receive(:after_test_case).with(test_case, anything) do |reported_test_case, result|
           expect(result).to be_passed
@@ -224,7 +267,7 @@ module Cucumber::Core::Test
 
       it "gets a failed result if the Around hook fails before the test case is run" do
         around_hook = AroundHook.new { |block| raise exception }
-        passing_step = Step.new([double]).with_action {}
+        passing_step = Step.new([source]).with_action {}
         test_case = Case.new([passing_step], source, [around_hook])
         expect(report).to receive(:after_test_case).with(test_case, anything) do |reported_test_case, result|
           expect(result).to be_failed
@@ -235,7 +278,7 @@ module Cucumber::Core::Test
 
       it "gets a failed result if the Around hook fails after the test case is run" do
         around_hook = AroundHook.new { |block| block.call; raise exception }
-        passing_step = Step.new([double]).with_action {}
+        passing_step = Step.new([source]).with_action {}
         test_case = Case.new([passing_step], source, [around_hook])
         expect(report).to receive(:after_test_case).with(test_case, anything) do |reported_test_case, result|
           expect(result).to be_failed
@@ -246,7 +289,7 @@ module Cucumber::Core::Test
 
       it "fails when a step fails if the around hook works" do
         around_hook = AroundHook.new { |block| block.call }
-        failing_step = Step.new([double]).with_action { raise exception }
+        failing_step = Step.new([source]).with_action { raise exception }
         test_case = Case.new([failing_step], source, [around_hook])
         expect(report).to receive(:after_test_case).with(test_case, anything) do |reported_test_case, result|
           expect(result).to be_failed

data/spec/cucumber/core/test/step_spec.rb

@@ -4,16 +4,21 @@ module Cucumber::Core::Test
   describe Step do
 
     describe "describing itself" do
+      let(:step_or_hook) { double }
+      before(:each) do
+        allow( step_or_hook ).to receive(:location)
+      end
+
       it "describes itself to a visitor" do
         visitor = double
         args = double
-        test_step = Step.new([double])
+        test_step = Step.new([step_or_hook])
         expect( visitor ).to receive(:test_step).with(test_step, args)
         test_step.describe_to(visitor, args)
       end
 
       it "describes its source to a visitor" do
-        feature, scenario, step_or_hook = double, double, double
+        feature, scenario = double, double
         visitor = double
         args = double
         expect( feature      ).to receive(:describe_to).with(visitor, args)
@@ -26,6 +31,9 @@ module Cucumber::Core::Test
 
     describe "executing" do
       let(:ast_step) { double }
+      before(:each) do
+        allow( ast_step ).to receive(:location)
+      end
 
       it "passes arbitrary arguments to the action's block" do
         args_spy = nil
@@ -72,5 +80,12 @@ module Cucumber::Core::Test
       expect( test_step.location ).to eq location
     end
 
+    it "exposes the location of the action as attribute" do
+      location = double
+      action = double(location: location)
+      test_step = Step.new([double], action)
+      expect( test_step.action_location ).to eq location
+    end
+
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-core
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.2.0
 platform: ruby
 authors:
 - Aslak Hellesøy
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-25 00:00:00.000000000 Z
+date: 2015-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin
@@ -218,7 +218,7 @@ rubyforge_project:
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: cucumber-core-1.1.3
+summary: cucumber-core-1.2.0
 test_files:
 - spec/capture_warnings.rb
 - spec/coverage.rb
@@ -245,3 +245,4 @@ test_files:
 - spec/cucumber/core_spec.rb
 - spec/readme_spec.rb
 - spec/report_api_spy.rb
+has_rdoc: