cucumber-core 1.0.0.beta.3 → 1.0.0.beta.4

data/spec/cucumber/core/ast/outline_step_spec.rb

@@ -32,7 +32,7 @@ module Cucumber
             let(:name) { 'a <color> cucumber' }
 
             it "replaces the argument" do
-              row = ExamplesTable::Row.new({'color' => 'green'}, 1, location)
+              row = ExamplesTable::Row.new({'color' => 'green'}, 1, location, language)
               expect( outline_step.to_step(row).name ).to eq 'a green cucumber'
             end
 
@@ -49,7 +49,7 @@ module Cucumber
               expect( visitor ).to receive(:data_table) do |data_table|
                 expect( data_table.raw ).to eq [['x', 'y'], ['a', 'a replacement']]
               end
-              row = ExamplesTable::Row.new({'arg' => 'replacement'}, 1, location)
+              row = ExamplesTable::Row.new({'arg' => 'replacement'}, 1, location, language)
               step = outline_step.to_step(row)
               step.describe_to(visitor)
             end
@@ -67,7 +67,7 @@ module Cucumber
               expect( visitor ).to receive(:doc_string) do |doc_string|
                 expect( doc_string.content ).to eq "a replacement that needs replacing"
               end
-              row = ExamplesTable::Row.new({'arg' => 'replacement'}, 1, location)
+              row = ExamplesTable::Row.new({'arg' => 'replacement'}, 1, location, language)
               step = outline_step.to_step(row)
               step.describe_to(visitor)
             end

data/spec/cucumber/core/gherkin/parser_spec.rb

@@ -27,6 +27,24 @@ module Cucumber
           end
         end
 
+        RSpec::Matchers.define :a_null_feature do
+          match do |actual|
+            allow( visitor ).to receive(:feature).and_throw
+
+            actual.describe_to( visitor )
+          end
+        end
+
+        context "for empty files" do
+          let(:source) { Gherkin::Document.new(path, '') }
+          let(:path)   { 'path_to/the.feature' }
+
+          it "creates a NullFeature" do
+            expect( receiver ).to receive(:feature).with(a_null_feature)
+            parse
+          end
+        end
+
         include Writer
         def self.source(&block)
           let(:source) { gherkin(&block) }

data/spec/cucumber/core/test/action_spec.rb

@@ -1,4 +1,5 @@
 require 'cucumber/core/test/action'
+require 'cucumber/core/test/duration_matcher'
 
 module Cucumber
   module Core
@@ -76,13 +77,13 @@ module Cucumber
             it "records the nanoseconds duration of the execution on the result" do
               mapping = Action.new { }
               duration = mapping.execute(last_result).duration
-              expect( duration ).to eq 1
+              expect( duration ).to be_duration 1
             end
 
             it "records the duration of a failed execution" do
               mapping = Action.new { raise StandardError }
               duration = mapping.execute(last_result).duration
-              expect( duration ).to eq 1
+              expect( duration ).to be_duration 1
             end
           end
 

data/spec/cucumber/core/test/duration_matcher.rb

@@ -0,0 +1,19 @@
+# -*- encoding: utf-8 -*-
+require 'cucumber/core/test/result'
+require 'rspec/expectations'
+
+module Cucumber::Core::Test
+  RSpec::Matchers.define :be_duration do |expected|
+    match do |actual|
+      actual.tap { |duration| @nanoseconds = duration.nanoseconds }
+      @nanoseconds == expected
+    end
+  end
+
+  RSpec::Matchers.define :an_unknown_duration do
+    match do |actual|
+      actual.tap { raise "#tap block was executed, not an UnknownDuration" } 
+      expect(actual).to respond_to(:nanoseconds)
+    end
+  end
+end

data/spec/cucumber/core/test/mapper_spec.rb

@@ -97,15 +97,19 @@ module Cucumber
           it "adds hooks in the right order" do
             log = double
             allow(mappings).to receive(:test_case) do |test_case, mapper|
-              mapper.before { log.before }
-              mapper.after { log.after }
+              mapper.before { log.before_hook_1 }
+              mapper.before { log.before_hook_2 }
+              mapper.after { log.after_hook_1 }
+              mapper.after { log.after_hook_2 }
             end
-            mapped_step = test_step.with_mapping { log.step }
+            mapped_step = test_step.with_mapping { log.step_1 }
             test_case = Case.new([mapped_step], source)
 
-            expect( log ).to receive(:before).ordered
-            expect( log ).to receive(:step).ordered
-            expect( log ).to receive(:after).ordered
+            expect( log ).to receive(:before_hook_1).ordered
+            expect( log ).to receive(:before_hook_2).ordered
+            expect( log ).to receive(:step_1).ordered
+            expect( log ).to receive(:after_hook_2).ordered
+            expect( log ).to receive(:after_hook_1).ordered
 
             allow(receiver).to receive(:test_case).and_yield(receiver)
             allow(receiver).to receive(:test_step) do |test_step|
@@ -128,7 +132,7 @@ module Cucumber
               expect( scenario ).to receive(:describe_to)
               expect( visitor ).to receive(:before_hook) do |hook, hook_args|
                 expect( args ).to eq(hook_args)
-                expect( hook.location.to_s ).to eq("#{__FILE__}:121")
+                expect( hook.location.to_s ).to eq("#{__FILE__}:125")
               end
               test_step.describe_source_to(visitor, args)
             end
@@ -148,7 +152,7 @@ module Cucumber
               expect( scenario ).to receive(:describe_to)
               expect( visitor ).to receive(:after_hook) do |hook, hook_args|
                 expect( args ).to eq(hook_args)
-                expect( hook.location.to_s ).to eq("#{__FILE__}:141")
+                expect( hook.location.to_s ).to eq("#{__FILE__}:145")
               end
               test_step.describe_source_to(visitor, args)
             end
@@ -168,7 +172,24 @@ module Cucumber
             expect( visitor ).to receive(:step).ordered
             expect( visitor ).to receive(:after_step_hook) do |hook, hook_args|
               expect( args ).to eq(hook_args)
-              expect( hook.location.to_s ).to eq("#{__FILE__}:160")
+              expect( hook.location.to_s ).to eq("#{__FILE__}:164")
+            end.once.ordered
+            expect( visitor ).to receive(:step).ordered
+            test_case.describe_to mapper
+          end
+
+          it "prepends before_step hooks to the test step" do
+            allow(mappings).to receive(:test_step) do |test_step, mapper|
+              mapper.before {}
+            end
+            args = double('args')
+            visitor = double('visitor')
+            allow(receiver).to receive(:test_case) do |test_case|
+              test_case.test_steps.first.describe_source_to(visitor, args)
+            end
+            expect( visitor ).to receive(:before_step_hook) do |hook, hook_args|
+              expect( args ).to eq(hook_args)
+              expect( hook.location.to_s ).to eq("#{__FILE__}:183")
             end.once.ordered
             expect( visitor ).to receive(:step).ordered
             test_case.describe_to mapper
@@ -180,4 +201,3 @@ module Cucumber
     end
   end
 end
-

data/spec/cucumber/core/test/result_spec.rb

@@ -1,5 +1,6 @@
 # -*- encoding: utf-8 -*-
 require 'cucumber/core/test/result'
+require 'cucumber/core/test/duration_matcher'
 
 module Cucumber::Core::Test
   describe Result do
@@ -9,7 +10,7 @@ module Cucumber::Core::Test
 
     describe Result::Passed do
       subject(:result) { Result::Passed.new(duration) }
-      let(:duration)   { 1 * 1000 * 1000 }
+      let(:duration)   { Result::Duration.new(1 * 1000 * 1000) }
 
       it "describes itself to a visitor" do
         expect( visitor ).to receive(:passed).with(args)
@@ -38,7 +39,7 @@ module Cucumber::Core::Test
 
     describe Result::Failed do
       subject(:result) { Result::Failed.new(duration, exception) }
-      let(:duration)   { 1 * 1000 * 1000 }
+      let(:duration)   { Result::Duration.new(1 * 1000 * 1000) }
       let(:exception)  { StandardError.new("error message") }
 
       it "describes itself to a visitor" do
@@ -84,6 +85,7 @@ module Cucumber::Core::Test
 
       it "describes itself to a visitor" do
         expect( visitor ).to receive(:undefined).with(args)
+        expect( visitor ).to receive(:duration).with(an_unknown_duration, args)
         result.describe_to(visitor, args)
       end
 
@@ -99,6 +101,7 @@ module Cucumber::Core::Test
 
       it "describes itself to a visitor" do
         expect( visitor ).to receive(:skipped).with(args)
+        expect( visitor ).to receive(:duration).with(an_unknown_duration, args)
         result.describe_to(visitor, args)
       end
 
@@ -111,8 +114,8 @@ module Cucumber::Core::Test
 
     describe Result::Summary do
       let(:summary)   { Result::Summary.new }
-      let(:failed)    { Result::Failed.new(10, exception) }
-      let(:passed)    { Result::Passed.new(11) }
+      let(:failed)    { Result::Failed.new(Result::Duration.new(10), exception) }
+      let(:passed)    { Result::Passed.new(Result::Duration.new(11)) }
       let(:skipped)   { Result::Skipped.new }
       let(:unknown)   { Result::Unknown.new }
       let(:undefined) { Result::Undefined.new }
@@ -142,6 +145,23 @@ module Cucumber::Core::Test
         expect( summary.total           ).to eq 1
       end
 
+      it "counts abitrary raisable results" do
+        flickering = Class.new(Result::Raisable) do
+          def describe_to(visitor, *args)
+            visitor.flickering(*args)
+          end
+        end
+
+        flickering.new.describe_to summary
+        expect( summary.total_flickering ).to eq 1
+        expect( summary.total           ).to eq 1
+      end
+
+      it "returns zero for a status where no messges have been received" do
+        expect( summary.total_passed ).to eq 0
+        expect( summary.total_ponies ).to eq 0
+      end
+
       it "doesn't count unknown results" do
         unknown.describe_to summary
         expect( summary.total ).to eq 0
@@ -158,7 +178,8 @@ module Cucumber::Core::Test
 
       it "records durations" do
         [passed, failed].each { |r| r.describe_to summary }
-        expect( summary.durations ).to eq [11, 10]
+        expect( summary.durations[0] ).to be_duration 11
+        expect( summary.durations[1] ).to be_duration 10
       end
 
       it "records exceptions" do
@@ -166,5 +187,26 @@ module Cucumber::Core::Test
         expect( summary.exceptions ).to eq [exception]
       end
     end
+
+    describe Result::Duration do
+      subject(:duration) { Result::Duration.new(10) }
+
+      it "#nanoseconds can be accessed in #tap" do
+        expect( duration.tap { |duration| @duration = duration.nanoseconds } ).to eq duration
+        expect( @duration ).to eq 10
+      end
+    end
+
+    describe Result::UnknownDuration do
+      subject(:duration) { Result::UnknownDuration.new }
+
+      it "#tap does not execute the passed block" do
+        expect( duration.tap { raise "tap executed block" } ).to eq duration
+      end
+
+      it "accessing #nanoseconds outside #tap block raises exception" do
+        expect { duration.nanoseconds }.to raise_error(RuntimeError)
+      end
+    end
   end
 end

data/spec/cucumber/core/test/runner_spec.rb

@@ -1,6 +1,7 @@
 require 'cucumber/core/test/runner'
 require 'cucumber/core/test/case'
 require 'cucumber/core/test/step'
+require 'cucumber/core/test/duration_matcher'
 
 module Cucumber::Core::Test
   describe Runner do
@@ -33,7 +34,7 @@ module Cucumber::Core::Test
 
         it "records the nanoseconds duration of the execution on the result" do
           expect( report ).to receive(:after_test_case) do |reported_test_case, result|
-            expect( result.duration ).to eq 1
+            expect( result.duration ).to be_duration 1
           end
           test_case.describe_to runner
         end
@@ -44,7 +45,7 @@ module Cucumber::Core::Test
 
         it "records the duration" do
           expect( report ).to receive(:after_test_case) do |reported_test_case, result|
-            expect( result.duration ).to eq 1
+            expect( result.duration ).to be_duration 1
           end
           test_case.describe_to runner
         end

data/spec/cucumber/core/test/timer_spec.rb

@@ -1,9 +1,22 @@
 require 'cucumber/core/test/timer'
+require 'cucumber/core/test/duration_matcher'
 
 module Cucumber
   module Core
     module Test
       describe Timer do
+        before do
+          time = double
+          allow( Time ).to receive(:now) { time }
+          allow( time ).to receive(:nsec).and_return(946752000, 946752001)
+          allow( time ).to receive(:to_i).and_return(1377009235, 1377009235)
+        end
+
+        it "returns a Result::Duration object" do
+          timer = Timer.new.start
+          expect( timer.duration ).to be_duration 1
+        end
+
         it "would be slow to test" do
           # so we won't
         end

data/spec/cucumber/core_spec.rb

@@ -2,32 +2,13 @@ require 'report_api_spy'
 require 'cucumber/core'
 require 'cucumber/core/gherkin/writer'
 require 'cucumber/core/platform'
+require 'cucumber/core/report/summary'
 
 module Cucumber
   describe Core do
     include Core
     include Core::Gherkin::Writer
 
-    describe "parsing Gherkin" do
-      it "calls the compiler with a valid AST" do
-        compiler = double(done: nil)
-        expect( compiler ).to receive(:feature) do |feature|
-          expect( feature ).to respond_to(:describe_to)
-          expect( feature ).to be_an_instance_of(Core::Ast::Feature)
-        end
-
-        gherkin = gherkin do
-          feature do
-            scenario do
-              step
-            end
-          end
-        end
-
-        parse([gherkin], compiler)
-      end
-    end
-
     describe "compiling features to a test suite" do
 
       it "compiles two scenarios into two test cases" do
@@ -216,30 +197,6 @@ module Cucumber
     end
 
     describe "executing a test suite" do
-      class SummaryReport
-        attr_reader :test_cases, :test_steps
-
-        def initialize
-          @test_cases = Core::Test::Result::Summary.new
-          @test_steps = Core::Test::Result::Summary.new
-        end
-
-        def before_test_case(*)
-          yield if block_given?
-        end
-
-        def after_test_case(test_case, result)
-          result.describe_to test_cases
-        end
-
-        def after_test_step(test_step, result)
-          result.describe_to test_steps
-        end
-
-        def method_missing(*)
-        end
-      end
-
       context "without hooks" do
         class StepTestMappings
           Failure = Class.new(StandardError)
@@ -270,7 +227,7 @@ module Cucumber
               end
             end
           end
-          report = SummaryReport.new
+          report = Core::Report::Summary.new
           mappings = StepTestMappings.new
 
           execute [gherkin], mappings, report
@@ -363,7 +320,7 @@ module Cucumber
               end
             end
           end
-          report = SummaryReport.new
+          report = Core::Report::Summary.new
           mappings = HookTestMappings.new
 
           execute [gherkin], mappings, report
@@ -440,7 +397,7 @@ module Cucumber
               end
             end
           end
-          report = SummaryReport.new
+          report = Core::Report::Summary.new
           mappings = AroundHookTestMappings.new
 
           execute [gherkin], mappings, report
@@ -481,7 +438,7 @@ module Cucumber
             end
           end
         end
-        report = SummaryReport.new
+        report = Core::Report::Summary.new
         mappings = HookTestMappings.new
 
         execute [gherkin], mappings, report, [[Cucumber::Core::Test::TagFilter, ['@a']]]
@@ -500,13 +457,40 @@ module Cucumber
             end
           end
         end
-        report = SummaryReport.new
+        report = Core::Report::Summary.new
         mappings = HookTestMappings.new
 
         execute [gherkin], mappings, report, [[Cucumber::Core::Test::NameFilter, [[/scenario/]]]]
 
         expect( report.test_cases.total ).to eq 1
       end
+
+      it "filters test cases by filename" do
+        documents = []
+        documents << gherkin("some.feature") do
+          feature 'some feature' do
+            scenario 'some scenario' do
+              step 'missing'
+            end
+          end
+        end
+        documents << gherkin("other.feature") do
+          feature 'other feature' do
+            scenario 'other scenario' do
+              step 'missing'
+            end
+          end
+        end
+
+        report = Core::Report::Summary.new
+        mappings = HookTestMappings.new
+        some_feature = Cucumber::Core::Ast::Location.new("some.feature")
+        filters = [[ Cucumber::Core::Test::LocationsFilter, [[some_feature]] ]]
+
+        execute documents, mappings, report, filters
+
+        expect( report.test_cases.total ).to eq 1
+      end
     end
   end
 end