cucumber-core 0.2.0 → 1.0.0.beta.1

data/lib/cucumber/core/test/step.rb

@@ -7,6 +7,7 @@ module Cucumber
     module Test
       class Step
         include Cucumber.initializer(:source)
+        attr_reader :source
 
         def initialize(source, mapping = Test::UndefinedMapping.new)
           raise ArgumentError if source.any?(&:nil?)
@@ -19,17 +20,10 @@ module Cucumber
         end
 
         def describe_source_to(visitor, *args)
-          source.each do |node|
+          source.reverse.each do |node|
             node.describe_to(visitor, *args)
           end
-        end
-
-        def name
-          step.name
-        end
-
-        def multiline_arg
-          step.multiline_arg
+          self
         end
 
         def skip
@@ -40,12 +34,16 @@ module Cucumber
           @mapping.execute
         end
 
-        def map(&block)
+        def with_mapping(&block)
           self.class.new(source, Test::Mapping.new(&block))
         end
 
+        def name
+          source.last.name
+        end
+
         def location
-          step.location
+          source.last.location
         end
 
         def match_locations?(queried_locations)
@@ -54,13 +52,7 @@ module Cucumber
         end
 
         def inspect
-          "#{self.class}: #{location}"
-        end
-
-        private
-
-        def step
-          source.last
+          "<#{self.class}: #{location}>"
         end
 
       end

data/lib/cucumber/core/version.rb

@@ -2,7 +2,7 @@ module Cucumber
   module Core
     class Version
       def self.to_s
-        "0.2.0"
+        "1.0.0.beta.1"
       end
     end
   end

data/spec/cucumber/core/ast/data_table_spec.rb

@@ -133,6 +133,18 @@ module Cucumber
             ]
           expect( @table.to_sexp ).to eq sexp_value
         end
+
+        describe "#each_cell" do
+          it "runs the given block on each cell in the table" do
+            table = DataTable.new([[1,2],[3,4]], location)
+            values = []
+            table.each_cell do |cell|
+              values << cell.value
+            end
+            expect( values ).to eq [1,2,3,4]
+          end
+        end
+
       end
     end
   end

data/spec/cucumber/core/ast/location_spec.rb

@@ -15,6 +15,13 @@ module Cucumber::Core::Ast
        it "is not equal to a wild card of the same file" do
          expect( Location.new(file, line) ).not_to eq Location.new(file)
        end
+
+      context "collections of locations" do
+        it "behave as expected with uniq" do
+          unique_collection = [Location.new(file, line), Location.new(file, line)].uniq
+          expect( unique_collection ).to eq [Location.new(file, line)]
+        end
+      end
     end
 
     describe "to_s" do
@@ -68,7 +75,7 @@ module Cucumber::Core::Ast
 
       context 'a range wildcard' do
         let(:range) { Location.new("foo.feature", 13..17) }
-        
+
         it "matches the first line in the same file" do
           other = Location.new("foo.feature", 13)
           expect( range ).to be_match(other)

data/spec/cucumber/core/ast/outline_step_spec.rb

@@ -2,6 +2,7 @@ require 'cucumber/core/ast/outline_step'
 require 'cucumber/core/ast/examples_table'
 require 'cucumber/core/ast/data_table'
 require 'cucumber/core/ast/doc_string'
+require 'cucumber/core/ast/empty_multiline_argument'
 
 module Cucumber
   module Core
@@ -20,7 +21,7 @@ module Cucumber
           end
 
           it 'knows the file and line' do
-            location.stub(:to_s) { 'file_name:8' }
+            allow( location ).to receive(:to_s) { 'file_name:8' }
             expect( outline_step.file_colon_line ).to eq 'file_name:8'
           end
         end
@@ -34,6 +35,12 @@ module Cucumber
               expect( outline_step.to_step(row).name ).to eq 'a green cucumber'
             end
 
+            it "knows the name of the outline step" do
+              row = ExamplesTable::Row.new({'color' => 'green'}, 1, location)
+              outline_step.gherkin_statement(double(:name => name))
+              expect( outline_step.to_step(row).gherkin_statement.name ).to eq name
+            end
+
           end
 
           context "when the step has a DataTable" do
@@ -43,8 +50,8 @@ module Cucumber
 
             it "replaces the arguments in the DataTable" do
               visitor = double
-              visitor.stub(:step).and_yield
-              expect( visitor ).to receive(:table) do |data_table| # TODO: rename this message to :data_table
+              allow( visitor ).to receive(:step).and_yield(visitor)
+              expect( visitor ).to receive(:data_table) do |data_table|
                 expect( data_table.raw ).to eq [['x', 'y'], ['a', 'a replacement']]
               end
               row = ExamplesTable::Row.new({'arg' => 'replacement'}, 1, location)
@@ -61,7 +68,7 @@ module Cucumber
 
             it "replaces the arguments in the DocString" do
               visitor = double
-              visitor.stub(:step).and_yield
+              allow( visitor ).to receive(:step).and_yield(visitor)
               expect( visitor ).to receive(:doc_string) do |doc_string|
                 expect( doc_string.content ).to eq "a replacement that needs replacing"
               end

data/spec/cucumber/core/ast/step_spec.rb

@@ -20,7 +20,7 @@ module Cucumber
 
           context "with no multiline argument" do
             it "does not try to describe any children" do
-              visitor.stub(:step).with(step).and_yield
+              allow( visitor ).to receive(:step).with(step).and_yield(visitor)
               step.describe_to(visitor)
             end
           end
@@ -30,7 +30,7 @@ module Cucumber
             let(:multiline_arg) { double }
 
             it "tells its multiline argument to describe itself" do
-              visitor.stub(:step).with(step).and_yield
+              allow( visitor ).to receive(:step).with(step).and_yield(visitor)
               expect( multiline_arg ).to receive(:describe_to).with(visitor)
               step.describe_to(visitor)
             end

data/spec/cucumber/core/compiler_spec.rb

@@ -24,7 +24,7 @@ module Cucumber::Core
         end
       ]
       compile(gherkin_documents) do |visitor|
-        expect( visitor ).to receive(:test_case).once.ordered.and_yield
+        expect( visitor ).to receive(:test_case).once.ordered.and_yield(visitor)
         expect( visitor ).to receive(:test_step).once.ordered
         expect( visitor ).to receive(:done).once.ordered
       end
@@ -45,7 +45,7 @@ module Cucumber::Core
         end
       ]
       compile(gherkin_documents) do |visitor|
-        expect( visitor ).to receive(:test_case).once.ordered.and_yield
+        expect( visitor ).to receive(:test_case).once.ordered.and_yield(visitor)
         expect( visitor ).to receive(:test_step).exactly(2).times.ordered
         expect( visitor ).to receive(:done).once.ordered
       end
@@ -111,7 +111,7 @@ module Cucumber::Core
           end
         ]
         compile(gherkin_documents) do |visitor|
-          expect( visitor ).to receive(:test_case).exactly(3).times.and_yield
+          expect( visitor ).to receive(:test_case).exactly(3).times.and_yield(visitor)
           expect( visitor ).to receive(:test_step).exactly(9).times
           expect( visitor ).to receive(:done).once
         end
@@ -202,7 +202,7 @@ module Cucumber::Core
              )
 
         it "sets the source correctly on the test steps" do
-          outline_step.stub(to_step: outline_ast_step)
+          allow( outline_step ).to receive(:to_step) { outline_ast_step }
           expect( receiver ).to receive(:on_step).with(
             [feature, scenario_outline, examples_table_1, examples_table_1_row_1, outline_ast_step]
           ).ordered
@@ -238,8 +238,8 @@ module Cucumber::Core
 
     def compile(gherkin_documents)
       visitor = double
-      visitor.stub(:test_suite).and_yield
-      visitor.stub(:test_case).and_yield
+      allow( visitor ).to receive(:test_suite).and_yield(visitor)
+      allow( visitor ).to receive(:test_case).and_yield(visitor)
       yield visitor
       super(gherkin_documents, visitor)
     end

data/spec/cucumber/core/gherkin/parser_spec.rb

@@ -34,7 +34,7 @@ module Cucumber
 
         def feature
           result = nil
-          receiver.stub(:feature) { |feature| result = feature }
+          allow( receiver ).to receive(:feature) { |feature| result = feature }
           parse
           result
         end
@@ -45,7 +45,7 @@ module Cucumber
           end
 
           it "sets the language from the Gherkin" do
-            feature.language.iso_code.should == 'ja'
+            expect( feature.language.iso_code ).to eq 'ja'
           end
         end
 
@@ -61,9 +61,9 @@ module Cucumber
           end
 
           it "parses doc strings without error" do
-            visitor.stub(:feature).and_yield
-            visitor.stub(:scenario).and_yield
-            visitor.stub(:step).and_yield
+            allow( visitor ).to receive(:feature).and_yield(visitor)
+            allow( visitor ).to receive(:scenario).and_yield(visitor)
+            allow( visitor ).to receive(:step).and_yield(visitor)
 
             location = double
             expected = Ast::DocString.new("content", "", location)
@@ -89,12 +89,12 @@ module Cucumber
 
           it "parses the DataTable" do
             visitor = double
-            visitor.stub(:feature).and_yield
-            visitor.stub(:scenario).and_yield
-            visitor.stub(:step).and_yield
+            allow( visitor ).to receive(:feature).and_yield(visitor)
+            allow( visitor ).to receive(:scenario).and_yield(visitor)
+            allow( visitor ).to receive(:step).and_yield(visitor)
 
             expected = Ast::DataTable.new([['name', 'surname'], ['rob', 'westgeest']], Ast::Location.new('foo.feature', 23))
-            expect( visitor ).to receive(:table).with(expected)
+            expect( visitor ).to receive(:data_table).with(expected)
             feature.describe_to(visitor)
           end
         end
@@ -109,7 +109,7 @@ module Cucumber
 
           it "parses the comment into the AST" do
             visitor = double
-            visitor.stub(:feature).and_yield
+            allow( visitor ).to receive(:feature).and_yield(visitor)
             expect( visitor ).to receive(:scenario) do |scenario|
               expect( scenario.comments.join ).to eq "# wow"
             end
@@ -138,7 +138,7 @@ module Cucumber
           end
 
           it "creates a scenario outline node" do
-            visitor.stub(:feature).and_yield
+            allow( visitor ).to receive(:feature).and_yield(visitor)
             expect( visitor ).to receive(:scenario_outline) do |outline|
               expect( outline.name ).to eq 'outline name'
             end
@@ -146,9 +146,9 @@ module Cucumber
           end
 
           it "creates a step node for each step of the scenario outline" do
-            visitor.stub(:feature).and_yield
-            visitor.stub(:scenario_outline).and_yield
-            visitor.stub(:examples_table)
+            allow( visitor ).to receive(:feature).and_yield(visitor)
+            allow( visitor ).to receive(:scenario_outline).and_yield(visitor)
+            allow( visitor ).to receive(:examples_table)
             expect( visitor ).to receive(:outline_step) do |step|
               expect( step.name ).to eq 'passing <arg>'
             end
@@ -156,10 +156,10 @@ module Cucumber
           end
 
           it "creates an examples table node for each examples table" do
-            visitor.stub(:feature).and_yield
-            visitor.stub(:scenario_outline).and_yield
-            visitor.stub(:outline_step)
-            expect( visitor ).to receive(:examples_table).exactly(2).times.and_yield
+            allow( visitor ).to receive(:feature).and_yield(visitor)
+            allow( visitor ).to receive(:scenario_outline).and_yield(visitor)
+            allow( visitor ).to receive(:outline_step)
+            expect( visitor ).to receive(:examples_table).exactly(2).times.and_yield(visitor)
             expect( visitor ).to receive(:examples_table_row) do |row|
               expect( row.number ).to eq 1
               expect( row.values ).to eq ['1']
@@ -176,6 +176,19 @@ module Cucumber
           end
 
         end
+
+        context "a Scenario Outline with no Examples" do
+          source do
+            feature do
+              scenario_outline do
+                step 'passing <arg>'
+              end
+            end
+          end
+          it "throws an error" do
+            expect { feature.describe_to(double.as_null_object) }.to raise_error(ParseError)
+          end
+        end
       end
     end
   end

data/spec/cucumber/core/test/case_spec.rb

@@ -31,16 +31,16 @@ module Cucumber
             test_steps.each do |test_step|
               expect( test_step ).to receive(:describe_to).with(visitor, args)
             end
-            visitor.stub(:test_case).and_yield
+            allow( visitor ).to receive(:test_case).and_yield(visitor)
             test_case.describe_to(visitor, args)
           end
 
           it "describes around hooks in order" do
             visitor = double
-            visitor.stub(:test_case).and_yield
+            allow( visitor ).to receive(:test_case).and_yield(visitor)
             first_hook, second_hook = double, double
-            first_hook.should_receive(:describe_to).ordered.and_yield
-            second_hook.should_receive(:describe_to).ordered.and_yield
+            expect( first_hook ).to receive(:describe_to).ordered.and_yield
+            expect( second_hook ).to receive(:describe_to).ordered.and_yield
             around_hooks = [first_hook, second_hook]
             Test::Case.new([], [], around_hooks).describe_to(visitor, double)
           end
@@ -192,7 +192,7 @@ module Cucumber
             end
             receiver = double.as_null_object
             expect( receiver ).to receive(:test_case) do |test_case|
-              expect( test_case.match_tags?('@a') ).to be_true
+              expect( test_case.match_tags?('@a') ).to be_truthy
             end
             compile [gherkin], receiver
           end
@@ -209,7 +209,7 @@ module Cucumber
             end
             receiver = double.as_null_object
             expect( receiver ).to receive(:test_case) do |test_case|
-              expect( test_case.match_name?(/feature/) ).to be_true
+              expect( test_case.match_name?(/feature/) ).to be_truthy
             end
             compile [gherkin], receiver
           end
@@ -235,7 +235,7 @@ module Cucumber
           let(:test_cases) do
             receiver = double.as_null_object
             result = []
-            receiver.stub(:test_case) { |test_case| result << test_case }
+            allow( receiver ).to receive(:test_case) { |test_case| result << test_case }
             compile [source], receiver
             result
           end
@@ -278,44 +278,44 @@ module Cucumber
 
             it 'matches the precise location of the scenario' do
               location = Ast::Location.new(file, 8)
-              expect( test_case.match_locations?([location]) ).to be_true
+              expect( test_case.match_locations?([location]) ).to be_truthy
             end
 
             it 'matches the precise location of an empty scenario' do
               empty_scenario_test_case = test_cases.find { |c| c.name == 'Scenario: empty' }
               location = Ast::Location.new(file, 26)
-              expect( empty_scenario_test_case.match_locations?([location]) ).to be_true
+              expect( empty_scenario_test_case.match_locations?([location]) ).to be_truthy
             end
 
             it 'matches multiple locations' do
               good_location = Ast::Location.new(file, 8)
               bad_location = Ast::Location.new(file, 5)
-              expect( test_case.match_locations?([good_location, bad_location]) ).to be_true
+              expect( test_case.match_locations?([good_location, bad_location]) ).to be_truthy
             end
 
             it 'matches a location on the last step of the scenario' do
               location = Ast::Location.new(file, 10)
-              expect( test_case.match_locations?([location]) ).to be_true
+              expect( test_case.match_locations?([location]) ).to be_truthy
             end
 
             it "matches a location on the scenario's comment" do
               location = Ast::Location.new(file, 6)
-              expect( test_case.match_locations?([location]) ).to be_true
+              expect( test_case.match_locations?([location]) ).to be_truthy
             end
 
             it "matches a location on the scenario's tags" do
               location = Ast::Location.new(file, 7)
-              expect( test_case.match_locations?([location]) ).to be_true
+              expect( test_case.match_locations?([location]) ).to be_truthy
             end
 
             it "doesn't match a location after the last step of the scenario" do
               location = Ast::Location.new(file, 11)
-              expect( test_case.match_locations?([location]) ).to be_false
+              expect( test_case.match_locations?([location]) ).to be_falsey
             end
 
             it "doesn't match a location before the scenario" do
               location = Ast::Location.new(file, 5)
-              expect( test_case.match_locations?([location]) ).to be_false
+              expect( test_case.match_locations?([location]) ).to be_falsey
             end
 
             context "with a docstring" do
@@ -325,12 +325,12 @@ module Cucumber
 
               it "matches a location at the start the docstring" do
                 location = Ast::Location.new(file, 17)
-                expect( test_case.match_locations?([location]) ).to be_true
+                expect( test_case.match_locations?([location]) ).to be_truthy
               end
 
               it "matches a location in the middle of the docstring" do
                 location = Ast::Location.new(file, 18)
-                expect( test_case.match_locations?([location]) ).to be_true
+                expect( test_case.match_locations?([location]) ).to be_truthy
               end
             end
 
@@ -341,7 +341,7 @@ module Cucumber
 
               it "matches a location on the first table row" do
                 location = Ast::Location.new(file, 23)
-                expect( test_case.match_locations?([location]) ).to be_true
+                expect( test_case.match_locations?([location]) ).to be_truthy
               end
             end
           end
@@ -381,32 +381,32 @@ module Cucumber
 
             it 'matches the precise location of the scenario outline examples table row' do
               location = Ast::Location.new(file, 16)
-              expect( test_case.match_locations?([location]) ).to be_true
+              expect( test_case.match_locations?([location]) ).to be_truthy
             end
 
             it 'matches a location on a step of the scenario outline' do
               location = Ast::Location.new(file, 10)
-              expect( test_case.match_locations?([location]) ).to be_true
+              expect( test_case.match_locations?([location]) ).to be_truthy
             end
 
             it "matches a location on the scenario outline's comment" do
               location = Ast::Location.new(file, 6)
-              expect( test_case.match_locations?([location]) ).to be_true
+              expect( test_case.match_locations?([location]) ).to be_truthy
             end
 
             it "matches a location on the scenario outline's tags" do
               location = Ast::Location.new(file, 7)
-              expect( test_case.match_locations?([location]) ).to be_true
+              expect( test_case.match_locations?([location]) ).to be_truthy
             end
 
             it "doesn't match a location after the last row of the examples table" do
               location = Ast::Location.new(file, 17)
-              expect( test_case.match_locations?([location]) ).to be_false
+              expect( test_case.match_locations?([location]) ).to be_falsey
             end
 
             it "doesn't match a location before the scenario outline" do
               location = Ast::Location.new(file, 5)
-              expect( test_case.match_locations?([location]) ).to be_false
+              expect( test_case.match_locations?([location]) ).to be_falsey
             end
           end
         end