cucumber-core 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ea9227a0b067303f1aa77c9f4f05e75a73a74da6
-  data.tar.gz: 5ec7e76b3ec7fe9e093e5091a0e7e80156153aea
+  metadata.gz: 4c30d51fa9f12c4fb7b91a14006a9a308b652cf0
+  data.tar.gz: cb60c3d4d610070a1e8344388900dfb553a10de4
 SHA512:
-  metadata.gz: 9b8b2ce54523d97a6107b334342578af32f865281ceccb891f035cd55d0df119f267f510713e3e893ed6cb4a6be4af278648f22f3c77364ec0cc5d7e4ab15635
-  data.tar.gz: faae23fd3346d6957260ea77836ec6162e15d562017723d6328e5f386eecc3c4628fbe54513d579febcf97118303ece2d2ef9de505f5cab2752a897683c62b9a
+  metadata.gz: e34a846062bf14159235cbe27829195e940fc57b465f69b750835fc5b2ffdd41e930e287be8ea2742c300c0ed9ecc093dcb5eca173b1b5da60e1eebd96d21494
+  data.tar.gz: fd76c152cc8183f86482f41262ef858b4efb3df34b946a179c2de3e157a7bca52020fa5adff880c975fb775356f06203a5204ee410e6e58db68fa487f81984b8

data/README.md

@@ -1,9 +1,9 @@
-cucumber-ruby-core
+cucumber-core
 ==================
 
 [![Build Status](https://secure.travis-ci.org/cucumber/cucumber-ruby-core.png)](http://travis-ci.org/cucumber/cucumber-ruby-core)
-[![Code
-Climate](https://codeclimate.com/github/cucumber/cucumber-ruby-core.png)](https://codeclimate.com/github/cucumber/cucumber-ruby-core)
+[![Code Climate](https://codeclimate.com/github/cucumber/cucumber-ruby-core.png)](https://codeclimate.com/github/cucumber/cucumber-ruby-core)
 [![Coverage Status](https://coveralls.io/repos/cucumber/cucumber-ruby-core/badge.png?branch=master)](https://coveralls.io/r/cucumber/cucumber-ruby-core?branch=master)
+[![Dependency Status](https://gemnasium.com/cucumber/cucumber-ruby-core.png)](https://gemnasium.com/cucumber/cucumber-ruby-core)
 
-Core library for the Ruby flavour of Cucumber
+Core library for the Ruby flavour of Cucumber.

data/lib/cucumber/core/ast.rb

@@ -2,6 +2,7 @@ require 'cucumber/core/ast/comment'
 require 'cucumber/core/ast/tag'
 require 'cucumber/core/ast/feature'
 require 'cucumber/core/ast/empty_background'
+require 'cucumber/core/ast/empty_multiline_argument'
 require 'cucumber/core/ast/background'
 require 'cucumber/core/ast/scenario'
 require 'cucumber/core/ast/step'

data/lib/cucumber/core/ast/data_table.rb

@@ -51,10 +51,6 @@ module Cucumber
 
         attr_accessor :file
 
-        def self.default_arg_name #:nodoc:
-          "table"
-        end
-
         def self.parse(text, uri, location)
           builder = Builder.new
           lexer = ::Gherkin::Lexer::I18nLexer.new(builder)
@@ -257,7 +253,7 @@ module Cucumber
         end
 
         def description_for_visitors
-          :table
+          :data_table
         end
 
         # Represents a row of cells or columns of cells

data/lib/cucumber/core/ast/doc_string.rb

@@ -23,10 +23,6 @@ module Cucumber
         include DescribesItself
         attr_accessor :file
 
-        def self.default_arg_name
-          "string"
-        end
-
         attr_reader :content_type, :content
 
         def initialize(string, content_type, location)

data/lib/cucumber/core/ast/empty_multiline_argument.rb

@@ -0,0 +1,24 @@
+module Cucumber
+  module Core
+    module Ast
+      class EmptyMultilineArgument
+        def describe_to(*)
+          self
+        end
+
+        def map(&block)
+          self
+        end
+
+        def match_locations?(*args)
+          false
+        end
+
+        def to_sexp
+          []
+        end
+      end
+    end
+  end
+end
+

data/lib/cucumber/core/ast/location.rb

@@ -118,8 +118,7 @@ module Cucumber
         end
 
         def attributes
-          # TODO: Remove compact when we have a null multiline arg object
-          [tags, comments, multiline_arg].flatten.compact
+          [tags, comments, multiline_arg].flatten
         end
 
         def tags
@@ -128,10 +127,13 @@ module Cucumber
         end
 
         def comments
+          # will be overriden by nodes that actually have comments
           []
         end
 
         def multiline_arg
+          # will be overriden by nodes that actually have a multiline_argument
+          EmptyMultilineArgument.new
         end
 
       end

data/lib/cucumber/core/ast/multiline_argument.rb

@@ -8,8 +8,9 @@ module Cucumber
         class << self
           include Gherkin::Rubify
 
+          # TODO: move this up to the front-end
           def from(argument, parent_location)
-            return unless argument
+            return EmptyMultilineArgument.new unless argument
             return argument if argument.respond_to?(:to_step_definition_arg)
 
             argument = rubify(argument)

data/lib/cucumber/core/ast/outline_step.rb

@@ -12,7 +12,7 @@ module Cucumber
 
         attr_reader :language, :location, :keyword, :name, :multiline_arg
 
-        def initialize(language, location, keyword, name, multiline_arg=nil)
+        def initialize(language, location, keyword, name, multiline_arg)
           @language, @location, @keyword, @name, @multiline_arg = language, location, keyword, name, multiline_arg
           @language || raise("Language is required!")
         end
@@ -32,10 +32,8 @@ module Cucumber
         end
 
         def children
-          # TODO use a null object
           # TODO remove duplication with Step
           # TODO spec
-          return [] unless @multiline_arg
           [@multiline_arg]
         end
 

data/lib/cucumber/core/ast/step.rb

@@ -10,7 +10,7 @@ module Cucumber
 
         attr_reader :keyword, :name, :language, :exception, :multiline_arg
 
-        def initialize(language, location, keyword, name, multiline_arg=nil)
+        def initialize(language, location, keyword, name, multiline_arg)
           @location, @keyword, @name, @multiline_arg = location, keyword, name, multiline_arg
         end
 
@@ -19,13 +19,12 @@ module Cucumber
         end
 
         def to_sexp
-          [:step, line, keyword, name, (@multiline_arg.nil? ? nil : @multiline_arg.to_sexp)].compact
+          [:step, line, keyword, name, @multiline_arg.to_sexp]
         end
 
         private
 
         def children
-          return [] unless @multiline_arg # TODO: use a null object
           [@multiline_arg]
         end
 

data/lib/cucumber/core/version.rb

@@ -2,7 +2,7 @@ module Cucumber
   module Core
     class Version
       def self.to_s
-        "0.1.0"
+        "0.2.0"
       end
     end
   end

data/spec/cucumber/core/ast/outline_step_spec.rb

@@ -7,11 +7,12 @@ module Cucumber
   module Core
     module Ast
       describe OutlineStep do
-        let(:outline_step) { OutlineStep.new(language, location, keyword, name) }
+        let(:outline_step) { OutlineStep.new(language, location, keyword, name, multiline_arg) }
         let(:language) { double }
         let(:location) { double }
         let(:keyword)  { double }
         let(:name)     { 'anything' }
+        let(:multiline_arg) { EmptyMultilineArgument.new }
 
         describe 'location' do
           it "has a location" do

data/spec/cucumber/core/ast/step_spec.rb

@@ -5,8 +5,9 @@ module Cucumber
     module Ast
       describe Step do
         let(:step) do
-          language, location, keyword, name = double, double, double, double
-          Step.new(language, location, keyword, name)
+          language, location, keyword, name = *double
+          multiline_arg = EmptyMultilineArgument.new
+          Step.new(language, location, keyword, name, multiline_arg)
         end
 
         describe "describing itself" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-core
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Aslak Hellesøy
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-12 00:00:00.000000000 Z
+date: 2014-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin
@@ -121,6 +121,7 @@ files:
 - lib/cucumber/core/ast/describes_itself.rb
 - lib/cucumber/core/ast/doc_string.rb
 - lib/cucumber/core/ast/empty_background.rb
+- lib/cucumber/core/ast/empty_multiline_argument.rb
 - lib/cucumber/core/ast/examples_table.rb
 - lib/cucumber/core/ast/feature.rb
 - lib/cucumber/core/ast/location.rb
@@ -192,10 +193,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
-summary: cucumber-core-0.1.0
+summary: cucumber-core-0.2.0
 test_files:
 - spec/capture_warnings.rb
 - spec/coverage.rb
@@ -218,4 +219,3 @@ test_files:
 - spec/cucumber/core/test/timer_spec.rb
 - spec/cucumber/core_spec.rb
 - spec/cucumber/initializer_spec.rb
-has_rdoc: