cucumber-compatibility-kit 9.1.0 → 9.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 59a65e57ebb944b7dc5f4c81b77980bb191a373784e2e4a52c99b9447cb14857
-  data.tar.gz: 6b9089229c92764ec244e118ec84230239c870764d5735b377319a65252edccc
+  metadata.gz: afa658b4a280cda50327bf09b20bee6d72b6199c1009164e3a355dc2f853753b
+  data.tar.gz: bb15dfd4c0b129db899feab720eefd10d942e17367fdcfda95c7b67233ed4e34
 SHA512:
-  metadata.gz: d641adbb794625b6be19984759b271ad958c7d0ceac00e0f59750aea28f643ddfff528d05c2e962e59d20cfeac8b022ac5b4d01463883baea9b6066a05eb9e61
-  data.tar.gz: 82c50b779fea698732f8f1cf2748a91191e150e1615577f9d5110c38d6e4de4ec36d3057a856a9a2b95cbbe2d9151d827b778983d521e1796416d3d10f9006bd
+  metadata.gz: 78f2b8199eaa1e82c44f896043edcda109ebc3c348bac08ae4cf833e0068bfdc8e4ef860d171062fb96d05c71523c16bcad35cfb064dcb45a4c64ab141c4add6
+  data.tar.gz: 170a260c3abd88bd526f95adb3c9ee484842ae688297c2d88054aecf0887032d07f336b28c420e9c4a845d75604857ea1233a32a8ee4da26833f3632b15c96b6

data/lib/keys_checker.rb

@@ -14,11 +14,15 @@ module CCK
 
       missing_keys = (expected_keys - found_keys)
 
-      extra_keys = (found_keys - expected_keys)
+      extra_keys = (found_keys - expected_keys).reject { |key|
+        ENV['CI'] && found.class == Cucumber::Messages::Meta && key == :ci
+      }
 
       errors << "Found extra keys in message #{found.class.name}: #{extra_keys}" unless extra_keys.empty?
       errors << "Missing keys in message #{found.class.name}: #{missing_keys}" unless missing_keys.empty?
       errors
+    rescue StandardError => e
+      ["Unexpected error: #{e.message}"]
     end
   end
 end

data/lib/messages_comparator.rb

@@ -62,6 +62,7 @@ module CCK
       return if found.is_a?(Cucumber::Messages::Pickle)
       return if found.is_a?(Cucumber::Messages::Timestamp) && expected.is_a?(Cucumber::Messages::Timestamp)
       return if found.is_a?(Cucumber::Messages::Duration) && expected.is_a?(Cucumber::Messages::Duration)
+      return if ENV['CI'] && found.is_a?(Cucumber::Messages::Ci) && expected.nil?
 
       @compared << found.class.name
       @all_errors << @validator.compare(found, expected)

data/spec/keys_checker_spec.rb

@@ -73,5 +73,34 @@ describe CCK::KeysChecker do
         expect(subject.compare(default_set, default_not_set)).to be_empty
       end
     end
+
+    context 'when executed as part of a CI' do
+      before do
+        allow(ENV).to receive(:[]).with('CI').and_return(true)
+      end
+
+      it 'ignores actual CI related messages' do
+        found = Cucumber::Messages::Meta.new(
+          ci: Cucumber::Messages::Ci.new(name: 'Some CI')
+        )
+
+        expected = Cucumber::Messages::Meta.new
+
+        expect(subject.compare(found, expected)).to be_empty
+      end
+    end
+
+    context 'when an unexcpected error occurs' do
+      it 'does not raise error' do
+        expect {
+          subject.compare(nil, nil)
+        }.not_to raise_error
+      end
+
+      it 'returns the error' do
+        expect(subject.compare(nil, nil))
+          .to eq(['Unexpected error: wrong number of arguments (given 1, expected 0)'])
+      end
+    end
   end
 end

data/spec/messages_comparator_spec.rb

@@ -0,0 +1,26 @@
+require 'rspec'
+require 'cucumber/messages'
+require_relative '../lib/messages_comparator'
+
+describe CCK::MessagesComparator do
+  subject() { CCK::MessagesComparator }
+
+  context 'when executed as part of a CI' do
+    before do
+      allow(ENV).to receive(:[]).with('CI').and_return(true)
+    end
+
+    it 'ignores actual CI related messages' do
+      found_message_ci = Cucumber::Messages::Ci.new(name: 'Some CI')
+      found_message_meta = Cucumber::Messages::Meta.new(ci: found_message_ci)
+      found_message_envelope = Cucumber::Messages::Envelope.new(meta: found_message_meta)
+
+      expected_message_meta = Cucumber::Messages::Meta.new()
+      expected_message_envelope = Cucumber::Messages::Envelope.new(meta: expected_message_meta)
+
+      comparator = subject.new(CCK::KeysChecker, [found_message_envelope], [expected_message_envelope])
+
+      expect(comparator.errors).to be_empty
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-compatibility-kit
 version: !ruby/object:Gem::Version
-  version: 9.1.0
+  version: 9.1.1
 platform: ruby
 authors:
 - Aurélien Reeves
@@ -130,6 +130,7 @@ files:
 - spec/capture_warnings.rb
 - spec/cucumber-compatibility-kit_spec.rb
 - spec/keys_checker_spec.rb
+- spec/messages_comparator_spec.rb
 homepage: https://github.com/cucumber/common
 licenses:
 - MIT
@@ -158,8 +159,9 @@ requirements: []
 rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
-summary: cucumber-compatibility-kit-9.1.0
+summary: cucumber-compatibility-kit-9.1.1
 test_files:
 - spec/capture_warnings.rb
+- spec/messages_comparator_spec.rb
 - spec/cucumber-compatibility-kit_spec.rb
 - spec/keys_checker_spec.rb