cucloud 0.4.0 → 0.5.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZDViMDhjYmM3ZGFmYjc1ZmU4OWZmNzM5YzJkNDZhNjkzMzVmZmMzNQ==
+    Y2I4NDQwZTdiOTNjZDdlNmJlYmE3NTM4YTIxNWIyN2QwYTU1YzFmMA==
   data.tar.gz: !binary |-
-    MmQ0YmQ5OWI3N2RhMGZiOTkwY2IyYzY3ZmJkYzJkM2E3NzhiYTMyNw==
+    NGI4NWI2ZWE0NGVkODUyZWU3ZWQ1NWZjNWE0NTJjYmQ4MWU1MDNmNw==
 SHA512:
   metadata.gz: !binary |-
-    MWU4NWQzZDM3ZmQxYzAzNWNmYzcwNzA3MjAwZDQ1ZTJhZjcyYWFhYTYxNDNl
-    YTZjMjBjZDQxYzRiOTczOWU3Y2E4MGUwMWQzOGFmNjhlNjRkNWZjNjE2MTM5
-    ZmY0NGQxZDIzMTg4MWYwZTRlMjAxMGUwMzViNjQxNjhmZGY0MmU=
+    N2U5YTQ1ZGRlZjkzY2M3MGZlYzliMDYwN2YxMDI2MWFlOWQwZmMwN2UyM2Y5
+    Yzg3ZTQ1ZjkxYTMwMGZhZjNmYTA0MmNkMmQ3MmQwODJlZTk2MDBiYmIyMTYx
+    NTFjMWNlYmY1MDcwM2RmYjRlYzdhZTcwMTg1NGZjZGM1ZjViODI=
   data.tar.gz: !binary |-
-    Y2Q5ZjQ4ZmU5NTZlMzYyNDc5NjM2NWQzNmI5ZDg1MDRjN2RjMTI2ZGM5ZWY4
-    MmJkYzU5YzM2ODExZDIwM2RmNzA1YmUwYmY4ZjU1MDRiMDFiZmY4Zjk5YjYz
-    MGU0NmQ1NWQxZDIwYWYzMzc3NTUyZDdkOGZhMjEyMjlkN2RmMjQ=
+    OTY1YjdhN2ExZDgwNjllYjVmMGI2YTllN2Q0NDUzYjNiOTVlYjgyZTM1Y2Rh
+    OGRmMGM0ZmFjMzMyMjI0NGQxM2I2OGY5YmU0ODU3ZmI3NjQwYzdmNmZlMTFm
+    YjdmMGY0NmRjMjg5M2NmNzk4NzcxZjFmM2RhZTcwNWQwNWEwNjk=

data/lib/cucloud/asg_utils.rb

@@ -15,10 +15,7 @@ module Cucloud
     # @return [Aws::AutoScaling::Types::AutoScalingGroup] AWS SDK autoscale group struct
     def get_asg_by_name(name)
       # https://docs.aws.amazon.com/sdkforruby/api/Aws/AutoScaling/Client.html#describe_auto_scaling_groups-instance_method
-      asg_desc = @asg.describe_auto_scaling_groups(auto_scaling_group_names: [name])
-
-      # nil if not found -> we're accepting one name, so return first result
-      asg_desc.auto_scaling_groups[0]
+      @asg.describe_auto_scaling_groups(auto_scaling_group_names: [name]).auto_scaling_groups.first
     end
 
     # get an instance of the launch configuration for a given autoscaling group
@@ -26,8 +23,7 @@ module Cucloud
     # @return [Aws::AutoScaling::Types::LaunchConfiguration] AWS SDK Launch Configuration struct
     def get_launch_configuration_by_name(launch_config_name)
       # https://docs.aws.amazon.com/sdkforruby/api/Aws/AutoScaling/Client.html#describe_launch_configurations-instance_method
-      lc_desc = @asg.describe_launch_configurations(launch_configuration_names: [launch_config_name])
-      lc_desc.launch_configurations[0]
+      @asg.describe_launch_configurations(launch_configuration_names: [launch_config_name]).launch_configurations.first
     end
 
     # Generate a hash that can be submitted when creating a new launch config - replace image with desired AMI

data/lib/cucloud/config_service_utils.rb

@@ -68,6 +68,13 @@ module Cucloud
       ).evaluation_results.first
     end
 
+    # Are all recorders active and logging data in this region
+    # @return [Boolean]
+    def recorder_active?
+      @cs.describe_configuration_recorder_status({})
+         .configuration_recorders_status.find { |x| !x.recording || x.last_status != 'SUCCESS' }.nil?
+    end
+
     # Is this rule active?
     # @param [Aws::ConfigService::Types::ConfigRule] Rule
     # @return [Boolean]

data/lib/cucloud/iam_utils.rb

@@ -62,21 +62,20 @@ module Cucloud
     def audit_password_policy(audit_criteria = [])
       policy_hash = get_account_password_policy.to_h
 
-      audit_array = []
-      audit_criteria.each do |check|
+      audit_criteria.map do |check|
         case check[:operator]
         when 'EQ'
-          audit_array << {
+          {
             key: check[:key],
             passes: policy_hash[check[:key].to_sym].nil? ? false : policy_hash[check[:key].to_sym] == check[:value]
           }
         when 'LTE'
-          audit_array << {
+          {
             key: check[:key],
             passes: policy_hash[check[:key].to_sym].nil? ? false : policy_hash[check[:key].to_sym] <= check[:value]
           }
         when 'GTE'
-          audit_array << {
+          {
             key: check[:key],
             passes: policy_hash[check[:key].to_sym].nil? ? false : policy_hash[check[:key].to_sym] >= check[:value]
           }
@@ -84,8 +83,6 @@ module Cucloud
           raise UnknownComparisonOperatorError.new, "Unknown operator #{check[:operator]}"
         end
       end
-
-      audit_array
     end
 
     # Get SAML providers configured for this account
@@ -95,15 +92,12 @@ module Cucloud
       # returns https://docs.aws.amazon.com/sdkforruby/api/Aws/IAM/Types/SAMLProviderListEntry.html
       # https://docs.aws.amazon.com/sdkforruby/api/Aws/IAM/Client.html#get_saml_provider-instance_method
 
-      provider_array = []
-      @iam.list_saml_providers.saml_provider_list.each do |provider|
-        provider_array << {
+      @iam.list_saml_providers.saml_provider_list.map do |provider|
+        {
           arn: provider.arn,
           saml_metadata_document: @iam.get_saml_provider(saml_provider_arn: provider.arn).saml_metadata_document
         }
       end
-
-      provider_array
     end
 
     # Is the Cornell SAML Identity Provider configured on this account?
@@ -116,14 +110,12 @@ module Cucloud
     # @return [Array<Hash>] Array of user hashes - base user type + added lookups for convenience
     def get_users
       # https://docs.aws.amazon.com/sdkforruby/api/Aws/IAM/Client.html#list_users-instance_method
-      user_array = []
-      @iam.list_users.users.each do |user|
-        user_array << {
+      @iam.list_users.users.map do |user|
+        {
           base_data: user, # https://docs.aws.amazon.com/sdkforruby/api/Aws/IAM/Types/User.html
           has_password: user_has_password?(user.user_name)
         }
       end
-      user_array
     end
 
     # Does this user have a password configured?
@@ -147,28 +139,23 @@ module Cucloud
     # @return [Array<Hash>] Array of key hashes - base key data + helper calculations for key age and active/inactive
     def get_user_access_keys(user_name)
       # https://docs.aws.amazon.com/sdkforruby/api/Aws/IAM/Client.html#list_access_keys-instance_method
-      keys = []
-      @iam.list_access_keys(user_name: user_name).access_key_metadata.each do |key|
-        keys << {
+
+      @iam.list_access_keys(user_name: user_name).access_key_metadata.map do |key|
+        {
           base_data: key,
           active: key.status == 'Active',
           days_old: (Time.now - key.create_date).to_i / (24 * 60 * 60)
         }
       end
-
-      keys
     end
 
     # Get active access keys on account that are older than specified age (in days)
     # @param [Integer] Days old
     # @return [Array<Hash>]
     def get_active_keys_older_than_n_days(n)
-      keys = []
-      get_users.each do |user|
-        keys << get_user_access_keys(user[:base_data].user_name).select { |k| k[:days_old] > n && k[:active] }
-      end
-
-      keys.flatten
+      get_users.map do |user|
+        get_user_access_keys(user[:base_data].user_name).select { |k| k[:days_old] > n && k[:active] }
+      end.flatten
     end
   end
 end

data/lib/cucloud/version.rb

@@ -1,5 +1,5 @@
 module Cucloud
   # Disable mutable constant warning - freezing this oddly breaks bundler
   # rubocop:disable Style/MutableConstant
-  VERSION = '0.4.0'
+  VERSION = '0.5.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cucloud
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - sbower
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-07-28 00:00:00.000000000 Z
+date: 2016-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk