cube-evaluator 0.0.1.alpha → 0.0.1.beta

data/README.md

@@ -7,12 +7,12 @@ Obtain data from cube evaluators in a nice format
 Add this to your Gemfile
 
 ```ruby
-gem cube-evaluator
+gem 'cube-evaluator'
 ```
 
 and then run
 
-`bundle`
+    $ bundle
 
 ## Usage
 
@@ -29,7 +29,13 @@ $cube_evaluator = Cube::Evaluator.new 'cube.example.com', 2280
 Ask for some metrics
 
 ```ruby
-$cube_evaluator.metric(:expression => 'sum(request)', :start => Time.now - 2592000, :stop => Time.now, :limit => 10, :step => '1minute')
+$cube_evaluator.metric(
+  :expression => 'sum(request)',
+  :start => Time.now - 2592000,
+  :stop => Time.now,
+  :limit => 10,
+  :step => '1minute'
+)
 ```
 
 The result will be a json encoded Hash with an array of 'times' and the corresponding 'values'
@@ -48,5 +54,4 @@ https://github.com/square/cube/wiki/Evaluator
 
 # TODO
 
-* Add support for evaluator events and types
-* Add tests
+* Add support for evaluator events and types

data/cube-evaluator.gemspec

@@ -16,4 +16,5 @@ Gem::Specification.new do |gem|
   gem.version       = Cube::Evaluator::VERSION
 
   gem.add_development_dependency 'rspec'
+  gem.add_development_dependency 'webmock'
 end

data/lib/cube-evaluator/version.rb

@@ -1,5 +1,5 @@
 module Cube
-  module Evaluator
-    VERSION = "0.0.1.alpha"
+  class Evaluator
+    VERSION = "0.0.1.beta"
   end
 end

data/lib/cube-evaluator.rb

@@ -1,16 +1,21 @@
 require "cube-evaluator/version"
+require 'json'
 
 module Cube
   class Evaluator
-    def initialize(url = 'localhost', port = 1081)
-      @url = "http://#{url}:#{port}/1.0/metric/get"
+    def initialize(host = 'localhost', port = 1081)
+      @url = "http://#{host}:#{port}/"
+    end
+
+    def url
+      @url || ""
     end
 
     def metric(options = {})
-      uri = URI(@url)
+      uri = URI(@url) + "1.0/metric/get"
 
       params = options.merge(options) do |k,v|
-        if v.is_a?(DateTime) || v.is_a?(Date) || v.is_a?(Time)
+        if [DateTime, Date, Time].any?{ |klass| v.is_a?(klass) }
           v.to_time.utc.iso8601
         elsif k == :step
           to_step(v)
@@ -42,6 +47,8 @@ module Cube
       result
     end
 
+    private
+
     def to_step(step)
       case step
       when '10seconds'

data/spec/cube-evaluator_spec.rb

@@ -1,5 +1,66 @@
 require 'spec_helper'
 
 describe Cube::Evaluator do
-  
+  before(:all) do
+    @cube = Cube::Evaluator.new
+  end
+
+  describe "#initialize" do
+    it "should set the url" do
+      @cube = Cube::Evaluator.new "cube.example.org", 1185
+      @cube.url.should == "http://cube.example.org:1185/"
+    end
+
+    it "should default the host and port to localhost:1081" do
+      @cube.url.should == "http://localhost:1081/"
+    end
+  end
+
+  describe "#metric" do
+    before(:all) do
+      @fake_response = [
+        {"time" => "2012-07-16T11:40:00.000Z", "value" => 1},
+        {"time" => "2012-07-16T11:41:00.000Z", "value" => 2},
+        {"time" => "2012-07-16T11:42:00.000Z", "value" => 3},
+        {"time" => "2012-07-16T11:43:00.000Z", "value" => 4},
+        {"time" => "2012-07-16T11:44:00.000Z", "value" => 5},
+        {"time" => "2012-07-16T11:45:00.000Z", "value" => 6},
+        {"time" => "2012-07-16T11:46:00.000Z", "value" => 7}
+      ]
+
+      stub_request(:get, "http://localhost:1081/1.0/metric/get?expression=sum(cube_requests)&limit=10&start=2012-04-16T16:00:00Z&step=6e4&stop=2012-04-16T17:00:00Z").
+        with(:headers => {'Accept'=>'*/*', 'User-Agent'=>'Ruby'}).
+        to_return(:status => 200, :body => @fake_response.to_json, :headers => {})
+    end
+
+    it "should return the response with the times and values hash" do
+      @metric = {
+        :times => [],
+        :values => []
+      }
+
+      @fake_response.each do |metric|
+        @metric[:times] << Time.parse(metric['time'])
+        @metric[:values] << metric['value']
+      end
+
+      @cube.metric(
+        :expression => 'sum(cube_requests)',
+        :start => Time.parse('2012-04-16T16:00Z'),
+        :stop => Time.parse('2012-04-16T17:00Z'),
+        :step => '1minute',
+        :limit => '10'
+      ).should == @metric
+    end
+  end
+
+  describe "#to_step" do
+    it "should return the supported step" do
+      @cube.send(:to_step, "10seconds").should == '1e4'
+      @cube.send(:to_step, "1minute").should == '6e4'
+      @cube.send(:to_step, "5minutes").should == '3e5'
+      @cube.send(:to_step, "1hour").should == '36e5'
+      @cube.send(:to_step, "1day").should == '864e5'
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1 +1,5 @@
-require 'cube-evaluator'
+require 'cube-evaluator'
+require 'webmock/rspec'
+
+RSpec.configure do |config|
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cube-evaluator
 version: !ruby/object:Gem::Version
-  version: 0.0.1.alpha
+  version: 0.0.1.beta
   prerelease: 6
 platform: ruby
 authors:
@@ -27,6 +27,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Square Cube evaluator gem
 email:
 - matteodepalo@gmail.com