csvops 0.1.0.alpha → 0.2.0.alpha

data/test/csvtool/domain/row_session/row_output_destination_test.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require_relative "../../../test_helper"
+require "csvtool/domain/row_session/row_output_destination"
+
+class RowRangeOutputDestinationTest < Minitest::Test
+  def test_console_destination
+    destination = Csvtool::Domain::RowSession::RowOutputDestination.console
+    refute destination.file?
+  end
+
+  def test_file_destination
+    destination = Csvtool::Domain::RowSession::RowOutputDestination.file(path: "/tmp/out.csv")
+    assert destination.file?
+    assert_equal "/tmp/out.csv", destination.path
+  end
+
+  def test_rejects_empty_file_path
+    assert_raises(ArgumentError) do
+      Csvtool::Domain::RowSession::RowOutputDestination.file(path: "")
+    end
+  end
+end

data/test/csvtool/domain/row_session/row_range_test.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require_relative "../../../test_helper"
+require "csvtool/domain/row_session/row_range"
+
+class RowRangeTest < Minitest::Test
+  def test_builds_from_valid_inputs
+    row_range = Csvtool::Domain::RowSession::RowRange.from_inputs(start_row_input: "2", end_row_input: "4")
+    assert_equal 2, row_range.start_row
+    assert_equal 4, row_range.end_row
+  end
+
+  def test_rejects_invalid_start_row
+    assert_raises(Csvtool::Domain::RowSession::InvalidStartRowError) do
+      Csvtool::Domain::RowSession::RowRange.from_inputs(start_row_input: "0", end_row_input: "2")
+    end
+  end
+
+  def test_rejects_invalid_end_row
+    assert_raises(Csvtool::Domain::RowSession::InvalidEndRowError) do
+      Csvtool::Domain::RowSession::RowRange.from_inputs(start_row_input: "1", end_row_input: "abc")
+    end
+  end
+
+  def test_rejects_end_before_start
+    assert_raises(Csvtool::Domain::RowSession::InvalidRowRangeOrderError) do
+      Csvtool::Domain::RowSession::RowRange.from_inputs(start_row_input: "3", end_row_input: "2")
+    end
+  end
+end

data/test/csvtool/domain/row_session/row_session_test.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require_relative "../../../test_helper"
+require "csvtool/domain/row_session/row_session"
+require "csvtool/domain/row_session/row_source"
+require "csvtool/domain/row_session/row_range"
+require "csvtool/domain/row_session/row_output_destination"
+
+class RowSessionTest < Minitest::Test
+  def test_starts_and_sets_output_destination
+    source = Csvtool::Domain::RowSession::RowSource.new(path: "/tmp/a.csv", separator: ",")
+    row_range = Csvtool::Domain::RowSession::RowRange.new(start_row: 1, end_row: 2)
+
+    session = Csvtool::Domain::RowSession::RowSession.start(source: source, row_range: row_range)
+    destination = Csvtool::Domain::RowSession::RowOutputDestination.console
+    updated = session.with_output_destination(destination)
+
+    assert_equal source, updated.source
+    assert_equal row_range, updated.row_range
+    assert_equal destination, updated.output_destination
+  end
+end

data/test/csvtool/domain/row_session/row_source_test.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+require_relative "../../../test_helper"
+require "csvtool/domain/row_session/row_source"
+
+class RowSourceTest < Minitest::Test
+  def test_holds_path_and_separator
+    source = Csvtool::Domain::RowSession::RowSource.new(path: "/tmp/a.csv", separator: "\t")
+    assert_equal "/tmp/a.csv", source.path
+    assert_equal "\t", source.separator
+  end
+end

data/test/csvtool/infrastructure/csv/row_streamer_test.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require_relative "../../../test_helper"
+require "csvtool/infrastructure/csv/row_streamer"
+
+class InfrastructureRowStreamerTest < Minitest::Test
+  def fixture_path(name)
+    File.expand_path("../../../fixtures/#{name}", __dir__)
+  end
+
+  def test_streams_only_requested_row_range
+    streamer = Csvtool::Infrastructure::CSV::RowStreamer.new
+    rows = []
+
+    stats = streamer.each_in_range(
+      file_path: fixture_path("sample_people.csv"),
+      col_sep: ",",
+      start_row: 2,
+      end_row: 3
+    ) { |fields| rows << fields }
+
+    assert_equal [["Bob", "Paris"], ["Cara", "Berlin"]], rows
+    assert_equal true, stats[:matched]
+    assert_equal 3, stats[:row_count]
+  end
+
+  def test_stops_before_malformed_tail_when_end_row_reached
+    streamer = Csvtool::Infrastructure::CSV::RowStreamer.new
+    rows = []
+
+    stats = streamer.each_in_range(
+      file_path: fixture_path("sample_people_bad_tail.csv"),
+      col_sep: ",",
+      start_row: 1,
+      end_row: 2
+    ) { |fields| rows << fields }
+
+    assert_equal [["Alice", "London"], ["Bob", "Paris"]], rows
+    assert_equal true, stats[:matched]
+  end
+end

data/test/csvtool/infrastructure/output/csv_row_console_writer_test.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+require_relative "../../../test_helper"
+require "csvtool/infrastructure/output/csv_row_console_writer"
+
+class InfrastructureCsvRowConsoleWriterTest < Minitest::Test
+  class FakeRowStreamer
+    def each_in_range(file_path:, col_sep:, start_row:, end_row:)
+      yield ["Bob", "Paris"]
+      yield ["Cara", "Berlin"]
+      { matched: true, row_count: 3 }
+    end
+  end
+
+  def test_writes_header_and_rows_to_stdout
+    out = StringIO.new
+    writer = Csvtool::Infrastructure::Output::CsvRowConsoleWriter.new(stdout: out, row_streamer: FakeRowStreamer.new)
+
+    stats = writer.call(file_path: "x.csv", col_sep: ",", headers: ["name", "city"], start_row: 2, end_row: 3)
+
+    assert_equal "name,city\nBob,Paris\nCara,Berlin\n", out.string
+    assert_equal true, stats[:matched]
+  end
+end

data/test/csvtool/infrastructure/output/csv_row_file_writer_test.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+require_relative "../../../test_helper"
+require "csvtool/infrastructure/output/csv_row_file_writer"
+require "csvtool/interface/cli/errors/presenter"
+require "tmpdir"
+
+class InfrastructureCsvRowFileWriterTest < Minitest::Test
+  class FakeRowStreamer
+    def each_in_range(file_path:, col_sep:, start_row:, end_row:)
+      yield ["Bob", "Paris"]
+      yield ["Cara", "Berlin"]
+      { matched: true, row_count: 3 }
+    end
+  end
+
+  def test_writes_header_and_rows_to_file
+    stdout = StringIO.new
+    writer = Csvtool::Infrastructure::Output::CsvRowFileWriter.new(
+      stdout: stdout,
+      errors: Csvtool::Interface::CLI::Errors::Presenter.new(stdout: stdout),
+      row_streamer: FakeRowStreamer.new
+    )
+
+    Dir.mktmpdir do |dir|
+      output_path = File.join(dir, "rows.csv")
+      stats = writer.call(
+        file_path: "x.csv",
+        col_sep: ",",
+        headers: ["name", "city"],
+        start_row: 2,
+        end_row: 3,
+        output_path: output_path
+      )
+
+      assert_equal "name,city\nBob,Paris\nCara,Berlin\n", File.read(output_path)
+      assert_equal true, stats[:matched]
+    end
+  end
+end

data/test/csvtool/interface/cli/errors/presenter_test.rb

@@ -19,6 +19,10 @@ class ErrorsPresenterTest < Minitest::Test
     presenter.empty_custom_separator
     presenter.invalid_separator_choice
     presenter.canceled
+    presenter.invalid_start_row
+    presenter.invalid_end_row
+    presenter.invalid_row_range_order
+    presenter.row_range_out_of_bounds(3)
 
     text = out.string
     assert_includes text, "File not found: /tmp/x.csv"
@@ -32,5 +36,9 @@ class ErrorsPresenterTest < Minitest::Test
     assert_includes text, "Separator cannot be empty."
     assert_includes text, "Invalid separator choice."
     assert_includes text, "Canceled."
+    assert_includes text, "Start row must be a positive integer."
+    assert_includes text, "End row must be a positive integer."
+    assert_includes text, "End row must be greater than or equal to start row."
+    assert_includes text, "Row range is out of bounds. File has 3 data rows."
   end
 end

data/test/csvtool/interface/cli/menu_loop_test.rb

@@ -16,36 +16,61 @@ class MenuLoopTest < Minitest::Test
     end
   end
 
-  def test_routes_extract_then_exit
-    action = FakeAction.new
+  def test_routes_extract_column_then_exit
+    column_action = FakeAction.new
+    rows_action = FakeAction.new
     stdout = StringIO.new
     menu = Csvtool::Interface::CLI::MenuLoop.new(
-      stdin: StringIO.new("1\n2\n"),
+      stdin: StringIO.new("1\n3\n"),
       stdout: stdout,
-      menu_options: ["Extract column", "Exit"],
-      extract_action: action
+      menu_options: ["Extract column", "Extract rows (range)", "Exit"],
+      extract_column_action: column_action,
+      extract_rows_action: rows_action
     )
 
     status = menu.run
 
     assert_equal 0, status
-    assert_equal 1, action.runs
+    assert_equal 1, column_action.runs
+    assert_equal 0, rows_action.runs
     assert_includes stdout.string, "CSV Tool Menu"
   end
 
+  def test_routes_extract_rows_then_exit
+    column_action = FakeAction.new
+    rows_action = FakeAction.new
+    stdout = StringIO.new
+    menu = Csvtool::Interface::CLI::MenuLoop.new(
+      stdin: StringIO.new("2\n3\n"),
+      stdout: stdout,
+      menu_options: ["Extract column", "Extract rows (range)", "Exit"],
+      extract_column_action: column_action,
+      extract_rows_action: rows_action
+    )
+
+    status = menu.run
+
+    assert_equal 0, status
+    assert_equal 0, column_action.runs
+    assert_equal 1, rows_action.runs
+  end
+
   def test_invalid_choice_shows_prompt
-    action = FakeAction.new
+    column_action = FakeAction.new
+    rows_action = FakeAction.new
     stdout = StringIO.new
     menu = Csvtool::Interface::CLI::MenuLoop.new(
-      stdin: StringIO.new("x\n2\n"),
+      stdin: StringIO.new("x\n3\n"),
       stdout: stdout,
-      menu_options: ["Extract column", "Exit"],
-      extract_action: action
+      menu_options: ["Extract column", "Extract rows (range)", "Exit"],
+      extract_column_action: column_action,
+      extract_rows_action: rows_action
     )
 
     menu.run
 
-    assert_includes stdout.string, "Please choose 1 or 2."
-    assert_equal 0, action.runs
+    assert_includes stdout.string, "Please choose 1, 2, or 3."
+    assert_equal 0, column_action.runs
+    assert_equal 0, rows_action.runs
   end
 end

data/test/fixtures/sample_people_bad_tail.csv

@@ -0,0 +1,5 @@
+name,city
+Alice,London
+Bob,Paris
+Cara,Berlin
+"broken

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: csvops
 version: !ruby/object:Gem::Version
-  version: 0.1.0.alpha
+  version: 0.2.0.alpha
 platform: ruby
 authors:
 - Robert Hall
@@ -68,21 +68,30 @@ files:
 - bin/tool
 - csvops.gemspec
 - docs/release-v0.1.0-alpha.md
+- docs/release-v0.2.0-alpha.md
 - exe/csvtool
 - lib/csvtool/application/use_cases/run_extraction.rb
+- lib/csvtool/application/use_cases/run_row_extraction.rb
 - lib/csvtool/cli.rb
-- lib/csvtool/domain/extraction_session/column_selection.rb
-- lib/csvtool/domain/extraction_session/csv_source.rb
-- lib/csvtool/domain/extraction_session/extraction_options.rb
-- lib/csvtool/domain/extraction_session/extraction_session.rb
-- lib/csvtool/domain/extraction_session/extraction_value.rb
-- lib/csvtool/domain/extraction_session/output_destination.rb
-- lib/csvtool/domain/extraction_session/preview.rb
-- lib/csvtool/domain/extraction_session/separator.rb
+- lib/csvtool/domain/column_session/column_selection.rb
+- lib/csvtool/domain/column_session/column_session.rb
+- lib/csvtool/domain/column_session/csv_source.rb
+- lib/csvtool/domain/column_session/extraction_options.rb
+- lib/csvtool/domain/column_session/extraction_value.rb
+- lib/csvtool/domain/column_session/output_destination.rb
+- lib/csvtool/domain/column_session/preview.rb
+- lib/csvtool/domain/column_session/separator.rb
+- lib/csvtool/domain/row_session/row_output_destination.rb
+- lib/csvtool/domain/row_session/row_range.rb
+- lib/csvtool/domain/row_session/row_session.rb
+- lib/csvtool/domain/row_session/row_source.rb
 - lib/csvtool/infrastructure/csv/header_reader.rb
+- lib/csvtool/infrastructure/csv/row_streamer.rb
 - lib/csvtool/infrastructure/csv/value_streamer.rb
 - lib/csvtool/infrastructure/output/console_writer.rb
 - lib/csvtool/infrastructure/output/csv_file_writer.rb
+- lib/csvtool/infrastructure/output/csv_row_console_writer.rb
+- lib/csvtool/infrastructure/output/csv_row_file_writer.rb
 - lib/csvtool/interface/cli/errors/presenter.rb
 - lib/csvtool/interface/cli/menu_loop.rb
 - lib/csvtool/interface/cli/prompts/column_selector_prompt.rb
@@ -94,20 +103,28 @@ files:
 - lib/csvtool/services/preview_builder.rb
 - lib/csvtool/version.rb
 - test/csvtool/application/use_cases/run_extraction_test.rb
+- test/csvtool/application/use_cases/run_row_extraction_test.rb
 - test/csvtool/cli_test.rb
 - test/csvtool/cli_unit_test.rb
-- test/csvtool/domain/extraction_session/column_selection_test.rb
-- test/csvtool/domain/extraction_session/csv_source_test.rb
-- test/csvtool/domain/extraction_session/extraction_options_test.rb
-- test/csvtool/domain/extraction_session/extraction_session_test.rb
-- test/csvtool/domain/extraction_session/extraction_value_test.rb
-- test/csvtool/domain/extraction_session/output_destination_test.rb
-- test/csvtool/domain/extraction_session/preview_test.rb
-- test/csvtool/domain/extraction_session/separator_test.rb
+- test/csvtool/domain/column_session/column_selection_test.rb
+- test/csvtool/domain/column_session/column_session_test.rb
+- test/csvtool/domain/column_session/csv_source_test.rb
+- test/csvtool/domain/column_session/extraction_options_test.rb
+- test/csvtool/domain/column_session/extraction_value_test.rb
+- test/csvtool/domain/column_session/output_destination_test.rb
+- test/csvtool/domain/column_session/preview_test.rb
+- test/csvtool/domain/column_session/separator_test.rb
+- test/csvtool/domain/row_session/row_output_destination_test.rb
+- test/csvtool/domain/row_session/row_range_test.rb
+- test/csvtool/domain/row_session/row_session_test.rb
+- test/csvtool/domain/row_session/row_source_test.rb
 - test/csvtool/infrastructure/csv/header_reader_test.rb
+- test/csvtool/infrastructure/csv/row_streamer_test.rb
 - test/csvtool/infrastructure/csv/value_streamer_test.rb
 - test/csvtool/infrastructure/output/console_writer_test.rb
 - test/csvtool/infrastructure/output/csv_file_writer_test.rb
+- test/csvtool/infrastructure/output/csv_row_console_writer_test.rb
+- test/csvtool/infrastructure/output/csv_row_file_writer_test.rb
 - test/csvtool/interface/cli/errors/presenter_test.rb
 - test/csvtool/interface/cli/menu_loop_test.rb
 - test/csvtool/interface/cli/prompts/column_selector_prompt_test.rb
@@ -120,6 +137,7 @@ files:
 - test/fixtures/empty.csv
 - test/fixtures/sample_people.csv
 - test/fixtures/sample_people.tsv
+- test/fixtures/sample_people_bad_tail.csv
 - test/fixtures/sample_people_blanks.csv
 - test/fixtures/sample_people_colon.txt
 - test/fixtures/sample_people_many.csv

data/test/csvtool/domain/extraction_session/csv_source_test.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../../../test_helper"
-require "csvtool/domain/extraction_session/csv_source"
-require "csvtool/domain/extraction_session/separator"
-
-class CsvSourceTest < Minitest::Test
-  def test_stores_path_and_separator
-    separator = Csvtool::Domain::ExtractionSession::Separator.new(",")
-    source = Csvtool::Domain::ExtractionSession::CsvSource.new(path: "/tmp/a.csv", separator: separator)
-    assert_equal "/tmp/a.csv", source.path
-    assert_equal separator, source.separator
-  end
-end

data/test/csvtool/domain/extraction_session/extraction_session_test.rb

@@ -1,35 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../../../test_helper"
-require "csvtool/domain/extraction_session/extraction_session"
-require "csvtool/domain/extraction_session/csv_source"
-require "csvtool/domain/extraction_session/separator"
-require "csvtool/domain/extraction_session/column_selection"
-require "csvtool/domain/extraction_session/extraction_options"
-require "csvtool/domain/extraction_session/preview"
-require "csvtool/domain/extraction_session/extraction_value"
-require "csvtool/domain/extraction_session/output_destination"
-
-class ExtractionSessionTest < Minitest::Test
-  def test_state_transitions
-    session = Csvtool::Domain::ExtractionSession::ExtractionSession.start(
-      source: Csvtool::Domain::ExtractionSession::CsvSource.new(
-        path: "/tmp/in.csv",
-        separator: Csvtool::Domain::ExtractionSession::Separator.new(",")
-      ),
-      column_selection: Csvtool::Domain::ExtractionSession::ColumnSelection.new(name: "name"),
-      options: Csvtool::Domain::ExtractionSession::ExtractionOptions.new(skip_blanks: true, preview_limit: 10)
-    )
-
-    preview = Csvtool::Domain::ExtractionSession::Preview.new(
-      values: [Csvtool::Domain::ExtractionSession::ExtractionValue.new("Alice")]
-    )
-    session = session.with_preview(preview).confirm!.with_output_destination(
-      Csvtool::Domain::ExtractionSession::OutputDestination.console
-    )
-
-    assert_equal true, session.confirmed?
-    assert_equal preview, session.preview
-    assert_equal true, session.output_destination.console?
-  end
-end

data/test/csvtool/domain/extraction_session/preview_test.rb

@@ -1,18 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "../../../test_helper"
-require "csvtool/domain/extraction_session/preview"
-require "csvtool/domain/extraction_session/extraction_value"
-
-class PreviewTest < Minitest::Test
-  def test_exposes_size_and_string_values
-    values = [
-      Csvtool::Domain::ExtractionSession::ExtractionValue.new("Alice"),
-      Csvtool::Domain::ExtractionSession::ExtractionValue.new("Bob")
-    ]
-    preview = Csvtool::Domain::ExtractionSession::Preview.new(values: values)
-
-    assert_equal 2, preview.size
-    assert_equal %w[Alice Bob], preview.to_strings
-  end
-end